Textual improvements and fixes such as typos, casing, etc. (#1612)

[user/henk/code/inspircd.git] / src / coremods / core_xline / cmd_gline.cpp

diff --git a/src/coremods/core_xline/cmd_gline.cpp b/src/coremods/core_xline/cmd_gline.cpp
index 49932ba9d473b1ec9342423f9926e659d4d104bd..05068362fec3de3bd12e1968a1a7ac1d1c846fe6 100644 (file)
--- a/src/coremods/core_xline/cmd_gline.cpp
+++ b/src/coremods/core_xline/cmd_gline.cpp
@@ -26,12 +26,12 @@ CommandGline::CommandGline(Module* parent)
        : Command(parent, "GLINE", 1, 3)
 {
        flags_needed = 'o';
-       syntax = "<ident@host> [<duration> :<reason>]";
+       syntax = "<user@host> [<duration> :<reason>]";
 }
 
 /** Handle /GLINE
  */
-CmdResult CommandGline::Handle (const std::vector<std::string>& parameters, User *user)
+CmdResult CommandGline::Handle(User* user, const Params& parameters)
 {
        std::string target = parameters[0];
 
@@ -50,7 +50,7 @@ CmdResult CommandGline::Handle (const std::vector<std::string>& parameters, User
 
                if (ih.first.empty())
                {
-                       user->WriteNotice("*** Target not found");
+                       user->WriteNotice("*** Target not found.");
                        return CMD_FAILURE;
                }
 
@@ -60,24 +60,28 @@ CmdResult CommandGline::Handle (const std::vector<std::string>& parameters, User
 
                else if (target.find('!') != std::string::npos)
                {
-                       user->WriteNotice("*** G-Line cannot operate on nick!user@host masks");
+                       user->WriteNotice("*** G-line cannot operate on nick!user@host masks.");
                        return CMD_FAILURE;
                }
 
-               unsigned long duration = InspIRCd::Duration(parameters[1]);
+               unsigned long duration;
+               if (!InspIRCd::Duration(parameters[1], duration))
+               {
+                       user->WriteNotice("*** Invalid duration for G-line.");
+                       return CMD_FAILURE;
+               }
                GLine* gl = new GLine(ServerInstance->Time(), duration, user->nick.c_str(), parameters[2].c_str(), ih.first.c_str(), ih.second.c_str());
                if (ServerInstance->XLines->AddLine(gl, user))
                {
                        if (!duration)
                        {
-                               ServerInstance->SNO->WriteToSnoMask('x',"%s added permanent G-line for %s: %s",user->nick.c_str(),target.c_str(), parameters[2].c_str());
+                               ServerInstance->SNO->WriteToSnoMask('x', "%s added permanent G-line for %s: %s", user->nick.c_str(), target.c_str(), parameters[2].c_str());
                        }
                        else
                        {
-                               time_t c_requires_crap = duration + ServerInstance->Time();
-                               std::string timestr = InspIRCd::TimeString(c_requires_crap);
-                               ServerInstance->SNO->WriteToSnoMask('x',"%s added timed G-line for %s, expires on %s: %s",user->nick.c_str(),target.c_str(),
-                                               timestr.c_str(), parameters[2].c_str());
+                               ServerInstance->SNO->WriteToSnoMask('x', "%s added timed G-line for %s, expires in %s (on %s): %s",
+                                       user->nick.c_str(), target.c_str(), InspIRCd::DurationString(duration).c_str(),
+                                       InspIRCd::TimeString(ServerInstance->Time() + duration).c_str(), parameters[2].c_str());
                        }
 
                        ServerInstance->XLines->ApplyLines();
@@ -85,19 +89,21 @@ CmdResult CommandGline::Handle (const std::vector<std::string>& parameters, User
                else
                {
                        delete gl;
-                       user->WriteNotice("** G-Line for " + target + " already exists");
+                       user->WriteNotice("** G-line for " + target + " already exists.");
                }
 
        }
        else
        {
-               if (ServerInstance->XLines->DelLine(target.c_str(),"G",user))
+               std::string reason;
+
+               if (ServerInstance->XLines->DelLine(target.c_str(), "G", reason, user))
                {
-                       ServerInstance->SNO->WriteToSnoMask('x',"%s removed G-line on %s",user->nick.c_str(),target.c_str());
+                       ServerInstance->SNO->WriteToSnoMask('x', "%s removed G-line on %s: %s", user->nick.c_str(), target.c_str(), reason.c_str());
                }
                else
                {
-                       user->WriteNotice("*** G-Line " + target + " not found in list, try /stats g.");
+                       user->WriteNotice("*** G-line " + target + " not found on the list.");
                }
        }