Only parse valid durations, don't treat invalid multipliers as seconds (#1538)

[user/henk/code/inspircd.git] / src / coremods / core_xline / cmd_qline.cpp

diff --git a/src/coremods/core_xline/cmd_qline.cpp b/src/coremods/core_xline/cmd_qline.cpp
index 6dc0da9bad7ec210e62fbe690a6bd39840ae9c9d..893c8d2139b8675c5af82313d0644452ae9b289c 100644 (file)
--- a/src/coremods/core_xline/cmd_qline.cpp
+++ b/src/coremods/core_xline/cmd_qline.cpp
@@ -30,7 +30,7 @@ CommandQline::CommandQline(Module* parent)
        syntax = "<nick> [<duration> :<reason>]";
 }
 
-CmdResult CommandQline::Handle (const std::vector<std::string>& parameters, User *user)
+CmdResult CommandQline::Handle(User* user, const Params& parameters)
 {
        if (parameters.size() >= 3)
        {
@@ -44,7 +44,12 @@ CmdResult CommandQline::Handle (const std::vector<std::string>& parameters, User
                        return CMD_FAILURE;
                }
 
-               unsigned long duration = InspIRCd::Duration(parameters[1]);
+               unsigned long duration;
+               if (!InspIRCd::Duration(parameters[1], duration))
+               {
+                       user->WriteNotice("*** Invalid duration for Q-line");
+                       return CMD_FAILURE;
+               }
                QLine* ql = new QLine(ServerInstance->Time(), duration, user->nick.c_str(), parameters[2].c_str(), parameters[0].c_str());
                if (ServerInstance->XLines->AddLine(ql,user))
                {