Convert more by-values to const references, optimise ConfigReader a bit

[user/henk/code/inspircd.git] / src / cull_list.cpp

diff --git a/src/cull_list.cpp b/src/cull_list.cpp
index 5a589b144efcfe8ee67dd2330473de1758a12cc5..b7254fd0b0d3bd3ba3b4a6fed6fe69fd2986257c 100644 (file)
--- a/src/cull_list.cpp
+++ b/src/cull_list.cpp
@@ -43,17 +43,56 @@ using namespace std;
 #include "commands.h"
 #include "xline.h"
 #include "inspstring.h"
+#include "inspircd.h"
 #include "helperfuncs.h"
 #include "hashcomp.h"
 #include "typedefs.h"
 #include "cull_list.h"
 
-CullItem::CullItem(userrec* u, std::string r)
+extern InspIRCd* ServerInstance;
+extern user_hash clientlist;
+
+bool CullList::IsValid(userrec* user)
+{
+       time_t esignon = 0;
+       std::map<userrec*,time_t>::iterator es = exempt.find(user);
+       if (es != exempt.end())
+               esignon = es->second;
+
+       for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
+       {
+               /*
+                * BUGFIX
+                *
+                * Because there is an undetermined period of time between a user existing,
+                * and this function being called, we have to check for the following condition:
+                *
+                * Between CullList::AddItem(u) being called, and CullList::IsValid(u) being called,
+                * the user with the pointer u has quit, but only to be REPLACED WITH A NEW USER WHO
+                * BECAUSE OF ALLOCATION RULES, HAS THE SAME MEMORY ADDRESS! To prevent this, we
+                * cross reference each pointer to the user's signon time, and if the signon times
+                * do not match, we return false here to indicate this user is NOT valid as it
+                * seems to differ from the pointer snapshot we got a few seconds earlier. Should
+                * prevent a few random crashes during netsplits.
+                */
+               if (user == u->second)
+                       return (u->second->signon == esignon);
+       }
+       return false;
+}
+
+CullItem::CullItem(userrec* u, std::string &r)
 {
         this->user = u;
         this->reason = r;
 }
 
+CullItem::CullItem(userrec* u, const char* r)
+{
+       this->user = u;
+       this->reason = r;
+}
+
 userrec* CullItem::GetUser()
 {
         return this->user;
@@ -70,13 +109,23 @@ CullList::CullList()
         exempt.clear();
 }
 
-void CullList::AddItem(userrec* user, std::string reason)
+void CullList::AddItem(userrec* user, std::string &reason)
 {
        if (exempt.find(user) == exempt.end())
        {
                CullItem item(user,reason);
                list.push_back(item);
-               exempt[user] = 1;
+               exempt[user] = user->signon;
+       }
+}
+
+void CullList::AddItem(userrec* user, const char* reason)
+{
+       if (exempt.find(user) == exempt.end())
+       {
+               CullItem item(user,reason);
+               list.push_back(item);
+               exempt[user] = user->signon;
        }
 }
 
@@ -85,12 +134,30 @@ int CullList::Apply()
         int n = 0;
         while (list.size())
         {
-               std::vector<CullItem>::iterator a = list.begin();
-               userrec* u = a->GetUser();
-               std::string reason = a->GetReason();
-               kill_link(u,reason.c_str());
-               list.erase(list.begin());
-               n++;
+               std::vector<CullItem>::iterator a = list.begin();
+               userrec* u = a->GetUser();
+               /* Because ServerInstance->DoOneIteration can
+                * take the user away from us in the middle of
+                * our operation, we should check to see if this
+                * pointer is still valid by iterating the hash.
+                * It's expensive, yes, but the DoOneIteration
+                * call stops it being horrendously bad.
+                */
+               if (IsValid(u))
+               {
+                       kill_link(u,a->GetReason().c_str());
+                       list.erase(list.begin());
+                       /* So that huge numbers of quits dont block,
+                        * we yield back to our mainloop every 15
+                        * iterations.
+                        * The DoOneIteration call basically acts
+                        * like a software threading mechanism.
+                        */
+                       if (((n++) % 15) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
+               }
         }
         return n;
 }