]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/dns.cpp
Change Extensible to use strongly typed entries
[user/henk/code/inspircd.git] / src / dns.cpp
index 625951ee50e8d19cc00b26e94d1b49a83dc80cc1..94a01e64c9cedbf60bfa70c3dfaee096bf07adce 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
@@ -11,6 +11,8 @@
  * ---------------------------------------------------
  */
 
+/* $Core */
+
 /*
 dns.cpp - Nonblocking DNS functions.
 Very very loosely based on the firedns library,
@@ -21,22 +23,22 @@ Please do not assume that firedns works like this,
 looks like this, walks like this or tastes like this.
 */
 
+#ifndef WIN32
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <errno.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
-#include "dns.h"
+#else
+#include "inspircd_win32wrapper.h"
+#include "inspircd_se_config.h"
+#endif
+
 #include "inspircd.h"
 #include "socketengine.h"
 #include "configreader.h"
 #include "socket.h"
 
-using irc::sockets::insp_sockaddr;
-using irc::sockets::insp_inaddr;
-using irc::sockets::insp_ntoa;
-using irc::sockets::insp_aton;
-
 /** Masks to mask off the responses we get from the DNSRequest methods
  */
 enum QueryInfo
@@ -61,9 +63,8 @@ enum QueryFlags
 
 /** Represents a dns resource record (rr)
  */
-class ResourceRecord
+struct ResourceRecord
 {
- public:
        QueryType       type;           /* Record type */
        unsigned int    rr_class;       /* Record class */
        unsigned long   ttl;            /* Time to live */
@@ -92,44 +93,48 @@ class DNSRequest
        unsigned char*  res;            /* Result processing buffer */
        unsigned int    rr_class;       /* Request class */
        QueryType       type;           /* Request type */
-       insp_inaddr     myserver;       /* DNS server address*/
        DNS*            dnsobj;         /* DNS caller (where we get our FD from) */
        unsigned long   ttl;            /* Time to live */
        std::string     orig;           /* Original requested name/ip */
+       InspIRCd*       ServerInstance;
 
-       DNSRequest(InspIRCd* Instance, DNS* dns, insp_inaddr server, int id, const std::string &original);
+       DNSRequest(InspIRCd* Instance, DNS* dns, int id, const std::string &original);
        ~DNSRequest();
        DNSInfo ResultIsReady(DNSHeader &h, int length);
        int SendRequests(const DNSHeader *header, const int length, QueryType qt);
 };
 
-class CacheTimer : public InspTimer
+class CacheTimer : public Timer
 {
  private:
        InspIRCd* ServerInstance;
        DNS* dns;
  public:
        CacheTimer(InspIRCd* Instance, DNS* thisdns)
-               : InspTimer(3600, Instance->Time(), true), ServerInstance(Instance), dns(thisdns) { }
+               : Timer(3600, Instance->Time(), true), ServerInstance(Instance), dns(thisdns) { }
 
-       virtual void Tick(time_t TIME)
+       virtual void Tick(time_t)
        {
                dns->PruneCache();
        }
 };
 
-class RequestTimeout : public InspTimer
+class RequestTimeout : public Timer
 {
        InspIRCd* ServerInstance;
        DNSRequest* watch;
        int watchid;
  public:
-       RequestTimeout(unsigned long n, InspIRCd* SI, DNSRequest* watching, int id) : InspTimer(n, time(NULL)), ServerInstance(SI), watch(watching), watchid(id)
+       RequestTimeout(unsigned long n, InspIRCd* SI, DNSRequest* watching, int id) : Timer(n, SI->Time()), ServerInstance(SI), watch(watching), watchid(id)
        {
-               ServerInstance->Log(DEBUG, "New DNS timeout set on %08x", watching);
+       }
+       ~RequestTimeout()
+       {
+               if (ServerInstance->Res)
+                       Tick(0);
        }
 
-       void Tick(time_t TIME)
+       void Tick(time_t)
        {
                if (ServerInstance->Res->requests[watchid] == watch)
                {
@@ -142,21 +147,17 @@ class RequestTimeout : public InspTimer
                        }
                        ServerInstance->Res->requests[watchid] = NULL;
                        delete watch;
-                       ServerInstance->Log(DEBUG, "DNS timeout on %08x squished pointer", watch);
-                       return;
                }
-               ServerInstance->Log(DEBUG, "DNS timeout on %08x: result already received!", watch);
        }
 };
 
 /* Allocate the processing buffer */
-DNSRequest::DNSRequest(InspIRCd* Instance, DNS* dns, insp_inaddr server, int id, const std::string &original) : dnsobj(dns)
+DNSRequest::DNSRequest(InspIRCd* Instance, DNS* dns, int rid, const std::string &original) : dnsobj(dns), ServerInstance(Instance)
 {
        res = new unsigned char[512];
        *res = 0;
-       memcpy(&myserver, &server, sizeof(insp_inaddr));
        orig = original;
-       RequestTimeout* RT = new RequestTimeout(Instance->Config->dns_timeout ? Instance->Config->dns_timeout : 5, Instance, this, id);
+       RequestTimeout* RT = new RequestTimeout(Instance->Config->dns_timeout ? Instance->Config->dns_timeout : 5, Instance, this, rid);
        Instance->Timers->AddTimer(RT); /* The timer manager frees this */
 }
 
@@ -210,27 +211,37 @@ inline void DNS::EmptyHeader(unsigned char *output, const DNSHeader *header, con
 /** Send requests we have previously built down the UDP socket */
 int DNSRequest::SendRequests(const DNSHeader *header, const int length, QueryType qt)
 {
-       insp_sockaddr addr;
+       ServerInstance->Logs->Log("RESOLVER", DEBUG,"DNSRequest::SendRequests");
+
        unsigned char payload[sizeof(DNSHeader)];
 
        this->rr_class = 1;
        this->type = qt;
-               
+
        DNS::EmptyHeader(payload,header,length);
 
-       memset(&addr,0,sizeof(addr));
-#ifdef IPV6
-       memcpy(&addr.sin6_addr,&myserver,sizeof(addr.sin6_addr));
-       addr.sin6_family = AF_FAMILY;
-       addr.sin6_port = htons(DNS::QUERY_PORT);
-#else
-       memcpy(&addr.sin_addr.s_addr,&myserver,sizeof(addr.sin_addr));
-       addr.sin_family = AF_FAMILY;
-       addr.sin_port = htons(DNS::QUERY_PORT);
-#endif
-       if (sendto(dnsobj->GetFd(), payload, length + 12, 0, (sockaddr *) &addr, sizeof(addr)) == -1)
-               return -1;
+       if (this->dnsobj->socketfamily == AF_INET6)
+       {
+               sockaddr_in6 addr;
+               memset(&addr,0,sizeof(addr));
+               memcpy(&addr.sin6_addr,&dnsobj->myserver6,sizeof(addr.sin6_addr));
+               addr.sin6_family = AF_INET6;
+               addr.sin6_port = htons(DNS::QUERY_PORT);
+               if (ServerInstance->SE->SendTo(dnsobj, payload, length + 12, 0, (sockaddr *) &addr, sizeof(addr)) != length+12)
+                       return -1;
+       }
+       else
+       {
+               sockaddr_in addr;
+               memset(&addr,0,sizeof(addr));
+               memcpy(&addr.sin_addr.s_addr,&dnsobj->myserver4,sizeof(addr.sin_addr));
+               addr.sin_family = AF_INET;
+               addr.sin_port = htons(DNS::QUERY_PORT);
+               if (ServerInstance->SE->SendTo(dnsobj, (const char*)payload, length + 12, 0, (sockaddr *) &addr, sizeof(addr)) != length+12)
+                       return -1;
+       }
 
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"Sent OK");
        return 0;
 }
 
@@ -240,7 +251,7 @@ DNSRequest* DNS::AddQuery(DNSHeader *header, int &id, const char* original)
        /* Is the DNS connection down? */
        if (this->GetFd() == -1)
                return NULL;
-       
+
        /* Create an id */
        id = this->PRNG() & DNS::MAX_REQUEST_ID;
 
@@ -248,7 +259,7 @@ DNSRequest* DNS::AddQuery(DNSHeader *header, int &id, const char* original)
        while (requests[id])
                id = this->PRNG() & DNS::MAX_REQUEST_ID;
 
-       DNSRequest* req = new DNSRequest(ServerInstance, this, this->myserver, id, original);
+       DNSRequest* req = new DNSRequest(ServerInstance, this, id, original);
 
        header->id[0] = req->id[0] = id >> 8;
        header->id[1] = req->id[1] = id & 0xFF;
@@ -290,21 +301,20 @@ int DNS::PruneCache()
 
        delete this->cache;
        this->cache = newcache;
-       ServerInstance->Log(DEBUG,"Prune %d expired cache items", n);
        return n;
 }
 
 void DNS::Rehash()
 {
-       insp_inaddr addr;
        ip6munge = false;
+       int portpass = 0;
 
        if (this->GetFd() > -1)
        {
                if (ServerInstance && ServerInstance->SE)
                        ServerInstance->SE->DelFd(this);
-               shutdown(this->GetFd(), 2);
-               close(this->GetFd());
+               ServerInstance->SE->Shutdown(this, 2);
+               ServerInstance->SE->Close(this);
                this->SetFd(-1);
 
                /* Rehash the cache */
@@ -316,90 +326,69 @@ void DNS::Rehash()
                this->cache = new dnscache();
        }
 
-       if (insp_aton(ServerInstance->Config->DNSServer,&addr) > 0)
-       {
-               memcpy(&myserver,&addr,sizeof(insp_inaddr));
-               if ((strstr(ServerInstance->Config->DNSServer,"::ffff:") == (char*)&ServerInstance->Config->DNSServer) ||  (strstr(ServerInstance->Config->DNSServer,"::FFFF:") == (char*)&ServerInstance->Config->DNSServer))
-               {
-                       ServerInstance->Log(DEFAULT,"WARNING: Using IPv4 addresses over IPv6 forces some DNS checks to be disabled.");
-                       ServerInstance->Log(DEFAULT,"         This should not cause a problem, however it is recommended you migrate");
-                       ServerInstance->Log(DEFAULT,"         to a true IPv6 environment.");
-                       this->ip6munge = true;
-               }
-               ServerInstance->Log(DEBUG,"Added nameserver '%s'",ServerInstance->Config->DNSServer);
-       }
-       else
+       if ((strstr(ServerInstance->Config->DNSServer,"::ffff:") == (char*)&ServerInstance->Config->DNSServer) ||  (strstr(ServerInstance->Config->DNSServer,"::FFFF:") == (char*)&ServerInstance->Config->DNSServer))
        {
-               ServerInstance->Log(DEBUG,"GACK! insp_aton says the nameserver '%s' is invalid!",ServerInstance->Config->DNSServer);
+               ServerInstance->Logs->Log("RESOLVER",DEFAULT,"WARNING: Using IPv4 addresses over IPv6 forces some DNS checks to be disabled.");
+               ServerInstance->Logs->Log("RESOLVER",DEFAULT,"         This should not cause a problem, however it is recommended you migrate");
+               ServerInstance->Logs->Log("RESOLVER",DEFAULT,"         to a true IPv6 environment.");
+               this->ip6munge = true;
        }
 
-       /* Initialize mastersocket */
-       this->SetFd(socket(PF_PROTOCOL, SOCK_DGRAM, 0));
-       if (this->GetFd() != -1)
+       this->socketfamily = AF_INET;
+       if (strchr(ServerInstance->Config->DNSServer,':'))
        {
-               /* Did it succeed? */
-               if (fcntl(this->GetFd(), F_SETFL, O_NONBLOCK) != 0)
-               {
-                       /* Couldn't make the socket nonblocking */
-                       shutdown(this->GetFd(),2);
-                       close(this->GetFd());
-                       this->SetFd(-1);
-               }
+               this->socketfamily = AF_INET6;
+               inet_pton(AF_INET6, ServerInstance->Config->DNSServer, &this->myserver6);
        }
        else
        {
-               ServerInstance->Log(DEBUG,"I cant socket() this socket! (%s)",strerror(errno));
+               inet_aton(ServerInstance->Config->DNSServer, &this->myserver4);
+               portpass = -1;
        }
 
+       /* Initialize mastersocket */
+       int s = irc::sockets::OpenTCPSocket(ServerInstance->Config->DNSServer, SOCK_DGRAM);
+       this->SetFd(s);
+       ServerInstance->SE->NonBlocking(this->GetFd());
+
        /* Have we got a socket and is it nonblocking? */
        if (this->GetFd() != -1)
        {
-#ifdef IPV6
-               insp_sockaddr addr;
-               memset(&addr,0,sizeof(addr));
-               addr.sin6_family = AF_FAMILY;
-               addr.sin6_port = 0;
-               addr.sin6_addr = in6addr_any;
-#else
-               insp_sockaddr addr;
-               memset(&addr,0,sizeof(addr));
-               addr.sin_family = AF_FAMILY;
-               addr.sin_port = 0;
-               addr.sin_addr.s_addr = INADDR_ANY;
-#endif
-               /* Bind the port */
-               if (bind(this->GetFd(),(sockaddr *)&addr,sizeof(addr)) != 0)
+               /* Bind the port - port 0 INADDR_ANY */
+               if (!ServerInstance->BindSocket(this->GetFd(), portpass, "", false))
                {
                        /* Failed to bind */
-                       ServerInstance->Log(DEBUG,"Cant bind DNS fd");
-                       shutdown(this->GetFd(),2);
-                       close(this->GetFd());
+                       ServerInstance->Logs->Log("RESOLVER",DEBUG,"Error binding dns socket");
+                       ServerInstance->SE->Shutdown(this, 2);
+                       ServerInstance->SE->Close(this);
                        this->SetFd(-1);
                }
 
                if (this->GetFd() >= 0)
                {
-                       ServerInstance->Log(DEBUG,"Add master socket %d",this->GetFd());
                        /* Hook the descriptor into the socket engine */
                        if (ServerInstance && ServerInstance->SE)
                        {
                                if (!ServerInstance->SE->AddFd(this))
                                {
-                                       ServerInstance->Log(DEFAULT,"Internal error starting DNS - hostnames will NOT resolve.");
-                                       shutdown(this->GetFd(),2);
-                                       close(this->GetFd());
+                                       ServerInstance->Logs->Log("RESOLVER",DEFAULT,"Internal error starting DNS - hostnames will NOT resolve.");
+                                       ServerInstance->SE->Shutdown(this, 2);
+                                       ServerInstance->SE->Close(this);
                                        this->SetFd(-1);
                                }
                        }
                }
        }
+       else
+       {
+               ServerInstance->Logs->Log("RESOLVER",DEBUG,"Error creating dns socket");
+       }
 }
 
 /** Initialise the DNS UDP socket so that we can send requests */
 DNS::DNS(InspIRCd* Instance) : ServerInstance(Instance)
 {
-       ServerInstance->Log(DEBUG,"DNS::DNS: Instance = %08x",Instance);
-
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"DNS::DNS");
        /* Clear the Resolver class table */
        memset(Classes,0,sizeof(Classes));
 
@@ -413,7 +402,7 @@ DNS::DNS(InspIRCd* Instance) : ServerInstance(Instance)
        /* DNS::Rehash() sets this to a valid ptr
         */
        this->cache = NULL;
-       
+
        /* Again, DNS::Rehash() sets this to a
         * valid value
         */
@@ -471,7 +460,7 @@ int DNS::GetIP(const char *name)
        DNSHeader h;
        int id;
        int length;
-       
+
        if ((length = this->MakePayload(name, DNS_QUERY_A, 1, (unsigned char*)&h.payload)) == -1)
                return -1;
 
@@ -519,38 +508,6 @@ int DNS::GetCName(const char *alias)
        return id;
 }
 
-/** Start lookup of an IP address to a hostname */
-int DNS::GetName(const insp_inaddr *ip)
-{
-       char query[128];
-       DNSHeader h;
-       int id;
-       int length;
-
-#ifdef IPV6
-       unsigned char* c = (unsigned char*)&ip->s6_addr;
-       if (c[0] == 0 && c[1] == 0 && c[2] == 0 && c[3] == 0 &&
-           c[4] == 0 && c[5] == 0 && c[6] == 0 && c[7] == 0 &&
-           c[8] == 0 && c[9] == 0 && c[10] == 0xFF && c[11] == 0xFF)
-               sprintf(query,"%d.%d.%d.%d.in-addr.arpa",c[15],c[14],c[13],c[12]);
-       else
-               DNS::MakeIP6Int(query, (in6_addr*)ip);
-#else
-       unsigned char* c = (unsigned char*)&ip->s_addr;
-       sprintf(query,"%d.%d.%d.%d.in-addr.arpa",c[3],c[2],c[1],c[0]);
-#endif
-
-       if ((length = this->MakePayload(query, DNS_QUERY_PTR, 1, (unsigned char*)&h.payload)) == -1)
-               return -1;
-
-       DNSRequest* req = this->AddQuery(&h, id, insp_ntoa(*ip));
-
-       if ((!req) || (req->SendRequests(&h, length, DNS_QUERY_PTR) == -1))
-               return -1;
-
-       return id;
-}
-
 /** Start lookup of an IP address to a hostname */
 int DNS::GetNameForce(const char *ip, ForceProtocol fp)
 {
@@ -558,7 +515,7 @@ int DNS::GetNameForce(const char *ip, ForceProtocol fp)
        DNSHeader h;
        int id;
        int length;
-#ifdef SUPPORT_IP6LINKS
+
        if (fp == PROTOCOL_IPV6)
        {
                in6_addr i;
@@ -571,7 +528,6 @@ int DNS::GetNameForce(const char *ip, ForceProtocol fp)
                        return -1;
        }
        else
-#endif
        {
                in_addr i;
                if (inet_aton(ip, &i))
@@ -584,8 +540,6 @@ int DNS::GetNameForce(const char *ip, ForceProtocol fp)
                        return -1;
        }
 
-       ServerInstance->Log(DEBUG,"DNS::GetNameForce: %s %d",query, fp);
-
        if ((length = this->MakePayload(query, DNS_QUERY_PTR, 1, (unsigned char*)&h.payload)) == -1)
                return -1;
 
@@ -601,7 +555,6 @@ int DNS::GetNameForce(const char *ip, ForceProtocol fp)
  */
 void DNS::MakeIP6Int(char* query, const in6_addr *ip)
 {
-#ifdef SUPPORT_IP6LINKS
        const char* hex = "0123456789abcdef";
        for (int index = 31; index >= 0; index--) /* for() loop steps twice per byte */
        {
@@ -614,9 +567,6 @@ void DNS::MakeIP6Int(char* query, const in6_addr *ip)
                *query++ = '.'; /* Seperator */
        }
        strcpy(query,"ip6.arpa"); /* Suffix the string */
-#else
-       *query = 0;
-#endif
 }
 
 /** Return the next id which is ready, and the result attached to it */
@@ -626,21 +576,17 @@ DNSResult DNS::GetResult()
        DNSHeader header;
        DNSRequest *req;
        unsigned char buffer[sizeof(DNSHeader)];
-       sockaddr from;
-       socklen_t x = sizeof(from);
-       const char* ipaddr_from = "";
+       irc::sockets::sockaddrs from;
+       socklen_t x = this->socketfamily == AF_INET ? sizeof(sockaddr_in) : sizeof(sockaddr_in6);
+       const char* ipaddr_from;
        unsigned short int port_from = 0;
 
-       int length = recvfrom(this->GetFd(),buffer,sizeof(DNSHeader),0,&from,&x);
-
-       if (length < 0)
-               ServerInstance->Log(DEBUG,"Error in recvfrom()! (%s)",strerror(errno));
+       int length = ServerInstance->SE->RecvFrom(this, (char*)buffer, sizeof(DNSHeader), 0, &from.sa, &x);
 
        /* Did we get the whole header? */
        if (length < 12)
        {
                /* Nope - something screwed up. */
-               ServerInstance->Log(DEBUG,"Whole header not read!");
                return DNSResult(-1,"",0,"");
        }
 
@@ -653,13 +599,17 @@ DNSResult DNS::GetResult()
         *
         * -- Thanks jilles for pointing this one out.
         */
-#ifdef IPV6
-       ipaddr_from = insp_ntoa(((sockaddr_in6*)&from)->sin6_addr);
-       port_from = ntohs(((sockaddr_in6*)&from)->sin6_port);
-#else
-       ipaddr_from = insp_ntoa(((sockaddr_in*)&from)->sin_addr);
-       port_from = ntohs(((sockaddr_in*)&from)->sin_port);
-#endif
+       char nbuf[MAXBUF];
+       if (this->socketfamily == AF_INET6)
+       {
+               ipaddr_from = inet_ntop(AF_INET6, &from.in6.sin6_addr, nbuf, sizeof(nbuf));
+               port_from = ntohs(from.in6.sin6_port);
+       }
+       else
+       {
+               ipaddr_from = inet_ntoa(from.in4.sin_addr);
+               port_from = ntohs(from.in4.sin_port);
+       }
 
        /* We cant perform this security check if you're using 4in6.
         * Tough luck to you, choose one or't other!
@@ -668,7 +618,6 @@ DNSResult DNS::GetResult()
        {
                if ((port_from != DNS::QUERY_PORT) || (strcasecmp(ipaddr_from, ServerInstance->Config->DNSServer)))
                {
-                       ServerInstance->Log(DEBUG,"port %d is not 53, or %s is not %s",port_from, ipaddr_from, ServerInstance->Config->DNSServer);
                        return DNSResult(-1,"",0,"");
                }
        }
@@ -686,7 +635,6 @@ DNSResult DNS::GetResult()
        if (!requests[this_id])
        {
                /* Somehow we got a DNS response for a request we never made... */
-               ServerInstance->Log(DEBUG,"DNS: got a response for a query we didnt send with fd=%d queryid=%d",this->GetFd(),this_id);
                return DNSResult(-1,"",0,"");
        }
        else
@@ -731,15 +679,7 @@ DNSResult DNS::GetResult()
 
                        case DNS_QUERY_AAAA:
                        {
-                               snprintf(formatted,40,"%x:%x:%x:%x:%x:%x:%x:%x",
-                                               (ntohs(data.first[0]) + ntohs(data.first[1] << 8)),
-                                               (ntohs(data.first[2]) + ntohs(data.first[3] << 8)),
-                                               (ntohs(data.first[4]) + ntohs(data.first[5] << 8)),
-                                               (ntohs(data.first[6]) + ntohs(data.first[7] << 8)),
-                                               (ntohs(data.first[8]) + ntohs(data.first[9] << 8)),
-                                               (ntohs(data.first[10]) + ntohs(data.first[11] << 8)),
-                                               (ntohs(data.first[12]) + ntohs(data.first[13] << 8)),
-                                               (ntohs(data.first[14]) + ntohs(data.first[15] << 8)));
+                               inet_ntop(AF_INET6, data.first, formatted, sizeof(formatted));
                                char* c = strstr(formatted,":0:");
                                if (c != NULL)
                                {
@@ -760,7 +700,7 @@ DNSResult DNS::GetResult()
                                 * as the last parameter on the line with a value ":1".
                                 */
                                if (*formatted == ':')
-                                       resultstr = "0" + resultstr;
+                                       resultstr.insert(0, "0");
                        }
                        break;
 
@@ -773,9 +713,7 @@ DNSResult DNS::GetResult()
                        break;
 
                        default:
-                               ServerInstance->Log(DEBUG,"WARNING: Somehow we made a request for a DNS_QUERY_PTR4 or DNS_QUERY_PTR6, but these arent real rr types!");
                        break;
-                       
                }
 
                /* Build the reply with the id and hostname/ip in it */
@@ -797,6 +735,8 @@ DNSInfo DNSRequest::ResultIsReady(DNSHeader &header, int length)
        /* This is just to keep _FORTIFY_SOURCE happy */
        rr.type = DNS_QUERY_NONE;
        rr.rdlength = 0;
+       rr.ttl = 1;     /* GCC is a whiney bastard -- see the XXX below. */
+       rr.rr_class = 0; /* Same for VC++ */
 
        if (!(header.flags1 & FLAGS_MASK_QR))
                return std::make_pair((unsigned char*)NULL,"Not a query result");
@@ -854,8 +794,11 @@ DNSInfo DNSRequest::ResultIsReady(DNSHeader &header, int length)
                if (length - i < 10)
                        return std::make_pair((unsigned char*)NULL,"Incorrectly sized DNS reply");
 
+               /* XXX: We actually initialise 'rr' here including its ttl field */
                DNS::FillResourceRecord(&rr,&header.payload[i]);
+
                i += 10;
+               ServerInstance->Logs->Log("RESOLVER",DEBUG,"Resolver: rr.type is %d and this.type is %d rr.class %d this.class %d", rr.type, this->type, rr.rr_class, this->rr_class);
                if (rr.type != this->type)
                {
                        curanswer++;
@@ -871,7 +814,7 @@ DNSInfo DNSRequest::ResultIsReady(DNSHeader &header, int length)
                break;
        }
        if ((unsigned int)curanswer == header.ancount)
-               return std::make_pair((unsigned char*)NULL,"No valid answers");
+               return std::make_pair((unsigned char*)NULL,"No A, AAAA or PTR type answers (" + ConvToStr(header.ancount) + " answers)");
 
        if (i + rr.rdlength > (unsigned int)length)
                return std::make_pair((unsigned char*)NULL,"Resource record larger than stated");
@@ -927,16 +870,17 @@ DNSInfo DNSRequest::ResultIsReady(DNSHeader &header, int length)
                        res[rr.rdlength] = 0;
                break;
        }
-       return std::make_pair(res,"No error");;
+       return std::make_pair(res,"No error");
 }
 
 /** Close the master socket */
 DNS::~DNS()
 {
-       shutdown(this->GetFd(), 2);
-       close(this->GetFd());
+       ServerInstance->SE->Shutdown(this, 2);
+       ServerInstance->SE->Close(this);
        ServerInstance->Timers->DelTimer(this->PruneTimer);
-       delete this->PruneTimer;
+       if (cache)
+               delete cache;
 }
 
 CachedQuery* DNS::GetCache(const std::string &source)
@@ -947,7 +891,7 @@ CachedQuery* DNS::GetCache(const std::string &source)
        else
                return NULL;
 }
-               
+
 void DNS::DelCache(const std::string &source)
 {
        cache->erase(source.c_str());
@@ -962,8 +906,7 @@ void Resolver::TriggerCachedResult()
 /** High level abstraction of dns used by application at large */
 Resolver::Resolver(InspIRCd* Instance, const std::string &source, QueryType qt, bool &cached, Module* creator) : ServerInstance(Instance), Creator(creator), input(source), querytype(qt)
 {
-       ServerInstance->Log(DEBUG,"Instance: %08x %08x",Instance, ServerInstance);
-
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"Resolver::Resolver");
        cached = false;
 
        CQ = ServerInstance->Res->GetCache(source);
@@ -972,39 +915,21 @@ Resolver::Resolver(InspIRCd* Instance, const std::string &source, QueryType qt,
                time_left = CQ->CalcTTLRemaining();
                if (!time_left)
                {
-                       ServerInstance->Log(DEBUG,"Cached but EXPIRED result: %s", CQ->data.c_str());
                        ServerInstance->Res->DelCache(source);
                }
                else
                {
                        cached = true;
-                       ServerInstance->Log(DEBUG,"Cached result: %s", CQ->data.c_str());
                        return;
                }
        }
 
-       insp_inaddr binip;
-
        switch (querytype)
        {
                case DNS_QUERY_A:
                        this->myid = ServerInstance->Res->GetIP(source.c_str());
                break;
 
-               case DNS_QUERY_PTR:
-                       if (insp_aton(source.c_str(), &binip) > 0)
-                       {
-                               /* Valid ip address */
-                               this->myid = ServerInstance->Res->GetName(&binip);
-                       }
-                       else
-                       {
-                               this->OnError(RESOLVER_BADIP, "Bad IP address for reverse lookup");
-                               throw ModuleException("Resolver: Bad IP address");
-                               return;
-                       }
-               break;
-
                case DNS_QUERY_PTR4:
                        querytype = DNS_QUERY_PTR;
                        this->myid = ServerInstance->Res->GetNameForce(source.c_str(), PROTOCOL_IPV4);
@@ -1029,18 +954,19 @@ Resolver::Resolver(InspIRCd* Instance, const std::string &source, QueryType qt,
        }
        if (this->myid == -1)
        {
-               ServerInstance->Log(DEBUG,"Resolver::Resolver: Could not get an id!");
                this->OnError(RESOLVER_NSDOWN, "Nameserver is down");
                throw ModuleException("Resolver: Couldnt get an id to make a request");
                /* We shouldnt get here really */
                return;
        }
-
-       ServerInstance->Log(DEBUG,"Resolver::Resolver: this->myid=%d",this->myid);
+       else
+       {
+               ServerInstance->Logs->Log("RESOLVER",DEBUG,"DNS request id %d", this->myid);
+       }
 }
 
 /** Called when an error occurs */
-void Resolver::OnError(ResolverError e, const std::string &errormessage)
+void Resolver::OnError(ResolverError, const std::string&)
 {
        /* Nothing in here */
 }
@@ -1063,10 +989,17 @@ Module* Resolver::GetCreator()
 }
 
 /** Process a socket read event */
-void DNS::HandleEvent(EventType et, int errornum)
+void DNS::HandleEvent(EventType, int)
 {
        /* Fetch the id and result of the next available packet */
-       DNSResult res = this->GetResult();
+       DNSResult res(0,"",0,"");
+       res.id = 0;
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"Handle DNS event");
+
+       res = this->GetResult();
+
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"Result id %d", res.id);
+
        /* Is there a usable request id? */
        if (res.id != -1)
        {
@@ -1076,7 +1009,6 @@ void DNS::HandleEvent(EventType et, int errornum)
                        /* Mask off the error bit */
                        res.id -= ERROR_MASK;
                        /* Marshall the error to the correct class */
-                       ServerInstance->Log(DEBUG,"Error available, id=%d",res.id);
                        if (Classes[res.id])
                        {
                                if (ServerInstance && ServerInstance->stats)
@@ -1085,22 +1017,18 @@ void DNS::HandleEvent(EventType et, int errornum)
                                delete Classes[res.id];
                                Classes[res.id] = NULL;
                        }
+                       return;
                }
                else
                {
-                       /* It is a non-error result */
-                       ServerInstance->Log(DEBUG,"Result available, id=%d",res.id);
-                       /* Marshall the result to the correct class */
+                       /* It is a non-error result, marshall the result to the correct class */
                        if (Classes[res.id])
                        {
                                if (ServerInstance && ServerInstance->stats)
                                        ServerInstance->stats->statsDnsGood++;
 
                                if (!this->GetCache(res.original.c_str()))
-                               {
-                                       ServerInstance->Log(DEBUG,"Caching result: %s->%s for %lu secs", res.original.c_str(), res.result.c_str(), res.ttl);
                                        this->cache->insert(std::make_pair(res.original.c_str(), CachedQuery(res.result, res.ttl)));
-                               }
 
                                Classes[res.id]->OnLookupComplete(res.result, res.ttl, false);
                                delete Classes[res.id];
@@ -1116,6 +1044,7 @@ void DNS::HandleEvent(EventType et, int errornum)
 /** Add a derived Resolver to the working set */
 bool DNS::AddResolverClass(Resolver* r)
 {
+       ServerInstance->Logs->Log("RESOLVER",DEBUG,"AddResolverClass 0x%08lx", (unsigned long)r);
        /* Check the pointers validity and the id's validity */
        if ((r) && (r->GetId() > -1))
        {
@@ -1153,7 +1082,7 @@ void DNS::CleanResolvers(Module* module)
                {
                        if (Classes[i]->GetCreator() == module)
                        {
-                               Classes[i]->OnError(RESLOVER_FORCEUNLOAD, "Parent module is unloading");
+                               Classes[i]->OnError(RESOLVER_FORCEUNLOAD, "Parent module is unloading");
                                delete Classes[i];
                                Classes[i] = NULL;
                        }
@@ -1168,9 +1097,8 @@ unsigned long DNS::PRNG()
        timeval n;
        serverstats* s = ServerInstance->stats;
        gettimeofday(&n,NULL);
-       val = (n.tv_usec ^ getpid() ^ geteuid() ^ (this->currid++)) ^ s->statsAccept + n.tv_sec;
-       val = val + s->statsCollisions ^ s->statsDnsGood - s->statsDnsBad;
-       val += (s->statsConnects ^ (unsigned long)s->statsSent ^ (unsigned long)s->statsRecv) - s->BoundPortCount;
+       val = (n.tv_usec ^ (getpid() ^ geteuid()) ^ ((this->currid++)) ^ s->statsAccept) + n.tv_sec;
+       val = val + (s->statsCollisions ^ s->statsDnsGood) - s->statsDnsBad;
+       val += (s->statsConnects ^ (unsigned long)s->statsSent ^ (unsigned long)s->statsRecv) - ServerInstance->ports.size();
        return val;
 }
-