]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/helperfuncs.cpp
Changed two fields in ConnectClass to strings, moved constructor stuff to init-list
[user/henk/code/inspircd.git] / src / helperfuncs.cpp
index eed15dc7b78e2eb01734e44b94a03285249de6a0..3bc2bb79aed664196b9a4bf46d4c1f8ffd0996f1 100644 (file)
@@ -19,7 +19,6 @@ using namespace std;
 #include "inspircd_config.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
-#include "inspircd_util.h"
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/errno.h>
@@ -53,37 +52,24 @@ using namespace std;
 extern int MODCOUNT;
 extern std::vector<Module*> modules;
 extern ServerConfig *Config;
-
+extern InspIRCd* ServerInstance;
 extern time_t TIME;
 extern char lowermap[255];
-extern std::stringstream config_f;
 static char list[MAXBUF];
 extern userrec* fd_ref_table[65536];
-
-extern serverstats* stats;
-
 static char already_sent[65536];
 extern std::vector<userrec*> all_opers;
-
-extern ClassVector Classes;
-
 extern user_hash clientlist;
 extern chan_hash chanlist;
-extern command_table cmdlist;
-extern file_cache MOTD;
-extern file_cache RULES;
 
 void log(int level,char *text, ...)
 {
-        char textbuffer[MAXBUF];
         va_list argsPtr;
-        time_t rawtime;
         struct tm * timeinfo;
         if (level < Config->LogLevel)
                 return;
-
-        time(&rawtime);
-        timeinfo = localtime(&rawtime);
+       char textbuffer[MAXBUF];
+        timeinfo = localtime(&TIME);
 
         if (Config->log_file)
         {
@@ -117,7 +103,7 @@ void readfile(file_cache &F, const char* fname)
                 {
                         fgets(linebuf,sizeof(linebuf),file);
                         linebuf[strlen(linebuf)-1]='\0';
-                        if (linebuf[0] == 0)
+                        if (!*linebuf)
                         {
                                 strcpy(linebuf,"  ");
                         }
@@ -144,10 +130,8 @@ void Write(int sock,char *text, ...)
                 log(DEFAULT,"*** BUG *** Write was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF];
         va_list argsPtr;
-        char tb[MAXBUF];
-
+       char textbuffer[MAXBUF],tb[MAXBUF];
         va_start (argsPtr, text);
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
         va_end(argsPtr);
@@ -155,10 +139,15 @@ void Write(int sock,char *text, ...)
         chop(tb);
         if (fd_ref_table[sock])
         {
-                int MOD_RESULT = 0;
-                FOREACH_RESULT(OnRawSocketWrite(sock,tb,bytes));
-                fd_ref_table[sock]->AddWriteBuf(tb);
-                stats->statsSent += bytes;
+               if (Config->GetIOHook(fd_ref_table[sock]->port))
+               {
+                       Config->GetIOHook(fd_ref_table[sock]->port)->OnRawSocketWrite(sock,tb,bytes);
+               }
+               else
+               {
+                       fd_ref_table[sock]->AddWriteBuf(tb);
+               }
+               ServerInstance->stats->statsSent += bytes;
         }
         else log(DEFAULT,"ERROR! attempted write to a user with no fd_ref_table entry!!!");
 }
@@ -174,20 +163,24 @@ void WriteServ(int sock, char* text, ...)
                 log(DEFAULT,"*** BUG *** WriteServ was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, text);
-
+       char textbuffer[MAXBUF],tb[MAXBUF];
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
         va_end(argsPtr);
         int bytes = snprintf(tb,MAXBUF,":%s %s\r\n",Config->ServerName,textbuffer);
         chop(tb);
         if (fd_ref_table[sock])
         {
-                int MOD_RESULT = 0;
-                FOREACH_RESULT(OnRawSocketWrite(sock,tb,bytes));
-                fd_ref_table[sock]->AddWriteBuf(tb);
-                stats->statsSent += bytes;
+               if (Config->GetIOHook(fd_ref_table[sock]->port))
+               {
+                       Config->GetIOHook(fd_ref_table[sock]->port)->OnRawSocketWrite(sock,tb,bytes);
+               }
+               else
+               {
+                       fd_ref_table[sock]->AddWriteBuf(tb);
+               }
+                ServerInstance->stats->statsSent += bytes;
         }
         else log(DEFAULT,"ERROR! attempted write to a user with no fd_ref_table entry!!!");
 }
@@ -203,20 +196,24 @@ void WriteFrom(int sock, userrec *user,char* text, ...)
                 log(DEFAULT,"*** BUG *** WriteFrom was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, text);
-
+       char textbuffer[MAXBUF],tb[MAXBUF];
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
         va_end(argsPtr);
         int bytes = snprintf(tb,MAXBUF,":%s!%s@%s %s\r\n",user->nick,user->ident,user->dhost,textbuffer);
         chop(tb);
         if (fd_ref_table[sock])
         {
-                int MOD_RESULT = 0;
-                FOREACH_RESULT(OnRawSocketWrite(sock,tb,bytes));
-                fd_ref_table[sock]->AddWriteBuf(tb);
-                stats->statsSent += bytes;
+               if (Config->GetIOHook(fd_ref_table[sock]->port))
+               {
+                       Config->GetIOHook(fd_ref_table[sock]->port)->OnRawSocketWrite(sock,tb,bytes);
+               }
+               else
+               {
+                       fd_ref_table[sock]->AddWriteBuf(tb);
+               }
+                ServerInstance->stats->statsSent += bytes;
         }
         else log(DEFAULT,"ERROR! attempted write to a user with no fd_ref_table entry!!!");
 }
@@ -232,7 +229,7 @@ void WriteTo(userrec *source, userrec *dest,char *data, ...)
         }
         if (dest->fd == FD_MAGIC_NUMBER)
                 return;
-        char textbuffer[MAXBUF],tb[MAXBUF];
+       char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, data);
         vsnprintf(textbuffer, MAXBUF, data, argsPtr);
@@ -267,7 +264,8 @@ void WriteChannel(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -294,7 +292,8 @@ void WriteChannelLocal(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -327,7 +326,8 @@ void WriteChannelWithServ(char* ServName, chanrec* Ptr, char* text, ...)
 
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -353,7 +353,8 @@ void ChanExceptSender(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -399,20 +400,22 @@ void WriteCommon(userrec *u, char* text, ...)
         va_end(argsPtr);
 
         // FIX: Stops a message going to the same person more than once
-        memset(&already_sent,0,65536);
+        memset(&already_sent,0,MAXCLIENTS);
 
         bool sent_to_at_least_one = false;
 
-        for (unsigned int i = 0; i < u->chans.size(); i++)
+       unsigned int y = u->chans.size();
+        for (unsigned int i = 0; i < y; i++)
         {
                 if (u->chans[i].channel)
                 {
                         std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
+                       unsigned int x = ulist->size();
+                        for (unsigned int j = 0; j < x; j++)
                         {
                                 char* o = (*ulist)[j];
                                 userrec* otheruser = (userrec*)o;
-                                if ((otheruser->fd > 0) && (!already_sent[otheruser->fd]))
+                                if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
                                 {
                                         already_sent[otheruser->fd] = 1;
                                         WriteFrom(otheruser->fd,u,"%s",textbuffer);
@@ -451,20 +454,22 @@ void WriteCommonExcept(userrec *u, char* text, ...)
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
         va_end(argsPtr);
 
-        memset(&already_sent,0,65536);
+        memset(&already_sent,0,MAXCLIENTS);
 
-        for (unsigned int i = 0; i < u->chans.size(); i++)
+       unsigned int y = u->chans.size();
+        for (unsigned int i = 0; i < y; i++)
         {
                 if (u->chans[i].channel)
                 {
                         std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
+                       unsigned int x = ulist->size();
+                        for (unsigned int j = 0; j < x; j++)
                         {
                                 char* o = (*ulist)[j];
                                 userrec* otheruser = (userrec*)o;
                                 if (u != otheruser)
                                 {
-                                        if ((otheruser->fd > 0) && (!already_sent[otheruser->fd]))
+                                        if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
                                         {
                                                 already_sent[otheruser->fd] = 1;
                                                 WriteFrom(otheruser->fd,u,"%s",textbuffer);
@@ -543,75 +548,6 @@ void ServerPrivmsgAll(char* text, ...)
        }
 }
 
-void NoticeAllOpers(userrec *source, bool local_only, char* text, ...)
-{
-        if ((!text) || (!source))
-        {
-                log(DEFAULT,"*** BUG *** NoticeAllOpers was given an invalid parameter");
-                return;
-        }
-
-        char textbuffer[MAXBUF];
-        va_list argsPtr;
-        va_start (argsPtr, text);
-        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
-        va_end(argsPtr);
-
-        for (std::vector<userrec*>::iterator i = all_opers.begin(); i != all_opers.end(); i++)
-        {
-                userrec* a = *i;
-                if ((a) && (a->fd != FD_MAGIC_NUMBER))
-                {
-                        if (strchr(a->modes,'s'))
-                        {
-                                // send server notices to all with +s
-                                WriteServ(a->fd,"NOTICE %s :*** Notice From %s: %s",a->nick,source->nick,textbuffer);
-                        }
-                }
-        }
-
-}
-// returns TRUE of any users on channel C occupy server 'servername'.
-
-bool ChanAnyOnThisServer(chanrec *c,char* servername)
-{
-        log(DEBUG,"ChanAnyOnThisServer");
-
-        std::vector<char*> *ulist = c->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
-        {
-                char* o = (*ulist)[j];
-                userrec* user = (userrec*)o;
-                if (!strcasecmp(user->server,servername))
-                        return true;
-        }
-        return false;
-}
-
-// returns true if user 'u' shares any common channels with any users on server 'servername'
-
-bool CommonOnThisServer(userrec* u,const char* servername)
-{
-        log(DEBUG,"ChanAnyOnThisServer");
-
-        for (unsigned int i = 0; i < u->chans.size(); i++)
-        {
-                if (u->chans[i].channel)
-                {
-                        std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
-                        {
-                                char* o = (*ulist)[j];
-                                userrec* user = (userrec*)o;
-                                if (!strcasecmp(user->server,servername))
-                                        return true;
-                        }
-                }
-        }
-        return false;
-}
-
-
 void WriteMode(const char* modes, int flags, const char* text, ...)
 {
         if ((!text) || (!modes) || (!flags))
@@ -772,12 +708,12 @@ chanrec* FindChan(const char* chan)
 long GetMaxBans(char* name)
 {
         char CM[MAXBUF];
-        for (int count = 0; count < ConfValueEnum("banlist",&config_f); count++)
+        for (int count = 0; count < Config->ConfValueEnum("banlist",&Config->config_f); count++)
         {
-                ConfValue("banlist","chan",count,CM,&config_f);
+               Config->ConfValue("banlist","chan",count,CM,&Config->config_f);
                 if (match(name,CM))
                 {
-                        ConfValue("banlist","limit",count,CM,&config_f);
+                        Config->ConfValue("banlist","limit",count,CM,&Config->config_f);
                         return atoi(CM);
                 }
         }
@@ -787,7 +723,7 @@ long GetMaxBans(char* name)
 void purge_empty_chans(userrec* u)
 {
 
-        int go_again = 1, purge = 0;
+        int purge = 0;
 
         // firstly decrement the count on each channel
         for (unsigned int f = 0; f < u->chans.size(); f++)
@@ -812,7 +748,6 @@ void purge_empty_chans(userrec* u)
                                         if (i2->second)
                                                 delete i2->second;
                                         chanlist.erase(i2);
-                                        go_again = 1;
                                         purge++;
                                         u->chans[i].channel = NULL;
                                 }
@@ -829,57 +764,39 @@ void purge_empty_chans(userrec* u)
 }
 
 
-char scratch[MAXBUF];
-char sparam[MAXBUF];
-
 char* chanmodes(chanrec *chan)
 {
+       static char scratch[MAXBUF];
+       static char sparam[MAXBUF];
+       char* offset = scratch;
+
         if (!chan)
         {
                 log(DEFAULT,"*** BUG *** chanmodes was given an invalid parameter");
-                strcpy(scratch,"");
+                *scratch = '\0';
                 return scratch;
         }
 
-        strcpy(scratch,"");
-        strcpy(sparam,"");
+        *scratch = '\0';
+        *sparam = '\0';
         if (chan->binarymodes & CM_NOEXTERNAL)
-        {
-                strlcat(scratch,"n",MAXMODES);
-        }
+               *offset++ = 'n';
         if (chan->binarymodes & CM_TOPICLOCK)
-        {
-                strlcat(scratch,"t",MAXMODES);
-        }
-        if (chan->key[0])
-        {
-                strlcat(scratch,"k",MAXMODES);
-        }
+               *offset++ = 't';
+        if (*chan->key)
+               *offset++ = 'k';
         if (chan->limit)
-        {
-                strlcat(scratch,"l",MAXMODES);
-        }
+               *offset++ = 'l';
         if (chan->binarymodes & CM_INVITEONLY)
-        {
-                strlcat(scratch,"i",MAXMODES);
-        }
+               *offset++ = 'i';
         if (chan->binarymodes & CM_MODERATED)
-        {
-                strlcat(scratch,"m",MAXMODES);
-        }
+               *offset++ = 'm';
         if (chan->binarymodes & CM_SECRET)
-        {
-                strlcat(scratch,"s",MAXMODES);
-        }
+               *offset++ = 's';
         if (chan->binarymodes & CM_PRIVATE)
-        {
-                strlcat(scratch,"p",MAXMODES);
-        }
-        if (chan->key[0])
-        {
-                strlcat(sparam," ",MAXBUF);
-                strlcat(sparam,chan->key,MAXBUF);
-        }
+                *offset++ = 'p';
+        if (*chan->key)
+               snprintf(sparam,MAXBUF," %s",chan->key);
         if (chan->limit)
         {
                 char foo[24];
@@ -888,8 +805,9 @@ char* chanmodes(chanrec *chan)
         }
         if (*chan->custom_modes)
         {
-                strlcat(scratch,chan->custom_modes,MAXMODES);
-                for (int z = 0; chan->custom_modes[z] != 0; z++)
+               for (char* t = chan->custom_modes; *t; t++)
+                       *offset++ = *t;
+                for (int z = 0; chan->custom_modes[z]; z++)
                 {
                         std::string extparam = chan->GetModeParameter(chan->custom_modes[z]);
                         if (extparam != "")
@@ -899,7 +817,8 @@ char* chanmodes(chanrec *chan)
                         }
                 }
         }
-        log(DEBUG,"chanmodes: %s %s%s",chan->name,scratch,sparam);
+       /* Null terminate scratch */
+       *offset = '\0';
         strlcat(scratch,sparam,MAXMODES);
         return scratch;
 }
@@ -1001,11 +920,11 @@ int usercount(chanrec *c)
 
 char* Passwd(userrec *user)
 {
-        for (ClassVector::iterator i = Classes.begin(); i != Classes.end(); i++)
+        for (ClassVector::iterator i = Config->Classes.begin(); i != Config->Classes.end(); i++)
         {
-                if (match(user->host,i->host) && (i->type == CC_ALLOW))
+                if ((i->type == CC_ALLOW) && match(user->host,i->host.c_str()))
                 {
-                        return i->pass;
+                        return (char*)i->pass.c_str();
                 }
         }
         return "";
@@ -1013,9 +932,9 @@ char* Passwd(userrec *user)
 
 bool IsDenied(userrec *user)
 {
-        for (ClassVector::iterator i = Classes.begin(); i != Classes.end(); i++)
+        for (ClassVector::iterator i = Config->Classes.begin(); i != Config->Classes.end(); i++)
         {
-                if (match(user->host,i->host) && (i->type == CC_DENY))
+                if ((i->type == CC_DENY) && match(user->host,i->host.c_str()))
                 {
                         return true;
                 }
@@ -1034,15 +953,18 @@ void send_error(char *s)
         log(DEBUG,"send_error: %s",s);
         for (user_hash::const_iterator i = clientlist.begin(); i != clientlist.end(); i++)
         {
-                if (isnick(i->second->nick))
-                {
-                        WriteServ(i->second->fd,"NOTICE %s :%s",i->second->nick,s);
-                }
-                else
-                {
-                        // fix - unregistered connections receive ERROR, not NOTICE
-                        Write(i->second->fd,"ERROR :%s",s);
-                }
+                if (IS_LOCAL(i->second))
+               {
+                       if (i->second->registered == 7)
+                       {
+                               WriteServ(i->second->fd,"NOTICE %s :%s",i->second->nick,s);
+                       }
+                       else
+                       {
+                               // fix - unregistered connections receive ERROR, not NOTICE
+                               Write(i->second->fd,"ERROR :%s",s);
+                       }
+               }
         }
 }
 
@@ -1126,39 +1048,43 @@ long local_count()
 
 void ShowMOTD(userrec *user)
 {
-        char buf[65536];
+        static char mbuf[MAXBUF];
+       static char crud[MAXBUF];
         std::string WholeMOTD = "";
-        if (!MOTD.size())
+        if (!Config->MOTD.size())
         {
                 WriteServ(user->fd,"422 %s :Message of the day file is missing.",user->nick);
                 return;
         }
-        snprintf(buf,65535,":%s 375 %s :- %s message of the day\r\n", Config->ServerName, user->nick, Config->ServerName);
-        WholeMOTD = WholeMOTD + buf;
-        for (unsigned int i = 0; i != MOTD.size(); i++)
-        {
-                snprintf(buf,65535,":%s 372 %s :- %s\r\n", Config->ServerName, user->nick, MOTD[i].c_str());
-                WholeMOTD = WholeMOTD + buf;
-        }
-        snprintf(buf,65535,":%s 376 %s :End of message of the day.\r\n", Config->ServerName, user->nick);
-        WholeMOTD = WholeMOTD + buf;
+       snprintf(crud,MAXBUF,":%s 372 %s :- ", Config->ServerName, user->nick);
+        snprintf(mbuf,MAXBUF,":%s 375 %s :- %s message of the day\r\n", Config->ServerName, user->nick, Config->ServerName);
+        WholeMOTD = WholeMOTD + mbuf;
+        for (unsigned int i = 0; i < Config->MOTD.size(); i++)
+                WholeMOTD = WholeMOTD + std::string(crud) + Config->MOTD[i].c_str() + std::string("\r\n");
+        snprintf(mbuf,MAXBUF,":%s 376 %s :End of message of the day.\r\n", Config->ServerName, user->nick);
+        WholeMOTD = WholeMOTD + mbuf;
         // only one write operation
-        user->AddWriteBuf(WholeMOTD);
-        stats->statsSent += WholeMOTD.length();
+       if (Config->GetIOHook(user->port))
+       {
+               Config->GetIOHook(user->port)->OnRawSocketWrite(user->fd,(char*)WholeMOTD.c_str(),WholeMOTD.length());
+       }
+       else
+       {
+               user->AddWriteBuf(WholeMOTD);
+       }
+        ServerInstance->stats->statsSent += WholeMOTD.length();
 }
 
 void ShowRULES(userrec *user)
 {
-        if (!RULES.size())
+        if (!Config->RULES.size())
         {
                 WriteServ(user->fd,"NOTICE %s :Rules file is missing.",user->nick);
                 return;
         }
         WriteServ(user->fd,"NOTICE %s :%s rules",user->nick,Config->ServerName);
-        for (unsigned int i = 0; i != RULES.size(); i++)
-        {
-                                WriteServ(user->fd,"NOTICE %s :%s",user->nick,RULES[i].c_str());
-        }
+        for (unsigned int i = 0; i < Config->RULES.size(); i++)
+                WriteServ(user->fd,"NOTICE %s :%s",user->nick,Config->RULES[i].c_str());
         WriteServ(user->fd,"NOTICE %s :End of %s rules.",user->nick,Config->ServerName);
 }
 
@@ -1170,92 +1096,20 @@ bool AllModulesReportReady(userrec* user)
         for (int i = 0; i <= MODCOUNT; i++)
         {
                 int res = modules[i]->OnCheckReady(user);
-                        if (!res)
-                                return false;
+                if (!res)
+                        return false;
         }
         return true;
 }
 
-void createcommand(char* cmd, handlerfunc f, char flags, int minparams,char* source)
-{
-        command_t comm;
-        /* create the command and push it onto the table */
-        strlcpy(comm.command,cmd,MAXBUF);
-        strlcpy(comm.source,source,MAXBUF);
-        comm.handler_function = f;
-        comm.flags_needed = flags;
-        comm.min_params = minparams;
-        comm.use_count = 0;
-        comm.total_bytes = 0;
-        cmdlist.push_back(comm);
-        log(DEBUG,"Added command %s (%lu parameters)",cmd,(unsigned long)minparams);
-}
-
-
-void SetupCommandTable(void)
-{
-        createcommand("USER",handle_user,0,4,"<core>");
-        createcommand("NICK",handle_nick,0,1,"<core>");
-        createcommand("QUIT",handle_quit,0,0,"<core>");
-        createcommand("VERSION",handle_version,0,0,"<core>");
-        createcommand("PING",handle_ping,0,1,"<core>");
-        createcommand("PONG",handle_pong,0,1,"<core>");
-        createcommand("ADMIN",handle_admin,0,0,"<core>");
-        createcommand("PRIVMSG",handle_privmsg,0,2,"<core>");
-        createcommand("INFO",handle_info,0,0,"<core>");
-        createcommand("TIME",handle_time,0,0,"<core>");
-        createcommand("WHOIS",handle_whois,0,1,"<core>");
-        createcommand("WALLOPS",handle_wallops,'o',1,"<core>");
-        createcommand("NOTICE",handle_notice,0,2,"<core>");
-        createcommand("JOIN",handle_join,0,1,"<core>");
-        createcommand("NAMES",handle_names,0,0,"<core>");
-        createcommand("PART",handle_part,0,1,"<core>");
-        createcommand("KICK",handle_kick,0,2,"<core>");
-        createcommand("MODE",handle_mode,0,1,"<core>");
-        createcommand("TOPIC",handle_topic,0,1,"<core>");
-        createcommand("WHO",handle_who,0,1,"<core>");
-        createcommand("MOTD",handle_motd,0,0,"<core>");
-        createcommand("RULES",handle_rules,0,0,"<core>");
-        createcommand("OPER",handle_oper,0,2,"<core>");
-        createcommand("LIST",handle_list,0,0,"<core>");
-        createcommand("DIE",handle_die,'o',1,"<core>");
-        createcommand("RESTART",handle_restart,'o',1,"<core>");
-        createcommand("KILL",handle_kill,'o',2,"<core>");
-        createcommand("REHASH",handle_rehash,'o',0,"<core>");
-        createcommand("LUSERS",handle_lusers,0,0,"<core>");
-        createcommand("STATS",handle_stats,0,1,"<core>");
-        createcommand("USERHOST",handle_userhost,0,1,"<core>");
-        createcommand("AWAY",handle_away,0,0,"<core>");
-        createcommand("ISON",handle_ison,0,0,"<core>");
-        createcommand("SUMMON",handle_summon,0,0,"<core>");
-        createcommand("USERS",handle_users,0,0,"<core>");
-        createcommand("INVITE",handle_invite,0,0,"<core>");
-        createcommand("PASS",handle_pass,0,1,"<core>");
-        createcommand("TRACE",handle_trace,'o',0,"<core>");
-        createcommand("WHOWAS",handle_whowas,0,1,"<core>");
-        createcommand("CONNECT",handle_connect,'o',1,"<core>");
-        createcommand("SQUIT",handle_squit,'o',0,"<core>");
-        createcommand("MODULES",handle_modules,0,0,"<core>");
-        createcommand("LINKS",handle_links,0,0,"<core>");
-        createcommand("MAP",handle_map,0,0,"<core>");
-        createcommand("KLINE",handle_kline,'o',1,"<core>");
-        createcommand("GLINE",handle_gline,'o',1,"<core>");
-        createcommand("ZLINE",handle_zline,'o',1,"<core>");
-        createcommand("QLINE",handle_qline,'o',1,"<core>");
-        createcommand("ELINE",handle_eline,'o',1,"<core>");
-        createcommand("LOADMODULE",handle_loadmodule,'o',1,"<core>");
-        createcommand("UNLOADMODULE",handle_unloadmodule,'o',1,"<core>");
-        createcommand("SERVER",handle_server,0,0,"<core>");
-       createcommand("COMMANDS",handle_commands,0,0,"<core>");
-}
-
 bool DirValid(char* dirandfile)
 {
         char work[MAXBUF];
+       char buffer[MAXBUF], otherdir[MAXBUF];
         strlcpy(work,dirandfile,MAXBUF);
         int p = strlen(work);
         // we just want the dir
-        while (strlen(work))
+        while (*work)
         {
                 if (work[p] == '/')
                 {
@@ -1264,7 +1118,6 @@ bool DirValid(char* dirandfile)
                 }
                 work[p--] = '\0';
         }
-        char buffer[MAXBUF], otherdir[MAXBUF];
         // Get the current working directory
         if( getcwd( buffer, MAXBUF ) == NULL )
                 return false;
@@ -1287,10 +1140,11 @@ bool DirValid(char* dirandfile)
 std::string GetFullProgDir(char** argv, int argc)
 {
         char work[MAXBUF];
+       char buffer[MAXBUF], otherdir[MAXBUF];
         strlcpy(work,argv[0],MAXBUF);
         int p = strlen(work);
         // we just want the dir
-        while (strlen(work))
+        while (*work)
         {
                 if (work[p] == '/')
                 {
@@ -1299,7 +1153,6 @@ std::string GetFullProgDir(char** argv, int argc)
                 }
                 work[p--] = '\0';
         }
-        char buffer[MAXBUF], otherdir[MAXBUF];
         // Get the current working directory
         if( getcwd( buffer, MAXBUF ) == NULL )
                 return "";