]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/helperfuncs.cpp
Removed syscalls in log, moved va* buffers to static char
[user/henk/code/inspircd.git] / src / helperfuncs.cpp
index 65a416a47dcc68567c889b3bd9fbf84d39979df8..c886acf3c081d83fd022a62a22d88ec8e56bbbb1 100644 (file)
@@ -19,7 +19,6 @@ using namespace std;
 #include "inspircd_config.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
-#include "inspircd_util.h"
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/errno.h>
@@ -60,22 +59,21 @@ extern userrec* fd_ref_table[65536];
 extern serverstats* stats;
 static char already_sent[65536];
 extern std::vector<userrec*> all_opers;
-extern ClassVector Classes;
 extern user_hash clientlist;
 extern chan_hash chanlist;
 extern command_table cmdlist;
 
+static char textbuffer[MAXBUF];
+static char tb[MAXBUF];
+
 void log(int level,char *text, ...)
 {
-        char textbuffer[MAXBUF];
         va_list argsPtr;
-        time_t rawtime;
         struct tm * timeinfo;
         if (level < Config->LogLevel)
                 return;
 
-        time(&rawtime);
-        timeinfo = localtime(&rawtime);
+        timeinfo = localtime(&TIME);
 
         if (Config->log_file)
         {
@@ -136,9 +134,7 @@ void Write(int sock,char *text, ...)
                 log(DEFAULT,"*** BUG *** Write was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF];
         va_list argsPtr;
-        char tb[MAXBUF];
 
         va_start (argsPtr, text);
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
@@ -166,7 +162,6 @@ void WriteServ(int sock, char* text, ...)
                 log(DEFAULT,"*** BUG *** WriteServ was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, text);
 
@@ -195,7 +190,6 @@ void WriteFrom(int sock, userrec *user,char* text, ...)
                 log(DEFAULT,"*** BUG *** WriteFrom was given an invalid parameter");
                 return;
         }
-        char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, text);
 
@@ -224,7 +218,6 @@ void WriteTo(userrec *source, userrec *dest,char *data, ...)
         }
         if (dest->fd == FD_MAGIC_NUMBER)
                 return;
-        char textbuffer[MAXBUF],tb[MAXBUF];
         va_list argsPtr;
         va_start (argsPtr, data);
         vsnprintf(textbuffer, MAXBUF, data, argsPtr);
@@ -259,7 +252,8 @@ void WriteChannel(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -286,7 +280,8 @@ void WriteChannelLocal(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -319,7 +314,8 @@ void WriteChannelWithServ(char* ServName, chanrec* Ptr, char* text, ...)
 
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -345,7 +341,8 @@ void ChanExceptSender(chanrec* Ptr, userrec* user, char* text, ...)
         va_end(argsPtr);
 
         std::vector<char*> *ulist = Ptr->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
+       unsigned int x = ulist->size();
+        for (unsigned int j = 0; j < x; j++)
         {
                 char* o = (*ulist)[j];
                 userrec* otheruser = (userrec*)o;
@@ -391,20 +388,22 @@ void WriteCommon(userrec *u, char* text, ...)
         va_end(argsPtr);
 
         // FIX: Stops a message going to the same person more than once
-        memset(&already_sent,0,65536);
+        memset(&already_sent,0,MAXCLIENTS);
 
         bool sent_to_at_least_one = false;
 
-        for (unsigned int i = 0; i < u->chans.size(); i++)
+       unsigned int y = u->chans.size();
+        for (unsigned int i = 0; i < y; i++)
         {
                 if (u->chans[i].channel)
                 {
                         std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
+                       unsigned int x = ulist->size();
+                        for (unsigned int j = 0; j < x; j++)
                         {
                                 char* o = (*ulist)[j];
                                 userrec* otheruser = (userrec*)o;
-                                if ((otheruser->fd > 0) && (!already_sent[otheruser->fd]))
+                                if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
                                 {
                                         already_sent[otheruser->fd] = 1;
                                         WriteFrom(otheruser->fd,u,"%s",textbuffer);
@@ -443,20 +442,22 @@ void WriteCommonExcept(userrec *u, char* text, ...)
         vsnprintf(textbuffer, MAXBUF, text, argsPtr);
         va_end(argsPtr);
 
-        memset(&already_sent,0,65536);
+        memset(&already_sent,0,MAXCLIENTS);
 
-        for (unsigned int i = 0; i < u->chans.size(); i++)
+       unsigned int y = u->chans.size();
+        for (unsigned int i = 0; i < y; i++)
         {
                 if (u->chans[i].channel)
                 {
                         std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
+                       unsigned int x = ulist->size();
+                        for (unsigned int j = 0; j < x; j++)
                         {
                                 char* o = (*ulist)[j];
                                 userrec* otheruser = (userrec*)o;
                                 if (u != otheruser)
                                 {
-                                        if ((otheruser->fd > 0) && (!already_sent[otheruser->fd]))
+                                        if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
                                         {
                                                 already_sent[otheruser->fd] = 1;
                                                 WriteFrom(otheruser->fd,u,"%s",textbuffer);
@@ -535,75 +536,6 @@ void ServerPrivmsgAll(char* text, ...)
        }
 }
 
-void NoticeAllOpers(userrec *source, bool local_only, char* text, ...)
-{
-        if ((!text) || (!source))
-        {
-                log(DEFAULT,"*** BUG *** NoticeAllOpers was given an invalid parameter");
-                return;
-        }
-
-        char textbuffer[MAXBUF];
-        va_list argsPtr;
-        va_start (argsPtr, text);
-        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
-        va_end(argsPtr);
-
-        for (std::vector<userrec*>::iterator i = all_opers.begin(); i != all_opers.end(); i++)
-        {
-                userrec* a = *i;
-                if ((a) && (a->fd != FD_MAGIC_NUMBER))
-                {
-                        if (strchr(a->modes,'s'))
-                        {
-                                // send server notices to all with +s
-                                WriteServ(a->fd,"NOTICE %s :*** Notice From %s: %s",a->nick,source->nick,textbuffer);
-                        }
-                }
-        }
-
-}
-// returns TRUE of any users on channel C occupy server 'servername'.
-
-bool ChanAnyOnThisServer(chanrec *c,char* servername)
-{
-        log(DEBUG,"ChanAnyOnThisServer");
-
-        std::vector<char*> *ulist = c->GetUsers();
-        for (unsigned int j = 0; j < ulist->size(); j++)
-        {
-                char* o = (*ulist)[j];
-                userrec* user = (userrec*)o;
-                if (!strcasecmp(user->server,servername))
-                        return true;
-        }
-        return false;
-}
-
-// returns true if user 'u' shares any common channels with any users on server 'servername'
-
-bool CommonOnThisServer(userrec* u,const char* servername)
-{
-        log(DEBUG,"ChanAnyOnThisServer");
-
-        for (unsigned int i = 0; i < u->chans.size(); i++)
-        {
-                if (u->chans[i].channel)
-                {
-                        std::vector<char*> *ulist = u->chans[i].channel->GetUsers();
-                        for (unsigned int j = 0; j < ulist->size(); j++)
-                        {
-                                char* o = (*ulist)[j];
-                                userrec* user = (userrec*)o;
-                                if (!strcasecmp(user->server,servername))
-                                        return true;
-                        }
-                }
-        }
-        return false;
-}
-
-
 void WriteMode(const char* modes, int flags, const char* text, ...)
 {
         if ((!text) || (!modes) || (!flags))
@@ -764,12 +696,12 @@ chanrec* FindChan(const char* chan)
 long GetMaxBans(char* name)
 {
         char CM[MAXBUF];
-        for (int count = 0; count < ConfValueEnum("banlist",&Config->config_f); count++)
+        for (int count = 0; count < Config->ConfValueEnum("banlist",&Config->config_f); count++)
         {
-                ConfValue("banlist","chan",count,CM,&Config->config_f);
+               Config->ConfValue("banlist","chan",count,CM,&Config->config_f);
                 if (match(name,CM))
                 {
-                        ConfValue("banlist","limit",count,CM,&Config->config_f);
+                        Config->ConfValue("banlist","limit",count,CM,&Config->config_f);
                         return atoi(CM);
                 }
         }
@@ -779,7 +711,7 @@ long GetMaxBans(char* name)
 void purge_empty_chans(userrec* u)
 {
 
-        int go_again = 1, purge = 0;
+        int purge = 0;
 
         // firstly decrement the count on each channel
         for (unsigned int f = 0; f < u->chans.size(); f++)
@@ -804,7 +736,6 @@ void purge_empty_chans(userrec* u)
                                         if (i2->second)
                                                 delete i2->second;
                                         chanlist.erase(i2);
-                                        go_again = 1;
                                         purge++;
                                         u->chans[i].channel = NULL;
                                 }
@@ -821,57 +752,39 @@ void purge_empty_chans(userrec* u)
 }
 
 
-char scratch[MAXBUF];
-char sparam[MAXBUF];
-
 char* chanmodes(chanrec *chan)
 {
+       static char scratch[MAXBUF];
+       static char sparam[MAXBUF];
+       char* offset = scratch;
+
         if (!chan)
         {
                 log(DEFAULT,"*** BUG *** chanmodes was given an invalid parameter");
-                strcpy(scratch,"");
+                *scratch = '\0';
                 return scratch;
         }
 
-        strcpy(scratch,"");
-        strcpy(sparam,"");
+        *scratch = '\0';
+        *sparam = '\0';
         if (chan->binarymodes & CM_NOEXTERNAL)
-        {
-                strlcat(scratch,"n",MAXMODES);
-        }
+               *offset++ = 'n';
         if (chan->binarymodes & CM_TOPICLOCK)
-        {
-                strlcat(scratch,"t",MAXMODES);
-        }
+               *offset++ = 't';
         if (*chan->key)
-        {
-                strlcat(scratch,"k",MAXMODES);
-        }
+               *offset++ = 'k';
         if (chan->limit)
-        {
-                strlcat(scratch,"l",MAXMODES);
-        }
+               *offset++ = 'l';
         if (chan->binarymodes & CM_INVITEONLY)
-        {
-                strlcat(scratch,"i",MAXMODES);
-        }
+               *offset++ = 'i';
         if (chan->binarymodes & CM_MODERATED)
-        {
-                strlcat(scratch,"m",MAXMODES);
-        }
+               *offset++ = 'm';
         if (chan->binarymodes & CM_SECRET)
-        {
-                strlcat(scratch,"s",MAXMODES);
-        }
+               *offset++ = 's';
         if (chan->binarymodes & CM_PRIVATE)
-        {
-                strlcat(scratch,"p",MAXMODES);
-        }
+                *offset++ = 'p';
         if (*chan->key)
-        {
-                strlcat(sparam," ",MAXBUF);
-                strlcat(sparam,chan->key,MAXBUF);
-        }
+               snprintf(sparam,MAXBUF," %s",chan->key);
         if (chan->limit)
         {
                 char foo[24];
@@ -880,8 +793,9 @@ char* chanmodes(chanrec *chan)
         }
         if (*chan->custom_modes)
         {
-                strlcat(scratch,chan->custom_modes,MAXMODES);
-                for (int z = 0; chan->custom_modes[z] != 0; z++)
+               for (char* t = chan->custom_modes; *t; t++)
+                       *offset++ = *t;
+                for (int z = 0; chan->custom_modes[z]; z++)
                 {
                         std::string extparam = chan->GetModeParameter(chan->custom_modes[z]);
                         if (extparam != "")
@@ -891,7 +805,8 @@ char* chanmodes(chanrec *chan)
                         }
                 }
         }
-        log(DEBUG,"chanmodes: %s %s%s",chan->name,scratch,sparam);
+       /* Null terminate scratch */
+       *offset = '\0';
         strlcat(scratch,sparam,MAXMODES);
         return scratch;
 }
@@ -993,9 +908,9 @@ int usercount(chanrec *c)
 
 char* Passwd(userrec *user)
 {
-        for (ClassVector::iterator i = Classes.begin(); i != Classes.end(); i++)
+        for (ClassVector::iterator i = Config->Classes.begin(); i != Config->Classes.end(); i++)
         {
-                if (match(user->host,i->host) && (i->type == CC_ALLOW))
+                if ((i->type == CC_ALLOW) && match(user->host,i->host))
                 {
                         return i->pass;
                 }
@@ -1005,9 +920,9 @@ char* Passwd(userrec *user)
 
 bool IsDenied(userrec *user)
 {
-        for (ClassVector::iterator i = Classes.begin(); i != Classes.end(); i++)
+        for (ClassVector::iterator i = Config->Classes.begin(); i != Config->Classes.end(); i++)
         {
-                if (match(user->host,i->host) && (i->type == CC_DENY))
+                if ((i->type == CC_DENY) && match(user->host,i->host))
                 {
                         return true;
                 }
@@ -1026,15 +941,18 @@ void send_error(char *s)
         log(DEBUG,"send_error: %s",s);
         for (user_hash::const_iterator i = clientlist.begin(); i != clientlist.end(); i++)
         {
-                if (isnick(i->second->nick))
-                {
-                        WriteServ(i->second->fd,"NOTICE %s :%s",i->second->nick,s);
-                }
-                else
-                {
-                        // fix - unregistered connections receive ERROR, not NOTICE
-                        Write(i->second->fd,"ERROR :%s",s);
-                }
+                if (IS_LOCAL(i->second))
+               {
+                       if (i->second->registered == 7)
+                       {
+                               WriteServ(i->second->fd,"NOTICE %s :%s",i->second->nick,s);
+                       }
+                       else
+                       {
+                               // fix - unregistered connections receive ERROR, not NOTICE
+                               Write(i->second->fd,"ERROR :%s",s);
+                       }
+               }
         }
 }
 
@@ -1118,22 +1036,21 @@ long local_count()
 
 void ShowMOTD(userrec *user)
 {
-        char buf[65536];
+        static char mbuf[MAXBUF];
+       static char crud[MAXBUF];
         std::string WholeMOTD = "";
         if (!Config->MOTD.size())
         {
                 WriteServ(user->fd,"422 %s :Message of the day file is missing.",user->nick);
                 return;
         }
-        snprintf(buf,65535,":%s 375 %s :- %s message of the day\r\n", Config->ServerName, user->nick, Config->ServerName);
-        WholeMOTD = WholeMOTD + buf;
+       snprintf(crud,MAXBUF,":%s 372 %s :- ", Config->ServerName, user->nick);
+        snprintf(mbuf,MAXBUF,":%s 375 %s :- %s message of the day\r\n", Config->ServerName, user->nick, Config->ServerName);
+        WholeMOTD = WholeMOTD + mbuf;
         for (unsigned int i = 0; i < Config->MOTD.size(); i++)
-        {
-                snprintf(buf,65535,":%s 372 %s :- %s\r\n", Config->ServerName, user->nick, Config->MOTD[i].c_str());
-                WholeMOTD = WholeMOTD + buf;
-        }
-        snprintf(buf,65535,":%s 376 %s :End of message of the day.\r\n", Config->ServerName, user->nick);
-        WholeMOTD = WholeMOTD + buf;
+                WholeMOTD = WholeMOTD + std::string(crud) + Config->MOTD[i].c_str() + std::string("\r\n");
+        snprintf(mbuf,MAXBUF,":%s 376 %s :End of message of the day.\r\n", Config->ServerName, user->nick);
+        WholeMOTD = WholeMOTD + mbuf;
         // only one write operation
         user->AddWriteBuf(WholeMOTD);
         stats->statsSent += WholeMOTD.length();
@@ -1148,9 +1065,7 @@ void ShowRULES(userrec *user)
         }
         WriteServ(user->fd,"NOTICE %s :%s rules",user->nick,Config->ServerName);
         for (unsigned int i = 0; i < Config->RULES.size(); i++)
-        {
                 WriteServ(user->fd,"NOTICE %s :%s",user->nick,Config->RULES[i].c_str());
-        }
         WriteServ(user->fd,"NOTICE %s :End of %s rules.",user->nick,Config->ServerName);
 }
 
@@ -1162,8 +1077,8 @@ bool AllModulesReportReady(userrec* user)
         for (int i = 0; i <= MODCOUNT; i++)
         {
                 int res = modules[i]->OnCheckReady(user);
-                        if (!res)
-                                return false;
+                if (!res)
+                        return false;
         }
         return true;
 }
@@ -1244,10 +1159,11 @@ void SetupCommandTable(void)
 bool DirValid(char* dirandfile)
 {
         char work[MAXBUF];
+       char buffer[MAXBUF], otherdir[MAXBUF];
         strlcpy(work,dirandfile,MAXBUF);
         int p = strlen(work);
         // we just want the dir
-        while (strlen(work))
+        while (*work)
         {
                 if (work[p] == '/')
                 {
@@ -1256,7 +1172,6 @@ bool DirValid(char* dirandfile)
                 }
                 work[p--] = '\0';
         }
-        char buffer[MAXBUF], otherdir[MAXBUF];
         // Get the current working directory
         if( getcwd( buffer, MAXBUF ) == NULL )
                 return false;
@@ -1279,10 +1194,11 @@ bool DirValid(char* dirandfile)
 std::string GetFullProgDir(char** argv, int argc)
 {
         char work[MAXBUF];
+       char buffer[MAXBUF], otherdir[MAXBUF];
         strlcpy(work,argv[0],MAXBUF);
         int p = strlen(work);
         // we just want the dir
-        while (strlen(work))
+        while (*work)
         {
                 if (work[p] == '/')
                 {
@@ -1291,7 +1207,6 @@ std::string GetFullProgDir(char** argv, int argc)
                 }
                 work[p--] = '\0';
         }
-        char buffer[MAXBUF], otherdir[MAXBUF];
         // Get the current working directory
         if( getcwd( buffer, MAXBUF ) == NULL )
                 return "";