]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/helperfuncs.cpp
Removal of ancient TRUE/FALSE #defines (C-ish stuff)
[user/henk/code/inspircd.git] / src / helperfuncs.cpp
index 52f365fb2430f69fec8ba253542f9bc419f93ea9..c910e0f2b89f38fdbbadd456d50f2562c7141c5d 100644 (file)
@@ -55,7 +55,6 @@ extern ServerConfig *Config;
 extern InspIRCd* ServerInstance;
 extern time_t TIME;
 extern char lowermap[255];
-static char list[MAXBUF];
 extern userrec* fd_ref_table[MAX_DESCRIPTORS];
 static char already_sent[MAX_DESCRIPTORS];
 extern std::vector<userrec*> all_opers;
@@ -458,7 +457,7 @@ void WriteChannel(chanrec* Ptr, userrec* user, char* text, ...)
 {
        char textbuffer[MAXBUF];
        va_list argsPtr;
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!user) || (!text))
        {
@@ -472,20 +471,16 @@ void WriteChannel(chanrec* Ptr, userrec* user, char* text, ...)
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX - WHAT THE HELL are we doing here? :P --w00t */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if (otheruser->fd != FD_MAGIC_NUMBER)
-                       WriteTo_NoFormat(user,otheruser,textbuffer);
+               if (i->second->fd != FD_MAGIC_NUMBER)
+                       WriteTo_NoFormat(user,i->second,textbuffer);
        }
 }
 
 void WriteChannel_NoFormat(chanrec* Ptr, userrec* user, const char* text)
 {
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!user) || (!text))
        {
@@ -495,14 +490,10 @@ void WriteChannel_NoFormat(chanrec* Ptr, userrec* user, const char* text)
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX - .....and here! --w00t */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if (otheruser->fd != FD_MAGIC_NUMBER)
-                       WriteTo_NoFormat(user,otheruser,text);
+               if (i->second->fd != FD_MAGIC_NUMBER)
+                       WriteTo_NoFormat(user,i->second,text);
        }
 }
 
@@ -515,7 +506,7 @@ void WriteChannelLocal(chanrec* Ptr, userrec* user, char* text, ...)
 {
        char textbuffer[MAXBUF];
        va_list argsPtr;
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!text))
        {
@@ -529,21 +520,17 @@ void WriteChannelLocal(chanrec* Ptr, userrec* user, char* text, ...)
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX -- w00t */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if ((otheruser->fd != FD_MAGIC_NUMBER) && (otheruser != user))
+               if ((i->second->fd != FD_MAGIC_NUMBER) && (i->second != user))
                {
                        if (!user)
                        {
-                               WriteServ_NoFormat(otheruser->fd,textbuffer);
+                               WriteServ_NoFormat(i->second->fd,textbuffer);
                        }
                        else
                        {
-                               WriteTo_NoFormat(user,otheruser,textbuffer);
+                               WriteTo_NoFormat(user,i->second,textbuffer);
                        }
                }
        }
@@ -551,7 +538,7 @@ void WriteChannelLocal(chanrec* Ptr, userrec* user, char* text, ...)
 
 void WriteChannelLocal_NoFormat(chanrec* Ptr, userrec* user, const char* text)
 {
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!text))
        {
@@ -561,21 +548,17 @@ void WriteChannelLocal_NoFormat(chanrec* Ptr, userrec* user, const char* text)
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX -- w00t */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if ((otheruser->fd != FD_MAGIC_NUMBER) && (otheruser != user))
+               if ((i->second->fd != FD_MAGIC_NUMBER) && (i->second != user))
                {
                        if (!user)
                        {
-                               WriteServ_NoFormat(otheruser->fd,text);
+                               WriteServ_NoFormat(i->second->fd,text);
                        }
                        else
                        {
-                               WriteTo_NoFormat(user,otheruser,text);
+                               WriteTo_NoFormat(user,i->second,text);
                        }
                }
        }
@@ -587,7 +570,7 @@ void WriteChannelWithServ(char* ServName, chanrec* Ptr, char* text, ...)
 {
        char textbuffer[MAXBUF];
        va_list argsPtr;
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!text))
        {
@@ -601,20 +584,16 @@ void WriteChannelWithServ(char* ServName, chanrec* Ptr, char* text, ...)
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if (IS_LOCAL(otheruser))
-                       WriteServ_NoFormat(otheruser->fd,textbuffer);
+               if (IS_LOCAL(i->second))
+                       WriteServ_NoFormat(i->second->fd,textbuffer);
        }
 }
 
 void WriteChannelWithServ_NoFormat(char* ServName, chanrec* Ptr, const char* text)
 {
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!text))
        {
@@ -624,14 +603,10 @@ void WriteChannelWithServ_NoFormat(char* ServName, chanrec* Ptr, const char* tex
 
        ulist = Ptr->GetUsers();
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if (IS_LOCAL(otheruser))
-                       WriteServ_NoFormat(otheruser->fd,text);
+               if (IS_LOCAL(i->second))
+                       WriteServ_NoFormat(i->second->fd,text);
        }
 }
 
@@ -644,7 +619,7 @@ void ChanExceptSender(chanrec* Ptr, userrec* user, char status, char* text, ...)
 {
        char textbuffer[MAXBUF];
        va_list argsPtr;
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!user) || (!text))
        {
@@ -674,20 +649,16 @@ void ChanExceptSender(chanrec* Ptr, userrec* user, char status, char* text, ...)
 
        log(DEBUG,"%d users to write to",ulist->size());
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if ((IS_LOCAL(otheruser)) && (user != otheruser))
-                       WriteFrom_NoFormat(otheruser->fd,user,textbuffer);
+               if ((IS_LOCAL(i->second)) && (user != i->second))
+                       WriteFrom_NoFormat(i->second->fd,user,textbuffer);
        }
 }
 
 void ChanExceptSender_NoFormat(chanrec* Ptr, userrec* user, char status, const char* text)
 {
-       std::map<char*,char*> *ulist;
+       CUList *ulist;
 
        if ((!Ptr) || (!user) || (!text))
        {
@@ -711,14 +682,10 @@ void ChanExceptSender_NoFormat(chanrec* Ptr, userrec* user, char status, const c
                        break;
        }
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               /* XXX */
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-
-               if ((IS_LOCAL(otheruser)) && (user != otheruser))
-                       WriteFrom_NoFormat(otheruser->fd,user,text);
+               if ((IS_LOCAL(i->second)) && (user != i->second))
+                       WriteFrom_NoFormat(i->second->fd,user,text);
        }
 }
 
@@ -747,7 +714,6 @@ void WriteCommon(userrec *u, char* text, ...)
        char textbuffer[MAXBUF];
        va_list argsPtr;
        bool sent_to_at_least_one = false;
-       unsigned int y;
 
        if (!u)
        {
@@ -767,23 +733,19 @@ void WriteCommon(userrec *u, char* text, ...)
 
        // FIX: Stops a message going to the same person more than once
        memset(&already_sent,0,MAX_DESCRIPTORS);
-       y = u->chans.size();
 
-       for (unsigned int i = 0; i < y; i++)
+       for (std::vector<ucrec*>::const_iterator v = u->chans.begin(); v != u->chans.end(); v++)
        {
-               if (u->chans[i].channel)
+               if (((ucrec*)(*v))->channel)
                {
-                       std::map<char*,char*> *ulist= u->chans[i].channel->GetUsers();
+                       CUList *ulist= ((ucrec*)(*v))->channel->GetUsers();
 
-                       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
-                               char* o = i->second;
-                               userrec* otheruser = (userrec*)o;
-
-                               if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
+                               if ((i->second->fd > -1) && (!already_sent[i->second->fd]))
                                {
-                                       already_sent[otheruser->fd] = 1;
-                                       WriteFrom_NoFormat(otheruser->fd,u,textbuffer);
+                                       already_sent[i->second->fd] = 1;
+                                       WriteFrom_NoFormat(i->second->fd,u,textbuffer);
                                        sent_to_at_least_one = true;
                                }
                        }
@@ -803,7 +765,6 @@ void WriteCommon(userrec *u, char* text, ...)
 void WriteCommon_NoFormat(userrec *u, const char* text)
 {
        bool sent_to_at_least_one = false;
-       unsigned int y;
 
        if (!u)
        {
@@ -819,23 +780,19 @@ void WriteCommon_NoFormat(userrec *u, const char* text)
 
        // FIX: Stops a message going to the same person more than once
        memset(&already_sent,0,MAX_DESCRIPTORS);
-       y = u->chans.size();
 
-       for (unsigned int i = 0; i < y; i++)
+       for (std::vector<ucrec*>::const_iterator v = u->chans.begin(); v != u->chans.end(); v++)
        {
-               if (u->chans[i].channel)
+               if (((ucrec*)(*v))->channel)
                {
-                       std::map<char*,char*> *ulist= u->chans[i].channel->GetUsers();
+                       CUList *ulist= ((ucrec*)(*v))->channel->GetUsers();
 
-                       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
-                               char* o = i->second;
-                               userrec* otheruser = (userrec*)o;
-
-                               if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
+                               if ((i->second->fd > -1) && (!already_sent[i->second->fd]))
                                {
-                                       already_sent[otheruser->fd] = 1;
-                                       WriteFrom_NoFormat(otheruser->fd,u,text);
+                                       already_sent[i->second->fd] = 1;
+                                       WriteFrom_NoFormat(i->second->fd,u,text);
                                        sent_to_at_least_one = true;
                                }
                        }
@@ -864,7 +821,6 @@ void WriteCommonExcept(userrec *u, char* text, ...)
        bool quit_munge = false;
        va_list argsPtr;
        int total;
-       unsigned int y;
 
        if (!u)
        {
@@ -887,7 +843,6 @@ void WriteCommonExcept(userrec *u, char* text, ...)
                /* Yeah yeah, this is ugly. But its fast, live with it. */
                char* check = textbuffer;
 
-               /* XXX - don't mean to be picky, but I think this could be done better */
                if ((*check++ == 'Q') && (*check++ == 'U') && (*check++ == 'I') && (*check++ == 'T') && (*check++ == ' ') && (*check++ == ':'))
                {
                        std::stringstream split(check);
@@ -925,31 +880,27 @@ void WriteCommonExcept(userrec *u, char* text, ...)
        }
 
        memset(&already_sent,0,MAX_DESCRIPTORS);
-       y = u->chans.size();
 
-       for (unsigned int i = 0; i < y; i++)
+       for (std::vector<ucrec*>::const_iterator v = u->chans.begin(); v != u->chans.end(); v++)
        {
-               if (u->chans[i].channel)
+               if (((ucrec*)(*v))->channel)
                {
-                       std::map<char*,char*> *ulist= u->chans[i].channel->GetUsers();
+                       CUList *ulist= ((ucrec*)(*v))->channel->GetUsers();
 
-                       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
-                               char* o = i->second;
-                               userrec* otheruser = (userrec*)o;
-
-                               if (u != otheruser)
+                               if (u != i->second)
                                {
-                                       if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
+                                       if ((i->second->fd > -1) && (!already_sent[i->second->fd]))
                                        {
-                                               already_sent[otheruser->fd] = 1;
+                                               already_sent[i->second->fd] = 1;
 
                                                if (quit_munge)
                                                {
-                                                       WriteFrom_NoFormat(otheruser->fd,u,*otheruser->oper ? oper_quit : textbuffer);
+                                                       WriteFrom_NoFormat(i->second->fd,u,*i->second->oper ? oper_quit : textbuffer);
                                                }
                                                else
-                                                       WriteFrom_NoFormat(otheruser->fd,u,textbuffer);
+                                                       WriteFrom_NoFormat(i->second->fd,u,textbuffer);
                                        }
                                }
                        }
@@ -959,8 +910,6 @@ void WriteCommonExcept(userrec *u, char* text, ...)
 
 void WriteCommonExcept_NoFormat(userrec *u, const char* text)
 {
-       unsigned int y;
-
        if (!u)
        {
                log(DEFAULT,"*** BUG *** WriteCommon was given an invalid parameter");
@@ -974,25 +923,21 @@ void WriteCommonExcept_NoFormat(userrec *u, const char* text)
        }
 
        memset(&already_sent,0,MAX_DESCRIPTORS);
-       y = u->chans.size();
 
-       for (unsigned int i = 0; i < y; i++)
+       for (std::vector<ucrec*>::const_iterator v = u->chans.begin(); v != u->chans.end(); v++)
        {
-               if (u->chans[i].channel)
+               if (((ucrec*)(*v))->channel)
                {
-                       std::map<char*,char*> *ulist= u->chans[i].channel->GetUsers();
+                       CUList *ulist= ((ucrec*)(*v))->channel->GetUsers();
 
-                       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
-                               char* o = i->second;
-                               userrec* otheruser = (userrec*)o;
-
-                               if (u != otheruser)
+                               if (u != i->second)
                                {
-                                       if ((otheruser->fd > -1) && (!already_sent[otheruser->fd]))
+                                       if ((i->second->fd > -1) && (!already_sent[i->second->fd]))
                                        {
-                                               already_sent[otheruser->fd] = 1;
-                                               WriteFrom_NoFormat(otheruser->fd,u,text);
+                                               already_sent[i->second->fd] = 1;
+                                               WriteFrom_NoFormat(i->second->fd,u,text);
                                        }
                                }
                        }
@@ -1001,7 +946,13 @@ void WriteCommonExcept_NoFormat(userrec *u, const char* text)
 }
 
 
-/* XXX - replace with a call to WriteMode() ? -- w00t */
+/* XXX - We don't use WriteMode for this because WriteMode is very slow and
+ * this isnt. Basically WriteMode has to iterate ALL the users 'n' times for
+ * the number of modes provided, e.g. if you send WriteMode 'og' to write to
+ * opers with globops, and you have 2000 users, thats 4000 iterations. WriteOpers
+ * uses the oper list, which means if you have 2000 users but only 5 opers,
+ * it iterates 5 times.
+ */
 void WriteOpers(char* text, ...)
 {
        char textbuffer[MAXBUF];
@@ -1023,7 +974,7 @@ void WriteOpers(char* text, ...)
 
                if (IS_LOCAL(a))
                {
-                       if (strchr(a->modes,'s'))
+                       if (a->modebits & UM_SERVERNOTICE)
                        {
                                // send server notices to all with +s
                                WriteServ(a->fd,"NOTICE %s :%s",a->nick,textbuffer);
@@ -1038,15 +989,18 @@ void ServerNoticeAll(char* text, ...)
                return;
 
        char textbuffer[MAXBUF];
+       char formatbuffer[MAXBUF];
        va_list argsPtr;
        va_start (argsPtr, text);
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
+       snprintf(formatbuffer,MAXBUF,"NOTICE $%s :%s",Config->ServerName,textbuffer);
+
        for (std::vector<userrec*>::const_iterator i = local_users.begin(); i != local_users.end(); i++)
        {
                userrec* t = (userrec*)(*i);
-               WriteServ(t->fd,"NOTICE $%s :%s",Config->ServerName,textbuffer);
+               WriteServ_NoFormat(t->fd,formatbuffer);
        }
 }
 
@@ -1056,15 +1010,18 @@ void ServerPrivmsgAll(char* text, ...)
                return;
 
        char textbuffer[MAXBUF];
+       char formatbuffer[MAXBUF];
        va_list argsPtr;
        va_start (argsPtr, text);
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
+       snprintf(formatbuffer,MAXBUF,"NOTICE $%s :%s",Config->ServerName,textbuffer);
+
        for (std::vector<userrec*>::const_iterator i = local_users.begin(); i != local_users.end(); i++)
        {
                userrec* t = (userrec*)(*i);
-               WriteServ(t->fd,"PRIVMSG $%s :%s",Config->ServerName,textbuffer);
+               WriteServ_NoFormat(t->fd,formatbuffer);
        }
 }
 
@@ -1127,6 +1084,7 @@ void WriteMode(const char* modes, int flags, const char* text, ...)
 void NoticeAll(userrec *source, bool local_only, char* text, ...)
 {
        char textbuffer[MAXBUF];
+       char formatbuffer[MAXBUF];
        va_list argsPtr;
 
        if ((!text) || (!source))
@@ -1139,10 +1097,12 @@ void NoticeAll(userrec *source, bool local_only, char* text, ...)
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
+       snprintf(formatbuffer,MAXBUF,"NOTICE $* :%s",textbuffer);
+
        for (std::vector<userrec*>::const_iterator i = local_users.begin(); i != local_users.end(); i++)
        {
                userrec* t = (userrec*)(*i);
-               WriteFrom(t->fd,source,"NOTICE $* :%s",textbuffer);
+               WriteFrom_NoFormat(t->fd,source,formatbuffer);
        }
 }
 
@@ -1150,6 +1110,7 @@ void NoticeAll(userrec *source, bool local_only, char* text, ...)
 void WriteWallOps(userrec *source, bool local_only, char* text, ...)
 {
        char textbuffer[MAXBUF];
+       char formatbuffer[MAXBUF];
        va_list argsPtr;
 
        if ((!text) || (!source))
@@ -1162,13 +1123,15 @@ void WriteWallOps(userrec *source, bool local_only, char* text, ...)
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
+       snprintf(formatbuffer,MAXBUF,"WALLOPS :%s",textbuffer);
+
        for (std::vector<userrec*>::const_iterator i = local_users.begin(); i != local_users.end(); i++)
        {
                userrec* t = (userrec*)(*i);
 
-               if ((IS_LOCAL(t)) && (strchr(t->modes,'w')))
+               if ((IS_LOCAL(t)) && (t->modebits & UM_WALLOPS))
                {
-                       WriteTo(source,t,"WALLOPS :%s",textbuffer);
+                       WriteTo_NoFormat(source,t,formatbuffer);
                }
        }
 }
@@ -1193,7 +1156,7 @@ void strlower(char *n)
 
 /* Find a user record by nickname and return a pointer to it */
 
-userrec* Find(std::string nick)
+userrec* Find(const std::string &nick)
 {
        user_hash::iterator iter = clientlist.find(nick);
 
@@ -1257,50 +1220,38 @@ long GetMaxBans(char* name)
 
 void purge_empty_chans(userrec* u)
 {
-       int purge = 0;
+       std::vector<chanrec*> to_delete;
 
        // firstly decrement the count on each channel
-       for (unsigned int f = 0; f < u->chans.size(); f++)
+       for (std::vector<ucrec*>::iterator f = u->chans.begin(); f != u->chans.end(); f++)
        {
-               if (u->chans[f].channel)
+               if (((ucrec*)(*f))->channel)
                {
-                       u->chans[f].channel->DelUser((char*)u);
+                       if (((ucrec*)(*f))->channel->DelUser(u) == 0)
+                       {
+                               /* No users left in here, mark it for deletion */
+                               to_delete.push_back(((ucrec*)(*f))->channel);
+                               ((ucrec*)(*f))->channel = NULL;
+                       }
                }
        }
 
-       for (unsigned int i = 0; i < u->chans.size(); i++)
+       log(DEBUG,"purge_empty_chans: %d channels to delete",to_delete.size());
+
+       for (std::vector<chanrec*>::iterator n = to_delete.begin(); n != to_delete.end(); n++)
        {
-               if (u->chans[i].channel)
+               chanrec* thischan = (chanrec*)*n;
+               chan_hash::iterator i2 = chanlist.find(thischan->name);
+               if (i2 != chanlist.end())
                {
-                       if (!usercount(u->chans[i].channel))
-                       {
-                               chan_hash::iterator i2 = chanlist.find(u->chans[i].channel->name);
-
-                               /* kill the record */
-                               if (i2 != chanlist.end())
-                               {
-                                       log(DEBUG,"del_channel: destroyed: %s",i2->second->name);
-
-                                       if (i2->second)
-                                       {
-                                               FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(i2->second));
-                                               delete i2->second;
-                                       }
-
-                                       chanlist.erase(i2);
-                                       purge++;
-                                       u->chans[i].channel = NULL;
-                               }
-                       }
-                       else
-                       {
-                               log(DEBUG,"skipped purge for %s",u->chans[i].channel->name);
-                       }
+                       FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(i2->second));
+                       delete i2->second;
+                       chanlist.erase(i2);
                }
        }
 
-       log(DEBUG,"completed channel purge, killed %lu",(unsigned long)purge);
-       DeleteOper(u);
+       if (*u->oper)
+               DeleteOper(u);
 }
 
 
@@ -1309,6 +1260,7 @@ char* chanmodes(chanrec *chan, bool showkey)
        static char scratch[MAXBUF];
        static char sparam[MAXBUF];
        char* offset = scratch;
+       std::string extparam = "";
 
        if (!chan)
        {
@@ -1320,42 +1272,33 @@ char* chanmodes(chanrec *chan, bool showkey)
        *scratch = '\0';
        *sparam = '\0';
 
-       if (chan->binarymodes & CM_NOEXTERNAL)
-               *offset++ = 'n';
-       if (chan->binarymodes & CM_TOPICLOCK)
-               *offset++ = 't';
-       if (*chan->key)
-               *offset++ = 'k';
-       if (chan->limit)
-               *offset++ = 'l';
-       if (chan->binarymodes & CM_INVITEONLY)
-               *offset++ = 'i';
-       if (chan->binarymodes & CM_MODERATED)
-               *offset++ = 'm';
-       if (chan->binarymodes & CM_SECRET)
-               *offset++ = 's';
-       if (chan->binarymodes & CM_PRIVATE)
-               *offset++ = 'p';
-
-       if (*chan->key)
-       {
-               snprintf(sparam,MAXBUF," %s",showkey ? chan->key : "<key>");
-       }
-
-       if (chan->limit)
-       {
-               char foo[24];
-               sprintf(foo," %lu",(unsigned long)chan->limit);
-               strlcat(sparam,foo,MAXBUF);
-       }
-
-       for (int n = 0; n < 190; n++)
+       /* This was still iterating up to 190, chanrec::custom_modes is only 64 elements -- Om */
+       for(int n = 0; n < 64; n++)
        {
-               if (chan->custom_modes[n])
+               if(chan->modes[n])
                {
                        *offset++ = n+65;
-                       std::string extparam = chan->GetModeParameter(n+65);
-
+                       extparam = "";
+                       switch (n)
+                       {
+                               case CM_KEY:
+                                       extparam = (showkey ? chan->key : "<key>");
+                               break;
+                               case CM_LIMIT:
+                                       extparam = ConvToStr(chan->limit);
+                               break;
+                               case CM_NOEXTERNAL:
+                               case CM_TOPICLOCK:
+                               case CM_INVITEONLY:
+                               case CM_MODERATED:
+                               case CM_SECRET:
+                               case CM_PRIVATE:
+                                       /* We know these have no parameters */
+                               break;
+                               default:
+                                       extparam = chan->GetModeParameter(n+65);
+                               break;
+                       }
                        if (extparam != "")
                        {
                                charlcat(sparam,' ',MAXBUF);
@@ -1382,17 +1325,24 @@ void userlist(userrec *user,chanrec *c)
                return;
        }
 
-       size_t dlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, c->name);
-       size_t initial = dlen;
+       char list[MAXBUF];
+       size_t dlen, curlen;
 
-       std::map<char*,char*> *ulist= c->GetUsers();
+       dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, c->name);
 
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
-       {
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
+       int numusers = 0;
+       char* ptr = list + dlen;
+
+       CUList *ulist= c->GetUsers();
+
+       /* Improvement by Brain - this doesnt change in value, so why was it inside
+        * the loop?
+        */
+       bool has_user = c->HasUser(user);
 
-               if ((!has_channel(user,c)) && (strchr(otheruser->modes,'i')))
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+       {
+               if ((!has_user) && (i->second->modebits & UM_INVISIBLE))
                {
                        /*
                         * user is +i, and source not on the channel, does not show
@@ -1401,21 +1351,29 @@ void userlist(userrec *user,chanrec *c)
                        continue;
                }
 
-               dlen += strlcat(list,cmode(otheruser,c),MAXBUF);
-               dlen += strlcat(list,otheruser->nick,MAXBUF);
-               charlcat(list,' ',MAXBUF);
-               dlen++;
+               size_t ptrlen = snprintf(ptr, MAXBUF, "%s%s ", cmode(i->second, c), i->second->nick);
+
+               curlen += ptrlen;
+               ptr += ptrlen;
+
+               numusers++;
 
-               if (dlen > (480-NICKMAX))
+               if (curlen > (480-NICKMAX))
                {
                        /* list overflowed into multiple numerics */
                        WriteServ_NoFormat(user->fd,list);
-                       dlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, c->name);
+
+                       /* reset our lengths */
+                       dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, c->name);
+                       ptr = list + dlen;
+
+                       ptrlen = 0;
+                       numusers = 0;
                }
        }
 
        /* if whats left in the list isnt empty, send it */
-       if (dlen != initial)
+       if (numusers)
        {
                WriteServ_NoFormat(user->fd,list);
        }
@@ -1432,12 +1390,10 @@ int usercount_i(chanrec *c)
        if (!c)
                return 0;
 
-       std::map<char*,char*> *ulist= c->GetUsers();
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       CUList *ulist= c->GetUsers();
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               char* o = i->second;
-               userrec* user = (userrec*)o;
-               if (!strchr(user->modes,'i'))
+               if (!(i->second->modebits & UM_INVISIBLE))
                        count++;
        }
 
@@ -1526,7 +1482,7 @@ int usercount_invisible(void)
 
        for (user_hash::const_iterator i = clientlist.begin(); i != clientlist.end(); i++)
        {
-               if ((i->second->registered == 7) && (strchr(i->second->modes,'i')))
+               if ((i->second->registered == 7) && (i->second->modebits & UM_INVISIBLE))
                        c++;
        }
 
@@ -1830,9 +1786,8 @@ bool charremove(char* mp, char remove)
                if (shift_down)
                        *mptr = *(mptr+1);
 
-               *mptr++;
+               mptr++;
        }
 
        return shift_down;
 }
-