]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspircd.cpp
*** empty log message ***
[user/henk/code/inspircd.git] / src / inspircd.cpp
index 4464be7559dbab30c4a8bd7b1891baceb3f39f51..4e6e0f86c9631b2519aef412e9c3556d5c345933 100644 (file)
@@ -27,11 +27,18 @@ using namespace std;
 #include <sys/errno.h>
 #include <sys/ioctl.h>
 #include <sys/utsname.h>
+
 #ifdef USE_KQUEUE
 #include <sys/types.h>
 #include <sys/event.h>
 #include <sys/time.h>
 #endif
+
+#ifdef USE_EPOLL
+#include <sys/epoll.h>
+#define EP_DELAY 50
+#endif
+
 #include <time.h>
 #include <string>
 #ifdef GCC3
@@ -81,7 +88,8 @@ int WHOWAS_STALE = 48; // default WHOWAS Entries last 2 days before they go 'sta
 int WHOWAS_MAX = 100;  // default 100 people maximum in the WHOWAS list
 int DieDelay  =  5;
 time_t startup_time = time(NULL);
-int NetBufferSize = 10240; // NetBufferSize used as the buffer size for all read() ops
+int NetBufferSize = 10240;     // NetBufferSize used as the buffer size for all read() ops
+int MaxConn = SOMAXCONN;       // size of accept() backlog (128 by default on *BSD)
 extern int MaxWhoResults;
 time_t nb_start = 0;
 int dns_timeout = 5;
@@ -107,6 +115,10 @@ time_t TIME = time(NULL), OLDTIME = time(NULL);
 int kq, lkq, skq;
 #endif
 
+#ifdef USE_EPOLL
+int ep, lep, sep;
+#endif
+
 typedef nspace::hash_map<std::string, userrec*, nspace::hash<string>, irc::StrHashComp> user_hash;
 typedef nspace::hash_map<std::string, chanrec*, nspace::hash<string>, irc::StrHashComp> chan_hash;
 typedef nspace::hash_map<in_addr,string*, nspace::hash<in_addr>, irc::InAddr_HashComp> address_cache;
@@ -221,7 +233,7 @@ std::string getadminnick()
 
 void ReadConfig(bool bail, userrec* user)
 {
-       char dbg[MAXBUF],pauseval[MAXBUF],Value[MAXBUF],timeout[MAXBUF],NB[MAXBUF],flood[MAXBUF],MW[MAXBUF];
+       char dbg[MAXBUF],pauseval[MAXBUF],Value[MAXBUF],timeout[MAXBUF],NB[MAXBUF],flood[MAXBUF],MW[MAXBUF],MCON[MAXBUF];
        char AH[MAXBUF],AP[MAXBUF],AF[MAXBUF],DNT[MAXBUF],pfreq[MAXBUF],thold[MAXBUF],sqmax[MAXBUF],rqmax[MAXBUF];
        ConnectClass c;
        std::stringstream errstr;
@@ -282,12 +294,18 @@ void ReadConfig(bool bail, userrec* user)
        ConfValue("dns","timeout",0,DNT,&config_f);
        ConfValue("options","moduledir",0,ModPath,&config_f);
         ConfValue("disabled","commands",0,DisabledCommands,&config_f);
+       ConfValue("options","somaxconn",0,MCON,&config_f);
 
+       MaxConn = atoi(MCON);
+       if (MaxConn > SOMAXCONN)
+               log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
        NetBufferSize = atoi(NB);
        MaxWhoResults = atoi(MW);
        dns_timeout = atoi(DNT);
        if (!dns_timeout)
                dns_timeout = 5;
+       if (!MaxConn)
+               MaxConn = SOMAXCONN;
        if (!DNSServer[0])
                strlcpy(DNSServer,"127.0.0.1",MAXBUF);
        if (!ModPath[0])
@@ -1063,6 +1081,8 @@ void kill_link(userrec *user,const char* r)
                NetSendToAll(buffer);
        }
 
+       user->FlushWriteBuf();
+
        FOREACH_MOD OnUserDisconnect(user);
 
        if (user->fd > -1)
@@ -1076,19 +1096,28 @@ void kill_link(userrec *user,const char* r)
                {
                        log(DEBUG,"kqueue: Failed to remove user from queue!");
                }
+#endif
+#ifdef USE_EPOLL
+               struct epoll_event ev;
+               ev.events = EPOLLIN | EPOLLET;
+               ev.data.fd = user->fd;
+               int i = epoll_ctl(ep, EPOLL_CTL_DEL, user->fd, &ev);
+               if (i < 0)
+               {
+                       log(DEBUG,"epoll: List deletion failure!");
+               }
 #endif
                 shutdown(user->fd,2);
                 close(user->fd);
        }
-       
-       if (user->registered == 7) {
-               WriteOpers("*** Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason);
-               AddWhoWas(user);
-       }
 
+       // this must come before the WriteOpers so that it doesnt try to fill their buffer with anything
+       // if they were an oper with +s.
         if (user->registered == 7) {
                 purge_empty_chans(user);
-        }
+               WriteOpers("*** Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason);
+               AddWhoWas(user);
+       }
 
        if (iter != clientlist.end())
        {
@@ -1117,6 +1146,8 @@ void kill_link_silent(userrec *user,const char* r)
        Write(user->fd,"ERROR :Closing link (%s@%s) [%s]",user->ident,user->host,reason);
        log(DEBUG,"closing fd %lu",(unsigned long)user->fd);
 
+       user->FlushWriteBuf();
+
        if (user->registered == 7) {
                FOREACH_MOD OnUserQuit(user);
                WriteCommonExcept(user,"QUIT :%s",reason);
@@ -1140,6 +1171,16 @@ void kill_link_silent(userrec *user,const char* r)
                 {
                         log(DEBUG,"kqueue: Failed to remove user from queue!");
                 }
+#endif
+#ifdef USE_EPOLL
+                struct epoll_event ev;
+                ev.events = EPOLLIN | EPOLLET;
+                ev.data.fd = user->fd;
+                int i = epoll_ctl(ep, EPOLL_CTL_DEL, user->fd, &ev);
+                if (i < 0)
+                {
+                        log(DEBUG,"epoll: List deletion failure!");
+                }
 #endif
                 shutdown(user->fd,2);
                 close(user->fd);
@@ -1417,6 +1458,17 @@ void AddClient(int socket, char* host, int port, bool iscached, char* ip)
        }
        fd_ref_table[socket] = clientlist[tempnick];
 
+#ifdef USE_EPOLL
+       struct epoll_event ev;
+       log(DEBUG,"epoll: Adduser to events, ep=%d socket=%d",ep,socket);
+       ev.events = EPOLLIN | EPOLLET;
+       ev.data.fd = socket;
+       int i = epoll_ctl(ep, EPOLL_CTL_ADD, socket, &ev);
+       if (i < 0)
+       {
+               log(DEBUG,"epoll: List insertion failure!");
+       }
+#endif
 #ifdef USE_KQUEUE
        struct kevent ke;
        log(DEBUG,"kqueue: Add user to events, kq=%d socket=%d",kq,socket);
@@ -1424,37 +1476,7 @@ void AddClient(int socket, char* host, int port, bool iscached, char* ip)
         int i = kevent(kq, &ke, 1, 0, 0, NULL);
         if (i == -1)
         {
-               switch (errno)
-               {
-                       case EACCES:
-                               log(DEBUG,"kqueue: EACCES");
-                       break;
-                       case EFAULT:
-                               log(DEBUG,"kqueue: EFAULT");
-                       break;
-                       case EBADF:
-                               log(DEBUG,"kqueue: EBADF=%d",ke.ident);
-                       break;
-                       case EINTR:
-                               log(DEBUG,"kqueue: EINTR");
-                       break;
-                       case EINVAL:
-                               log(DEBUG,"kqueue: EINVAL");
-                       break;
-                       case ENOENT:
-                               log(DEBUG,"kqueue: ENOENT");
-                       break;
-                       case ENOMEM:
-                               log(DEBUG,"kqueue: ENOMEM");
-                       break;
-                       case ESRCH:
-                               log(DEBUG,"kqueue: ESRCH");
-                       break;
-                       default:
-                               log(DEBUG,"kqueue: UNKNOWN!");
-                       break;
-               }
-                log(DEBUG,"kqueue: Failed to add user to queue!");
+                log(DEBUG,"kqueue: List insertion failure!");
         }
 
 #endif
@@ -1569,8 +1591,12 @@ std::string GetVersionString()
         s1 = savept;
 #ifdef USE_KQUEUE
        char socketengine[] = "kqueue";
-#else
+#endif
+#ifdef USE_SELECT
        char socketengine[] = "select";
+#endif
+#ifdef USE_EPOLL
+       char socketengine[] = "epoll";
 #endif
        snprintf(versiondata,MAXBUF,"%s Rev. %s %s :%s (O=%lu) [SE=%s]",VERSION,v2,ServerName,SYSTEM,(unsigned long)OPTIMISATION,socketengine);
        return versiondata;
@@ -2414,17 +2440,25 @@ bool UnloadModule(const char* filename)
 bool LoadModule(const char* filename)
 {
        char modfile[MAXBUF];
+#ifdef STATIC_LINK
+       snprintf(modfile,MAXBUF,"%s",filename);
+#else
        snprintf(modfile,MAXBUF,"%s/%s",ModPath,filename);
+#endif
        std::string filename_str = filename;
+#ifndef STATIC_LINK
        if (!DirValid(modfile))
        {
                log(DEFAULT,"Module %s is not within the modules directory.",modfile);
                snprintf(MODERR,MAXBUF,"Module %s is not within the modules directory.",modfile);
                return false;
        }
+#endif
        log(DEBUG,"Loading module: %s",modfile);
+#ifndef STATIC_LINK
         if (FileExists(modfile))
         {
+#endif
                for (int j = 0; j < module_names.size(); j++)
                {
                        if (module_names[j] == filename_str)
@@ -2457,6 +2491,7 @@ bool LoadModule(const char* filename)
                        snprintf(MODERR,MAXBUF,"Factory function failed!");
                        return false;
                 }
+#ifndef STATIC_LINK
         }
         else
         {
@@ -2464,6 +2499,7 @@ bool LoadModule(const char* filename)
                snprintf(MODERR,MAXBUF,"Module file could not be found");
                return false;
         }
+#endif
        MODCOUNT++;
        return true;
 }
@@ -2638,19 +2674,63 @@ int InspIRCd(char** argv, int argc)
         }
 #endif
 
+#ifdef USE_EPOLL
+       ep = epoll_create(MAXCLIENTS);
+       lep = epoll_create(32);
+       sep = epoll_create(128);
+       if ((ep == -1) || (lep == -1) || (sep == -1))
+       {
+               log(DEFAULT,"main: epoll_create() failed!");
+               printf("ERROR: could not initialise epoll event system. Shutting down.\n");
+               Exit(ERROR);
+       }
+#endif
 
+#ifdef USE_EPOLL
+       log(DEFAULT,"epoll socket engine is enabled. Filling listen list. boundPortcount=%d",boundPortCount);
+       for (count = 0; count < boundPortCount; count++)
+       {
+               struct epoll_event ev;
+               log(DEBUG,"epoll: Add listening socket to events, ep=%d socket=%d",lep,openSockfd[count]);
+               ev.events = EPOLLIN | EPOLLET;
+               ev.data.fd = openSockfd[count];
+               int i = epoll_ctl(lep, EPOLL_CTL_ADD, openSockfd[count], &ev);
+               if (i < 0)
+               {
+                       log(DEFAULT,"main: add listen ports, epoll_ctl failed!");
+                       printf("ERROR: could not initialise listening sockets in epoll list. Shutting down.\n");
+                       Exit(ERROR);
+               }
+               
+       }
+       for (int t = 0; t != SERVERportCount; t++)
+       {
+               struct epoll_event ev;
+               log(DEBUG,"epoll: Add listening server socket to events, ep=%d socket=%d",sep,me[t]->fd);
+               ev.events = EPOLLIN | EPOLLET;
+               ev.data.fd = me[t]->fd;
+               int i = epoll_ctl(sep, EPOLL_CTL_ADD, me[t]->fd, &ev);
+               if (i == -1)
+               {
+                       log(DEFAULT,"main: add server listen ports, epoll_ctl failed!");
+                       printf("ERROR: could not initialise server listening sockets in epoll list. Shutting down.\n");
+                       Exit(ERROR);
+               }
+       }
+#else
 #ifdef USE_KQUEUE
        log(DEFAULT,"kqueue socket engine is enabled. Filling listen list.");
        for (count = 0; count < boundPortCount; count++)
        {
                struct kevent ke;
                log(DEBUG,"kqueue: Add listening socket to events, kq=%d socket=%d",lkq,openSockfd[count]);
-               EV_SET(&ke, openSockfd[count], EVFILT_READ, EV_ADD, 0, 5, NULL);
+               EV_SET(&ke, openSockfd[count], EVFILT_READ, EV_ADD, 0, MaxConn, NULL);
                int i = kevent(lkq, &ke, 1, 0, 0, NULL);
                if (i == -1)
                {
                        log(DEFAULT,"main: add listen ports to kqueue failed!");
                        printf("ERROR: could not initialise listening sockets in kqueue. Shutting down.\n");
+                       Exit(ERROR);
                }
        }
         for (int t = 0; t != SERVERportCount; t++)
@@ -2659,12 +2739,13 @@ int InspIRCd(char** argv, int argc)
                 if (me[t])
                 {
                        log(DEBUG,"kqueue: Add listening SERVER socket to events, kq=%d socket=%d",skq,me[t]->fd);
-                       EV_SET(&ke, me[t]->fd, EVFILT_READ, EV_ADD, 0, 5, NULL);
+                       EV_SET(&ke, me[t]->fd, EVFILT_READ, EV_ADD, 0, MaxConn, NULL);
                        int i = kevent(skq, &ke, 1, 0, 0, NULL);
                        if (i == -1)
                        {
                                log(DEFAULT,"main: add server listen ports to kqueue failed!");
                                printf("ERROR: could not initialise listening server sockets in kqueue. Shutting down.\n");
+                               Exit(ERROR);
                        }
                }
         }
@@ -2672,6 +2753,7 @@ int InspIRCd(char** argv, int argc)
 
 #else
        log(DEFAULT,"Using standard select socket engine.");
+#endif
 #endif
 
        WritePID(PID);
@@ -2683,6 +2765,9 @@ int InspIRCd(char** argv, int argc)
         struct kevent ke;
        struct kevent ke_list[33];
         struct timespec ts;
+#endif
+#ifdef USE_EPOLL
+       struct epoll_event event[33];
 #endif
         fd_set serverfds;
         timeval tvs;
@@ -2705,10 +2790,9 @@ int InspIRCd(char** argv, int argc)
 #ifdef _POSIX_PRIORITY_SCHEDULING
                sched_yield();
 #endif
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
                FD_ZERO(&sfd);
 #endif
-
                // we only read time() once per iteration rather than tons of times!
                OLDTIME = TIME;
                TIME = time(NULL);
@@ -2730,6 +2814,16 @@ int InspIRCd(char** argv, int argc)
                // fix by brain - this must be below any manipulation of the hashmap by modules
                user_hash::iterator count2 = clientlist.begin();
 
+#ifdef USE_EPOLL
+               i = epoll_wait(sep, event, 1, EP_DELAY);
+               if (i > 0)
+               {
+                       log(DEBUG,"epoll: Listening server socket event, i=%d, event.data.fd=%d",i,event[0].data.fd);
+                       for (int x = 0; x != SERVERportCount; x++)
+                       {
+                               if ((me[x]) && (event[0].data.fd == me[x]->fd))
+                               {
+#endif
 #ifdef USE_KQUEUE
                ts.tv_sec = 0;
                ts.tv_nsec = 30000L;
@@ -2742,7 +2836,8 @@ int InspIRCd(char** argv, int argc)
                                if ((me[x]) && (ke.ident == me[x]->fd))
                                {
 
-#else
+#endif
+#ifdef USE_SELECT
                FD_ZERO(&serverfds);
                for (int x = 0; x != SERVERportCount; x++)
                {
@@ -2751,7 +2846,7 @@ int InspIRCd(char** argv, int argc)
                }
                tvs.tv_usec = 30000L;
                tvs.tv_sec = 0;
-               int servresult = select(32767, &serverfds, NULL, NULL, &tvs);
+               int servresult = select(FD_SETSIZE, &serverfds, NULL, NULL, &tvs);
                if (servresult > 0)
                {
                        for (int x = 0; x != SERVERportCount; x++)
@@ -2777,13 +2872,13 @@ int InspIRCd(char** argv, int argc)
                        }
                }
      
+               std::deque<std::string> msgs;
+               std::deque<std::string> sums;
                for (int x = 0; x < SERVERportCount; x++)
                {
-                       std::deque<std::string> msgs;
-                       std::deque<std::string> sums;
-                       msgs.clear();
                        sums.clear();
-                       if ((me[x]) && (me[x]->RecvPacket(msgs, tcp_host, sums)))
+                       msgs.clear();
+                       while ((me[x]) && (me[x]->RecvPacket(msgs, tcp_host, sums))) // returns 0 or more lines (can be multiple lines!)
                        {
                                for (int ctr = 0; ctr < msgs.size(); ctr++)
                                {
@@ -2791,7 +2886,7 @@ int InspIRCd(char** argv, int argc)
                                        strlcpy(tcp_sum,msgs[ctr].c_str(),MAXBUF);
                                        log(DEBUG,"Processing: %s",tcp_msg);
                                        if (!tcp_msg[0])
-                                       {
+                                       {
                                                log(DEBUG,"Invalid string from %s [route%lu]",tcp_host,(unsigned long)x);
                                                break;
                                        }
@@ -2811,15 +2906,17 @@ int InspIRCd(char** argv, int argc)
                                        std::string msg = tcp_msg;
                                        FOREACH_MOD OnPacketReceive(msg,tcp_host);
                                        strlcpy(tcp_msg,msg.c_str(),MAXBUF);
-                                       handle_link_packet(tcp_msg, tcp_host, me[x], tcp_sum);
+                                       if (me[x])
+                                               handle_link_packet(tcp_msg, tcp_host, me[x], tcp_sum);
                                }
-                               goto label;
+                                       sums.clear();   // we're done, clear the list for the next operation
+                                       msgs.clear();
                        }
                }
        
        while (count2 != clientlist.end())
        {
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
                FD_ZERO(&sfd);
 #endif
 
@@ -2835,6 +2932,9 @@ int InspIRCd(char** argv, int argc)
                if (count2->second)
                        curr = count2->second;
 
+               if ((long)curr == -1)
+                       goto label;
+
                if ((curr) && (curr->fd != 0))
                {
 #ifdef _POSIX_PRIORITY_SCHEDULING
@@ -2845,14 +2945,17 @@ int InspIRCd(char** argv, int argc)
                        //
                        // This should be up to 64x faster than the
                        // old implementation.
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
                        while (total_in_this_set < 1024)
                        {
                                if (count2 != clientlist.end())
                                {
                                        curr = count2->second;
+                                       if ((long)curr == -1)
+                                               goto label;
+                                       int currfd = curr->fd;
                                        // we don't check the state of remote users.
-                                       if ((curr->fd != -1) && (curr->fd != FD_MAGIC_NUMBER))
+                                       if ((currfd != -1) && (currfd != FD_MAGIC_NUMBER))
                                        {
                                                curr->FlushWriteBuf();
                                                if (curr->GetWriteError() != "")
@@ -2878,13 +2981,15 @@ int InspIRCd(char** argv, int argc)
                                                        curr->dns_done = true;
                                                        statsDnsBad++;
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                               goto label;                                                        
                                                }
                                                if ((curr->dns_done) && (curr->registered == 3) && (AllModulesReportReady(curr))) // both NICK and USER... and DNS
                                                {
                                                        log(DEBUG,"dns done, registered=3, and modules ready, OK");
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((TIME > curr->nping) && (isnick(curr->nick)) && (curr->registered == 7))
                                                {
@@ -2908,17 +3013,20 @@ int InspIRCd(char** argv, int argc)
                        endingiter = count2;
                                count2 = xcount; // roll back to where we were
 #else
-                       // KQUEUE: We don't go through a loop to fill the fd_set so instead we must manually do this loop every now and again.
+                       // KQUEUE and EPOLL: We don't go through a loop to fill the fd_set so instead we must manually do this loop every now and again.
                        // TODO: We dont need to do all this EVERY loop iteration, tone down the visits to this if we're using kqueue.
                        cycle_iter++;
-                       if (cycle_iter > 10) while (count2 != clientlist.end())
+                       if (cycle_iter > 20) while (count2 != clientlist.end())
                        {
                                cycle_iter = 0;
                                if (count2 != clientlist.end())
                                {
                                        curr = count2->second;
+                                        if ((long)curr == -1)
+                                                goto label;
+                                       int currfd = curr->fd;
                                        // we don't check the state of remote users.
-                                       if ((curr->fd != -1) && (curr->fd != FD_MAGIC_NUMBER))
+                                       if ((currfd != -1) && (currfd != FD_MAGIC_NUMBER))
                                        {
 
                                                 curr->FlushWriteBuf();
@@ -2935,7 +3043,8 @@ int InspIRCd(char** argv, int argc)
                                                {
                                                        log(DEBUG,"InspIRCd: registration timeout: %s",curr->nick);
                                                        kill_link(curr,"Registration timeout");
-                                                       goto label;
+                                                       goto label;
+
                                                }
                                                if ((TIME > curr->signon) && (curr->registered == 3) && (AllModulesReportReady(curr)))
                                                {
@@ -2943,13 +3052,15 @@ int InspIRCd(char** argv, int argc)
                                                        curr->dns_done = true;
                                                        statsDnsBad++;
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((curr->dns_done) && (curr->registered == 3) && (AllModulesReportReady(curr)))
                                                {
                                                        log(DEBUG,"dns done, registered=3, and modules ready, OK");
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((TIME > curr->nping) && (isnick(curr->nick)) && (curr->registered == 7))
                                                {
@@ -2973,7 +3084,14 @@ int InspIRCd(char** argv, int argc)
 #endif
         
                        v = 0;
-
+#ifdef USE_EPOLL
+                       int i = epoll_wait(ep, event, 1, 5);
+                       if (i > 0)
+                       {
+                               log(DEBUG,"epoll_wait call: ep=%d, i=%d",ep,i);
+                               // EPOLL: we asked epoll_wait for ONE fd which is ready. Do something.
+                               userrec* cu = fd_ref_table[event[0].data.fd];
+#endif
 #ifdef USE_KQUEUE
                        ts.tv_sec = 0;
                        ts.tv_nsec = 1000L;
@@ -2984,15 +3102,18 @@ int InspIRCd(char** argv, int argc)
                                log(DEBUG,"kevent call: kq=%d, i=%d",kq,i);
                                // KQUEUE: kevent gives us ONE fd which is ready to have something done to it. Do something to it.
                                userrec* cu = fd_ref_table[ke.ident];
-#else
+#endif
+#ifdef USE_SELECT
+                       tval.tv_sec = 0;
                        tval.tv_usec = 1000L;
-                       selectResult2 = select(65535, &sfd, NULL, NULL, &tval);
-                       
+                       selectResult2 = select(FD_SETSIZE, &sfd, NULL, NULL, &tval);
                        // now loop through all of the items in this pool if any are waiting
-                       if (selectResult2 > 0)
+                       if ((selectResult2 > 0) && (xcount != clientlist.end()))
                        for (user_hash::iterator count2a = xcount; count2a != endingiter; count2a++)
                        {
                                // SELECT: we have to iterate...
+                               if (count2a == clientlist.end())
+                                       break;
                                userrec* cu = count2a->second;
 #endif
 
@@ -3000,10 +3121,15 @@ int InspIRCd(char** argv, int argc)
                                sched_yield();
 #endif
                                result = EAGAIN;
+#ifdef USE_EPOLL
+                               // EPOLL: We already know we have a valid FD. No checks needed.
+                               if ((cu->fd != FD_MAGIC_NUMBER) && (cu->fd != -1))
+#endif
 #ifdef USE_KQUEUE
                                // KQUEUE: We already know we have a valid FD. No checks needed.
                                if ((cu->fd != FD_MAGIC_NUMBER) && (cu->fd != -1))
-#else
+#endif
+#ifdef USE_SELECT
                                // SELECT: We don't know if our FD is valid.
                                if ((cu->fd != FD_MAGIC_NUMBER) && (cu->fd != -1) && (FD_ISSET (cu->fd, &sfd)))
 #endif
@@ -3145,7 +3271,7 @@ int InspIRCd(char** argv, int argc)
                                else
                                if (result == 0)
                                {
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
                                        if (count2->second)
                                        {
 #endif
@@ -3154,7 +3280,7 @@ int InspIRCd(char** argv, int argc)
                                                // must bail here? kill_link removes the hash, corrupting the iterator
                                                log(DEBUG,"Bailing from client exit");
                                                goto label;
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
                                        }
 #endif
                                }
@@ -3173,7 +3299,7 @@ int InspIRCd(char** argv, int argc)
         sched_yield();
 #endif
        
-#ifndef USE_KQUEUE
+#ifdef USE_SELECT
        // set up select call
        for (count = 0; count < boundPortCount; count++)
        {
@@ -3190,13 +3316,14 @@ int InspIRCd(char** argv, int argc)
                {
                        if (FD_ISSET (openSockfd[count], &selectFds))
                        {
-#else
+#endif
+#ifdef USE_KQUEUE
        ts.tv_sec = 0;
        ts.tv_nsec = 30000L;
        i = kevent(lkq, NULL, 0, ke_list, 32, &ts);
        if (i > 0) for (j = 0; j < i; j++)
        {
-               log(DEBUG,"kqueue: Listening socket event, i=%d, ke.ident=%d",i,ke.ident);
+               log(DEBUG,"kqueue: Listening socket event, i=%d, ke.ident=%d",i,ke_list[j].ident);
                // this isnt as efficient as it could be, we could create a reference table
                // to reference bound ports by fd, but this isnt a big bottleneck as the actual
                // number of listening ports on the average ircd is a small number (less than 20)
@@ -3205,6 +3332,16 @@ int InspIRCd(char** argv, int argc)
                {
                        if (ke_list[j].ident == openSockfd[count])
                        {
+#endif
+#ifdef USE_EPOLL
+       i = epoll_wait(lep, event, 32, EP_DELAY);
+       if (i > 0) for (j = 0; j < i; j++)
+       {
+               log(DEBUG,"epoll: Listening socket event, i=%d,events[j].data.fd=%d",i,event[j].data.fd);
+               for (count = 0; count < boundPortCount; count++)
+               {
+                       if (event[j].data.fd == openSockfd[count])
+                       {
 #endif
                                char target[MAXBUF], resolved[MAXBUF];
                                length = sizeof (client);
@@ -3226,7 +3363,6 @@ int InspIRCd(char** argv, int argc)
                                        AddClient(incomingSockfd, resolved, ports[count], false, inet_ntoa (client.sin_addr));
                                        log(DEBUG,"InspIRCd: adding client on port %lu fd=%lu",(unsigned long)ports[count],(unsigned long)incomingSockfd);
                                }
-                               //goto label;
                        }
                }
        }