]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspircd.cpp
Add more debug logging of object lifetimes
[user/henk/code/inspircd.git] / src / inspircd.cpp
index 3bebbf30d81ed3e98a3fc6bf5b5eee4f6e88d07c..862aa31d093f26276d92e7db82d6c691c8616980 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *         the file COPYING for details.
  * ---------------------------------------------------
  */
 
-/* w00t was here. ;p */
-
-/* $Install: src/inspircd $(BINPATH) */
+/* $Core */
 #include "inspircd.h"
+#include "inspircd_version.h"
 #include <signal.h>
 
 #ifndef WIN32
                #define RUSAGE_SELF 0
        #endif
 
-       /* CRT memory debugging */
-       #ifdef DEBUG
-       #define _CRTDBG_MAP_ALLOC
-       #include <stdlib.h>
-       #include <crtdbg.h>
-       #endif
+       #include <pwd.h> // setuid
+       #include <grp.h> // setgid
 #endif
 
 #include <fstream>
 #include "xline.h"
 #include "bancache.h"
 #include "socketengine.h"
-#include "inspircd_se_config.h"
 #include "socket.h"
 #include "command_parse.h"
 #include "exitcodes.h"
 #include "caller.h"
 #include "testsuite.h"
 
-using irc::sockets::insp_ntoa;
-using irc::sockets::insp_inaddr;
-using irc::sockets::insp_sockaddr;
-
-InspIRCd* SI = NULL;
+InspIRCd* ServerInstance = NULL;
 int* mysig = NULL;
 
+/** Seperate from the other casemap tables so that code *can* still exclusively rely on RFC casemapping
+ * if it must.
+ *
+ * This is provided as a pointer so that modules can change it to their custom mapping tables,
+ * e.g. for national character support.
+ */
+unsigned const char *national_case_insensitive_map = rfc_case_insensitive_map;
+
 
 /* Moved from exitcodes.h -- due to duplicate symbols -- Burlex
  * XXX this is a bit ugly. -- w00t
@@ -83,144 +81,58 @@ const char* ExitCodes[] =
                "CreateEvent failed" /* 19 */
 };
 
+template<typename T> static void DeleteZero(T*&n)
+{
+       T* t = n;
+       n = NULL;
+       delete t;
+}
+
 void InspIRCd::Cleanup()
 {
        if (Config)
        {
-               for (unsigned int i = 0; i < Config->ports.size(); i++)
+               for (unsigned int i = 0; i < ports.size(); i++)
                {
                        /* This calls the constructor and closes the listening socket */
-                       delete Config->ports[i];
+                       delete ports[i];
                }
 
-               Config->ports.clear();
+               ports.clear();
        }
 
        /* Close all client sockets, or the new process inherits them */
-       for (std::vector<User*>::const_iterator i = this->Users->local_users.begin(); i != this->Users->local_users.end(); i++)
-       {
-               this->Users->QuitUser((*i), "Server shutdown");
-               (*i)->CloseSocket();
-       }
-
-       /* We do this more than once, so that any service providers get a
-        * chance to be unhooked by the modules using them, but then get
-        * a chance to be removed themsleves.
-        *
-        * XXX there may be a better way to do this with 1.2
-        */
-       for (int tries = 0; tries < 3; tries++)
-       {
-               std::vector<std::string> module_names = Modules->GetAllModuleNames(0);
-               for (std::vector<std::string>::iterator k = module_names.begin(); k != module_names.end(); ++k)
-               {
-                       /* Unload all modules, so they get a chance to clean up their listeners */
-                       this->Modules->Unload(k->c_str());
-               }
-       }
-       /* Remove core commands */
-       Parser->RemoveCommands("<core>");
-
-       /* Cleanup Server Names */
-       for(servernamelist::iterator itr = servernames.begin(); itr != servernames.end(); ++itr)
-               delete (*itr);
-
-       /* Delete objects dynamically allocated in constructor
-        * (destructor would be more appropriate, but we're likely exiting)
-        */
-
-       // Must be deleted before modes as it decrements modelines
-       if (this->Users)
-       {
-               delete this->Users;
-               this->Users = 0;
-       }
-       
-       if (this->Modes)
-       {
-               delete this->Modes;
-               this->Modes = 0;
-       }
-
-       if (this->XLines)
-       {
-               delete this->XLines;
-               this->XLines = 0;
-       }
-
-       if (this->Parser)
-       {
-               delete this->Parser;
-               this->Parser = 0;
-
-       if (this->stats)
-       {
-               delete this->stats;
-               this->stats = 0;
-       }
-
-       if (this->Modules)
-       {
-               delete this->Modules;
-               this->Modules = 0;
-       }
-
-       if (this->BanCache)
-               delete this->BanCache;
-               this->BanCache = 0;
-       }
-
-       if (this->SNO)
-       {
-               delete this->SNO;
-               this->SNO = 0;
-       }
-
-       if (this->Config)
-       {
-               delete this->Config;
-               this->Config = 0;
-       }
-
-       if (this->Res)
-       {
-               delete this->Res;
-               this->Res = 0;
-       }
-
-       if (this->chanlist)
-       {
-               delete chanlist;
-               chanlist = 0;
-       }
-
-       if (this->PI)
-       {
-               delete this->PI;
-               this->PI = 0;
-       }
-       
-       if (this->Threads)
-       {
-               delete this->Threads;
-               this->Threads = 0;
-       }
-
-       /* Needs to be deleted after Res, DNS has a timer */
-       if (this->Timers)
-       {
-               delete this->Timers;
-               this->Timers = 0;
-       }
-
+       std::vector<User*>::reverse_iterator i = Users->local_users.rbegin();
+       while (i != this->Users->local_users.rend())
+       {
+               User* u = *i++;
+               Users->QuitUser(u, "Server shutdown");
+       }
+
+       GlobalCulls.Apply();
+       Modules->UnloadAll();
+
+       /* Delete objects dynamically allocated in constructor (destructor would be more appropriate, but we're likely exiting) */
+       /* Must be deleted before modes as it decrements modelines */
+       DeleteZero(this->FakeClient);
+       DeleteZero(this->Users);
+       DeleteZero(this->Modes);
+       DeleteZero(this->XLines);
+       DeleteZero(this->Parser);
+       DeleteZero(this->stats);
+       DeleteZero(this->Modules);
+       DeleteZero(this->BanCache);
+       DeleteZero(this->SNO);
+       DeleteZero(this->Config);
+       DeleteZero(this->Res);
+       DeleteZero(this->chanlist);
+       DeleteZero(this->PI);
+       DeleteZero(this->Threads);
+       DeleteZero(this->Timers);
+       DeleteZero(this->SE);
        /* Close logging */
        this->Logs->CloseLogs();
-
-       if (this->Logs)
-       {
-               delete this->Logs;
-               this->Logs = 0;
-       }
+       DeleteZero(this->Logs);
 }
 
 void InspIRCd::Restart(const std::string &reason)
@@ -298,6 +210,8 @@ void InspIRCd::SetSignals()
        signal(SIGHUP, InspIRCd::SetSignal);
        signal(SIGPIPE, SIG_IGN);
        signal(SIGCHLD, SIG_IGN);
+       /* We want E2BIG not a signal! */
+       signal(SIGXFSZ, SIG_IGN);
 #endif
        signal(SIGTERM, InspIRCd::SetSignal);
 }
@@ -343,12 +257,10 @@ bool InspIRCd::DaemonSeed()
                this->Logs->Log("STARTUP",DEFAULT,"Failed to getrlimit()!");
                return false;
        }
-       else
-       {
-               rl.rlim_cur = rl.rlim_max;
-               if (setrlimit(RLIMIT_CORE, &rl) == -1)
+       rl.rlim_cur = rl.rlim_max;
+
+       if (setrlimit(RLIMIT_CORE, &rl) == -1)
                        this->Logs->Log("STARTUP",DEFAULT,"setrlimit() failed, cannot increase coredump size.");
-       }
 
        return true;
 #endif
@@ -356,18 +268,9 @@ bool InspIRCd::DaemonSeed()
 
 void InspIRCd::WritePID(const std::string &filename)
 {
-       std::string fname = (filename.empty() ? "inspircd.pid" : filename);
-       std::replace(fname.begin(), fname.end(), '\\', '/');
-       if ((fname[0] != '/') && (!Config->StartsWithWindowsDriveLetter(filename)))
-       {
-               std::string::size_type pos;
-               std::string confpath = this->ConfigFileName;
-               if ((pos = confpath.rfind("/")) != std::string::npos)
-               {
-                       /* Leaves us with just the path */
-                       fname = confpath.substr(0, pos) + std::string("/") + fname;
-               }
-       }
+       std::string fname(filename);
+       if (fname.empty())
+               fname = "data/inspircd.pid";
        std::ofstream outfile(fname.c_str());
        if (outfile.is_open())
        {
@@ -382,50 +285,40 @@ void InspIRCd::WritePID(const std::string &filename)
        }
 }
 
-InspIRCd::InspIRCd(int argc, char** argv)
-       : GlobalCulls(this),
+InspIRCd::InspIRCd(int argc, char** argv) :
+        ConfigFileName("inspircd.conf"),
 
-        /* Functor initialisation. Note that the ordering here is very important. 
-         *
-         * THIS MUST MATCH ORDER OF DECLARATION OF THE HandleWhateverFunc classes
-         * within class InspIRCd.
-         */
-        HandleProcessUser(this),
-        HandleIsNick(this),
-        HandleIsIdent(this),
-        HandleFindDescriptor(this),
-        HandleFloodQuitUser(this),
-        HandleIsChannel(this),
-        HandleIsSID(this),
-        HandleRehash(this),
-
-        /* Functor pointer initialisation. Must match the order of the list above
+        /* Functor pointer initialisation.
          *
          * THIS MUST MATCH THE ORDER OF DECLARATION OF THE FUNCTORS, e.g. the methods
          * themselves within the class.
          */
-        ProcessUser(&HandleProcessUser),
+        NICKForced("NICKForced", NULL),
+        OperQuit("OperQuit", NULL),
         IsChannel(&HandleIsChannel),
         IsSID(&HandleIsSID),
         Rehash(&HandleRehash),
         IsNick(&HandleIsNick),
         IsIdent(&HandleIsIdent),
-        FindDescriptor(&HandleFindDescriptor),
         FloodQuitUser(&HandleFloodQuitUser)
-
 {
 #ifdef WIN32
        // Strict, frequent checking of memory on debug builds
        _CrtSetDbgFlag ( _CRTDBG_CHECK_ALWAYS_DF | _CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF );
-       
+
        // Avoid erroneous frees on early exit
        WindowsIPC = 0;
 #endif
-       int found_ports = 0;
+
+       ServerInstance = this;
+
+       Extensions.Register(&NICKForced);
+       Extensions.Register(&OperQuit);
+
        FailedPortList pl;
        int do_version = 0, do_nofork = 0, do_debug = 0,
            do_nolog = 0, do_root = 0, do_testsuite = 0;    /* flag variables */
-       char c = 0;
+       int c = 0;
 
        // Initialize so that if we exit before proper initialization they're not deleted
        this->Logs = 0;
@@ -443,62 +336,48 @@ InspIRCd::InspIRCd(int argc, char** argv)
        this->XLines = 0;
        this->Modes = 0;
        this->Res = 0;
+       this->ConfigThread = NULL;
 
-
-       memset(&server, 0, sizeof(server));
-       memset(&client, 0, sizeof(client));
+       // Initialise TIME
+       this->TIME = time(NULL);
 
        // This must be created first, so other parts of Insp can use it while starting up
-       this->Logs = new LogManager(this);
+       this->Logs = new LogManager;
 
-       SocketEngineFactory* SEF = new SocketEngineFactory();
-       SE = SEF->Create(this);
-       delete SEF;
+       SE = CreateSocketEngine();
 
-       ThreadEngineFactory* tef = new ThreadEngineFactory();
-       this->Threads = tef->Create(this);
-       delete tef;
+       this->Threads = new ThreadEngine;
 
        /* Default implementation does nothing */
-       this->PI = new ProtocolInterface(this);
+       this->PI = new ProtocolInterface;
 
        this->s_signal = 0;
-       
+
        // Create base manager classes early, so nothing breaks
-       this->Users = new UserManager(this);
-       
+       this->Users = new UserManager;
+
        this->Users->unregistered_count = 0;
 
        this->Users->clientlist = new user_hash();
        this->Users->uuidlist = new user_hash();
        this->chanlist = new chan_hash();
 
-       this->Config = new ServerConfig(this);
-       this->SNO = new SnomaskManager(this);
-       this->BanCache = new BanCacheManager(this);
-       this->Modules = new ModuleManager(this);
+       this->Config = new ServerConfig;
+       this->SNO = new SnomaskManager;
+       this->BanCache = new BanCacheManager;
+       this->Modules = new ModuleManager();
        this->stats = new serverstats();
-       this->Timers = new TimerManager(this);
-       this->Parser = new CommandParser(this);
-       this->XLines = new XLineManager(this);
+       this->Timers = new TimerManager;
+       this->Parser = new CommandParser;
+       this->XLines = new XLineManager;
 
        this->Config->argv = argv;
        this->Config->argc = argc;
 
-       if (chdir(Config->GetFullProgDir().c_str()))
-       {
-               printf("Unable to change to my directory: %s\nAborted.", strerror(errno));
-               exit(0);
-       }
-
-       this->Config->opertypes.clear();
-       this->Config->operclass.clear();
-
        this->TIME = this->OLDTIME = this->startup_time = time(NULL);
        srand(this->TIME);
 
        *this->LogFileName = 0;
-       strlcpy(this->ConfigFileName, CONFIG_FILE, MAXBUF);
 
        struct option longopts[] =
        {
@@ -513,7 +392,8 @@ InspIRCd::InspIRCd(int argc, char** argv)
                { 0, 0, 0, 0 }
        };
 
-       while ((c = getopt_long_only(argc, argv, ":f:", longopts, NULL)) != -1)
+       int index;
+       while ((c = getopt_long_only(argc, argv, ":f:", longopts, &index)) != -1)
        {
                switch (c)
                {
@@ -523,15 +403,17 @@ InspIRCd::InspIRCd(int argc, char** argv)
                        break;
                        case 'c':
                                /* Config filename was set */
-                               strlcpy(ConfigFileName, optarg, MAXBUF);
+                               ConfigFileName = optarg;
                        break;
                        case 0:
                                /* getopt_long_only() set an int variable, just keep going */
                        break;
+                       case '?':
+                               /* Unknown parameter */
                        default:
-                               /* Unknown parameter! DANGER, INTRUDER.... err.... yeah. */
-                               printf("Usage: %s [--nofork] [--nolog] [--debug] [--logfile <filename>]\n\
-                                                 [--runasroot] [--version] [--config <config>] [--testsuite]\n", argv[0]);
+                               /* Fall through to handle other weird values too */
+                               printf("Unknown parameter '%s'\n", argv[optind-1]);
+                               printf("Usage: %s [--nofork] [--nolog] [--debug] [--logfile <filename>]\n%*s[--runasroot] [--version] [--config <config>] [--testsuite]\n", argv[0], static_cast<int>(8+strlen(argv[0])), " ");
                                Exit(EXIT_STATUS_ARGV);
                        break;
                }
@@ -551,7 +433,7 @@ InspIRCd::InspIRCd(int argc, char** argv)
        // Handle forking
        if(!do_nofork)
        {
-               DWORD ExitCode = WindowsForkStart(this);
+               DWORD ExitCode = WindowsForkStart();
                if(ExitCode)
                        exit(ExitCode);
        }
@@ -559,9 +441,8 @@ InspIRCd::InspIRCd(int argc, char** argv)
        // Set up winsock
        WSADATA wsadata;
        WSAStartup(MAKEWORD(2,0), &wsadata);
-       ChangeWindowsSpecificPointers(this);
+       ChangeWindowsSpecificPointers();
 #endif
-       strlcpy(Config->MyExecutable,argv[0],MAXBUF);
 
        /* Set the finished argument values */
        Config->nofork = do_nofork;
@@ -575,23 +456,34 @@ InspIRCd::InspIRCd(int argc, char** argv)
                Exit(EXIT_STATUS_LOG);
        }
 
-       if (!ServerConfig::FileExists(this->ConfigFileName))
+       if (!ServerConfig::FileExists(ConfigFileName.c_str()))
        {
-               printf("ERROR: Cannot open config file: %s\nExiting...\n", this->ConfigFileName);
-               this->Logs->Log("STARTUP",DEFAULT,"Unable to open config file %s", this->ConfigFileName);
-               Exit(EXIT_STATUS_CONFIG);
+#ifdef WIN32
+               /* Windows can (and defaults to) hide file extensions, so let's play a bit nice for windows users. */
+               std::string txtconf = this->ConfigFileName;
+               txtconf.append(".txt");
+
+               if (ServerConfig::FileExists(txtconf.c_str()))
+               {
+                       ConfigFileName = txtconf;
+               }
+               else
+#endif
+               {
+                       printf("ERROR: Cannot open config file: %s\nExiting...\n", ConfigFileName.c_str());
+                       this->Logs->Log("STARTUP",DEFAULT,"Unable to open config file %s", ConfigFileName.c_str());
+                       Exit(EXIT_STATUS_CONFIG);
+               }
        }
 
        printf_c("\033[1;32mInspire Internet Relay Chat Server, compiled %s at %s\n",__DATE__,__TIME__);
        printf_c("(C) InspIRCd Development Team.\033[0m\n\n");
        printf_c("Developers:\n");
        printf_c("\t\033[1;32mBrain, FrostyCoolSlug, w00t, Om, Special\n");
-       printf_c("\t\033[1;32mpippijn, peavey, aquanight, fez\033[0m\n\n");
+       printf_c("\t\033[1;32mpeavey, aquanight, psychon, dz, danieldg\033[0m\n\n");
        printf_c("Others:\t\t\t\033[1;32mSee /INFO Output\033[0m\n");
 
-       Config->ClearStack();
-
-       this->Modes = new ModeParser(this);
+       this->Modes = new ModeParser;
 
        if (!do_root)
                this->CheckRoot();
@@ -625,59 +517,54 @@ InspIRCd::InspIRCd(int argc, char** argv)
        /* During startup we don't actually initialize this
         * in the thread engine.
         */
-       this->ConfigThread = new ConfigReaderThread(this, true, NULL);
-       ConfigThread->Run();
-       delete ConfigThread;
-       this->ConfigThread = NULL;
-
-       this->Res = new DNS(this);
+       this->Config->Read();
+       this->Config->Apply(NULL, "");
+       Logs->OpenFileLogs();
 
-       this->AddServerName(Config->ServerName);
+       this->Res = new DNS;
 
        /*
         * Initialise SID/UID.
         * For an explanation as to exactly how this works, and why it works this way, see GetUID().
         *   -- w00t
         */
-       if (!*Config->sid)
+       if (Config->sid.empty())
        {
                // Generate one
-               size_t sid = 0;
+               unsigned int sid = 0;
+               char sidstr[4];
 
-               for (const char* x = Config->ServerName; *x; ++x)
+               for (const char* x = Config->ServerName.c_str(); *x; ++x)
                        sid = 5 * sid + *x;
-               for (const char* y = Config->ServerDesc; *y; ++y)
+               for (const char* y = Config->ServerDesc.c_str(); *y; ++y)
                        sid = 5 * sid + *y;
-               sid = sid % 999;
+               sprintf(sidstr, "%03d", sid % 1000);
 
-               Config->sid[0] = (char)(sid / 100 + 48);
-               Config->sid[1] = (char)(((sid / 10) % 10) + 48);
-               Config->sid[2] = (char)(sid % 10 + 48);
-               Config->sid[3] = '\0';
+               Config->sid = sidstr;
        }
 
        /* set up fake client again this time with the correct uid */
-       this->FakeClient = new User(this, "#INVALID");
-       this->FakeClient->SetFd(FD_MAGIC_NUMBER);
+       this->FakeClient = new FakeUser("!");
+       this->FakeClient->SetFakeServer(Config->ServerName);
 
        // Get XLine to do it's thing.
        this->XLines->CheckELines();
        this->XLines->ApplyLines();
 
-       CheckDie();
-       int bounditems = BindPorts(true, found_ports, pl);
+       int bounditems = BindPorts(pl);
 
        printf("\n");
 
        this->Modules->LoadAll();
-       
+
        /* Just in case no modules were loaded - fix for bug #101 */
        this->BuildISupport();
-       InitializeDisabledCommands(Config->DisabledCommands, this);
+       Config->ApplyDisabledCommands(Config->DisabledCommands);
 
-       if (Config->ports.size() != (unsigned int)found_ports)
+       if (!pl.empty())
        {
-               printf("\nWARNING: Not all your client ports could be bound --\nstarting anyway with %d of %d client ports bound.\n\n", bounditems, found_ports);
+               printf("\nWARNING: Not all your client ports could be bound --\nstarting anyway with %d of %d client ports bound.\n\n",
+                       bounditems, bounditems + (int)pl.size());
                printf("The following port(s) failed to bind:\n");
                printf("Hint: Try using a public IP instead of blank or *\n\n");
                int j = 1;
@@ -687,8 +574,9 @@ InspIRCd::InspIRCd(int argc, char** argv)
                }
        }
 
-       printf("\nInspIRCd is now running as '%s'[%s] with %d max open sockets\n", Config->ServerName,Config->GetSID().c_str(), SE->GetMaxFds());
-       
+       printf("\nInspIRCd is now running as '%s'[%s] with %d max open sockets\n",
+               Config->ServerName.c_str(),Config->GetSID().c_str(), SE->GetMaxFds());
+
 #ifndef WINDOWS
        if (!Config->nofork)
        {
@@ -717,17 +605,76 @@ InspIRCd::InspIRCd(int argc, char** argv)
                }
        }
 #else
-       WindowsIPC = new IPC(this);
+       WindowsIPC = new IPC;
        if(!Config->nofork)
        {
-               WindowsForkKillOwner(this);
+               WindowsForkKillOwner();
                FreeConsole();
        }
        /* Set win32 service as running, if we are running as a service */
        SetServiceRunning();
 #endif
 
-       Logs->Log("STARTUP", DEFAULT, "Startup complete as '%s'[%s], %d max open sockets", Config->ServerName,Config->GetSID().c_str(), SE->GetMaxFds());
+       Logs->Log("STARTUP", DEFAULT, "Startup complete as '%s'[%s], %d max open sockets", Config->ServerName.c_str(),Config->GetSID().c_str(), SE->GetMaxFds());
+
+#ifndef WIN32
+       if (!Config->SetGroup.empty())
+       {
+               int ret;
+
+               // setgroups
+               ret = setgroups(0, NULL);
+
+               if (ret == -1)
+               {
+                       this->Logs->Log("SETGROUPS", DEFAULT, "setgroups() failed (wtf?): %s", strerror(errno));
+                       this->QuickExit(0);
+               }
+
+               // setgid
+               struct group *g;
+
+               errno = 0;
+               g = getgrnam(this->Config->SetGroup.c_str());
+
+               if (!g)
+               {
+                       this->Logs->Log("SETGUID", DEFAULT, "getgrnam() failed (bad user?): %s", strerror(errno));
+                       this->QuickExit(0);
+               }
+
+               ret = setgid(g->gr_gid);
+
+               if (ret == -1)
+               {
+                       this->Logs->Log("SETGUID", DEFAULT, "setgid() failed (bad user?): %s", strerror(errno));
+                       this->QuickExit(0);
+               }
+       }
+
+       if (!Config->SetUser.empty())
+       {
+               // setuid
+               struct passwd *u;
+
+               errno = 0;
+               u = getpwnam(this->Config->SetUser.c_str());
+
+               if (!u)
+               {
+                       this->Logs->Log("SETGUID", DEFAULT, "getpwnam() failed (bad user?): %s", strerror(errno));
+                       this->QuickExit(0);
+               }
+
+               int ret = setuid(u->pw_uid);
+
+               if (ret == -1)
+               {
+                       this->Logs->Log("SETGUID", DEFAULT, "setuid() failed (bad user?): %s", strerror(errno));
+                       this->QuickExit(0);
+               }
+       }
+#endif
 
        this->WritePID(Config->PID);
 }
@@ -737,7 +684,7 @@ int InspIRCd::Run()
        /* See if we're supposed to be running the test suite rather than entering the mainloop */
        if (Config->TestSuite)
        {
-               TestSuite* ts = new TestSuite(this);
+               TestSuite* ts = new TestSuite;
                delete ts;
                Exit(0);
        }
@@ -753,32 +700,16 @@ int InspIRCd::Run()
 #endif
 
                /* Check if there is a config thread which has finished executing but has not yet been freed */
-               if (this->ConfigThread && this->ConfigThread->GetExitFlag())
+               if (this->ConfigThread && this->ConfigThread->IsDone())
                {
                        /* Rehash has completed */
                        this->Logs->Log("CONFIG",DEBUG,"Detected ConfigThread exiting, tidying up...");
 
-                       /* IMPORTANT: This delete may hang if you fuck up your thread syncronization.
-                        * It will hang waiting for the ConfigThread to 'join' to avoid race conditons,
-                        * until the other thread is completed.
-                        */
+                       this->ConfigThread->Finish();
+
+                       ConfigThread->join();
                        delete ConfigThread;
                        ConfigThread = NULL;
-
-                       /* These are currently not known to be threadsafe, so they are executed outside
-                        * of the thread. It would be pretty simple to move them to the thread Run method
-                        * once they are known threadsafe with all the correct mutexes in place.
-                        *
-                        * XXX: The order of these is IMPORTANT, do not reorder them without testing
-                        * thoroughly!!!
-                        */
-                       this->XLines->CheckELines();
-                       this->XLines->ApplyLines();
-                       this->Res->Rehash();
-                       this->ResetMaxBans();
-                       InitializeDisabledCommands(Config->DisabledCommands, this);
-                       FOREACH_MOD_I(this, I_OnRehash, OnRehash(Config->RehashUser, Config->RehashParameter));
-                       this->BuildISupport();
                }
 
                /* time() seems to be a pretty expensive syscall, so avoid calling it too much.
@@ -807,7 +738,7 @@ int InspIRCd::Run()
                        if ((TIME % 3600) == 0)
                        {
                                this->RehashUsersAndChans();
-                               FOREACH_MOD_I(this, I_OnGarbageCollect, OnGarbageCollect());
+                               FOREACH_MOD(I_OnGarbageCollect, OnGarbageCollect());
                        }
 
                        Timers->TickTimers(TIME);
@@ -815,7 +746,7 @@ int InspIRCd::Run()
 
                        if ((TIME % 5) == 0)
                        {
-                               FOREACH_MOD_I(this,I_OnBackgroundTimer,OnBackgroundTimer(TIME));
+                               FOREACH_MOD(I_OnBackgroundTimer,OnBackgroundTimer(TIME));
                                SNO->FlushSnotices();
                        }
 #ifndef WIN32
@@ -826,7 +757,7 @@ int InspIRCd::Run()
                                this->stats->LastCPU = ru.ru_utime;
                        }
 #else
-                       WindowsIPC->Check();    
+                       WindowsIPC->Check();
 #endif
                }
 
@@ -837,13 +768,12 @@ int InspIRCd::Run()
                 * This will cause any read or write events to be
                 * dispatched to their handlers.
                 */
+               this->SE->DispatchTrialWrites();
                this->SE->DispatchEvents();
 
                /* if any users were quit, take them out */
-               this->GlobalCulls.Apply();
-
-               /* If any inspsockets closed, remove them */
-               this->BufferedSocketCull();
+               GlobalCulls.Apply();
+               AtomicActions.Run();
 
                if (this->s_signal)
                {
@@ -855,18 +785,6 @@ int InspIRCd::Run()
        return 0;
 }
 
-void InspIRCd::BufferedSocketCull()
-{
-       for (std::map<BufferedSocket*,BufferedSocket*>::iterator x = SocketCull.begin(); x != SocketCull.end(); ++x)
-       {
-               this->Logs->Log("MISC",DEBUG,"Cull socket");
-               SE->DelFd(x->second);
-               x->second->Close();
-               delete x->second;
-       }
-       SocketCull.clear();
-}
-
 /**********************************************************************************/
 
 /**
@@ -879,12 +797,9 @@ void InspIRCd::BufferedSocketCull()
  */
 bool InspIRCd::AllModulesReportReady(User* user)
 {
-       for (EventHandlerIter i = Modules->EventHandlers[I_OnCheckReady].begin(); i != Modules->EventHandlers[I_OnCheckReady].end(); ++i)
-       {
-               if (!(*i)->OnCheckReady(user))
-                       return false;
-       }
-       return true;
+       ModResult res;
+       FIRST_MOD_RESULT(OnCheckReady, res, (user));
+       return (res == MOD_RES_PASSTHRU);
 }
 
 time_t InspIRCd::Time()
@@ -905,9 +820,9 @@ void InspIRCd::SetSignal(int signal)
  */
 ENTRYPOINT
 {
-       SI = new InspIRCd(argc, argv);
-       mysig = &SI->s_signal;
-       SI->Run();
-       delete SI;
+       new InspIRCd(argc, argv);
+       mysig = &ServerInstance->s_signal;
+       ServerInstance->Run();
+       delete ServerInstance;
        return 0;
 }