Remove needless chdir() from inspircd executable

[user/henk/code/inspircd.git] / src / inspircd.cpp

diff --git a/src/inspircd.cpp b/src/inspircd.cpp
index 300d01650a1f9daf21bbb861aa374002defdf536..a932b95e10fe9aeabf4bd162527bd12d32d31370 100644 (file)
--- a/src/inspircd.cpp
+++ b/src/inspircd.cpp
@@ -36,7 +36,6 @@
 #include "xline.h"
 #include "bancache.h"
 #include "socketengine.h"
-#include "inspircd_se_config.h"
 #include "socket.h"
 #include "command_parse.h"
 #include "exitcodes.h"
@@ -116,7 +115,7 @@ void InspIRCd::Cleanup()
         * chance to be unhooked by the modules using them, but then get
         * a chance to be removed themsleves.
         *
-        * XXX there may be a better way to do this with 1.2
+        * XXX there may be a better way to do this
         */
        for (int tries = 0; tries < 4; tries++)
        {
@@ -126,12 +125,9 @@ void InspIRCd::Cleanup()
                        /* Unload all modules, so they get a chance to clean up their listeners */
                        this->Modules->Unload(k->c_str());
                }
+               GlobalCulls.Apply();
        }
 
-       /* Cleanup Server Names */
-       for(servernamelist::iterator itr = servernames.begin(); itr != servernames.end(); ++itr)
-               delete (*itr);
-
        /* Delete objects dynamically allocated in constructor (destructor would be more appropriate, but we're likely exiting) */
        /* Must be deleted before modes as it decrements modelines */
        DeleteZero(this->FakeClient);
@@ -324,13 +320,14 @@ InspIRCd::InspIRCd(int argc, char** argv) :
          * THIS MUST MATCH THE ORDER OF DECLARATION OF THE FUNCTORS, e.g. the methods
          * themselves within the class.
          */
+        NICKForced("NICKForced", NULL),
+        OperQuit("OperQuit", NULL),
         IsChannel(&HandleIsChannel),
         IsSID(&HandleIsSID),
         Rehash(&HandleRehash),
         IsNick(&HandleIsNick),
         IsIdent(&HandleIsIdent),
         FloodQuitUser(&HandleFloodQuitUser)
-
 {
 #ifdef WIN32
        // Strict, frequent checking of memory on debug builds
@@ -342,8 +339,8 @@ InspIRCd::InspIRCd(int argc, char** argv) :
 
        ServerInstance = this;
 
-       Extensible::Register(&User::NICKForced);
-       Extensible::Register(&User::OperQuit);
+       Extensible::Register(&NICKForced);
+       Extensible::Register(&OperQuit);
 
        FailedPortList pl;
        int do_version = 0, do_nofork = 0, do_debug = 0,
@@ -374,8 +371,7 @@ InspIRCd::InspIRCd(int argc, char** argv) :
        // This must be created first, so other parts of Insp can use it while starting up
        this->Logs = new LogManager;
 
-       SocketEngineFactory SEF;
-       SE = SEF.Create();
+       SE = CreateSocketEngine();
 
        this->Threads = new ThreadEngine;
 
@@ -405,15 +401,6 @@ InspIRCd::InspIRCd(int argc, char** argv) :
        this->Config->argv = argv;
        this->Config->argc = argc;
 
-       if (chdir(Config->GetFullProgDir().c_str()))
-       {
-               printf("Unable to change to my directory: %s\nAborted.", strerror(errno));
-               exit(0);
-       }
-
-       this->Config->opertypes.clear();
-       this->Config->operclass.clear();
-
        this->TIME = this->OLDTIME = this->startup_time = time(NULL);
        srand(this->TIME);
 
@@ -564,28 +551,24 @@ InspIRCd::InspIRCd(int argc, char** argv) :
 
        this->Res = new DNS;
 
-       this->AddServerName(Config->ServerName);
-
        /*
         * Initialise SID/UID.
         * For an explanation as to exactly how this works, and why it works this way, see GetUID().
         *   -- w00t
         */
-       if (!*Config->sid)
+       if (Config->sid.empty())
        {
                // Generate one
-               size_t sid = 0;
+               unsigned int sid = 0;
+               char sidstr[4];
 
-               for (const char* x = Config->ServerName; *x; ++x)
+               for (const char* x = Config->ServerName.c_str(); *x; ++x)
                        sid = 5 * sid + *x;
-               for (const char* y = Config->ServerDesc; *y; ++y)
+               for (const char* y = Config->ServerDesc.c_str(); *y; ++y)
                        sid = 5 * sid + *y;
-               sid = sid % 999;
+               sprintf(sidstr, "%03d", sid % 1000);
 
-               Config->sid[0] = (char)(sid / 100 + 48);
-               Config->sid[1] = (char)(((sid / 10) % 10) + 48);
-               Config->sid[2] = (char)(sid % 10 + 48);
-               Config->sid[3] = '\0';
+               Config->sid = sidstr;
        }
 
        /* set up fake client again this time with the correct uid */
@@ -619,7 +602,8 @@ InspIRCd::InspIRCd(int argc, char** argv) :
                }
        }
 
-       printf("\nInspIRCd is now running as '%s'[%s] with %d max open sockets\n", Config->ServerName,Config->GetSID().c_str(), SE->GetMaxFds());
+       printf("\nInspIRCd is now running as '%s'[%s] with %d max open sockets\n",
+               Config->ServerName.c_str(),Config->GetSID().c_str(), SE->GetMaxFds());
 
 #ifndef WINDOWS
        if (!Config->nofork)
@@ -659,10 +643,10 @@ InspIRCd::InspIRCd(int argc, char** argv) :
        SetServiceRunning();
 #endif
 
-       Logs->Log("STARTUP", DEFAULT, "Startup complete as '%s'[%s], %d max open sockets", Config->ServerName,Config->GetSID().c_str(), SE->GetMaxFds());
+       Logs->Log("STARTUP", DEFAULT, "Startup complete as '%s'[%s], %d max open sockets", Config->ServerName.c_str(),Config->GetSID().c_str(), SE->GetMaxFds());
 
 #ifndef WIN32
-       if (*(this->Config->SetGroup))
+       if (!Config->SetGroup.empty())
        {
                int ret;
 
@@ -679,7 +663,7 @@ InspIRCd::InspIRCd(int argc, char** argv) :
                struct group *g;
 
                errno = 0;
-               g = getgrnam(this->Config->SetGroup);
+               g = getgrnam(this->Config->SetGroup.c_str());
 
                if (!g)
                {
@@ -696,13 +680,13 @@ InspIRCd::InspIRCd(int argc, char** argv) :
                }
        }
 
-       if (*(this->Config->SetUser))
+       if (!Config->SetUser.empty())
        {
                // setuid
                struct passwd *u;
 
                errno = 0;
-               u = getpwnam(this->Config->SetUser);
+               u = getpwnam(this->Config->SetUser.c_str());
 
                if (!u)
                {