]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspircd.cpp
Added m_watch.cpp (provides /WATCH for notify) and fixes to allow it to work
[user/henk/code/inspircd.git] / src / inspircd.cpp
index aa8d0313813fc818b792122d0e2ba1c02c3050e0..c780b8bf1c33c21cf9ca653ae9ac3aeaec32dc4f 100644 (file)
 
 using namespace std;
 
+#include "inspircd_config.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
 #include "inspircd_util.h"
-#include "inspircd_config.h"
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/errno.h>
@@ -36,7 +36,7 @@ using namespace std;
 
 #ifdef USE_EPOLL
 #include <sys/epoll.h>
-#define EP_DELAY 35
+#define EP_DELAY 50
 #endif
 
 #include <time.h>
@@ -88,7 +88,8 @@ int WHOWAS_STALE = 48; // default WHOWAS Entries last 2 days before they go 'sta
 int WHOWAS_MAX = 100;  // default 100 people maximum in the WHOWAS list
 int DieDelay  =  5;
 time_t startup_time = time(NULL);
-int NetBufferSize = 10240; // NetBufferSize used as the buffer size for all read() ops
+int NetBufferSize = 10240;     // NetBufferSize used as the buffer size for all read() ops
+int MaxConn = SOMAXCONN;       // size of accept() backlog (128 by default on *BSD)
 extern int MaxWhoResults;
 time_t nb_start = 0;
 int dns_timeout = 5;
@@ -118,11 +119,16 @@ int kq, lkq, skq;
 int ep, lep, sep;
 #endif
 
+bool has_been_netsplit = false;
+extern std::vector<std::string> include_stack;
+
 typedef nspace::hash_map<std::string, userrec*, nspace::hash<string>, irc::StrHashComp> user_hash;
 typedef nspace::hash_map<std::string, chanrec*, nspace::hash<string>, irc::StrHashComp> chan_hash;
 typedef nspace::hash_map<in_addr,string*, nspace::hash<in_addr>, irc::InAddr_HashComp> address_cache;
 typedef nspace::hash_map<std::string, WhoWasUser*, nspace::hash<string>, irc::StrHashComp> whowas_hash;
 typedef std::deque<command_t> command_table;
+typedef std::map<std::string,time_t> autoconnects;
+typedef std::vector<std::string> servernamelist;
 
 // This table references users by file descriptor.
 // its an array to make it VERY fast, as all lookups are referenced
@@ -139,11 +145,13 @@ user_hash clientlist;
 chan_hash chanlist;
 whowas_hash whowas;
 command_table cmdlist;
+autoconnects autoconns;
 file_cache MOTD;
 file_cache RULES;
 address_cache IP;
 
 ClassVector Classes;
+servernamelist servernames;
 
 struct linger linger = { 0 };
 char MyExecutable[1024];
@@ -174,6 +182,26 @@ void AddOper(userrec* user)
        all_opers.push_back(user);
 }
 
+void AddServerName(std::string servername)
+{
+       for (servernamelist::iterator a = servernames.begin(); a < servernames.end(); a++)
+       {
+               if (*a == servername)
+                       return;
+       }
+       servernames.push_back(servername);
+}
+
+const char* FindServerNamePtr(std::string servername)
+{
+       for (servernamelist::iterator a = servernames.begin(); a < servernames.end(); a++)
+       {
+               if (*a == servername)
+                       return a->c_str();
+       }
+       return "";
+}
+
 void DeleteOper(userrec* user)
 {
         for (std::vector<userrec*>::iterator a = all_opers.begin(); a < all_opers.end(); a++)
@@ -187,7 +215,7 @@ void DeleteOper(userrec* user)
         }
 }
 
-long GetRevision()
+std::string GetRevision()
 {
        char Revision[] = "$Revision$";
        char *s1 = Revision;
@@ -196,7 +224,7 @@ long GetRevision()
        s1 = savept;
        v2 = strtok_r(s1," ",&savept);
        s1 = savept;
-       return (long)(atof(v2)*10000);
+       return std::string(v2);
 }
 
 
@@ -232,10 +260,11 @@ std::string getadminnick()
 
 void ReadConfig(bool bail, userrec* user)
 {
-       char dbg[MAXBUF],pauseval[MAXBUF],Value[MAXBUF],timeout[MAXBUF],NB[MAXBUF],flood[MAXBUF],MW[MAXBUF];
+       char dbg[MAXBUF],pauseval[MAXBUF],Value[MAXBUF],timeout[MAXBUF],NB[MAXBUF],flood[MAXBUF],MW[MAXBUF],MCON[MAXBUF];
        char AH[MAXBUF],AP[MAXBUF],AF[MAXBUF],DNT[MAXBUF],pfreq[MAXBUF],thold[MAXBUF],sqmax[MAXBUF],rqmax[MAXBUF];
        ConnectClass c;
        std::stringstream errstr;
+       include_stack.clear();
        
        if (!LoadConf(CONFIG_FILE,&config_f,&errstr))
        {
@@ -293,12 +322,18 @@ void ReadConfig(bool bail, userrec* user)
        ConfValue("dns","timeout",0,DNT,&config_f);
        ConfValue("options","moduledir",0,ModPath,&config_f);
         ConfValue("disabled","commands",0,DisabledCommands,&config_f);
+       ConfValue("options","somaxconn",0,MCON,&config_f);
 
+       MaxConn = atoi(MCON);
+       if (MaxConn > SOMAXCONN)
+               log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
        NetBufferSize = atoi(NB);
        MaxWhoResults = atoi(MW);
        dns_timeout = atoi(DNT);
        if (!dns_timeout)
                dns_timeout = 5;
+       if (!MaxConn)
+               MaxConn = SOMAXCONN;
        if (!DNSServer[0])
                strlcpy(DNSServer,"127.0.0.1",MAXBUF);
        if (!ModPath[0])
@@ -391,6 +426,20 @@ void ReadConfig(bool bail, userrec* user)
        read_xline_defaults();
        log(DEFAULT,"Applying K lines, Q lines and Z lines...");
        apply_lines();
+
+       autoconns.clear();
+        for (int i = 0; i < ConfValueEnum("link",&config_f); i++)
+        {
+               char Link_ServerName[MAXBUF],Link_AConn[MAXBUF];
+                ConfValue("link","name",i,Link_ServerName,&config_f);
+                ConfValue("link","autoconnect",i,Link_AConn,&config_f);
+               if (strcmp(Link_AConn,""))
+               {
+                       autoconns[std::string(Link_ServerName)] = atoi(Link_AConn) + time(NULL);
+               }
+        }
+
+
        log(DEFAULT,"Done reading configuration file, InspIRCd is now starting.");
        if (!bail)
        {
@@ -491,9 +540,9 @@ chanrec* add_channel(userrec *user, const char* cn, const char* key, bool overri
        // we MUST declare this wherever we use FOREACH_RESULT
        int MOD_RESULT = 0;
 
-       if (strlen(cname) > CHANMAX-1)
+       if (strlen(cname) > CHANMAX)
        {
-               cname[CHANMAX-1] = '\0';
+               cname[CHANMAX] = '\0';
        }
 
        log(DEBUG,"add_channel: %s %s",user->nick,cname);
@@ -1074,6 +1123,8 @@ void kill_link(userrec *user,const char* r)
                NetSendToAll(buffer);
        }
 
+       user->FlushWriteBuf();
+
        FOREACH_MOD OnUserDisconnect(user);
 
        if (user->fd > -1)
@@ -1098,18 +1149,18 @@ void kill_link(userrec *user,const char* r)
                        log(DEBUG,"epoll: List deletion failure!");
                }
 #endif
-                shutdown(user->fd,2);
-                close(user->fd);
-       }
-       
-       if (user->registered == 7) {
-               WriteOpers("*** Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason);
-               AddWhoWas(user);
+               user->CloseSocket();
        }
 
+       // this must come before the WriteOpers so that it doesnt try to fill their buffer with anything
+       // if they were an oper with +s.
         if (user->registered == 7) {
                 purge_empty_chans(user);
-        }
+               // fix by brain: only show local quits because we only show local connects (it just makes SENSE)
+               if (!strcmp(user->server,ServerName))
+                       WriteOpers("*** Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason);
+               AddWhoWas(user);
+       }
 
        if (iter != clientlist.end())
        {
@@ -1138,6 +1189,8 @@ void kill_link_silent(userrec *user,const char* r)
        Write(user->fd,"ERROR :Closing link (%s@%s) [%s]",user->ident,user->host,reason);
        log(DEBUG,"closing fd %lu",(unsigned long)user->fd);
 
+       user->FlushWriteBuf();
+
        if (user->registered == 7) {
                FOREACH_MOD OnUserQuit(user);
                WriteCommonExcept(user,"QUIT :%s",reason);
@@ -1172,8 +1225,7 @@ void kill_link_silent(userrec *user,const char* r)
                         log(DEBUG,"epoll: List deletion failure!");
                 }
 #endif
-                shutdown(user->fd,2);
-                close(user->fd);
+               user->CloseSocket();
         }
 
         if (user->registered == 7) {
@@ -1282,10 +1334,10 @@ void AddWhoWas(userrec* u)
        whowas_hash::iterator iter = whowas.find(u->nick);
        WhoWasUser *a = new WhoWasUser();
        strlcpy(a->nick,u->nick,NICKMAX);
-       strlcpy(a->ident,u->ident,15);
+       strlcpy(a->ident,u->ident,IDENTMAX);
        strlcpy(a->dhost,u->dhost,160);
        strlcpy(a->host,u->host,160);
-       strlcpy(a->fullname,u->fullname,128);
+       strlcpy(a->fullname,u->fullname,MAXGECOS);
        strlcpy(a->server,u->server,256);
        a->signon = u->signon;
 
@@ -1369,16 +1421,16 @@ void AddClient(int socket, char* host, int port, bool iscached, char* ip)
        log(DEBUG,"AddClient: %lu %s %d %s",(unsigned long)socket,host,port,ip);
 
        clientlist[tempnick]->fd = socket;
-       strncpy(clientlist[tempnick]->nick, tn2,NICKMAX);
-       strncpy(clientlist[tempnick]->host, host,160);
-       strncpy(clientlist[tempnick]->dhost, host,160);
-       strncpy(clientlist[tempnick]->server, ServerName,256);
-       strncpy(clientlist[tempnick]->ident, "unknown",15);
+       strlcpy(clientlist[tempnick]->nick, tn2,NICKMAX);
+       strlcpy(clientlist[tempnick]->host, host,160);
+       strlcpy(clientlist[tempnick]->dhost, host,160);
+       clientlist[tempnick]->server = (char*)FindServerNamePtr(ServerName);
+       strlcpy(clientlist[tempnick]->ident, "unknown",IDENTMAX);
        clientlist[tempnick]->registered = 0;
        clientlist[tempnick]->signon = TIME+dns_timeout;
        clientlist[tempnick]->lastping = 1;
        clientlist[tempnick]->port = port;
-       strncpy(clientlist[tempnick]->ip,ip,16);
+       strlcpy(clientlist[tempnick]->ip,ip,16);
 
        // set the registration timeout for this user
        unsigned long class_regtimeout = 90;
@@ -1555,6 +1607,7 @@ void FullConnectUser(userrec* user)
 
        // fix by brain: these should be AFTER the N token, so other servers know what the HELL we're on about... :)
        FOREACH_MOD OnUserConnect(user);
+       FOREACH_MOD OnGlobalConnect(user);
        WriteOpers("*** Client connecting on port %lu: %s!%s@%s [%s]",(unsigned long)user->port,user->nick,user->ident,user->host,user->ip);
 }
 
@@ -1718,6 +1771,7 @@ void DoSplitEveryone()
                        }
                }
        }
+       has_been_netsplit = true;
 }
 
 
@@ -2013,21 +2067,18 @@ void process_command(userrec *user, char* cmd)
                                        }
                                        if ((user->registered == 7) && (!strchr(user->modes,'o')))
                                        {
-                                               char* mycmd;
-                                               char* savept2;
-                                               mycmd = strtok_r(DisabledCommands," ",&savept2);
-                                               while (mycmd)
+                                               std::stringstream dcmds(DisabledCommands);
+                                               while (!dcmds.eof())
                                                {
-                                                       if (!strcasecmp(mycmd,command))
+                                                       std::string thiscmd;
+                                                       dcmds >> thiscmd;
+                                                       if (!strcasecmp(thiscmd.c_str(),command))
                                                        {
                                                                // command is disabled!
                                                                WriteServ(user->fd,"421 %s %s :This command has been disabled.",user->nick,command);
                                                                return;
                                                        }
-                                                       mycmd = strtok_r(NULL," ",&savept2);
                                                }
-        
-
                                        }
                                        if ((user->registered == 7) || (!strncmp(command,"USER",4)) || (!strncmp(command,"NICK",4)) || (!strncmp(command,"PASS",4)))
                                        {
@@ -2317,6 +2368,7 @@ void DoSplit(const char* params)
                        }
                }
        }
+       has_been_netsplit = true;
 }
 
 // removes a server. Will NOT remove its users!
@@ -2430,17 +2482,25 @@ bool UnloadModule(const char* filename)
 bool LoadModule(const char* filename)
 {
        char modfile[MAXBUF];
+#ifdef STATIC_LINK
+       snprintf(modfile,MAXBUF,"%s",filename);
+#else
        snprintf(modfile,MAXBUF,"%s/%s",ModPath,filename);
+#endif
        std::string filename_str = filename;
+#ifndef STATIC_LINK
        if (!DirValid(modfile))
        {
                log(DEFAULT,"Module %s is not within the modules directory.",modfile);
                snprintf(MODERR,MAXBUF,"Module %s is not within the modules directory.",modfile);
                return false;
        }
+#endif
        log(DEBUG,"Loading module: %s",modfile);
+#ifndef STATIC_LINK
         if (FileExists(modfile))
         {
+#endif
                for (int j = 0; j < module_names.size(); j++)
                {
                        if (module_names[j] == filename_str)
@@ -2473,6 +2533,7 @@ bool LoadModule(const char* filename)
                        snprintf(MODERR,MAXBUF,"Factory function failed!");
                        return false;
                 }
+#ifndef STATIC_LINK
         }
         else
         {
@@ -2480,10 +2541,31 @@ bool LoadModule(const char* filename)
                snprintf(MODERR,MAXBUF,"Module file could not be found");
                return false;
         }
+#endif
        MODCOUNT++;
        return true;
 }
 
+
+bool GotServer(std::string name)
+{
+        for (int j = 0; j < 32; j++)
+        {
+                if (me[j] != NULL)
+                {
+                        for (int k = 0; k < me[j]->connectors.size(); k++)
+                        {
+                               if (name == me[j]->connectors[k].GetServerName())
+                               {
+                                       return true;
+                               }
+                        }
+                }
+        }
+       return false;
+}
+
+
 int InspIRCd(char** argv, int argc)
 {
        struct sockaddr_in client,server;
@@ -2503,7 +2585,12 @@ int InspIRCd(char** argv, int argc)
                printf("ERROR: Could not write to logfile %s, bailing!\n\n",logpath.c_str());
                Exit(ERROR);
        }
+
+#ifdef IS_CYGWIN
+       printf("Logging to ircd.log...\n");
+#else
        printf("Logging to %s...\n",logpath.c_str());
+#endif
 
        log(DEFAULT,"$Id$");
        if (geteuid() == 0)
@@ -2524,6 +2611,8 @@ int InspIRCd(char** argv, int argc)
        }  
        log(DEBUG,"InspIRCd: startup: read config");
 
+       AddServerName(ServerName);
+
        int clientportcount = 0, serverportcount = 0;
 
        for (count = 0; count < ConfValueEnum("bind",&config_f); count++)
@@ -2704,7 +2793,7 @@ int InspIRCd(char** argv, int argc)
        {
                struct kevent ke;
                log(DEBUG,"kqueue: Add listening socket to events, kq=%d socket=%d",lkq,openSockfd[count]);
-               EV_SET(&ke, openSockfd[count], EVFILT_READ, EV_ADD, 0, 32, NULL);
+               EV_SET(&ke, openSockfd[count], EVFILT_READ, EV_ADD, 0, MaxConn, NULL);
                int i = kevent(lkq, &ke, 1, 0, 0, NULL);
                if (i == -1)
                {
@@ -2719,7 +2808,7 @@ int InspIRCd(char** argv, int argc)
                 if (me[t])
                 {
                        log(DEBUG,"kqueue: Add listening SERVER socket to events, kq=%d socket=%d",skq,me[t]->fd);
-                       EV_SET(&ke, me[t]->fd, EVFILT_READ, EV_ADD, 0, 32, NULL);
+                       EV_SET(&ke, me[t]->fd, EVFILT_READ, EV_ADD, 0, MaxConn, NULL);
                        int i = kevent(skq, &ke, 1, 0, 0, NULL);
                        if (i == -1)
                        {
@@ -2783,6 +2872,25 @@ int InspIRCd(char** argv, int argc)
                // them in a list, then reap the list every second or so.
                if (((TIME % 5) == 0) && (!expire_run))
                {
+                       for (int i = 0; i < ConfValueEnum("link",&config_f); i++)
+                       {
+                               char Link_ServerName[MAXBUF],Link_AConn[MAXBUF];
+                               ConfValue("link","name",i,Link_ServerName,&config_f);
+                               ConfValue("link","autoconnect",i,Link_AConn,&config_f);
+                               if ((Link_AConn[0]) && (!GotServer(Link_ServerName)))
+                               {
+                                       autoconnects::iterator a = autoconns.find(std::string(Link_ServerName));
+                                       if (a != autoconns.end())
+                                       {
+                                               if (TIME > a->second)
+                                               {
+                                                       ConnectServer(Link_ServerName,NULL);
+                                                       a->second = TIME + atoi(Link_AConn);
+                                               }
+                                       }
+                               }
+                       }
+
                        expire_lines();
                        FOREACH_MOD OnBackgroundTimer(TIME);
                        expire_run = true;
@@ -2795,10 +2903,7 @@ int InspIRCd(char** argv, int argc)
                user_hash::iterator count2 = clientlist.begin();
 
 #ifdef USE_EPOLL
-               i = epoll_wait(sep, event, 1, EP_DELAY*2);
-#ifdef _POSIX_PRIORITY_SCHEDULING
-                                sched_yield();
-#endif
+               i = epoll_wait(sep, event, 1, EP_DELAY);
                if (i > 0)
                {
                        log(DEBUG,"epoll: Listening server socket event, i=%d, event.data.fd=%d",i,event[0].data.fd);
@@ -2829,7 +2934,7 @@ int InspIRCd(char** argv, int argc)
                }
                tvs.tv_usec = 30000L;
                tvs.tv_sec = 0;
-               int servresult = select(32767, &serverfds, NULL, NULL, &tvs);
+               int servresult = select(FD_SETSIZE, &serverfds, NULL, NULL, &tvs);
                if (servresult > 0)
                {
                        for (int x = 0; x != SERVERportCount; x++)
@@ -2855,21 +2960,24 @@ int InspIRCd(char** argv, int argc)
                        }
                }
      
+               std::deque<std::string> msgs;
+               std::deque<std::string> sums;
                for (int x = 0; x < SERVERportCount; x++)
                {
-                       std::deque<std::string> msgs;
-                       std::deque<std::string> sums;
-                       msgs.clear();
+                       if (me[x])
+                               me[x]->FlushWriteBuffers();
                        sums.clear();
-                       if ((me[x]) && (me[x]->RecvPacket(msgs, tcp_host, sums)))
+                       msgs.clear();
+                       while ((me[x]) && (me[x]->RecvPacket(msgs, tcp_host, sums))) // returns 0 or more lines (can be multiple lines!)
                        {
+                               has_been_netsplit = false;
                                for (int ctr = 0; ctr < msgs.size(); ctr++)
                                {
                                        strlcpy(tcp_msg,msgs[ctr].c_str(),MAXBUF);
-                                       strlcpy(tcp_sum,msgs[ctr].c_str(),MAXBUF);
+                                       strlcpy(tcp_sum,sums[ctr].c_str(),MAXBUF);
                                        log(DEBUG,"Processing: %s",tcp_msg);
                                        if (!tcp_msg[0])
-                                       {
+                                       {
                                                log(DEBUG,"Invalid string from %s [route%lu]",tcp_host,(unsigned long)x);
                                                break;
                                        }
@@ -2889,7 +2997,13 @@ int InspIRCd(char** argv, int argc)
                                        std::string msg = tcp_msg;
                                        FOREACH_MOD OnPacketReceive(msg,tcp_host);
                                        strlcpy(tcp_msg,msg.c_str(),MAXBUF);
-                                       handle_link_packet(tcp_msg, tcp_host, me[x], tcp_sum);
+                                       if (me[x])
+                                               handle_link_packet(tcp_msg, tcp_host, me[x], tcp_sum);
+                                       if (!me[x]->FindHost(tcp_host))
+                                       {
+                                               log(DEBUG,"Connector gone, bailing!");
+                                               goto label;
+                                       }
                                }
                                goto label;
                        }
@@ -2913,6 +3027,9 @@ int InspIRCd(char** argv, int argc)
                if (count2->second)
                        curr = count2->second;
 
+               if ((long)curr == -1)
+                       goto label;
+
                if ((curr) && (curr->fd != 0))
                {
 #ifdef _POSIX_PRIORITY_SCHEDULING
@@ -2929,8 +3046,11 @@ int InspIRCd(char** argv, int argc)
                                if (count2 != clientlist.end())
                                {
                                        curr = count2->second;
+                                       if ((long)curr == -1)
+                                               goto label;
+                                       int currfd = curr->fd;
                                        // we don't check the state of remote users.
-                                       if ((curr->fd != -1) && (curr->fd != FD_MAGIC_NUMBER))
+                                       if ((currfd != -1) && (currfd != FD_MAGIC_NUMBER))
                                        {
                                                curr->FlushWriteBuf();
                                                if (curr->GetWriteError() != "")
@@ -2956,13 +3076,15 @@ int InspIRCd(char** argv, int argc)
                                                        curr->dns_done = true;
                                                        statsDnsBad++;
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                               goto label;                                                        
                                                }
                                                if ((curr->dns_done) && (curr->registered == 3) && (AllModulesReportReady(curr))) // both NICK and USER... and DNS
                                                {
                                                        log(DEBUG,"dns done, registered=3, and modules ready, OK");
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((TIME > curr->nping) && (isnick(curr->nick)) && (curr->registered == 7))
                                                {
@@ -2995,8 +3117,11 @@ int InspIRCd(char** argv, int argc)
                                if (count2 != clientlist.end())
                                {
                                        curr = count2->second;
+                                        if ((long)curr == -1)
+                                                goto label;
+                                       int currfd = curr->fd;
                                        // we don't check the state of remote users.
-                                       if ((curr->fd != -1) && (curr->fd != FD_MAGIC_NUMBER))
+                                       if ((currfd != -1) && (currfd != FD_MAGIC_NUMBER))
                                        {
 
                                                 curr->FlushWriteBuf();
@@ -3013,7 +3138,8 @@ int InspIRCd(char** argv, int argc)
                                                {
                                                        log(DEBUG,"InspIRCd: registration timeout: %s",curr->nick);
                                                        kill_link(curr,"Registration timeout");
-                                                       goto label;
+                                                       goto label;
+
                                                }
                                                if ((TIME > curr->signon) && (curr->registered == 3) && (AllModulesReportReady(curr)))
                                                {
@@ -3021,13 +3147,15 @@ int InspIRCd(char** argv, int argc)
                                                        curr->dns_done = true;
                                                        statsDnsBad++;
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((curr->dns_done) && (curr->registered == 3) && (AllModulesReportReady(curr)))
                                                {
                                                        log(DEBUG,"dns done, registered=3, and modules ready, OK");
                                                        FullConnectUser(curr);
-                                                       goto label;
+                                                        if (fd_ref_table[currfd] != curr) // something changed, bail pronto
+                                                                goto label;
                                                }
                                                if ((TIME > curr->nping) && (isnick(curr->nick)) && (curr->registered == 7))
                                                {
@@ -3071,14 +3199,16 @@ int InspIRCd(char** argv, int argc)
                                userrec* cu = fd_ref_table[ke.ident];
 #endif
 #ifdef USE_SELECT
+                       tval.tv_sec = 0;
                        tval.tv_usec = 1000L;
-                       selectResult2 = select(65535, &sfd, NULL, NULL, &tval);
-                       
+                       selectResult2 = select(FD_SETSIZE, &sfd, NULL, NULL, &tval);
                        // now loop through all of the items in this pool if any are waiting
-                       if (selectResult2 > 0)
+                       if ((selectResult2 > 0) && (xcount != clientlist.end()))
                        for (user_hash::iterator count2a = xcount; count2a != endingiter; count2a++)
                        {
                                // SELECT: we have to iterate...
+                               if (count2a == clientlist.end())
+                                       break;
                                userrec* cu = count2a->second;
 #endif
 
@@ -3105,7 +3235,7 @@ int InspIRCd(char** argv, int argc)
                                        FOREACH_RESULT(OnRawSocketRead(cu->fd,data,65535,result2));
                                        if (!MOD_RESULT)
                                        {
-                                               result = read(cu->fd, data, 65535);
+                                               result = cu->ReadData(data, 65535);
                                        }
                                        else result = result2;
                                        log(DEBUG,"Read result: %d",result);
@@ -3299,13 +3429,7 @@ int InspIRCd(char** argv, int argc)
                        {
 #endif
 #ifdef USE_EPOLL
-#ifdef _POSIX_PRIORITY_SCHEDULING
-                                sched_yield();
-#endif
-       i = epoll_wait(lep, event, 32, EP_DELAY*2);
-#ifdef _POSIX_PRIORITY_SCHEDULING
-                                sched_yield();
-#endif
+       i = epoll_wait(lep, event, 32, EP_DELAY);
        if (i > 0) for (j = 0; j < i; j++)
        {
                log(DEBUG,"epoll: Listening socket event, i=%d,events[j].data.fd=%d",i,event[j].data.fd);
@@ -3334,7 +3458,6 @@ int InspIRCd(char** argv, int argc)
                                        AddClient(incomingSockfd, resolved, ports[count], false, inet_ntoa (client.sin_addr));
                                        log(DEBUG,"InspIRCd: adding client on port %lu fd=%lu",(unsigned long)ports[count],(unsigned long)incomingSockfd);
                                }
-                               //goto label;
                        }
                }
        }