]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspsocket.cpp
mlock: handle case where no mlock has been set on a channel yet
[user/henk/code/inspircd.git] / src / inspsocket.cpp
index 37335c855d1d1f9be4edd8552ec0a195683eab45..1254dc58bfd430a2440a9cb87ccbdebd1fc90a38 100644 (file)
@@ -1,16 +1,27 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2007-2009 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2008 Thomas Stagner <aquanight@inspircd.org>
+ *   Copyright (C) 2006-2007 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 #include "inspircd.h"
 #include "socket.h"
 #include "inspstring.h"
 
 #ifndef DISABLE_WRITEV
 #include <sys/uio.h>
+#endif
+
 #ifndef IOV_MAX
 #define IOV_MAX 1024
 #endif
-#endif
 
 BufferedSocket::BufferedSocket()
 {
@@ -52,7 +64,7 @@ void BufferedSocket::DoConnect(const std::string &ipaddr, int aport, unsigned lo
 BufferedSocketError BufferedSocket::BeginConnect(const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
 {
        irc::sockets::sockaddrs addr, bind;
-       if (!irc::sockets::aptosa(ipaddr, aport, &addr))
+       if (!irc::sockets::aptosa(ipaddr, aport, addr))
        {
                ServerInstance->Logs->Log("SOCKET", DEBUG, "BUG: Hostname passed to BufferedSocket, rather than an IP address!");
                return I_ERR_CONNECT;
@@ -61,7 +73,7 @@ BufferedSocketError BufferedSocket::BeginConnect(const std::string &ipaddr, int
        bind.sa.sa_family = 0;
        if (!connectbindip.empty())
        {
-               if (!irc::sockets::aptosa(connectbindip, 0, &bind))
+               if (!irc::sockets::aptosa(connectbindip, 0, bind))
                {
                        return I_ERR_BIND;
                }
@@ -90,7 +102,7 @@ BufferedSocketError BufferedSocket::BeginConnect(const irc::sockets::sockaddrs&
 
        if (bind.sa.sa_family != 0)
        {
-               if (ServerInstance->SE->Bind(fd, &bind.sa, sa_size(bind)) < 0)
+               if (ServerInstance->SE->Bind(fd, bind) < 0)
                        return I_ERR_BIND;
        }
 
@@ -104,7 +116,7 @@ BufferedSocketError BufferedSocket::BeginConnect(const irc::sockets::sockaddrs&
 
        this->state = I_CONNECTING;
 
-       if (!ServerInstance->SE->AddFd(this, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE))
+       if (!ServerInstance->SE->AddFd(this, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE | FD_WRITE_WILL_BLOCK))
                return I_ERR_NOMOREFDS;
 
        this->Timeout = new SocketTimeout(this->GetFd(), this, timeout, ServerInstance->Time());
@@ -118,13 +130,10 @@ BufferedSocketError BufferedSocket::BeginConnect(const irc::sockets::sockaddrs&
 
 void StreamSocket::Close()
 {
-       /* Save this, so we dont lose it,
-        * otherise on failure, error messages
-        * might be inaccurate.
-        */
-       int save = errno;
        if (this->fd > -1)
        {
+               // final chance, dump as much of the sendq as we can
+               DoWrite();
                if (IOHook)
                {
                        try
@@ -136,19 +145,19 @@ void StreamSocket::Close()
                                ServerInstance->Logs->Log("SOCKET", DEFAULT,"%s threw an exception: %s",
                                        modexcept.GetSource(), modexcept.GetReason());
                        }
+                       IOHook = NULL;
                }
                ServerInstance->SE->Shutdown(this, 2);
                ServerInstance->SE->DelFd(this);
                ServerInstance->SE->Close(this);
                fd = -1;
        }
-       errno = save;
 }
 
-bool StreamSocket::cull()
+CullResult StreamSocket::cull()
 {
        Close();
-       return true;
+       return EventHandler::cull();
 }
 
 bool StreamSocket::GetNextLine(std::string& line, char delim)
@@ -156,7 +165,7 @@ bool StreamSocket::GetNextLine(std::string& line, char delim)
        std::string::size_type i = recvq.find(delim);
        if (i == std::string::npos)
                return false;
-       line = recvq.substr(0, i - 1);
+       line = recvq.substr(0, i);
        // TODO is this the most efficient way to split?
        recvq = recvq.substr(i + 1);
        return true;
@@ -219,6 +228,9 @@ void StreamSocket::DoRead()
        }
 }
 
+/* Don't try to prepare huge blobs of data to send to a blocked socket */
+static const int MYIOV_MAX = IOV_MAX < 128 ? IOV_MAX : 128;
+
 void StreamSocket::DoWrite()
 {
        if (sendq.empty())
@@ -236,7 +248,7 @@ void StreamSocket::DoWrite()
                int rv = -1;
                try
                {
-                       while (!sendq.empty())
+                       while (error.empty() && !sendq.empty())
                        {
                                if (sendq.size() > 1 && sendq[0].length() < 1024)
                                {
@@ -329,15 +341,15 @@ void StreamSocket::DoWrite()
                        return;
                // start out optimistic - we won't need to write any more
                int eventChange = FD_WANT_EDGE_WRITE;
-               while (sendq_len && eventChange == FD_WANT_EDGE_WRITE)
+               while (error.empty() && sendq_len && eventChange == FD_WANT_EDGE_WRITE)
                {
                        // Prepare a writev() call to write all buffers efficiently
                        int bufcount = sendq.size();
-               
-                       // cap the number of buffers at IOV_MAX
-                       if (bufcount > IOV_MAX)
+
+                       // cap the number of buffers at MYIOV_MAX
+                       if (bufcount > MYIOV_MAX)
                        {
-                               bufcount = IOV_MAX;
+                               bufcount = MYIOV_MAX;
                        }
 
                        int rv_max = 0;
@@ -395,6 +407,7 @@ void StreamSocket::DoWrite()
                        else if (errno == EINTR)
                        {
                                // restart interrupted syscall
+                               errno = 0;
                        }
                        else
                        {
@@ -445,11 +458,6 @@ void SocketTimeout::Tick(time_t)
                // connection.
                this->sock->OnTimeout();
                this->sock->OnError(I_ERR_TIMEOUT);
-
-               /* NOTE: We must set this AFTER DelFd, as we added
-                * this socket whilst writeable. This means that we
-                * must DELETE the socket whilst writeable too!
-                */
                this->sock->state = I_ERROR;
 
                ServerInstance->GlobalCulls.AddItem(sock);
@@ -490,49 +498,56 @@ void StreamSocket::HandleEvent(EventType et, int errornum)
        if (!error.empty())
                return;
        BufferedSocketError errcode = I_ERR_OTHER;
-       switch (et)
-       {
-               case EVENT_ERROR:
+       try {
+               switch (et)
                {
-                       if (errornum == 0)
-                               SetError("Connection closed");
-                       else
-                               SetError(strerror(errornum));
-                       switch (errornum)
+                       case EVENT_ERROR:
+                       {
+                               if (errornum == 0)
+                                       SetError("Connection closed");
+                               else
+                                       SetError(strerror(errornum));
+                               switch (errornum)
+                               {
+                                       case ETIMEDOUT:
+                                               errcode = I_ERR_TIMEOUT;
+                                               break;
+                                       case ECONNREFUSED:
+                                       case 0:
+                                               errcode = I_ERR_CONNECT;
+                                               break;
+                                       case EADDRINUSE:
+                                               errcode = I_ERR_BIND;
+                                               break;
+                                       case EPIPE:
+                                       case EIO:
+                                               errcode = I_ERR_WRITE;
+                                               break;
+                               }
+                               break;
+                       }
+                       case EVENT_READ:
                        {
-                               case ETIMEDOUT:
-                                       errcode = I_ERR_TIMEOUT;
-                                       break;
-                               case ECONNREFUSED:
-                               case 0:
-                                       errcode = I_ERR_CONNECT;
-                                       break;
-                               case EADDRINUSE:
-                                       errcode = I_ERR_BIND;
-                                       break;
-                               case EPIPE:
-                               case EIO:
-                                       errcode = I_ERR_WRITE;
-                                       break;
+                               DoRead();
+                               break;
+                       }
+                       case EVENT_WRITE:
+                       {
+                               DoWrite();
+                               break;
                        }
-                       break;
-               }
-               case EVENT_READ:
-               {
-                       DoRead();
-                       break;
-               }
-               case EVENT_WRITE:
-               {
-                       DoWrite();
-                       break;
                }
        }
+       catch (CoreException& ex)
+       {
+               ServerInstance->Logs->Log("SOCKET", DEFAULT, "Caught exception in socket processing on FD %d - '%s'",
+                       fd, ex.GetReason());
+               SetError(ex.GetReason());
+       }
        if (!error.empty())
        {
                ServerInstance->Logs->Log("SOCKET", DEBUG, "Error on FD %d - '%s'", fd, error.c_str());
                OnError(errcode);
-               ServerInstance->GlobalCulls.AddItem(this);
        }
 }