]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspsocket.cpp
Fix this so it works, passes test case. Provide a method to query for a bit and to...
[user/henk/code/inspircd.git] / src / inspsocket.cpp
index 5c8607f7de9493e180d9e5cea6b558da2a3f6be3..5f5c2d6ec2d3701f6e2cf6244b6f99b97055d8da 100644 (file)
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <sstream>
-#include <iostream>
-#include <fstream>
-#include <stdexcept>
-#include "inspircd_config.h"
 #include "socket.h"
-#include "inspircd.h"
 #include "configreader.h"
 #include "inspstring.h"
-#include "helperfuncs.h"
 #include "socketengine.h"
-#include "message.h"
-
-
-extern InspIRCd* ServerInstance;
-extern time_t TIME;
-extern Server* MyServer;
+#include "inspircd.h"
 
-InspSocket* socket_ref[MAX_DESCRIPTORS];
+using irc::sockets::OpenTCPSocket;
+using irc::sockets::insp_inaddr;
+using irc::sockets::insp_sockaddr;
 
+bool InspSocket::Readable()
+{
+       return ((this->state != I_CONNECTING) && (this->WaitingForWriteEvent == false));
+}
 
-InspSocket::InspSocket()
+InspSocket::InspSocket(InspIRCd* SI)
 {
        this->state = I_DISCONNECTED;
        this->fd = -1;
-       this->ClosePending = false;
+       this->WaitingForWriteEvent = false;
+       this->Instance = SI;
 }
 
-InspSocket::InspSocket(int newfd, const char* ip)
+InspSocket::InspSocket(InspIRCd* SI, int newfd, const char* ip)
 {
        this->fd = newfd;
        this->state = I_CONNECTED;
        strlcpy(this->IP,ip,MAXBUF);
-       this->ClosePending = false;
+       this->WaitingForWriteEvent = false;
+       this->Instance = SI;
        if (this->fd > -1)
-       {
-               this->ClosePending = (!ServerInstance->SE->AddFd(this->fd,true,X_ESTAB_MODULE));
-               socket_ref[this->fd] = this;
-       }
+               this->Instance->SE->AddFd(this);
 }
 
-InspSocket::InspSocket(const std::string &ipaddr, int aport, bool listening, unsigned long maxtime) : fd(-1)
+InspSocket::InspSocket(InspIRCd* SI, const std::string &ipaddr, int aport, bool listening, unsigned long maxtime)
 {
+       this->fd = -1;
+       this->Instance = SI;
        strlcpy(host,ipaddr.c_str(),MAXBUF);
-       this->ClosePending = false;
-       if (listening) {
+       this->WaitingForWriteEvent = false;
+       if (listening)
+       {
                if ((this->fd = OpenTCPSocket()) == ERROR)
                {
                        this->fd = -1;
                        this->state = I_ERROR;
                        this->OnError(I_ERR_SOCKET);
-                       this->ClosePending = true;
-                       log(DEBUG,"OpenTCPSocket() error");
+                       this->Instance->Log(DEBUG,"OpenTCPSocket() error");
                        return;
                }
                else
                {
-                       if (!BindSocket(this->fd,this->client,this->server,aport,(char*)ipaddr.c_str()))
+                       if (!SI->BindSocket(this->fd,this->client,this->server,aport,(char*)ipaddr.c_str()))
                        {
-                               log(DEBUG,"BindSocket() error %s",strerror(errno));
+                               this->Instance->Log(DEBUG,"BindSocket() error %s",strerror(errno));
                                this->Close();
                                this->fd = -1;
                                this->state = I_ERROR;
@@ -87,16 +81,14 @@ InspSocket::InspSocket(const std::string &ipaddr, int aport, bool listening, uns
                                this->state = I_LISTENING;
                                if (this->fd > -1)
                                {
-                                       if (!ServerInstance->SE->AddFd(this->fd,true,X_ESTAB_MODULE))
+                                       if (!this->Instance->SE->AddFd(this))
                                        {
                                                this->Close();
                                                this->state = I_ERROR;
                                                this->OnError(I_ERR_NOMOREFDS);
-                                               this->ClosePending = true;
                                        }
-                                       socket_ref[this->fd] = this;
                                }
-                               log(DEBUG,"New socket now in I_LISTENING state");
+                               this->Instance->Log(DEBUG,"New socket now in I_LISTENING state");
                                return;
                        }
                }                       
@@ -108,19 +100,18 @@ InspSocket::InspSocket(const std::string &ipaddr, int aport, bool listening, uns
 
                if (insp_aton(host,&addy) < 1)
                {
-                       log(DEBUG,"You cannot pass hostnames to InspSocket, resolve them first with Resolver!");
+                       this->Instance->Log(DEBUG,"You cannot pass hostnames to InspSocket, resolve them first with Resolver!");
                        this->Close();
                        this->fd = -1;
                        this->state = I_ERROR;
                        this->OnError(I_ERR_RESOLVE);
-                       this->ClosePending = true;
                        return;
                }
                else
                {
-                       log(DEBUG,"No need to resolve %s",this->host);
+                       this->Instance->Log(DEBUG,"No need to resolve %s",this->host);
                        strlcpy(this->IP,host,MAXBUF);
-                       timeout_end = time(NULL) + maxtime;
+                       timeout_val = maxtime;
                        this->DoConnect();
                }
        }
@@ -128,26 +119,8 @@ InspSocket::InspSocket(const std::string &ipaddr, int aport, bool listening, uns
 
 void InspSocket::WantWrite()
 {
-       /** XXX:
-        * The socket engine may only have each FD in the list ONCE.
-        * This means we cant watch for write AND read at the same
-        * time. We have to remove the READ fd, to insert the WRITE
-        * fd. Once we receive our WRITE event (which WILL ARRIVE,
-        * pretty much gauranteed) we switch back to watching for
-        * READ events again.
-        *
-        * This behaviour may be fixed in a later version.
-        */
+       this->Instance->SE->WantWrite(this);
        this->WaitingForWriteEvent = true;
-       ServerInstance->SE->DelFd(this->fd);
-       if (!ServerInstance->SE->AddFd(this->fd,false,X_ESTAB_MODULE))
-       {
-               this->Close();
-               this->fd = -1;
-               this->state = I_ERROR;
-               this->OnError(I_ERR_NOMOREFDS);
-               this->ClosePending = true;
-       }
 }
 
 void InspSocket::SetQueues(int nfd)
@@ -170,9 +143,9 @@ void InspSocket::SetQueues(int nfd)
 bool InspSocket::BindAddr()
 {
        insp_inaddr n;
-       ConfigReader Conf;
+       ConfigReader Conf(this->Instance);
 
-       log(DEBUG,"In InspSocket::BindAddr()");
+       this->Instance->Log(DEBUG,"In InspSocket::BindAddr()");
        for (int j =0; j < Conf.Enumerate("bind"); j++)
        {
                std::string Type = Conf.ReadValue("bind","type",j);
@@ -185,7 +158,7 @@ bool InspSocket::BindAddr()
 
                                if (insp_aton(IP.c_str(),&n) > 0)
                                {
-                                       log(DEBUG,"Found an IP to bind to: %s",IP.c_str());
+                                       this->Instance->Log(DEBUG,"Found an IP to bind to: %s",IP.c_str());
 #ifdef IPV6
                                        s.sin6_addr = n;
                                        s.sin6_family = AF_FAMILY;
@@ -195,35 +168,34 @@ bool InspSocket::BindAddr()
 #endif
                                        if (bind(this->fd,(struct sockaddr*)&s,sizeof(s)) < 0)
                                        {
-                                               log(DEBUG,"Cant bind()");
+                                               this->Instance->Log(DEBUG,"Cant bind()");
                                                this->state = I_ERROR;
                                                this->OnError(I_ERR_BIND);
                                                this->fd = -1;
                                                return false;
                                        }
-                                       log(DEBUG,"bind() reports outbound fd bound to ip %s",IP.c_str());
+                                       this->Instance->Log(DEBUG,"bind() reports outbound fd bound to ip %s",IP.c_str());
                                        return true;
                                }
                                else
                                {
-                                       log(DEBUG,"Address '%s' was not an IP address",IP.c_str());
+                                       this->Instance->Log(DEBUG,"Address '%s' was not an IP address",IP.c_str());
                                }
                        }
                }
        }
-       log(DEBUG,"Found no suitable IPs to bind, binding INADDR_ANY");
+       this->Instance->Log(DEBUG,"Found no suitable IPs to bind, binding INADDR_ANY");
        return true;
 }
 
 bool InspSocket::DoConnect()
 {
-       log(DEBUG,"In DoConnect()");
+       this->Instance->Log(DEBUG,"In DoConnect()");
        if ((this->fd = socket(AF_FAMILY, SOCK_STREAM, 0)) == -1)
        {
-               log(DEBUG,"Cant socket()");
+               this->Instance->Log(DEBUG,"Cant socket()");
                this->state = I_ERROR;
                this->OnError(I_ERR_SOCKET);
-               this->fd = -1;
                return false;
        }
 
@@ -233,7 +205,7 @@ bool InspSocket::DoConnect()
                        return false;
        }
 
-       log(DEBUG,"Part 2 DoConnect() %s",this->IP);
+       this->Instance->Log(DEBUG,"Part 2 DoConnect() %s",this->IP);
        insp_aton(this->IP,&addy);
 #ifdef IPV6
        addr.sin6_family = AF_FAMILY;
@@ -253,45 +225,40 @@ bool InspSocket::DoConnect()
        {
                if (errno != EINPROGRESS)
                {
-                       log(DEBUG,"Error connect() %d: %s",this->fd,strerror(errno));
+                       this->Instance->Log(DEBUG,"Error connect() %d: %s",this->fd,strerror(errno));
                        this->OnError(I_ERR_CONNECT);
                        this->Close();
                        this->state = I_ERROR;
-                       this->fd = -1;
-                       this->ClosePending = true;
                        return false;
                }
+
+               this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, timeout_val, this->Instance->Time());
+               this->Instance->Timers->AddTimer(this->Timeout);
        }
        this->state = I_CONNECTING;
        if (this->fd > -1)
        {
-               if (!ServerInstance->SE->AddFd(this->fd,false,X_ESTAB_MODULE))
+               if (!this->Instance->SE->AddFd(this))
                {
                        this->OnError(I_ERR_NOMOREFDS);
                        this->Close();
-                       this->fd = -1;
                        this->state = I_ERROR;
-                       this->ClosePending = true;
                        return false;
                }
-               socket_ref[this->fd] = this;
                this->SetQueues(this->fd);
        }
-       log(DEBUG,"Returning true from InspSocket::DoConnect");
+       this->Instance->Log(DEBUG,"Returning true from InspSocket::DoConnect");
        return true;
 }
 
 
 void InspSocket::Close()
 {
-       if (this->fd != -1)
+       if (this->fd > -1)
        {
                this->OnClose();
                shutdown(this->fd,2);
                close(this->fd);
-               socket_ref[this->fd] = NULL;
-               this->ClosePending = true;
-               this->fd = -1;
        }
 }
 
@@ -312,13 +279,17 @@ char* InspSocket::Read()
        }
        else
        {
-               if (errno == EAGAIN)
+               int err = errno;
+               if (err == EAGAIN)
                {
                        return "";
                }
                else
                {
-                       log(DEBUG,"EOF or error on socket: %s",strerror(errno));
+                       if (!n)
+                               this->Instance->Log(DEBUG,"EOF or error on socket: EOF");
+                       else
+                               this->Instance->Log(DEBUG,"EOF or error on socket: %s",strerror(err));
                        return NULL;
                }
        }
@@ -326,8 +297,7 @@ char* InspSocket::Read()
 
 void InspSocket::MarkAsClosed()
 {
-       log(DEBUG,"Marked as closed");
-       this->ClosePending = true;
+       this->Instance->Log(DEBUG,"Marked as closed");
 }
 
 // There are two possible outcomes to this function.
@@ -336,36 +306,33 @@ void InspSocket::MarkAsClosed()
 // and should be aborted.
 int InspSocket::Write(const std::string &data)
 {
-       if (this->ClosePending)
-               return false;
-
-       /*int result = write(this->fd,data.c_str(),data.length());
-       if (result < 1)
-               return false;
-       return true;*/
-
        /* Try and append the data to the back of the queue, and send it on its way
         */
        outbuffer.push_back(data);
+       this->Instance->SE->WantWrite(this);
        return (!this->FlushWriteBuffer());
 }
 
 bool InspSocket::FlushWriteBuffer()
 {
-       if (this->ClosePending)
-               return true;
-
+       errno = 0;
        if ((this->fd > -1) && (this->state == I_CONNECTED))
        {
-               if (outbuffer.size())
+               /* If we have multiple lines, try to send them all,
+                * not just the first one -- Brain
+                */
+               while (outbuffer.size() && (errno != EAGAIN))
                {
+                       /* Send a line */
                        int result = write(this->fd,outbuffer[0].c_str(),outbuffer[0].length());
                        if (result > 0)
                        {
                                if ((unsigned int)result == outbuffer[0].length())
                                {
                                        /* The whole block was written (usually a line)
-                                        * Pop the block off the front of the queue
+                                        * Pop the block off the front of the queue,
+                                        * dont set errno, because we are clear of errors
+                                        * and want to try and write the next block too.
                                         */
                                        outbuffer.pop_front();
                                }
@@ -373,75 +340,86 @@ bool InspSocket::FlushWriteBuffer()
                                {
                                        std::string temp = outbuffer[0].substr(result);
                                        outbuffer[0] = temp;
+                                       /* We didnt get the whole line out. arses.
+                                        * Try again next time, i guess. Set errno,
+                                        * because we shouldnt be writing any more now,
+                                        * until the socketengine says its safe to do so.
+                                        */
+                                       errno = EAGAIN;
                                }
                        }
                        else if ((result == -1) && (errno != EAGAIN))
                        {
-                               log(DEBUG,"Write error on socket: %s",strerror(errno));
+                               this->Instance->Log(DEBUG,"Write error on socket: %s",strerror(errno));
                                this->OnError(I_ERR_WRITE);
                                this->state = I_ERROR;
-                               this->ClosePending = true;
+                               this->Instance->SE->DelFd(this);
+                               this->Close();
                                return true;
                        }
                }
        }
-       return (fd < 0);
-}
 
-bool InspSocket::Timeout(time_t current)
-{
-       if (!socket_ref[this->fd] || !ServerInstance->SE->HasFd(this->fd))
+       if ((errno == EAGAIN) && (fd > -1))
        {
-               log(DEBUG,"No FD or socket ref");
-               return false;
+               this->Instance->SE->WantWrite(this);
        }
 
-       if (this->ClosePending)
+       return (fd < 0);
+}
+
+void SocketTimeout::Tick(time_t now)
+{
+       if (ServerInstance->SE->GetRef(this->sfd) != this->sock)
        {
-               log(DEBUG,"Close is pending");
-               return true;
+               ServerInstance->Log(DEBUG,"Our socket has been deleted before the timeout was reached.");
+               return;
        }
 
-       if ((this->state == I_CONNECTING) && (current > timeout_end))
+       if (this->sock->state == I_CONNECTING)
        {
-               log(DEBUG,"Timed out, current=%lu timeout_end=%lu");
+               ServerInstance->Log(DEBUG,"Timed out, current=%lu",now);
                // for non-listening sockets, the timeout can occur
                // which causes termination of the connection after
                // the given number of seconds without a successful
                // connection.
-               this->OnTimeout();
-               this->OnError(I_ERR_TIMEOUT);
-               timeout = true;
-               this->state = I_ERROR;
-               this->ClosePending = true;
-               return true;
+               this->sock->OnTimeout();
+               this->sock->OnError(I_ERR_TIMEOUT);
+               this->sock->timeout = true;
+               ServerInstance->SE->DelFd(this->sock);
+               /* NOTE: We must set this AFTER DelFd, as we added
+                * this socket whilst writeable. This means that we
+                * must DELETE the socket whilst writeable too!
+                */
+               this->sock->state = I_ERROR;
+               this->sock->Close();
+               delete this->sock;
+               return;
        }
-       return this->FlushWriteBuffer();
 }
 
 bool InspSocket::Poll()
 {
-       if (!socket_ref[this->fd] || !ServerInstance->SE->HasFd(this->fd))
+       if (this->Instance->SE->GetRef(this->fd) != this)
                return false;
 
        int incoming = -1;
-       bool n = true;
 
-       if ((fd < 0) || (fd > MAX_DESCRIPTORS) || (this->ClosePending))
+       if ((fd < 0) || (fd > MAX_DESCRIPTORS))
                return false;
 
        switch (this->state)
        {
                case I_CONNECTING:
-                       log(DEBUG,"State = I_CONNECTING");
-                       this->SetState(I_CONNECTED);
+                       this->Instance->Log(DEBUG,"State = I_CONNECTING");
                        /* Our socket was in write-state, so delete it and re-add it
                         * in read-state.
                         */
                        if (this->fd > -1)
                        {
-                               ServerInstance->SE->DelFd(this->fd);
-                               if (!ServerInstance->SE->AddFd(this->fd,true,X_ESTAB_MODULE))
+                               this->Instance->SE->DelFd(this);
+                               this->SetState(I_CONNECTED);
+                               if (!this->Instance->SE->AddFd(this))
                                        return false;
                        }
                        return this->OnConnected();
@@ -458,30 +436,8 @@ bool InspSocket::Poll()
                        return true;
                break;
                case I_CONNECTED:
-
-                       if (this->WaitingForWriteEvent)
-                       {
-                               /* Switch back to read events */
-                               ServerInstance->SE->DelFd(this->fd);
-                               if (!ServerInstance->SE->AddFd(this->fd,true,X_ESTAB_MODULE))
-                                       return false;
-
-                               /* Trigger the write event */
-                               n = this->OnWriteReady();
-                       }
-                       else
-                       {
-                               /* Process the read event */
-                               n = this->OnDataReady();
-                       }
-                       /* Flush any pending, but not till after theyre done with the event
-                        * so there are less write calls involved.
-                        * Both FlushWriteBuffer AND the return result of OnDataReady must
-                        * return true for this to be ok.
-                        */
-                       if (this->FlushWriteBuffer())
-                               return false;
-                       return n;
+                       /* Process the read event */
+                       return this->OnDataReady();
                break;
                default:
                break;
@@ -491,7 +447,7 @@ bool InspSocket::Poll()
 
 void InspSocket::SetState(InspSocketState s)
 {
-       log(DEBUG,"Socket state change");
+       this->Instance->Log(DEBUG,"Socket state change");
        this->state = s;
 }
 
@@ -518,3 +474,61 @@ InspSocket::~InspSocket()
 {
        this->Close();
 }
+
+void InspSocket::HandleEvent(EventType et, int errornum)
+{
+       switch (et)
+       {
+               case EVENT_ERROR:
+                       this->Instance->SE->DelFd(this);
+                       this->Close();
+                       delete this;
+                       return;
+               break;
+               case EVENT_READ:
+                       if (!this->Poll())
+                       {
+                               this->Instance->SE->DelFd(this);
+                               this->Close();
+                               delete this;
+                               return;
+                       }
+               break;
+               case EVENT_WRITE:
+                       if (this->WaitingForWriteEvent)
+                       {
+                               this->WaitingForWriteEvent = false;
+                               if (!this->OnWriteReady())
+                               {
+                                       this->Instance->SE->DelFd(this);
+                                       this->Close();
+                                       delete this;
+                                       return;
+                               }
+                       }
+                       if (this->state == I_CONNECTING)
+                       {
+                               /* This might look wrong as if we should be actually calling
+                                * with EVENT_WRITE, but trust me it is correct. There are some
+                                * writeability-state things in the read code, because of how
+                                * InspSocket used to work regarding write buffering in previous
+                                * versions of InspIRCd. - Brain
+                                */
+                               this->HandleEvent(EVENT_READ);
+                               return;
+                       }
+                       else
+                       {
+                               Instance->Log(DEBUG,"State=%d CONNECTED=%d", this->state, I_CONNECTED);
+                               if (this->FlushWriteBuffer())
+                               {
+                                       this->Instance->SE->DelFd(this);
+                                       this->Close();
+                                       delete this;
+                                       return;
+                               }
+                       }
+               break;
+       }
+}
+