]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspsocket.cpp
Cleanup of some internals. Tested via m_httpd.
[user/henk/code/inspircd.git] / src / inspsocket.cpp
index c12494503214fe35005aed2af8ea2e6916f18fef..6407b213f848bcfd5553019769034593ddbbf4b0 100644 (file)
  * ---------------------------------------------------
  */
 
-/* $Core: libIRCDinspsocket */
+/* $Core */
 
 #include "socket.h"
 #include "inspstring.h"
 #include "socketengine.h"
 #include "inspircd.h"
 
-using irc::sockets::OpenTCPSocket;
-
 bool BufferedSocket::Readable()
 {
-       return ((this->state != I_CONNECTING) && (this->WaitingForWriteEvent == false));
+       return (this->state != I_CONNECTING);
 }
 
 BufferedSocket::BufferedSocket(InspIRCd* SI)
@@ -30,9 +28,7 @@ BufferedSocket::BufferedSocket(InspIRCd* SI)
        this->Timeout = NULL;
        this->state = I_DISCONNECTED;
        this->fd = -1;
-       this->WaitingForWriteEvent = false;
        this->Instance = SI;
-       this->IsIOHooked = false;
 }
 
 BufferedSocket::BufferedSocket(InspIRCd* SI, int newfd, const char* ip)
@@ -41,116 +37,66 @@ BufferedSocket::BufferedSocket(InspIRCd* SI, int newfd, const char* ip)
        this->fd = newfd;
        this->state = I_CONNECTED;
        strlcpy(this->IP,ip,MAXBUF);
-       this->WaitingForWriteEvent = false;
        this->Instance = SI;
-       this->IsIOHooked = false;
        if (this->fd > -1)
                this->Instance->SE->AddFd(this);
 }
 
-BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int aport, bool listening, unsigned long maxtime, const std::string &connectbindip)
+BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
 {
        this->cbindip = connectbindip;
        this->fd = -1;
        this->Instance = SI;
        strlcpy(host,ipaddr.c_str(),MAXBUF);
-       this->WaitingForWriteEvent = false;
-       this->IsIOHooked = false;
        this->Timeout = NULL;
-       if (listening)
+
+       strlcpy(this->host,ipaddr.c_str(),MAXBUF);
+       this->port = aport;
+
+       bool ipvalid = true;
+#ifdef IPV6
+       if (strchr(host,':'))
        {
-               if ((this->fd = OpenTCPSocket(host)) == ERROR)
-               {
-                       this->fd = -1;
-                       this->state = I_ERROR;
-                       this->OnError(I_ERR_SOCKET);
-                       return;
-               }
-               else
-               {
-                       if (!SI->BindSocket(this->fd,aport,(char*)ipaddr.c_str()))
-                       {
-                               this->Close();
-                               this->fd = -1;
-                               this->state = I_ERROR;
-                               this->OnError(I_ERR_BIND);
-                               this->ClosePending = true;
-                               return;
-                       }
-                       else
-                       {
-                               this->state = I_LISTENING;
-                               this->port = aport;
-                               if (this->fd > -1)
-                               {
-                                       if (!this->Instance->SE->AddFd(this))
-                                       {
-                                               this->Close();
-                                               this->state = I_ERROR;
-                                               this->OnError(I_ERR_NOMOREFDS);
-                                       }
-                               }
-                               return;
-                       }
-               }
+               in6_addr n;
+               if (inet_pton(AF_INET6, host, &n) < 1)
+                       ipvalid = false;
        }
        else
-       {
-               strlcpy(this->host,ipaddr.c_str(),MAXBUF);
-               this->port = aport;
-
-               bool ipvalid = true;
-#ifdef IPV6
-               if (strchr(host,':'))
-               {
-                       in6_addr n;
-                       if (inet_pton(AF_INET6, host, &n) < 1)
-                               ipvalid = false;
-               }
-               else
 #endif
+       {
+               in_addr n;
+               if (inet_aton(host,&n) < 1)
+                       ipvalid = false;
+       }
+       if (!ipvalid)
+       {
+               this->Instance->Logs->Log("SOCKET", DEBUG,"BUG: Hostname passed to BufferedSocket, rather than an IP address!");
+               this->OnError(I_ERR_CONNECT);
+               this->Close();
+               this->fd = -1;
+               this->state = I_ERROR;
+               return;
+       }
+       else
+       {
+               strlcpy(this->IP,host,MAXBUF);
+               if (!this->DoConnect(maxtime))
                {
-                       in_addr n;
-                       if (inet_aton(host,&n) < 1)
-                               ipvalid = false;
-               }
-               if (!ipvalid)
-               {
-                       this->Instance->Logs->Log("SOCKET", DEBUG,"BUG: Hostname passed to BufferedSocket, rather than an IP address!");
                        this->OnError(I_ERR_CONNECT);
                        this->Close();
                        this->fd = -1;
                        this->state = I_ERROR;
                        return;
                }
-               else
-               {
-                       strlcpy(this->IP,host,MAXBUF);
-                       timeout_val = maxtime;
-                       if (!this->DoConnect())
-                       {
-                               this->OnError(I_ERR_CONNECT);
-                               this->Close();
-                               this->fd = -1;
-                               this->state = I_ERROR;
-                               return;
-                       }
-               }
        }
 }
 
-void BufferedSocket::WantWrite()
-{
-       this->Instance->SE->WantWrite(this);
-       this->WaitingForWriteEvent = true;
-}
-
-void BufferedSocket::SetQueues(int nfd)
+void BufferedSocket::SetQueues()
 {
        // attempt to increase socket sendq and recvq as high as its possible
        int sendbuf = 32768;
        int recvbuf = 32768;
-       if(setsockopt(nfd,SOL_SOCKET,SO_SNDBUF,(const char *)&sendbuf,sizeof(sendbuf)) || setsockopt(nfd,SOL_SOCKET,SO_RCVBUF,(const char *)&recvbuf,sizeof(sendbuf)))
+       if(setsockopt(this->fd,SOL_SOCKET,SO_SNDBUF,(const char *)&sendbuf,sizeof(sendbuf)) || setsockopt(this->fd,SOL_SOCKET,SO_RCVBUF,(const char *)&recvbuf,sizeof(sendbuf)))
        {
                //this->Instance->Log(DEFAULT, "Could not increase SO_SNDBUF/SO_RCVBUF for socket %u", GetFd());
                ; // do nothing. I'm a little sick of people trying to interpret this message as a result of why their incorrect setups don't work.
@@ -240,7 +186,7 @@ bool BufferedSocket::BindAddr(const std::string &ip)
        return true;
 }
 
-bool BufferedSocket::DoConnect()
+bool BufferedSocket::DoConnect(unsigned long maxtime)
 {
        /* The [2] is required because we may write a sockaddr_in6 here, and sockaddr_in6 is larger than sockaddr, where sockaddr_in4 is not. */
        sockaddr* addr = new sockaddr[2];
@@ -310,11 +256,6 @@ bool BufferedSocket::DoConnect()
 
        Instance->SE->NonBlocking(this->fd);
 
-#ifdef WIN32
-       /* UGH for the LOVE OF ZOMBIE JESUS SOMEONE FIX THIS!!!!!!!!!!! */
-       Instance->SE->Blocking(this->fd);
-#endif
-
        if (Instance->SE->Connect(this, (sockaddr*)addr, size) == -1)
        {
                if (errno != EINPROGRESS)
@@ -325,13 +266,10 @@ bool BufferedSocket::DoConnect()
                        return false;
                }
 
-               this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, timeout_val, this->Instance->Time());
+               this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, maxtime, this->Instance->Time());
                this->Instance->Timers->AddTimer(this->Timeout);
        }
-#ifdef WIN32
-       /* CRAQ SMOKING STUFF TO BE FIXED */
-       Instance->SE->NonBlocking(this->fd);
-#endif
+
        this->state = I_CONNECTING;
        if (this->fd > -1)
        {
@@ -342,7 +280,7 @@ bool BufferedSocket::DoConnect()
                        this->state = I_ERROR;
                        return false;
                }
-               this->SetQueues(this->fd);
+               this->SetQueues();
        }
 
        Instance->Logs->Log("SOCKET", DEBUG,"BufferedSocket::DoConnect success");
@@ -359,12 +297,11 @@ void BufferedSocket::Close()
        int save = errno;
        if (this->fd > -1)
        {
-               if (this->IsIOHooked && Instance->Config->GetIOHook(this))
+               if (this->GetIOHook())
                {
                        try
                        {
-                               if (this->state != I_LISTENING)
-                                       Instance->Config->GetIOHook(this)->OnRawSocketClose(this->fd);
+                               this->GetIOHook()->OnRawSocketClose(this->fd);
                        }
                        catch (CoreException& modexcept)
                        {
@@ -394,13 +331,13 @@ const char* BufferedSocket::Read()
        int n = 0;
        char* ReadBuffer = Instance->GetReadBuffer();
 
-       if (this->IsIOHooked)
+       if (this->GetIOHook())
        {
                int result2 = 0;
                int MOD_RESULT = 0;
                try
                {
-                       MOD_RESULT = Instance->Config->GetIOHook(this)->OnRawSocketRead(this->fd, ReadBuffer, Instance->Config->NetBufferSize, result2);
+                       MOD_RESULT = this->GetIOHook()->OnRawSocketRead(this->fd, ReadBuffer, Instance->Config->NetBufferSize, result2);
                }
                catch (CoreException& modexcept)
                {
@@ -468,7 +405,7 @@ bool BufferedSocket::FlushWriteBuffer()
        errno = 0;
        if ((this->fd > -1) && (this->state == I_CONNECTED))
        {
-               if (this->IsIOHooked)
+               if (this->GetIOHook())
                {
                        while (outbuffer.size() && (errno != EAGAIN))
                        {
@@ -477,7 +414,7 @@ bool BufferedSocket::FlushWriteBuffer()
                                        /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
                                         * implement their own buffering mechanisms
                                         */
-                                       Instance->Config->GetIOHook(this)->OnRawSocketWrite(this->fd, outbuffer[0].c_str(), outbuffer[0].length());
+                                       this->GetIOHook()->OnRawSocketWrite(this->fd, outbuffer[0].c_str(), outbuffer[0].length());
                                        outbuffer.pop_front();
                                }
                                catch (CoreException& modexcept)
@@ -555,13 +492,12 @@ void SocketTimeout::Tick(time_t)
 
        if (this->sock->state == I_CONNECTING)
        {
-               // for non-listening sockets, the timeout can occur
+               // for connecting sockets, the timeout can occur
                // which causes termination of the connection after
                // the given number of seconds without a successful
                // connection.
                this->sock->OnTimeout();
                this->sock->OnError(I_ERR_TIMEOUT);
-               this->sock->timeout = true;
 
                /* NOTE: We must set this AFTER DelFd, as we added
                 * this socket whilst writeable. This means that we
@@ -576,103 +512,27 @@ void SocketTimeout::Tick(time_t)
        this->sock->Timeout = NULL;
 }
 
-bool BufferedSocket::Poll()
+bool BufferedSocket::InternalMarkConnected()
 {
-       int incoming = -1;
-
-#ifndef WINDOWS
-       if (!Instance->SE->BoundsCheckFd(this))
-               return false;
-#endif
-
-       if (Instance->SE->GetRef(this->fd) != this)
-               return false;
+       /* Our socket was in write-state, so delete it and re-add it
+        * in read-state.
+        */
+       this->SetState(I_CONNECTED);
 
-       switch (this->state)
+       if (this->GetIOHook())
        {
-               case I_CONNECTING:
-                       /* Our socket was in write-state, so delete it and re-add it
-                        * in read-state.
-                        */
-#ifndef WINDOWS
-                       if (this->fd > -1)
-                       {
-                               this->Instance->SE->DelFd(this);
-                               if (!this->Instance->SE->AddFd(this))
-                                       return false;
-                       }
-#endif
-                       this->SetState(I_CONNECTED);
-
-                       if (Instance->Config->GetIOHook(this))
-                       {
-                               Instance->Logs->Log("SOCKET",DEBUG,"Hook for raw connect");
-                               try
-                               {
-                                       Instance->Config->GetIOHook(this)->OnRawSocketConnect(this->fd);
-                               }
-                               catch (CoreException& modexcept)
-                               {
-                                       Instance->Logs->Log("SOCKET",DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
-                               }
-                       }
-                       return this->OnConnected();
-               break;
-               case I_LISTENING:
+               Instance->Logs->Log("SOCKET",DEBUG,"Hook for raw connect");
+               try
                {
-                       /* The [2] is required because we may write a sockaddr_in6 here, and sockaddr_in6 is larger than sockaddr, where sockaddr_in4 is not. */
-                       sockaddr* client = new sockaddr[2];
-                       length = sizeof (sockaddr_in);
-                       std::string recvip;
-#ifdef IPV6
-                       if ((!*this->host) || strchr(this->host, ':'))
-                               length = sizeof(sockaddr_in6);
-#endif
-                       incoming = Instance->SE->Accept(this, client, &length);
-#ifdef IPV6
-                       if ((!*this->host) || strchr(this->host, ':'))
-                       {
-                               char buf[1024];
-                               recvip = inet_ntop(AF_INET6, &((sockaddr_in6*)client)->sin6_addr, buf, sizeof(buf));
-                       }
-                       else
-#endif
-                       {
-                               // FIX: we were doing this for IPv6 connections as well, which was fucking recvip..
-                               // Add brackets to make this a bit clearer. -- w00t (Jan 15, 2008)
-                               recvip = inet_ntoa(((sockaddr_in*)client)->sin_addr);
-                       }
-
-                       Instance->SE->NonBlocking(incoming);
-
-                       this->OnIncomingConnection(incoming, (char*)recvip.c_str());
-
-                       if (this->IsIOHooked)
-                       {
-                               try
-                               {
-                                       Instance->Config->GetIOHook(this)->OnRawSocketAccept(incoming, recvip.c_str(), this->port);
-                               }
-                               catch (CoreException& modexcept)
-                               {
-                                       Instance->Logs->Log("SOCKET",DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
-                               }
-                       }
-
-                       this->SetQueues(incoming);
-
-                       delete[] client;
-                       return true;
+                       this->GetIOHook()->OnRawSocketConnect(this->fd);
+               }
+               catch (CoreException& modexcept)
+               {
+                       Instance->Logs->Log("SOCKET",DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
+                       return false;
                }
-               break;
-               case I_CONNECTED:
-                       /* Process the read event */
-                       return this->OnDataReady();
-               break;
-               default:
-               break;
        }
-       return true;
+       return this->OnConnected();
 }
 
 void BufferedSocket::SetState(BufferedSocketState s)
@@ -685,17 +545,15 @@ BufferedSocketState BufferedSocket::GetState()
        return this->state;
 }
 
-int BufferedSocket::GetFd()
-{
-       return this->fd;
-}
-
 bool BufferedSocket::OnConnected() { return true; }
 void BufferedSocket::OnError(BufferedSocketError) { return; }
 int BufferedSocket::OnDisconnect() { return 0; }
-int BufferedSocket::OnIncomingConnection(int, char*) { return 0; }
 bool BufferedSocket::OnDataReady() { return true; }
-bool BufferedSocket::OnWriteReady() { return true; }
+bool BufferedSocket::OnWriteReady()
+{
+       // Default behaviour: just try write some.
+       return !this->FlushWriteBuffer();
+}
 void BufferedSocket::OnTimeout() { return; }
 void BufferedSocket::OnClose() { return; }
 
@@ -714,67 +572,63 @@ void BufferedSocket::HandleEvent(EventType et, int errornum)
        switch (et)
        {
                case EVENT_ERROR:
+               {
                        switch (errornum)
                        {
                                case ETIMEDOUT:
                                        this->OnError(I_ERR_TIMEOUT);
-                               break;
+                                       break;
                                case ECONNREFUSED:
                                case 0:
                                        this->OnError(this->state == I_CONNECTING ? I_ERR_CONNECT : I_ERR_WRITE);
-                               break;
+                                       break;
                                case EADDRINUSE:
                                        this->OnError(I_ERR_BIND);
-                               break;
+                                       break;
                                case EPIPE:
                                case EIO:
                                        this->OnError(I_ERR_WRITE);
-                               break;
+                                       break;
                        }
+
                        if (this->Instance->SocketCull.find(this) == this->Instance->SocketCull.end())
                                this->Instance->SocketCull[this] = this;
                        return;
-               break;
+                       break;
+               }
                case EVENT_READ:
-                       if (!this->Poll())
+               {
+                       if (!this->OnDataReady())
                        {
                                if (this->Instance->SocketCull.find(this) == this->Instance->SocketCull.end())
                                        this->Instance->SocketCull[this] = this;
                                return;
                        }
-               break;
+                       break;
+               }
                case EVENT_WRITE:
-                       if (this->WaitingForWriteEvent)
+               {
+                       if (this->state == I_CONNECTING)
                        {
-                               this->WaitingForWriteEvent = false;
-                               if (!this->OnWriteReady())
+                               if (!this->InternalMarkConnected())
                                {
                                        if (this->Instance->SocketCull.find(this) == this->Instance->SocketCull.end())
                                                this->Instance->SocketCull[this] = this;
                                        return;
                                }
-                       }
-                       if (this->state == I_CONNECTING)
-                       {
-                               /* This might look wrong as if we should be actually calling
-                                * with EVENT_WRITE, but trust me it is correct. There are some
-                                * writeability-state things in the read code, because of how
-                                * BufferedSocket used to work regarding write buffering in previous
-                                * versions of InspIRCd. - Brain
-                                */
-                               this->HandleEvent(EVENT_READ);
                                return;
                        }
                        else
                        {
-                               if (this->FlushWriteBuffer())
+                               if (!this->OnWriteReady())
                                {
                                        if (this->Instance->SocketCull.find(this) == this->Instance->SocketCull.end())
                                                this->Instance->SocketCull[this] = this;
                                        return;
                                }
                        }
-               break;
+                       break;
+               }
        }
 }