]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/inspsocket.cpp
Split IOHook into IOHook and IOHookProvider
[user/henk/code/inspircd.git] / src / inspsocket.cpp
index 391d7fe82d4367b161a685a661a0ea76214ded98..ea09a8b1d5ca2c6fa819acdf978996770a26f3a3 100644 (file)
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
+ *
+ *   Copyright (C) 2009 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2007-2009 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2008 Thomas Stagner <aquanight@inspircd.org>
+ *   Copyright (C) 2006-2007 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
  *
- * ---------------------------------------------------
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* $Core */
 
+#include "inspircd.h"
 #include "socket.h"
 #include "inspstring.h"
 #include "socketengine.h"
-#include "inspircd.h"
+#include "iohook.h"
 
-bool BufferedSocket::Readable()
-{
-       return (this->state != I_CONNECTING);
-}
+#ifndef DISABLE_WRITEV
+#include <sys/uio.h>
+#endif
+
+#ifndef IOV_MAX
+#define IOV_MAX 1024
+#endif
 
-BufferedSocket::BufferedSocket(InspIRCd* SI)
+BufferedSocket::BufferedSocket()
 {
-       this->Timeout = NULL;
-       this->state = I_DISCONNECTED;
-       this->fd = -1;
-       this->ServerInstance = SI;
+       Timeout = NULL;
+       state = I_ERROR;
 }
 
-BufferedSocket::BufferedSocket(InspIRCd* SI, int newfd, const char* ip)
+BufferedSocket::BufferedSocket(int newfd)
 {
-       this->Timeout = NULL;
+       Timeout = NULL;
        this->fd = newfd;
        this->state = I_CONNECTED;
-       strlcpy(this->IP,ip,MAXBUF);
-       this->ServerInstance = SI;
-       if (this->fd > -1)
-               this->ServerInstance->SE->AddFd(this);
+       if (fd > -1)
+               ServerInstance->SE->AddFd(this, FD_WANT_FAST_READ | FD_WANT_EDGE_WRITE);
 }
 
-BufferedSocket::BufferedSocket(InspIRCd* SI, const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
+void BufferedSocket::DoConnect(const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
 {
-       this->cbindip = connectbindip;
-       this->fd = -1;
-       this->ServerInstance = SI;
-       strlcpy(host,ipaddr.c_str(),MAXBUF);
-       this->Timeout = NULL;
-
-       strlcpy(this->host,ipaddr.c_str(),MAXBUF);
-       this->port = aport;
-
-       bool ipvalid = true;
-#ifdef IPV6
-       if (strchr(host,':'))
-       {
-               in6_addr n;
-               if (inet_pton(AF_INET6, host, &n) < 1)
-                       ipvalid = false;
-       }
-       else
-#endif
+       BufferedSocketError err = BeginConnect(ipaddr, aport, maxtime, connectbindip);
+       if (err != I_ERR_NONE)
        {
-               in_addr n;
-               if (inet_aton(host,&n) < 1)
-                       ipvalid = false;
-       }
-       if (!ipvalid)
-       {
-               this->ServerInstance->Logs->Log("SOCKET", DEBUG,"BUG: Hostname passed to BufferedSocket, rather than an IP address!");
-               this->OnError(I_ERR_CONNECT);
-               this->Close();
-               this->fd = -1;
-               this->state = I_ERROR;
-               return;
-       }
-       else
-       {
-               strlcpy(this->IP,host,MAXBUF);
-               if (!this->DoConnect(maxtime))
-               {
-                       this->OnError(I_ERR_CONNECT);
-                       this->Close();
-                       this->fd = -1;
-                       this->state = I_ERROR;
-                       return;
-               }
+               state = I_ERROR;
+               SetError(SocketEngine::LastError());
+               OnError(err);
        }
 }
 
-void BufferedSocket::SetQueues()
+BufferedSocketError BufferedSocket::BeginConnect(const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
 {
-       // attempt to increase socket sendq and recvq as high as its possible
-       int sendbuf = 32768;
-       int recvbuf = 32768;
-       if(setsockopt(this->fd,SOL_SOCKET,SO_SNDBUF,(const char *)&sendbuf,sizeof(sendbuf)) || setsockopt(this->fd,SOL_SOCKET,SO_RCVBUF,(const char *)&recvbuf,sizeof(sendbuf)))
+       irc::sockets::sockaddrs addr, bind;
+       if (!irc::sockets::aptosa(ipaddr, aport, addr))
        {
-               //this->ServerInstance->Log(DEFAULT, "Could not increase SO_SNDBUF/SO_RCVBUF for socket %u", GetFd());
-               ; // do nothing. I'm a little sick of people trying to interpret this message as a result of why their incorrect setups don't work.
+               ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "BUG: Hostname passed to BufferedSocket, rather than an IP address!");
+               return I_ERR_CONNECT;
        }
-}
 
-bool BufferedSocket::DoBindMagic(const std::string &current_ip, bool v6)
-{
-       /* The [2] is required because we may write a sockaddr_in6 here, and sockaddr_in6 is larger than sockaddr, where sockaddr_in4 is not. */
-       socklen_t size = sizeof(sockaddr_in);
-       sockaddr* s = new sockaddr[2];
-#ifdef IPV6
-       if (v6)
-       {
-               in6_addr n;
-               if (inet_pton(AF_INET6, current_ip.c_str(), &n) > 0)
-               {
-                       memcpy(&((sockaddr_in6*)s)->sin6_addr, &n, sizeof(sockaddr_in6));
-                       ((sockaddr_in6*)s)->sin6_port = 0;
-                       ((sockaddr_in6*)s)->sin6_family = AF_INET6;
-                       size = sizeof(sockaddr_in6);
-               }
-               else
-               {
-                       // Well, this is as good as it's gonna get.
-                       errno = EADDRNOTAVAIL;
-                       delete[] s;
-                       return false;
-               }
-       }
-       else
-#endif
+       bind.sa.sa_family = 0;
+       if (!connectbindip.empty())
        {
-               in_addr n;
-               if (inet_aton(current_ip.c_str(), &n) > 0)
-               {
-                       ((sockaddr_in*)s)->sin_addr = n;
-                       ((sockaddr_in*)s)->sin_port = 0;
-                       ((sockaddr_in*)s)->sin_family = AF_INET;
-               }
-               else
+               if (!irc::sockets::aptosa(connectbindip, 0, bind))
                {
-                       // Well, this is as good as it's gonna get.
-                       errno = EADDRNOTAVAIL;
-                       delete[] s;
-                       return false;
+                       return I_ERR_BIND;
                }
        }
 
-       if (ServerInstance->SE->Bind(this->fd, s, size) < 0)
-       {
-               this->state = I_ERROR;
-               this->OnError(I_ERR_BIND);
-               delete[] s;
-               return false;
-       }
-
-       delete[] s;
-       return true;
+       return BeginConnect(addr, bind, maxtime);
 }
 
-/* Most irc servers require you to specify the ip you want to bind to.
- * If you dont specify an IP, they rather dumbly bind to the first IP
- * of the box (e.g. INADDR_ANY). In InspIRCd, we scan thought the IP
- * addresses we've bound server ports to, and we try and bind our outbound
- * connections to the first usable non-loopback and non-any IP we find.
- * This is easier to configure when you have a lot of links and a lot
- * of servers to configure.
- */
-bool BufferedSocket::BindAddr(const std::string &ip_to_bind)
+BufferedSocketError BufferedSocket::BeginConnect(const irc::sockets::sockaddrs& dest, const irc::sockets::sockaddrs& bind, unsigned long timeout)
 {
-       ConfigReader Conf(this->ServerInstance);
-       bool v6 = false;
-#ifdef IPV6
-       /* Are we looking for a binding to fit an ipv6 host? */
-       if ((ip_to_bind.empty()) || (ip_to_bind.find(':') != std::string::npos))
-               v6 = true;
-#endif
+       if (fd < 0)
+               fd = socket(dest.sa.sa_family, SOCK_STREAM, 0);
 
-       // Case one: If they provided an IP, try bind it
-       if (!ip_to_bind.empty())
-       {
-               // And if it fails, don't do anything.
-               return this->DoBindMagic(ip_to_bind, v6);
-       }
+       if (fd < 0)
+               return I_ERR_SOCKET;
 
-       for (int j = 0; j < Conf.Enumerate("bind"); j++)
+       if (bind.sa.sa_family != 0)
        {
-               // We only want to try bind to a server ip.
-               if (Conf.ReadValue("bind","type",j) != "servers")
-                       continue;
-
-               // set current IP to the <bind> tag
-               std::string current_ip = Conf.ReadValue("bind","address",j);
-
-               // Make sure IP is nothing local
-               if (current_ip == "*" || current_ip == "127.0.0.1" || current_ip.empty() || current_ip == "::1")
-                       continue;
-
-               // Try bind, don't fail if it doesn't bind though.
-               if (this->DoBindMagic(current_ip, v6))
-                       return true;
+               if (ServerInstance->SE->Bind(fd, bind) < 0)
+                       return I_ERR_BIND;
        }
 
-       // NOTE: You may wonder WTF we are returning *true* here, but that is because there were no custom binds setup, and so we have nothing to do
-       // (remember, outgoing connections without binding are perfectly ok).
-       ServerInstance->Logs->Log("SOCKET", DEBUG,"nothing in the config to bind()!");
-       return true;
-}
+       ServerInstance->SE->NonBlocking(fd);
 
-bool BufferedSocket::DoConnect(unsigned long maxtime)
-{
-       /* The [2] is required because we may write a sockaddr_in6 here, and sockaddr_in6 is larger than sockaddr, where sockaddr_in4 is not. */
-       sockaddr* addr = new sockaddr[2];
-       socklen_t size = sizeof(sockaddr_in);
-#ifdef IPV6
-       bool v6 = false;
-       if ((!*this->host) || strchr(this->host, ':'))
-               v6 = true;
-
-       if (v6)
-       {
-               this->fd = socket(AF_INET6, SOCK_STREAM, 0);
-               if ((this->fd > -1) && ((strstr(this->IP,"::ffff:") != (char*)&this->IP) && (strstr(this->IP,"::FFFF:") != (char*)&this->IP)))
-               {
-                       if (!this->BindAddr(this->cbindip))
-                       {
-                               this->Close();
-                               this->fd = -1;
-                               delete[] addr;
-                               return false;
-                       }
-               }
-       }
-       else
-#endif
-       {
-               this->fd = socket(AF_INET, SOCK_STREAM, 0);
-               if (this->fd > -1)
-               {
-                       if (!this->BindAddr(this->cbindip))
-                       {
-                               this->Close();
-                               this->fd = -1;
-                               delete[] addr;
-                               return false;
-                       }
-               }
-       }
-
-       if (this->fd == -1)
-       {
-               this->state = I_ERROR;
-               this->OnError(I_ERR_SOCKET);
-               delete[] addr;
-               return false;
-       }
-
-#ifdef IPV6
-       if (v6)
-       {
-               in6_addr addy;
-               if (inet_pton(AF_INET6, this->host, &addy) > 0)
-               {
-                       ((sockaddr_in6*)addr)->sin6_family = AF_INET6;
-                       memcpy(&((sockaddr_in6*)addr)->sin6_addr, &addy, sizeof(addy));
-                       ((sockaddr_in6*)addr)->sin6_port = htons(this->port);
-                       size = sizeof(sockaddr_in6);
-               }
-       }
-       else
-#endif
-       {
-               in_addr addy;
-               if (inet_aton(this->host, &addy) > 0)
-               {
-                       ((sockaddr_in*)addr)->sin_family = AF_INET;
-                       ((sockaddr_in*)addr)->sin_addr = addy;
-                       ((sockaddr_in*)addr)->sin_port = htons(this->port);
-               }
-       }
-
-       ServerInstance->SE->NonBlocking(this->fd);
-
-       if (ServerInstance->SE->Connect(this, (sockaddr*)addr, size) == -1)
+       if (ServerInstance->SE->Connect(this, &dest.sa, dest.sa_size()) == -1)
        {
                if (errno != EINPROGRESS)
-               {
-                       this->OnError(I_ERR_CONNECT);
-                       this->Close();
-                       this->state = I_ERROR;
-                       delete[] addr;
-                       return false;
-               }
-
-               this->Timeout = new SocketTimeout(this->GetFd(), this->ServerInstance, this, maxtime, this->ServerInstance->Time());
-               this->ServerInstance->Timers->AddTimer(this->Timeout);
+                       return I_ERR_CONNECT;
        }
 
        this->state = I_CONNECTING;
-       delete[] addr;
-       if (this->fd > -1)
-       {
-               if (!this->ServerInstance->SE->AddFd(this))
-               {
-                       this->OnError(I_ERR_NOMOREFDS);
-                       this->Close();
-                       this->state = I_ERROR;
-                       return false;
-               }
-               this->SetQueues();
-       }
 
-       ServerInstance->Logs->Log("SOCKET", DEBUG,"BufferedSocket::DoConnect success");
-       return true;
-}
+       if (!ServerInstance->SE->AddFd(this, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE | FD_WRITE_WILL_BLOCK))
+               return I_ERR_NOMOREFDS;
 
+       this->Timeout = new SocketTimeout(this->GetFd(), this, timeout, ServerInstance->Time());
+       ServerInstance->Timers->AddTimer(this->Timeout);
 
-void BufferedSocket::Close()
+       ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "BufferedSocket::DoConnect success");
+       return I_ERR_NONE;
+}
+
+void StreamSocket::Close()
 {
-       /* Save this, so we dont lose it,
-        * otherise on failure, error messages
-        * might be inaccurate.
-        */
-       int save = errno;
        if (this->fd > -1)
        {
-               if (this->GetIOHook())
+               // final chance, dump as much of the sendq as we can
+               DoWrite();
+               if (GetIOHook())
                {
                        try
                        {
-                               this->GetIOHook()->OnRawSocketClose(this->fd);
+                               GetIOHook()->OnStreamSocketClose(this);
                        }
                        catch (CoreException& modexcept)
                        {
-                               ServerInstance->Logs->Log("SOCKET", DEFAULT,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
+                               ServerInstance->Logs->Log("SOCKET", LOG_DEFAULT, "%s threw an exception: %s",
+                                       modexcept.GetSource().c_str(), modexcept.GetReason().c_str());
                        }
+                       delete iohook;
+                       DelIOHook();
                }
                ServerInstance->SE->Shutdown(this, 2);
-               if (ServerInstance->SE->Close(this) != -1)
-                       this->OnClose();
-
-               if (ServerInstance->SocketCull.find(this) == ServerInstance->SocketCull.end())
-                       ServerInstance->SocketCull[this] = this;
+               ServerInstance->SE->DelFd(this);
+               ServerInstance->SE->Close(this);
+               fd = -1;
        }
-       errno = save;
 }
 
-std::string BufferedSocket::GetIP()
+CullResult StreamSocket::cull()
 {
-       return this->IP;
+       Close();
+       return EventHandler::cull();
 }
 
-const char* BufferedSocket::Read()
+bool StreamSocket::GetNextLine(std::string& line, char delim)
 {
-       if (!ServerInstance->SE->BoundsCheckFd(this))
-               return NULL;
-
-       int n = 0;
-       char* ReadBuffer = ServerInstance->GetReadBuffer();
+       std::string::size_type i = recvq.find(delim);
+       if (i == std::string::npos)
+               return false;
+       line = recvq.substr(0, i);
+       // TODO is this the most efficient way to split?
+       recvq = recvq.substr(i + 1);
+       return true;
+}
 
-       if (this->GetIOHook())
+void StreamSocket::DoRead()
+{
+       if (GetIOHook())
        {
-               int result2 = 0;
-               int MOD_RESULT = 0;
+               int rv = -1;
                try
                {
-                       MOD_RESULT = this->GetIOHook()->OnRawSocketRead(this->fd, ReadBuffer, ServerInstance->Config->NetBufferSize, result2);
+                       rv = GetIOHook()->OnStreamSocketRead(this, recvq);
                }
                catch (CoreException& modexcept)
                {
-                       ServerInstance->Logs->Log("SOCKET", DEFAULT,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
+                       ServerInstance->Logs->Log("SOCKET", LOG_DEFAULT, "%s threw an exception: %s",
+                               modexcept.GetSource().c_str(), modexcept.GetReason().c_str());
+                       return;
                }
-               if (MOD_RESULT < 0)
+               if (rv > 0)
+                       OnDataReady();
+               if (rv < 0)
+                       SetError("Read Error"); // will not overwrite a better error message
+       }
+       else
+       {
+               char* ReadBuffer = ServerInstance->GetReadBuffer();
+               int n = ServerInstance->SE->Recv(this, ReadBuffer, ServerInstance->Config->NetBufferSize, 0);
+               if (n == ServerInstance->Config->NetBufferSize)
                {
-                       n = -1;
-                       errno = EAGAIN;
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_READ | FD_ADD_TRIAL_READ);
+                       recvq.append(ReadBuffer, n);
+                       OnDataReady();
                }
-               else
+               else if (n > 0)
                {
-                       n = result2;
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_READ);
+                       recvq.append(ReadBuffer, n);
+                       OnDataReady();
+               }
+               else if (n == 0)
+               {
+                       error = "Connection closed";
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_NO_READ | FD_WANT_NO_WRITE);
+               }
+               else if (SocketEngine::IgnoreError())
+               {
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_READ | FD_READ_WILL_BLOCK);
+               }
+               else if (errno == EINTR)
+               {
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_READ | FD_ADD_TRIAL_READ);
                }
-       }
-       else
-       {
-               n = recv(this->fd, ReadBuffer, ServerInstance->Config->NetBufferSize, 0);
-       }
-
-       /*
-        * This used to do some silly bounds checking instead of just passing bufsize - 1 to recv.
-        * Not only does that make absolutely no sense, but it could potentially result in a read buffer's worth
-        * of data being thrown into the bit bucket for no good reason, which is just *stupid*.. do things correctly now.
-        * --w00t (july 2, 2008)
-        */
-       if (n > 0)
-       {
-               ReadBuffer[n] = 0;
-               return ReadBuffer;
-       }
-       else
-       {
-               int err = errno;
-               if (err == EAGAIN)
-                       return "";
                else
-                       return NULL;
+               {
+                       error = SocketEngine::LastError();
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_NO_READ | FD_WANT_NO_WRITE);
+               }
        }
 }
 
-/*
- * This function formerly tried to flush write buffer each call.
- * While admirable in attempting to get the data out to wherever
- * it is going, on a full socket, it's just going to syscall write() and
- * EAGAIN constantly, instead of waiting in the SE to know if it can write
- * which will chew a bit of CPU.
- *
- * So, now this function returns void (take note) and just adds to the sendq.
- *
- * It'll get written at a determinate point when the socketengine tells us it can write.
- *             -- w00t (april 1, 2008)
- */
-void BufferedSocket::Write(const std::string &data)
-{
-       /* Append the data to the back of the queue ready for writing */
-       outbuffer.push_back(data);
-
-       /* Mark ourselves as wanting write */
-       this->ServerInstance->SE->WantWrite(this);
-}
+/* Don't try to prepare huge blobs of data to send to a blocked socket */
+static const int MYIOV_MAX = IOV_MAX < 128 ? IOV_MAX : 128;
 
-bool BufferedSocket::FlushWriteBuffer()
+void StreamSocket::DoWrite()
 {
-       errno = 0;
-       if ((this->fd > -1) && (this->state == I_CONNECTED))
+       if (sendq.empty())
+               return;
+       if (!error.empty() || fd < 0 || fd == INT_MAX)
+       {
+               ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "DoWrite on errored or closed socket");
+               return;
+       }
+
+#ifndef DISABLE_WRITEV
+       if (GetIOHook())
+#endif
        {
-               if (this->GetIOHook())
+               int rv = -1;
+               try
                {
-                       while (outbuffer.size() && (errno != EAGAIN))
+                       while (error.empty() && !sendq.empty())
                        {
-                               try
+                               if (sendq.size() > 1 && sendq[0].length() < 1024)
                                {
-                                       /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
-                                        * implement their own buffering mechanisms
-                                        */
-                                       this->GetIOHook()->OnRawSocketWrite(this->fd, outbuffer[0].c_str(), outbuffer[0].length());
-                                       outbuffer.pop_front();
+                                       // Avoid multiple repeated SSL encryption invocations
+                                       // This adds a single copy of the queue, but avoids
+                                       // much more overhead in terms of system calls invoked
+                                       // by the IOHook.
+                                       //
+                                       // The length limit of 1024 is to prevent merging strings
+                                       // more than once when writes begin to block.
+                                       std::string tmp;
+                                       tmp.reserve(1280);
+                                       while (!sendq.empty() && tmp.length() < 1024)
+                                       {
+                                               tmp.append(sendq.front());
+                                               sendq.pop_front();
+                                       }
+                                       sendq.push_front(tmp);
                                }
-                               catch (CoreException& modexcept)
+                               std::string& front = sendq.front();
+                               int itemlen = front.length();
+                               if (GetIOHook())
                                {
-                                       ServerInstance->Logs->Log("SOCKET", DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
-                                       return true;
+                                       rv = GetIOHook()->OnStreamSocketWrite(this, front);
+                                       if (rv > 0)
+                                       {
+                                               // consumed the entire string, and is ready for more
+                                               sendq_len -= itemlen;
+                                               sendq.pop_front();
+                                       }
+                                       else if (rv == 0)
+                                       {
+                                               // socket has blocked. Stop trying to send data.
+                                               // IOHook has requested unblock notification from the socketengine
+
+                                               // Since it is possible that a partial write took place, adjust sendq_len
+                                               sendq_len = sendq_len - itemlen + front.length();
+                                               return;
+                                       }
+                                       else
+                                       {
+                                               SetError("Write Error"); // will not overwrite a better error message
+                                               return;
+                                       }
                                }
+#ifdef DISABLE_WRITEV
+                               else
+                               {
+                                       rv = ServerInstance->SE->Send(this, front.data(), itemlen, 0);
+                                       if (rv == 0)
+                                       {
+                                               SetError("Connection closed");
+                                               return;
+                                       }
+                                       else if (rv < 0)
+                                       {
+                                               if (errno == EINTR || SocketEngine::IgnoreError())
+                                                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_WRITE | FD_WRITE_WILL_BLOCK);
+                                               else
+                                                       SetError(SocketEngine::LastError());
+                                               return;
+                                       }
+                                       else if (rv < itemlen)
+                                       {
+                                               ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_WRITE | FD_WRITE_WILL_BLOCK);
+                                               front = front.substr(rv);
+                                               sendq_len -= rv;
+                                               return;
+                                       }
+                                       else
+                                       {
+                                               sendq_len -= itemlen;
+                                               sendq.pop_front();
+                                               if (sendq.empty())
+                                                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_EDGE_WRITE);
+                                       }
+                               }
+#endif
                        }
                }
-               else
+               catch (CoreException& modexcept)
                {
-                       /* If we have multiple lines, try to send them all,
-                        * not just the first one -- Brain
-                        */
-                       while (outbuffer.size() && (errno != EAGAIN))
+                       ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "%s threw an exception: %s",
+                               modexcept.GetSource().c_str(), modexcept.GetReason().c_str());
+               }
+       }
+#ifndef DISABLE_WRITEV
+       else
+       {
+               // don't even try if we are known to be blocking
+               if (GetEventMask() & FD_WRITE_WILL_BLOCK)
+                       return;
+               // start out optimistic - we won't need to write any more
+               int eventChange = FD_WANT_EDGE_WRITE;
+               while (error.empty() && sendq_len && eventChange == FD_WANT_EDGE_WRITE)
+               {
+                       // Prepare a writev() call to write all buffers efficiently
+                       int bufcount = sendq.size();
+
+                       // cap the number of buffers at MYIOV_MAX
+                       if (bufcount > MYIOV_MAX)
                        {
-                               /* Send a line */
-                               int result = ServerInstance->SE->Send(this, outbuffer[0].c_str(), outbuffer[0].length(), 0);
+                               bufcount = MYIOV_MAX;
+                       }
+
+                       int rv_max = 0;
+                       iovec* iovecs = new iovec[bufcount];
+                       for(int i=0; i < bufcount; i++)
+                       {
+                               iovecs[i].iov_base = const_cast<char*>(sendq[i].data());
+                               iovecs[i].iov_len = sendq[i].length();
+                               rv_max += sendq[i].length();
+                       }
+                       int rv = writev(fd, iovecs, bufcount);
+                       delete[] iovecs;
 
-                               if (result > 0)
+                       if (rv == (int)sendq_len)
+                       {
+                               // it's our lucky day, everything got written out. Fast cleanup.
+                               // This won't ever happen if the number of buffers got capped.
+                               sendq_len = 0;
+                               sendq.clear();
+                       }
+                       else if (rv > 0)
+                       {
+                               // Partial write. Clean out strings from the sendq
+                               if (rv < rv_max)
                                {
-                                       if ((unsigned int)result >= outbuffer[0].length())
+                                       // it's going to block now
+                                       eventChange = FD_WANT_FAST_WRITE | FD_WRITE_WILL_BLOCK;
+                               }
+                               sendq_len -= rv;
+                               while (rv > 0 && !sendq.empty())
+                               {
+                                       std::string& front = sendq.front();
+                                       if (front.length() <= (size_t)rv)
                                        {
-                                               /* The whole block was written (usually a line)
-                                                * Pop the block off the front of the queue,
-                                                * dont set errno, because we are clear of errors
-                                                * and want to try and write the next block too.
-                                                */
-                                               outbuffer.pop_front();
+                                               // this string got fully written out
+                                               rv -= front.length();
+                                               sendq.pop_front();
                                        }
                                        else
                                        {
-                                               std::string temp = outbuffer[0].substr(result);
-                                               outbuffer[0] = temp;
-                                               /* We didnt get the whole line out. arses.
-                                                * Try again next time, i guess. Set errno,
-                                                * because we shouldnt be writing any more now,
-                                                * until the socketengine says its safe to do so.
-                                                */
-                                               errno = EAGAIN;
+                                               // stopped in the middle of this string
+                                               front = front.substr(rv);
+                                               rv = 0;
                                        }
                                }
-                               else if (result == 0)
-                               {
-                                       this->ServerInstance->SE->DelFd(this);
-                                       this->Close();
-                                       return true;
-                               }
-                               else if ((result == -1) && (errno != EAGAIN))
-                               {
-                                       this->OnError(I_ERR_WRITE);
-                                       this->state = I_ERROR;
-                                       this->ServerInstance->SE->DelFd(this);
-                                       this->Close();
-                                       return true;
-                               }
                        }
+                       else if (rv == 0)
+                       {
+                               error = "Connection closed";
+                       }
+                       else if (SocketEngine::IgnoreError())
+                       {
+                               eventChange = FD_WANT_FAST_WRITE | FD_WRITE_WILL_BLOCK;
+                       }
+                       else if (errno == EINTR)
+                       {
+                               // restart interrupted syscall
+                               errno = 0;
+                       }
+                       else
+                       {
+                               error = SocketEngine::LastError();
+                       }
+               }
+               if (!error.empty())
+               {
+                       // error - kill all events
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_NO_READ | FD_WANT_NO_WRITE);
+               }
+               else
+               {
+                       ServerInstance->SE->ChangeEventMask(this, eventChange);
                }
        }
+#endif
+}
 
-       if ((errno == EAGAIN) && (fd > -1))
+void StreamSocket::WriteData(const std::string &data)
+{
+       if (fd < 0)
        {
-               this->ServerInstance->SE->WantWrite(this);
+               ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Attempt to write data to dead socket: %s",
+                       data.c_str());
+               return;
        }
 
-       return (fd < 0);
+       /* Append the data to the back of the queue ready for writing */
+       sendq.push_back(data);
+       sendq_len += data.length();
+
+       ServerInstance->SE->ChangeEventMask(this, FD_ADD_TRIAL_WRITE);
 }
 
-void SocketTimeout::Tick(time_t)
+bool SocketTimeout::Tick(time_t)
 {
-       ServerInstance->Logs->Log("SOCKET", DEBUG,"SocketTimeout::Tick");
+       ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "SocketTimeout::Tick");
 
        if (ServerInstance->SE->GetRef(this->sfd) != this->sock)
-               return;
+               return false;
 
        if (this->sock->state == I_CONNECTING)
        {
@@ -525,137 +450,95 @@ void SocketTimeout::Tick(time_t)
                // connection.
                this->sock->OnTimeout();
                this->sock->OnError(I_ERR_TIMEOUT);
-
-               /* NOTE: We must set this AFTER DelFd, as we added
-                * this socket whilst writeable. This means that we
-                * must DELETE the socket whilst writeable too!
-                */
                this->sock->state = I_ERROR;
 
-               if (ServerInstance->SocketCull.find(this->sock) == ServerInstance->SocketCull.end())
-                       ServerInstance->SocketCull[this->sock] = this->sock;
+               ServerInstance->GlobalCulls.AddItem(sock);
        }
 
        this->sock->Timeout = NULL;
+       return false;
 }
 
-bool BufferedSocket::InternalMarkConnected()
-{
-       /* Our socket was in write-state, so delete it and re-add it
-        * in read-state.
-        */
-       this->SetState(I_CONNECTED);
+void BufferedSocket::OnConnected() { }
+void BufferedSocket::OnTimeout() { return; }
 
-       if (this->GetIOHook())
+void BufferedSocket::DoWrite()
+{
+       if (state == I_CONNECTING)
        {
-               ServerInstance->Logs->Log("SOCKET",DEBUG,"Hook for raw connect");
-               try
-               {
-                       this->GetIOHook()->OnRawSocketConnect(this->fd);
-               }
-               catch (CoreException& modexcept)
-               {
-                       ServerInstance->Logs->Log("SOCKET",DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
-                       return false;
-               }
+               state = I_CONNECTED;
+               this->OnConnected();
+               if (!GetIOHook())
+                       ServerInstance->SE->ChangeEventMask(this, FD_WANT_FAST_READ | FD_WANT_EDGE_WRITE);
        }
-       return this->OnConnected();
+       this->StreamSocket::DoWrite();
 }
 
-void BufferedSocket::SetState(BufferedSocketState s)
-{
-       this->state = s;
-}
-
-BufferedSocketState BufferedSocket::GetState()
-{
-       return this->state;
-}
-
-bool BufferedSocket::OnConnected() { return true; }
-void BufferedSocket::OnError(BufferedSocketError) { return; }
-int BufferedSocket::OnDisconnect() { return 0; }
-bool BufferedSocket::OnDataReady() { return true; }
-bool BufferedSocket::OnWriteReady()
-{
-       // Default behaviour: just try write some.
-       return !this->FlushWriteBuffer();
-}
-void BufferedSocket::OnTimeout() { return; }
-void BufferedSocket::OnClose() { return; }
-
 BufferedSocket::~BufferedSocket()
 {
        this->Close();
        if (Timeout)
        {
-               ServerInstance->Timers->DelTimer(Timeout);
-               Timeout = NULL;
+               // The timer is removed from the TimerManager in Timer::~Timer()
+               delete Timeout;
        }
 }
 
-void BufferedSocket::HandleEvent(EventType et, int errornum)
+void StreamSocket::HandleEvent(EventType et, int errornum)
 {
-       switch (et)
-       {
-               case EVENT_ERROR:
-               {
-                       switch (errornum)
-                       {
-                               case ETIMEDOUT:
-                                       this->OnError(I_ERR_TIMEOUT);
-                                       break;
-                               case ECONNREFUSED:
-                               case 0:
-                                       this->OnError(this->state == I_CONNECTING ? I_ERR_CONNECT : I_ERR_WRITE);
-                                       break;
-                               case EADDRINUSE:
-                                       this->OnError(I_ERR_BIND);
-                                       break;
-                               case EPIPE:
-                               case EIO:
-                                       this->OnError(I_ERR_WRITE);
-                                       break;
-                       }
-
-                       if (this->ServerInstance->SocketCull.find(this) == this->ServerInstance->SocketCull.end())
-                               this->ServerInstance->SocketCull[this] = this;
-                       return;
-                       break;
-               }
-               case EVENT_READ:
-               {
-                       if (!this->OnDataReady())
-                       {
-                               if (this->ServerInstance->SocketCull.find(this) == this->ServerInstance->SocketCull.end())
-                                       this->ServerInstance->SocketCull[this] = this;
-                               return;
-                       }
-                       break;
-               }
-               case EVENT_WRITE:
+       if (!error.empty())
+               return;
+       BufferedSocketError errcode = I_ERR_OTHER;
+       try {
+               switch (et)
                {
-                       if (this->state == I_CONNECTING)
+                       case EVENT_ERROR:
                        {
-                               if (!this->InternalMarkConnected())
+                               if (errornum == 0)
+                                       SetError("Connection closed");
+                               else
+                                       SetError(SocketEngine::GetError(errornum));
+                               switch (errornum)
                                {
-                                       if (this->ServerInstance->SocketCull.find(this) == this->ServerInstance->SocketCull.end())
-                                               this->ServerInstance->SocketCull[this] = this;
-                                       return;
+                                       case ETIMEDOUT:
+                                               errcode = I_ERR_TIMEOUT;
+                                               break;
+                                       case ECONNREFUSED:
+                                       case 0:
+                                               errcode = I_ERR_CONNECT;
+                                               break;
+                                       case EADDRINUSE:
+                                               errcode = I_ERR_BIND;
+                                               break;
+                                       case EPIPE:
+                                       case EIO:
+                                               errcode = I_ERR_WRITE;
+                                               break;
                                }
-                               return;
+                               break;
                        }
-                       else
+                       case EVENT_READ:
                        {
-                               if (!this->OnWriteReady())
-                               {
-                                       if (this->ServerInstance->SocketCull.find(this) == this->ServerInstance->SocketCull.end())
-                                               this->ServerInstance->SocketCull[this] = this;
-                                       return;
-                               }
+                               DoRead();
+                               break;
+                       }
+                       case EVENT_WRITE:
+                       {
+                               DoWrite();
+                               break;
                        }
-                       break;
                }
        }
+       catch (CoreException& ex)
+       {
+               ServerInstance->Logs->Log("SOCKET", LOG_DEFAULT, "Caught exception in socket processing on FD %d - '%s'",
+                       fd, ex.GetReason().c_str());
+               SetError(ex.GetReason());
+       }
+       if (!error.empty())
+       {
+               ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Error on FD %d - '%s'", fd, error.c_str());
+               OnError(errcode);
+       }
 }