Relax fd bounds checking

[user/henk/code/inspircd.git] / src / listensocket.cpp

diff --git a/src/listensocket.cpp b/src/listensocket.cpp
index 108466ae34548993b86c2c1ab18db4e78cb38920..cb4bfd2db4a01bd06fa6f177bce17e4b8e4e2ef3 100644 (file)
--- a/src/listensocket.cpp
+++ b/src/listensocket.cpp
@@ -28,6 +28,7 @@
 
 ListenSocket::ListenSocket(ConfigTag* tag, const irc::sockets::sockaddrs& bind_to)
        : bind_tag(tag)
+       , iohookprov(NULL, std::string())
 {
        irc::sockets::satoap(bind_to, bind_addr, bind_port);
        bind_desc = bind_to.str();
@@ -55,10 +56,10 @@ ListenSocket::ListenSocket(ConfigTag* tag, const irc::sockets::sockaddrs& bind_t
        }
 #endif
 
-       ServerInstance->SE->SetReuse(fd);
-       int rv = ServerInstance->SE->Bind(this->fd, bind_to);
+       SocketEngine::SetReuse(fd);
+       int rv = SocketEngine::Bind(this->fd, bind_to);
        if (rv >= 0)
-               rv = ServerInstance->SE->Listen(this->fd, ServerInstance->Config->MaxConn);
+               rv = SocketEngine::Listen(this->fd, ServerInstance->Config->MaxConn);
 
        int timeout = tag->getInt("defer", 0);
        if (timeout && !rv)
@@ -76,15 +77,17 @@ ListenSocket::ListenSocket(ConfigTag* tag, const irc::sockets::sockaddrs& bind_t
        if (rv < 0)
        {
                int errstore = errno;
-               ServerInstance->SE->Shutdown(this, 2);
-               ServerInstance->SE->Close(this);
+               SocketEngine::Shutdown(this, 2);
+               SocketEngine::Close(this->GetFd());
                this->fd = -1;
                errno = errstore;
        }
        else
        {
-               ServerInstance->SE->NonBlocking(this->fd);
-               ServerInstance->SE->AddFd(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+               SocketEngine::NonBlocking(this->fd);
+               SocketEngine::AddFd(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+
+               this->ResetIOHookProvider();
        }
 }
 
@@ -92,12 +95,10 @@ ListenSocket::~ListenSocket()
 {
        if (this->GetFd() > -1)
        {
-               ServerInstance->SE->DelFd(this);
                ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Shut down listener on fd %d", this->fd);
-               ServerInstance->SE->Shutdown(this, 2);
-               if (ServerInstance->SE->Close(this) != 0)
+               SocketEngine::Shutdown(this, 2);
+               if (SocketEngine::Close(this) != 0)
                        ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Failed to cancel listener: %s", strerror(errno));
-               this->fd = -1;
        }
 }
 
@@ -108,7 +109,7 @@ void ListenSocket::AcceptInternal()
        irc::sockets::sockaddrs server;
 
        socklen_t length = sizeof(client);
-       int incomingSockfd = ServerInstance->SE->Accept(this, &client.sa, &length);
+       int incomingSockfd = SocketEngine::Accept(this, &client.sa, &length);
 
        ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "HandleEvent for Listensocket %s nfd=%d", bind_desc.c_str(), incomingSockfd);
        if (incomingSockfd < 0)
@@ -124,25 +125,6 @@ void ListenSocket::AcceptInternal()
                irc::sockets::aptosa(bind_addr, bind_port, server);
        }
 
-       /*
-        * XXX -
-        * this is done as a safety check to keep the file descriptors within range of fd_ref_table.
-        * its a pretty big but for the moment valid assumption:
-        * file descriptors are handed out starting at 0, and are recycled as theyre freed.
-        * therefore if there is ever an fd over 65535, 65536 clients must be connected to the
-        * irc server at once (or the irc server otherwise initiating this many connections, files etc)
-        * which for the time being is a physical impossibility (even the largest networks dont have more
-        * than about 10,000 users on ONE server!)
-        */
-       if (incomingSockfd >= ServerInstance->SE->GetMaxFds())
-       {
-               ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Server is full");
-               ServerInstance->SE->Shutdown(incomingSockfd, 2);
-               ServerInstance->SE->Close(incomingSockfd);
-               ServerInstance->stats->statsRefused++;
-               return;
-       }
-
        if (client.sa.sa_family == AF_INET6)
        {
                /*
@@ -173,7 +155,7 @@ void ListenSocket::AcceptInternal()
                }
        }
 
-       ServerInstance->SE->NonBlocking(incomingSockfd);
+       SocketEngine::NonBlocking(incomingSockfd);
 
        ModResult res;
        FIRST_MOD_RESULT(OnAcceptConnection, res, (incomingSockfd, this, &client, &server));
@@ -195,7 +177,7 @@ void ListenSocket::AcceptInternal()
                ServerInstance->stats->statsRefused++;
                ServerInstance->Logs->Log("SOCKET", LOG_DEFAULT, "Refusing connection on %s - %s",
                        bind_desc.c_str(), res == MOD_RES_DENY ? "Connection refused by module" : "Module for this port not found");
-               ServerInstance->SE->Close(incomingSockfd);
+               SocketEngine::Close(incomingSockfd);
        }
 }
 
@@ -214,3 +196,16 @@ void ListenSocket::HandleEvent(EventType e, int err)
                        break;
        }
 }
+
+bool ListenSocket::ResetIOHookProvider()
+{
+       std::string provname = bind_tag->getString("ssl");
+       if (!provname.empty())
+               provname.insert(0, "ssl/");
+
+       // Set the new provider name, dynref handles the rest
+       iohookprov.SetProvider(provname);
+
+       // Return true if no provider was set, or one was set and it was also found
+       return (provname.empty() || iohookprov);
+}