]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/mode.cpp
Added a parameter to OnRehash for the rehash parameter
[user/henk/code/inspircd.git] / src / mode.cpp
index 2258d0f57d2b3ccce8e39f17dc9bfdfdba55202b..7cc53d23016e569cb88b6d669e49c2979a45fd54 100644 (file)
  * ---------------------------------------------------
  */
 
+using namespace std;
+
+#include "inspircd_config.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
 #include "inspircd_util.h"
-#include "inspircd_config.h"
 #include <unistd.h>
-#include <fcntl.h>
 #include <sys/errno.h>
-#include <sys/ioctl.h>
-#include <sys/utsname.h>
-#include <cstdio>
 #include <time.h>
 #include <string>
 #ifdef GCC3
 #include <map>
 #include <sstream>
 #include <vector>
-#include <errno.h>
 #include <deque>
-#include <errno.h>
-#include <unistd.h>
-#include <sched.h>
 #include "connection.h"
 #include "users.h"
-#include "servers.h"
 #include "ctables.h"
 #include "globals.h"
 #include "modules.h"
@@ -51,8 +44,7 @@
 #include "commands.h"
 #include "xline.h"
 #include "inspstring.h"
-
-using namespace std;
+#include "helperfuncs.h"
 
 extern int MODCOUNT;
 extern std::vector<Module*> modules;
@@ -84,7 +76,6 @@ extern time_t TIME;
 char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -95,14 +86,14 @@ char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
        if (!isnick(dest))
        {
                log(DEFAULT,"the target nickname given to give_ops was invalid");
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        d = Find(dest);
        if (!d)
        {
                log(DEFAULT,"the target nickname given to give_ops couldnt be found");
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -124,7 +115,7 @@ char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
                }
 
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -148,7 +139,6 @@ char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
 char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -159,12 +149,12 @@ char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -183,7 +173,7 @@ char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
                        }
                }
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -205,7 +195,6 @@ char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
 char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -216,12 +205,12 @@ char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -240,7 +229,7 @@ char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
                        }
                }
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -262,7 +251,6 @@ char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
 char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -274,13 +262,13 @@ char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
        if (!isnick(dest))
        {
                log(DEBUG,"take_ops was given an invalid target nickname of %s",dest);
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
                log(DEBUG,"take_ops couldnt resolve the target nickname: %s",dest);
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -299,7 +287,7 @@ char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
                        }
                }
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -322,7 +310,6 @@ char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
 char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -333,12 +320,12 @@ char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -357,7 +344,7 @@ char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
                        }
                }
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -379,7 +366,6 @@ char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
 char* take_voice(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -390,12 +376,12 @@ char* take_voice(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -414,7 +400,7 @@ char* take_voice(userrec *user,char *dest,chanrec *chan,int status)
                        }
                }
 
-               for (int i = 0; i != MAXCHANS; i++)
+               for (unsigned int i = 0; i != MAXCHANS; i++)
                {
                        if ((d->chans[i].channel != NULL) && (chan != NULL))
                        if (!strcasecmp(d->chans[i].channel->name,chan->name))
@@ -443,31 +429,32 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
        BanItem b;
        if ((!user) || (!dest) || (!chan))
                return NULL;
+       unsigned int l = strlen(dest);
        if (strchr(dest,'!')==0)
                return NULL;
        if (strchr(dest,'@')==0)
                return NULL;
-       for (int i = 0; i < strlen(dest); i++)
+       for (unsigned int i = 0; i < l; i++)
                if (dest[i] < 32)
                        return NULL;
-       for (int i = 0; i < strlen(dest); i++)
+       for (unsigned int i = 0; i < l; i++)
                if (dest[i] > 126)
                        return NULL;
        int c = 0;
-       for (int i = 0; i < strlen(dest); i++)
+       for (unsigned int i = 0; i < l; i++)
                if (dest[i] == '!')
                        c++;
        if (c>1)
                return NULL;
        c = 0;
-       for (int i = 0; i < strlen(dest); i++)
+       for (unsigned int i = 0; i < l; i++)
                if (dest[i] == '@')
                        c++;
        if (c>1)
                return NULL;
 
        long maxbans = GetMaxBans(chan->name);
-       if (chan->bans.size() > maxbans)
+       if ((unsigned)chan->bans.size() > (unsigned)maxbans)
        {
                WriteServ(user->fd,"478 %s %s :Channel ban list for %s is full (maximum entries for this channel is %d)",user->nick, chan->name,chan->name,maxbans);
                return NULL;
@@ -475,6 +462,11 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
 
        log(DEBUG,"add_ban: %s %s",chan->name,user->nick);
 
+       int MOD_RESULT = 0;
+       FOREACH_RESULT(OnAddBan(user,chan,dest));
+       if (MOD_RESULT)
+               return NULL;
+
        TidyBan(dest);
        for (BanList::iterator i = chan->bans.begin(); i != chan->bans.end(); i++)
        {
@@ -504,6 +496,10 @@ char* take_ban(userrec *user,char *dest,chanrec *chan,int status)
        {
                if (!strcasecmp(i->data,dest))
                {
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT(OnDelBan(user,chan,dest));
+                       if (MOD_RESULT)
+                               return NULL;
                        chan->bans.erase(i);
                        return dest;
                }
@@ -511,6 +507,56 @@ char* take_ban(userrec *user,char *dest,chanrec *chan,int status)
        return NULL;
 }
 
+// tidies up redundant modes, e.g. +nt-nt+i becomes +-+i,
+// a section further down the chain tidies up the +-+- crap.
+std::string compress_modes(std::string modes,bool channelmodes)
+{
+       int counts[127];
+       bool active[127];
+       memset(counts,0,sizeof(counts));
+       memset(active,0,sizeof(active));
+       log(DEBUG,"compress_modes: %s",modes.c_str());
+       for (unsigned int i = 0; i < modes.length(); i++)
+       {
+               if ((modes[i] == '+') || (modes[i] == '-'))
+                       continue;
+               if (channelmodes)
+               {
+                       if ((strchr("itnmsp",modes[i])) || ((ModeDefined(modes[i],MT_CHANNEL)) && (ModeDefinedOn(modes[i],MT_CHANNEL)==0) && (ModeDefinedOff(modes[i],MT_CHANNEL)==0)))
+                       {
+                               log(DEBUG,"Tidy mode %c",modes[i]);
+                               counts[(unsigned int)modes[i]]++;
+                               active[(unsigned int)modes[i]] = true;
+                       }
+               }
+               else
+               {
+                       log(DEBUG,"Tidy mode %c",modes[i]);
+                       counts[(unsigned int)modes[i]]++;
+                       active[(unsigned int)modes[i]] = true;
+               }
+       }
+       for (int j = 65; j < 127; j++)
+       {
+               if ((counts[j] > 1) && (active[j] == true))
+               {
+                       static char v[2];
+                       v[0] = (unsigned char)j;
+                       v[1] = '\0';
+                       std::string mode_str = v;
+                       std::string::size_type pos = modes.find(mode_str);
+                       if (pos != std::string::npos)
+                       {
+                               log(DEBUG,"all occurances of mode %c to be deleted...",(unsigned char)j);
+                               while (modes.find(mode_str) != std::string::npos)
+                                       modes.erase(modes.find(mode_str),1);
+                               log(DEBUG,"New mode line: %s",modes.c_str());
+                       }
+               }
+       }
+       return modes;
+}
+
 void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int pcnt, bool servermode, bool silent, bool local)
 {
        if (!parameters) {
@@ -527,7 +573,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
        int ptr = 0;
        int mdir = 1;
        char* r = NULL;
-       bool k_set = false, l_set = false;
+       bool k_set = false, l_set = false, previously_set_l = false, previously_unset_l = false, previously_set_k = false, previously_unset_k = false;
 
        if (pcnt < 2)
        {
@@ -550,7 +596,13 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
        log(DEBUG,"process_modes: modelist: %s",modelist);
 
-       for (ptr = 0; ptr < strlen(modelist); ptr++)
+       std::string tidied = compress_modes(modelist,true);
+       strlcpy(modelist,tidied.c_str(),MAXBUF);
+
+       int len = strlen(modelist);
+       while (modelist[len-1] == ' ')
+               modelist[--len] = '\0';
+       for (ptr = 0; ptr < len; ptr++)
        {
                r = NULL;
 
@@ -563,9 +615,10 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                case '-':
                                        if (mdir != 0)
                                        {
-                                               if ((outlist[strlen(outlist)-1] == '+') || (outlist[strlen(outlist)-1] == '-'))
+                                               int t = strlen(outlist)-1;
+                                               if ((outlist[t] == '+') || (outlist[t] == '-'))
                                                {
-                                                       outlist[strlen(outlist)-1] = '-';
+                                                       outlist[t] = '-';
                                                }
                                                else
                                                {
@@ -579,9 +632,10 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                case '+':
                                        if (mdir != 1)
                                        {
-                                               if ((outlist[strlen(outlist)-1] == '+') || (outlist[strlen(outlist)-1] == '-'))
+                                               int t = strlen(outlist)-1;
+                                               if ((outlist[t] == '+') || (outlist[t] == '-'))
                                                {
-                                                       outlist[strlen(outlist)-1] = '+';
+                                                       outlist[t] = '+';
                                                }
                                                else
                                                {
@@ -721,6 +775,10 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        {
                                                if (k_set)
                                                        break;
+
+                                               if (previously_unset_k)
+                                                       break;
+                                               previously_set_k = true;
                                                
                                                if (!strcmp(chan->key,""))
                                                {
@@ -730,10 +788,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                        {
                                                                strcat(outlist,"k");
                                                                char key[MAXBUF];
-                                                               strlcpy(key,parameters[param++],MAXBUF);
-                                                               if (strlen(key)>32) {
-                                                                       key[31] = '\0';
-                                                               }
+                                                               strlcpy(key,parameters[param++],32);
                                                                strlcpy(outpars[pc++],key,MAXBUF);
                                                                strlcpy(chan->key,key,MAXBUF);
                                                                k_set = true;
@@ -745,16 +800,16 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        {
                                                /* checks on -k are case sensitive and only accurate to the
                                                   first 32 characters */
+                                               if (previously_set_k)
+                                                       break;
+                                               previously_unset_k = true;
+
                                                char key[MAXBUF];
                                                MOD_RESULT = 0;
                                                FOREACH_RESULT(OnRawMode(user, chan, 'k', parameters[param], false, 1));
                                                if (!MOD_RESULT)
                                                {
-                                                       strlcpy(key,parameters[param++],MAXBUF);
-                                                       if (strlen(key)>32)
-                                                       {
-                                                               key[31] = '\0';
-                                                       }
+                                                       strlcpy(key,parameters[param++],32);
                                                        /* only allow -k if correct key given */
                                                        if (!strcmp(chan->key,key))
                                                        {
@@ -770,6 +825,9 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                case 'l':
                                        if (mdir == 0)
                                        {
+                                               if (previously_set_l)
+                                                       break;
+                                               previously_unset_l = true;
                                                 MOD_RESULT = 0;
                                                 FOREACH_RESULT(OnRawMode(user, chan, 'l', "", false, 0));
                                                 if (!MOD_RESULT)
@@ -787,9 +845,11 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        {
                                                if (l_set)
                                                        break;
-                                               
+                                               if (previously_unset_l)
+                                                       break;
+                                               previously_set_l = true;
                                                bool invalid = false;
-                                               for (int i = 0; i < strlen(parameters[param]); i++)
+                                               for (unsigned int i = 0; i < strlen(parameters[param]); i++)
                                                {
                                                        if ((parameters[param][i] < '0') || (parameters[param][i] > '9'))
                                                        {
@@ -813,7 +873,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                        
                                                        // reported by mech: large values cause underflow
                                                        if (chan->limit < 0)
-                                                               chan->limit = 0x7FFFFF;
+                                                               chan->limit = 0x7FFF;
                                                }
                                                        
                                                if (chan->limit)
@@ -830,11 +890,16 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 'i', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->inviteonly != mdir)
+                                               if (mdir)
+                                               {
+                                                       if (!(chan->binarymodes & CM_INVITEONLY)) strlcat(outlist,"i",MAXBUF);
+                                                       chan->binarymodes |= CM_INVITEONLY;
+                                               }
+                                               else
                                                {
-                                                       strlcat(outlist,"i",MAXBUF);
+                                                       if (chan->binarymodes & CM_INVITEONLY) strlcat(outlist,"i",MAXBUF);
+                                                       chan->binarymodes &= ~CM_INVITEONLY;
                                                }
-                                               chan->inviteonly = mdir;
                                        }
                                break;
                                
@@ -843,11 +908,16 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 't', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->topiclock != mdir)
-                                               {
-                                                       strlcat(outlist,"t",MAXBUF);
-                                               }
-                                               chan->topiclock = mdir;
+                                               if (mdir)
+                                                {
+                                                       if (!(chan->binarymodes & CM_TOPICLOCK)) strlcat(outlist,"t",MAXBUF);
+                                                        chan->binarymodes |= CM_TOPICLOCK;
+                                                }
+                                                else
+                                                {
+                                                       if (chan->binarymodes & CM_NOEXTERNAL) strlcat(outlist,"t",MAXBUF);
+                                                        chan->binarymodes &= ~CM_TOPICLOCK;
+                                                }
                                        }
                                break;
                                
@@ -856,11 +926,16 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 'n', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->noexternal != mdir)
-                                               {
-                                                       strlcat(outlist,"n",MAXBUF);
-                                               }
-                                               chan->noexternal = mdir;
+                                                if (mdir)
+                                                {
+                                                       if (!(chan->binarymodes & CM_NOEXTERNAL)) strlcat(outlist,"n",MAXBUF);
+                                                        chan->binarymodes |= CM_NOEXTERNAL;
+                                                }
+                                                else
+                                                {
+                                                       if (chan->binarymodes & CM_NOEXTERNAL) strlcat(outlist,"n",MAXBUF);
+                                                        chan->binarymodes &= ~CM_NOEXTERNAL;
+                                                }
                                        }
                                break;
                                
@@ -869,11 +944,16 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 'm', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->moderated != mdir)
-                                               {
-                                                       strlcat(outlist,"m",MAXBUF);
-                                               }
-                                               chan->moderated = mdir;
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_MODERATED)) strlcat(outlist,"m",MAXBUF);
+                                                        chan->binarymodes |= CM_MODERATED;
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_MODERATED) strlcat(outlist,"m",MAXBUF);
+                                                        chan->binarymodes &= ~CM_MODERATED;
+                                                }
                                        }
                                break;
                                
@@ -882,23 +962,24 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 's', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->secret != mdir)
-                                               {
-                                                       strcat(outlist,"s");
-                                                       if (chan->c_private)
-                                                       {
-                                                               chan->c_private = 0;
-                                                               if (mdir)
-                                                               {
-                                                                       strlcat(outlist,"-p+",MAXBUF);
-                                                               }
-                                                               else
-                                                               {
-                                                                       strlcat(outlist,"+p-",MAXBUF);
-                                                               }
-                                                       }
-                                               }
-                                               chan->secret = mdir;
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_SECRET)) strlcat(outlist,"s",MAXBUF);
+                                                        chan->binarymodes |= CM_SECRET;
+                                                        if (chan->binarymodes & CM_PRIVATE)
+                                                        {
+                                                                chan->binarymodes &= ~CM_PRIVATE;
+                                                                if (mdir)
+                                                                {
+                                                                        strlcat(outlist,"-p+",MAXBUF);
+                                                                }
+                                                        }
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_SECRET) strlcat(outlist,"s",MAXBUF);
+                                                        chan->binarymodes &= ~CM_SECRET;
+                                                }
                                        }
                                break;
                                
@@ -907,23 +988,24 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                         FOREACH_RESULT(OnRawMode(user, chan, 'p', "", mdir, 0));
                                         if (!MOD_RESULT)
                                         {
-                                               if (chan->c_private != mdir)
-                                               {
-                                                       strlcat(outlist,"p",MAXBUF);
-                                                       if (chan->secret)
-                                                       {
-                                                               chan->secret = 0;
-                                                               if (mdir)
-                                                               {
-                                                                       strlcat(outlist,"-s+",MAXBUF);
-                                                               }
-                                                               else
-                                                               {
-                                                                       strlcat(outlist,"+s-",MAXBUF);
-                                                               }
-                                                       }
-                                               }
-                                               chan->c_private = mdir;
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_PRIVATE)) strlcat(outlist,"p",MAXBUF);
+                                                        chan->binarymodes |= CM_PRIVATE;
+                                                        if (chan->binarymodes & CM_SECRET)
+                                                        {
+                                                                chan->binarymodes &= ~CM_SECRET;
+                                                                if (mdir)
+                                                                {
+                                                                        strlcat(outlist,"-s+",MAXBUF);
+                                                                }
+                                                        }
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_PRIVATE) strlcat(outlist,"p",MAXBUF);
+                                                        chan->binarymodes &= ~CM_PRIVATE;
+                                                }
                                        }
                                break;
                                
@@ -989,7 +1071,8 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                                                {
                                                                                        if (t == -1)
                                                                                        {
-                                                                                               pc++;
+                                                                                               //pc++;
+                                                                                               param++;
                                                                                        }
                                                                                        else
                                                                                        {
@@ -1039,11 +1122,13 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
        }
 
        /* this ensures only the *valid* modes are sent out onto the network */
-       while ((outlist[strlen(outlist)-1] == '-') || (outlist[strlen(outlist)-1] == '+'))
+       int xt = strlen(outlist)-1;
+       while ((outlist[xt] == '-') || (outlist[xt] == '+'))
        {
-               outlist[strlen(outlist)-1] = '\0';
+               outlist[xt] = '\0';
+               xt = strlen(outlist)-1;
        }
-       if (strcmp(outlist,""))
+       if (outlist[0])
        {
                strlcpy(outstr,outlist,MAXBUF);
                for (ptr = 0; ptr < pc; ptr++)
@@ -1055,6 +1140,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                {
                        log(DEBUG,"Local mode change");
                        WriteChannelLocal(chan, user, "MODE %s %s",chan->name,outstr);
+                       FOREACH_MOD OnMode(user, chan, TYPE_CHANNEL, outstr);
                }
                else
                {
@@ -1062,11 +1148,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                        {
                                if (!silent)
                                {
-                                       WriteChannelWithServ(ServerName,chan,user,"MODE %s %s",chan->name,outstr);
-                                       // M token for a usermode must go to all servers
-                                       char buffer[MAXBUF];
-                                       snprintf(buffer,MAXBUF,"M %s %s",chan->name, outstr);
-                                       NetSendToAll(buffer);
+                                       WriteChannelWithServ(ServerName,chan,"MODE %s %s",chan->name,outstr);
                                }
                                        
                        }
@@ -1075,10 +1157,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                if (!silent)
                                {
                                        WriteChannel(chan,user,"MODE %s %s",chan->name,outstr);
-                                       // M token for a usermode must go to all servers
-                                       char buffer[MAXBUF];
-                                       snprintf(buffer,MAXBUF,"m %s %s %s",user->nick,chan->name, outstr);
-                                       NetSendToAll(buffer);
+                                       FOREACH_MOD OnMode(user, chan, TYPE_CHANNEL, outstr);
                                }
                        }
                }
@@ -1087,9 +1166,14 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
 // based on sourcemodes, return true or false to determine if umode is a valid mode a user may set on themselves or others.
 
-bool allowed_umode(char umode, char* sourcemodes,bool adding)
+bool allowed_umode(char umode, char* sourcemodes,bool adding,bool serveroverride)
 {
        log(DEBUG,"Allowed_umode: %c %s",umode,sourcemodes);
+       // Servers can +o and -o arbitrarily
+       if ((serveroverride == true) && (umode == 'o'))
+       {
+               return true;
+       }
        // RFC1459 specified modes
        if ((umode == 'w') || (umode == 's') || (umode == 'i'))
        {
@@ -1141,7 +1225,7 @@ bool process_module_umode(char umode, userrec* source, void* dest, bool adding)
        {
                s2 = new userrec;
                strlcpy(s2->nick,ServerName,NICKMAX);
-               strcpy(s2->modes,"o");
+               strlcpy(s2->modes,"o",52);
                s2->fd = -1;
                source = s2;
                faked = true;
@@ -1181,7 +1265,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1200,10 +1284,13 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 
        if ((dest) && (pcnt > 1))
        {
+               std::string tidied = compress_modes(parameters[1],false);
+               parameters[1] = (char*)tidied.c_str();
+
                char dmodes[MAXBUF];
-               strlcpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
                log(DEBUG,"pulled up dest user modes: %s",dmodes);
-       
+
                can_change = 0;
                if (user != dest)
                {
@@ -1228,15 +1315,18 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
                        return;
 
-               for (int i = 0; i < strlen(parameters[1]); i++)
+               for (unsigned int i = 0; i < strlen(parameters[1]); i++)
                {
+                       if (parameters[1][i] == ' ')
+                               continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1250,9 +1340,10 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1270,7 +1361,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                }
                                else
                                {
-                                       if ((parameters[1][i] == 'i') || (parameters[1][i] == 'w') || (parameters[1][i] == 's') || (allowed_umode(parameters[1][i],user->modes,direction)))
+                                       if ((parameters[1][i] == 'i') || (parameters[1][i] == 'w') || (parameters[1][i] == 's') || (allowed_umode(parameters[1][i],user->modes,direction,false)))
                                        {
                                                can_change = 1;
                                        }
@@ -1279,31 +1370,38 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                {
                                        if (direction == 1)
                                        {
-                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true)))
+                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true,false)))
                                                {
                                                        char umode = parameters[1][i];
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int q = strlen(dmodes);
+                                                               int r = strlen(outpars);
+                                                               dmodes[q+1]='\0';
+                                                               dmodes[q] = parameters[1][i];
+                                                               outpars[r+1]='\0';
+                                                               outpars[r] = parameters[1][i];
+                                                               if (parameters[1][i] == 'o')
+                                                               {
+                                                                       FOREACH_MOD OnGlobalOper(dest);
+                                                               }
                                                        }
                                                }
                                        }
                                        else
                                        {
-                                               if ((allowed_umode(parameters[1][i],user->modes,false)) && (strchr(dmodes,parameters[1][i])))
+                                               if ((allowed_umode(parameters[1][i],user->modes,false,false)) && (strchr(dmodes,parameters[1][i])))
                                                {
                                                        char umode = parameters[1][i];
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               int q = 0;
+                                                               unsigned int q = 0;
                                                                char temp[MAXBUF];      
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               unsigned int r = strlen(outpars);
+                                                               outpars[r+1]='\0';
+                                                               outpars[r] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1315,19 +1413,22 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                                                                strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strlcpy(dmodes,temp,MAXBUF);
+                                                               strlcpy(dmodes,temp,52);
+
+                                                               if (umode == 'o')
+                                                                       DeleteOper(dest);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strlcpy(b,"",MAXBUF);
-                       int z = 0;
-                       int i = 0;
+                       unsigned int z = 0;
+                       unsigned int i = 0;
                        while (i < strlen (outpars))
                        {
                                b[z++] = outpars[i++];
@@ -1352,17 +1453,16 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
+                       if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
 
-                       WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
-
-                       // M token for a usermode must go to all servers
-                       char buffer[MAXBUF];
-                       snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
-                       NetSendToAll(buffer);
+                       if (strcmp(b,""))
+                       {
+                               WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
+                               FOREACH_MOD OnMode(user, dest, TYPE_USER, b);
+                       }
 
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1370,7 +1470,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strlcpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,52);
 
                }
 
@@ -1384,6 +1484,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                {
                        /* just /modes #channel */
                        WriteServ(user->fd,"324 %s %s +%s",user->nick, Ptr->name, chanmodes(Ptr));
+                        WriteServ(user->fd,"329 %s %s %d", user->nick, Ptr->name, Ptr->created);
                        return;
                }
                else
@@ -1443,7 +1544,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
        }
        else
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, parameters[0]);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, parameters[0]);
        }
 }
 
@@ -1454,7 +1555,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1468,10 +1569,11 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strlcpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1479,15 +1581,18 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
                        return;
 
-               for (int i = 0; i < strlen(parameters[1]); i++)
+               for (unsigned int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1501,9 +1606,10 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1521,16 +1627,18 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                        if (direction == 1)
                                        {
                                                log(DEBUG,"umode %c being added",parameters[1][i]);
-                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true)))
+                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true,true)))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
                                                        }
                                                }
                                        }
@@ -1538,18 +1646,19 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                        {
                                                // can only remove a mode they already have
                                                log(DEBUG,"umode %c being removed",parameters[1][i]);
-                                               if ((allowed_umode(parameters[1][i],user->modes,false)) && (strchr(dmodes,parameters[1][i])))
+                                               if ((allowed_umode(parameters[1][i],user->modes,false,true)) && (strchr(dmodes,parameters[1][i])))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               int q = 0;
+                                                               unsigned int q = 0;
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               unsigned int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1561,19 +1670,19 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                                                                strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strlcpy(dmodes,temp,MAXBUF);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strlcpy(b,"",MAXBUF);
-                       int z = 0;
-                       int i = 0;
+                       unsigned int z = 0;
+                       unsigned int i = 0;
                        while (i < strlen (outpars))
                        {
                                b[z++] = outpars[i++];
@@ -1598,17 +1707,16 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
+                       if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
 
-                       WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
-
-                       // M token for a usermode must go to all servers
-                       char buffer[MAXBUF];
-                       snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
-                       NetSendToAll(buffer);
+                       if (strcmp(b,""))
+                       {
+                               WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
+                               FOREACH_MOD OnMode(user, dest, TYPE_USER, b);
+                       }
                        
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1630,7 +1738,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
        }
        else
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, parameters[0]);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, parameters[0]);
        }
 }
 
@@ -1640,7 +1748,7 @@ void merge_mode(char **parameters, int pcnt)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1654,10 +1762,11 @@ void merge_mode(char **parameters, int pcnt)
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strlcpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1665,15 +1774,18 @@ void merge_mode(char **parameters, int pcnt)
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
                        return;
 
-               for (int i = 0; i < strlen(parameters[1]); i++)
+               for (unsigned int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1687,9 +1799,10 @@ void merge_mode(char **parameters, int pcnt)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1707,16 +1820,18 @@ void merge_mode(char **parameters, int pcnt)
                                        if (direction == 1)
                                        {
                                                log(DEBUG,"umode %c being added",parameters[1][i]);
-                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],"o",true)))
+                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],"o",true,true)))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
                                                        }
                                                }
                                        }
@@ -1724,18 +1839,19 @@ void merge_mode(char **parameters, int pcnt)
                                        {
                                                // can only remove a mode they already have
                                                log(DEBUG,"umode %c being removed",parameters[1][i]);
-                                               if ((allowed_umode(parameters[1][i],"o",false)) && (strchr(dmodes,parameters[1][i])))
+                                               if ((allowed_umode(parameters[1][i],"o",false,true)) && (strchr(dmodes,parameters[1][i])))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               int q = 0;
+                                                               unsigned int q = 0;
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               unsigned int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1747,19 +1863,19 @@ void merge_mode(char **parameters, int pcnt)
                                                                                strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strlcpy(dmodes,temp,MAXBUF);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strcpy(b,"");
-                       int z = 0;
-                       int i = 0;
+                       unsigned int z = 0;
+                       unsigned int i = 0;
                        while (i < strlen (outpars))
                        {
                                b[z++] = outpars[i++];
@@ -1784,7 +1900,7 @@ void merge_mode(char **parameters, int pcnt)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
                        if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
@@ -1818,7 +1934,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1827,15 +1943,16 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
        // fix: ChroNiCk found this - we cant use this as debug if its null!
        if (dest)
        {
-               log(DEBUG,"merge_mode on %s",dest->nick);
+               log(DEBUG,"merge_mode2 on %s",dest->nick);
        }
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strlcpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1848,15 +1965,18 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
                return;
 
-               for (int i = 0; i < strlen(parameters[1]); i++)
+               for (unsigned int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1870,9 +1990,10 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1890,16 +2011,18 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                        if (direction == 1)
                                        {
                                                log(DEBUG,"umode %c being added",parameters[1][i]);
-                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true)))
+                                               if ((!strchr(dmodes,parameters[1][i])) && (allowed_umode(parameters[1][i],user->modes,true,false)))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
                                                                log(DEBUG,"OUTPARS='%s', DMODES='%s'",outpars,dmodes);
                                                        }
                                                }
@@ -1908,18 +2031,19 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                        {
                                                // can only remove a mode they already have
                                                log(DEBUG,"umode %c being removed",parameters[1][i]);
-                                               if ((allowed_umode(parameters[1][i],user->modes,false)) && (strchr(dmodes,parameters[1][i])))
+                                               if ((allowed_umode(parameters[1][i],user->modes,false,false)) && (strchr(dmodes,parameters[1][i])))
                                                {
                                                        char umode = parameters[1][i];
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               int q = 0;
+                                                               unsigned int q = 0;
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               unsigned int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1931,7 +2055,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                                                strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strlcpy(dmodes,temp,MAXBUF);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
@@ -1939,12 +2063,12 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        }
                }
                log(DEBUG,"DONE! OUTPARS='%s', DMODES='%s'",outpars,dmodes);
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strcpy(b,"");
-                       int z = 0;
-                       int i = 0;
+                       unsigned int z = 0;
+                       unsigned int i = 0;
                        while (i < strlen (outpars))
                        {
                                b[z++] = outpars[i++];
@@ -1969,14 +2093,17 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
-                               return;
 
-                       // was sending 'b'
-                       WriteTo(user,dest,"MODE %s :%s",dest->nick,b);
-                       log(DEBUG,"Sent: :%s MODE %s",user->nick,b);
+                        if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
+                                return;
+
+                        if (strcmp(b,""))
+                        {
+                               WriteTo(user,dest,"MODE %s :%s",dest->nick,b);
+                               FOREACH_MOD OnMode(user, dest, TYPE_USER, b);
+                       }
 
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1985,7 +2112,6 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
                        strlcpy(dest->modes,dmodes,MAXMODES);
-
                }
 
                return;
@@ -1997,10 +2123,10 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                log(DEBUG,"merge_mode2: found channel %s",Ptr->name);
                if (Ptr)
                {
-                       if ((cstatus(user,Ptr) < STATUS_HOP) && (!is_uline(user->server)))
-                       {
-                               return;
-                       }
+                       //if ((cstatus(user,Ptr) < STATUS_HOP) && (!is_uline(user->server)))
+                       //{
+                       //      return;
+                       //}
                        process_modes(parameters,user,Ptr,cstatus(user,Ptr),pcnt,false,false,true);
                }
        }