]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/mode.cpp
Services speedups for stupid buffered i/o uplinks
[user/henk/code/inspircd.git] / src / mode.cpp
index e7ed4badf90ff54eedaa1909f867b148caa91be0..aab5a403a1f611311688f988335e50d70dc762cf 100644 (file)
@@ -1,3 +1,19 @@
+/*       +------------------------------------+
+ *       | Inspire Internet Relay Chat Daemon |
+ *       +------------------------------------+
+ *
+ *  Inspire is copyright (C) 2002-2004 ChatSpike-Dev.
+ *                       E-mail:
+ *                <brain@chatspike.net>
+ *               <Craig@chatspike.net>
+ *     
+ * Written by Craig Edwards, Craig McLure, and others.
+ * This program is free but copyrighted software; see
+ *            the file COPYING for details.
+ *
+ * ---------------------------------------------------
+ */
+
 #include "inspircd.h"
 #include "inspircd_io.h"
 #include "inspircd_util.h"
 #include "message.h"
 #include "commands.h"
 #include "xline.h"
+#include "inspstring.h"
 
 using namespace std;
 
 extern int MODCOUNT;
-extern vector<Module*> modules;
-extern vector<ircd_module*> factory;
+extern std::vector<Module*> modules;
+extern std::vector<ircd_module*> factory;
+extern std::vector<std::string> module_names;
+
 
 extern int LogLevel;
 extern char ServerName[MAXBUF];
@@ -60,6 +79,7 @@ extern bool AllowHalfop;
 extern bool AllowProtect;
 extern bool AllowFounder;
 
+extern time_t TIME;
 
 char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
 {
@@ -445,6 +465,14 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
                        c++;
        if (c>1)
                return NULL;
+
+       long maxbans = GetMaxBans(chan->name);
+       if (chan->bans.size() > maxbans)
+       {
+               WriteServ(user->fd,"478 %s %s :Channel ban list for %s is full (maximum entries for this channel is %d)",user->nick, chan->name,chan->name,maxbans);
+               return NULL;
+       }
+
        log(DEBUG,"add_ban: %s %s",chan->name,user->nick);
 
        TidyBan(dest);
@@ -457,7 +485,7 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
                }
        }
 
-       b.set_time = time(NULL);
+       b.set_time = TIME;
        strncpy(b.data,dest,MAXBUF);
        strncpy(b.set_by,user->nick,NICKMAX);
        chan->bans.push_back(b);
@@ -514,10 +542,10 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
        log(DEBUG,"process_modes: start: parameters=%d",pcnt);
 
-       strcpy(modelist,parameters[1]); /* mode list, e.g. +oo-o */
-                                       /* parameters[2] onwards are parameters for
-                                        * modes that require them :) */
-       strcpy(outlist,"+");
+       strlcpy(modelist,parameters[1],MAXBUF); /* mode list, e.g. +oo-o *
+                                                * parameters[2] onwards are parameters for
+                                                * modes that require them :) */
+       strlcpy(outlist,"+",MAXBUF);
        mdir = 1;
 
        log(DEBUG,"process_modes: modelist: %s",modelist);
@@ -528,6 +556,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
                {
                        log(DEBUG,"process_modes: modechar: %c",modelist[ptr]);
+
                        char modechar = modelist[ptr];
                        switch (modelist[ptr])
                        {
@@ -568,18 +597,30 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        log(DEBUG,"Enough parameters left");
                                        if (mdir == 1)
                                        {
-                                               log(DEBUG,"calling give_ops");
-                                               r = give_ops(user,parameters[param++],chan,status);
+                                               MOD_RESULT = 0;
+                                               FOREACH_RESULT(OnRawMode(user, chan, 'o', parameters[param], true, 1));
+                                               if (!MOD_RESULT)
+                                               {
+                                                       log(DEBUG,"calling give_ops");
+                                                       r = give_ops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               log(DEBUG,"calling take_ops");
-                                               r = take_ops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'o', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       log(DEBUG,"calling take_ops");
+                                                       r = take_ops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"o");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"o",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                        
@@ -587,16 +628,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if (((param >= pcnt)) || (!AllowHalfop)) break;
                                        if (mdir == 1)
                                        {
-                                               r = give_hops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'h', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = give_hops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_hops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'h', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_hops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"h");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"h",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                        
@@ -605,16 +658,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if ((param >= pcnt)) break;
                                        if (mdir == 1)
                                        {
-                                               r = give_voice(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'v', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = give_voice(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_voice(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'v', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_voice(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"v");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"v",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                                
@@ -622,16 +687,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if ((param >= pcnt)) break;
                                        if (mdir == 1)
                                        {
-                                               r = add_ban(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'b', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = add_ban(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_ban(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'b', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_ban(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"b");
-                                               strcpy(outpars[pc++],parameters[param-1]);
+                                               strlcat(outlist,"b",MAXBUF);
+                                               strlcpy(outpars[pc++],parameters[param-1],MAXBUF);
                                        }
                                break;
 
@@ -647,15 +724,21 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                
                                                if (!strcmp(chan->key,""))
                                                {
-                                                       strcat(outlist,"k");
-                                                       char key[MAXBUF];
-                                                       strcpy(key,parameters[param++]);
-                                                       if (strlen(key)>32) {
-                                                               key[31] = '\0';
+                                                       MOD_RESULT = 0;
+                                                       FOREACH_RESULT(OnRawMode(user, chan, 'k', parameters[param], true, 1));
+                                                       if (!MOD_RESULT)
+                                                       {
+                                                               strcat(outlist,"k");
+                                                               char key[MAXBUF];
+                                                               strlcpy(key,parameters[param++],MAXBUF);
+                                                               if (strlen(key)>32) {
+                                                                       key[31] = '\0';
+                                                               }
+                                                               strlcpy(outpars[pc++],key,MAXBUF);
+                                                               strlcpy(chan->key,key,MAXBUF);
+                                                               k_set = true;
                                                        }
-                                                       strcpy(outpars[pc++],key);
-                                                       strcpy(chan->key,key);
-                                                       k_set = true;
+                                                       else param++;
                                                }
                                        }
                                        else
@@ -663,27 +746,39 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                /* checks on -k are case sensitive and only accurate to the
                                                   first 32 characters */
                                                char key[MAXBUF];
-                                               strcpy(key,parameters[param++]);
-                                               if (strlen(key)>32) {
-                                                       key[31] = '\0';
-                                               }
-                                               /* only allow -k if correct key given */
-                                               if (!strcmp(chan->key,key))
+                                               MOD_RESULT = 0;
+                                               FOREACH_RESULT(OnRawMode(user, chan, 'k', parameters[param], false, 1));
+                                               if (!MOD_RESULT)
                                                {
-                                                       strcat(outlist,"k");
-                                                       strcpy(chan->key,"");
-                                                       strcpy(outpars[pc++],key);
+                                                       strlcpy(key,parameters[param++],MAXBUF);
+                                                       if (strlen(key)>32)
+                                                       {
+                                                               key[31] = '\0';
+                                                       }
+                                                       /* only allow -k if correct key given */
+                                                       if (!strcmp(chan->key,key))
+                                                       {
+                                                               strlcat(outlist,"k",MAXBUF);
+                                                               strlcpy(chan->key,"",MAXBUF);
+                                                               strlcpy(outpars[pc++],key,MAXBUF);
+                                                       }
                                                }
+                                               else param++;
                                        }
                                break;
                                
                                case 'l':
                                        if (mdir == 0)
                                        {
-                                               if (chan->limit)
-                                               {
-                                                       strcat(outlist,"l");
-                                                       chan->limit = 0;
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'l', "", false, 0));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       if (chan->limit)
+                                                       {
+                                                               strcat(outlist,"l");
+                                                               chan->limit = 0;
+                                                       }
                                                }
                                        }
                                        
@@ -708,96 +803,132 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
                                                if (invalid)
                                                        break;
-                                               
-                                               chan->limit = atoi(parameters[param]);
-                                               
-                                               // reported by mech: large values cause underflow
-                                               if (chan->limit < 0)
-                                                       chan->limit = 0x7FFFFF;
+
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'l', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+       
+                                                       chan->limit = atoi(parameters[param]);
+                                                       
+                                                       // reported by mech: large values cause underflow
+                                                       if (chan->limit < 0)
+                                                               chan->limit = 0x7FFFFF;
+                                               }
                                                        
                                                if (chan->limit)
                                                {
-                                                       strcat(outlist,"l");
-                                                       strcpy(outpars[pc++],parameters[param++]);
+                                                       strlcat(outlist,"l",MAXBUF);
+                                                       strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                        l_set = true;
                                                }
                                        }
                                break;
                                
                                case 'i':
-                                       if (chan->inviteonly != mdir)
-                                       {
-                                               strcat(outlist,"i");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'i', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->inviteonly != mdir)
+                                               {
+                                                       strlcat(outlist,"i",MAXBUF);
+                                               }
+                                               chan->inviteonly = mdir;
                                        }
-                                       chan->inviteonly = mdir;
                                break;
                                
                                case 't':
-                                       if (chan->topiclock != mdir)
-                                       {
-                                               strcat(outlist,"t");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 't', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->topiclock != mdir)
+                                               {
+                                                       strlcat(outlist,"t",MAXBUF);
+                                               }
+                                               chan->topiclock = mdir;
                                        }
-                                       chan->topiclock = mdir;
                                break;
                                
                                case 'n':
-                                       if (chan->noexternal != mdir)
-                                       {
-                                               strcat(outlist,"n");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'n', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->noexternal != mdir)
+                                               {
+                                                       strlcat(outlist,"n",MAXBUF);
+                                               }
+                                               chan->noexternal = mdir;
                                        }
-                                       chan->noexternal = mdir;
                                break;
                                
                                case 'm':
-                                       if (chan->moderated != mdir)
-                                       {
-                                               strcat(outlist,"m");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'm', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->moderated != mdir)
+                                               {
+                                                       strlcat(outlist,"m",MAXBUF);
+                                               }
+                                               chan->moderated = mdir;
                                        }
-                                       chan->moderated = mdir;
                                break;
                                
                                case 's':
-                                       if (chan->secret != mdir)
-                                       {
-                                               strcat(outlist,"s");
-                                               if (chan->c_private)
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 's', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->secret != mdir)
                                                {
-                                                       chan->c_private = 0;
-                                                       if (mdir)
-                                                       {
-                                                               strcat(outlist,"-p+");
-                                                       }
-                                                       else
+                                                       strcat(outlist,"s");
+                                                       if (chan->c_private)
                                                        {
-                                                               strcat(outlist,"+p-");
+                                                               chan->c_private = 0;
+                                                               if (mdir)
+                                                               {
+                                                                       strlcat(outlist,"-p+",MAXBUF);
+                                                               }
+                                                               else
+                                                               {
+                                                                       strlcat(outlist,"+p-",MAXBUF);
+                                                               }
                                                        }
                                                }
+                                               chan->secret = mdir;
                                        }
-                                       chan->secret = mdir;
                                break;
                                
                                case 'p':
-                                       if (chan->c_private != mdir)
-                                       {
-                                               strcat(outlist,"p");
-                                               if (chan->secret)
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'p', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (chan->c_private != mdir)
                                                {
-                                                       chan->secret = 0;
-                                                       if (mdir)
-                                                       {
-                                                               strcat(outlist,"-s+");
-                                                       }
-                                                       else
+                                                       strlcat(outlist,"p",MAXBUF);
+                                                       if (chan->secret)
                                                        {
-                                                               strcat(outlist,"+s-");
+                                                               chan->secret = 0;
+                                                               if (mdir)
+                                                               {
+                                                                       strlcat(outlist,"-s+",MAXBUF);
+                                                               }
+                                                               else
+                                                               {
+                                                                       strlcat(outlist,"+s-",MAXBUF);
+                                                               }
                                                        }
                                                }
+                                               chan->c_private = mdir;
                                        }
-                                       chan->c_private = mdir;
                                break;
                                
                                default:
-                                       log(DEBUG,"Preprocessing custom mode %c",modechar);
+                                       log(DEBUG,"Preprocessing custom mode %c: modelist: %s",modechar,chan->custom_modes);
                                        string_list p;
                                        p.clear();
                                        if (((!strchr(chan->custom_modes,modechar)) && (!mdir)) || ((strchr(chan->custom_modes,modechar)) && (mdir)))
@@ -825,65 +956,82 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                bool handled = false;
                                                if (param>=pcnt)
                                                {
-                                                       log(DEBUG,"Not enough parameters for module-mode %c",modechar);
                                                        // we're supposed to have a parameter, but none was given... so dont handle the mode.
                                                        if (((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir)) || ((ModeDefinedOff(modechar,MT_CHANNEL)>0) && (!mdir))) 
                                                        {
+                                                               log(DEBUG,"Not enough parameters for module-mode %c",modechar);
                                                                handled = true;
                                                                param++;
                                                        }
                                                }
-                                               for (int i = 0; i <= MODCOUNT; i++)
-                                               {
-                                                       if (!handled)
+
+                                               // BIG ASS IDIOTIC CODER WARNING!
+                                               // Using OnRawMode on another modules mode's behavour 
+                                               // will confuse the crap out of admins! just because you CAN
+                                               // do it, doesnt mean you SHOULD!
+                                               MOD_RESULT = 0;
+                                               std::string para = "";
+                                               if (p.size())
+                                                       para = p[0];
+                                               FOREACH_RESULT(OnRawMode(user, chan, modechar, para, mdir, pcnt));
+                                               if (!MOD_RESULT)
+                                               {
+                                                       for (int i = 0; i <= MODCOUNT; i++)
                                                        {
-                                                               int t = modules[i]->OnExtendedMode(user,chan,modechar,MT_CHANNEL,mdir,p);
-                                                               if (t != 0)
+                                                               if (!handled)
                                                                {
-                                                                       log(DEBUG,"OnExtendedMode returned nonzero for a module");
-                                                                       char app[] = {modechar, 0};
-                                                                       if (ModeIsListMode(modechar,MT_CHANNEL))
+                                                                       int t = modules[i]->OnExtendedMode(user,chan,modechar,MT_CHANNEL,mdir,p);
+                                                                       if (t != 0)
                                                                        {
-                                                                               if (t == -1)
+                                                                               log(DEBUG,"OnExtendedMode returned nonzero for a module");
+                                                                               char app[] = {modechar, 0};
+                                                                               if (ModeIsListMode(modechar,MT_CHANNEL))
                                                                                {
-                                                                                       pc++;
-                                                                               }
-                                                                               else
-                                                                               {
-                                                                                       if (ptr>0)
+                                                                                       if (t == -1)
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               pc++;
+                                                                                       }
+                                                                                       else
+                                                                                       {
+                                                                                               if (ptr>0)
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
+                                                                                               strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                                                        }
-                                                                                       strcpy(outpars[pc++],parameters[param++]);
                                                                                }
-                                                                       }
-                                                                       else
-                                                                       {
-                                                                               if (ptr>0)
+                                                                               else
                                                                                {
-                                                                                       if ((modelist[ptr-1] == '+') || (modelist[ptr-1] == '-'))
+                                                                                       if (ptr>0)
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               if ((modelist[ptr-1] == '+') || (modelist[ptr-1] == '-'))
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
+                                                                                               else if (!strchr(outlist,modechar))
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
                                                                                        }
-                                                                                       else if (!strchr(outlist,modechar))
+                                                                                       chan->SetCustomMode(modechar,mdir);
+                                                                                       // include parameters in output if mode has them
+                                                                                       if ((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir))
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               chan->SetCustomModeParam(modelist[ptr],parameters[param],mdir);
+                                                                                               strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                                                        }
                                                                                }
-                                                                               chan->SetCustomMode(modechar,mdir);
-                                                                               // include parameters in output if mode has them
-                                                                               if ((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir))
-                                                                               {
-                                                                                       chan->SetCustomModeParam(modelist[ptr],parameters[param],mdir);
-                                                                                       strcpy(outpars[pc++],parameters[param++]);
-                                                                               }
-                                                                       }
-                                                                       // break, because only one module can handle the mode.
-                                                                       handled = true;
-                                                               }
-                                                       }
-                                               }
+                                                                               // break, because only one module can handle the mode.
+                                                                               handled = true;
+                                                                               }
+                                                                       }
+                                                       }
+                                               }
                                        }
+                                       else
+                                       {
+                                               WriteServ(user->fd,"472 %s %c :is unknown mode char to me",user->nick,modechar);
+                                       }
                                break;
                                
                        }
@@ -897,11 +1045,11 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
        }
        if (strcmp(outlist,""))
        {
-               strcpy(outstr,outlist);
+               strlcpy(outstr,outlist,MAXBUF);
                for (ptr = 0; ptr < pc; ptr++)
                {
-                       strcat(outstr," ");
-                       strcat(outstr,outpars[ptr]);
+                       strlcat(outstr," ",MAXBUF);
+                       strlcat(outstr,outpars[ptr],MAXBUF);
                }
                if (local)
                {
@@ -992,7 +1140,7 @@ bool process_module_umode(char umode, userrec* source, void* dest, bool adding)
        if (!source)
        {
                s2 = new userrec;
-               strncpy(s2->nick,ServerName,NICKMAX);
+               strlcpy(s2->nick,ServerName,NICKMAX);
                strcpy(s2->modes,"o");
                s2->fd = -1;
                source = s2;
@@ -1006,7 +1154,7 @@ bool process_module_umode(char umode, userrec* source, void* dest, bool adding)
                {
                        if (modules[i]->OnExtendedMode(source,(void*)dest,umode,MT_CLIENT,adding,p))
                        {
-                               log(DEBUG,"Module claims umode %c",umode);
+                               log(DEBUG,"Module %s claims umode %c",module_names[i].c_str(),umode);
                                return true;
                        }
                }
@@ -1053,7 +1201,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
        if ((dest) && (pcnt > 1))
        {
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,MAXBUF);
                log(DEBUG,"pulled up dest user modes: %s",dmodes);
        
                can_change = 0;
@@ -1164,10 +1312,10 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,MAXBUF);
                                                        }
                                                }
                                        }
@@ -1177,7 +1325,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                if (strlen(outpars))
                {
                        char b[MAXBUF];
-                       strcpy(b,"");
+                       strlcpy(b,"",MAXBUF);
                        int z = 0;
                        int i = 0;
                        while (i < strlen (outpars))
@@ -1222,7 +1370,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }
 
@@ -1236,39 +1384,63 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                {
                        /* just /modes #channel */
                        WriteServ(user->fd,"324 %s %s +%s",user->nick, Ptr->name, chanmodes(Ptr));
-                       WriteServ(user->fd,"329 %s %s %d", user->nick, Ptr->name, Ptr->created);
+                        WriteServ(user->fd,"329 %s %s %d", user->nick, Ptr->name, Ptr->created);
                        return;
                }
                else
                if (pcnt == 2)
                {
-                       if ((!strcmp(parameters[1],"+b")) || (!strcmp(parameters[1],"b")))
-                       {
+                       char* mode = parameters[1];
+                       if (*mode == '+')
+                               mode++;
+                       int MOD_RESULT = 0;
+                        FOREACH_RESULT(OnRawMode(user, Ptr, *mode, "", false, 0));
+                        if (!MOD_RESULT)
+                        {
+                               if (*mode == 'b')
+                               {
 
-                               for (BanList::iterator i = Ptr->bans.begin(); i != Ptr->bans.end(); i++)
+                                       for (BanList::iterator i = Ptr->bans.begin(); i != Ptr->bans.end(); i++)
+                                       {
+                                               WriteServ(user->fd,"367 %s %s %s %s %d",user->nick, Ptr->name, i->data, i->set_by, i->set_time);
+                                       }
+                                       WriteServ(user->fd,"368 %s %s :End of channel ban list",user->nick, Ptr->name);
+                                       return;
+                               }
+                               if ((ModeDefined(*mode,MT_CHANNEL)) && (ModeIsListMode(*mode,MT_CHANNEL)))
                                {
-                                       WriteServ(user->fd,"367 %s %s %s %s %d",user->nick, Ptr->name, i->data, i->set_by, i->set_time);
+                                       // list of items for an extmode
+                                       log(DEBUG,"Calling OnSendList for all modules, list output for mode %c",*mode);
+                                       FOREACH_MOD OnSendList(user,Ptr,*mode);
+                                       return;
                                }
-                               WriteServ(user->fd,"368 %s %s :End of channel ban list",user->nick, Ptr->name);
-                               return;
                        }
                }
 
-               int MOD_RESULT = 0;
-               FOREACH_RESULT(OnAccessCheck(user,NULL,Ptr,AC_GENERAL_MODE));
-               
-               if (MOD_RESULT == ACR_DENY)
-                       return;
-               if (MOD_RESULT == ACR_DEFAULT)
+                if ((Ptr) && (!has_channel(user,Ptr)))
+                {
+                        WriteServ(user->fd,"442 %s %s :You're not on that channel!",user->nick, Ptr->name);
+                        return;
+                }
+
+               if (Ptr)
                {
-                       if ((cstatus(user,Ptr) < STATUS_HOP) && (Ptr))
-                       {
-                               WriteServ(user->fd,"482 %s %s :You must be at least a half-operator to change modes on this channel",user->nick, Ptr->name);
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT(OnAccessCheck(user,NULL,Ptr,AC_GENERAL_MODE));
+                       
+                       if (MOD_RESULT == ACR_DENY)
                                return;
+                       if (MOD_RESULT == ACR_DEFAULT)
+                       {
+                               if (cstatus(user,Ptr) < STATUS_HOP)
+                               {
+                                       WriteServ(user->fd,"482 %s %s :You must be at least a half-operator to change modes on this channel",user->nick, Ptr->name);
+                                       return;
+                               }
                        }
-               }
 
-               process_modes(parameters,user,Ptr,cstatus(user,Ptr),pcnt,false,false,false);
+                       process_modes(parameters,user,Ptr,cstatus(user,Ptr),pcnt,false,false,false);
+               }
        }
        else
        {
@@ -1300,7 +1472,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                log(DEBUG,"params > 1");
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,MAXBUF);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1387,10 +1559,10 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,MAXBUF);
                                                        }
                                                }
                                        }
@@ -1400,7 +1572,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                if (strlen(outpars))
                {
                        char b[MAXBUF];
-                       strcpy(b,"");
+                       strlcpy(b,"",MAXBUF);
                        int z = 0;
                        int i = 0;
                        while (i < strlen (outpars))
@@ -1445,7 +1617,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }
 
@@ -1486,7 +1658,7 @@ void merge_mode(char **parameters, int pcnt)
                log(DEBUG,"params > 1");
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,MAXBUF);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1573,10 +1745,10 @@ void merge_mode(char **parameters, int pcnt)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,MAXBUF);
                                                        }
                                                }
                                        }
@@ -1624,7 +1796,7 @@ void merge_mode(char **parameters, int pcnt)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }
 
@@ -1635,7 +1807,7 @@ void merge_mode(char **parameters, int pcnt)
        if (Ptr)
        {
                userrec s2;
-               strncpy(s2.nick,ServerName,NICKMAX);
+               strlcpy(s2.nick,ServerName,NICKMAX);
                strcpy(s2.modes,"o");
                s2.fd = -1;
                process_modes(parameters,&s2,Ptr,STATUS_OP,pcnt,true,true,false);
@@ -1664,13 +1836,18 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                log(DEBUG,"params > 1");
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,MAXBUF);
 
                strcpy(outpars,"+");
                direction = 1;
 
+               if ((parameters[1][0] == ':') && (strlen(parameters[1])>1))
+               {
+                       // some stupid 3rd party things (such as services packages) put a colon on the mode list...
+                       log(DEBUG,"Some muppet put a colon on the modelist! changed to '%s'",++parameters[1]);
+               }
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
-                       return;
+               return;
 
                for (int i = 0; i < strlen(parameters[1]); i++)
                {
@@ -1724,6 +1901,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                                dmodes[strlen(dmodes)] = parameters[1][i];
                                                                outpars[strlen(outpars)+1]='\0';
                                                                outpars[strlen(outpars)] = parameters[1][i];
+                                                               log(DEBUG,"OUTPARS='%s', DMODES='%s'",outpars,dmodes);
                                                        }
                                                }
                                        }
@@ -1751,16 +1929,17 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,MAXBUF);
                                                        }
                                                }
                                        }
                                }
                        }
                }
+               log(DEBUG,"DONE! OUTPARS='%s', DMODES='%s'",outpars,dmodes);
                if (strlen(outpars))
                {
                        char b[MAXBUF];
@@ -1796,7 +1975,9 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
 
-                       WriteTo(user,dest,"MODE :%s",b);
+                       // was sending 'b'
+                       WriteTo(user,dest,"MODE %s :%s",dest->nick,b);
+                       log(DEBUG,"Sent: :%s MODE %s",user->nick,b);
 
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1804,7 +1985,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }