]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/mode.cpp
Convert remaining InspIRCd::Log() calls to new logging system
[user/henk/code/inspircd.git] / src / mode.cpp
index 48777a7bf808e93f64f8b55376af847c000534a4..b3f05bd3710639237bbcb7ac209c271baa2bbfe0 100644 (file)
@@ -54,8 +54,8 @@
 /* +n (notice mask - our implementation of snomasks) */
 #include "modes/umode_n.h"
 
-ModeHandler::ModeHandler(InspIRCd* Instance, char modeletter, int parameters_on, int parameters_off, bool listmode, ModeType type, bool operonly, char mprefix)
-       : ServerInstance(Instance), mode(modeletter), n_params_on(parameters_on), n_params_off(parameters_off), list(listmode), m_type(type), oper(operonly), prefix(mprefix), count(0)
+ModeHandler::ModeHandler(InspIRCd* Instance, char modeletter, int parameters_on, int parameters_off, bool listmode, ModeType type, bool operonly, char mprefix, char prefixrequired)
+       : ServerInstance(Instance), mode(modeletter), n_params_on(parameters_on), n_params_off(parameters_off), list(listmode), m_type(type), oper(operonly), prefix(mprefix), count(0), prefixneeded(prefixrequired)
 {
 }
 
@@ -68,6 +68,16 @@ bool ModeHandler::IsListMode()
        return list;
 }
 
+char ModeHandler::GetNeededPrefix()
+{
+       return prefixneeded;
+}
+
+void ModeHandler::SetNeededPrefix(char needsprefix)
+{
+       prefixneeded = needsprefix;
+}
+
 unsigned int ModeHandler::GetPrefixRank()
 {
        return 0;
@@ -81,7 +91,7 @@ unsigned int ModeHandler::GetCount()
 void ModeHandler::ChangeCount(int modifier)
 {
        count += modifier;
-       ServerInstance->Log(DEBUG,"Change count for mode %c is now %d", mode, count);
+       ServerInstance->Logs->Log("MODE", DEBUG,"Change count for mode %c is now %d", mode, count);
 }
 
 ModeType ModeHandler::GetModeType()
@@ -109,7 +119,7 @@ char ModeHandler::GetModeChar()
        return mode;
 }
 
-ModeAction ModeHandler::OnModeChange(User*, User*, Channel*, std::string&, bool)
+ModeAction ModeHandler::OnModeChange(User*, User*, Channel*, std::string&, bool, bool)
 {
        return MODEACTION_DENY;
 }
@@ -157,12 +167,12 @@ ModeType ModeWatcher::GetModeType()
        return m_type;
 }
 
-bool ModeWatcher::BeforeMode(User*, User*, Channel*, std::string&, bool, ModeType)
+bool ModeWatcher::BeforeMode(User*, User*, Channel*, std::string&, bool, ModeType, bool)
 {
        return true;
 }
 
-void ModeWatcher::AfterMode(User*, User*, Channel*, const std::string&, bool, ModeType)
+void ModeWatcher::AfterMode(User*, User*, Channel*, const std::string&, bool, ModeType, bool)
 {
 }
 
@@ -279,7 +289,7 @@ void ModeParser::DisplayCurrentModes(User *user, User* targetuser, Channel* targ
        return;
 }
 
-void ModeParser::Process(const char** parameters, int pcnt, User *user, bool servermode)
+void ModeParser::Process(const char* const* parameters, int pcnt, User *user, bool servermode)
 {
        std::string target = parameters[0];
        ModeType type = MODETYPE_USER;
@@ -306,20 +316,12 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
                {
                        unsigned char mletter = *mode;
 
-                       int MOD_RESULT = 0;
-                       FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, *mode, "", true, 0));
-                       if (MOD_RESULT == ACR_DENY)
-                       {
-                               mode++;
-                               continue;
-                       }
-
                        if (*mode == '+')
                        {
                                mode++;
                                continue;
                        }
-
+                       
                        /* Ensure the user doesnt request the same mode twice,
                         * so they cant flood themselves off out of idiocy.
                         */
@@ -338,6 +340,14 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
 
                        if ((mh) && (mh->IsListMode()))
                        {
+                               int MOD_RESULT = 0;
+                               FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, *mode, "", true, 0));
+                               if (MOD_RESULT == ACR_DENY)
+                               {
+                                       mode++;
+                                       continue;
+                               }
+
                                if (ServerInstance->Config->HideModeLists[mletter] && (targetchannel->GetStatus(user) < STATUS_HOP))
                                {
                                        user->WriteServ("482 %s %s :Only half-operators and above may view the +%c list",user->nick, targetchannel->name, *mode++);
@@ -377,6 +387,8 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
        }
        else if (pcnt > 1)
        {
+               bool SkipAccessChecks = false;
+
                if (targetchannel)
                {
                        type = MODETYPE_CHANNEL;
@@ -386,28 +398,14 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
                         * (e.g. are they a (half)op?
                         */
 
-                       if ((IS_LOCAL(user)) && (targetchannel->GetStatus(user) < STATUS_HOP))
+                       if ((IS_LOCAL(user)) && (!ServerInstance->ULine(user->server)) && (!servermode))
                        {
                                /* We don't have halfop */
                                int MOD_RESULT = 0;
                                FOREACH_RESULT(I_OnAccessCheck,OnAccessCheck(user, NULL, targetchannel, AC_GENERAL_MODE));
                                if (MOD_RESULT == ACR_DENY)
                                        return;
-
-                               if (MOD_RESULT == ACR_DEFAULT)
-                               {
-                                       /* Are we a uline or is it a servermode? */
-                                       if ((!ServerInstance->ULine(user->server)) && (!servermode))
-                                       {
-                                               /* Not enough permission:
-                                                * NOT a uline and NOT a servermode,
-                                                * OR, NOT halfop or above.
-                                                */
-                                               user->WriteServ("482 %s %s :You're not a channel %soperator",user->nick, targetchannel->name,
-                                                               ServerInstance->Config->AllowHalfop ? "(half)" : "");
-                                               return;
-                                       }
-                               }
+                               SkipAccessChecks = (MOD_RESULT == ACR_ALLOW);
                        }
                }
                else if (targetuser)
@@ -492,6 +490,8 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
 
                                                if (modehandlers[handler_id]->GetModeType() == type)
                                                {
+                                                       int MOD_RESULT = 0;
+
                                                        if (modehandlers[handler_id]->GetNumParams(adding))
                                                        {
                                                                /* This mode expects a parameter, do we have any parameters left in our list to use? */
@@ -509,52 +509,73 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
                                                                        continue;
                                                                }
 
-                                                               int MOD_RESULT = 0;
-                                                               FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, modechar, parameter, adding, 1));
-                                                               if (MOD_RESULT == ACR_DENY)
-                                                                       continue;
-
-                                                               bool had_parameter = !parameter.empty();
-                                                               
-                                                               for (ModeWatchIter watchers = modewatchers[handler_id].begin(); watchers != modewatchers[handler_id].end(); watchers++)
-                                                               {
-                                                                       if ((*watchers)->BeforeMode(user, targetuser, targetchannel, parameter, adding, type) == false)
-                                                                       {
-                                                                               abort = true;
-                                                                               break;
-                                                                       }
-                                                                       /* A module whacked the parameter completely, and there was one. abort. */
-                                                                       if ((had_parameter) && (parameter.empty()))
-                                                                       {
-                                                                               abort = true;
-                                                                               break;
-                                                                       }
-                                                               }
-
-                                                               if (abort)
-                                                                       continue;
+                                                               FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, modechar, parameter, adding, 1, servermode));
                                                        }
                                                        else
                                                        {
-                                                               int MOD_RESULT = 0;
-                                                               FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, modechar, "", adding, 0));
-                                                               if (MOD_RESULT == ACR_DENY)
-                                                                       continue;
+                                                               FOREACH_RESULT(I_OnRawMode, OnRawMode(user, targetchannel, modechar, "", adding, 0, servermode));
+                                                       }
 
-                                                               /* Fix by brain: mode watchers not being called for parameterless modes */
-                                                               for (ModeWatchIter watchers = modewatchers[handler_id].begin(); watchers != modewatchers[handler_id].end(); watchers++)
+                                                       if (IS_LOCAL(user) && (MOD_RESULT == ACR_DENY))
+                                                               continue;
+
+                                                       if (!SkipAccessChecks && IS_LOCAL(user) && (MOD_RESULT != ACR_ALLOW))
+                                                       {
+                                                               ServerInstance->Logs->Log("MODE", DEBUG,"Enter minimum prefix check");
+                                                               /* Check access to this mode character */
+                                                               if ((type == MODETYPE_CHANNEL) && (modehandlers[handler_id]->GetNeededPrefix()))
                                                                {
-                                                                       if ((*watchers)->BeforeMode(user, targetuser, targetchannel, parameter, adding, type) == false)
+                                                                       char needed = modehandlers[handler_id]->GetNeededPrefix();
+                                                                       ModeHandler* prefixmode = FindPrefix(needed);
+                                                                       ServerInstance->Logs->Log("MODE", DEBUG,"Needed prefix: %c", needed);
+
+                                                                       /* If the mode defined by the handler is not '\0', but the handler for it
+                                                                        * cannot be found, they probably dont have the right module loaded to implement
+                                                                        * the prefix they want to compare the mode against, e.g. '&' for m_chanprotect.
+                                                                        * Revert to checking against the minimum core prefix, '%'.
+                                                                        */
+                                                                       if (needed && !prefixmode)
+                                                                               prefixmode = FindPrefix('%');
+                                               
+                                                                       unsigned int neededrank = prefixmode->GetPrefixRank();
+                                                                       /* Compare our rank on the channel against the rank of the required prefix,
+                                                                        * allow if >= ours. Because mIRC and xchat throw a tizz if the modes shown
+                                                                        * in NAMES(X) are not in rank order, we know the most powerful mode is listed
+                                                                        * first, so we don't need to iterate, we just look up the first instead.
+                                                                        */
+                                                                       std::string modestring = targetchannel->GetAllPrefixChars(user);
+                                                                       char ml = (modestring.empty() ? '\0' : modestring[0]);
+                                                                       ModeHandler* ourmode = FindPrefix(ml);
+                                                                       if (!ourmode || ourmode->GetPrefixRank() < neededrank)
                                                                        {
-                                                                               abort = true;
-                                                                               break;
+                                                                               /* Bog off */
+                                                                               user->WriteServ("482 %s %s :You must have channel privilege %c or above to %sset channel mode %c",
+                                                                                               user->nick, targetchannel->name, needed, adding ? "" : "un", modechar);
+                                                                               continue;
                                                                        }
                                                                }
+                                                       }
 
-                                                               if (abort)
-                                                                       continue;
+                                                       bool had_parameter = !parameter.empty();
+                                                               
+                                                       for (ModeWatchIter watchers = modewatchers[handler_id].begin(); watchers != modewatchers[handler_id].end(); watchers++)
+                                                       {
+                                                               if ((*watchers)->BeforeMode(user, targetuser, targetchannel, parameter, adding, type, servermode) == false)
+                                                               {
+                                                                       abort = true;
+                                                                       break;
+                                                               }
+                                                               /* A module whacked the parameter completely, and there was one. abort. */
+                                                               if ((had_parameter) && (parameter.empty()))
+                                                               {
+                                                                       abort = true;
+                                                                       break;
+                                                               }
                                                        }
 
+                                                       if (abort)
+                                                               continue;
+
                                                        /* It's an oper only mode, check if theyre an oper. If they arent,
                                                         * eat any parameter that  came with the mode, and continue to next
                                                         */
@@ -567,7 +588,7 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
                                                        }
 
                                                        /* Call the handler for the mode */
-                                                       ModeAction ma = modehandlers[handler_id]->OnModeChange(user, targetuser, targetchannel, parameter, adding);
+                                                       ModeAction ma = modehandlers[handler_id]->OnModeChange(user, targetuser, targetchannel, parameter, adding, servermode);
 
                                                        if ((modehandlers[handler_id]->GetNumParams(adding)) && (parameter.empty()))
                                                        {
@@ -610,7 +631,7 @@ void ModeParser::Process(const char** parameters, int pcnt, User *user, bool ser
 
                                                                /* Call all the AfterMode events in the mode watchers for this mode */
                                                                for (ModeWatchIter watchers = modewatchers[handler_id].begin(); watchers != modewatchers[handler_id].end(); watchers++)
-                                                                       (*watchers)->AfterMode(user, targetuser, targetchannel, parameter, adding, type);
+                                                                       (*watchers)->AfterMode(user, targetuser, targetchannel, parameter, adding, type, servermode);
 
                                                                /* Reset the state change flag */
                                                                state_change = false;