]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/mode.cpp
Changed length of user::modes buffer from 512 to much more sensible 54
[user/henk/code/inspircd.git] / src / mode.cpp
index 4a7c56bd3733a7a889b641f93dc35bc2f317ae54..d33da7e7d31cb6dbc006cda2ae5ad50484ec4f1e 100644 (file)
@@ -1,13 +1,27 @@
+/*       +------------------------------------+
+ *       | Inspire Internet Relay Chat Daemon |
+ *       +------------------------------------+
+ *
+ *  Inspire is copyright (C) 2002-2004 ChatSpike-Dev.
+ *                       E-mail:
+ *                <brain@chatspike.net>
+ *               <Craig@chatspike.net>
+ *     
+ * Written by Craig Edwards, Craig McLure, and others.
+ * This program is free but copyrighted software; see
+ *            the file COPYING for details.
+ *
+ * ---------------------------------------------------
+ */
+
+using namespace std;
+
+#include "inspircd_config.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
 #include "inspircd_util.h"
-#include "inspircd_config.h"
 #include <unistd.h>
-#include <fcntl.h>
 #include <sys/errno.h>
-#include <sys/ioctl.h>
-#include <sys/utsname.h>
-#include <cstdio>
 #include <time.h>
 #include <string>
 #ifdef GCC3
 #include <map>
 #include <sstream>
 #include <vector>
-#include <errno.h>
 #include <deque>
-#include <errno.h>
-#include <unistd.h>
-#include <sched.h>
 #include "connection.h"
 #include "users.h"
 #include "servers.h"
 #include "message.h"
 #include "commands.h"
 #include "xline.h"
-
-using namespace std;
+#include "inspstring.h"
+#include "helperfuncs.h"
 
 extern int MODCOUNT;
-extern vector<Module*> modules;
-extern vector<ircd_module*> factory;
+extern std::vector<Module*> modules;
+extern std::vector<ircd_module*> factory;
+extern std::vector<std::string> module_names;
+
 
 extern int LogLevel;
 extern char ServerName[MAXBUF];
@@ -60,11 +72,11 @@ extern bool AllowHalfop;
 extern bool AllowProtect;
 extern bool AllowFounder;
 
+extern time_t TIME;
 
 char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -75,14 +87,14 @@ char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
        if (!isnick(dest))
        {
                log(DEFAULT,"the target nickname given to give_ops was invalid");
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        d = Find(dest);
        if (!d)
        {
                log(DEFAULT,"the target nickname given to give_ops couldnt be found");
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -128,7 +140,6 @@ char* give_ops(userrec *user,char *dest,chanrec *chan,int status)
 char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -139,12 +150,12 @@ char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -185,7 +196,6 @@ char* give_hops(userrec *user,char *dest,chanrec *chan,int status)
 char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -196,12 +206,12 @@ char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -242,7 +252,6 @@ char* give_voice(userrec *user,char *dest,chanrec *chan,int status)
 char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -254,13 +263,13 @@ char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
        if (!isnick(dest))
        {
                log(DEBUG,"take_ops was given an invalid target nickname of %s",dest);
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
                log(DEBUG,"take_ops couldnt resolve the target nickname: %s",dest);
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -302,7 +311,6 @@ char* take_ops(userrec *user,char *dest,chanrec *chan,int status)
 char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -313,12 +321,12 @@ char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -359,7 +367,6 @@ char* take_hops(userrec *user,char *dest,chanrec *chan,int status)
 char* take_voice(userrec *user,char *dest,chanrec *chan,int status)
 {
        userrec *d;
-       int i;
        
        if ((!user) || (!dest) || (!chan))
        {
@@ -370,12 +377,12 @@ char* take_voice(userrec *user,char *dest,chanrec *chan,int status)
        d = Find(dest);
        if (!isnick(dest))
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        if (!d)
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, dest);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, dest);
                return NULL;
        }
        else
@@ -423,30 +430,44 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
        BanItem b;
        if ((!user) || (!dest) || (!chan))
                return NULL;
+       int l = strlen(dest);
        if (strchr(dest,'!')==0)
                return NULL;
        if (strchr(dest,'@')==0)
                return NULL;
-       for (int i = 0; i < strlen(dest); i++)
+       for (int i = 0; i < l; i++)
                if (dest[i] < 32)
                        return NULL;
-       for (int i = 0; i < strlen(dest); i++)
+       for (int i = 0; i < l; i++)
                if (dest[i] > 126)
                        return NULL;
        int c = 0;
-       for (int i = 0; i < strlen(dest); i++)
+       for (int i = 0; i < l; i++)
                if (dest[i] == '!')
                        c++;
        if (c>1)
                return NULL;
        c = 0;
-       for (int i = 0; i < strlen(dest); i++)
+       for (int i = 0; i < l; i++)
                if (dest[i] == '@')
                        c++;
        if (c>1)
                return NULL;
+
+       long maxbans = GetMaxBans(chan->name);
+       if (chan->bans.size() > maxbans)
+       {
+               WriteServ(user->fd,"478 %s %s :Channel ban list for %s is full (maximum entries for this channel is %d)",user->nick, chan->name,chan->name,maxbans);
+               return NULL;
+       }
+
        log(DEBUG,"add_ban: %s %s",chan->name,user->nick);
 
+       int MOD_RESULT = 0;
+       FOREACH_RESULT(OnAddBan(user,chan,dest));
+       if (MOD_RESULT)
+               return NULL;
+
        TidyBan(dest);
        for (BanList::iterator i = chan->bans.begin(); i != chan->bans.end(); i++)
        {
@@ -457,7 +478,7 @@ char* add_ban(userrec *user,char *dest,chanrec *chan,int status)
                }
        }
 
-       b.set_time = time(NULL);
+       b.set_time = TIME;
        strncpy(b.data,dest,MAXBUF);
        strncpy(b.set_by,user->nick,NICKMAX);
        chan->bans.push_back(b);
@@ -476,6 +497,10 @@ char* take_ban(userrec *user,char *dest,chanrec *chan,int status)
        {
                if (!strcasecmp(i->data,dest))
                {
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT(OnDelBan(user,chan,dest));
+                       if (MOD_RESULT)
+                               return NULL;
                        chan->bans.erase(i);
                        return dest;
                }
@@ -483,6 +508,57 @@ char* take_ban(userrec *user,char *dest,chanrec *chan,int status)
        return NULL;
 }
 
+// tidies up redundant modes, e.g. +nt-nt+i becomes +-+i,
+// a section further down the chain tidies up the +-+- crap.
+std::string compress_modes(std::string modes,bool channelmodes)
+{
+       int counts[127];
+       bool active[127];
+       int delta = 1;
+       memset(counts,0,sizeof(counts));
+       memset(active,0,sizeof(active));
+       log(DEBUG,"compress_modes: %s",modes.c_str());
+       for (int i = 0; i < modes.length(); i++)
+       {
+               if ((modes[i] == '+') || (modes[i] == '-'))
+                       continue;
+               if (channelmodes)
+               {
+                       if ((strchr("itnmsp",modes[i])) || ((ModeDefined(modes[i],MT_CHANNEL)) && (ModeDefinedOn(modes[i],MT_CHANNEL)==0) && (ModeDefinedOff(modes[i],MT_CHANNEL)==0)))
+                       {
+                               log(DEBUG,"Tidy mode %c",modes[i]);
+                               counts[(unsigned int)modes[i]]++;
+                               active[(unsigned int)modes[i]] = true;
+                       }
+               }
+               else
+               {
+                       log(DEBUG,"Tidy mode %c",modes[i]);
+                       counts[(unsigned int)modes[i]]++;
+                       active[(unsigned int)modes[i]] = true;
+               }
+       }
+       for (int j = 65; j < 127; j++)
+       {
+               if ((counts[j] > 1) && (active[j] == true))
+               {
+                       static char v[2];
+                       v[0] = (unsigned char)j;
+                       v[1] = '\0';
+                       std::string mode_str = v;
+                       std::string::size_type pos = modes.find(mode_str);
+                       if (pos != std::string::npos)
+                       {
+                               log(DEBUG,"all occurances of mode %c to be deleted...",(unsigned char)j);
+                               while (modes.find(mode_str) != std::string::npos)
+                                       modes.erase(modes.find(mode_str),1);
+                               log(DEBUG,"New mode line: %s",modes.c_str());
+                       }
+               }
+       }
+       return modes;
+}
+
 void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int pcnt, bool servermode, bool silent, bool local)
 {
        if (!parameters) {
@@ -499,7 +575,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
        int ptr = 0;
        int mdir = 1;
        char* r = NULL;
-       bool k_set = false, l_set = false;
+       bool k_set = false, l_set = false, previously_set_l = false, previously_unset_l = false, previously_set_k = false, previously_unset_k = false;
 
        if (pcnt < 2)
        {
@@ -514,29 +590,37 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
        log(DEBUG,"process_modes: start: parameters=%d",pcnt);
 
-       strcpy(modelist,parameters[1]); /* mode list, e.g. +oo-o */
-                                       /* parameters[2] onwards are parameters for
-                                        * modes that require them :) */
-       strcpy(outlist,"+");
+       strlcpy(modelist,parameters[1],MAXBUF); /* mode list, e.g. +oo-o *
+                                                * parameters[2] onwards are parameters for
+                                                * modes that require them :) */
+       strlcpy(outlist,"+",MAXBUF);
        mdir = 1;
 
        log(DEBUG,"process_modes: modelist: %s",modelist);
 
-       for (ptr = 0; ptr < strlen(modelist); ptr++)
+       std::string tidied = compress_modes(modelist,true);
+       strlcpy(modelist,tidied.c_str(),MAXBUF);
+
+       int len = strlen(modelist);
+       while (modelist[len-1] == ' ')
+               modelist[--len] = '\0';
+       for (ptr = 0; ptr < len; ptr++)
        {
                r = NULL;
 
                {
                        log(DEBUG,"process_modes: modechar: %c",modelist[ptr]);
+
                        char modechar = modelist[ptr];
                        switch (modelist[ptr])
                        {
                                case '-':
                                        if (mdir != 0)
                                        {
-                                               if ((outlist[strlen(outlist)-1] == '+') || (outlist[strlen(outlist)-1] == '-'))
+                                               int t = strlen(outlist)-1;
+                                               if ((outlist[t] == '+') || (outlist[t] == '-'))
                                                {
-                                                       outlist[strlen(outlist)-1] = '-';
+                                                       outlist[t] = '-';
                                                }
                                                else
                                                {
@@ -550,9 +634,10 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                case '+':
                                        if (mdir != 1)
                                        {
-                                               if ((outlist[strlen(outlist)-1] == '+') || (outlist[strlen(outlist)-1] == '-'))
+                                               int t = strlen(outlist)-1;
+                                               if ((outlist[t] == '+') || (outlist[t] == '-'))
                                                {
-                                                       outlist[strlen(outlist)-1] = '+';
+                                                       outlist[t] = '+';
                                                }
                                                else
                                                {
@@ -568,18 +653,30 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        log(DEBUG,"Enough parameters left");
                                        if (mdir == 1)
                                        {
-                                               log(DEBUG,"calling give_ops");
-                                               r = give_ops(user,parameters[param++],chan,status);
+                                               MOD_RESULT = 0;
+                                               FOREACH_RESULT(OnRawMode(user, chan, 'o', parameters[param], true, 1));
+                                               if (!MOD_RESULT)
+                                               {
+                                                       log(DEBUG,"calling give_ops");
+                                                       r = give_ops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               log(DEBUG,"calling take_ops");
-                                               r = take_ops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'o', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       log(DEBUG,"calling take_ops");
+                                                       r = take_ops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"o");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"o",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                        
@@ -587,16 +684,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if (((param >= pcnt)) || (!AllowHalfop)) break;
                                        if (mdir == 1)
                                        {
-                                               r = give_hops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'h', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = give_hops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_hops(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'h', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_hops(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"h");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"h",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                        
@@ -605,16 +714,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if ((param >= pcnt)) break;
                                        if (mdir == 1)
                                        {
-                                               r = give_voice(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'v', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = give_voice(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_voice(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'v', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_voice(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"v");
-                                               strcpy(outpars[pc++],r);
+                                               strlcat(outlist,"v",MAXBUF);
+                                               strlcpy(outpars[pc++],r,MAXBUF);
                                        }
                                break;
                                
@@ -622,16 +743,28 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        if ((param >= pcnt)) break;
                                        if (mdir == 1)
                                        {
-                                               r = add_ban(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'b', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = add_ban(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        else
                                        {
-                                               r = take_ban(user,parameters[param++],chan,status);
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'b', parameters[param], false, 1));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       r = take_ban(user,parameters[param++],chan,status);
+                                               }
+                                               else param++;
                                        }
                                        if (r)
                                        {
-                                               strcat(outlist,"b");
-                                               strcpy(outpars[pc++],parameters[param-1]);
+                                               strlcat(outlist,"b",MAXBUF);
+                                               strlcpy(outpars[pc++],parameters[param-1],MAXBUF);
                                        }
                                break;
 
@@ -644,46 +777,68 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        {
                                                if (k_set)
                                                        break;
+
+                                               if (previously_unset_k)
+                                                       break;
+                                               previously_set_k = true;
                                                
                                                if (!strcmp(chan->key,""))
                                                {
-                                                       strcat(outlist,"k");
-                                                       char key[MAXBUF];
-                                                       strcpy(key,parameters[param++]);
-                                                       if (strlen(key)>32) {
-                                                               key[31] = '\0';
+                                                       MOD_RESULT = 0;
+                                                       FOREACH_RESULT(OnRawMode(user, chan, 'k', parameters[param], true, 1));
+                                                       if (!MOD_RESULT)
+                                                       {
+                                                               strcat(outlist,"k");
+                                                               char key[MAXBUF];
+                                                               strlcpy(key,parameters[param++],32);
+                                                               strlcpy(outpars[pc++],key,MAXBUF);
+                                                               strlcpy(chan->key,key,MAXBUF);
+                                                               k_set = true;
                                                        }
-                                                       strcpy(outpars[pc++],key);
-                                                       strcpy(chan->key,key);
-                                                       k_set = true;
+                                                       else param++;
                                                }
                                        }
                                        else
                                        {
                                                /* checks on -k are case sensitive and only accurate to the
                                                   first 32 characters */
+                                               if (previously_set_k)
+                                                       break;
+                                               previously_unset_k = true;
+
                                                char key[MAXBUF];
-                                               strcpy(key,parameters[param++]);
-                                               if (strlen(key)>32) {
-                                                       key[31] = '\0';
-                                               }
-                                               /* only allow -k if correct key given */
-                                               if (!strcmp(chan->key,key))
+                                               MOD_RESULT = 0;
+                                               FOREACH_RESULT(OnRawMode(user, chan, 'k', parameters[param], false, 1));
+                                               if (!MOD_RESULT)
                                                {
-                                                       strcat(outlist,"k");
-                                                       strcpy(chan->key,"");
-                                                       strcpy(outpars[pc++],key);
+                                                       strlcpy(key,parameters[param++],32);
+                                                       /* only allow -k if correct key given */
+                                                       if (!strcmp(chan->key,key))
+                                                       {
+                                                               strlcat(outlist,"k",MAXBUF);
+                                                               strlcpy(chan->key,"",MAXBUF);
+                                                               strlcpy(outpars[pc++],key,MAXBUF);
+                                                       }
                                                }
+                                               else param++;
                                        }
                                break;
                                
                                case 'l':
                                        if (mdir == 0)
                                        {
-                                               if (chan->limit)
-                                               {
-                                                       strcat(outlist,"l");
-                                                       chan->limit = 0;
+                                               if (previously_set_l)
+                                                       break;
+                                               previously_unset_l = true;
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'l', "", false, 0));
+                                                if (!MOD_RESULT)
+                                                {
+                                                       if (chan->limit)
+                                                       {
+                                                               strcat(outlist,"l");
+                                                               chan->limit = 0;
+                                                       }
                                                }
                                        }
                                        
@@ -692,7 +847,9 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                        {
                                                if (l_set)
                                                        break;
-                                               
+                                               if (previously_unset_l)
+                                                       break;
+                                               previously_set_l = true;
                                                bool invalid = false;
                                                for (int i = 0; i < strlen(parameters[param]); i++)
                                                {
@@ -708,96 +865,154 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
 
                                                if (invalid)
                                                        break;
-                                               
-                                               chan->limit = atoi(parameters[param]);
-                                               
-                                               // reported by mech: large values cause underflow
-                                               if (chan->limit < 0)
-                                                       chan->limit = 0x7FFFFF;
+
+                                                MOD_RESULT = 0;
+                                                FOREACH_RESULT(OnRawMode(user, chan, 'l', parameters[param], true, 1));
+                                                if (!MOD_RESULT)
+                                                {
+       
+                                                       chan->limit = atoi(parameters[param]);
+                                                       
+                                                       // reported by mech: large values cause underflow
+                                                       if (chan->limit < 0)
+                                                               chan->limit = 0x7FFF;
+                                               }
                                                        
                                                if (chan->limit)
                                                {
-                                                       strcat(outlist,"l");
-                                                       strcpy(outpars[pc++],parameters[param++]);
+                                                       strlcat(outlist,"l",MAXBUF);
+                                                       strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                        l_set = true;
                                                }
                                        }
                                break;
                                
                                case 'i':
-                                       if (chan->inviteonly != mdir)
-                                       {
-                                               strcat(outlist,"i");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'i', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (mdir)
+                                               {
+                                                       if (!(chan->binarymodes & CM_INVITEONLY)) strlcat(outlist,"i",MAXBUF);
+                                                       chan->binarymodes |= CM_INVITEONLY;
+                                               }
+                                               else
+                                               {
+                                                       if (chan->binarymodes & CM_INVITEONLY) strlcat(outlist,"i",MAXBUF);
+                                                       chan->binarymodes &= ~CM_INVITEONLY;
+                                               }
                                        }
-                                       chan->inviteonly = mdir;
                                break;
                                
                                case 't':
-                                       if (chan->topiclock != mdir)
-                                       {
-                                               strcat(outlist,"t");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 't', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                               if (mdir)
+                                                {
+                                                       if (!(chan->binarymodes & CM_TOPICLOCK)) strlcat(outlist,"t",MAXBUF);
+                                                        chan->binarymodes |= CM_TOPICLOCK;
+                                                }
+                                                else
+                                                {
+                                                       if (chan->binarymodes & CM_NOEXTERNAL) strlcat(outlist,"t",MAXBUF);
+                                                        chan->binarymodes &= ~CM_TOPICLOCK;
+                                                }
                                        }
-                                       chan->topiclock = mdir;
                                break;
                                
                                case 'n':
-                                       if (chan->noexternal != mdir)
-                                       {
-                                               strcat(outlist,"n");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'n', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                                if (mdir)
+                                                {
+                                                       if (!(chan->binarymodes & CM_NOEXTERNAL)) strlcat(outlist,"n",MAXBUF);
+                                                        chan->binarymodes |= CM_NOEXTERNAL;
+                                                }
+                                                else
+                                                {
+                                                       if (chan->binarymodes & CM_NOEXTERNAL) strlcat(outlist,"n",MAXBUF);
+                                                        chan->binarymodes &= ~CM_NOEXTERNAL;
+                                                }
                                        }
-                                       chan->noexternal = mdir;
                                break;
                                
                                case 'm':
-                                       if (chan->moderated != mdir)
-                                       {
-                                               strcat(outlist,"m");
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'm', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_MODERATED)) strlcat(outlist,"m",MAXBUF);
+                                                        chan->binarymodes |= CM_MODERATED;
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_MODERATED) strlcat(outlist,"m",MAXBUF);
+                                                        chan->binarymodes &= ~CM_MODERATED;
+                                                }
                                        }
-                                       chan->moderated = mdir;
                                break;
                                
                                case 's':
-                                       if (chan->secret != mdir)
-                                       {
-                                               strcat(outlist,"s");
-                                               if (chan->c_private)
-                                               {
-                                                       chan->c_private = 0;
-                                                       if (mdir)
-                                                       {
-                                                               strcat(outlist,"-p+");
-                                                       }
-                                                       else
-                                                       {
-                                                               strcat(outlist,"+p-");
-                                                       }
-                                               }
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 's', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_SECRET)) strlcat(outlist,"s",MAXBUF);
+                                                        chan->binarymodes |= CM_SECRET;
+                                                        if (chan->binarymodes & CM_PRIVATE)
+                                                        {
+                                                                chan->binarymodes &= ~CM_PRIVATE;
+                                                                if (mdir)
+                                                                {
+                                                                        strlcat(outlist,"-p+",MAXBUF);
+                                                                }
+                                                        }
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_SECRET) strlcat(outlist,"s",MAXBUF);
+                                                        chan->binarymodes &= ~CM_SECRET;
+                                                }
                                        }
-                                       chan->secret = mdir;
                                break;
                                
                                case 'p':
-                                       if (chan->c_private != mdir)
-                                       {
-                                               strcat(outlist,"p");
-                                               if (chan->secret)
-                                               {
-                                                       chan->secret = 0;
-                                                       if (mdir)
-                                                       {
-                                                               strcat(outlist,"-s+");
-                                                       }
-                                                       else
-                                                       {
-                                                               strcat(outlist,"+s-");
-                                                       }
-                                               }
+                                        MOD_RESULT = 0;
+                                        FOREACH_RESULT(OnRawMode(user, chan, 'p', "", mdir, 0));
+                                        if (!MOD_RESULT)
+                                        {
+                                                if (mdir)
+                                                {
+                                                        if (!(chan->binarymodes & CM_PRIVATE)) strlcat(outlist,"p",MAXBUF);
+                                                        chan->binarymodes |= CM_PRIVATE;
+                                                        if (chan->binarymodes & CM_SECRET)
+                                                        {
+                                                                chan->binarymodes &= ~CM_SECRET;
+                                                                if (mdir)
+                                                                {
+                                                                        strlcat(outlist,"-s+",MAXBUF);
+                                                                }
+                                                        }
+                                                }
+                                                else
+                                                {
+                                                        if (chan->binarymodes & CM_PRIVATE) strlcat(outlist,"p",MAXBUF);
+                                                        chan->binarymodes &= ~CM_PRIVATE;
+                                                }
                                        }
-                                       chan->c_private = mdir;
                                break;
                                
                                default:
-                                       log(DEBUG,"Preprocessing custom mode %c",modechar);
+                                       log(DEBUG,"Preprocessing custom mode %c: modelist: %s",modechar,chan->custom_modes);
                                        string_list p;
                                        p.clear();
                                        if (((!strchr(chan->custom_modes,modechar)) && (!mdir)) || ((strchr(chan->custom_modes,modechar)) && (mdir)))
@@ -825,65 +1040,83 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                                                bool handled = false;
                                                if (param>=pcnt)
                                                {
-                                                       log(DEBUG,"Not enough parameters for module-mode %c",modechar);
                                                        // we're supposed to have a parameter, but none was given... so dont handle the mode.
                                                        if (((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir)) || ((ModeDefinedOff(modechar,MT_CHANNEL)>0) && (!mdir))) 
                                                        {
+                                                               log(DEBUG,"Not enough parameters for module-mode %c",modechar);
                                                                handled = true;
                                                                param++;
                                                        }
                                                }
-                                               for (int i = 0; i <= MODCOUNT; i++)
-                                               {
-                                                       if (!handled)
+
+                                               // BIG ASS IDIOTIC CODER WARNING!
+                                               // Using OnRawMode on another modules mode's behavour 
+                                               // will confuse the crap out of admins! just because you CAN
+                                               // do it, doesnt mean you SHOULD!
+                                               MOD_RESULT = 0;
+                                               std::string para = "";
+                                               if (p.size())
+                                                       para = p[0];
+                                               FOREACH_RESULT(OnRawMode(user, chan, modechar, para, mdir, pcnt));
+                                               if (!MOD_RESULT)
+                                               {
+                                                       for (int i = 0; i <= MODCOUNT; i++)
                                                        {
-                                                               int t = modules[i]->OnExtendedMode(user,chan,modechar,MT_CHANNEL,mdir,p);
-                                                               if (t != 0)
+                                                               if (!handled)
                                                                {
-                                                                       log(DEBUG,"OnExtendedMode returned nonzero for a module");
-                                                                       char app[] = {modechar, 0};
-                                                                       if (ModeIsListMode(modechar,MT_CHANNEL))
+                                                                       int t = modules[i]->OnExtendedMode(user,chan,modechar,MT_CHANNEL,mdir,p);
+                                                                       if (t != 0)
                                                                        {
-                                                                               if (t == -1)
-                                                                               {
-                                                                                       pc++;
-                                                                               }
-                                                                               else
+                                                                               log(DEBUG,"OnExtendedMode returned nonzero for a module");
+                                                                               char app[] = {modechar, 0};
+                                                                               if (ModeIsListMode(modechar,MT_CHANNEL))
                                                                                {
-                                                                                       if (ptr>0)
+                                                                                       if (t == -1)
+                                                                                       {
+                                                                                               //pc++;
+                                                                                               param++;
+                                                                                       }
+                                                                                       else
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               if (ptr>0)
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
+                                                                                               strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                                                        }
-                                                                                       strcpy(outpars[pc++],parameters[param++]);
                                                                                }
-                                                                       }
-                                                                       else
-                                                                       {
-                                                                               if (ptr>0)
+                                                                               else
                                                                                {
-                                                                                       if ((modelist[ptr-1] == '+') || (modelist[ptr-1] == '-'))
+                                                                                       if (ptr>0)
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               if ((modelist[ptr-1] == '+') || (modelist[ptr-1] == '-'))
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
+                                                                                               else if (!strchr(outlist,modechar))
+                                                                                               {
+                                                                                                       strlcat(outlist, app,MAXBUF);
+                                                                                               }
                                                                                        }
-                                                                                       else if (!strchr(outlist,modechar))
+                                                                                       chan->SetCustomMode(modechar,mdir);
+                                                                                       // include parameters in output if mode has them
+                                                                                       if ((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir))
                                                                                        {
-                                                                                               strcat(outlist, app);
+                                                                                               chan->SetCustomModeParam(modelist[ptr],parameters[param],mdir);
+                                                                                               strlcpy(outpars[pc++],parameters[param++],MAXBUF);
                                                                                        }
                                                                                }
-                                                                               chan->SetCustomMode(modechar,mdir);
-                                                                               // include parameters in output if mode has them
-                                                                               if ((ModeDefinedOn(modechar,MT_CHANNEL)>0) && (mdir))
-                                                                               {
-                                                                                       chan->SetCustomModeParam(modelist[ptr],parameters[param],mdir);
-                                                                                       strcpy(outpars[pc++],parameters[param++]);
-                                                                               }
-                                                                       }
-                                                                       // break, because only one module can handle the mode.
-                                                                       handled = true;
-                                                               }
-                                                       }
-                                               }
+                                                                               // break, because only one module can handle the mode.
+                                                                               handled = true;
+                                                                               }
+                                                                       }
+                                                       }
+                                               }
                                        }
+                                       else
+                                       {
+                                               WriteServ(user->fd,"472 %s %c :is unknown mode char to me",user->nick,modechar);
+                                       }
                                break;
                                
                        }
@@ -891,17 +1124,19 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
        }
 
        /* this ensures only the *valid* modes are sent out onto the network */
-       while ((outlist[strlen(outlist)-1] == '-') || (outlist[strlen(outlist)-1] == '+'))
+       int xt = strlen(outlist)-1;
+       while ((outlist[xt] == '-') || (outlist[xt] == '+'))
        {
-               outlist[strlen(outlist)-1] = '\0';
+               outlist[xt] = '\0';
+               xt = strlen(outlist)-1;
        }
-       if (strcmp(outlist,""))
+       if (outlist[0])
        {
-               strcpy(outstr,outlist);
+               strlcpy(outstr,outlist,MAXBUF);
                for (ptr = 0; ptr < pc; ptr++)
                {
-                       strcat(outstr," ");
-                       strcat(outstr,outpars[ptr]);
+                       strlcat(outstr," ",MAXBUF);
+                       strlcat(outstr,outpars[ptr],MAXBUF);
                }
                if (local)
                {
@@ -914,7 +1149,7 @@ void process_modes(char **parameters,userrec* user,chanrec *chan,int status, int
                        {
                                if (!silent)
                                {
-                                       WriteChannelWithServ(ServerName,chan,user,"MODE %s %s",chan->name,outstr);
+                                       WriteChannelWithServ(ServerName,chan,"MODE %s %s",chan->name,outstr);
                                        // M token for a usermode must go to all servers
                                        char buffer[MAXBUF];
                                        snprintf(buffer,MAXBUF,"M %s %s",chan->name, outstr);
@@ -992,8 +1227,8 @@ bool process_module_umode(char umode, userrec* source, void* dest, bool adding)
        if (!source)
        {
                s2 = new userrec;
-               strncpy(s2->nick,ServerName,NICKMAX);
-               strcpy(s2->modes,"o");
+               strlcpy(s2->nick,ServerName,NICKMAX);
+               strcpy(s2->modes,"o",52);
                s2->fd = -1;
                source = s2;
                faked = true;
@@ -1006,7 +1241,7 @@ bool process_module_umode(char umode, userrec* source, void* dest, bool adding)
                {
                        if (modules[i]->OnExtendedMode(source,(void*)dest,umode,MT_CLIENT,adding,p))
                        {
-                               log(DEBUG,"Module claims umode %c",umode);
+                               log(DEBUG,"Module %s claims umode %c",module_names[i].c_str(),umode);
                                return true;
                        }
                }
@@ -1033,7 +1268,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1046,16 +1281,19 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 
        if ((dest) && (pcnt == 1))
        {
-               WriteServ(user->fd,"221 %s :+%s",user->nick,user->modes);
+               WriteServ(user->fd,"221 %s :+%s",dest->nick,dest->modes);
                return;
        }
 
        if ((dest) && (pcnt > 1))
        {
+               std::string tidied = compress_modes(parameters[1],false);
+               parameters[1] = (char*)tidied.c_str();
+
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
                log(DEBUG,"pulled up dest user modes: %s",dmodes);
-       
+
                can_change = 0;
                if (user != dest)
                {
@@ -1082,13 +1320,16 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 
                for (int i = 0; i < strlen(parameters[1]); i++)
                {
+                       if (parameters[1][i] == ' ')
+                               continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1102,9 +1343,10 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1136,10 +1378,16 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                                        char umode = parameters[1][i];
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int q = strlen(dmodes);
+                                                               int r = strlen(outpars);
+                                                               dmodes[q+1]='\0';
+                                                               dmodes[q] = parameters[1][i];
+                                                               outpars[r+1]='\0';
+                                                               outpars[r] = parameters[1][i];
+                                                               if (parameters[1][i] == 'o')
+                                                               {
+                                                                       FOREACH_MOD OnGlobalOper(dest);
+                                                               }
                                                        }
                                                }
                                        }
@@ -1154,8 +1402,9 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                                                char temp[MAXBUF];      
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int r = strlen(outpars);
+                                                               outpars[r+1]='\0';
+                                                               outpars[r] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1164,20 +1413,23 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,52);
+
+                                                               if (umode == 'o')
+                                                                       DeleteOper(dest);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
-                       strcpy(b,"");
+                       strlcpy(b,"",MAXBUF);
                        int z = 0;
                        int i = 0;
                        while (i < strlen (outpars))
@@ -1204,17 +1456,19 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
+                       if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
 
-                       WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
-
-                       // M token for a usermode must go to all servers
-                       char buffer[MAXBUF];
-                       snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
-                       NetSendToAll(buffer);
+                       if (strcmp(b,""))
+                       {
+                               WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
+                               // M token for a usermode must go to all servers
+                               char buffer[MAXBUF];
+                               snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
+                               NetSendToAll(buffer);
+                       }
 
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1222,7 +1476,7 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,52);
 
                }
 
@@ -1236,35 +1490,67 @@ void handle_mode(char **parameters, int pcnt, userrec *user)
                {
                        /* just /modes #channel */
                        WriteServ(user->fd,"324 %s %s +%s",user->nick, Ptr->name, chanmodes(Ptr));
-                       WriteServ(user->fd,"329 %s %s %d", user->nick, Ptr->name, Ptr->created);
+                        WriteServ(user->fd,"329 %s %s %d", user->nick, Ptr->name, Ptr->created);
                        return;
                }
                else
                if (pcnt == 2)
                {
-                       if ((!strcmp(parameters[1],"+b")) || (!strcmp(parameters[1],"b")))
-                       {
+                       char* mode = parameters[1];
+                       if (*mode == '+')
+                               mode++;
+                       int MOD_RESULT = 0;
+                        FOREACH_RESULT(OnRawMode(user, Ptr, *mode, "", false, 0));
+                        if (!MOD_RESULT)
+                        {
+                               if (*mode == 'b')
+                               {
 
-                               for (BanList::iterator i = Ptr->bans.begin(); i != Ptr->bans.end(); i++)
+                                       for (BanList::iterator i = Ptr->bans.begin(); i != Ptr->bans.end(); i++)
+                                       {
+                                               WriteServ(user->fd,"367 %s %s %s %s %d",user->nick, Ptr->name, i->data, i->set_by, i->set_time);
+                                       }
+                                       WriteServ(user->fd,"368 %s %s :End of channel ban list",user->nick, Ptr->name);
+                                       return;
+                               }
+                               if ((ModeDefined(*mode,MT_CHANNEL)) && (ModeIsListMode(*mode,MT_CHANNEL)))
                                {
-                                       WriteServ(user->fd,"367 %s %s %s %s %d",user->nick, Ptr->name, i->data, i->set_by, i->set_time);
+                                       // list of items for an extmode
+                                       log(DEBUG,"Calling OnSendList for all modules, list output for mode %c",*mode);
+                                       FOREACH_MOD OnSendList(user,Ptr,*mode);
+                                       return;
                                }
-                               WriteServ(user->fd,"368 %s %s :End of channel ban list",user->nick, Ptr->name);
-                               return;
                        }
                }
 
-               if ((cstatus(user,Ptr) < STATUS_HOP) && (Ptr))
+                if ((Ptr) && (!has_channel(user,Ptr)))
+                {
+                        WriteServ(user->fd,"442 %s %s :You're not on that channel!",user->nick, Ptr->name);
+                        return;
+                }
+
+               if (Ptr)
                {
-                       WriteServ(user->fd,"482 %s %s :You must be at least a half-operator to change modes on this channel",user->nick, Ptr->name);
-                       return;
-               }
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT(OnAccessCheck(user,NULL,Ptr,AC_GENERAL_MODE));
+                       
+                       if (MOD_RESULT == ACR_DENY)
+                               return;
+                       if (MOD_RESULT == ACR_DEFAULT)
+                       {
+                               if (cstatus(user,Ptr) < STATUS_HOP)
+                               {
+                                       WriteServ(user->fd,"482 %s %s :You must be at least a half-operator to change modes on this channel",user->nick, Ptr->name);
+                                       return;
+                               }
+                       }
 
-               process_modes(parameters,user,Ptr,cstatus(user,Ptr),pcnt,false,false,false);
+                       process_modes(parameters,user,Ptr,cstatus(user,Ptr),pcnt,false,false,false);
+               }
        }
        else
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, parameters[0]);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, parameters[0]);
        }
 }
 
@@ -1275,7 +1561,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1289,10 +1575,11 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1302,13 +1589,16 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 
                for (int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1322,9 +1612,10 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1348,10 +1639,12 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, user, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
                                                        }
                                                }
                                        }
@@ -1369,8 +1662,9 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1379,20 +1673,20 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
-                       strcpy(b,"");
+                       strlcpy(b,"",MAXBUF);
                        int z = 0;
                        int i = 0;
                        while (i < strlen (outpars))
@@ -1419,17 +1713,19 @@ void server_mode(char **parameters, int pcnt, userrec *user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
+                       if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
 
-                       WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
-
-                       // M token for a usermode must go to all servers
-                       char buffer[MAXBUF];
-                       snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
-                       NetSendToAll(buffer);
+                       if (strcmp(b,""))
+                       {
+                               WriteTo(user, dest, "MODE %s :%s", dest->nick, b);
+                               // M token for a usermode must go to all servers
+                               char buffer[MAXBUF];
+                               snprintf(buffer,MAXBUF,"m %s %s %s",user->nick, dest->nick, b);
+                               NetSendToAll(buffer);
+                       }
                        
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1437,7 +1733,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }
 
@@ -1451,7 +1747,7 @@ void server_mode(char **parameters, int pcnt, userrec *user)
        }
        else
        {
-               WriteServ(user->fd,"401 %s %s :No suck nick/channel",user->nick, parameters[0]);
+               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, parameters[0]);
        }
 }
 
@@ -1461,7 +1757,7 @@ void merge_mode(char **parameters, int pcnt)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1475,10 +1771,11 @@ void merge_mode(char **parameters, int pcnt)
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
@@ -1488,13 +1785,16 @@ void merge_mode(char **parameters, int pcnt)
 
                for (int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1508,9 +1808,10 @@ void merge_mode(char **parameters, int pcnt)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1534,10 +1835,12 @@ void merge_mode(char **parameters, int pcnt)
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
                                                        }
                                                }
                                        }
@@ -1555,8 +1858,9 @@ void merge_mode(char **parameters, int pcnt)
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1565,17 +1869,17 @@ void merge_mode(char **parameters, int pcnt)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strcpy(b,"");
@@ -1605,7 +1909,7 @@ void merge_mode(char **parameters, int pcnt)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
                        if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
                                return;
@@ -1616,7 +1920,7 @@ void merge_mode(char **parameters, int pcnt)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
+                       strlcpy(dest->modes,dmodes,MAXMODES);
 
                }
 
@@ -1627,7 +1931,7 @@ void merge_mode(char **parameters, int pcnt)
        if (Ptr)
        {
                userrec s2;
-               strncpy(s2.nick,ServerName,NICKMAX);
+               strlcpy(s2.nick,ServerName,NICKMAX);
                strcpy(s2.modes,"o");
                s2.fd = -1;
                process_modes(parameters,&s2,Ptr,STATUS_OP,pcnt,true,true,false);
@@ -1639,7 +1943,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
 {
        chanrec* Ptr;
        userrec* dest;
-       int can_change,i;
+       int can_change;
        int direction = 1;
        char outpars[MAXBUF];
 
@@ -1648,31 +1952,40 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
        // fix: ChroNiCk found this - we cant use this as debug if its null!
        if (dest)
        {
-               log(DEBUG,"merge_mode on %s",dest->nick);
+               log(DEBUG,"merge_mode2 on %s",dest->nick);
        }
 
        if ((dest) && (pcnt > 1))
        {
-               log(DEBUG,"params > 1");
+                std::string tidied = compress_modes(parameters[1],false);
+                parameters[1] = (char*)tidied.c_str();
 
                char dmodes[MAXBUF];
-               strncpy(dmodes,dest->modes,MAXBUF);
+               strlcpy(dmodes,dest->modes,52);
 
                strcpy(outpars,"+");
                direction = 1;
 
+               if ((parameters[1][0] == ':') && (strlen(parameters[1])>1))
+               {
+                       // some stupid 3rd party things (such as services packages) put a colon on the mode list...
+                       log(DEBUG,"Some muppet put a colon on the modelist! changed to '%s'",++parameters[1]);
+               }
                if ((parameters[1][0] != '+') && (parameters[1][0] != '-'))
-                       return;
+               return;
 
                for (int i = 0; i < strlen(parameters[1]); i++)
                {
+                        if (parameters[1][i] == ' ')
+                                continue;
                        if (parameters[1][i] == '+')
                        {
                                if (direction != 1)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '+';
+                                               outpars[t] = '+';
                                        }
                                        else
                                        {
@@ -1686,9 +1999,10 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        {
                                if (direction != 0)
                                {
-                                       if ((outpars[strlen(outpars)-1] == '+') || (outpars[strlen(outpars)-1] == '-'))
+                                       int t = strlen(outpars)-1;
+                                       if ((outpars[t] == '+') || (outpars[t] == '-'))
                                        {
-                                               outpars[strlen(outpars)-1] = '-';
+                                               outpars[t] = '-';
                                        }
                                        else
                                        {
@@ -1712,10 +2026,13 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                        log(DEBUG,"umode %c is an allowed umode",umode);
                                                        if ((process_module_umode(umode, NULL, dest, direction)) || (umode == 'i') || (umode == 's') || (umode == 'w') || (umode == 'o'))
                                                        {
-                                                               dmodes[strlen(dmodes)+1]='\0';
-                                                               dmodes[strlen(dmodes)] = parameters[1][i];
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(dmodes);
+                                                               int v2 = strlen(outpars);
+                                                               dmodes[v1+1]='\0';
+                                                               dmodes[v1] = parameters[1][i];
+                                                               outpars[v2+1]='\0';
+                                                               outpars[v2] = parameters[1][i];
+                                                               log(DEBUG,"OUTPARS='%s', DMODES='%s'",outpars,dmodes);
                                                        }
                                                }
                                        }
@@ -1733,8 +2050,9 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                                char temp[MAXBUF];
                                                                char moo[MAXBUF];       
 
-                                                               outpars[strlen(outpars)+1]='\0';
-                                                               outpars[strlen(outpars)] = parameters[1][i];
+                                                               int v1 = strlen(outpars);
+                                                               outpars[v1+1]='\0';
+                                                               outpars[v1] = parameters[1][i];
                                                        
                                                                strcpy(temp,"");
                                                                for (q = 0; q < strlen(dmodes); q++)
@@ -1743,17 +2061,18 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                                                                        {
                                                                                moo[0] = dmodes[q];
                                                                                moo[1] = '\0';
-                                                                               strcat(temp,moo);
+                                                                               strlcat(temp,moo,MAXBUF);
                                                                        }
                                                                }
-                                                               strcpy(dmodes,temp);
+                                                               strlcpy(dmodes,temp,52);
                                                        }
                                                }
                                        }
                                }
                        }
                }
-               if (strlen(outpars))
+               log(DEBUG,"DONE! OUTPARS='%s', DMODES='%s'",outpars,dmodes);
+               if (outpars[0])
                {
                        char b[MAXBUF];
                        strcpy(b,"");
@@ -1783,12 +2102,17 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
 
                        z = strlen(b)-1;
                        if ((b[z] == '-') || (b[z] == '+'))
-                               b[z] == '\0';
+                               b[z] = '\0';
 
-                       if ((!strcmp(b,"+")) || (!strcmp(b,"-")))
-                               return;
 
-                       WriteTo(user,dest,"MODE :%s",b);
+                        if ((!b[0]) || (!strcmp(b,"+")) || (!strcmp(b,"-")))
+                                return;
+
+                        if (strcmp(b,""))
+                        {
+                               WriteTo(user,dest,"MODE %s :%s",dest->nick,b);
+                               log(DEBUG,"Sent: :%s MODE %s",user->nick,b);
+                       }
 
                        if (strlen(dmodes)>MAXMODES)
                        {
@@ -1796,8 +2120,7 @@ void merge_mode2(char **parameters, int pcnt, userrec* user)
                        }
                        log(DEBUG,"Stripped mode line");
                        log(DEBUG,"Line dest is now %s",dmodes);
-                       strncpy(dest->modes,dmodes,MAXMODES);
-
+                       strlcpy(dest->modes,dmodes,MAXMODES);
                }
 
                return;