Fix test client error cheecking on result types

[user/henk/code/inspircd.git] / src / modes / umode_i.cpp

diff --git a/src/modes/umode_i.cpp b/src/modes/umode_i.cpp
index 08af105cabbc3a05d0565dfdf2eab8f15fa3a808..584a12ff5af043d7f1088b08fe2f1f2122b93df6 100644 (file)
--- a/src/modes/umode_i.cpp
+++ b/src/modes/umode_i.cpp
@@ -12,14 +12,15 @@ ModeAction ModeUserInvisible::OnModeChange(userrec* source, userrec* dest, chanr
 {
        /* Only opers can change other users modes */
        if ((source != dest) && (!*source->oper))
-               return MODEACTION_ALLOW;
+               return MODEACTION_DENY;
 
        /* Set the bitfields */
-       adding ? dest->modebits |= UM_INVISIBLE : dest->modebits &= ~UM_INVISIBLE;
-
-       /* Use the bitfields to build the user's mode string */
-       ModeParser::BuildModeString(dest);
+       if (dest->modes[UM_INVISIBLE] != adding)
+       {
+               dest->modes[UM_INVISIBLE] = adding;
+               return MODEACTION_ALLOW;
+       }
 
        /* Allow the change */
-       return MODEACTION_ALLOW;
+       return MODEACTION_DENY;
 }