Add extra method to mode handler, ModeHandler::ModeSet().

[user/henk/code/inspircd.git] / src / modes / umode_s.cpp

diff --git a/src/modes/umode_s.cpp b/src/modes/umode_s.cpp
index a56e29034e04052b36a7e99cf7d0e39eee58a5cc..0c005f56a6d69bd93bf62eda56b7d0a7a9b3d1ae 100644 (file)
--- a/src/modes/umode_s.cpp
+++ b/src/modes/umode_s.cpp
@@ -12,14 +12,15 @@ ModeAction ModeUserServerNotice::OnModeChange(userrec* source, userrec* dest, ch
 {
        /* Only opers can change other users modes */
        if ((source != dest) && (!*source->oper))
-               return MODEACTION_ALLOW;
+               return MODEACTION_DENY;
 
        /* Set the bitfields */
-       adding ? dest->modebits |= UM_SERVERNOTICE : dest->modebits &= ~UM_SERVERNOTICE;
-
-       /* Use the bitfields to build the user's mode string */
-       ModeParser::BuildModeString(dest);
+       if (dest->modes[UM_SERVERNOTICE] != adding)
+       {
+               dest->modes[UM_SERVERNOTICE] = adding;
+               return MODEACTION_ALLOW;
+       }
 
        /* Allow the change */
-       return MODEACTION_ALLOW;
+       return MODEACTION_DENY;
 }