Fix typos

[user/henk/code/inspircd.git] / src / modes / umode_s.cpp

diff --git a/src/modes/umode_s.cpp b/src/modes/umode_s.cpp
index a56e29034e04052b36a7e99cf7d0e39eee58a5cc..4a5add907bf7a6ac0bb9c1b225da47874227da05 100644 (file)
--- a/src/modes/umode_s.cpp
+++ b/src/modes/umode_s.cpp
@@ -4,7 +4,7 @@
 #include "users.h"
 #include "modes/umode_s.h"
 
-ModeUserServerNotice::ModeUserServerNotice() : ModeHandler('s', 0, 0, false, MODETYPE_USER, false)
+ModeUserServerNotice::ModeUserServerNotice(InspIRCd* Instance) : ModeHandler(Instance, 's', 0, 0, false, MODETYPE_USER, false)
 {
 }
 
@@ -12,14 +12,15 @@ ModeAction ModeUserServerNotice::OnModeChange(userrec* source, userrec* dest, ch
 {
        /* Only opers can change other users modes */
        if ((source != dest) && (!*source->oper))
-               return MODEACTION_ALLOW;
+               return MODEACTION_DENY;
 
        /* Set the bitfields */
-       adding ? dest->modebits |= UM_SERVERNOTICE : dest->modebits &= ~UM_SERVERNOTICE;
-
-       /* Use the bitfields to build the user's mode string */
-       ModeParser::BuildModeString(dest);
+       if (dest->modes[UM_SERVERNOTICE] != adding)
+       {
+               dest->modes[UM_SERVERNOTICE] = adding;
+               return MODEACTION_ALLOW;
+       }
 
        /* Allow the change */
-       return MODEACTION_ALLOW;
+       return MODEACTION_DENY;
 }