]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_mysql.cpp
Switch from the Ubuntu 16.04 image to the 18.04 Ubuntu image.
[user/henk/code/inspircd.git] / src / modules / extra / m_mysql.cpp
index d965c88fb84cef1d0dc52e6113156cfc20ff8814..377ffee7e026e10553a93da519fdc7a79828c30f 100644 (file)
@@ -1,10 +1,17 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2019 linuxdaemon <linuxdaemon.irc@gmail.com>
+ *   Copyright (C) 2015 Daniel Vassdal <shutter@canternet.org>
+ *   Copyright (C) 2014, 2016 Adam <Adam@anope.org>
+ *   Copyright (C) 2013-2014 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2013, 2016-2020 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2012 Robby <robby@chatbelgie.be>
+ *   Copyright (C) 2012 ChrisTX <xpipe@hotmail.de>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2006-2007, 2009 Dennis Friis <peavey@inspircd.org>
- *   Copyright (C) 2006-2009 Craig Edwards <craigedwards@brainbox.cc>
- *   Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2009 Uli Schlachter <psychon@inspircd.org>
+ *   Copyright (C) 2007, 2009 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2005, 2008-2010 Craig Edwards <brain@inspircd.org>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
  * redistribute it and/or modify it under the terms of the GNU General Public
 /// $CompilerFlags: execute("mysql_config --include" "MYSQL_CXXFLAGS")
 /// $LinkerFlags: execute("mysql_config --libs_r" "MYSQL_LDFLAGS" "-lmysqlclient")
 
+/// $PackageInfo: require_system("arch") mariadb-libs
+/// $PackageInfo: require_system("centos" "6.0" "6.99") mysql-devel
+/// $PackageInfo: require_system("centos" "7.0") mariadb-devel
 /// $PackageInfo: require_system("darwin") mysql-connector-c
+/// $PackageInfo: require_system("debian") libmysqlclient-dev
 /// $PackageInfo: require_system("ubuntu") libmysqlclient-dev
 
+#ifdef __GNUC__
+# pragma GCC diagnostic push
+#endif
 
 // Fix warnings about the use of `long long` on C++03.
 #if defined __clang__
 #include <mysql.h>
 #include "modules/sql.h"
 
+#ifdef __GNUC__
+# pragma GCC diagnostic pop
+#endif
+
 #ifdef _WIN32
 # pragma comment(lib, "libmysql.lib")
 #endif
@@ -55,7 +73,7 @@
  * worker thread wakes up, and checks if there is a request at the head of its queue.
  * If there is, it processes this request, blocking the worker thread but leaving the ircd
  * thread to go about its business as usual. During this period, the ircd thread is able
- * to insert futher pending requests into the queue.
+ * to insert further pending requests into the queue.
  *
  * Once the processing of a request is complete, it is removed from the incoming queue to
  * an outgoing queue, and initialized as a 'response'. The worker thread then signals the
  * The ircd thread then mutexes the queue once more, reads the outbound response off the head
  * of the queue, and sends it on its way to the original calling module.
  *
- * XXX: You might be asking "why doesnt he just send the response from within the worker thread?"
+ * XXX: You might be asking "why doesnt it just send the response from within the worker thread?"
  * The answer to this is simple. The majority of InspIRCd, and in fact most ircd's are not
  * threadsafe. This module is designed to be threadsafe and is careful with its use of threads,
  * however, if we were to call a module's OnRequest even from within a thread which was not the
  * one the module was originally instantiated upon, there is a chance of all hell breaking loose
  * if a module is ever put in a re-enterant state (stack corruption could occur, crashes, data
  * corruption, and worse, so DONT think about it until the day comes when InspIRCd is 100%
- * gauranteed threadsafe!)
- *
- * For a diagram of this system please see http://wiki.inspircd.org/Mysql2
+ * guaranteed threadsafe!)
  */
 
 class SQLConnection;
 class MySQLresult;
 class DispatcherThread;
 
-struct QQueueItem
+struct QueryQueueItem
 {
-       SQLQuery* q;
-       std::string query;
-       SQLConnection* c;
-       QQueueItem(SQLQuery* Q, const std::string& S, SQLConnection* C) : q(Q), query(S), c(C) {}
+       // An SQL database which this query is executed on.
+       SQLConnection* connection;
+
+       // An object which handles the result of the query.
+       SQL::Query* query;
+
+       // The SQL query which is to be executed.
+       std::string querystr;
+
+       QueryQueueItem(SQL::Query* q, const std::string& s, SQLConnection* c)
+               : connection(c)
+               , query(q)
+               , querystr(s)
+       {
+       }
 };
 
-struct RQueueItem
+struct ResultQueueItem
 {
-       SQLQuery* q;
-       MySQLresult* r;
-       RQueueItem(SQLQuery* Q, MySQLresult* R) : q(Q), r(R) {}
+       // An object which handles the result of the query.
+       SQL::Query* query;
+
+       // The result returned from executing the MySQL query.
+       MySQLresult* result;
+
+       ResultQueueItem(SQL::Query* q, MySQLresult* r)
+               : query(q)
+               , result(r)
+       {
+       }
 };
 
 typedef insp::flat_map<std::string, SQLConnection*> ConnMap;
-typedef std::deque<QQueueItem> QueryQueue;
-typedef std::deque<RQueueItem> ResultQueue;
+typedef std::deque<QueryQueueItem> QueryQueue;
+typedef std::deque<ResultQueueItem> ResultQueue;
 
 /** MySQL module
  *  */
@@ -125,26 +160,25 @@ class DispatcherThread : public SocketThread
  public:
        DispatcherThread(ModuleSQL* CreatorModule) : Parent(CreatorModule) { }
        ~DispatcherThread() { }
-       void Run();
-       void OnNotify();
+       void Run() CXX11_OVERRIDE;
+       void OnNotify() CXX11_OVERRIDE;
 };
 
-#if !defined(MYSQL_VERSION_ID) || MYSQL_VERSION_ID<32224
-#define mysql_field_count mysql_num_fields
-#endif
-
 /** Represents a mysql result set
  */
-class MySQLresult : public SQLResult
+class MySQLresult : public SQL::Result
 {
  public:
-       SQLerror err;
+       SQL::Error err;
        int currentrow;
        int rows;
        std::vector<std::string> colnames;
-       std::vector<SQLEntries> fieldlists;
+       std::vector<SQL::Row> fieldlists;
 
-       MySQLresult(MYSQL_RES* res, int affected_rows) : err(SQL_NO_ERROR), currentrow(0), rows(0)
+       MySQLresult(MYSQL_RES* res, int affected_rows)
+               : err(SQL::SUCCESS)
+               , currentrow(0)
+               , rows(0)
        {
                if (affected_rows >= 1)
                {
@@ -173,9 +207,9 @@ class MySQLresult : public SQLResult
                                        {
                                                std::string a = (fields[field_count].name ? fields[field_count].name : "");
                                                if (row[field_count])
-                                                       fieldlists[n].push_back(SQLEntry(row[field_count]));
+                                                       fieldlists[n].push_back(SQL::Field(row[field_count]));
                                                else
-                                                       fieldlists[n].push_back(SQLEntry());
+                                                       fieldlists[n].push_back(SQL::Field());
                                                colnames.push_back(a);
                                                field_count++;
                                        }
@@ -187,31 +221,47 @@ class MySQLresult : public SQLResult
                }
        }
 
-       MySQLresult(SQLerror& e) : err(e)
+       MySQLresult(SQL::Error& e)
+               : err(e)
+               , currentrow(0)
+               , rows(0)
        {
 
        }
 
-       int Rows()
+       int Rows() CXX11_OVERRIDE
        {
                return rows;
        }
 
-       void GetCols(std::vector<std::string>& result)
+       void GetCols(std::vector<std::string>& result) CXX11_OVERRIDE
        {
                result.assign(colnames.begin(), colnames.end());
        }
 
-       SQLEntry GetValue(int row, int column)
+       bool HasColumn(const std::string& column, size_t& index) CXX11_OVERRIDE
+       {
+               for (size_t i = 0; i < colnames.size(); ++i)
+               {
+                       if (colnames[i] == column)
+                       {
+                               index = i;
+                               return true;
+                       }
+               }
+               return false;
+       }
+
+       SQL::Field GetValue(int row, int column)
        {
                if ((row >= 0) && (row < rows) && (column >= 0) && (column < (int)fieldlists[row].size()))
                {
                        return fieldlists[row][column];
                }
-               return SQLEntry();
+               return SQL::Field();
        }
 
-       bool GetRow(SQLEntries& result)
+       bool GetRow(SQL::Row& result) CXX11_OVERRIDE
        {
                if (currentrow < rows)
                {
@@ -229,50 +279,92 @@ class MySQLresult : public SQLResult
 
 /** Represents a connection to a mysql database
  */
-class SQLConnection : public SQLProvider
+class SQLConnection : public SQL::Provider
 {
+ private:
+       bool EscapeString(SQL::Query* query, const std::string& in, std::string& out)
+       {
+               // In the worst case each character may need to be encoded as using two bytes and one
+               // byte is the NUL terminator.
+               std::vector<char> buffer(in.length() * 2 + 1);
+
+               // The return value of mysql_escape_string() is either an error or the length of the
+               // encoded string not including the NUL terminator.
+               //
+               // Unfortunately, someone genius decided that mysql_escape_string should return an
+               // unsigned type even though -1 is returned on error so checking whether an error
+               // happened is a bit cursed.
+               unsigned long escapedsize = mysql_escape_string(&buffer[0], in.c_str(), in.length());
+               if (escapedsize == static_cast<unsigned long>(-1))
+               {
+                       SQL::Error err(SQL::QSEND_FAIL, InspIRCd::Format("%u: %s", mysql_errno(connection), mysql_error(connection)));
+                       query->OnError(err);
+                       return false;
+               }
+
+               out.append(&buffer[0], escapedsize);
+               return true;
+       }
+
  public:
        reference<ConfigTag> config;
        MYSQL *connection;
        Mutex lock;
 
        // This constructor creates an SQLConnection object with the given credentials, but does not connect yet.
-       SQLConnection(Module* p, ConfigTag* tag) : SQLProvider(p, "SQL/" + tag->getString("id")),
-               config(tag), connection(NULL)
+       SQLConnection(Module* p, ConfigTag* tag)
+               : SQL::Provider(p, tag->getString("id"))
+               , config(tag)
+               , connection(NULL)
        {
        }
 
        ~SQLConnection()
        {
-               Close();
+               mysql_close(connection);
        }
 
        // This method connects to the database using the credentials supplied to the constructor, and returns
        // true upon success.
        bool Connect()
        {
-               unsigned int timeout = 1;
                connection = mysql_init(connection);
-               mysql_options(connection,MYSQL_OPT_CONNECT_TIMEOUT,(char*)&timeout);
-               std::string host = config->getString("host");
-               std::string user = config->getString("user");
-               std::string pass = config->getString("pass");
-               std::string dbname = config->getString("name");
-               int port = config->getInt("port");
-               bool rv = mysql_real_connect(connection, host.c_str(), user.c_str(), pass.c_str(), dbname.c_str(), port, NULL, 0);
-               if (!rv)
-                       return rv;
-
-               // Enable character set settings
-               std::string charset = config->getString("charset");
-               if ((!charset.empty()) && (mysql_set_character_set(connection, charset.c_str())))
-                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "WARNING: Could not set character set to \"%s\"", charset.c_str());
-
-               std::string initquery;
-               if (config->readString("initialquery", initquery))
+
+               // Set the connection timeout.
+               unsigned int timeout = config->getDuration("timeout", 5, 1, 30);
+               mysql_options(connection, MYSQL_OPT_CONNECT_TIMEOUT, &timeout);
+
+               // Attempt to connect to the database.
+               const std::string host = config->getString("host");
+               const std::string user = config->getString("user");
+               const std::string pass = config->getString("pass");
+               const std::string dbname = config->getString("name");
+               unsigned int port = config->getUInt("port", 3306, 1, 65535);
+               if (!mysql_real_connect(connection, host.c_str(), user.c_str(), pass.c_str(), dbname.c_str(), port, NULL, CLIENT_IGNORE_SIGPIPE))
+               {
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Unable to connect to the %s MySQL server: %s",
+                               GetId().c_str(), mysql_error(connection));
+                       return false;
+               }
+
+               // Set the default character set.
+               const std::string charset = config->getString("charset");
+               if (!charset.empty() && mysql_set_character_set(connection, charset.c_str()))
                {
-                       mysql_query(connection,initquery.c_str());
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Could not set character set for %s to \"%s\": %s",
+                               GetId().c_str(), charset.c_str(), mysql_error(connection));
+                       return false;
                }
+
+               // Execute the initial SQL query.
+               const std::string initialquery = config->getString("initialquery");
+               if (!initialquery.empty() && mysql_real_query(connection, initialquery.data(), initialquery.length()))
+               {
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Could not execute initial query \"%s\" for %s: %s",
+                               initialquery.c_str(), name.c_str(), mysql_error(connection));
+                       return false;
+               }
+
                return true;
        }
 
@@ -287,7 +379,7 @@ class SQLConnection : public SQLProvider
                /* Parse the command string and dispatch it to mysql */
                if (CheckConnection() && !mysql_real_query(connection, query.data(), query.length()))
                {
-                       /* Successfull query */
+                       /* Successful query */
                        MYSQL_RES* res = mysql_use_result(connection);
                        unsigned long rows = mysql_affected_rows(connection);
                        return new MySQLresult(res, rows);
@@ -296,7 +388,7 @@ class SQLConnection : public SQLProvider
                {
                        /* XXX: See /usr/include/mysql/mysqld_error.h for a list of
                         * possible error numbers and error messages */
-                       SQLerror e(SQL_QREPLY_FAIL, ConvToStr(mysql_errno(connection)) + ": " + mysql_error(connection));
+                       SQL::Error e(SQL::QREPLY_FAIL, InspIRCd::Format("%u: %s", mysql_errno(connection), mysql_error(connection)));
                        return new MySQLresult(e);
                }
        }
@@ -308,24 +400,15 @@ class SQLConnection : public SQLProvider
                return true;
        }
 
-       std::string GetError()
-       {
-               return mysql_error(connection);
-       }
-
-       void Close()
-       {
-               mysql_close(connection);
-       }
-
-       void submit(SQLQuery* q, const std::string& qs)
+       void Submit(SQL::Query* q, const std::string& qs) CXX11_OVERRIDE
        {
+               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Executing MySQL query: " + qs);
                Parent()->Dispatcher->LockQueue();
-               Parent()->qq.push_back(QQueueItem(q, qs, this));
+               Parent()->qq.push_back(QueryQueueItem(q, qs, this));
                Parent()->Dispatcher->UnlockQueueWakeup();
        }
 
-       void submit(SQLQuery* call, const std::string& q, const ParamL& p)
+       void Submit(SQL::Query* call, const std::string& q, const SQL::ParamList& p) CXX11_OVERRIDE
        {
                std::string res;
                unsigned int param = 0;
@@ -333,27 +416,13 @@ class SQLConnection : public SQLProvider
                {
                        if (q[i] != '?')
                                res.push_back(q[i]);
-                       else
-                       {
-                               if (param < p.size())
-                               {
-                                       std::string parm = p[param++];
-                                       // In the worst case, each character may need to be encoded as using two bytes,
-                                       // and one byte is the terminating null
-                                       std::vector<char> buffer(parm.length() * 2 + 1);
-
-                                       // The return value of mysql_escape_string() is the length of the encoded string,
-                                       // not including the terminating null
-                                       unsigned long escapedsize = mysql_escape_string(&buffer[0], parm.c_str(), parm.length());
-//                                     mysql_real_escape_string(connection, queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length());
-                                       res.append(&buffer[0], escapedsize);
-                               }
-                       }
+                       else if (param < p.size() && !EscapeString(call, p[param++], res))
+                               return;
                }
-               submit(call, res);
+               Submit(call, res);
        }
 
-       void submit(SQLQuery* call, const std::string& q, const ParamM& p)
+       void Submit(SQL::Query* call, const std::string& q, const SQL::ParamMap& p) CXX11_OVERRIDE
        {
                std::string res;
                for(std::string::size_type i = 0; i < q.length(); i++)
@@ -368,28 +437,25 @@ class SQLConnection : public SQLProvider
                                        field.push_back(q[i++]);
                                i--;
 
-                               ParamM::const_iterator it = p.find(field);
-                               if (it != p.end())
-                               {
-                                       std::string parm = it->second;
-                                       // NOTE: See above
-                                       std::vector<char> buffer(parm.length() * 2 + 1);
-                                       unsigned long escapedsize = mysql_escape_string(&buffer[0], parm.c_str(), parm.length());
-                                       res.append(&buffer[0], escapedsize);
-                               }
+                               SQL::ParamMap::const_iterator it = p.find(field);
+                               if (it != p.end() && !EscapeString(call, it->second, res))
+                                       return;
                        }
                }
-               submit(call, res);
+               Submit(call, res);
        }
 };
 
 ModuleSQL::ModuleSQL()
+       : Dispatcher(NULL)
 {
-       Dispatcher = NULL;
 }
 
 void ModuleSQL::init()
 {
+       if (mysql_library_init(0, NULL, NULL))
+               throw ModuleException("Unable to initialise the MySQL library!");
+
        Dispatcher = new DispatcherThread(this);
        ServerInstance->Threads.Start(Dispatcher);
 }
@@ -402,10 +468,13 @@ ModuleSQL::~ModuleSQL()
                Dispatcher->OnNotify();
                delete Dispatcher;
        }
+
        for(ConnMap::iterator i = connections.begin(); i != connections.end(); i++)
        {
                delete i->second;
        }
+
+       mysql_library_end();
 }
 
 void ModuleSQL::ReadConfig(ConfigStatus& status)
@@ -414,7 +483,7 @@ void ModuleSQL::ReadConfig(ConfigStatus& status)
        ConfigTagList tags = ServerInstance->Config->ConfTags("database");
        for(ConfigIter i = tags.first; i != tags.second; i++)
        {
-               if (i->second->getString("module", "mysql") != "mysql")
+               if (!stdalgo::string::equalsci(i->second->getString("module"), "mysql"))
                        continue;
                std::string id = i->second->getString("id");
                ConnMap::iterator curr = connections.find(id);
@@ -433,7 +502,7 @@ void ModuleSQL::ReadConfig(ConfigStatus& status)
 
        // now clean up the deleted databases
        Dispatcher->LockQueue();
-       SQLerror err(SQL_BAD_DBID);
+       SQL::Error err(SQL::BAD_DBID);
        for(ConnMap::iterator i = connections.begin(); i != connections.end(); i++)
        {
                ServerInstance->Modules->DelService(*i->second);
@@ -444,10 +513,10 @@ void ModuleSQL::ReadConfig(ConfigStatus& status)
                for (size_t j = qq.size(); j > 0; j--)
                {
                        size_t k = j - 1;
-                       if (qq[k].c == i->second)
+                       if (qq[k].connection == i->second)
                        {
-                               qq[k].q->OnError(err);
-                               delete qq[k].q;
+                               qq[k].query->OnError(err);
+                               delete qq[k].query;
                                qq.erase(qq.begin() + k);
                        }
                }
@@ -460,23 +529,23 @@ void ModuleSQL::ReadConfig(ConfigStatus& status)
 
 void ModuleSQL::OnUnloadModule(Module* mod)
 {
-       SQLerror err(SQL_BAD_DBID);
+       SQL::Error err(SQL::BAD_DBID);
        Dispatcher->LockQueue();
        unsigned int i = qq.size();
        while (i > 0)
        {
                i--;
-               if (qq[i].q->creator == mod)
+               if (qq[i].query->creator == mod)
                {
                        if (i == 0)
                        {
                                // need to wait until the query is done
                                // (the result will be discarded)
-                               qq[i].c->lock.Lock();
-                               qq[i].c->lock.Unlock();
+                               qq[i].connection->lock.Lock();
+                               qq[i].connection->lock.Unlock();
                        }
-                       qq[i].q->OnError(err);
-                       delete qq[i].q;
+                       qq[i].query->OnError(err);
+                       delete qq[i].query;
                        qq.erase(qq.begin() + i);
                }
        }
@@ -487,7 +556,7 @@ void ModuleSQL::OnUnloadModule(Module* mod)
 
 Version ModuleSQL::GetVersion()
 {
-       return Version("MySQL support", VF_VENDOR);
+       return Version("Provides the ability for SQL modules to query a MySQL database.", VF_VENDOR);
 }
 
 void DispatcherThread::Run()
@@ -497,23 +566,23 @@ void DispatcherThread::Run()
        {
                if (!Parent->qq.empty())
                {
-                       QQueueItem i = Parent->qq.front();
-                       i.c->lock.Lock();
+                       QueryQueueItem i = Parent->qq.front();
+                       i.connection->lock.Lock();
                        this->UnlockQueue();
-                       MySQLresult* res = i.c->DoBlockingQuery(i.query);
-                       i.c->lock.Unlock();
+                       MySQLresult* res = i.connection->DoBlockingQuery(i.querystr);
+                       i.connection->lock.Unlock();
 
                        /*
                         * At this point, the main thread could be working on:
-                        *  Rehash - delete i.c out from under us. We don't care about that.
-                        *  UnloadModule - delete i.q and the qq item. Need to avoid reporting results.
+                        *  Rehash - delete i.connection out from under us. We don't care about that.
+                        *  UnloadModule - delete i.query and the qq item. Need to avoid reporting results.
                         */
 
                        this->LockQueue();
-                       if (!Parent->qq.empty() && Parent->qq.front().q == i.q)
+                       if (!Parent->qq.empty() && Parent->qq.front().query == i.query)
                        {
                                Parent->qq.pop_front();
-                               Parent->rq.push_back(RQueueItem(i.q, res));
+                               Parent->rq.push_back(ResultQueueItem(i.query, res));
                                NotifyParent();
                        }
                        else
@@ -539,13 +608,13 @@ void DispatcherThread::OnNotify()
        this->LockQueue();
        for(ResultQueue::iterator i = Parent->rq.begin(); i != Parent->rq.end(); i++)
        {
-               MySQLresult* res = i->r;
-               if (res->err.id == SQL_NO_ERROR)
-                       i->q->OnResult(*res);
+               MySQLresult* res = i->result;
+               if (res->err.code == SQL::SUCCESS)
+                       i->query->OnResult(*res);
                else
-                       i->q->OnError(res->err);
-               delete i->q;
-               delete i->r;
+                       i->query->OnError(res->err);
+               delete i->query;
+               delete i->result;
        }
        Parent->rq.clear();
        this->UnlockQueue();