* | Inspire Internet Relay Chat Daemon |
* +------------------------------------+
*
- * InspIRCd: (C) 2002-2008 InspIRCd Development Team
+ * InspIRCd: (C) 2002-2009 InspIRCd Development Team
* See: http://www.inspircd.org/wiki/index.php/Credits
*
* This program is free but copyrighted software; see
#include "inspircd.h"
#include <mysql.h>
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
#include "m_sqlv2.h"
#ifdef WINDOWS
class DispatcherThread;
+unsigned long count(const char * const str, char a)
+{
+ unsigned long n = 0;
+ for (const char *p = reinterpret_cast<const char *>(str); *p; ++p)
+ {
+ if (*p == '?')
+ ++n;
+ }
+ return n;
+}
+
+
/** MySQL module
* */
class ModuleSQL : public Module
rows++;
}
mysql_free_result(res);
+ res = NULL;
}
}
class SQLConnection : public classbase
{
protected:
-
- MYSQL connection;
+ MYSQL *connection;
MYSQL_RES *res;
- MYSQL_ROW row;
+ MYSQL_ROW *row;
SQLhost host;
std::map<std::string,std::string> thisrow;
bool Enabled;
ResultQueue rq;
// This constructor creates an SQLConnection object with the given credentials, but does not connect yet.
- SQLConnection(const SQLhost &hi, ModuleSQL* Creator) : host(hi), Enabled(false), Parent(Creator)
+ SQLConnection(const SQLhost &hi, ModuleSQL* Creator) : connection(NULL), host(hi), Enabled(false), Parent(Creator)
{
}
bool Connect()
{
unsigned int timeout = 1;
- mysql_init(&connection);
- mysql_options(&connection,MYSQL_OPT_CONNECT_TIMEOUT,(char*)&timeout);
- return mysql_real_connect(&connection, host.host.c_str(), host.user.c_str(), host.pass.c_str(), host.name.c_str(), host.port, NULL, 0);
+ connection = mysql_init(connection);
+ mysql_options(connection,MYSQL_OPT_CONNECT_TIMEOUT,(char*)&timeout);
+ return mysql_real_connect(connection, host.host.c_str(), host.user.c_str(), host.pass.c_str(), host.name.c_str(), host.port, NULL, 0);
}
void DoLeadingQuery()
char* queryend;
/* Total length of the unescaped parameters */
- unsigned long paramlen;
-
- /* Total length of query, used for binary-safety in mysql_real_query */
- unsigned long querylength = 0;
+ unsigned long maxparamlen, paramcount;
- paramlen = 0;
+ /* The length of the longest parameter */
+ maxparamlen = 0;
for(ParamL::iterator i = req.query.p.begin(); i != req.query.p.end(); i++)
{
- paramlen += i->size();
+ if (i->size() > maxparamlen)
+ maxparamlen = i->size();
}
+ /* How many params are there in the query? */
+ paramcount = count(req.query.q.c_str(), '?');
+
+ /* This stores copy of params to be inserted with using numbered params 1;3B*/
+ ParamL paramscopy(req.query.p);
+
/* To avoid a lot of allocations, allocate enough memory for the biggest the escaped query could possibly be.
- * sizeofquery + (totalparamlength*2) + 1
+ * sizeofquery + (maxtotalparamlength*2) + 1
*
* The +1 is for null-terminating the string for mysql_real_escape_string
*/
- query = new char[req.query.q.length() + (paramlen*2) + 1];
+ query = new char[req.query.q.length() + (maxparamlen*paramcount*2) + 1];
queryend = query;
/* Okay, now we have a buffer large enough we need to start copying the query into it and escaping and substituting
* then we "just" need to make sure queryend is
* pointing at the right place.
*/
- if(req.query.p.size())
+
+ /* Is it numbered parameter?
+ */
+
+ bool numbered;
+ numbered = false;
+
+ /* Numbered parameter number :|
+ */
+ unsigned int paramnum;
+ paramnum = 0;
+
+ /* Let's check if it's a numbered param. And also calculate it's number.
+ */
+
+ while ((i < req.query.q.length() - 1) && (req.query.q[i+1] >= '0') && (req.query.q[i+1] <= '9'))
+ {
+ numbered = true;
+ ++i;
+ paramnum = paramnum * 10 + req.query.q[i] - '0';
+ }
+
+ if (paramnum > paramscopy.size() - 1)
{
- unsigned long len = mysql_real_escape_string(&connection, queryend, req.query.p.front().c_str(), req.query.p.front().length());
+ /* index is out of range!
+ */
+ numbered = false;
+ }
+
+ if (numbered)
+ {
+ unsigned long len = mysql_real_escape_string(connection, queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length());
+
+ queryend += len;
+ }
+ else if (req.query.p.size())
+ {
+ unsigned long len = mysql_real_escape_string(connection, queryend, req.query.p.front().c_str(), req.query.p.front().length());
queryend += len;
req.query.p.pop_front();
*queryend = req.query.q[i];
queryend++;
}
- querylength++;
}
*queryend = 0;
req.query.q = query;
Parent->QueueMutex->Unlock();
- if (!mysql_real_query(&connection, req.query.q.data(), req.query.q.length()))
+ if (!mysql_real_query(connection, req.query.q.data(), req.query.q.length()))
{
/* Successfull query */
- res = mysql_use_result(&connection);
- unsigned long rows = mysql_affected_rows(&connection);
+ res = mysql_use_result(connection);
+ unsigned long rows = mysql_affected_rows(connection);
MySQLresult* r = new MySQLresult(Parent, req.GetSource(), res, rows, req.id);
r->dbid = this->GetID();
r->query = req.query.q;
{
/* XXX: See /usr/include/mysql/mysqld_error.h for a list of
* possible error numbers and error messages */
- SQLerror e(SQL_QREPLY_FAIL, ConvToStr(mysql_errno(&connection)) + std::string(": ") + mysql_error(&connection));
+ SQLerror e(SQL_QREPLY_FAIL, ConvToStr(mysql_errno(connection)) + std::string(": ") + mysql_error(connection));
MySQLresult* r = new MySQLresult(Parent, req.GetSource(), e, req.id);
r->dbid = this->GetID();
r->query = req.query.q;
bool ConnectionLost()
{
- if (&connection) {
- return (mysql_ping(&connection) != 0);
+ if (&connection)
+ {
+ return (mysql_ping(connection) != 0);
}
else return false;
}
bool CheckConnection()
{
- if (ConnectionLost()) {
+ if (ConnectionLost())
+ {
return Connect();
}
else return true;
std::string GetError()
{
- return mysql_error(&connection);
+ return mysql_error(connection);
}
const std::string& GetID()
void Close()
{
- mysql_close(&connection);
+ mysql_close(connection);
}
const SQLhost& GetConfHost()
* back into an iterator.
*/
- if (Instance->SE->Recv(this, &data, 1, 0) > 0)
+ if (ServerInstance->SE->Recv(this, &data, 1, 0) > 0)
{
Parent->ConnMutex->Lock();
ConnMap::iterator iter = GetCharId(data);
+ Parent->ConnMutex->Unlock();
if (iter != Connections.end())
{
- /* Lock the mutex, send back the data */
Parent->ResultsMutex->Lock();
ResultQueue::iterator n = iter->second->rq.begin();
+ Parent->ResultsMutex->Unlock();
+
(*n)->Send();
delete (*n);
+
+ Parent->ResultsMutex->Lock();
iter->second->rq.pop_front();
Parent->ResultsMutex->Unlock();
- Parent->ConnMutex->Unlock();
+
return true;
}
/* No error, but unknown id */
- Parent->ConnMutex->Unlock();
return true;
}
class MySQLListener : public ListenSocketBase
{
ModuleSQL* Parent;
- insp_sockaddr sock_us;
+ irc::sockets::insp_sockaddr sock_us;
socklen_t uslen;
FileReader* index;
virtual void OnAcceptReady(const std::string &ipconnectedto, int nfd, const std::string &incomingip)
{
- new Notifier(this->Parent, this->ServerInstance, nfd, (char *)ipconnectedto.c_str()); // XXX unsafe casts suck
+ // XXX unsafe casts suck
+ new Notifier(this->Parent, this->ServerInstance, nfd, (char *)ipconnectedto.c_str());
}
/* Using getsockname and ntohs, we can determine which port number we were allocated */
if (MessagePipe->GetFd() == -1)
{
delete ConnMutex;
+ ServerInstance->Modules->DoneWithInterface("SQLutils");
throw ModuleException("m_mysql: unable to create ITC pipe");
}
else
{
- Parent->LoggingMutex->Lock();
+ LoggingMutex->Lock();
ServerInstance->Logs->Log("m_mysql", DEBUG, "MySQL: Interthread comms port is %d", MessagePipe->GetPort());
- Parent->LoggingMutex->Unlock();
+ LoggingMutex->Unlock();
}
Dispatcher = new DispatcherThread(ServerInstance, this);
/* Tell worker thread to exit NOW,
* Automatically joins */
delete Dispatcher;
+ delete LoggingMutex;
+ delete ResultsMutex;
+ delete QueueMutex;
+ delete ConnMutex;
+ ServerInstance->Modules->DoneWithInterface("SQLutils");
throw ModuleException("m_mysql: Unable to publish feature 'SQL'");
}
const char* returnval = NULL;
- Parent->ConnMutex->Lock();
+ ConnMutex->Lock();
if((iter = Connections.find(req->dbid)) != Connections.end())
{
req->id = NewID();
req->error.Id(SQL_BAD_DBID);
}
- Parent->ConnMutex->Unlock();
+ ConnMutex->Unlock();
QueueMutex->Unlock();
return returnval;
return;
}
- insp_sockaddr addr;
+ irc::sockets::insp_sockaddr addr;
#ifdef IPV6
- insp_aton("::1", &addr.sin6_addr);
+ irc::sockets::insp_aton("::1", &addr.sin6_addr);
addr.sin6_family = AF_FAMILY;
addr.sin6_port = htons(MessagePipe->GetPort());
#else
- insp_inaddr ia;
- insp_aton("127.0.0.1", &ia);
+ irc::sockets::insp_inaddr ia;
+ irc::sockets::insp_aton("127.0.0.1", &ia);
addr.sin_family = AF_FAMILY;
addr.sin_addr = ia;
addr.sin_port = htons(MessagePipe->GetPort());
}
}
-MODULE_INIT(ModuleSQL)
+MODULE_INIT(ModuleSQL)
projects / user / henk / code / inspircd.git / blobdiff