]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_mysql.cpp
Removed extremely verbose debugging from the SSL modules, as I believe that bug has...
[user/henk/code/inspircd.git] / src / modules / extra / m_mysql.cpp
index 7451824bf7e216f6631f86408f001d376715c8ec..a78e8c61b0a5253067bc8cd08a7bc2df2d1751e2 100644 (file)
  * ---------------------------------------------------
  */
 
-#include <stdio.h>
-#include <string>
+#include "inspircd.h"
 #include <mysql.h>
 #include <pthread.h>
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-#include "inspircd.h"
 #include "m_sqlv2.h"
 
 /* VERSION 2 API: With nonblocking (threaded) requests */
@@ -80,116 +78,6 @@ int QueueFD = -1;
 
 typedef std::deque<SQLresult*> ResultQueue;
 
-/** Represents a mysql query queue
- */
-class QueryQueue : public classbase
-{
-private:
-       typedef std::deque<SQLrequest> ReqDeque;
-
-       ReqDeque priority;      /* The priority queue */
-       ReqDeque normal;        /* The 'normal' queue */
-       enum { PRI, NOR, NON } which;   /* Which queue the currently active element is at the front of */
-
-public:
-       QueryQueue()
-       : which(NON)
-       {
-       }
-
-       void push(const SQLrequest &q)
-       {
-               if(q.pri)
-                       priority.push_back(q);
-               else
-                       normal.push_back(q);
-       }
-
-       void pop()
-       {
-               if((which == PRI) && priority.size())
-               {
-                       priority.pop_front();
-               }
-               else if((which == NOR) && normal.size())
-               {
-                       normal.pop_front();
-               }
-
-               /* Reset this */
-               which = NON;
-
-               /* Silently do nothing if there was no element to pop() */
-       }
-
-       SQLrequest& front()
-       {
-               switch(which)
-               {
-                       case PRI:
-                               return priority.front();
-                       case NOR:
-                               return normal.front();
-                       default:
-                               if(priority.size())
-                               {
-                                       which = PRI;
-                                       return priority.front();
-                               }
-
-                               if(normal.size())
-                               {
-                                       which = NOR;
-                                       return normal.front();
-                               }
-
-                               /* This will probably result in a segfault,
-                                * but the caller should have checked totalsize()
-                                * first so..meh - moron :p
-                                */
-
-                               return priority.front();
-               }
-       }
-
-       std::pair<int, int> size()
-       {
-               return std::make_pair(priority.size(), normal.size());
-       }
-
-       int totalsize()
-       {
-               return priority.size() + normal.size();
-       }
-
-       void PurgeModule(Module* mod)
-       {
-               DoPurgeModule(mod, priority);
-               DoPurgeModule(mod, normal);
-       }
-
-private:
-       void DoPurgeModule(Module* mod, ReqDeque& q)
-       {
-               for(ReqDeque::iterator iter = q.begin(); iter != q.end(); iter++)
-               {
-                       if(iter->GetSource() == mod)
-                       {
-                               if(iter->id == front().id)
-                               {
-                                       /* It's the currently active query.. :x */
-                                       iter->SetSource(NULL);
-                               }
-                               else
-                               {
-                                       /* It hasn't been executed yet..just remove it */
-                                       iter = q.erase(iter);
-                               }
-                       }
-               }
-       }
-};
-
 /* A mutex to wrap around queue accesses */
 pthread_mutex_t queue_mutex = PTHREAD_MUTEX_INITIALIZER;
 
@@ -202,7 +90,6 @@ pthread_mutex_t logging_mutex = PTHREAD_MUTEX_INITIALIZER;
 class MySQLresult : public SQLresult
 {
        int currentrow;
-       //std::vector<std::map<std::string,std::string> > results;
        std::vector<std::string> colnames;
        std::vector<SQLfieldList> fieldlists;
        SQLfieldMap* fieldmap;
@@ -687,6 +574,30 @@ void LoadDatabases(ConfigReader* conf, InspIRCd* ServerInstance)
        ConnectDatabases(ServerInstance);
 }
 
+char FindCharId(const std::string &id)
+{
+       char i = 1;
+       for (ConnMap::iterator iter = Connections.begin(); iter != Connections.end(); ++iter, ++i)
+       {
+               if (iter->first == id)
+               {
+                       return i;
+               }
+       }
+       return 0;
+}
+
+ConnMap::iterator GetCharId(char id)
+{
+       char i = 1;
+       for (ConnMap::iterator iter = Connections.begin(); iter != Connections.end(); ++iter, ++i)
+       {
+               if (i == id)
+                       return iter;
+       }
+       return Connections.end();
+}
+
 void NotifyMainThread(SQLConnection* connection_with_new_result)
 {
        /* Here we write() to the socket the main thread has open
@@ -697,8 +608,16 @@ void NotifyMainThread(SQLConnection* connection_with_new_result)
         * thread, we can just use standard connect(), and we can
         * block if we like. We just send the connection id of the
         * connection back.
+        *
+        * NOTE: We only send a single char down the connection, this
+        * way we know it wont get a partial read at the other end if
+        * the system is especially congested (see bug #263).
+        * The function FindCharId translates a connection name into a
+        * one character id, and GetCharId translates a character id
+        * back into an iterator.
         */
-       send(QueueFD, connection_with_new_result->GetID().c_str(), connection_with_new_result->GetID().length()+1, 0);
+       char id = FindCharId(connection_with_new_result->GetID());
+       send(QueueFD, &id, 1, 0);
 }
 
 void* DispatcherThread(void* arg);
@@ -750,13 +669,17 @@ class Notifier : public InspSocket
 
        virtual bool OnDataReady()
        {
-               char* data = this->Read();
-               ConnMap::iterator iter;
-
-               if (data && *data)
+               char data = 0;
+               /* NOTE: Only a single character is read so we know we
+                * cant get a partial read. (We've been told that theres
+                * data waiting, so we wont ever get EAGAIN)
+                * The function GetCharId translates a single character
+                * back into an iterator.
+                */
+               if (Instance->SE->Recv(this, &data, 1, 0) > 0)
                {
-                       /* We expect to be sent a null terminated string */
-                       if((iter = Connections.find(data)) != Connections.end())
+                       ConnMap::iterator iter = GetCharId(data);
+                       if (iter != Connections.end())
                        {
                                /* Lock the mutex, send back the data */
                                pthread_mutex_lock(&results_mutex);
@@ -766,8 +689,11 @@ class Notifier : public InspSocket
                                pthread_mutex_unlock(&results_mutex);
                                return true;
                        }
+                       /* No error, but unknown id */
+                       return true;
                }
 
+               /* Erk, error on descriptor! */
                return false;
        }
 };
@@ -787,7 +713,7 @@ class ModuleSQL : public Module
        ModuleSQL(InspIRCd* Me)
        : Module::Module(Me), rehashing(false)
        {
-               ServerInstance->UseInterface("SQLutils");
+               ServerInstance->Modules->UseInterface("SQLutils");
 
                Conf = new ConfigReader(ServerInstance);
                PublicServerInstance = ServerInstance;
@@ -804,24 +730,24 @@ class ModuleSQL : public Module
                        throw ModuleException("m_mysql: Failed to create dispatcher thread: " + std::string(strerror(errno)));
                }
 
-               if (!ServerInstance->PublishFeature("SQL", this))
+               if (!ServerInstance->Modules->PublishFeature("SQL", this))
                {
                        /* Tell worker thread to exit NOW */
                        giveup = true;
                        throw ModuleException("m_mysql: Unable to publish feature 'SQL'");
                }
 
-               ServerInstance->PublishInterface("SQL", this);
+               ServerInstance->Modules->PublishInterface("SQL", this);
        }
 
        virtual ~ModuleSQL()
        {
                giveup = true;
                ClearAllConnections();
-               DELETE(Conf);
-               ServerInstance->UnpublishInterface("SQL", this);
-               ServerInstance->UnpublishFeature("SQL");
-               ServerInstance->DoneWithInterface("SQLutils");
+               delete Conf;
+               ServerInstance->Modules->UnpublishInterface("SQL", this);
+               ServerInstance->Modules->UnpublishFeature("SQL");
+               ServerInstance->Modules->DoneWithInterface("SQLutils");
        }
 
 
@@ -959,29 +885,4 @@ void* DispatcherThread(void* arg)
        return NULL;
 }
 
-
-// stuff down here is the module-factory stuff. For basic modules you can ignore this.
-
-class ModuleSQLFactory : public ModuleFactory
-{
- public:
-       ModuleSQLFactory()
-       {
-       }
-       
-       ~ModuleSQLFactory()
-       {
-       }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSQL(Me);
-       }
-       
-};
-
-
-extern "C" void * init_module( void )
-{
-       return new ModuleSQLFactory;
-}
+MODULE_INIT(ModuleSQL);