]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_pgsql.cpp
Remove InspIRCd* parameters and fields
[user/henk/code/inspircd.git] / src / modules / extra / m_pgsql.cpp
index d702b9c341e34b85a7fbc683f534851089e92b4a..c0d301107e9488d177da328feb6ab0e4d3fb85a2 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  * ---------------------------------------------------
  */
 
+#include "inspircd.h"
 #include <cstdlib>
 #include <sstream>
-#include <string>
-#include <deque>
-#include <map>
 #include <libpq-fe.h>
-
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
-
-#include "inspircd.h"
-#include "configreader.h"
-
 #include "m_sqlv2.h"
 
 /* $ModDesc: PostgreSQL Service Provider module for all other m_sql* modules, uses v2 of the SQL API */
-/* $CompileFlags: -I`pg_config --includedir` `perl extra/pgsql_config.pl` */
-/* $LinkerFlags: -L`pg_config --libdir` -lpq */
+/* $CompileFlags: -Iexec("pg_config --includedir") eval("my $s = `pg_config --version`;$s =~ /^.*?(\d+)\.(\d+)\.(\d+).*?$/;my $v = hex(sprintf("0x%02x%02x%02x", $1, $2, $3));print "-DPGSQL_HAS_ESCAPECONN" if(($v >= 0x080104) || ($v >= 0x07030F && $v < 0x070400) || ($v >= 0x07040D && $v < 0x080000) || ($v >= 0x080008 && $v < 0x080100));") */
+/* $LinkerFlags: -Lexec("pg_config --libdir") -lpq */
 /* $ModDep: m_sqlv2.h */
 
 
 /* SQLConn rewritten by peavey to
  * use EventHandler instead of
- * InspSocket. This is much neater
+ * BufferedSocket. This is much neater
  * and gives total control of destroy
  * and delete of resources.
  */
@@ -54,14 +44,25 @@ typedef std::map<std::string, SQLConn*> ConnMap;
  */
 enum SQLstatus { CREAD, CWRITE, WREAD, WWRITE, RREAD, RWRITE };
 
+unsigned long count(const char * const str, char a)
+{
+       unsigned long n = 0;
+       for (const char *p = str; *p; ++p)
+       {
+               if (*p == '?')
+                       ++n;
+       }
+       return n;
+}
+
 /** SQLhost::GetDSN() - Overload to return correct DSN for PostgreSQL
  */
 std::string SQLhost::GetDSN()
 {
-       std::ostringstream conninfo("connect_timeout = '2'");
+       std::ostringstream conninfo("connect_timeout = '5'");
 
-       if (ip.length())
-               conninfo << " hostaddr = '" << ip << "'";
+       if (host.length())
+               conninfo << " host = '" << host << "'";
 
        if (port)
                conninfo << " port = '" << port << "'";
@@ -87,174 +88,18 @@ std::string SQLhost::GetDSN()
        return conninfo.str();
 }
 
-class ReconnectTimer : public InspTimer
-{
-  private:
-       Module* mod;
-  public:
-       ReconnectTimer(InspIRCd* SI, Module* m)
-       : InspTimer(5, SI->Time(), false), mod(m)
-       {
-       }
-       virtual void Tick(time_t TIME);
-};
-
-
-/** Used to resolve sql server hostnames
- */
-class SQLresolver : public Resolver
+class ReconnectTimer : public Timer
 {
  private:
-       SQLhost host;
        Module* mod;
  public:
-       SQLresolver(Module* m, InspIRCd* Instance, const SQLhost& hi, bool &cached)
-       : Resolver(Instance, hi.host, DNS_QUERY_FORWARD, cached, (Module*)m), host(hi), mod(m)
+       ReconnectTimer(Module* m)
+       : Timer(5, SI->Time(), false), mod(m)
        {
        }
-
-       virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached);
-
-       virtual void OnError(ResolverError e, const std::string &errormessage)
-       {
-               ServerInstance->Log(DEBUG, "DNS lookup failed (%s), dying horribly", errormessage.c_str());
-       }
+       virtual void Tick(time_t TIME);
 };
 
-/** QueryQueue, a queue of queries waiting to be executed.
- * This maintains two queues internally, one for 'priority'
- * queries and one for less important ones. Each queue has
- * new queries appended to it and ones to execute are popped
- * off the front. This keeps them flowing round nicely and no
- * query should ever get 'stuck' for too long. If there are
- * queries in the priority queue they will be executed first,
- * 'unimportant' queries will only be executed when the
- * priority queue is empty.
- *
- * We store lists of SQLrequest's here, by value as we want to avoid storing
- * any data allocated inside the client module (in case that module is unloaded
- * while the query is in progress).
- *
- * Because we want to work on the current SQLrequest in-situ, we need a way
- * of accessing the request we are currently processing, QueryQueue::front(),
- * but that call needs to always return the same request until that request
- * is removed from the queue, this is what the 'which' variable is. New queries are
- * always added to the back of one of the two queues, but if when front()
- * is first called then the priority queue is empty then front() will return
- * a query from the normal queue, but if a query is then added to the priority
- * queue then front() must continue to return the front of the *normal* queue
- * until pop() is called.
- */
-
-class QueryQueue : public classbase
-{
-private:
-       typedef std::deque<SQLrequest> ReqDeque;
-
-       ReqDeque priority;      /* The priority queue */
-       ReqDeque normal;        /* The 'normal' queue */
-       enum { PRI, NOR, NON } which;   /* Which queue the currently active element is at the front of */
-
-public:
-       QueryQueue()
-       : which(NON)
-       {
-       }
-
-       void push(const SQLrequest &q)
-       {
-               //ServerInstance->Log(DEBUG, "QueryQueue::push(): Adding %s query to queue: %s", ((q.pri) ? "priority" : "non-priority"), q.query.q.c_str());
-
-               if(q.pri)
-                       priority.push_back(q);
-               else
-                       normal.push_back(q);
-       }
-
-       void pop()
-       {
-               if((which == PRI) && priority.size())
-               {
-                       priority.pop_front();
-               }
-               else if((which == NOR) && normal.size())
-               {
-                       normal.pop_front();
-               }
-
-               /* Reset this */
-               which = NON;
-
-               /* Silently do nothing if there was no element to pop() */
-       }
-
-       SQLrequest& front()
-       {
-               switch(which)
-               {
-                       case PRI:
-                               return priority.front();
-                       case NOR:
-                               return normal.front();
-                       default:
-                               if(priority.size())
-                               {
-                                       which = PRI;
-                                       return priority.front();
-                               }
-
-                               if(normal.size())
-                               {
-                                       which = NOR;
-                                       return normal.front();
-                               }
-
-                               /* This will probably result in a segfault,
-                                * but the caller should have checked totalsize()
-                                * first so..meh - moron :p
-                                */
-
-                               return priority.front();
-               }
-       }
-
-       std::pair<int, int> size()
-       {
-               return std::make_pair(priority.size(), normal.size());
-       }
-
-       int totalsize()
-       {
-               return priority.size() + normal.size();
-       }
-
-       void PurgeModule(Module* mod)
-       {
-               DoPurgeModule(mod, priority);
-               DoPurgeModule(mod, normal);
-       }
-
-private:
-       void DoPurgeModule(Module* mod, ReqDeque& q)
-       {
-               for(ReqDeque::iterator iter = q.begin(); iter != q.end(); iter++)
-               {
-                       if(iter->GetSource() == mod)
-                       {
-                               if(iter->id == front().id)
-                               {
-                                       /* It's the currently active query.. :x */
-                                       iter->SetSource(NULL);
-                               }
-                               else
-                               {
-                                       /* It hasn't been executed yet..just remove it */
-                                       iter = q.erase(iter);
-                               }
-                       }
-               }
-       }
-};
 
 /** PgSQLresult is a subclass of the mostly-pure-virtual class SQLresult.
  * All SQL providers must create their own subclass and define it's methods using that
@@ -273,23 +118,21 @@ class PgSQLresult : public SQLresult
        SQLfieldList* fieldlist;
        SQLfieldMap* fieldmap;
 public:
-       PgSQLresult(Module* self, Module* to, unsigned long id, PGresult* result)
-       : SQLresult(self, to, id), res(result), currentrow(0), fieldlist(NULL), fieldmap(NULL)
+       PgSQLresult(Module* self, Module* to, unsigned long rid, PGresult* result)
+       : SQLresult(self, to, rid), res(result), currentrow(0), fieldlist(NULL), fieldmap(NULL)
        {
                rows = PQntuples(res);
                cols = PQnfields(res);
-
-               //ServerInstance->Log(DEBUG, "Created new PgSQL result; %d rows, %d columns, %s affected", rows, cols, PQcmdTuples(res));
        }
 
        ~PgSQLresult()
        {
                /* If we allocated these, free them... */
                if(fieldlist)
-                       DELETE(fieldlist);
+                       delete fieldlist;
 
                if(fieldmap)
-                       DELETE(fieldmap);
+                       delete fieldmap;
 
                PQclear(res);
        }
@@ -342,7 +185,6 @@ public:
                }
                else
                {
-                       //ServerInstance->Log(DEBUG, "PQgetvalue returned a null pointer..nobody wants to tell us what this means");
                        throw SQLbadColName();
                }
        }
@@ -363,9 +205,9 @@ public:
 
                if(currentrow < PQntuples(res))
                {
-                       int cols = PQnfields(res);
+                       int ncols = PQnfields(res);
 
-                       for(int i = 0; i < cols; i++)
+                       for(int i = 0; i < ncols; i++)
                        {
                                fieldlist->push_back(GetValue(currentrow, i));
                        }
@@ -392,9 +234,9 @@ public:
 
                if(currentrow < PQntuples(res))
                {
-                       int cols = PQnfields(res);
+                       int ncols = PQnfields(res);
 
-                       for(int i = 0; i < cols; i++)
+                       for(int i = 0; i < ncols; i++)
                        {
                                fieldmap->insert(std::make_pair(ColName(i), GetValue(currentrow, i)));
                        }
@@ -411,9 +253,9 @@ public:
 
                if(currentrow < PQntuples(res))
                {
-                       int cols = PQnfields(res);
+                       int ncols = PQnfields(res);
 
-                       for(int i = 0; i < cols; i++)
+                       for(int i = 0; i < ncols; i++)
                        {
                                fl->push_back(GetValue(currentrow, i));
                        }
@@ -430,9 +272,9 @@ public:
 
                if(currentrow < PQntuples(res))
                {
-                       int cols = PQnfields(res);
+                       int ncols = PQnfields(res);
 
-                       for(int i = 0; i < cols; i++)
+                       for(int i = 0; i < ncols; i++)
                        {
                                fm->insert(std::make_pair(ColName(i), GetValue(currentrow, i)));
                        }
@@ -445,12 +287,12 @@ public:
 
        virtual void Free(SQLfieldMap* fm)
        {
-               DELETE(fm);
+               delete fm;
        }
 
        virtual void Free(SQLfieldList* fl)
        {
-               DELETE(fl);
+               delete fl;
        }
 };
 
@@ -458,8 +300,7 @@ public:
  */
 class SQLConn : public EventHandler
 {
-  private:
-       InspIRCd*               Instance;
+ private:
        SQLhost                 confhost;       /* The <database> entry */
        Module*                 us;                     /* Pointer to the SQL provider itself */
        PGconn*                 sql;            /* PgSQL database connection handle */
@@ -468,14 +309,14 @@ class SQLConn : public EventHandler
        QueryQueue              queue;          /* Queue of queries waiting to be executed on this connection */
        time_t                  idle;           /* Time we last heard from the database */
 
 public:
-       SQLConn(InspIRCd* SI, Module* self, const SQLhost& hi)
-       : EventHandler(), Instance(SI), confhost(hi), us(self), sql(NULL), status(CWRITE), qinprog(false)
+ public:
+       SQLConn(Module* self, const SQLhost& hi)
+       : EventHandler(), confhost(hi), us(self), sql(NULL), status(CWRITE), qinprog(false)
        {
-               idle = this->Instance->Time();
+               idle = this->ServerInstance->Time();
                if(!DoConnect())
                {
-                       Instance->Log(DEFAULT, "WARNING: Could not connect to database with id: " + ConvToStr(hi.id));
+                       ServerInstance->Logs->Log("m_pgsql",DEFAULT, "WARNING: Could not connect to database with id: " + ConvToStr(hi.id));
                        DelayReconnect();
                }
        }
@@ -509,40 +350,25 @@ class SQLConn : public EventHandler
        bool DoConnect()
        {
                if(!(sql = PQconnectStart(confhost.GetDSN().c_str())))
-               {
-                       Instance->Log(DEBUG, "Couldn't allocate PGconn structure, aborting: %s", PQerrorMessage(sql));
                        return false;
-               }
 
                if(PQstatus(sql) == CONNECTION_BAD)
-               {
-                       Instance->Log(DEBUG, "PQconnectStart failed: %s", PQerrorMessage(sql));
                        return false;
-               }
-
-               ShowStatus();
 
                if(PQsetnonblocking(sql, 1) == -1)
-               {
-                       Instance->Log(DEBUG, "Couldn't set connection nonblocking: %s", PQerrorMessage(sql));
                        return false;
-               }
 
                /* OK, we've initalised the connection, now to get it hooked into the socket engine
                * and then start polling it.
                */
                this->fd = PQsocket(sql);
-               Instance->Log(DEBUG, "New SQL socket: %d", this->fd);
 
                if(this->fd <= -1)
-               {
-                       Instance->Log(DEBUG, "PQsocket says we have an invalid FD: %d", this->fd);
                        return false;
-               }
 
-               if (!this->Instance->SE->AddFd(this))
+               if (!this->ServerInstance->SE->AddFd(this))
                {
-                       Instance->Log(DEBUG, "A PQsocket cant be added to the socket engine!");
+                       ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Couldn't add pgsql socket to socket engine");
                        return false;
                }
 
@@ -555,7 +381,7 @@ class SQLConn : public EventHandler
                switch(PQconnectPoll(sql))
                {
                        case PGRES_POLLING_WRITING:
-                               Instance->SE->WantWrite(this);
+                               ServerInstance->SE->WantWrite(this);
                                status = CWRITE;
                                return true;
                        case PGRES_POLLING_READING:
@@ -582,26 +408,20 @@ class SQLConn : public EventHandler
 
                if(PQconsumeInput(sql))
                {
-                       Instance->Log(DEBUG, "PQconsumeInput succeeded");
-
                        /* We just read stuff from the server, that counts as it being alive
                         * so update the idle-since time :p
                         */
-                       idle = this->Instance->Time();
+                       idle = this->ServerInstance->Time();
 
-                       if(PQisBusy(sql))
+                       if (PQisBusy(sql))
                        {
-                               //Instance->Log(DEBUG, "Still busy processing command though");
+                               /* Nothing happens here */
                        }
-                       else if(qinprog)
+                       else if (qinprog)
                        {
-                               //ServerInstance->Log(DEBUG, "Looks like we have a result to process!");
-
                                /* Grab the request we're processing */
                                SQLrequest& query = queue.front();
 
-                               Instance->Log(DEBUG, "ID is %lu", query.id);
-
                                /* Get a pointer to the module we're about to return the result to */
                                Module* to = query.GetSource();
 
@@ -628,16 +448,15 @@ class SQLConn : public EventHandler
                                        /* Fix by brain, make sure the original query gets sent back in the reply */
                                        reply.query = query.query.q;
 
-                                       Instance->Log(DEBUG, "Got result, status code: %s; error message: %s", PQresStatus(PQresultStatus(result)), PQresultErrorMessage(result));
-
                                        switch(PQresultStatus(result))
                                        {
                                                case PGRES_EMPTY_QUERY:
                                                case PGRES_BAD_RESPONSE:
                                                case PGRES_FATAL_ERROR:
-                                                       reply.error.Id(QREPLY_FAIL);
+                                                       reply.error.Id(SQL_QREPLY_FAIL);
                                                        reply.error.Str(PQresultErrorMessage(result));
-                                               default:;
+                                               default:
+                                                       ;
                                                        /* No action, other values are not errors */
                                        }
 
@@ -651,17 +470,12 @@ class SQLConn : public EventHandler
                                         * the pointer to NULL. We cannot just cancel the query as the result will still come
                                         * through at some point...and it could get messy if we play with invalid pointers...
                                         */
-                                       Instance->Log(DEBUG, "Looks like we're handling a zombie query from a module which unloaded before it got a result..fun. ID: %lu", query.id);
                                        PQclear(result);
                                }
                                qinprog = false;
                                queue.pop();
                                DoConnectedPoll();
                        }
-                       else
-                       {
-                               Instance->Log(DEBUG, "Eh!? We just got a read event, and connection isn't busy..but no result :(");
-                       }
                        return true;
                }
                else
@@ -671,7 +485,6 @@ class SQLConn : public EventHandler
                         * deserves to reconnect [/excuse]
                         * Returning true so the core doesn't try and close the connection.
                         */
-                       Instance->Log(DEBUG, "PQconsumeInput failed: %s", PQerrorMessage(sql));
                        DelayReconnect();
                        return true;
                }
@@ -682,85 +495,36 @@ class SQLConn : public EventHandler
                switch(PQresetPoll(sql))
                {
                        case PGRES_POLLING_WRITING:
-                               //ServerInstance->Log(DEBUG, "PGresetPoll: PGRES_POLLING_WRITING");
-                               Instance->SE->WantWrite(this);
+                               ServerInstance->SE->WantWrite(this);
                                status = CWRITE;
                                return DoPoll();
                        case PGRES_POLLING_READING:
-                               //ServerInstance->Log(DEBUG, "PGresetPoll: PGRES_POLLING_READING");
                                status = CREAD;
                                return true;
                        case PGRES_POLLING_FAILED:
-                               //ServerInstance->Log(DEBUG, "PGresetPoll: PGRES_POLLING_FAILED: %s", PQerrorMessage(sql));
                                return false;
                        case PGRES_POLLING_OK:
-                               //ServerInstance->Log(DEBUG, "PGresetPoll: PGRES_POLLING_OK");
                                status = WWRITE;
                                return DoConnectedPoll();
                        default:
-                               //ServerInstance->Log(DEBUG, "PGresetPoll: wtf?");
                                return true;
                }
        }
 
-       void ShowStatus()
-       {
-               switch(PQstatus(sql))
-               {
-                       case CONNECTION_OK:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_OK: Can proceed to connect.");
-                               break;
-
-                       case CONNECTION_BAD:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_BAD: Connection is closed.");
-                               break;
-
-                       case CONNECTION_STARTED:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_STARTED: Waiting for connection to be made.");
-                               break;
-
-                       case CONNECTION_MADE:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_MADE: Connection OK; waiting to send.");
-                               break;
-
-                       case CONNECTION_AWAITING_RESPONSE:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_AWAITING_RESPONSE: Waiting for a response from the server.");
-                               break;
-
-                       case CONNECTION_AUTH_OK:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_AUTH_OK: Received authentication; waiting for backend start-up to finish.");
-                               break;
-
-                       case CONNECTION_SSL_STARTUP:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_SSL_STARTUP: Negotiating SSL encryption.");
-                               break;
-
-                       case CONNECTION_SETENV:
-                               Instance->Log(DEBUG, "PQstatus: CONNECTION_SETENV: Negotiating environment-driven parameter settings.");
-                               break;
-
-                       default:
-                               Instance->Log(DEBUG, "PQstatus: ???");
-               }
-       }
-
        bool OnDataReady()
        {
                /* Always return true here, false would close the socket - we need to do that ourselves with the pgsql API */
-               Instance->Log(DEBUG, "OnDataReady(): status = %s", StatusStr());
                return DoEvent();
        }
 
        bool OnWriteReady()
        {
                /* Always return true here, false would close the socket - we need to do that ourselves with the pgsql API */
-               Instance->Log(DEBUG, "OnWriteReady(): status = %s", StatusStr());
                return DoEvent();
        }
 
        bool OnConnected()
        {
-               Instance->Log(DEBUG, "OnConnected(): status = %s", StatusStr());
                return DoEvent();
        }
 
@@ -785,15 +549,6 @@ class SQLConn : public EventHandler
                return ret;
        }
 
-       const char* StatusStr()
-       {
-               if(status == CREAD) return "CREAD";
-               if(status == CWRITE) return "CWRITE";
-               if(status == WREAD) return "WREAD";
-               if(status == WWRITE) return "WWRITE";
-               return "Err...what, erm..BUG!";
-       }
-
        SQLerror DoQuery(SQLrequest &req)
        {
                if((status == WREAD) || (status == WWRITE))
@@ -806,23 +561,32 @@ class SQLConn : public EventHandler
                                char* query;
                                /* Pointer to the current end of query, where we append new stuff */
                                char* queryend;
+
                                /* Total length of the unescaped parameters */
-                               unsigned int paramlen;
+                               unsigned long maxparamlen, paramcount;
 
-                               paramlen = 0;
+                               /* The length of the longest parameter */
+                               maxparamlen = 0;
 
                                for(ParamL::iterator i = req.query.p.begin(); i != req.query.p.end(); i++)
                                {
-                                       paramlen += i->size();
+                                       if (i->size() > maxparamlen)
+                                               maxparamlen = i->size();
                                }
 
+                               /* How many params are there in the query? */
+                               paramcount = count(req.query.q.c_str(), '?');
+
+                               /* This stores copy of params to be inserted with using numbered params 1;3B*/
+                               ParamL paramscopy(req.query.p);
+
                                /* To avoid a lot of allocations, allocate enough memory for the biggest the escaped query could possibly be.
-                                * sizeofquery + (totalparamlength*2) + 1
+                                * sizeofquery + (maxtotalparamlength*2) + 1
                                 *
                                 * The +1 is for null-terminating the string for PQsendQuery()
                                 */
 
-                               query = new char[req.query.q.length() + (paramlen*2) + 1];
+                               query = new char[req.query.q.length() + (maxparamlen*paramcount*2) + 1];
                                queryend = query;
 
                                /* Okay, now we have a buffer large enough we need to start copying the query into it and escaping and substituting
@@ -840,7 +604,53 @@ class SQLConn : public EventHandler
                                                 * pointing at the right place.
                                                 */
 
-                                               if(req.query.p.size())
+                                               /* Is it numbered parameter?
+                                                */
+
+                                               bool numbered;
+                                               numbered = false;
+
+                                               /* Numbered parameter number :|
+                                                */
+                                               unsigned int paramnum;
+                                               paramnum = 0;
+
+                                               /* Let's check if it's a numbered param. And also calculate it's number.
+                                                */
+
+                                               while ((i < req.query.q.length() - 1) && (req.query.q[i+1] >= '0') && (req.query.q[i+1] <= '9'))
+                                               {
+                                                       numbered = true;
+                                                       ++i;
+                                                       paramnum = paramnum * 10 + req.query.q[i] - '0';
+                                               }
+
+                                               if (paramnum > paramscopy.size() - 1)
+                                               {
+                                                       /* index is out of range!
+                                                        */
+                                                       numbered = false;
+                                               }
+
+                                               if (numbered)
+                                               {
+                                                       int error = 0;
+                                                       size_t len = 0;
+
+#ifdef PGSQL_HAS_ESCAPECONN
+                                                       len = PQescapeStringConn(sql, queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length(), &error);
+#else
+                                                       len = PQescapeString         (queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length());
+#endif
+                                                       if (error)
+                                                       {
+                                                               ServerInstance->Logs->Log("m_pgsql", DEBUG, "BUG: Apparently PQescapeStringConn() failed somehow...don't know how or what to do...");
+                                                       }
+
+                                                       /* Incremenet queryend to the end of the newly escaped parameter */
+                                                       queryend += len;
+                                               }
+                                               else if (req.query.p.size())
                                                {
                                                        int error = 0;
                                                        size_t len = 0;
@@ -852,11 +662,9 @@ class SQLConn : public EventHandler
 #endif
                                                        if(error)
                                                        {
-                                                               Instance->Log(DEBUG, "Apparently PQescapeStringConn() failed somehow...don't know how or what to do...");
+                                                               ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Apparently PQescapeStringConn() failed somehow...don't know how or what to do...");
                                                        }
 
-                                                       Instance->Log(DEBUG, "Appended %d bytes of escaped string onto the query", len);
-
                                                        /* Incremenet queryend to the end of the newly escaped parameter */
                                                        queryend += len;
 
@@ -865,7 +673,7 @@ class SQLConn : public EventHandler
                                                }
                                                else
                                                {
-                                                       Instance->Log(DEBUG, "Found a substitution location but no parameter to substitute :|");
+                                                       ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Found a substitution location but no parameter to substitute :|");
                                                        break;
                                                }
                                        }
@@ -878,27 +686,22 @@ class SQLConn : public EventHandler
 
                                /* Null-terminate the query */
                                *queryend = 0;
-
-                               Instance->Log(DEBUG, "Attempting to dispatch query: %s", query);
-
                                req.query.q = query;
 
                                if(PQsendQuery(sql, query))
                                {
-                                       Instance->Log(DEBUG, "Dispatched query successfully");
                                        qinprog = true;
                                        delete[] query;
                                        return SQLerror();
                                }
                                else
                                {
-                                       Instance->Log(DEBUG, "Failed to dispatch query: %s", PQerrorMessage(sql));
                                        delete[] query;
-                                       return SQLerror(QSEND_FAIL, PQerrorMessage(sql));
+                                       return SQLerror(SQL_QSEND_FAIL, PQerrorMessage(sql));
                                }
                        }
                }
-               return SQLerror(BAD_CONN, "Can't query until connection is complete");
+               return SQLerror(SQL_BAD_CONN, "Can't query until connection is complete");
        }
 
        SQLerror Query(const SQLrequest &req)
@@ -927,24 +730,19 @@ class SQLConn : public EventHandler
                return confhost;
        }
 
-       void Close() {
-               Instance->Log(DEBUG, "SQLConn::Close - socket: %d", this->fd);
-
-               if (!this->Instance->SE->DelFd(this))
+       void Close()
+       {
+               if (!this->ServerInstance->SE->DelFd(this))
                {
                        if (sql && PQstatus(sql) == CONNECTION_BAD)
                        {
-                               Instance->Log(DEBUG, "PQsocket was already removed. Forcing removal from socket engine!");
-                               this->Instance->SE->DelFd(this, true);
+                               this->ServerInstance->SE->DelFd(this, true);
                        }
                        else
                        {
-                               Instance->Log(DEBUG, "PQsocket cant be removed from socket engine!");
+                               ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: PQsocket cant be removed from socket engine!");
                        }
                }
-               else {
-                       Instance->Log(DEBUG, "PQsocket removed from socket engine!");
-               }
 
                if(sql)
                {
@@ -957,30 +755,32 @@ class SQLConn : public EventHandler
 
 class ModulePgSQL : public Module
 {
 private:
+ private:
        ConnMap connections;
        unsigned long currid;
        char* sqlsuccess;
        ReconnectTimer* retimer;
 
 public:
-       ModulePgSQL(InspIRCd* Me)
-       : Module::Module(Me), currid(0)
+ public:
+       ModulePgSQL()
+       : currid(0)
        {
-               ServerInstance->UseInterface("SQLutils");
+               ServerInstance->Modules->UseInterface("SQLutils");
 
                sqlsuccess = new char[strlen(SQLSUCCESS)+1];
 
                strlcpy(sqlsuccess, SQLSUCCESS, strlen(SQLSUCCESS));
 
-               if (!ServerInstance->PublishFeature("SQL", this))
+               if (!ServerInstance->Modules->PublishFeature("SQL", this))
                {
-                       throw ModuleException("m_pgsql: Unable to publish feature 'SQL'");
+                       throw ModuleException("BUG: PgSQL Unable to publish feature 'SQL'");
                }
 
                ReadConf();
 
-               ServerInstance->PublishInterface("SQL", this);
+               ServerInstance->Modules->PublishInterface("SQL", this);
+               Implementation eventlist[] = { I_OnUnloadModule, I_OnRequest, I_OnRehash };
+               ServerInstance->Modules->Attach(eventlist, this, 3);
        }
 
        virtual ~ModulePgSQL()
@@ -989,17 +789,13 @@ class ModulePgSQL : public Module
                        ServerInstance->Timers->DelTimer(retimer);
                ClearAllConnections();
                delete[] sqlsuccess;
-               ServerInstance->UnpublishInterface("SQL", this);
-               ServerInstance->UnpublishFeature("SQL");
-               ServerInstance->DoneWithInterface("SQLutils");
+               ServerInstance->Modules->UnpublishInterface("SQL", this);
+               ServerInstance->Modules->UnpublishFeature("SQL");
+               ServerInstance->Modules->DoneWithInterface("SQLutils");
        }
 
-       void Implements(char* List)
-       {
-               List[I_OnUnloadModule] = List[I_OnRequest] = List[I_OnRehash] = List[I_OnUserRegister] = List[I_OnCheckReady] = List[I_OnUserDisconnect] = 1;
-       }
 
-       virtual void OnRehash(userrec* user, const std::string &parameter)
+       virtual void OnRehash(User* user)
        {
                ReadConf();
        }
@@ -1016,7 +812,7 @@ class ModulePgSQL : public Module
 
        bool HostInConf(const SQLhost &h)
        {
-               ConfigReader conf(ServerInstance);
+               ConfigReader conf;
                for(int i = 0; i < conf.Enumerate("database"); i++)
                {
                        SQLhost host;
@@ -1037,12 +833,10 @@ class ModulePgSQL : public Module
        {
                ClearOldConnections();
 
-               ConfigReader conf(ServerInstance);
+               ConfigReader conf;
                for(int i = 0; i < conf.Enumerate("database"); i++)
                {
                        SQLhost host;
-                       int ipvalid;
-                       insp_inaddr blargle;
 
                        host.id         = conf.ReadValue("database", "id", i);
                        host.host       = conf.ReadValue("database", "hostname", i);
@@ -1055,36 +849,7 @@ class ModulePgSQL : public Module
                        if (HasHost(host))
                                continue;
 
-                       ipvalid = insp_aton(host.host.c_str(), &blargle);
-
-                       if(ipvalid > 0)
-                       {
-                               /* The conversion succeeded, we were given an IP and we can give it straight to SQLConn */
-                               host.ip = host.host;
-                               this->AddConn(host);
-                       }
-                       else if(ipvalid == 0)
-                       {
-                               /* Conversion failed, assume it's a host */
-                               SQLresolver* resolver;
-
-                               try
-                               {
-                                       bool cached;
-                                       resolver = new SQLresolver(this, ServerInstance, host, cached);
-                                       ServerInstance->AddResolver(resolver, cached);
-                               }
-                               catch(...)
-                               {
-                                       /* THE WORLD IS COMING TO AN END! */
-                                       ServerInstance->Log(DEBUG, "Couldn't make a SQLresolver..this connection is gonna diiiiiie...actually we just won't create it");
-                               }
-                       }
-                       else
-                       {
-                               /* Invalid address family, die horribly. */
-                               ServerInstance->Log(DEBUG, "insp_aton failed returning -1, oh noes.");
-                       }
+                       this->AddConn(host);
                }
        }
 
@@ -1095,7 +860,7 @@ class ModulePgSQL : public Module
                {
                        if (!HostInConf(iter->second->GetConfHost()))
                        {
-                               DELETE(iter->second);
+                               delete iter->second;
                                safei = iter;
                                --iter;
                                connections.erase(safei);
@@ -1109,7 +874,7 @@ class ModulePgSQL : public Module
                while ((i = connections.begin()) != connections.end())
                {
                        connections.erase(i);
-                       DELETE(i->second);
+                       delete i->second;
                }
        }
 
@@ -1117,14 +882,13 @@ class ModulePgSQL : public Module
        {
                if (HasHost(hi))
                {
-                       ServerInstance->Log(DEFAULT, "WARNING: A pgsql connection with id: %s already exists, possibly due to DNS delay. Aborting connection attempt.", hi.id.c_str());
+                       ServerInstance->Logs->Log("m_pgsql",DEFAULT, "WARNING: A pgsql connection with id: %s already exists. Aborting connection attempt.", hi.id.c_str());
                        return;
                }
 
                SQLConn* newconn;
 
-               /* The conversion succeeded, we were given an IP and we can give it straight to SQLConn */
-               newconn = new SQLConn(ServerInstance, this, hi);
+               newconn = new SQLConn(this, hi);
 
                connections.insert(std::make_pair(hi.id, newconn));
        }
@@ -1135,41 +899,35 @@ class ModulePgSQL : public Module
                {
                        if (conn == iter->second)
                        {
-                               DELETE(iter->second);
+                               delete iter->second;
                                connections.erase(iter);
                                break;
                        }
                }
-               retimer = new ReconnectTimer(ServerInstance, this);
+               retimer = new ReconnectTimer(this);
                ServerInstance->Timers->AddTimer(retimer);
        }
 
-       virtual char* OnRequest(Request* request)
+       virtual const char* OnRequest(Request* request)
        {
                if(strcmp(SQLREQID, request->GetId()) == 0)
                {
                        SQLrequest* req = (SQLrequest*)request;
                        ConnMap::iterator iter;
-
-                       ServerInstance->Log(DEBUG, "Got query: '%s' with %d replacement parameters on id '%s'", req->query.q.c_str(), req->query.p.size(), req->dbid.c_str());
-
                        if((iter = connections.find(req->dbid)) != connections.end())
                        {
                                /* Execute query */
                                req->id = NewID();
                                req->error = iter->second->Query(*req);
 
-                               return (req->error.Id() == NO_ERROR) ? sqlsuccess : NULL;
+                               return (req->error.Id() == SQL_NO_ERROR) ? sqlsuccess : NULL;
                        }
                        else
                        {
-                               req->error.Id(BAD_DBID);
+                               req->error.Id(SQL_BAD_DBID);
                                return NULL;
                        }
                }
-
-               ServerInstance->Log(DEBUG, "Got unsupported API version string: %s", request->GetId());
-
                return NULL;
        }
 
@@ -1197,20 +955,10 @@ class ModulePgSQL : public Module
 
        virtual Version GetVersion()
        {
-               return Version(1, 1, 0, 0, VF_VENDOR|VF_SERVICEPROVIDER, API_VERSION);
+               return Version("PostgreSQL Service Provider module for all other m_sql* modules, uses v2 of the SQL API", VF_VENDOR|VF_SERVICEPROVIDER, API_VERSION);
        }
 };
 
-/* move this here to use AddConn, rather that than having the whole
- * module above SQLConn, since this is buggin me right now :/
- */
-void SQLresolver::OnLookupComplete(const std::string &result, unsigned int ttl, bool cached)
-{
-       host.ip = result;
-       ((ModulePgSQL*)mod)->AddConn(host);
-       ((ModulePgSQL*)mod)->ClearOldConnections();
-}
-
 void ReconnectTimer::Tick(time_t time)
 {
        ((ModulePgSQL*)mod)->ReadConf();
@@ -1221,26 +969,4 @@ void SQLConn::DelayReconnect()
        ((ModulePgSQL*)us)->ReconnectConn(this);
 }
 
-
-class ModulePgSQLFactory : public ModuleFactory
-{
- public:
-       ModulePgSQLFactory()
-       {
-       }
-
-       ~ModulePgSQLFactory()
-       {
-       }
-
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModulePgSQL(Me);
-       }
-};
-
-
-extern "C" void * init_module( void )
-{
-       return new ModulePgSQLFactory;
-}
+MODULE_INIT(ModulePgSQL)