]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_sqlauth.cpp
All of insp now builds with -pedantic (theres some warnings to squash in modules...
[user/henk/code/inspircd.git] / src / modules / extra / m_sqlauth.cpp
index 7130439e0537ad93e4e3d5a21486b6bb68c425fd..98b0227e5ad3157927e4dac3ace89fdab33c6bc3 100644 (file)
  * ---------------------------------------------------
  */
 
-#include <string>
+#include "inspircd.h"
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-#include "inspircd.h"
-
 #include "m_sqlv2.h"
 #include "m_sqlutils.h"
 
@@ -25,7 +23,6 @@
 
 class ModuleSQLAuth : public Module
 {
-       InspIRCd* Srv;
        Module* SQLutils;
        Module* SQLprovider;
 
@@ -41,22 +38,26 @@ class ModuleSQLAuth : public Module
        
 public:
        ModuleSQLAuth(InspIRCd* Me)
-       : Module::Module(Me), Srv(Me)
+       : Module::Module(Me)
        {
-               ServerInstance->UseInterface("SQLutils");
-               ServerInstance->UseInterface("SQL");
+               ServerInstance->Modules->UseInterface("SQLutils");
+               ServerInstance->Modules->UseInterface("SQL");
 
-               SQLutils = ServerInstance->FindModule("m_sqlutils.so");
+               SQLutils = ServerInstance->Modules->Find("m_sqlutils.so");
                if (!SQLutils)
                        throw ModuleException("Can't find m_sqlutils.so. Please load m_sqlutils.so before m_sqlauth.so.");
 
+               SQLprovider = ServerInstance->Modules->FindFeature("SQL");
+               if (!SQLprovider)
+                       throw ModuleException("Can't find an SQL provider module. Please load one before attempting to load m_sqlauth.");
+
                OnRehash(NULL,"");
        }
 
        virtual ~ModuleSQLAuth()
        {
-               ServerInstance->DoneWithInterface("SQL");
-               ServerInstance->DoneWithInterface("SQLutils");
+               ServerInstance->Modules->DoneWithInterface("SQL");
+               ServerInstance->Modules->DoneWithInterface("SQLutils");
        }
 
        void Implements(char* List)
@@ -64,9 +65,9 @@ public:
                List[I_OnUserDisconnect] = List[I_OnCheckReady] = List[I_OnRequest] = List[I_OnRehash] = List[I_OnUserRegister] = 1;
        }
 
-       virtual void OnRehash(userrec* user, const std::string &parameter)
+       virtual void OnRehash(User* user, const std::string &parameter)
        {
-               ConfigReader Conf(Srv);
+               ConfigReader Conf(ServerInstance);
                
                usertable       = Conf.ReadValue("sqlauth", "usertable", 0);    /* User table name */
                databaseid      = Conf.ReadValue("sqlauth", "dbid", 0);                 /* Database ID, given to the SQL service provider */
@@ -85,9 +86,9 @@ public:
                }
        }       
 
-       virtual int OnUserRegister(userrec* user)
+       virtual int OnUserRegister(User* user)
        {
-               if ((allowpattern != "") && (Srv->MatchText(user->nick,allowpattern)))
+               if ((!allowpattern.empty()) && (ServerInstance->MatchText(user->nick,allowpattern)))
                {
                        user->Extend("sqlauthed");
                        return 0;
@@ -95,50 +96,33 @@ public:
                
                if (!CheckCredentials(user))
                {
-                       userrec::QuitUser(Srv,user,killreason);
+                       User::QuitUser(ServerInstance,user,killreason);
                        return 1;
                }
                return 0;
        }
 
-       bool CheckCredentials(userrec* user)
+       bool CheckCredentials(User* user)
        {
-               Module* target;
-               
-               target = Srv->FindFeature("SQL");
-               
-               if(target)
-               {
-                       SQLrequest req = SQLreq(this, target, databaseid, "SELECT ? FROM ? WHERE ? = '?' AND ? = ?'?')", userfield, usertable, userfield, user->nick, passfield, encryption, user->password);
+               SQLrequest req = SQLreq(this, SQLprovider, databaseid, "SELECT ? FROM ? WHERE ? = '?' AND ? = ?'?')", userfield, usertable, userfield, user->nick, passfield, encryption, user->password);
                        
-                       if(req.Send())
-                       {
-                               /* When we get the query response from the service provider we will be given an ID to play with,
-                                * just an ID number which is unique to this query. We need a way of associating that ID with a userrec
-                                * so we insert it into a map mapping the IDs to users.
-                                * Thankfully m_sqlutils provides this, it will associate a ID with a user or channel, and if the user quits it removes the
-                                * association. This means that if the user quits during a query we will just get a failed lookup from m_sqlutils - telling
-                                * us to discard the query.
-                                */
-                               ServerInstance->Log(DEBUG, "Sent query, got given ID %lu", req.id);
+               if(req.Send())
+               {
+                       /* When we get the query response from the service provider we will be given an ID to play with,
+                        * just an ID number which is unique to this query. We need a way of associating that ID with a User
+                        * so we insert it into a map mapping the IDs to users.
+                        * Thankfully m_sqlutils provides this, it will associate a ID with a user or channel, and if the user quits it removes the
+                        * association. This means that if the user quits during a query we will just get a failed lookup from m_sqlutils - telling
+                        * us to discard the query.
+                        */
+                       AssociateUser(this, SQLutils, req.id, user).Send();
                                
-                               AssociateUser(this, SQLutils, req.id, user).Send();
-                                       
-                               return true;
-                       }
-                       else
-                       {
-                               ServerInstance->Log(DEBUG, "SQLrequest failed: %s", req.error.Str());
-                       
-                               if (verbose)
-                                       Srv->WriteOpers("Forbidden connection from %s!%s@%s (SQL query failed: %s)", user->nick, user->ident, user->host, req.error.Str());
-                       
-                               return false;
-                       }
+                       return true;
                }
                else
                {
-                       ServerInstance->Log(SPARSE, "WARNING: Couldn't find SQL provider module. NOBODY will be allowed to connect until it comes back unless they match an exception");
+                       if (verbose)
+                               ServerInstance->WriteOpers("Forbidden connection from %s!%s@%s (SQL query failed: %s)", user->nick, user->ident, user->host, req.error.Str());
                        return false;
                }
        }
@@ -147,22 +131,15 @@ public:
        {
                if(strcmp(SQLRESID, request->GetId()) == 0)
                {
-                       SQLresult* res;
-               
-                       res = static_cast<SQLresult*>(request);
-                       
-                       ServerInstance->Log(DEBUG, "Got SQL result (%s) with ID %lu", res->GetId(), res->id);
-                       
-                       userrec* user = GetAssocUser(this, SQLutils, res->id).S().user;
+                       SQLresult* res = static_cast<SQLresult*>(request);
+
+                       User* user = GetAssocUser(this, SQLutils, res->id).S().user;
                        UnAssociate(this, SQLutils, res->id).S();
                        
                        if(user)
                        {
                                if(res->error.Id() == NO_ERROR)
-                               {                               
-                                       ServerInstance->Log(DEBUG, "Associated query ID %lu with user %s", res->id, user->nick);                        
-                                       ServerInstance->Log(DEBUG, "Got result with %d rows and %d columns", res->Rows(), res->Cols());
-                       
+                               {
                                        if(res->Rows())
                                        {
                                                /* We got a row in the result, this is enough really */
@@ -171,42 +148,37 @@ public:
                                        else if (verbose)
                                        {
                                                /* No rows in result, this means there was no record matching the user */
-                                               Srv->WriteOpers("Forbidden connection from %s!%s@%s (SQL query returned no matches)", user->nick, user->ident, user->host);
+                                               ServerInstance->WriteOpers("Forbidden connection from %s!%s@%s (SQL query returned no matches)", user->nick, user->ident, user->host);
                                                user->Extend("sqlauth_failed");
                                        }
                                }
                                else if (verbose)
                                {
-                                       ServerInstance->Log(DEBUG, "Query failed: %s", res->error.Str());
-                                       Srv->WriteOpers("Forbidden connection from %s!%s@%s (SQL query failed: %s)", user->nick, user->ident, user->host, res->error.Str());
+                                       ServerInstance->WriteOpers("Forbidden connection from %s!%s@%s (SQL query failed: %s)", user->nick, user->ident, user->host, res->error.Str());
                                        user->Extend("sqlauth_failed");
                                }
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "Got query with unknown ID, this probably means the user quit while the query was in progress");
                                return NULL;
                        }
 
                        if (!user->GetExt("sqlauthed"))
                        {
-                               userrec::QuitUser(Srv,user,killreason);
+                               User::QuitUser(ServerInstance,user,killreason);
                        }
                        return SQLSUCCESS;
-               }
-               
-               ServerInstance->Log(DEBUG, "Got unsupported API version string: %s", request->GetId());
-               
+               }               
                return NULL;
        }
        
-       virtual void OnUserDisconnect(userrec* user)
+       virtual void OnUserDisconnect(User* user)
        {
                user->Shrink("sqlauthed");
                user->Shrink("sqlauth_failed");         
        }
        
-       virtual bool OnCheckReady(userrec* user)
+       virtual bool OnCheckReady(User* user)
        {
                return user->GetExt("sqlauthed");
        }
@@ -218,26 +190,4 @@ public:
        
 };
 
-class ModuleSQLAuthFactory : public ModuleFactory
-{
- public:
-       ModuleSQLAuthFactory()
-       {
-       }
-       
-       ~ModuleSQLAuthFactory()
-       {
-       }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSQLAuth(Me);
-       }
-       
-};
-
-
-extern "C" void * init_module( void )
-{
-       return new ModuleSQLAuthFactory;
-}
+MODULE_INIT(ModuleSQLAuth)