]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_sqlite3.cpp
Remove InspIRCd* parameters and fields
[user/henk/code/inspircd.git] / src / modules / extra / m_sqlite3.cpp
index 0720f8c939f968f91bd30dc2d21b98e4ec0d4784..0631131023be98de60058ec17e891a7cb3d9464e 100644 (file)
@@ -1,22 +1,18 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*              +------------------------------------+
+ *              | Inspire Internet Relay Chat Daemon |
+ *              +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *     InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ *                       the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
 #include "inspircd.h"
 #include <sqlite3.h>
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
-
 #include "m_sqlv2.h"
 
 /* $ModDesc: sqlite3 provider */
 class SQLConn;
 class SQLite3Result;
 class ResultNotifier;
+class SQLiteListener;
+class ModuleSQLite3;
 
 typedef std::map<std::string, SQLConn*> ConnMap;
 typedef std::deque<classbase*> paramlist;
 typedef std::deque<SQLite3Result*> ResultQueue;
 
-ResultNotifier* resultnotify = NULL;
+unsigned long count(const char * const str, char a)
+{
+       unsigned long n = 0;
+       for (const char *p = str; *p; ++p)
+       {
+               if (*p == '?')
+                       ++n;
+       }
+       return n;
+}
 
+ResultNotifier* notifier = NULL;
+SQLiteListener* listener = NULL;
+int QueueFD = -1;
 
 class ResultNotifier : public BufferedSocket
 {
-       Module* mod;
-       insp_sockaddr sock_us;
+       ModuleSQLite3* mod;
+
+ public:
+       ResultNotifier(ModuleSQLite3* m, int newfd, char* ip) : BufferedSocket(SI, newfd, ip), mod(m)
+       {
+       }
+
+       virtual bool OnDataReady()
+       {
+               char data = 0;
+               if (ServerInstance->SE->Recv(this, &data, 1, 0) > 0)
+               {
+                       Dispatch();
+                       return true;
+               }
+               return false;
+       }
+
+       void Dispatch();
+};
+
+class SQLiteListener : public ListenSocketBase
+{
+       ModuleSQLite3* Parent;
+       irc::sockets::insp_sockaddr sock_us;
        socklen_t uslen;
+       FileReader* index;
 
  public:
-       /* Create a socket on a random port. Let the tcp stack allocate us an available port */
-#ifdef IPV6
-       ResultNotifier(InspIRCd* SI, Module* m) : BufferedSocket(SI, "::1", 0, true, 3000), mod(m)
-#else
-       ResultNotifier(InspIRCd* SI, Module* m) : BufferedSocket(SI, "127.0.0.1", 0, true, 3000), mod(m)
-#endif
+       SQLiteListener(ModuleSQLite3* P, int port, const std::string &addr) : ListenSocketBase(port, addr), Parent(P)
        {
                uslen = sizeof(sock_us);
                if (getsockname(this->fd,(sockaddr*)&sock_us,&uslen))
                {
-                       throw ModuleException("Could not create random listening port on localhost");
+                       throw ModuleException("Could not getsockname() to find out port number for ITC port");
                }
        }
 
-       ResultNotifier(InspIRCd* SI, Module* m, int newfd, char* ip) : BufferedSocket(SI, newfd, ip), mod(m)
+       virtual void OnAcceptReady(const std::string &ipconnectedto, int nfd, const std::string &incomingip)
        {
+               new ResultNotifier(this->Parent, this->ServerInstance, nfd, (char *)ipconnectedto.c_str()); // XXX unsafe casts suck
        }
 
        /* Using getsockname and ntohs, we can determine which port number we were allocated */
@@ -70,20 +100,11 @@ class ResultNotifier : public BufferedSocket
                return ntohs(sock_us.sin_port);
 #endif
        }
-
-       virtual int OnIncomingConnection(int newsock, char* ip)
-       {
-               Dispatch();
-               return false;
-       }
-
-       void Dispatch();
 };
 
-
 class SQLite3Result : public SQLresult
 {
 private:
+ private:
        int currentrow;
        int rows;
        int cols;
@@ -95,9 +116,9 @@ class SQLite3Result : public SQLresult
        SQLfieldList* fieldlist;
        SQLfieldMap* fieldmap;
 
 public:
-       SQLite3Result(Module* self, Module* to, unsigned int id)
-       : SQLresult(self, to, id), currentrow(0), rows(0), cols(0), fieldlist(NULL), fieldmap(NULL)
+ public:
+       SQLite3Result(Module* self, Module* to, unsigned int rid)
+       : SQLresult(self, to, rid), currentrow(0), rows(0), cols(0), fieldlist(NULL), fieldmap(NULL)
        {
        }
 
@@ -105,7 +126,7 @@ class SQLite3Result : public SQLresult
        {
        }
 
-       void AddRow(int colsnum, char **data, char **colname)
+       void AddRow(int colsnum, char **dat, char **colname)
        {
                colnames.clear();
                cols = colsnum;
@@ -113,7 +134,7 @@ class SQLite3Result : public SQLresult
                {
                        fieldlists.resize(fieldlists.size()+1);
                        colnames.push_back(colname[i]);
-                       SQLfield sf(data[i] ? data[i] : "", data[i] ? false : true);
+                       SQLfield sf(dat[i] ? dat[i] : "", dat[i] ? false : true);
                        fieldlists[rows].push_back(sf);
                }
                rows++;
@@ -251,20 +272,19 @@ class SQLite3Result : public SQLresult
 
 class SQLConn : public classbase
 {
 private:
+ private:
        ResultQueue results;
-       InspIRCd* Instance;
        Module* mod;
        SQLhost host;
        sqlite3* conn;
 
 public:
-       SQLConn(InspIRCd* SI, Module* m, const SQLhost& hi)
-       : Instance(SI), mod(m), host(hi)
+ public:
+       SQLConn(Module* m, const SQLhost& hi)
+       : mod(m), host(hi)
        {
                if (OpenDB() != SQLITE_OK)
                {
-                       Instance->Log(DEFAULT, "WARNING: Could not open DB with id: " + host.id);
+                       ServerInstance->Logs->Log("m_sqlite3",DEFAULT, "WARNING: Could not open DB with id: " + host.id);
                        CloseDB();
                }
        }
@@ -283,30 +303,84 @@ class SQLConn : public classbase
                char* queryend;
 
                /* Total length of the unescaped parameters */
-               unsigned long paramlen;
+               unsigned long maxparamlen, paramcount;
 
-               /* Total length of query, used for binary-safety in mysql_real_query */
-               unsigned long querylength = 0;
+               /* The length of the longest parameter */
+               maxparamlen = 0;
 
-               paramlen = 0;
                for(ParamL::iterator i = req.query.p.begin(); i != req.query.p.end(); i++)
                {
-                       paramlen += i->size();
+                       if (i->size() > maxparamlen)
+                               maxparamlen = i->size();
                }
 
+               /* How many params are there in the query? */
+               paramcount = count(req.query.q.c_str(), '?');
+
+               /* This stores copy of params to be inserted with using numbered params 1;3B*/
+               ParamL paramscopy(req.query.p);
+
                /* To avoid a lot of allocations, allocate enough memory for the biggest the escaped query could possibly be.
-                * sizeofquery + (totalparamlength*2) + 1
+                * sizeofquery + (maxtotalparamlength*2) + 1
                 *
-                * The +1 is for null-terminating the string for mysql_real_escape_string
+                * The +1 is for null-terminating the string
                 */
-               query = new char[req.query.q.length() + (paramlen*2) + 1];
+
+               query = new char[req.query.q.length() + (maxparamlen*paramcount*2) + 1];
                queryend = query;
 
                for(unsigned long i = 0; i < req.query.q.length(); i++)
                {
                        if(req.query.q[i] == '?')
                        {
-                               if(req.query.p.size())
+                               /* We found a place to substitute..what fun.
+                                * use sqlite calls to escape and write the
+                                * escaped string onto the end of our query buffer,
+                                * then we "just" need to make sure queryend is
+                                * pointing at the right place.
+                                */
+
+                               /* Is it numbered parameter?
+                                */
+
+                               bool numbered;
+                               numbered = false;
+
+                               /* Numbered parameter number :|
+                                */
+                               unsigned int paramnum;
+                               paramnum = 0;
+
+                               /* Let's check if it's a numbered param. And also calculate it's number.
+                                */
+
+                               while ((i < req.query.q.length() - 1) && (req.query.q[i+1] >= '0') && (req.query.q[i+1] <= '9'))
+                               {
+                                       numbered = true;
+                                       ++i;
+                                       paramnum = paramnum * 10 + req.query.q[i] - '0';
+                               }
+
+                               if (paramnum > paramscopy.size() - 1)
+                               {
+                                       /* index is out of range!
+                                        */
+                                       numbered = false;
+                               }
+
+
+                               if (numbered)
+                               {
+                                       char* escaped;
+                                       escaped = sqlite3_mprintf("%q", paramscopy[paramnum].c_str());
+                                       for (char* n = escaped; *n; n++)
+                                       {
+                                               *queryend = *n;
+                                               queryend++;
+                                       }
+                                       sqlite3_free(escaped);
+                               }
+                               else if (req.query.p.size())
                                {
                                        char* escaped;
                                        escaped = sqlite3_mprintf("%q", req.query.p.front().c_str());
@@ -326,7 +400,6 @@ class SQLConn : public classbase
                                *queryend = req.query.q[i];
                                queryend++;
                        }
-                       querylength++;
                }
                *queryend = 0;
                req.query.q = query;
@@ -346,7 +419,7 @@ class SQLConn : public classbase
                        sqlite3_free(errmsg);
                        delete[] query;
                        delete res;
-                       return SQLerror(QSEND_FAIL, error);
+                       return SQLerror(SQL_QSEND_FAIL, error);
                }
                delete[] query;
 
@@ -380,7 +453,7 @@ class SQLConn : public classbase
 
        int OpenDB()
        {
-               return sqlite3_open(host.host.c_str(), &conn);
+               return sqlite3_open_v2(host.host.c_str(), &conn, SQLITE_OPEN_READWRITE, 0);
        }
 
        void CloseDB()
@@ -427,32 +500,36 @@ class SQLConn : public classbase
 
        void SendNotify()
        {
-               int QueueFD;
-               if ((QueueFD = socket(AF_FAMILY, SOCK_STREAM, 0)) == -1)
+               if (QueueFD < 0)
                {
-                       /* crap, we're out of sockets... */
-                       return;
-               }
+                       if ((QueueFD = socket(AF_FAMILY, SOCK_STREAM, 0)) == -1)
+                       {
+                               /* crap, we're out of sockets... */
+                               return;
+                       }
 
-               insp_sockaddr addr;
+                       irc::sockets::insp_sockaddr addr;
 
 #ifdef IPV6
-               insp_aton("::1", &addr.sin6_addr);
-               addr.sin6_family = AF_FAMILY;
-               addr.sin6_port = htons(resultnotify->GetPort());
+                       irc::sockets::insp_aton("::1", &addr.sin6_addr);
+                       addr.sin6_family = AF_FAMILY;
+                       addr.sin6_port = htons(listener->GetPort());
 #else
-               insp_inaddr ia;
-               insp_aton("127.0.0.1", &ia);
-               addr.sin_family = AF_FAMILY;
-               addr.sin_addr = ia;
-               addr.sin_port = htons(resultnotify->GetPort());
+                       irc::sockets::insp_inaddr ia;
+                       irc::sockets::insp_aton("127.0.0.1", &ia);
+                       addr.sin_family = AF_FAMILY;
+                       addr.sin_addr = ia;
+                       addr.sin_port = htons(listener->GetPort());
 #endif
 
-               if (connect(QueueFD, (sockaddr*)&addr,sizeof(addr)) == -1)
-               {
-                       /* wtf, we cant connect to it, but we just created it! */
-                       return;
+                       if (connect(QueueFD, (sockaddr*)&addr,sizeof(addr)) == -1)
+                       {
+                               /* wtf, we cant connect to it, but we just created it! */
+                               return;
+                       }
                }
+               char id = 0;
+               send(QueueFD, &id, 1, 0);
        }
 
 };
@@ -460,13 +537,13 @@ class SQLConn : public classbase
 
 class ModuleSQLite3 : public Module
 {
 private:
+ private:
        ConnMap connections;
        unsigned long currid;
 
 public:
-       ModuleSQLite3(InspIRCd* Me)
-       : Module::Module(Me), currid(0)
+ public:
+       ModuleSQLite3()
+       : currid(0)
        {
                ServerInstance->Modules->UseInterface("SQLutils");
 
@@ -475,7 +552,22 @@ class ModuleSQLite3 : public Module
                        throw ModuleException("m_sqlite3: Unable to publish feature 'SQL'");
                }
 
-               resultnotify = new ResultNotifier(ServerInstance, this);
+               /* Create a socket on a random port. Let the tcp stack allocate us an available port */
+#ifdef IPV6
+               listener = new SQLiteListener(this, ServerInstance, 0, "::1");
+#else
+               listener = new SQLiteListener(this, ServerInstance, 0, "127.0.0.1");
+#endif
+
+               if (listener->GetFd() == -1)
+               {
+                       ServerInstance->Modules->DoneWithInterface("SQLutils");
+                       throw ModuleException("m_sqlite3: unable to create ITC pipe");
+               }
+               else
+               {
+                       ServerInstance->Logs->Log("m_sqlite3", DEBUG, "SQLite: Interthread comms port is %d", listener->GetPort());
+               }
 
                ReadConf();
 
@@ -488,11 +580,23 @@ class ModuleSQLite3 : public Module
        {
                ClearQueue();
                ClearAllConnections();
-               resultnotify->SetFd(-1);
-               resultnotify->state = I_ERROR;
-               resultnotify->OnError(I_ERR_SOCKET);
-               resultnotify->ClosePending = true;
-               delete resultnotify;
+
+               ServerInstance->SE->DelFd(listener);
+               ServerInstance->BufferedSocketCull();
+
+               if (QueueFD >= 0)
+               {
+                       shutdown(QueueFD, 2);
+                       close(QueueFD);
+               }
+
+               if (notifier)
+               {
+                       ServerInstance->SE->DelFd(notifier);
+                       notifier->Close();
+                       ServerInstance->BufferedSocketCull();
+               }
+
                ServerInstance->Modules->UnpublishInterface("SQL", this);
                ServerInstance->Modules->UnpublishFeature("SQL");
                ServerInstance->Modules->DoneWithInterface("SQLutils");
@@ -527,7 +631,7 @@ class ModuleSQLite3 : public Module
 
        bool HostInConf(const SQLhost &h)
        {
-               ConfigReader conf(ServerInstance);
+               ConfigReader conf;
                for(int i = 0; i < conf.Enumerate("database"); i++)
                {
                        SQLhost host;
@@ -537,7 +641,6 @@ class ModuleSQLite3 : public Module
                        host.name       = conf.ReadValue("database", "name", i);
                        host.user       = conf.ReadValue("database", "username", i);
                        host.pass       = conf.ReadValue("database", "password", i);
-                       host.ssl        = conf.ReadFlag("database", "ssl", "0", i);
                        if (h == host)
                                return true;
                }
@@ -548,7 +651,7 @@ class ModuleSQLite3 : public Module
        {
                ClearOldConnections();
 
-               ConfigReader conf(ServerInstance);
+               ConfigReader conf;
                for(int i = 0; i < conf.Enumerate("database"); i++)
                {
                        SQLhost host;
@@ -559,7 +662,6 @@ class ModuleSQLite3 : public Module
                        host.name       = conf.ReadValue("database", "name", i);
                        host.user       = conf.ReadValue("database", "username", i);
                        host.pass       = conf.ReadValue("database", "password", i);
-                       host.ssl        = conf.ReadFlag("database", "ssl", "0", i);
 
                        if (HasHost(host))
                                continue;
@@ -572,13 +674,13 @@ class ModuleSQLite3 : public Module
        {
                if (HasHost(hi))
                {
-                       ServerInstance->Log(DEFAULT, "WARNING: A sqlite connection with id: %s already exists. Aborting database open attempt.", hi.id.c_str());
+                       ServerInstance->Logs->Log("m_sqlite3",DEFAULT, "WARNING: A sqlite connection with id: %s already exists. Aborting database open attempt.", hi.id.c_str());
                        return;
                }
 
                SQLConn* newconn;
 
-               newconn = new SQLConn(ServerInstance, this, hi);
+               newconn = new SQLConn(this, hi);
 
                connections.insert(std::make_pair(hi.id, newconn));
        }
@@ -608,12 +710,12 @@ class ModuleSQLite3 : public Module
                }
        }
 
-       virtual void OnRehash(User* user, const std::string &parameter)
+       virtual void OnRehash(User* user)
        {
                ReadConf();
        }
 
-       virtual char* OnRequest(Request* request)
+       virtual const char* OnRequest(Request* request)
        {
                if(strcmp(SQLREQID, request->GetId()) == 0)
                {
@@ -627,7 +729,7 @@ class ModuleSQLite3 : public Module
                        }
                        else
                        {
-                               req->error.Id(BAD_DBID);
+                               req->error.Id(SQL_BAD_DBID);
                                return NULL;
                        }
                }
@@ -644,15 +746,14 @@ class ModuleSQLite3 : public Module
 
        virtual Version GetVersion()
        {
-               return Version(1,1,0,0,VF_VENDOR|VF_SERVICEPROVIDER,API_VERSION);
+               return Version("sqlite3 provider", VF_VENDOR | VF_SERVICEPROVIDER, API_VERSION);
        }
 
 };
 
 void ResultNotifier::Dispatch()
 {
-       ((ModuleSQLite3*)mod)->SendQueue();
+       mod->SendQueue();
 }
 
 MODULE_INIT(ModuleSQLite3)
-