]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Change Windows libraries to be dynamically linked
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index 689d69580836e515e5f238e4a607bc8dd97adb60..03673d7a06a4363aad55ca4ea5beb85644d20088 100644 (file)
 
 
 #include "inspircd.h"
+#ifndef _WIN32
+#include <gcrypt.h>
+#endif
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
-#include <gcrypt.h>
 #include "ssl.h"
 #include "m_cap.h"
 
+#ifdef _WIN32
+# pragma comment(lib, "libgnutls-28.lib")
+#endif
+
 /* $ModDesc: Provides SSL support for clients */
-/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") */
-/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") -lgcrypt */
+/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") exec("libgcrypt-config --cflags") */
+/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") exec("libgcrypt-config --libs") */
+/* $NoPedantic */
+
+#ifndef GNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MAJOR LIBGNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MINOR LIBGNUTLS_VERSION_MINOR
+#define GNUTLS_VERSION_PATCH LIBGNUTLS_VERSION_PATCH
+#endif
+
+// These don't exist in older GnuTLS versions
+#if ((GNUTLS_VERSION_MAJOR > 2) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR > 1) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR == 1 && GNUTLS_VERSION_PATCH >= 7))
+#define GNUTLS_NEW_PRIO_API
+#endif
+
+#if(GNUTLS_VERSION_MAJOR < 2)
+typedef gnutls_certificate_credentials_t gnutls_certificate_credentials;
+typedef gnutls_dh_params_t gnutls_dh_params;
+#endif
+
+#if (defined(_WIN32) && (GNUTLS_VERSION_MAJOR > 2 || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR >= 12)))
+# define GNUTLS_HAS_RND
+# include <gnutls/crypto.h>
+#else
+# include <gcrypt.h>
+#endif
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
 static std::vector<gnutls_x509_crt_t> x509_certs;
 static gnutls_x509_privkey_t x509_key;
+#if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
 static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
        const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr_st * st) {
 
        st->type = GNUTLS_CRT_X509;
+#else
+static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
+       const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr2_st * st) {
+       st->cert_type = GNUTLS_CRT_X509;
+       st->key_type = GNUTLS_PRIVKEY_X509;
+#endif
        st->ncerts = x509_certs.size();
        st->cert.x509 = &x509_certs[0];
        st->key.x509 = x509_key;
@@ -48,41 +85,17 @@ static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_c
        return 0;
 }
 
-static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t user_wrap, void* buffer, size_t size)
-{
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_READ_WILL_BLOCK)
-       {
-               errno = EAGAIN;
-               return -1;
-       }
-       int rv = ServerInstance->SE->Recv(user, reinterpret_cast<char *>(buffer), size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_READ_WILL_BLOCK);
-       return rv;
-}
-
-static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t user_wrap, const void* buffer, size_t size)
-{
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_WRITE_WILL_BLOCK)
-       {
-               errno = EAGAIN;
-               return -1;
-       }
-       int rv = ServerInstance->SE->Send(user, reinterpret_cast<const char *>(buffer), size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_WRITE_WILL_BLOCK);
-       return rv;
-}
-
 class RandGen : public HandlerBase2<void, char*, size_t>
 {
  public:
        RandGen() {}
        void Call(char* buffer, size_t len)
        {
+#ifdef GNUTLS_HAS_RND
+               gnutls_rnd(GNUTLS_RND_RANDOM, buffer, len);
+#else
                gcry_randomize(buffer, len, GCRY_STRONG_RANDOM);
+#endif
        }
 };
 
@@ -91,10 +104,12 @@ class RandGen : public HandlerBase2<void, char*, size_t>
 class issl_session
 {
 public:
+       StreamSocket* socket;
        gnutls_session_t sess;
        issl_status status;
        reference<ssl_cert> cert;
-       issl_session() : sess(NULL) {}
+
+       issl_session() : socket(NULL), sess(NULL) {}
 };
 
 class CommandStartTLS : public SplitCommand
@@ -148,9 +163,12 @@ class ModuleSSLGnuTLS : public Module
 {
        issl_session* sessions;
 
-       gnutls_certificate_credentials x509_cred;
-       gnutls_dh_params dh_params;
+       gnutls_certificate_credentials_t x509_cred;
+       gnutls_dh_params_t dh_params;
        gnutls_digest_algorithm_t hash;
+       #ifdef GNUTLS_NEW_PRIO_API
+       gnutls_priority_t priority;
+       #endif
 
        std::string sslports;
        int dh_bits;
@@ -163,16 +181,95 @@ class ModuleSSLGnuTLS : public Module
 
        GenericCap capHandler;
        ServiceProvider iohook;
+
+       inline static const char* UnknownIfNULL(const char* str)
+       {
+               return str ? str : "UNKNOWN";
+       }
+
+       static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t session_wrap, void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_READ_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Recv(session->socket, reinterpret_cast<char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_READ_WILL_BLOCK);
+               return rv;
+       }
+
+       static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t session_wrap, const void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_WRITE_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Send(session->socket, reinterpret_cast<const char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_WRITE_WILL_BLOCK);
+               return rv;
+       }
+
  public:
 
        ModuleSSLGnuTLS()
                : starttls(this), capHandler(this, "tls"), iohook(this, "ssl/gnutls", SERVICE_IOHOOK)
        {
+#ifndef GNUTLS_HAS_RND
+               gcry_control (GCRYCTL_INITIALIZATION_FINISHED, 0);
+#endif
+
                sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                gnutls_global_init(); // This must be called once in the program
                gnutls_x509_privkey_init(&x509_key);
 
+               #ifdef GNUTLS_NEW_PRIO_API
+               // Init this here so it's always initialized, avoids an extra boolean
+               gnutls_priority_init(&priority, "NORMAL", NULL);
+               #endif
+
                cred_alloc = false;
                dh_alloc = false;
        }
@@ -191,7 +288,7 @@ class ModuleSSLGnuTLS : public Module
                ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
                ServerInstance->Modules->AddService(iohook);
-               ServerInstance->AddCommand(&starttls);
+               ServerInstance->Modules->AddService(starttls);
        }
 
        void OnRehash(User* user)
@@ -203,6 +300,10 @@ class ModuleSSLGnuTLS : public Module
 
                if (Conf->getBool("showports", true))
                {
+                       sslports = Conf->getString("advertisedports");
+                       if (!sslports.empty())
+                               return;
+
                        for (size_t i = 0; i < ServerInstance->ports.size(); i++)
                        {
                                ListenSocket* port = ServerInstance->ports[i];
@@ -213,11 +314,20 @@ class ModuleSSLGnuTLS : public Module
                                ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
 
                                if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
-                                       sslports.append(portid).append(";");
+                               {
+                                       /*
+                                        * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
+                                        * the IP:port in ISUPPORT.
+                                        *
+                                        * We used to advertise all ports seperated by a ';' char that matched the above criteria,
+                                        * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
+                                        * To solve this by default we now only display the first IP:port found and let the user
+                                        * configure the exact value for the 005 token, if necessary.
+                                        */
+                                       sslports = portid;
+                                       break;
+                               }
                        }
-
-                       if (!sslports.empty())
-                               sslports.erase(sslports.end() - 1);
                }
        }
 
@@ -234,13 +344,20 @@ class ModuleSSLGnuTLS : public Module
 
                ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
 
-               cafile = Conf->getString("cafile", "conf/ca.pem");
-               crlfile = Conf->getString("crlfile", "conf/crl.pem");
-               certfile = Conf->getString("certfile", "conf/cert.pem");
-               keyfile = Conf->getString("keyfile", "conf/key.pem");
+               cafile = Conf->getString("cafile", CONFIG_PATH "/ca.pem");
+               crlfile = Conf->getString("crlfile", CONFIG_PATH "/crl.pem");
+               certfile = Conf->getString("certfile", CONFIG_PATH "/cert.pem");
+               keyfile = Conf->getString("keyfile", CONFIG_PATH "/key.pem");
                dh_bits = Conf->getInt("dhbits");
                std::string hashname = Conf->getString("hash", "md5");
 
+               // The GnuTLS manual states that the gnutls_set_default_priority()
+               // call we used previously when initializing the session is the same
+               // as setting the "NORMAL" priority string.
+               // Thus if the setting below is not in the config we will behave exactly
+               // the same as before, when the priority setting wasn't available.
+               std::string priorities = Conf->getString("priority", "NORMAL");
+
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
                        dh_bits = 1024;
 
@@ -258,6 +375,7 @@ class ModuleSSLGnuTLS : public Module
                {
                        gnutls_dh_params_deinit(dh_params);
                        dh_alloc = false;
+                       dh_params = NULL;
                }
 
                if (cred_alloc)
@@ -285,19 +403,30 @@ class ModuleSSLGnuTLS : public Module
 
                reader.LoadFile(certfile);
                std::string cert_string = reader.Contents();
-               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), cert_string.length() };
+               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), static_cast<unsigned int>(cert_string.length()) };
 
                reader.LoadFile(keyfile);
                std::string key_string = reader.Contents();
-               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), key_string.length() };
+               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), static_cast<unsigned int>(key_string.length()) };
 
                // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
-               unsigned int certcount = Conf->getInt("certcount", 3);
+               unsigned int certcount = 3;
                x509_certs.resize(certcount);
                ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
-               if (ret < 0)
-                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + std::string(gnutls_strerror(ret)));
-               x509_certs.resize(certcount);
+               if (ret == GNUTLS_E_SHORT_MEMORY_BUFFER)
+               {
+                       // the buffer wasn't big enough to hold all certs but gnutls updated certcount to the number of available certs, try again with a bigger buffer
+                       x509_certs.resize(certcount);
+                       ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
+               }
+
+               if (ret <= 0)
+               {
+                       // clear the vector so we won't call gnutls_x509_crt_deinit() on the (uninited) certs later
+                       x509_certs.clear();
+                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + ((ret < 0) ? (std::string(gnutls_strerror(ret))) : "No certs could be read"));
+               }
+               x509_certs.resize(ret);
 
                if((ret = gnutls_x509_privkey_import(x509_key, &key_datum, GNUTLS_X509_FMT_PEM)) < 0)
                        throw ModuleException("Unable to load GnuTLS server private key (" + keyfile + "): " + std::string(gnutls_strerror(ret)));
@@ -305,15 +434,59 @@ class ModuleSSLGnuTLS : public Module
                if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_certs[0], certcount, x509_key)) < 0)
                        throw ModuleException("Unable to set GnuTLS cert/key pair: " + std::string(gnutls_strerror(ret)));
 
-               gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
+               #ifdef GNUTLS_NEW_PRIO_API
+               // It's safe to call this every time as we cannot have this uninitialized, see constructor and below.
+               gnutls_priority_deinit(priority);
+
+               // Try to set the priorities for ciphers, kex methods etc. to the user supplied string
+               // If the user did not supply anything then the string is already set to "NORMAL"
+               const char* priocstr = priorities.c_str();
+               const char* prioerror;
+
+               if ((ret = gnutls_priority_init(&priority, priocstr, &prioerror)) < 0)
+               {
+                       // gnutls did not understand the user supplied string, log and fall back to the default priorities
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set priorities to \"%s\": %s Syntax error at position %u, falling back to default (NORMAL)", priorities.c_str(), gnutls_strerror(ret), (unsigned int) (prioerror - priocstr));
+                       gnutls_priority_init(&priority, "NORMAL", NULL);
+               }
 
+               #else
+               if (priorities != "NORMAL")
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: You've set <gnutls:priority> to a value other than the default, but this is only supported with GnuTLS v2.1.7 or newer. Your GnuTLS version is older than that so the option will have no effect.");
+               #endif
+
+               #if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
+               gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
+               #else
+               gnutls_certificate_set_retrieve_function (x509_cred, cert_callback);
+               #endif
                ret = gnutls_dh_params_init(&dh_params);
                dh_alloc = (ret >= 0);
                if (!dh_alloc)
+               {
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
+                       return;
+               }
+
+               std::string dhfile = Conf->getString("dhfile");
+               if (!dhfile.empty())
+               {
+                       // Try to load DH params from file
+                       reader.LoadFile(dhfile);
+                       std::string dhstring = reader.Contents();
+                       gnutls_datum_t dh_datum = { (unsigned char*)dhstring.data(), static_cast<unsigned int>(dhstring.length()) };
 
-               // This may be on a large (once a day or week) timer eventually.
-               GenerateDHParams();
+                       if ((ret = gnutls_dh_params_import_pkcs3(dh_params, &dh_datum, GNUTLS_X509_FMT_PEM)) < 0)
+                       {
+                               // File unreadable or GnuTLS was unhappy with the contents, generate the DH primes now
+                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Generating DH parameters because I failed to load them from file '%s': %s", dhfile.c_str(), gnutls_strerror(ret));
+                               GenerateDHParams();
+                       }
+               }
+               else
+               {
+                       GenerateDHParams();
+               }
        }
 
        void GenerateDHParams()
@@ -323,6 +496,9 @@ class ModuleSSLGnuTLS : public Module
                // once a day, once a week or once a month. Depending on the
                // security requirements.
 
+               if (!dh_alloc)
+                       return;
+
                int ret;
 
                if((ret = gnutls_dh_params_generate2(dh_params, dh_bits)) < 0)
@@ -335,6 +511,9 @@ class ModuleSSLGnuTLS : public Module
                        gnutls_x509_crt_deinit(x509_certs[i]);
 
                gnutls_x509_privkey_deinit(x509_key);
+               #ifdef GNUTLS_NEW_PRIO_API
+               gnutls_priority_deinit(priority);
+               #endif
 
                if (dh_alloc)
                        gnutls_dh_params_deinit(dh_params);
@@ -396,44 +575,44 @@ class ModuleSSLGnuTLS : public Module
                }
        }
 
-       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
+       void InitSession(StreamSocket* user, bool me_server)
        {
-               int fd = user->GetFd();
-               issl_session* session = &sessions[fd];
-
-               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
-               if (session->sess)
-                       return;
+               issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_SERVER);
+               gnutls_init(&session->sess, me_server ? GNUTLS_SERVER : GNUTLS_CLIENT);
+               session->socket = user;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
+               #ifdef GNUTLS_NEW_PRIO_API
+               gnutls_priority_set(session->sess, priority);
+               #else
+               gnutls_set_default_priority(session->sess);
+               #endif
                gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
-
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
+               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(session));
                gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
                gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 
-               gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
+               if (me_server)
+                       gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
 
                Handshake(session, user);
        }
 
-       void OnStreamSocketConnect(StreamSocket* user)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
                issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_CLIENT);
+               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
+               if (session->sess)
+                       return;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
-               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
-               gnutls_dh_set_prime_bits(session->sess, dh_bits);
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
-               gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
-               gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
+               InitSession(user, true);
+       }
 
-               Handshake(session, user);
+       void OnStreamSocketConnect(StreamSocket* user)
+       {
+               InitSession(user, false);
        }
 
        void OnStreamSocketClose(StreamSocket* user)
@@ -482,7 +661,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else if (ret == 0)
                        {
-                               user->SetError("SSL Connection closed");
+                               user->SetError("Connection closed");
                                CloseSession(session);
                                return -1;
                        }
@@ -577,7 +756,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else
                        {
-                               user->SetError(std::string("Handshake Failed - ") + gnutls_strerror(ret));
+                               user->SetError("Handshake Failed - " + std::string(gnutls_strerror(ret)));
                                CloseSession(session);
                                session->status = ISSL_CLOSING;
                        }
@@ -604,10 +783,12 @@ class ModuleSSLGnuTLS : public Module
                {
                        if (sessions[user->eh.GetFd()].sess)
                        {
+                               const gnutls_session_t& sess = sessions[user->eh.GetFd()].sess;
+                               std::string cipher = UnknownIfNULL(gnutls_kx_get_name(gnutls_kx_get(sess)));
+                               cipher.append("-").append(UnknownIfNULL(gnutls_cipher_get_name(gnutls_cipher_get(sess)))).append("-");
+                               cipher.append(UnknownIfNULL(gnutls_mac_get_name(gnutls_mac_get(sess))));
+
                                ssl_cert* cert = sessions[user->eh.GetFd()].cert;
-                               std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->eh.GetFd()].sess));
-                               cipher.append("-").append(gnutls_cipher_get_name(gnutls_cipher_get(sessions[user->eh.GetFd()].sess))).append("-");
-                               cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->eh.GetFd()].sess)));
                                if (cert->fingerprint.empty())
                                        user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
                                else
@@ -624,6 +805,7 @@ class ModuleSSLGnuTLS : public Module
                        gnutls_bye(session->sess, GNUTLS_SHUT_WR);
                        gnutls_deinit(session->sess);
                }
+               session->socket = NULL;
                session->sess = NULL;
                session->cert = NULL;
                session->status = ISSL_NONE;