]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Properly check if the SSL handshake is completed in m_ssl_gnutls, fixes the recent...
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index aae0397380b7ce358fd9f7f055100d485a31274d..151d10fd401543d1411fd56bc548f74391c422b7 100644 (file)
@@ -2,54 +2,43 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ *         the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <vector>
-
+#include "inspircd.h"
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
-
-#include "inspircd_config.h"
-#include "configreader.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
-
-#include "socket.h"
-#include "hashcomp.h"
-#include "inspircd.h"
-
 #include "transport.h"
+#include "m_cap.h"
 
 #ifdef WINDOWS
 #pragma comment(lib, "libgnutls-13.lib")
-#undef MAX_DESCRIPTORS
-#define MAX_DESCRIPTORS 10000
 #endif
 
 /* $ModDesc: Provides SSL support for clients */
 /* $CompileFlags: exec("libgnutls-config --cflags") */
 /* $LinkerFlags: rpath("libgnutls-config --libs") exec("libgnutls-config --libs") */
 /* $ModDep: transport.h */
-
+/* $CopyInstall: conf/key.pem $(CONPATH) */
+/* $CopyInstall: conf/cert.pem $(CONPATH) */
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
-bool isin(int port, const std::vector<int> &portlist)
+bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
 {
-       for(unsigned int i = 0; i < portlist.size(); i++)
-               if(portlist[i] == port)
-                       return true;
+       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
+               return true;
+
+       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
+               return true;
 
-       return false;
+       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
 }
 
 /** Represents an SSL user's extra data
@@ -57,6 +46,11 @@ bool isin(int port, const std::vector<int> &portlist)
 class issl_session : public classbase
 {
 public:
+       issl_session()
+       {
+               sess = NULL;
+       }
+
        gnutls_session_t sess;
        issl_status status;
        std::string outbuf;
@@ -65,6 +59,42 @@ public:
        int fd;
 };
 
+class CommandStartTLS : public Command
+{
+       Module* Caller;
+ public:
+       /* Command 'dalinfo', takes no parameters and needs no special modes */
+       CommandStartTLS (InspIRCd* Instance, Module* mod) : Command(Instance,"STARTTLS", 0, 0, true), Caller(mod)
+       {
+               this->source = "m_ssl_gnutls.so";
+       }
+
+       CmdResult Handle (const std::vector<std::string> &parameters, User *user)
+       {
+               /* changed from == REG_ALL to catch clients sending STARTTLS
+                * after NICK and USER but before OnUserConnect completes and
+                * give a proper error message (see bug #645) - dz
+                */
+               if (user->registered != REG_NONE)
+               {
+                       ServerInstance->Users->QuitUser(user, "STARTTLS is not permitted after client registration has started");
+               }
+               else
+               {
+                       if (!user->GetIOHook())
+                       {
+                               user->WriteNumeric(670, "%s :STARTTLS successful, go ahead with TLS handshake", user->nick.c_str());
+                               user->AddIOHook(Caller);
+                               Caller->OnRawSocketAccept(user->GetFd(), user->GetIPString(), user->GetPort());
+                       }
+                       else
+                               user->WriteNumeric(691, "%s :STARTTLS failure", user->nick.c_str());
+               }
+
+               return CMD_FAILURE;
+       }
+};
+
 class ModuleSSLGnuTLS : public Module
 {
 
@@ -72,10 +102,10 @@ class ModuleSSLGnuTLS : public Module
 
        char* dummy;
 
-       std::vector<int> listenports;
+       std::vector<std::string> listenports;
 
        int inbufsize;
-       issl_session sessions[MAX_DESCRIPTORS];
+       issl_session* sessions;
 
        gnutls_certificate_credentials x509_cred;
        gnutls_dh_params dh_params;
@@ -84,58 +114,60 @@ class ModuleSSLGnuTLS : public Module
        std::string certfile;
        std::string cafile;
        std::string crlfile;
+       std::string sslports;
        int dh_bits;
 
        int clientactive;
+       bool cred_alloc;
+
+       CommandStartTLS* starttls;
 
  public:
 
        ModuleSSLGnuTLS(InspIRCd* Me)
                : Module(Me)
        {
-               ServerInstance->PublishInterface("InspSocketHook", this);
+               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
+
+               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
 
                gnutls_global_init(); // This must be called once in the program
 
-               if(gnutls_certificate_allocate_credentials(&x509_cred) != 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to allocate certificate credentials");
-
-               // Guessing return meaning
-               if(gnutls_dh_params_init(&dh_params) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters");
-
+               cred_alloc = false;
                // Needs the flag as it ignores a plain /rehash
                OnRehash(NULL,"ssl");
 
                // Void return, guess we assume success
                gnutls_certificate_set_dh_params(x509_cred, dh_params);
+               Implementation eventlist[] = { I_On005Numeric, I_OnRawSocketConnect, I_OnRawSocketAccept, I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup,
+                       I_OnBufferFlushed, I_OnRequest, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUnloadModule, I_OnRehash, I_OnWhois, I_OnPostConnect, I_OnEvent, I_OnHookUserIO };
+               ServerInstance->Modules->Attach(eventlist, this, 17);
+
+               starttls = new CommandStartTLS(ServerInstance, this);
+               ServerInstance->AddCommand(starttls);
        }
 
-       virtual void OnRehash(userrec* user, const std::string &param)
+       virtual void OnRehash(User* user, const std::string &param)
        {
-               if(param != "ssl")
-                       return;
-
                Conf = new ConfigReader(ServerInstance);
 
-               for(unsigned int i = 0; i < listenports.size(); i++)
-               {
-                       ServerInstance->Config->DelIOHook(listenports[i]);
-               }
-
                listenports.clear();
                clientactive = 0;
+               sslports.clear();
 
-               for(int i = 0; i < Conf->Enumerate("bind"); i++)
+               for(int index = 0; index < Conf->Enumerate("bind"); index++)
                {
                        // For each <bind> tag
-                       if(((Conf->ReadValue("bind", "type", i) == "") || (Conf->ReadValue("bind", "type", i) == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "gnutls"))
+                       std::string x = Conf->ReadValue("bind", "type", index);
+                       if(((x.empty()) || (x == "clients")) && (Conf->ReadValue("bind", "ssl", index) == "gnutls"))
                        {
                                // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf->ReadValue("bind", "port", i);
+                               std::string port = Conf->ReadValue("bind", "port", index);
+                               std::string addr = Conf->ReadValue("bind", "address", index);
+
                                irc::portparser portrange(port, false);
                                long portno = -1;
                                while ((portno = portrange.GetToken()))
@@ -143,27 +175,32 @@ class ModuleSSLGnuTLS : public Module
                                        clientactive++;
                                        try
                                        {
-                                               if (ServerInstance->Config->AddIOHook(portno, this))
-                                               {
-                                                       listenports.push_back(portno);
-                                                       for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
-                                                               if (ServerInstance->Config->ports[i]->GetPort() == portno)
-                                                                       ServerInstance->Config->ports[i]->SetDescription("ssl");
-                                                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %d", portno);
-                                               }
-                                               else
-                                               {
-                                                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?", portno);
-                                               }
+                                               listenports.push_back(addr + ":" + ConvToStr(portno));
+
+                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
+                                                       if ((ServerInstance->Config->ports[i]->GetPort() == portno) && (ServerInstance->Config->ports[i]->GetIP() == addr))
+                                                               ServerInstance->Config->ports[i]->SetDescription("ssl");
+                                               ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %ld", portno);
+
+                                               sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
                                        }
                                        catch (ModuleException &e)
                                        {
-                                               ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %d: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
+                                               ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
                                        }
                                }
                        }
                }
 
+               if (!sslports.empty())
+                       sslports.erase(sslports.end() - 1);
+
+               if(param != "ssl")
+               {
+                       delete Conf;
+                       return;
+               }
+
                std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
                confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
@@ -175,50 +212,67 @@ class ModuleSSLGnuTLS : public Module
                dh_bits = Conf->ReadInteger("gnutls", "dhbits", 0, false);
 
                // Set all the default values needed.
-               if(cafile == "")
+               if (cafile.empty())
                        cafile = "ca.pem";
 
-               if(crlfile == "")
+               if (crlfile.empty())
                        crlfile = "crl.pem";
 
-               if(certfile == "")
+               if (certfile.empty())
                        certfile = "cert.pem";
 
-               if(keyfile == "")
+               if (keyfile.empty())
                        keyfile = "key.pem";
 
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
                        dh_bits = 1024;
 
                // Prepend relative paths with the path to the config directory.
-               if(cafile[0] != '/')
+               if ((cafile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(cafile)))
                        cafile = confdir + cafile;
 
-               if(crlfile[0] != '/')
+               if ((crlfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(crlfile)))
                        crlfile = confdir + crlfile;
 
-               if(certfile[0] != '/')
+               if ((certfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(certfile)))
                        certfile = confdir + certfile;
 
-               if(keyfile[0] != '/')
+               if ((keyfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(keyfile)))
                        keyfile = confdir + keyfile;
 
                int ret;
-
+               
+               if (cred_alloc)
+               {
+                       // Deallocate the old credentials
+                       gnutls_dh_params_deinit(dh_params);
+                       gnutls_certificate_free_credentials(x509_cred);
+               }
+               else
+                       cred_alloc = true;
+               
+               if((ret = gnutls_certificate_allocate_credentials(&x509_cred)) < 0)
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to allocate certificate credentials: %s", gnutls_strerror(ret));
+               
+               if((ret = gnutls_dh_params_init(&dh_params)) < 0)
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
+               
                if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
 
                if((ret = gnutls_certificate_set_x509_crl_file (x509_cred, crlfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
 
-               // Guessing on the return value of this, manual doesn't say :|
                if((ret = gnutls_certificate_set_x509_key_file (x509_cred, certfile.c_str(), keyfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 certificate and key files '%s' and '%s': %s", certfile.c_str(), keyfile.c_str(), gnutls_strerror(ret));
+               {
+                       // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
+                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + ", key: " + keyfile + "): " + std::string(gnutls_strerror(ret)));
+               }
 
                // This may be on a large (once a day or week) timer eventually.
                GenerateDHParams();
 
-               DELETE(Conf);
+               delete Conf;
        }
 
        void GenerateDHParams()
@@ -231,7 +285,7 @@ class ModuleSSLGnuTLS : public Module
                int ret;
 
                if((ret = gnutls_dh_params_generate2(dh_params, dh_bits)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
        }
 
        virtual ~ModuleSSLGnuTLS()
@@ -239,21 +293,24 @@ class ModuleSSLGnuTLS : public Module
                gnutls_dh_params_deinit(dh_params);
                gnutls_certificate_free_credentials(x509_cred);
                gnutls_global_deinit();
+               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
+               delete[] sessions;
        }
 
        virtual void OnCleanup(int target_type, void* item)
        {
                if(target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
+                       User* user = (User*)item;
 
-                       if(user->GetExt("ssl", dummy) && isin(user->GetPort(), listenports))
+                       if (user->GetIOHook() == this)
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->GlobalCulls.AddItem(user, "SSL module unloading");
+                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
+                               user->DelIOHook();
                        }
-                       if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
+                       if (user->GetExt("ssl_cert", dummy))
                        {
                                ssl_cert* tofree;
                                user->GetExt("ssl_cert", tofree);
@@ -269,9 +326,8 @@ class ModuleSSLGnuTLS : public Module
                {
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
-                               ServerInstance->Config->DelIOHook(listenports[i]);
                                for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
-                                       if (ServerInstance->Config->ports[j]->GetPort() == listenports[i])
+                                       if (listenports[i] == (ServerInstance->Config->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->Config->ports[j]->GetPort())))
                                                ServerInstance->Config->ports[j]->SetDescription("plaintext");
                        }
                }
@@ -279,16 +335,25 @@ class ModuleSSLGnuTLS : public Module
 
        virtual Version GetVersion()
        {
-               return Version(1, 1, 0, 0, VF_VENDOR, API_VERSION);
+               return Version("$Id$", VF_VENDOR, API_VERSION);
        }
 
-       void Implements(char* List)
+
+       virtual void On005Numeric(std::string &output)
        {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
+               output.append(" SSL=" + sslports);
        }
 
-       virtual char* OnRequest(Request* request)
+       virtual void OnHookUserIO(User* user, const std::string &targetip)
+       {
+               if (!user->GetIOHook() && isin(targetip,user->GetPort(),listenports))
+               {
+                       /* Hook the user with our module */
+                       user->AddIOHook(this);
+               }
+       }
+
+       virtual const char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
                if (strcmp("IS_NAME", request->GetId()) == 0)
@@ -297,10 +362,10 @@ class ModuleSSLGnuTLS : public Module
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       char* ret = "OK";
+                       const char* ret = "OK";
                        try
                        {
-                               ret = ServerInstance->Config->AddIOHook((Module*)this, (InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                               ret = ISR->Sock->AddIOHook((Module*)this) ? "OK" : NULL;
                        }
                        catch (ModuleException &e)
                        {
@@ -310,15 +375,15 @@ class ModuleSSLGnuTLS : public Module
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ServerInstance->Config->DelIOHook((InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                       return ISR->Sock->DelIOHook() ? "OK" : NULL;
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
                        if (ISR->Sock->GetFd() < 0)
-                               return (char*)"OK";
+                               return "OK";
 
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       return (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE) ? NULL : (char*)"OK";
+                       return (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE) ? NULL : "OK";
                }
                else if (strcmp("IS_ATTACH", request->GetId()) == 0)
                {
@@ -329,7 +394,7 @@ class ModuleSSLGnuTLS : public Module
                                {
                                        if ((Extensible*)ServerInstance->FindDescriptor(ISR->Sock->GetFd()) == (Extensible*)(ISR->Sock))
                                        {
-                                               VerifyCertificate(session, (InspSocket*)ISR->Sock);
+                                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                                return "OK";
                                        }
                                }
@@ -341,8 +406,16 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                issl_session* session = &sessions[fd];
 
+               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
+               if (session->sess)
+                       return;
+
                session->fd = fd;
                session->inbuf = new char[inbufsize];
                session->inbufoffset = 0;
@@ -370,6 +443,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketConnect(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -388,6 +465,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds()))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -403,6 +484,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -425,6 +510,7 @@ class ModuleSSLGnuTLS : public Module
                else if (session->status == ISSL_HANDSHAKING_WRITE)
                {
                        errno = EAGAIN;
+                       MakePollWrite(session);
                        return -1;
                }
 
@@ -452,6 +538,9 @@ class ModuleSSLGnuTLS : public Module
                                }
                                else
                                {
+                                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
+                                                       "m_ssl_gnutls.so: Error while reading on fd %d: %s",
+                                                       session->fd, gnutls_strerror(ret));
                                        readresult = 0;
                                        CloseSession(session);
                                }
@@ -468,7 +557,7 @@ class ModuleSSLGnuTLS : public Module
                                {
                                        memcpy(buffer, session->inbuf, count);
                                        // Move the stuff left in inbuf to the beginning of it
-                                       memcpy(session->inbuf, session->inbuf + count, (length - count));
+                                       memmove(session->inbuf, session->inbuf + count, (length - count));
                                        // Now we need to set session->inbufoffset to the amount of data still waiting to be handed to insp.
                                        session->inbufoffset = length - count;
                                        // Insp uses readresult as the count of how much data there is in buffer, so:
@@ -493,7 +582,8 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
-               if (!count)
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return 0;
 
                issl_session* session = &sessions[fd];
@@ -509,7 +599,7 @@ class ModuleSSLGnuTLS : public Module
                sendbuffer = session->outbuf.c_str();
                count = session->outbuf.size();
 
-               if(session->status == ISSL_HANDSHAKING_WRITE)
+               if (session->status == ISSL_HANDSHAKING_WRITE || session->status == ISSL_HANDSHAKING_READ)
                {
                        // The handshake isn't finished, try to finish it.
                        Handshake(session);
@@ -519,11 +609,11 @@ class ModuleSSLGnuTLS : public Module
 
                int ret = 0;
 
-               if(session->status == ISSL_HANDSHAKEN)
+               if (session->status == ISSL_HANDSHAKEN)
                {
                        ret = gnutls_record_send(session->sess, sendbuffer, count);
 
-                       if(ret == 0)
+                       if (ret == 0)
                        {
                                CloseSession(session);
                        }
@@ -531,12 +621,14 @@ class ModuleSSLGnuTLS : public Module
                        {
                                if(ret != GNUTLS_E_AGAIN && ret != GNUTLS_E_INTERRUPTED)
                                {
+                                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
+                                                       "m_ssl_gnutls.so: Error while writing to fd %d: %s",
+                                                       session->fd, gnutls_strerror(ret));
                                        CloseSession(session);
                                }
                                else
                                {
                                        errno = EAGAIN;
-                                       return -1;
                                }
                        }
                        else
@@ -545,26 +637,28 @@ class ModuleSSLGnuTLS : public Module
                        }
                }
 
+               MakePollWrite(session);
+
                /* Who's smart idea was it to return 1 when we havent written anything?
-                * This fucks the buffer up in InspSocket :p
+                * This fucks the buffer up in BufferedSocket :p
                 */
                return ret < 1 ? 0 : ret;
        }
 
        // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(userrec* source, userrec* dest)
+       virtual void OnWhois(User* source, User* dest)
        {
                if (!clientactive)
                        return;
 
                // Bugfix, only send this numeric for *our* SSL users
-               if(dest->GetExt("ssl", dummy) || (IS_LOCAL(dest) &&  isin(dest->GetPort(), listenports)))
+               if (dest->GetExt("ssl", dummy) || ((IS_LOCAL(dest) && (dest->GetIOHook() == this))))
                {
-                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick, dest->nick);
+                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick.c_str(), dest->nick.c_str());
                }
        }
 
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
+       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
        {
                // check if the linking module wants to know about OUR metadata
                if(extname == "ssl")
@@ -584,7 +678,7 @@ class ModuleSSLGnuTLS : public Module
                // check if its our metadata key, and its associated with a user
                if ((target_type == TYPE_USER) && (extname == "ssl"))
                {
-                       userrec* dest = (userrec*)target;
+                       User* dest = (User*)target;
                        // if they dont already have an ssl flag, accept the remote server's
                        if (!dest->GetExt(extname, dummy))
                        {
@@ -618,6 +712,9 @@ class ModuleSSLGnuTLS : public Module
                        else
                        {
                                // Handshake failed.
+                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
+                                               "m_ssl_gnutls.so: Handshake failed on fd %d: %s",
+                                               session->fd, gnutls_strerror(ret));
                                CloseSession(session);
                                session->status = ISSL_CLOSING;
                        }
@@ -628,7 +725,7 @@ class ModuleSSLGnuTLS : public Module
                {
                        // Handshake complete.
                        // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       userrec* extendme = ServerInstance->FindDescriptor(session->fd);
+                       User* extendme = ServerInstance->FindDescriptor(session->fd);
                        if (extendme)
                        {
                                if (!extendme->GetExt("ssl", dummy))
@@ -645,21 +742,14 @@ class ModuleSSLGnuTLS : public Module
                }
        }
 
-       virtual void OnPostConnect(userrec* user)
+       virtual void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
-               if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
+               // protocol module has propagated the NICK message.
+               if (user->GetIOHook() == this && (IS_LOCAL(user)))
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
-                       std::deque<std::string>* metadata = new std::deque<std::string>;
-                       metadata->push_back(user->nick);
-                       metadata->push_back("ssl");             // The metadata id
-                       metadata->push_back("ON");              // The value to send
-                       Event* event = new Event((char*)metadata,(Module*)this,"send_metadata");
-                       event->Send(ServerInstance);            // Trigger the event. We don't care what module picks it up.
-                       DELETE(event);
-                       DELETE(metadata);
+                       ServerInstance->PI->SendMetaData(user, TYPE_USER, "SSL", "on");
 
                        VerifyCertificate(&sessions[user->GetFd()],user);
                        if (sessions[user->GetFd()].sess)
@@ -667,14 +757,27 @@ class ModuleSSLGnuTLS : public Module
                                std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->GetFd()].sess));
                                cipher.append("-").append(gnutls_cipher_get_name(gnutls_cipher_get(sessions[user->GetFd()].sess))).append("-");
                                cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->GetFd()].sess)));
-                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick, cipher.c_str());
+                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
                        }
                }
        }
 
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
+               if (eh)
+                       ServerInstance->SE->WantWrite(eh);
+       }
+
+       virtual void OnBufferFlushed(User* user)
+       {
+               if (user->GetIOHook() == this)
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
 
        void CloseSession(issl_session* session)
@@ -813,7 +916,7 @@ class ModuleSSLGnuTLS : public Module
 
                /* Beware here we do not check for errors.
                 */
-               if ((gnutls_x509_crt_get_expiration_time(cert) < time(0)) || (gnutls_x509_crt_get_activation_time(cert) > time(0)))
+               if ((gnutls_x509_crt_get_expiration_time(cert) < ServerInstance->Time()) || (gnutls_x509_crt_get_activation_time(cert) > ServerInstance->Time()))
                {
                        certinfo->data.insert(std::make_pair("error","Not activated, or expired certificate"));
                }
@@ -823,27 +926,16 @@ class ModuleSSLGnuTLS : public Module
                return;
        }
 
-};
-
-class ModuleSSLGnuTLSFactory : public ModuleFactory
-{
- public:
-       ModuleSSLGnuTLSFactory()
+       void OnEvent(Event* ev)
        {
+               GenericCapHandler(ev, "tls", "tls");
        }
 
-       ~ModuleSSLGnuTLSFactory()
+       void Prioritize()
        {
-       }
-
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSSLGnuTLS(Me);
+               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
+               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIO_AFTER, &server);
        }
 };
 
-
-extern "C" DllExport void * init_module( void )
-{
-       return new ModuleSSLGnuTLSFactory;
-}
+MODULE_INIT(ModuleSSLGnuTLS)