]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Remove InspIRCd* parameters and fields
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index c81be9f7bb16f476f4f9399dac0947ccf5f7252a..1fe84649f57b00578fc3c3add315da3ccb7cafb5 100644 (file)
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
-bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
-{
-       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
-               return true;
+static gnutls_x509_crt_t x509_cert;
+static gnutls_x509_privkey_t x509_key;
+static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
+       const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr_st * st) {
+
+       st->type = GNUTLS_CRT_X509;
+       st->ncerts = 1;
+       st->cert.x509 = &x509_cert;
+       st->key.x509 = x509_key;
+       st->deinit_all = 0;
+
+       return 0;
+}
 
-       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
-               return true;
+static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t user_wrap, void* buffer, size_t size)
+{
+       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
+       if (user->GetEventMask() & FD_READ_WILL_BLOCK)
+       {
+               errno = EAGAIN;
+               return -1;
+       }
+       int rv = recv(user->GetFd(), buffer, size, 0);
+       if (rv < (int)size)
+               ServerInstance->SE->ChangeEventMask(user, FD_READ_WILL_BLOCK);
+       return rv;
+}
 
-       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
+static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t user_wrap, const void* buffer, size_t size)
+{
+       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
+       if (user->GetEventMask() & FD_WRITE_WILL_BLOCK)
+       {
+               errno = EAGAIN;
+               return -1;
+       }
+       int rv = send(user->GetFd(), buffer, size, 0);
+       if (rv < (int)size)
+               ServerInstance->SE->ChangeEventMask(user, FD_WRITE_WILL_BLOCK);
+       return rv;
 }
 
 /** Represents an SSL user's extra data
@@ -53,16 +84,14 @@ public:
 
        gnutls_session_t sess;
        issl_status status;
-       std::string outbuf;
 };
 
 class CommandStartTLS : public Command
 {
-       Module* Caller;
  public:
-       CommandStartTLS (InspIRCd* Instance, Module* mod) : Command(Instance,"STARTTLS", 0, 0, true), Caller(mod)
+       CommandStartTLS (Module* mod) : Command(mod, "STARTTLS")
        {
-               this->source = "m_ssl_gnutls.so";
+               works_before_reg = true;
        }
 
        CmdResult Handle (const std::vector<std::string> &parameters, User *user)
@@ -80,8 +109,8 @@ class CommandStartTLS : public Command
                        if (!user->GetIOHook())
                        {
                                user->WriteNumeric(670, "%s :STARTTLS successful, go ahead with TLS handshake", user->nick.c_str());
-                               user->AddIOHook(Caller);
-                               Caller->OnRawSocketAccept(user->GetFd(), user->GetIPString(), user->GetPort());
+                               user->AddIOHook(creator);
+                               creator->OnStreamSocketAccept(user, NULL, NULL);
                        }
                        else
                                user->WriteNumeric(691, "%s :STARTTLS failure", user->nick.c_str());
@@ -93,7 +122,7 @@ class CommandStartTLS : public Command
 
 class ModuleSSLGnuTLS : public Module
 {
-       std::vector<std::string> listenports;
+       std::set<ListenSocketBase*> listenports;
 
        issl_session* sessions;
 
@@ -107,21 +136,23 @@ class ModuleSSLGnuTLS : public Module
        std::string sslports;
        int dh_bits;
 
-       int clientactive;
        bool cred_alloc;
 
-       CommandStartTLS* starttls;
+       CommandStartTLS starttls;
 
+       GenericCap capHandler;
  public:
 
-       ModuleSSLGnuTLS(InspIRCd* Me)
-               : Module(Me)
+       ModuleSSLGnuTLS()
+               : starttls(this), capHandler(this, "tls")
        {
                ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
                sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                gnutls_global_init(); // This must be called once in the program
+               gnutls_x509_crt_init(&x509_cert);
+               gnutls_x509_privkey_init(&x509_key);
 
                cred_alloc = false;
                // Needs the flag as it ignores a plain /rehash
@@ -129,80 +160,47 @@ class ModuleSSLGnuTLS : public Module
 
                // Void return, guess we assume success
                gnutls_certificate_set_dh_params(x509_cred, dh_params);
-               Implementation eventlist[] = { I_On005Numeric, I_OnRawSocketConnect, I_OnRawSocketAccept,
-                       I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup,
-                       I_OnBufferFlushed, I_OnRequest, I_OnUnloadModule, I_OnRehash, I_OnModuleRehash,
-                       I_OnPostConnect, I_OnEvent, I_OnHookUserIO };
+               Implementation eventlist[] = { I_On005Numeric, I_OnRequest, I_OnRehash, I_OnModuleRehash, I_OnPostConnect,
+                       I_OnEvent, I_OnHookIO };
                ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
-               starttls = new CommandStartTLS(ServerInstance, this);
-               ServerInstance->AddCommand(starttls);
+               ServerInstance->AddCommand(&starttls);
        }
 
-       virtual void OnRehash(User* user)
+       void OnRehash(User* user)
        {
-               ConfigReader Conf(ServerInstance);
+               ConfigReader Conf;
 
                listenports.clear();
-               clientactive = 0;
                sslports.clear();
 
-               for(int index = 0; index < Conf.Enumerate("bind"); index++)
+               for (size_t i = 0; i < ServerInstance->ports.size(); i++)
                {
-                       // For each <bind> tag
-                       std::string x = Conf.ReadValue("bind", "type", index);
-                       if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "gnutls"))
-                       {
-                               // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf.ReadValue("bind", "port", index);
-                               std::string addr = Conf.ReadValue("bind", "address", index);
-
-                               if (!addr.empty())
-                               {
-                                       // normalize address, important for IPv6
-                                       int portint = 0;
-                                       irc::sockets::sockaddrs bin;
-                                       if (irc::sockets::aptosa(addr.c_str(), portint, &bin))
-                                               irc::sockets::satoap(&bin, addr, portint);
-                               }
-
-                               irc::portparser portrange(port, false);
-                               long portno = -1;
-                               while ((portno = portrange.GetToken()))
-                               {
-                                       clientactive++;
-                                       try
-                                       {
-                                               listenports.push_back(addr + ":" + ConvToStr(portno));
+                       ListenSocketBase* port = ServerInstance->ports[i];
+                       std::string desc = port->GetDescription();
+                       if (desc != "gnutls")
+                               continue;
 
-                                               for (size_t i = 0; i < ServerInstance->ports.size(); i++)
-                                                       if ((ServerInstance->ports[i]->GetPort() == portno) && (ServerInstance->ports[i]->GetIP() == addr))
-                                                               ServerInstance->ports[i]->SetDescription("ssl");
-                                               ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %ld", portno);
+                       listenports.insert(port);
+                       std::string portid = port->GetBindDesc();
 
-                                               if (addr != "127.0.0.1")
-                                                       sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
-                                       }
-                                       catch (ModuleException &e)
-                                       {
-                                               ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
-                                       }
-                               }
-                       }
+                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
+                       if (port->GetIP() != "127.0.0.1")
+                               sslports.append(portid).append(";");
                }
 
                if (!sslports.empty())
                        sslports.erase(sslports.end() - 1);
        }
 
-       virtual void OnModuleRehash(User* user, const std::string &param)
+       void OnModuleRehash(User* user, const std::string &param)
        {
                if(param != "ssl")
                        return;
 
                OnRehash(user);
 
-               ConfigReader Conf(ServerInstance);
+               ConfigReader Conf;
 
                std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
@@ -255,22 +253,38 @@ class ModuleSSLGnuTLS : public Module
                        cred_alloc = true;
 
                if((ret = gnutls_certificate_allocate_credentials(&x509_cred)) < 0)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to allocate certificate credentials: %s", gnutls_strerror(ret));
-
-               if((ret = gnutls_dh_params_init(&dh_params)) < 0)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to allocate certificate credentials: %s", gnutls_strerror(ret));
 
                if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
 
                if((ret = gnutls_certificate_set_x509_crl_file (x509_cred, crlfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
 
-               if((ret = gnutls_certificate_set_x509_key_file (x509_cred, certfile.c_str(), keyfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-               {
-                       // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
-                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + ", key: " + keyfile + "): " + std::string(gnutls_strerror(ret)));
-               }
+               FileReader reader(ServerInstance);
+
+               reader.LoadFile(certfile);
+               std::string cert_string = reader.Contents();
+               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), cert_string.length() };
+
+               reader.LoadFile(keyfile);
+               std::string key_string = reader.Contents();
+               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), key_string.length() };
+
+               // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
+               if((ret = gnutls_x509_crt_import(x509_cert, &cert_datum, GNUTLS_X509_FMT_PEM)) < 0)
+                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + std::string(gnutls_strerror(ret)));
+
+               if((ret = gnutls_x509_privkey_import(x509_key, &key_datum, GNUTLS_X509_FMT_PEM)) < 0)
+                       throw ModuleException("Unable to load GnuTLS server private key (" + keyfile + "): " + std::string(gnutls_strerror(ret)));
+
+               if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_cert, 1, x509_key)) < 0)
+                       throw ModuleException("Unable to set GnuTLS cert/key pair: " + std::string(gnutls_strerror(ret)));
+
+               gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
+
+               if((ret = gnutls_dh_params_init(&dh_params)) < 0)
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
 
                // This may be on a large (once a day or week) timer eventually.
                GenerateDHParams();
@@ -289,8 +303,10 @@ class ModuleSSLGnuTLS : public Module
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
        }
 
-       virtual ~ModuleSSLGnuTLS()
+       ~ModuleSSLGnuTLS()
        {
+               gnutls_x509_crt_deinit(x509_cert);
+               gnutls_x509_privkey_deinit(x509_key);
                gnutls_dh_params_deinit(dh_params);
                gnutls_certificate_free_credentials(x509_cred);
                gnutls_global_deinit();
@@ -298,11 +314,11 @@ class ModuleSSLGnuTLS : public Module
                delete[] sessions;
        }
 
-       virtual void OnCleanup(int target_type, void* item)
+       void OnCleanup(int target_type, void* item)
        {
                if(target_type == TYPE_USER)
                {
-                       User* user = (User*)item;
+                       User* user = static_cast<User*>(item);
 
                        if (user->GetIOHook() == this)
                        {
@@ -311,74 +327,47 @@ class ModuleSSLGnuTLS : public Module
                                ServerInstance->Users->QuitUser(user, "SSL module unloading");
                                user->DelIOHook();
                        }
-                       if (user->GetExt("ssl_cert"))
-                       {
-                               ssl_cert* tofree;
-                               user->GetExt("ssl_cert", tofree);
-                               delete tofree;
-                               user->Shrink("ssl_cert");
-                       }
-               }
-       }
-
-       virtual void OnUnloadModule(Module* mod, const std::string &name)
-       {
-               if(mod == this)
-               {
-                       for(unsigned int i = 0; i < listenports.size(); i++)
-                       {
-                               for (size_t j = 0; j < ServerInstance->ports.size(); j++)
-                                       if (listenports[i] == (ServerInstance->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->ports[j]->GetPort())))
-                                               ServerInstance->ports[j]->SetDescription("plaintext");
-                       }
                }
        }
 
-       virtual Version GetVersion()
+       Version GetVersion()
        {
-               return Version("$Id$", VF_VENDOR, API_VERSION);
+               return Version("Provides SSL support for clients", VF_VENDOR, API_VERSION);
        }
 
 
-       virtual void On005Numeric(std::string &output)
+       void On005Numeric(std::string &output)
        {
                if (!sslports.empty())
                        output.append(" SSL=" + sslports);
                output.append(" STARTTLS");
        }
 
-       virtual void OnHookUserIO(User* user, const std::string &targetip)
+       void OnHookIO(StreamSocket* user, ListenSocketBase* lsb)
        {
-               if (!user->GetIOHook() && isin(targetip,user->GetPort(),listenports))
+               if (!user->GetIOHook() && listenports.find(lsb) != listenports.end())
                {
                        /* Hook the user with our module */
                        user->AddIOHook(this);
                }
        }
 
-       virtual const char* OnRequest(Request* request)
+       const char* OnRequest(Request* request)
        {
-               ISHRequest* ISR = (ISHRequest*)request;
+               ISHRequest* ISR = static_cast<ISHRequest*>(request);
                if (strcmp("IS_NAME", request->GetId()) == 0)
                {
                        return "gnutls";
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       const char* ret = "OK";
-                       try
-                       {
-                               ret = ISR->Sock->AddIOHook((Module*)this) ? "OK" : NULL;
-                       }
-                       catch (ModuleException &e)
-                       {
-                               return NULL;
-                       }
-                       return ret;
+                       ISR->Sock->AddIOHook(this);
+                       return "OK";
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ISR->Sock->DelIOHook() ? "OK" : NULL;
+                       ISR->Sock->DelIOHook();
+                       return "OK";
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
@@ -395,38 +384,26 @@ class ModuleSSLGnuTLS : public Module
                                issl_session* session = &sessions[ISR->Sock->GetFd()];
                                if (session->sess)
                                {
-                                       if ((Extensible*)ServerInstance->SE->GetRef(ISR->Sock->GetFd()) == (Extensible*)(ISR->Sock))
+                                       if (static_cast<Extensible*>(ServerInstance->SE->GetRef(ISR->Sock->GetFd())) == static_cast<Extensible*>(ISR->Sock))
                                        {
-                                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                                return "OK";
                                        }
                                }
                        }
                }
-               else if (strcmp("GET_FP", request->GetId()) == 0)
+               else if (strcmp("GET_CERT", request->GetId()) == 0)
                {
-                       if (ISR->Sock->GetFd() > -1)
-                       {
-                               issl_session* session = &sessions[ISR->Sock->GetFd()];
-                               if (session->sess)
-                               {
-                                       Extensible* ext = ISR->Sock;
-                                       ssl_cert* certinfo;
-                                       if (ext->GetExt("ssl_cert",certinfo))
-                                               return certinfo->GetFingerprint().c_str();
-                               }
-                       }
+                       Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
+                       if (sslinfo)
+                               return sslinfo->OnRequest(request);
                }
                return NULL;
        }
 
 
-       virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return;
-
+               int fd = user->GetFd();
                issl_session* session = &sessions[fd];
 
                /* For STARTTLS: Don't try and init a session on a socket that already has a session */
@@ -439,144 +416,113 @@ class ModuleSSLGnuTLS : public Module
                gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
 
-               gnutls_transport_set_ptr(session->sess, (gnutls_transport_ptr_t) fd); // Give gnutls the fd for the socket.
+               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
+               gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
+               gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 
                gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
 
-               Handshake(session, fd);
+               Handshake(session, user);
        }
 
-       virtual void OnRawSocketConnect(int fd)
+       void OnStreamSocketConnect(StreamSocket* user)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return;
-
-               issl_session* session = &sessions[fd];
+               issl_session* session = &sessions[user->GetFd()];
 
                gnutls_init(&session->sess, GNUTLS_CLIENT);
 
                gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
                gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
-               gnutls_transport_set_ptr(session->sess, (gnutls_transport_ptr_t) fd); // Give gnutls the fd for the socket.
+               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
+               gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
+               gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 
-               Handshake(session, fd);
+               Handshake(session, user);
        }
 
-       virtual void OnRawSocketClose(int fd)
+       void OnStreamSocketClose(StreamSocket* user)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds()))
-                       return;
-
-               CloseSession(&sessions[fd]);
-
-               EventHandler* user = ServerInstance->SE->GetRef(fd);
-
-               if ((user) && (user->GetExt("ssl_cert")))
-               {
-                       ssl_cert* tofree;
-                       user->GetExt("ssl_cert", tofree);
-                       delete tofree;
-                       user->Shrink("ssl_cert");
-               }
+               CloseSession(&sessions[user->GetFd()]);
        }
 
-       virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
+       int OnStreamSocketRead(StreamSocket* user, std::string& recvq)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
-
-               issl_session* session = &sessions[fd];
+               issl_session* session = &sessions[user->GetFd()];
 
                if (!session->sess)
                {
-                       readresult = 0;
                        CloseSession(session);
-                       return 1;
+                       user->SetError("No SSL session");
+                       return -1;
                }
 
-               if (session->status == ISSL_HANDSHAKING_READ)
+               if (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE)
                {
                        // The handshake isn't finished, try to finish it.
 
-                       if(!Handshake(session, fd))
+                       if(!Handshake(session, user))
                        {
-                               errno = session->status == ISSL_CLOSING ? EIO : EAGAIN;
-                               // Couldn't resume handshake.
+                               if (session->status != ISSL_CLOSING)
+                                       return 0;
+                               user->SetError("Handshake Failed");
                                return -1;
                        }
                }
-               else if (session->status == ISSL_HANDSHAKING_WRITE)
-               {
-                       errno = EAGAIN;
-                       MakePollWrite(fd);
-                       return -1;
-               }
 
                // If we resumed the handshake then session->status will be ISSL_HANDSHAKEN.
 
                if (session->status == ISSL_HANDSHAKEN)
                {
-                       int ret = gnutls_record_recv(session->sess, buffer, count);
-
+                       char* buffer = ServerInstance->GetReadBuffer();
+                       size_t bufsiz = ServerInstance->Config->NetBufferSize;
+                       int ret = gnutls_record_recv(session->sess, buffer, bufsiz);
                        if (ret > 0)
                        {
-                               readresult = ret;
-                       }
-                       else if (ret == 0)
-                       {
-                               // Client closed connection.
-                               readresult = 0;
-                               CloseSession(session);
+                               recvq.append(buffer, ret);
                                return 1;
                        }
                        else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
                        {
-                               errno = EAGAIN;
+                               return 0;
+                       }
+                       else if (ret == 0)
+                       {
+                               user->SetError("SSL Connection closed");
+                               CloseSession(session);
                                return -1;
                        }
                        else
                        {
-                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
-                                               "m_ssl_gnutls.so: Error while reading on fd %d: %s",
-                                               fd, gnutls_strerror(ret));
-                               readresult = 0;
+                               user->SetError(gnutls_strerror(ret));
                                CloseSession(session);
+                               return -1;
                        }
                }
-               else if(session->status == ISSL_CLOSING)
-                       readresult = 0;
+               else if (session->status == ISSL_CLOSING)
+                       return -1;
 
-               return 1;
+               return 0;
        }
 
-       virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
+       int OnStreamSocketWrite(StreamSocket* user, std::string& sendq)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
-
-               issl_session* session = &sessions[fd];
-               const char* sendbuffer = buffer;
+               issl_session* session = &sessions[user->GetFd()];
 
                if (!session->sess)
                {
                        CloseSession(session);
-                       return 1;
+                       user->SetError("No SSL session");
+                       return -1;
                }
 
-               session->outbuf.append(sendbuffer, count);
-               sendbuffer = session->outbuf.c_str();
-               count = session->outbuf.size();
-
                if (session->status == ISSL_HANDSHAKING_WRITE || session->status == ISSL_HANDSHAKING_READ)
                {
                        // The handshake isn't finished, try to finish it.
-                       Handshake(session, fd);
-                       errno = session->status == ISSL_CLOSING ? EIO : EAGAIN;
+                       Handshake(session, user);
+                       if (session->status != ISSL_CLOSING)
+                               return 0;
+                       user->SetError("Handshake Failed");
                        return -1;
                }
 
@@ -584,41 +530,42 @@ class ModuleSSLGnuTLS : public Module
 
                if (session->status == ISSL_HANDSHAKEN)
                {
-                       ret = gnutls_record_send(session->sess, sendbuffer, count);
+                       ret = gnutls_record_send(session->sess, sendq.data(), sendq.length());
 
-                       if (ret == 0)
+                       if (ret == (int)sendq.length())
                        {
-                               CloseSession(session);
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_WRITE);
+                               return 1;
                        }
-                       else if (ret < 0)
+                       else if (ret > 0)
                        {
-                               if(ret != GNUTLS_E_AGAIN && ret != GNUTLS_E_INTERRUPTED)
-                               {
-                                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
-                                                       "m_ssl_gnutls.so: Error while writing to fd %d: %s",
-                                                       fd, gnutls_strerror(ret));
-                                       CloseSession(session);
-                               }
-                               else
-                               {
-                                       errno = EAGAIN;
-                               }
+                               sendq = sendq.substr(ret);
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
+                               return 0;
                        }
-                       else
+                       else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
                        {
-                               session->outbuf = session->outbuf.substr(ret);
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
+                               return 0;
+                       }
+                       else if (ret == 0)
+                       {
+                               CloseSession(session);
+                               user->SetError("SSL Connection closed");
+                               return -1;
+                       }
+                       else // (ret < 0)
+                       {
+                               user->SetError(gnutls_strerror(ret));
+                               CloseSession(session);
+                               return -1;
                        }
                }
 
-               MakePollWrite(fd);
-
-               /* Who's smart idea was it to return 1 when we havent written anything?
-                * This fucks the buffer up in BufferedSocket :p
-                */
-               return ret < 1 ? 0 : ret;
+               return 0;
        }
 
-       bool Handshake(issl_session* session, int fd)
+       bool Handshake(issl_session* session, StreamSocket* user)
        {
                int ret = gnutls_handshake(session->sess);
 
@@ -632,20 +579,17 @@ class ModuleSSLGnuTLS : public Module
                                {
                                        // gnutls_handshake() wants to read() again.
                                        session->status = ISSL_HANDSHAKING_READ;
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
                                }
                                else
                                {
                                        // gnutls_handshake() wants to write() again.
                                        session->status = ISSL_HANDSHAKING_WRITE;
-                                       MakePollWrite(fd);
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
                                }
                        }
                        else
                        {
-                               // Handshake failed.
-                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT,
-                                               "m_ssl_gnutls.so: Handshake failed on fd %d: %s",
-                                               fd, gnutls_strerror(ret));
                                CloseSession(session);
                                session->status = ISSL_CLOSING;
                        }
@@ -654,32 +598,24 @@ class ModuleSSLGnuTLS : public Module
                }
                else
                {
-                       // Handshake complete.
-                       // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       EventHandler *extendme = ServerInstance->SE->GetRef(fd);
-                       if (extendme)
-                       {
-                               if (!extendme->GetExt("ssl"))
-                                       extendme->Extend("ssl", "ON");
-                       }
-
                        // Change the seesion state
                        session->status = ISSL_HANDSHAKEN;
 
+                       VerifyCertificate(session,user);
+
                        // Finish writing, if any left
-                       MakePollWrite(fd);
+                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
 
                        return true;
                }
        }
 
-       virtual void OnPostConnect(User* user)
+       void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
                // protocol module has propagated the NICK message.
                if (user->GetIOHook() == this && (IS_LOCAL(user)))
                {
-                       ssl_cert* certdata = VerifyCertificate(&sessions[user->GetFd()],user);
                        if (sessions[user->GetFd()].sess)
                        {
                                std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->GetFd()].sess));
@@ -687,28 +623,6 @@ class ModuleSSLGnuTLS : public Module
                                cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->GetFd()].sess)));
                                user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
                        }
-
-                       ServerInstance->PI->SendMetaData(user, TYPE_USER, "ssl", "ON");
-                       if (certdata)
-                               ServerInstance->PI->SendMetaData(user, TYPE_USER, "ssl_cert", certdata->GetMetaLine().c_str());
-               }
-       }
-
-       void MakePollWrite(int fd)
-       {
-               //OnRawSocketWrite(fd, NULL, 0);
-               EventHandler* eh = ServerInstance->SE->GetRef(fd);
-               if (eh)
-                       ServerInstance->SE->WantWrite(eh);
-       }
-
-       virtual void OnBufferFlushed(User* user)
-       {
-               if (user->GetIOHook() == this)
-               {
-                       issl_session* session = &sessions[user->GetFd()];
-                       if (session && session->outbuf.size())
-                               OnRawSocketWrite(user->GetFd(), NULL, 0);
                }
        }
 
@@ -720,15 +634,18 @@ class ModuleSSLGnuTLS : public Module
                        gnutls_deinit(session->sess);
                }
 
-               session->outbuf.clear();
                session->sess = NULL;
                session->status = ISSL_NONE;
        }
 
-       ssl_cert* VerifyCertificate(issl_session* session, Extensible* user)
+       void VerifyCertificate(issl_session* session, Extensible* user)
        {
                if (!session->sess || !user)
-                       return NULL;
+                       return;
+
+               Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
+               if (!sslinfo)
+                       return;
 
                unsigned int status;
                const gnutls_datum_t* cert_list;
@@ -741,8 +658,6 @@ class ModuleSSLGnuTLS : public Module
                size_t name_size = sizeof(name);
                ssl_cert* certinfo = new ssl_cert;
 
-               user->Extend("ssl_cert",certinfo);
-
                /* This verification function uses the trusted CAs in the credentials
                 * structure. So you must have installed one or more CA certificates.
                 */
@@ -751,7 +666,7 @@ class ModuleSSLGnuTLS : public Module
                if (ret < 0)
                {
                        certinfo->error = std::string(gnutls_strerror(ret));
-                       return certinfo;
+                       goto info_done;
                }
 
                certinfo->invalid = (status & GNUTLS_CERT_INVALID);
@@ -766,14 +681,14 @@ class ModuleSSLGnuTLS : public Module
                if (gnutls_certificate_type_get(session->sess) != GNUTLS_CRT_X509)
                {
                        certinfo->error = "No X509 keys sent";
-                       return certinfo;
+                       goto info_done;
                }
 
                ret = gnutls_x509_crt_init(&cert);
                if (ret < 0)
                {
                        certinfo->error = gnutls_strerror(ret);
-                       return certinfo;
+                       goto info_done;
                }
 
                cert_list_size = 0;
@@ -781,7 +696,7 @@ class ModuleSSLGnuTLS : public Module
                if (cert_list == NULL)
                {
                        certinfo->error = "No certificate was found";
-                       return certinfo;
+                       goto info_done_dealloc;
                }
 
                /* This is not a real world example, since we only check the first
@@ -792,7 +707,7 @@ class ModuleSSLGnuTLS : public Module
                if (ret < 0)
                {
                        certinfo->error = gnutls_strerror(ret);
-                       return certinfo;
+                       goto info_done_dealloc;
                }
 
                gnutls_x509_crt_get_dn(cert, name, &name_size);
@@ -817,20 +732,15 @@ class ModuleSSLGnuTLS : public Module
                        certinfo->error = "Not activated, or expired certificate";
                }
 
+info_done_dealloc:
                gnutls_x509_crt_deinit(cert);
-
-               return certinfo;
+info_done:
+               BufferedSocketFingerprintSubmission(user, this, sslinfo, certinfo).Send();
        }
 
        void OnEvent(Event* ev)
        {
-               GenericCapHandler(ev, "tls", "tls");
-       }
-
-       void Prioritize()
-       {
-               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
-               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIORITY_AFTER, &server);
+               capHandler.HandleEvent(ev);
        }
 };