]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Add sanity checks to the ssl modules so that theres no possibility of an out of range...
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index 0e923df414339519760520b1dcfe5c79aeab9460..4af425e0b06672443aeed51145716e0af00bc7ad 100644 (file)
@@ -11,8 +11,7 @@
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <vector>
+#include "inspircd.h"
 
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-
 #include "socket.h"
 #include "hashcomp.h"
-#include "inspircd.h"
-
 #include "transport.h"
 
+#ifdef WINDOWS
+#pragma comment(lib, "libgnutls-13.lib")
+#undef MAX_DESCRIPTORS
+#define MAX_DESCRIPTORS 10000
+#endif
+
 /* $ModDesc: Provides SSL support for clients */
 /* $CompileFlags: exec("libgnutls-config --cflags") */
 /* $LinkerFlags: rpath("libgnutls-config --libs") exec("libgnutls-config --libs") */
@@ -78,6 +80,7 @@ class ModuleSSLGnuTLS : public Module
        std::string certfile;
        std::string cafile;
        std::string crlfile;
+       std::string sslports;
        int dh_bits;
 
        int clientactive;
@@ -85,9 +88,9 @@ class ModuleSSLGnuTLS : public Module
  public:
 
        ModuleSSLGnuTLS(InspIRCd* Me)
-               : Module::Module(Me)
+               : Module(Me)
        {
-               ServerInstance->PublishInterface("InspSocketHook", this);
+               ServerInstance->Modules->PublishInterface("InspSocketHook", this);
 
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
@@ -122,11 +125,13 @@ class ModuleSSLGnuTLS : public Module
 
                listenports.clear();
                clientactive = 0;
+               sslports.clear();
 
                for(int i = 0; i < Conf->Enumerate("bind"); i++)
                {
                        // For each <bind> tag
-                       if(((Conf->ReadValue("bind", "type", i) == "") || (Conf->ReadValue("bind", "type", i) == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "gnutls"))
+                       std::string x = Conf->ReadValue("bind", "type", i);
+                       if(((x.empty()) || (x == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "gnutls"))
                        {
                                // Get the port we're meant to be listening on with SSL
                                std::string port = Conf->ReadValue("bind", "port", i);
@@ -140,10 +145,11 @@ class ModuleSSLGnuTLS : public Module
                                                if (ServerInstance->Config->AddIOHook(portno, this))
                                                {
                                                        listenports.push_back(portno);
-                                                       for (unsigned int i = 0; i < ServerInstance->stats->BoundPortCount; i++)
-                                                               if (ServerInstance->Config->ports[i] == portno)
-                                                                       ServerInstance->Config->openSockfd[i]->SetDescription("ssl");
+                                                       for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
+                                                               if (ServerInstance->Config->ports[i]->GetPort() == portno)
+                                                                       ServerInstance->Config->ports[i]->SetDescription("ssl");
                                                        ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %d", portno);
+                                                       sslports.append("*:").append(ConvToStr(portno)).append(";");
                                                }
                                                else
                                                {
@@ -169,16 +175,16 @@ class ModuleSSLGnuTLS : public Module
                dh_bits = Conf->ReadInteger("gnutls", "dhbits", 0, false);
 
                // Set all the default values needed.
-               if(cafile == "")
+               if (cafile.empty())
                        cafile = "ca.pem";
 
-               if(crlfile == "")
+               if (crlfile.empty())
                        crlfile = "crl.pem";
 
-               if(certfile == "")
+               if (certfile.empty())
                        certfile = "cert.pem";
 
-               if(keyfile == "")
+               if (keyfile.empty())
                        keyfile = "key.pem";
 
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
@@ -205,9 +211,11 @@ class ModuleSSLGnuTLS : public Module
                if((ret = gnutls_certificate_set_x509_crl_file (x509_cred, crlfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
                        ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
 
-               // Guessing on the return value of this, manual doesn't say :|
                if((ret = gnutls_certificate_set_x509_key_file (x509_cred, certfile.c_str(), keyfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 certificate and key files '%s' and '%s': %s", certfile.c_str(), keyfile.c_str(), gnutls_strerror(ret));
+               {
+                       // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
+                       throw ModuleException("Unable to load GnuTLS server certificate: " + std::string(gnutls_strerror(ret)));
+               }
 
                // This may be on a large (once a day or week) timer eventually.
                GenerateDHParams();
@@ -245,7 +253,7 @@ class ModuleSSLGnuTLS : public Module
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->GlobalCulls.AddItem(user, "SSL module unloading");
+                               userrec::QuitUser(ServerInstance, user, "SSL module unloading");
                        }
                        if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
                        {
@@ -264,10 +272,9 @@ class ModuleSSLGnuTLS : public Module
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
                                ServerInstance->Config->DelIOHook(listenports[i]);
-                               for (unsigned int j = 0; j < ServerInstance->stats->BoundPortCount; j++)
-                                       if (ServerInstance->Config->ports[j] == listenports[i])
-                                               if (ServerInstance->Config->openSockfd[j])
-                                                       ServerInstance->Config->openSockfd[j]->SetDescription("plaintext");
+                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
+                                       if (ServerInstance->Config->ports[j]->GetPort() == listenports[i])
+                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
                        }
                }
        }
@@ -279,11 +286,16 @@ class ModuleSSLGnuTLS : public Module
 
        void Implements(char* List)
        {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
+               List[I_On005Numeric] = List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
+               List[I_OnBufferFlushed] = List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
        }
 
-        virtual char* OnRequest(Request* request)
+       virtual void On005Numeric(std::string &output)
+       {
+               output.append(" SSL=" + sslports);
+       }
+
+       virtual char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
                if (strcmp("IS_NAME", request->GetId()) == 0)
@@ -336,6 +348,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -365,6 +381,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketConnect(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -383,6 +403,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -398,6 +422,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -420,6 +448,7 @@ class ModuleSSLGnuTLS : public Module
                else if (session->status == ISSL_HANDSHAKING_WRITE)
                {
                        errno = EAGAIN;
+                       MakePollWrite(session);
                        return -1;
                }
 
@@ -488,7 +517,8 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
-               if (!count)
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
                        return 0;
 
                issl_session* session = &sessions[fd];
@@ -504,7 +534,7 @@ class ModuleSSLGnuTLS : public Module
                sendbuffer = session->outbuf.c_str();
                count = session->outbuf.size();
 
-               if(session->status == ISSL_HANDSHAKING_WRITE)
+               if (session->status == ISSL_HANDSHAKING_WRITE)
                {
                        // The handshake isn't finished, try to finish it.
                        Handshake(session);
@@ -514,11 +544,11 @@ class ModuleSSLGnuTLS : public Module
 
                int ret = 0;
 
-               if(session->status == ISSL_HANDSHAKEN)
+               if (session->status == ISSL_HANDSHAKEN)
                {
                        ret = gnutls_record_send(session->sess, sendbuffer, count);
 
-                       if(ret == 0)
+                       if (ret == 0)
                        {
                                CloseSession(session);
                        }
@@ -531,7 +561,6 @@ class ModuleSSLGnuTLS : public Module
                                else
                                {
                                        errno = EAGAIN;
-                                       return -1;
                                }
                        }
                        else
@@ -540,6 +569,8 @@ class ModuleSSLGnuTLS : public Module
                        }
                }
 
+               MakePollWrite(session);
+
                /* Who's smart idea was it to return 1 when we havent written anything?
                 * This fucks the buffer up in InspSocket :p
                 */
@@ -643,7 +674,7 @@ class ModuleSSLGnuTLS : public Module
        virtual void OnPostConnect(userrec* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
+               // protocol module has propagated the NICK message.
                if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
@@ -669,7 +700,20 @@ class ModuleSSLGnuTLS : public Module
 
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
+               if (eh)
+                       ServerInstance->SE->WantWrite(eh);
+       }
+
+       virtual void OnBufferFlushed(userrec* user)
+       {
+               if (user->GetExt("ssl"))
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
 
        void CloseSession(issl_session* session)
@@ -820,25 +864,4 @@ class ModuleSSLGnuTLS : public Module
 
 };
 
-class ModuleSSLGnuTLSFactory : public ModuleFactory
-{
- public:
-       ModuleSSLGnuTLSFactory()
-       {
-       }
-
-       ~ModuleSSLGnuTLSFactory()
-       {
-       }
-
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSSLGnuTLS(Me);
-       }
-};
-
-
-extern "C" void * init_module( void )
-{
-       return new ModuleSSLGnuTLSFactory;
-}
+MODULE_INIT(ModuleSSLGnuTLS);