]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
m_ssl_gnutls Hold users in pre-registration state until the handshake is completed
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index c631642cee610e74f030117af62f35200df63f62..59ac1acb3bcd62295ba9ea5e531ef7479ed480e0 100644 (file)
 #include "inspircd.h"
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
-#include <gcrypt.h>
 #include "ssl.h"
 #include "m_cap.h"
 
-#ifdef WINDOWS
-# pragma comment(lib, "libgnutls.lib")
-# pragma comment(lib, "libgcrypt.lib")
-# pragma comment(lib, "libgpg-error.lib")
-# pragma comment(lib, "user32.lib")
-# pragma comment(lib, "advapi32.lib")
-# pragma comment(lib, "libgcc.lib")
-# pragma comment(lib, "libmingwex.lib")
-# pragma comment(lib, "gdi32.lib")
+#ifdef _WIN32
+# pragma comment(lib, "libgnutls-28.lib")
 #endif
 
 /* $ModDesc: Provides SSL support for clients */
-/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") */
-/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") -lgcrypt */
+/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --cflags") */
+/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --libs") */
+/* $NoPedantic */
+
+#ifndef GNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MAJOR LIBGNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MINOR LIBGNUTLS_VERSION_MINOR
+#define GNUTLS_VERSION_PATCH LIBGNUTLS_VERSION_PATCH
+#endif
+
+// These don't exist in older GnuTLS versions
+#if ((GNUTLS_VERSION_MAJOR > 2) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR > 1) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR == 1 && GNUTLS_VERSION_PATCH >= 7))
+#define GNUTLS_NEW_PRIO_API
+#endif
+
+#if(GNUTLS_VERSION_MAJOR < 2)
+typedef gnutls_certificate_credentials_t gnutls_certificate_credentials;
+typedef gnutls_dh_params_t gnutls_dh_params;
+#endif
+
+#if (GNUTLS_VERSION_MAJOR > 2 || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR >= 12))
+# define GNUTLS_HAS_RND
+# include <gnutls/crypto.h>
+#else
+# include <gcrypt.h>
+#endif
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
-static std::vector<gnutls_x509_crt_t> x509_certs;
-static gnutls_x509_privkey_t x509_key;
+struct SSLConfig : public refcountbase
+{
+       gnutls_certificate_credentials_t x509_cred;
+       std::vector<gnutls_x509_crt_t> x509_certs;
+       gnutls_x509_privkey_t x509_key;
+       gnutls_dh_params_t dh_params;
+#ifdef GNUTLS_NEW_PRIO_API
+       gnutls_priority_t priority;
+#endif
+
+       SSLConfig()
+               : x509_cred(NULL)
+               , x509_key(NULL)
+               , dh_params(NULL)
+#ifdef GNUTLS_NEW_PRIO_API
+               , priority(NULL)
+#endif
+       {
+       }
+
+       ~SSLConfig()
+       {
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Destroying SSLConfig %p", (void*)this);
+
+               if (x509_cred)
+                       gnutls_certificate_free_credentials(x509_cred);
+
+               for (unsigned int i = 0; i < x509_certs.size(); i++)
+                       gnutls_x509_crt_deinit(x509_certs[i]);
+
+               if (x509_key)
+                       gnutls_x509_privkey_deinit(x509_key);
+
+               if (dh_params)
+                       gnutls_dh_params_deinit(dh_params);
+
+#ifdef GNUTLS_NEW_PRIO_API
+               if (priority)
+                       gnutls_priority_deinit(priority);
+#endif
+       }
+};
+
+static reference<SSLConfig> currconf;
+
+static SSLConfig* GetSessionConfig(gnutls_session_t session);
+
+#if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
 static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
        const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr_st * st) {
 
        st->type = GNUTLS_CRT_X509;
+#else
+static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
+       const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr2_st * st) {
+       st->cert_type = GNUTLS_CRT_X509;
+       st->key_type = GNUTLS_PRIVKEY_X509;
+#endif
+       SSLConfig* conf = GetSessionConfig(session);
+       std::vector<gnutls_x509_crt_t>& x509_certs = conf->x509_certs;
        st->ncerts = x509_certs.size();
        st->cert.x509 = &x509_certs[0];
-       st->key.x509 = x509_key;
+       st->key.x509 = conf->x509_key;
        st->deinit_all = 0;
 
        return 0;
 }
 
-static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t user_wrap, void* buffer, size_t size)
-{
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_READ_WILL_BLOCK)
-       {
-               errno = EAGAIN;
-               return -1;
-       }
-       int rv = ServerInstance->SE->Recv(user, reinterpret_cast<char *>(buffer), size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_READ_WILL_BLOCK);
-       return rv;
-}
-
-static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t user_wrap, const void* buffer, size_t size)
-{
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_WRITE_WILL_BLOCK)
-       {
-               errno = EAGAIN;
-               return -1;
-       }
-       int rv = ServerInstance->SE->Send(user, reinterpret_cast<const char *>(buffer), size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_WRITE_WILL_BLOCK);
-       return rv;
-}
-
 class RandGen : public HandlerBase2<void, char*, size_t>
 {
  public:
        RandGen() {}
        void Call(char* buffer, size_t len)
        {
+#ifdef GNUTLS_HAS_RND
+               gnutls_rnd(GNUTLS_RND_RANDOM, buffer, len);
+#else
                gcry_randomize(buffer, len, GCRY_STRONG_RANDOM);
+#endif
        }
 };
 
@@ -102,12 +148,21 @@ class RandGen : public HandlerBase2<void, char*, size_t>
 class issl_session
 {
 public:
+       StreamSocket* socket;
        gnutls_session_t sess;
        issl_status status;
        reference<ssl_cert> cert;
-       issl_session() : sess(NULL) {}
+       reference<SSLConfig> config;
+
+       issl_session() : socket(NULL), sess(NULL), status(ISSL_NONE) {}
 };
 
+static SSLConfig* GetSessionConfig(gnutls_session_t sess)
+{
+       issl_session* session = reinterpret_cast<issl_session*>(gnutls_transport_get_ptr(sess));
+       return session->config;
+}
+
 class CommandStartTLS : public SplitCommand
 {
  public:
@@ -159,50 +214,113 @@ class ModuleSSLGnuTLS : public Module
 {
        issl_session* sessions;
 
-       gnutls_certificate_credentials x509_cred;
-       gnutls_dh_params dh_params;
        gnutls_digest_algorithm_t hash;
 
        std::string sslports;
        int dh_bits;
 
-       bool cred_alloc;
-       bool dh_alloc;
-
        RandGen randhandler;
        CommandStartTLS starttls;
 
        GenericCap capHandler;
        ServiceProvider iohook;
+
+       inline static const char* UnknownIfNULL(const char* str)
+       {
+               return str ? str : "UNKNOWN";
+       }
+
+       static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t session_wrap, void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_READ_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Recv(session->socket, reinterpret_cast<char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_READ_WILL_BLOCK);
+               return rv;
+       }
+
+       static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t session_wrap, const void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_WRITE_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Send(session->socket, reinterpret_cast<const char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_WRITE_WILL_BLOCK);
+               return rv;
+       }
+
  public:
 
        ModuleSSLGnuTLS()
                : starttls(this), capHandler(this, "tls"), iohook(this, "ssl/gnutls", SERVICE_IOHOOK)
        {
+#ifndef GNUTLS_HAS_RND
+               gcry_control (GCRYCTL_INITIALIZATION_FINISHED, 0);
+#endif
+
                sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                gnutls_global_init(); // This must be called once in the program
-               gnutls_x509_privkey_init(&x509_key);
-
-               cred_alloc = false;
-               dh_alloc = false;
        }
 
        void init()
        {
-               // Needs the flag as it ignores a plain /rehash
-               OnModuleRehash(NULL,"ssl");
+               currconf = new SSLConfig;
+               InitSSLConfig(currconf);
 
                ServerInstance->GenRandom = &randhandler;
 
-               // Void return, guess we assume success
-               gnutls_certificate_set_dh_params(x509_cred, dh_params);
                Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnUserConnect,
-                       I_OnEvent, I_OnHookIO };
+                       I_OnEvent, I_OnHookIO, I_OnCheckReady };
                ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
                ServerInstance->Modules->AddService(iohook);
-               ServerInstance->AddCommand(&starttls);
+               ServerInstance->Modules->AddService(starttls);
        }
 
        void OnRehash(User* user)
@@ -214,6 +332,10 @@ class ModuleSSLGnuTLS : public Module
 
                if (Conf->getBool("showports", true))
                {
+                       sslports = Conf->getString("advertisedports");
+                       if (!sslports.empty())
+                               return;
+
                        for (size_t i = 0; i < ServerInstance->ports.size(); i++)
                        {
                                ListenSocket* port = ServerInstance->ports[i];
@@ -224,11 +346,20 @@ class ModuleSSLGnuTLS : public Module
                                ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
 
                                if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
-                                       sslports.append(portid).append(";");
+                               {
+                                       /*
+                                        * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
+                                        * the IP:port in ISUPPORT.
+                                        *
+                                        * We used to advertise all ports seperated by a ';' char that matched the above criteria,
+                                        * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
+                                        * To solve this by default we now only display the first IP:port found and let the user
+                                        * configure the exact value for the 005 token, if necessary.
+                                        */
+                                       sslports = portid;
+                                       break;
+                               }
                        }
-
-                       if (!sslports.empty())
-                               sslports.erase(sslports.end() - 1);
                }
        }
 
@@ -237,21 +368,47 @@ class ModuleSSLGnuTLS : public Module
                if(param != "ssl")
                        return;
 
+               reference<SSLConfig> newconf = new SSLConfig;
+               try
+               {
+                       InitSSLConfig(newconf);
+               }
+               catch (ModuleException& ex)
+               {
+                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Not applying new config. %s", ex.GetReason());
+                       return;
+               }
+
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Applying new config, old config is in use by %d connection(s)", currconf->GetReferenceCount()-1);
+               currconf = newconf;
+       }
+
+       void InitSSLConfig(SSLConfig* config)
+       {
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Initializing new SSLConfig %p", (void*)config);
+
                std::string keyfile;
                std::string certfile;
                std::string cafile;
                std::string crlfile;
-               OnRehash(user);
+               OnRehash(NULL);
 
                ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
 
-               cafile = Conf->getString("cafile", "conf/ca.pem");
-               crlfile = Conf->getString("crlfile", "conf/crl.pem");
-               certfile = Conf->getString("certfile", "conf/cert.pem");
-               keyfile = Conf->getString("keyfile", "conf/key.pem");
+               cafile = Conf->getString("cafile", CONFIG_PATH "/ca.pem");
+               crlfile = Conf->getString("crlfile", CONFIG_PATH "/crl.pem");
+               certfile = Conf->getString("certfile", CONFIG_PATH "/cert.pem");
+               keyfile = Conf->getString("keyfile", CONFIG_PATH "/key.pem");
                dh_bits = Conf->getInt("dhbits");
                std::string hashname = Conf->getString("hash", "md5");
 
+               // The GnuTLS manual states that the gnutls_set_default_priority()
+               // call we used previously when initializing the session is the same
+               // as setting the "NORMAL" priority string.
+               // Thus if the setting below is not in the config we will behave exactly
+               // the same as before, when the priority setting wasn't available.
+               std::string priorities = Conf->getString("priority", "NORMAL");
+
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
                        dh_bits = 1024;
 
@@ -259,33 +416,27 @@ class ModuleSSLGnuTLS : public Module
                        hash = GNUTLS_DIG_MD5;
                else if (hashname == "sha1")
                        hash = GNUTLS_DIG_SHA1;
+#ifdef INSPIRCD_GNUTLS_ENABLE_SHA256_FINGERPRINT
+               else if (hashname == "sha256")
+                       hash = GNUTLS_DIG_SHA256;
+#endif
                else
                        throw ModuleException("Unknown hash type " + hashname);
 
 
                int ret;
 
-               if (dh_alloc)
-               {
-                       gnutls_dh_params_deinit(dh_params);
-                       dh_alloc = false;
-               }
+               gnutls_certificate_credentials_t& x509_cred = config->x509_cred;
 
-               if (cred_alloc)
+               ret = gnutls_certificate_allocate_credentials(&x509_cred);
+               if (ret < 0)
                {
-                       // Deallocate the old credentials
-                       gnutls_certificate_free_credentials(x509_cred);
-
-                       for(unsigned int i=0; i < x509_certs.size(); i++)
-                               gnutls_x509_crt_deinit(x509_certs[i]);
-                       x509_certs.clear();
+                       // Set to NULL because we can't be sure what value is in it and we must not try to
+                       // deallocate it in case of an error
+                       x509_cred = NULL;
+                       throw ModuleException("Failed to allocate certificate credentials: " + std::string(gnutls_strerror(ret)));
                }
 
-               ret = gnutls_certificate_allocate_credentials(&x509_cred);
-               cred_alloc = (ret >= 0);
-               if (!cred_alloc)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to allocate certificate credentials: %s", gnutls_strerror(ret));
-
                if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
 
@@ -296,19 +447,40 @@ class ModuleSSLGnuTLS : public Module
 
                reader.LoadFile(certfile);
                std::string cert_string = reader.Contents();
-               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), cert_string.length() };
+               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), static_cast<unsigned int>(cert_string.length()) };
 
                reader.LoadFile(keyfile);
                std::string key_string = reader.Contents();
-               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), key_string.length() };
+               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), static_cast<unsigned int>(key_string.length()) };
+
+               std::vector<gnutls_x509_crt_t>& x509_certs = config->x509_certs;
 
                // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
-               unsigned int certcount = Conf->getInt("certcount", 3);
+               unsigned int certcount = 3;
                x509_certs.resize(certcount);
                ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
-               if (ret < 0)
-                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + std::string(gnutls_strerror(ret)));
-               x509_certs.resize(certcount);
+               if (ret == GNUTLS_E_SHORT_MEMORY_BUFFER)
+               {
+                       // the buffer wasn't big enough to hold all certs but gnutls updated certcount to the number of available certs, try again with a bigger buffer
+                       x509_certs.resize(certcount);
+                       ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
+               }
+
+               if (ret <= 0)
+               {
+                       // clear the vector so we won't call gnutls_x509_crt_deinit() on the (uninited) certs later
+                       x509_certs.clear();
+                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + ((ret < 0) ? (std::string(gnutls_strerror(ret))) : "No certs could be read"));
+               }
+               x509_certs.resize(ret);
+
+               gnutls_x509_privkey_t& x509_key = config->x509_key;
+               if (gnutls_x509_privkey_init(&x509_key) < 0)
+               {
+                       // Make sure the destructor does not try to deallocate this, see above
+                       x509_key = NULL;
+                       throw ModuleException("Unable to initialize private key");
+               }
 
                if((ret = gnutls_x509_privkey_import(x509_key, &key_datum, GNUTLS_X509_FMT_PEM)) < 0)
                        throw ModuleException("Unable to load GnuTLS server private key (" + keyfile + "): " + std::string(gnutls_strerror(ret)));
@@ -316,27 +488,71 @@ class ModuleSSLGnuTLS : public Module
                if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_certs[0], certcount, x509_key)) < 0)
                        throw ModuleException("Unable to set GnuTLS cert/key pair: " + std::string(gnutls_strerror(ret)));
 
+               #ifdef GNUTLS_NEW_PRIO_API
+               // Try to set the priorities for ciphers, kex methods etc. to the user supplied string
+               // If the user did not supply anything then the string is already set to "NORMAL"
+               const char* priocstr = priorities.c_str();
+               const char* prioerror;
+
+               gnutls_priority_t& priority = config->priority;
+               if ((ret = gnutls_priority_init(&priority, priocstr, &prioerror)) < 0)
+               {
+                       // gnutls did not understand the user supplied string, log and fall back to the default priorities
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set priorities to \"%s\": %s Syntax error at position %u, falling back to default (NORMAL)", priorities.c_str(), gnutls_strerror(ret), (unsigned int) (prioerror - priocstr));
+                       gnutls_priority_init(&priority, "NORMAL", NULL);
+               }
+
+               #else
+               if (priorities != "NORMAL")
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: You've set <gnutls:priority> to a value other than the default, but this is only supported with GnuTLS v2.1.7 or newer. Your GnuTLS version is older than that so the option will have no effect.");
+               #endif
+
+               #if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
                gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
+               #else
+               gnutls_certificate_set_retrieve_function (x509_cred, cert_callback);
+               #endif
 
+               gnutls_dh_params_t& dh_params = config->dh_params;
                ret = gnutls_dh_params_init(&dh_params);
-               dh_alloc = (ret >= 0);
-               if (!dh_alloc)
+               if (ret < 0)
+               {
+                       // Make sure the destructor does not try to deallocate this, see above
+                       dh_params = NULL;
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
+                       return;
+               }
+
+               std::string dhfile = Conf->getString("dhfile");
+               if (!dhfile.empty())
+               {
+                       // Try to load DH params from file
+                       reader.LoadFile(dhfile);
+                       std::string dhstring = reader.Contents();
+                       gnutls_datum_t dh_datum = { (unsigned char*)dhstring.data(), static_cast<unsigned int>(dhstring.length()) };
 
-               // This may be on a large (once a day or week) timer eventually.
-               GenerateDHParams();
+                       if ((ret = gnutls_dh_params_import_pkcs3(dh_params, &dh_datum, GNUTLS_X509_FMT_PEM)) < 0)
+                       {
+                               // File unreadable or GnuTLS was unhappy with the contents, generate the DH primes now
+                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Generating DH parameters because I failed to load them from file '%s': %s", dhfile.c_str(), gnutls_strerror(ret));
+                               GenerateDHParams(dh_params);
+                       }
+               }
+               else
+               {
+                       GenerateDHParams(dh_params);
+               }
+
+               gnutls_certificate_set_dh_params(x509_cred, dh_params);
        }
 
-       void GenerateDHParams()
+       void GenerateDHParams(gnutls_dh_params_t dh_params)
        {
                // Generate Diffie Hellman parameters - for use with DHE
                // kx algorithms. These should be discarded and regenerated
                // once a day, once a week or once a month. Depending on the
                // security requirements.
 
-               if (!dh_alloc)
-                       return;
-
                int ret;
 
                if((ret = gnutls_dh_params_generate2(dh_params, dh_bits)) < 0)
@@ -345,15 +561,7 @@ class ModuleSSLGnuTLS : public Module
 
        ~ModuleSSLGnuTLS()
        {
-               for(unsigned int i=0; i < x509_certs.size(); i++)
-                       gnutls_x509_crt_deinit(x509_certs[i]);
-
-               gnutls_x509_privkey_deinit(x509_key);
-
-               if (dh_alloc)
-                       gnutls_dh_params_deinit(dh_params);
-               if (cred_alloc)
-                       gnutls_certificate_free_credentials(x509_cred);
+               currconf = NULL;
 
                gnutls_global_deinit();
                delete[] sessions;
@@ -408,46 +616,53 @@ class ModuleSSLGnuTLS : public Module
 
                        req.cert = session->cert;
                }
+               else if (!strcmp("GET_RAW_SSL_SESSION", request.id))
+               {
+                       SSLRawSessionRequest& req = static_cast<SSLRawSessionRequest&>(request);
+                       if ((req.fd >= 0) && (req.fd < ServerInstance->SE->GetMaxFds()))
+                               req.data = reinterpret_cast<void*>(sessions[req.fd].sess);
+               }
        }
 
-       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
+       void InitSession(StreamSocket* user, bool me_server)
        {
-               int fd = user->GetFd();
-               issl_session* session = &sessions[fd];
-
-               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
-               if (session->sess)
-                       return;
+               issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_SERVER);
+               gnutls_init(&session->sess, me_server ? GNUTLS_SERVER : GNUTLS_CLIENT);
+               session->socket = user;
+               session->config = currconf;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
-               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
+               #ifdef GNUTLS_NEW_PRIO_API
+               gnutls_priority_set(session->sess, currconf->priority);
+               #else
+               gnutls_set_default_priority(session->sess);
+               #endif
+               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, currconf->x509_cred);
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
-
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
+               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(session));
                gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
                gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 
-               gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
+               if (me_server)
+                       gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
 
                Handshake(session, user);
        }
 
-       void OnStreamSocketConnect(StreamSocket* user)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
                issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_CLIENT);
+               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
+               if (session->sess)
+                       return;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
-               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
-               gnutls_dh_set_prime_bits(session->sess, dh_bits);
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
-               gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
-               gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
+               InitSession(user, true);
+       }
 
-               Handshake(session, user);
+       void OnStreamSocketConnect(StreamSocket* user)
+       {
+               InitSession(user, false);
        }
 
        void OnStreamSocketClose(StreamSocket* user)
@@ -496,7 +711,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else if (ret == 0)
                        {
-                               user->SetError("SSL Connection closed");
+                               user->SetError("Connection closed");
                                CloseSession(session);
                                return -1;
                        }
@@ -591,7 +806,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else
                        {
-                               user->SetError(std::string("Handshake Failed - ") + gnutls_strerror(ret));
+                               user->SetError("Handshake Failed - " + std::string(gnutls_strerror(ret)));
                                CloseSession(session);
                                session->status = ISSL_CLOSING;
                        }
@@ -618,10 +833,12 @@ class ModuleSSLGnuTLS : public Module
                {
                        if (sessions[user->eh.GetFd()].sess)
                        {
+                               const gnutls_session_t& sess = sessions[user->eh.GetFd()].sess;
+                               std::string cipher = UnknownIfNULL(gnutls_kx_get_name(gnutls_kx_get(sess)));
+                               cipher.append("-").append(UnknownIfNULL(gnutls_cipher_get_name(gnutls_cipher_get(sess)))).append("-");
+                               cipher.append(UnknownIfNULL(gnutls_mac_get_name(gnutls_mac_get(sess))));
+
                                ssl_cert* cert = sessions[user->eh.GetFd()].cert;
-                               std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->eh.GetFd()].sess));
-                               cipher.append("-").append(gnutls_cipher_get_name(gnutls_cipher_get(sessions[user->eh.GetFd()].sess))).append("-");
-                               cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->eh.GetFd()].sess)));
                                if (cert->fingerprint.empty())
                                        user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
                                else
@@ -638,9 +855,11 @@ class ModuleSSLGnuTLS : public Module
                        gnutls_bye(session->sess, GNUTLS_SHUT_WR);
                        gnutls_deinit(session->sess);
                }
+               session->socket = NULL;
                session->sess = NULL;
                session->cert = NULL;
                session->status = ISSL_NONE;
+               session->config = NULL;
        }
 
        void VerifyCertificate(issl_session* session, StreamSocket* user)
@@ -712,11 +931,23 @@ class ModuleSSLGnuTLS : public Module
                        goto info_done_dealloc;
                }
 
-               gnutls_x509_crt_get_dn(cert, name, &name_size);
-               certinfo->dn = name;
+               if (gnutls_x509_crt_get_dn(cert, name, &name_size) == 0)
+               {
+                       std::string& dn = certinfo->dn;
+                       dn = name;
+                       // Make sure there are no chars in the string that we consider invalid
+                       if (dn.find_first_of("\r\n") != std::string::npos)
+                               dn.clear();
+               }
 
-               gnutls_x509_crt_get_issuer_dn(cert, name, &name_size);
-               certinfo->issuer = name;
+               name_size = sizeof(name);
+               if (gnutls_x509_crt_get_issuer_dn(cert, name, &name_size) == 0)
+               {
+                       std::string& issuer = certinfo->issuer;
+                       issuer = name;
+                       if (issuer.find_first_of("\r\n") != std::string::npos)
+                               issuer.clear();
+               }
 
                if ((ret = gnutls_x509_crt_get_fingerprint(cert, hash, digest, &digest_size)) < 0)
                {
@@ -743,6 +974,13 @@ info_done_dealloc:
                if (starttls.enabled)
                        capHandler.HandleEvent(ev);
        }
+
+       ModResult OnCheckReady(LocalUser* user)
+       {
+               if ((user->eh.GetIOHook() == this) && (sessions[user->eh.GetFd()].status != ISSL_HANDSHAKEN))
+                       return MOD_RES_DENY;
+               return MOD_RES_PASSTHRU;
+       }
 };
 
 MODULE_INIT(ModuleSSLGnuTLS)