]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Update m_ssl_gnutls to use libgnutls-30 for gnutls 3.4
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index 25b47c2fe7a44cec067191c5d25c65abf181804f..813a8ecfaa98990698339c32ac17ff15dd660ffa 100644 (file)
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2008 John Brooks <john.brooks@dereferenced.net>
+ *   Copyright (C) 2006-2008 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
  *
- * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 #include "inspircd.h"
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
 #include "ssl.h"
 #include "m_cap.h"
 
-#ifdef WINDOWS
-#pragma comment(lib, "libgnutls-13.lib")
+#ifdef _WIN32
+# pragma comment(lib, "libgnutls-30.lib")
 #endif
 
 /* $ModDesc: Provides SSL support for clients */
-/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") */
-/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") */
-/* $ModDep: transport.h */
-/* $CopyInstall: conf/key.pem $(CONPATH) */
-/* $CopyInstall: conf/cert.pem $(CONPATH) */
+/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --cflags") */
+/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --libs") */
+/* $NoPedantic */
+
+#ifndef GNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MAJOR LIBGNUTLS_VERSION_MAJOR
+#define GNUTLS_VERSION_MINOR LIBGNUTLS_VERSION_MINOR
+#define GNUTLS_VERSION_PATCH LIBGNUTLS_VERSION_PATCH
+#endif
+
+// These don't exist in older GnuTLS versions
+#if ((GNUTLS_VERSION_MAJOR > 2) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR > 1) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR == 1 && GNUTLS_VERSION_PATCH >= 7))
+#define GNUTLS_NEW_PRIO_API
+#endif
+
+#if(GNUTLS_VERSION_MAJOR < 2)
+typedef gnutls_certificate_credentials_t gnutls_certificate_credentials;
+typedef gnutls_dh_params_t gnutls_dh_params;
+#endif
+
+#if (GNUTLS_VERSION_MAJOR > 2 || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR >= 12))
+# define GNUTLS_HAS_RND
+# include <gnutls/crypto.h>
+#else
+# include <gcrypt.h>
+#endif
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
-static gnutls_x509_crt_t x509_cert;
-static gnutls_x509_privkey_t x509_key;
+struct SSLConfig : public refcountbase
+{
+       gnutls_certificate_credentials_t x509_cred;
+       std::vector<gnutls_x509_crt_t> x509_certs;
+       gnutls_x509_privkey_t x509_key;
+       gnutls_dh_params_t dh_params;
+#ifdef GNUTLS_NEW_PRIO_API
+       gnutls_priority_t priority;
+#endif
+
+       SSLConfig()
+               : x509_cred(NULL)
+               , x509_key(NULL)
+               , dh_params(NULL)
+#ifdef GNUTLS_NEW_PRIO_API
+               , priority(NULL)
+#endif
+       {
+       }
+
+       ~SSLConfig()
+       {
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Destroying SSLConfig %p", (void*)this);
+
+               if (x509_cred)
+                       gnutls_certificate_free_credentials(x509_cred);
+
+               for (unsigned int i = 0; i < x509_certs.size(); i++)
+                       gnutls_x509_crt_deinit(x509_certs[i]);
+
+               if (x509_key)
+                       gnutls_x509_privkey_deinit(x509_key);
+
+               if (dh_params)
+                       gnutls_dh_params_deinit(dh_params);
+
+#ifdef GNUTLS_NEW_PRIO_API
+               if (priority)
+                       gnutls_priority_deinit(priority);
+#endif
+       }
+};
+
+static reference<SSLConfig> currconf;
+
+static SSLConfig* GetSessionConfig(gnutls_session_t session);
+
+#if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
 static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
        const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr_st * st) {
 
        st->type = GNUTLS_CRT_X509;
-       st->ncerts = 1;
-       st->cert.x509 = &x509_cert;
-       st->key.x509 = x509_key;
+#else
+static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
+       const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr2_st * st) {
+       st->cert_type = GNUTLS_CRT_X509;
+       st->key_type = GNUTLS_PRIVKEY_X509;
+#endif
+       SSLConfig* conf = GetSessionConfig(session);
+       std::vector<gnutls_x509_crt_t>& x509_certs = conf->x509_certs;
+       st->ncerts = x509_certs.size();
+       st->cert.x509 = &x509_certs[0];
+       st->key.x509 = conf->x509_key;
        st->deinit_all = 0;
 
        return 0;
 }
 
-static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t user_wrap, void* buffer, size_t size)
-{
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_READ_WILL_BLOCK)
-       {
-               errno = EAGAIN;
-               return -1;
-       }
-       int rv = recv(user->GetFd(), buffer, size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_READ_WILL_BLOCK);
-       return rv;
-}
-
-static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t user_wrap, const void* buffer, size_t size)
+class RandGen : public HandlerBase2<void, char*, size_t>
 {
-       StreamSocket* user = reinterpret_cast<StreamSocket*>(user_wrap);
-       if (user->GetEventMask() & FD_WRITE_WILL_BLOCK)
+ public:
+       RandGen() {}
+       void Call(char* buffer, size_t len)
        {
-               errno = EAGAIN;
-               return -1;
+#ifdef GNUTLS_HAS_RND
+               gnutls_rnd(GNUTLS_RND_RANDOM, buffer, len);
+#else
+               gcry_randomize(buffer, len, GCRY_STRONG_RANDOM);
+#endif
        }
-       int rv = send(user->GetFd(), buffer, size, 0);
-       if (rv < (int)size)
-               ServerInstance->SE->ChangeEventMask(user, FD_WRITE_WILL_BLOCK);
-       return rv;
-}
+};
 
 /** Represents an SSL user's extra data
  */
 class issl_session
 {
 public:
-       issl_session()
-       {
-               sess = NULL;
-       }
-
+       StreamSocket* socket;
        gnutls_session_t sess;
        issl_status status;
+       reference<ssl_cert> cert;
+       reference<SSLConfig> config;
+
+       issl_session() : socket(NULL), sess(NULL), status(ISSL_NONE) {}
 };
 
-class CommandStartTLS : public Command
+static SSLConfig* GetSessionConfig(gnutls_session_t sess)
+{
+       issl_session* session = reinterpret_cast<issl_session*>(gnutls_transport_get_ptr(sess));
+       return session->config;
+}
+
+class CommandStartTLS : public SplitCommand
 {
  public:
-       CommandStartTLS (Module* mod) : Command(mod, "STARTTLS")
+       bool enabled;
+       CommandStartTLS (Module* mod) : SplitCommand(mod, "STARTTLS")
        {
+               enabled = true;
                works_before_reg = true;
        }
 
-       CmdResult Handle (const std::vector<std::string> &parameters, User *user)
+       CmdResult HandleLocal(const std::vector<std::string> &parameters, LocalUser *user)
        {
-               /* changed from == REG_ALL to catch clients sending STARTTLS
-                * after NICK and USER but before OnUserConnect completes and
-                * give a proper error message (see bug #645) - dz
-                */
-               if (user->registered != REG_NONE)
+               if (!enabled)
                {
-                       user->WriteNumeric(691, "%s :STARTTLS is not permitted after client registration has started", user->nick.c_str());
+                       user->WriteNumeric(691, "%s :STARTTLS is not enabled", user->nick.c_str());
+                       return CMD_FAILURE;
+               }
+
+               if (user->registered == REG_ALL)
+               {
+                       user->WriteNumeric(691, "%s :STARTTLS is not permitted after client registration is complete", user->nick.c_str());
                }
                else
                {
-                       if (!user->GetIOHook())
+                       if (!user->eh.GetIOHook())
                        {
                                user->WriteNumeric(670, "%s :STARTTLS successful, go ahead with TLS handshake", user->nick.c_str());
-                               user->AddIOHook(creator);
-                               creator->OnStreamSocketAccept(user, NULL, NULL);
+                               /* We need to flush the write buffer prior to adding the IOHook,
+                                * otherwise we'll be sending this line inside the SSL session - which
+                                * won't start its handshake until the client gets this line. Currently,
+                                * we assume the write will not block here; this is usually safe, as
+                                * STARTTLS is sent very early on in the registration phase, where the
+                                * user hasn't built up much sendq. Handling a blocked write here would
+                                * be very annoying.
+                                */
+                               user->eh.DoWrite();
+                               user->eh.AddIOHook(creator);
+                               creator->OnStreamSocketAccept(&user->eh, NULL, NULL);
                        }
                        else
                                user->WriteNumeric(691, "%s :STARTTLS failure", user->nick.c_str());
@@ -124,68 +214,153 @@ class ModuleSSLGnuTLS : public Module
 {
        issl_session* sessions;
 
-       gnutls_certificate_credentials x509_cred;
-       gnutls_dh_params dh_params;
+       gnutls_digest_algorithm_t hash;
 
-       std::string keyfile;
-       std::string certfile;
-       std::string cafile;
-       std::string crlfile;
        std::string sslports;
        int dh_bits;
 
-       bool cred_alloc;
-
+       RandGen randhandler;
        CommandStartTLS starttls;
 
        GenericCap capHandler;
+       ServiceProvider iohook;
+
+       inline static const char* UnknownIfNULL(const char* str)
+       {
+               return str ? str : "UNKNOWN";
+       }
+
+       static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t session_wrap, void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_READ_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Recv(session->socket, reinterpret_cast<char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_READ_WILL_BLOCK);
+               return rv;
+       }
+
+       static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t session_wrap, const void* buffer, size_t size)
+       {
+               issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
+               if (session->socket->GetEventMask() & FD_WRITE_WILL_BLOCK)
+               {
+#ifdef _WIN32
+                       gnutls_transport_set_errno(session->sess, EAGAIN);
+#else
+                       errno = EAGAIN;
+#endif
+                       return -1;
+               }
+
+               int rv = ServerInstance->SE->Send(session->socket, reinterpret_cast<const char *>(buffer), size, 0);
+
+#ifdef _WIN32
+               if (rv < 0)
+               {
+                       /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
+                        * and then set errno appropriately.
+                        * The gnutls library may also have a different errno variable than us, see
+                        * gnutls_transport_set_errno(3).
+                        */
+                       gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
+               }
+#endif
+
+               if (rv < (int)size)
+                       ServerInstance->SE->ChangeEventMask(session->socket, FD_WRITE_WILL_BLOCK);
+               return rv;
+       }
+
  public:
 
        ModuleSSLGnuTLS()
-               : starttls(this), capHandler(this, "tls")
+               : starttls(this), capHandler(this, "tls"), iohook(this, "ssl/gnutls", SERVICE_IOHOOK)
        {
-               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
+#ifndef GNUTLS_HAS_RND
+               gcry_control (GCRYCTL_INITIALIZATION_FINISHED, 0);
+#endif
 
                sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                gnutls_global_init(); // This must be called once in the program
-               gnutls_x509_crt_init(&x509_cert);
-               gnutls_x509_privkey_init(&x509_key);
+       }
 
-               cred_alloc = false;
-               // Needs the flag as it ignores a plain /rehash
-               OnModuleRehash(NULL,"ssl");
+       void init()
+       {
+               currconf = new SSLConfig;
+               InitSSLConfig(currconf);
 
-               // Void return, guess we assume success
-               gnutls_certificate_set_dh_params(x509_cred, dh_params);
-               Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnPostConnect,
-                       I_OnEvent, I_OnHookIO };
+               ServerInstance->GenRandom = &randhandler;
+
+               Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnUserConnect,
+                       I_OnEvent, I_OnHookIO, I_OnCheckReady };
                ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
-               ServerInstance->AddCommand(&starttls);
+               ServerInstance->Modules->AddService(iohook);
+               ServerInstance->Modules->AddService(starttls);
        }
 
        void OnRehash(User* user)
        {
-               ConfigReader Conf;
-
                sslports.clear();
 
-               for (size_t i = 0; i < ServerInstance->ports.size(); i++)
+               ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
+               starttls.enabled = Conf->getBool("starttls", true);
+
+               if (Conf->getBool("showports", true))
                {
-                       ListenSocket* port = ServerInstance->ports[i];
-                       if (port->bind_tag->getString("ssl") != "gnutls")
-                               continue;
+                       sslports = Conf->getString("advertisedports");
+                       if (!sslports.empty())
+                               return;
+
+                       for (size_t i = 0; i < ServerInstance->ports.size(); i++)
+                       {
+                               ListenSocket* port = ServerInstance->ports[i];
+                               if (port->bind_tag->getString("ssl") != "gnutls")
+                                       continue;
 
-                       const std::string& portid = port->bind_desc;
-                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
+                               const std::string& portid = port->bind_desc;
+                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
 
-                       if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
-                               sslports.append(portid).append(";");
+                               if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
+                               {
+                                       /*
+                                        * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
+                                        * the IP:port in ISUPPORT.
+                                        *
+                                        * We used to advertise all ports seperated by a ';' char that matched the above criteria,
+                                        * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
+                                        * To solve this by default we now only display the first IP:port found and let the user
+                                        * configure the exact value for the 005 token, if necessary.
+                                        */
+                                       sslports = portid;
+                                       break;
+                               }
+                       }
                }
-
-               if (!sslports.empty())
-                       sslports.erase(sslports.end() - 1);
        }
 
        void OnModuleRehash(User* user, const std::string &param)
@@ -193,45 +368,74 @@ class ModuleSSLGnuTLS : public Module
                if(param != "ssl")
                        return;
 
-               OnRehash(user);
-
-               ConfigReader Conf;
-
-               cafile = Conf.ReadValue("gnutls", "cafile", 0);
-               crlfile = Conf.ReadValue("gnutls", "crlfile", 0);
-               certfile = Conf.ReadValue("gnutls", "certfile", 0);
-               keyfile = Conf.ReadValue("gnutls", "keyfile", 0);
-               dh_bits = Conf.ReadInteger("gnutls", "dhbits", 0, false);
-
-               // Set all the default values needed.
-               if (cafile.empty())
-                       cafile = "conf/ca.pem";
-
-               if (crlfile.empty())
-                       crlfile = "conf/crl.pem";
+               reference<SSLConfig> newconf = new SSLConfig;
+               try
+               {
+                       InitSSLConfig(newconf);
+               }
+               catch (ModuleException& ex)
+               {
+                       ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Not applying new config. %s", ex.GetReason());
+                       return;
+               }
 
-               if (certfile.empty())
-                       certfile = "conf/cert.pem";
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Applying new config, old config is in use by %d connection(s)", currconf->GetReferenceCount()-1);
+               currconf = newconf;
+       }
 
-               if (keyfile.empty())
-                       keyfile = "conf/key.pem";
+       void InitSSLConfig(SSLConfig* config)
+       {
+               ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Initializing new SSLConfig %p", (void*)config);
+
+               std::string keyfile;
+               std::string certfile;
+               std::string cafile;
+               std::string crlfile;
+               OnRehash(NULL);
+
+               ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
+
+               cafile = Conf->getString("cafile", CONFIG_PATH "/ca.pem");
+               crlfile = Conf->getString("crlfile", CONFIG_PATH "/crl.pem");
+               certfile = Conf->getString("certfile", CONFIG_PATH "/cert.pem");
+               keyfile = Conf->getString("keyfile", CONFIG_PATH "/key.pem");
+               dh_bits = Conf->getInt("dhbits");
+               std::string hashname = Conf->getString("hash", "md5");
+
+               // The GnuTLS manual states that the gnutls_set_default_priority()
+               // call we used previously when initializing the session is the same
+               // as setting the "NORMAL" priority string.
+               // Thus if the setting below is not in the config we will behave exactly
+               // the same as before, when the priority setting wasn't available.
+               std::string priorities = Conf->getString("priority", "NORMAL");
 
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
                        dh_bits = 1024;
 
+               if (hashname == "md5")
+                       hash = GNUTLS_DIG_MD5;
+               else if (hashname == "sha1")
+                       hash = GNUTLS_DIG_SHA1;
+#ifdef INSPIRCD_GNUTLS_ENABLE_SHA256_FINGERPRINT
+               else if (hashname == "sha256")
+                       hash = GNUTLS_DIG_SHA256;
+#endif
+               else
+                       throw ModuleException("Unknown hash type " + hashname);
+
+
                int ret;
 
-               if (cred_alloc)
+               gnutls_certificate_credentials_t& x509_cred = config->x509_cred;
+
+               ret = gnutls_certificate_allocate_credentials(&x509_cred);
+               if (ret < 0)
                {
-                       // Deallocate the old credentials
-                       gnutls_dh_params_deinit(dh_params);
-                       gnutls_certificate_free_credentials(x509_cred);
+                       // Set to NULL because we can't be sure what value is in it and we must not try to
+                       // deallocate it in case of an error
+                       x509_cred = NULL;
+                       throw ModuleException("Failed to allocate certificate credentials: " + std::string(gnutls_strerror(ret)));
                }
-               else
-                       cred_alloc = true;
-
-               if((ret = gnutls_certificate_allocate_credentials(&x509_cred)) < 0)
-                       ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to allocate certificate credentials: %s", gnutls_strerror(ret));
 
                if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
@@ -243,32 +447,106 @@ class ModuleSSLGnuTLS : public Module
 
                reader.LoadFile(certfile);
                std::string cert_string = reader.Contents();
-               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), cert_string.length() };
+               gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), static_cast<unsigned int>(cert_string.length()) };
 
                reader.LoadFile(keyfile);
                std::string key_string = reader.Contents();
-               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), key_string.length() };
+               gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), static_cast<unsigned int>(key_string.length()) };
+
+               std::vector<gnutls_x509_crt_t>& x509_certs = config->x509_certs;
 
                // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
-               if((ret = gnutls_x509_crt_import(x509_cert, &cert_datum, GNUTLS_X509_FMT_PEM)) < 0)
-                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + std::string(gnutls_strerror(ret)));
+               unsigned int certcount = 3;
+               x509_certs.resize(certcount);
+               ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
+               if (ret == GNUTLS_E_SHORT_MEMORY_BUFFER)
+               {
+                       // the buffer wasn't big enough to hold all certs but gnutls updated certcount to the number of available certs, try again with a bigger buffer
+                       x509_certs.resize(certcount);
+                       ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
+               }
+
+               if (ret <= 0)
+               {
+                       // clear the vector so we won't call gnutls_x509_crt_deinit() on the (uninited) certs later
+                       x509_certs.clear();
+                       throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + ((ret < 0) ? (std::string(gnutls_strerror(ret))) : "No certs could be read"));
+               }
+               x509_certs.resize(ret);
+
+               gnutls_x509_privkey_t& x509_key = config->x509_key;
+               if (gnutls_x509_privkey_init(&x509_key) < 0)
+               {
+                       // Make sure the destructor does not try to deallocate this, see above
+                       x509_key = NULL;
+                       throw ModuleException("Unable to initialize private key");
+               }
 
                if((ret = gnutls_x509_privkey_import(x509_key, &key_datum, GNUTLS_X509_FMT_PEM)) < 0)
                        throw ModuleException("Unable to load GnuTLS server private key (" + keyfile + "): " + std::string(gnutls_strerror(ret)));
 
-               if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_cert, 1, x509_key)) < 0)
+               if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_certs[0], certcount, x509_key)) < 0)
                        throw ModuleException("Unable to set GnuTLS cert/key pair: " + std::string(gnutls_strerror(ret)));
 
+               #ifdef GNUTLS_NEW_PRIO_API
+               // Try to set the priorities for ciphers, kex methods etc. to the user supplied string
+               // If the user did not supply anything then the string is already set to "NORMAL"
+               const char* priocstr = priorities.c_str();
+               const char* prioerror;
+
+               gnutls_priority_t& priority = config->priority;
+               if ((ret = gnutls_priority_init(&priority, priocstr, &prioerror)) < 0)
+               {
+                       // gnutls did not understand the user supplied string, log and fall back to the default priorities
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set priorities to \"%s\": %s Syntax error at position %u, falling back to default (NORMAL)", priorities.c_str(), gnutls_strerror(ret), (unsigned int) (prioerror - priocstr));
+                       gnutls_priority_init(&priority, "NORMAL", NULL);
+               }
+
+               #else
+               if (priorities != "NORMAL")
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: You've set <gnutls:priority> to a value other than the default, but this is only supported with GnuTLS v2.1.7 or newer. Your GnuTLS version is older than that so the option will have no effect.");
+               #endif
+
+               #if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
                gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
+               #else
+               gnutls_certificate_set_retrieve_function (x509_cred, cert_callback);
+               #endif
 
-               if((ret = gnutls_dh_params_init(&dh_params)) < 0)
+               gnutls_dh_params_t& dh_params = config->dh_params;
+               ret = gnutls_dh_params_init(&dh_params);
+               if (ret < 0)
+               {
+                       // Make sure the destructor does not try to deallocate this, see above
+                       dh_params = NULL;
                        ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
+                       return;
+               }
+
+               std::string dhfile = Conf->getString("dhfile");
+               if (!dhfile.empty())
+               {
+                       // Try to load DH params from file
+                       reader.LoadFile(dhfile);
+                       std::string dhstring = reader.Contents();
+                       gnutls_datum_t dh_datum = { (unsigned char*)dhstring.data(), static_cast<unsigned int>(dhstring.length()) };
+
+                       if ((ret = gnutls_dh_params_import_pkcs3(dh_params, &dh_datum, GNUTLS_X509_FMT_PEM)) < 0)
+                       {
+                               // File unreadable or GnuTLS was unhappy with the contents, generate the DH primes now
+                               ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Generating DH parameters because I failed to load them from file '%s': %s", dhfile.c_str(), gnutls_strerror(ret));
+                               GenerateDHParams(dh_params);
+                       }
+               }
+               else
+               {
+                       GenerateDHParams(dh_params);
+               }
 
-               // This may be on a large (once a day or week) timer eventually.
-               GenerateDHParams();
+               gnutls_certificate_set_dh_params(x509_cred, dh_params);
        }
 
-       void GenerateDHParams()
+       void GenerateDHParams(gnutls_dh_params_t dh_params)
        {
                // Generate Diffie Hellman parameters - for use with DHE
                // kx algorithms. These should be discarded and regenerated
@@ -283,27 +561,24 @@ class ModuleSSLGnuTLS : public Module
 
        ~ModuleSSLGnuTLS()
        {
-               gnutls_x509_crt_deinit(x509_cert);
-               gnutls_x509_privkey_deinit(x509_key);
-               gnutls_dh_params_deinit(dh_params);
-               gnutls_certificate_free_credentials(x509_cred);
+               currconf = NULL;
+
                gnutls_global_deinit();
-               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
                delete[] sessions;
+               ServerInstance->GenRandom = &ServerInstance->HandleGenRandom;
        }
 
        void OnCleanup(int target_type, void* item)
        {
                if(target_type == TYPE_USER)
                {
-                       User* user = static_cast<User*>(item);
+                       LocalUser* user = IS_LOCAL(static_cast<User*>(item));
 
-                       if (user->GetIOHook() == this)
+                       if (user && user->eh.GetIOHook() == this)
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
                                ServerInstance->Users->QuitUser(user, "SSL module unloading");
-                               user->DelIOHook();
                        }
                }
        }
@@ -318,7 +593,8 @@ class ModuleSSLGnuTLS : public Module
        {
                if (!sslports.empty())
                        output.append(" SSL=" + sslports);
-               output.append(" STARTTLS");
+               if (starttls.enabled)
+                       output.append(" STARTTLS");
        }
 
        void OnHookIO(StreamSocket* user, ListenSocket* lsb)
@@ -332,50 +608,61 @@ class ModuleSSLGnuTLS : public Module
 
        void OnRequest(Request& request)
        {
-               Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
-               if (sslinfo)
-                       sslinfo->OnRequest(request);
-       }
+               if (strcmp("GET_SSL_CERT", request.id) == 0)
+               {
+                       SocketCertificateRequest& req = static_cast<SocketCertificateRequest&>(request);
+                       int fd = req.sock->GetFd();
+                       issl_session* session = &sessions[fd];
 
+                       req.cert = session->cert;
+               }
+               else if (!strcmp("GET_RAW_SSL_SESSION", request.id))
+               {
+                       SSLRawSessionRequest& req = static_cast<SSLRawSessionRequest&>(request);
+                       if ((req.fd >= 0) && (req.fd < ServerInstance->SE->GetMaxFds()))
+                               req.data = reinterpret_cast<void*>(sessions[req.fd].sess);
+               }
+       }
 
-       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
+       void InitSession(StreamSocket* user, bool me_server)
        {
-               int fd = user->GetFd();
-               issl_session* session = &sessions[fd];
-
-               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
-               if (session->sess)
-                       return;
+               issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_SERVER);
+               gnutls_init(&session->sess, me_server ? GNUTLS_SERVER : GNUTLS_CLIENT);
+               session->socket = user;
+               session->config = currconf;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
-               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
+               #ifdef GNUTLS_NEW_PRIO_API
+               gnutls_priority_set(session->sess, currconf->priority);
+               #else
+               gnutls_set_default_priority(session->sess);
+               #endif
+               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, currconf->x509_cred);
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
-
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
+               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(session));
                gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
                gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 
-               gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
+               if (me_server)
+                       gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
 
                Handshake(session, user);
        }
 
-       void OnStreamSocketConnect(StreamSocket* user)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
                issl_session* session = &sessions[user->GetFd()];
 
-               gnutls_init(&session->sess, GNUTLS_CLIENT);
+               /* For STARTTLS: Don't try and init a session on a socket that already has a session */
+               if (session->sess)
+                       return;
 
-               gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
-               gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
-               gnutls_dh_set_prime_bits(session->sess, dh_bits);
-               gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(user));
-               gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
-               gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
+               InitSession(user, true);
+       }
 
-               Handshake(session, user);
+       void OnStreamSocketConnect(StreamSocket* user)
+       {
+               InitSession(user, false);
        }
 
        void OnStreamSocketClose(StreamSocket* user)
@@ -402,7 +689,6 @@ class ModuleSSLGnuTLS : public Module
                        {
                                if (session->status != ISSL_CLOSING)
                                        return 0;
-                               user->SetError("Handshake Failed");
                                return -1;
                        }
                }
@@ -425,7 +711,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else if (ret == 0)
                        {
-                               user->SetError("SSL Connection closed");
+                               user->SetError("Connection closed");
                                CloseSession(session);
                                return -1;
                        }
@@ -459,7 +745,6 @@ class ModuleSSLGnuTLS : public Module
                        Handshake(session, user);
                        if (session->status != ISSL_CLOSING)
                                return 0;
-                       user->SetError("Handshake Failed");
                        return -1;
                }
 
@@ -480,17 +765,11 @@ class ModuleSSLGnuTLS : public Module
                                ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
                                return 0;
                        }
-                       else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
+                       else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED || ret == 0)
                        {
                                ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
                                return 0;
                        }
-                       else if (ret == 0)
-                       {
-                               CloseSession(session);
-                               user->SetError("SSL Connection closed");
-                               return -1;
-                       }
                        else // (ret < 0)
                        {
                                user->SetError(gnutls_strerror(ret));
@@ -527,6 +806,7 @@ class ModuleSSLGnuTLS : public Module
                        }
                        else
                        {
+                               user->SetError("Handshake Failed - " + std::string(gnutls_strerror(ret)));
                                CloseSession(session);
                                session->status = ISSL_CLOSING;
                        }
@@ -547,43 +827,46 @@ class ModuleSSLGnuTLS : public Module
                }
        }
 
-       void OnPostConnect(User* user)
+       void OnUserConnect(LocalUser* user)
        {
-               // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propagated the NICK message.
-               if (user->GetIOHook() == this)
+               if (user->eh.GetIOHook() == this)
                {
-                       if (sessions[user->GetFd()].sess)
+                       if (sessions[user->eh.GetFd()].sess)
                        {
-                               std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->GetFd()].sess));
-                               cipher.append("-").append(gnutls_cipher_get_name(gnutls_cipher_get(sessions[user->GetFd()].sess))).append("-");
-                               cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->GetFd()].sess)));
-                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
+                               const gnutls_session_t& sess = sessions[user->eh.GetFd()].sess;
+                               std::string cipher = UnknownIfNULL(gnutls_kx_get_name(gnutls_kx_get(sess)));
+                               cipher.append("-").append(UnknownIfNULL(gnutls_cipher_get_name(gnutls_cipher_get(sess)))).append("-");
+                               cipher.append(UnknownIfNULL(gnutls_mac_get_name(gnutls_mac_get(sess))));
+
+                               ssl_cert* cert = sessions[user->eh.GetFd()].cert;
+                               if (cert->fingerprint.empty())
+                                       user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
+                               else
+                                       user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\""
+                                               " and your SSL fingerprint is %s", user->nick.c_str(), cipher.c_str(), cert->fingerprint.c_str());
                        }
                }
        }
 
        void CloseSession(issl_session* session)
        {
-               if(session->sess)
+               if (session->sess)
                {
                        gnutls_bye(session->sess, GNUTLS_SHUT_WR);
                        gnutls_deinit(session->sess);
                }
-
+               session->socket = NULL;
                session->sess = NULL;
+               session->cert = NULL;
                session->status = ISSL_NONE;
+               session->config = NULL;
        }
 
-       void VerifyCertificate(issl_session* session, Extensible* user)
+       void VerifyCertificate(issl_session* session, StreamSocket* user)
        {
                if (!session->sess || !user)
                        return;
 
-               Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
-               if (!sslinfo)
-                       return;
-
                unsigned int status;
                const gnutls_datum_t* cert_list;
                int ret;
@@ -594,6 +877,7 @@ class ModuleSSLGnuTLS : public Module
                size_t digest_size = sizeof(digest);
                size_t name_size = sizeof(name);
                ssl_cert* certinfo = new ssl_cert;
+               session->cert = certinfo;
 
                /* This verification function uses the trusted CAs in the credentials
                 * structure. So you must have installed one or more CA certificates.
@@ -603,7 +887,7 @@ class ModuleSSLGnuTLS : public Module
                if (ret < 0)
                {
                        certinfo->error = std::string(gnutls_strerror(ret));
-                       goto info_done;
+                       return;
                }
 
                certinfo->invalid = (status & GNUTLS_CERT_INVALID);
@@ -618,14 +902,14 @@ class ModuleSSLGnuTLS : public Module
                if (gnutls_certificate_type_get(session->sess) != GNUTLS_CRT_X509)
                {
                        certinfo->error = "No X509 keys sent";
-                       goto info_done;
+                       return;
                }
 
                ret = gnutls_x509_crt_init(&cert);
                if (ret < 0)
                {
                        certinfo->error = gnutls_strerror(ret);
-                       goto info_done;
+                       return;
                }
 
                cert_list_size = 0;
@@ -647,13 +931,25 @@ class ModuleSSLGnuTLS : public Module
                        goto info_done_dealloc;
                }
 
-               gnutls_x509_crt_get_dn(cert, name, &name_size);
-               certinfo->dn = name;
+               if (gnutls_x509_crt_get_dn(cert, name, &name_size) == 0)
+               {
+                       std::string& dn = certinfo->dn;
+                       dn = name;
+                       // Make sure there are no chars in the string that we consider invalid
+                       if (dn.find_first_of("\r\n") != std::string::npos)
+                               dn.clear();
+               }
 
-               gnutls_x509_crt_get_issuer_dn(cert, name, &name_size);
-               certinfo->issuer = name;
+               name_size = sizeof(name);
+               if (gnutls_x509_crt_get_issuer_dn(cert, name, &name_size) == 0)
+               {
+                       std::string& issuer = certinfo->issuer;
+                       issuer = name;
+                       if (issuer.find_first_of("\r\n") != std::string::npos)
+                               issuer.clear();
+               }
 
-               if ((ret = gnutls_x509_crt_get_fingerprint(cert, GNUTLS_DIG_MD5, digest, &digest_size)) < 0)
+               if ((ret = gnutls_x509_crt_get_fingerprint(cert, hash, digest, &digest_size)) < 0)
                {
                        certinfo->error = gnutls_strerror(ret);
                }
@@ -671,13 +967,19 @@ class ModuleSSLGnuTLS : public Module
 
 info_done_dealloc:
                gnutls_x509_crt_deinit(cert);
-info_done:
-               SSLCertSubmission(user, this, sslinfo, certinfo);
        }
 
        void OnEvent(Event& ev)
        {
-               capHandler.HandleEvent(ev);
+               if (starttls.enabled)
+                       capHandler.HandleEvent(ev);
+       }
+
+       ModResult OnCheckReady(LocalUser* user)
+       {
+               if ((user->eh.GetIOHook() == this) && (sessions[user->eh.GetFd()].status != ISSL_HANDSHAKEN))
+                       return MOD_RES_DENY;
+               return MOD_RES_PASSTHRU;
        }
 };