]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_gnutls.cpp
Add stuff so that modules can hook users by altering a pointer in the User class...
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_gnutls.cpp
index cb88fdf7027ac5aad2b7fdc409343badb084f499..f3af386aea579689b0cc5f730c8dcaf393906beb 100644 (file)
@@ -2,17 +2,16 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ *         the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <vector>
+#include "inspircd.h"
 
 #include <gnutls/gnutls.h>
 #include <gnutls/x509.h>
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-
 #include "socket.h"
 #include "hashcomp.h"
-#include "inspircd.h"
-
 #include "transport.h"
+#include "m_cap.h"
+
+#ifdef WINDOWS
+#pragma comment(lib, "libgnutls-13.lib")
+#undef MAX_DESCRIPTORS
+#define MAX_DESCRIPTORS 10000
+#endif
 
 /* $ModDesc: Provides SSL support for clients */
 /* $CompileFlags: exec("libgnutls-config --cflags") */
 /* $LinkerFlags: rpath("libgnutls-config --libs") exec("libgnutls-config --libs") */
 /* $ModDep: transport.h */
-
+/* $CopyInstall: conf/key.pem $(CONPATH) */
+/* $CopyInstall: conf/cert.pem $(CONPATH) */
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 
@@ -59,6 +63,28 @@ public:
        int fd;
 };
 
+class CommandStartTLS : public Command
+{
+       Module* Caller;
+ public:
+       /* Command 'dalinfo', takes no parameters and needs no special modes */
+       CommandStartTLS (InspIRCd* Instance, Module* mod) : Command(Instance,"STARTTLS", 0, 0, true), Caller(mod)
+       {
+               this->source = "m_ssl_gnutls.so";
+       }
+
+       CmdResult Handle (const char* const* parameters, int pcnt, User *user)
+       {
+               if (!user->GetExt("tls"))
+                       return CMD_FAILURE;
+
+               user->io = Caller;
+               Caller->OnRawSocketAccept(user->GetFd(), user->GetIPString(), ServerInstance->Config->ports[i]->GetPort());
+
+               return CMD_FAILURE;
+       }
+};
+
 class ModuleSSLGnuTLS : public Module
 {
 
@@ -78,14 +104,19 @@ class ModuleSSLGnuTLS : public Module
        std::string certfile;
        std::string cafile;
        std::string crlfile;
+       std::string sslports;
        int dh_bits;
 
+       int clientactive;
+
+       CommandStartTLS* starttls;
+
  public:
 
        ModuleSSLGnuTLS(InspIRCd* Me)
-               : Module::Module(Me)
+               : Module(Me)
        {
-               ServerInstance->PublishInterface("InspSocketHook", this);
+               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
@@ -93,24 +124,27 @@ class ModuleSSLGnuTLS : public Module
                gnutls_global_init(); // This must be called once in the program
 
                if(gnutls_certificate_allocate_credentials(&x509_cred) != 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to allocate certificate credentials");
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to allocate certificate credentials");
 
                // Guessing return meaning
                if(gnutls_dh_params_init(&dh_params) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters");
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters");
 
                // Needs the flag as it ignores a plain /rehash
                OnRehash(NULL,"ssl");
 
                // Void return, guess we assume success
                gnutls_certificate_set_dh_params(x509_cred, dh_params);
+               Implementation eventlist[] = { I_On005Numeric, I_OnRawSocketConnect, I_OnRawSocketAccept, I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup,
+                       I_OnBufferFlushed, I_OnRequest, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUnloadModule, I_OnRehash, I_OnWhois, I_OnPostConnect, I_OnEvent, I_OnHookUserIO };
+               ServerInstance->Modules->Attach(eventlist, this, 17);
+
+               starttls = new CommandStartTLS(ServerInstance, this);
+               ServerInstance->AddCommand(starttls);
        }
 
-       virtual void OnRehash(userrec* user, const std::string &param)
+       virtual void OnRehash(User* user, const std::string &param)
        {
-               if(param != "ssl")
-                       return;
-
                Conf = new ConfigReader(ServerInstance);
 
                for(unsigned int i = 0; i < listenports.size(); i++)
@@ -119,35 +153,53 @@ class ModuleSSLGnuTLS : public Module
                }
 
                listenports.clear();
+               clientactive = 0;
+               sslports.clear();
 
-               for(int i = 0; i < Conf->Enumerate("bind"); i++)
+               for(int index = 0; index < Conf->Enumerate("bind"); index++)
                {
                        // For each <bind> tag
-                       if(((Conf->ReadValue("bind", "type", i) == "") || (Conf->ReadValue("bind", "type", i) == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "gnutls"))
+                       std::string x = Conf->ReadValue("bind", "type", index);
+                       if(((x.empty()) || (x == "clients")) && (Conf->ReadValue("bind", "ssl", index) == "gnutls"))
                        {
                                // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf->ReadValue("bind", "port", i);
+                               std::string port = Conf->ReadValue("bind", "port", index);
                                irc::portparser portrange(port, false);
                                long portno = -1;
                                while ((portno = portrange.GetToken()))
                                {
-                                       if (ServerInstance->Config->AddIOHook(portno, this))
+                                       clientactive++;
+                                       try
                                        {
-                                               listenports.push_back(portno);
-                                               for (unsigned int i = 0; i < ServerInstance->stats->BoundPortCount; i++)
-                                                       if (ServerInstance->Config->ports[i] == portno)
-                                                               ServerInstance->Config->openSockfd[i]->SetDescription("ssl");
-                                               ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %d", portno);
+                                               if (ServerInstance->Config->AddIOHook(portno, this))
+                                               {
+                                                       listenports.push_back(portno);
+                                                       for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
+                                                               if (ServerInstance->Config->ports[i]->GetPort() == portno)
+                                                                       ServerInstance->Config->ports[i]->SetDescription("ssl");
+                                                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %d", portno);
+                                                       sslports.append("*:").append(ConvToStr(portno)).append(";");
+                                               }
+                                               else
+                                               {
+                                                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?", portno);
+                                               }
                                        }
-                                       else
+                                       catch (ModuleException &e)
                                        {
-                                               ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?", portno);
+                                               ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %d: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
                                        }
                                }
                        }
                }
 
-               std::string confdir(CONFIG_FILE);
+               if(param != "ssl")
+               {
+                       delete Conf;
+                       return;
+               }
+
+               std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
                confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
 
@@ -158,16 +210,16 @@ class ModuleSSLGnuTLS : public Module
                dh_bits = Conf->ReadInteger("gnutls", "dhbits", 0, false);
 
                // Set all the default values needed.
-               if(cafile == "")
+               if (cafile.empty())
                        cafile = "ca.pem";
 
-               if(crlfile == "")
+               if (crlfile.empty())
                        crlfile = "crl.pem";
 
-               if(certfile == "")
+               if (certfile.empty())
                        certfile = "cert.pem";
 
-               if(keyfile == "")
+               if (keyfile.empty())
                        keyfile = "key.pem";
 
                if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
@@ -189,19 +241,21 @@ class ModuleSSLGnuTLS : public Module
                int ret;
 
                if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
 
                if((ret = gnutls_certificate_set_x509_crl_file (x509_cred, crlfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
 
-               // Guessing on the return value of this, manual doesn't say :|
                if((ret = gnutls_certificate_set_x509_key_file (x509_cred, certfile.c_str(), keyfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to set X.509 certificate and key files '%s' and '%s': %s", certfile.c_str(), keyfile.c_str(), gnutls_strerror(ret));
+               {
+                       // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
+                       throw ModuleException("Unable to load GnuTLS server certificate: " + std::string(gnutls_strerror(ret)));
+               }
 
                // This may be on a large (once a day or week) timer eventually.
                GenerateDHParams();
 
-               DELETE(Conf);
+               delete Conf;
        }
 
        void GenerateDHParams()
@@ -214,7 +268,7 @@ class ModuleSSLGnuTLS : public Module
                int ret;
 
                if((ret = gnutls_dh_params_generate2(dh_params, dh_bits)) < 0)
-                       ServerInstance->Log(DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
+                       ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
        }
 
        virtual ~ModuleSSLGnuTLS()
@@ -228,13 +282,13 @@ class ModuleSSLGnuTLS : public Module
        {
                if(target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
+                       User* user = (User*)item;
 
                        if(user->GetExt("ssl", dummy) && isin(user->GetPort(), listenports))
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->GlobalCulls.AddItem(user, "SSL module unloading");
+                               User::QuitUser(ServerInstance, user, "SSL module unloading");
                        }
                        if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
                        {
@@ -243,6 +297,8 @@ class ModuleSSLGnuTLS : public Module
                                delete tofree;
                                user->Shrink("ssl_cert");
                        }
+
+                       user->io = NULL;
                }
        }
 
@@ -253,26 +309,34 @@ class ModuleSSLGnuTLS : public Module
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
                                ServerInstance->Config->DelIOHook(listenports[i]);
-                               for (unsigned int j = 0; j < ServerInstance->stats->BoundPortCount; j++)
-                                       if (ServerInstance->Config->ports[j] == listenports[i])
-                                               if (ServerInstance->Config->openSockfd[j])
-                                                       ServerInstance->Config->openSockfd[j]->SetDescription("plaintext");
+                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
+                                       if (ServerInstance->Config->ports[j]->GetPort() == listenports[i])
+                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
                        }
                }
        }
 
        virtual Version GetVersion()
        {
-               return Version(1, 1, 0, 0, VF_VENDOR, API_VERSION);
+               return Version(1, 2, 0, 0, VF_VENDOR, API_VERSION);
        }
 
-       void Implements(char* List)
+
+       virtual void On005Numeric(std::string &output)
+       {
+               output.append(" SSL=" + sslports);
+       }
+
+       virtual void OnHookUserIO(User* user)
        {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
+               if (!user->io && isin(user->GetPort(), listenports))
+               {
+                       /* Hook the user with our module */
+                       user->io = this;
+               }
        }
 
-        virtual char* OnRequest(Request* request)
+       virtual const char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
                if (strcmp("IS_NAME", request->GetId()) == 0)
@@ -281,10 +345,10 @@ class ModuleSSLGnuTLS : public Module
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       char* ret = "OK";
+                       const char* ret = "OK";
                        try
                        {
-                               ret = ServerInstance->Config->AddIOHook((Module*)this, (InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                               ret = ServerInstance->Config->AddIOHook((Module*)this, (BufferedSocket*)ISR->Sock) ? "OK" : NULL;
                        }
                        catch (ModuleException &e)
                        {
@@ -294,20 +358,29 @@ class ModuleSSLGnuTLS : public Module
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ServerInstance->Config->DelIOHook((InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                       return ServerInstance->Config->DelIOHook((BufferedSocket*)ISR->Sock) ? "OK" : NULL;
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
+                       if (ISR->Sock->GetFd() < 0)
+                               return "OK";
+
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       return (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE) ? NULL : (char*)"OK";
+                       return (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE) ? NULL : "OK";
                }
                else if (strcmp("IS_ATTACH", request->GetId()) == 0)
                {
-                       issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       if (session)
+                       if (ISR->Sock->GetFd() > -1)
                        {
-                               VerifyCertificate(session, (InspSocket*)ISR->Sock);
-                               return "OK";
+                               issl_session* session = &sessions[ISR->Sock->GetFd()];
+                               if (session->sess)
+                               {
+                                       if ((Extensible*)ServerInstance->FindDescriptor(ISR->Sock->GetFd()) == (Extensible*)(ISR->Sock))
+                                       {
+                                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
+                                               return "OK";
+                                       }
+                               }
                        }
                }
                return NULL;
@@ -316,6 +389,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -326,7 +403,6 @@ class ModuleSSLGnuTLS : public Module
 
                gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
                gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
-               gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
 
                /* This is an experimental change to avoid a warning on 64bit systems about casting between integer and pointer of different sizes
@@ -339,11 +415,17 @@ class ModuleSSLGnuTLS : public Module
 
                gnutls_transport_set_ptr(session->sess, (gnutls_transport_ptr_t) fd); // Give gnutls the fd for the socket.
 
+               gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
+
                Handshake(session);
        }
 
        virtual void OnRawSocketConnect(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -354,10 +436,7 @@ class ModuleSSLGnuTLS : public Module
 
                gnutls_set_default_priority(session->sess); // Avoid calling all the priority functions, defaults are adequate.
                gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, x509_cred);
-               //TODO: Request server cert here.
-               //gnutls_certificate_request(session->sess, GNUTLS_CERT_REQUEST); // Request server certificate if any.
                gnutls_dh_set_prime_bits(session->sess, dh_bits);
-
                gnutls_transport_set_ptr(session->sess, (gnutls_transport_ptr_t) fd); // Give gnutls the fd for the socket.
 
                Handshake(session);
@@ -365,6 +444,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -380,6 +463,10 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -401,6 +488,8 @@ class ModuleSSLGnuTLS : public Module
                }
                else if (session->status == ISSL_HANDSHAKING_WRITE)
                {
+                       errno = EAGAIN;
+                       MakePollWrite(session);
                        return -1;
                }
 
@@ -422,7 +511,10 @@ class ModuleSSLGnuTLS : public Module
                        else if (ret < 0)
                        {
                                if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
+                               {
+                                       errno = EAGAIN;
                                        return -1;
+                               }
                                else
                                {
                                        readresult = 0;
@@ -466,7 +558,8 @@ class ModuleSSLGnuTLS : public Module
 
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
-               if (!count)
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
                        return 0;
 
                issl_session* session = &sessions[fd];
@@ -482,26 +575,34 @@ class ModuleSSLGnuTLS : public Module
                sendbuffer = session->outbuf.c_str();
                count = session->outbuf.size();
 
-               if(session->status == ISSL_HANDSHAKING_WRITE)
+               if (session->status == ISSL_HANDSHAKING_WRITE)
                {
                        // The handshake isn't finished, try to finish it.
                        Handshake(session);
                        errno = EAGAIN;
-                       return 0;
+                       return -1;
                }
 
                int ret = 0;
 
-               if(session->status == ISSL_HANDSHAKEN)
+               if (session->status == ISSL_HANDSHAKEN)
                {
                        ret = gnutls_record_send(session->sess, sendbuffer, count);
 
-                       if(ret == 0)
+                       if (ret == 0)
+                       {
                                CloseSession(session);
-                       else if(ret < 0)
+                       }
+                       else if (ret < 0)
                        {
                                if(ret != GNUTLS_E_AGAIN && ret != GNUTLS_E_INTERRUPTED)
+                               {
                                        CloseSession(session);
+                               }
+                               else
+                               {
+                                       errno = EAGAIN;
+                               }
                        }
                        else
                        {
@@ -509,15 +610,20 @@ class ModuleSSLGnuTLS : public Module
                        }
                }
 
+               MakePollWrite(session);
+
                /* Who's smart idea was it to return 1 when we havent written anything?
-                * This fucks the buffer up in InspSocket :p
+                * This fucks the buffer up in BufferedSocket :p
                 */
                return ret < 1 ? 0 : ret;
        }
 
        // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(userrec* source, userrec* dest)
+       virtual void OnWhois(User* source, User* dest)
        {
+               if (!clientactive)
+                       return;
+
                // Bugfix, only send this numeric for *our* SSL users
                if(dest->GetExt("ssl", dummy) || (IS_LOCAL(dest) &&  isin(dest->GetPort(), listenports)))
                {
@@ -525,7 +631,7 @@ class ModuleSSLGnuTLS : public Module
                }
        }
 
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname)
+       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
        {
                // check if the linking module wants to know about OUR metadata
                if(extname == "ssl")
@@ -535,7 +641,7 @@ class ModuleSSLGnuTLS : public Module
                        {
                                // call this function in the linking module, let it format the data how it
                                // sees fit, and send it on its way. We dont need or want to know how.
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, "ON");
+                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, displayable ? "Enabled" : "ON");
                        }
                }
        }
@@ -545,7 +651,7 @@ class ModuleSSLGnuTLS : public Module
                // check if its our metadata key, and its associated with a user
                if ((target_type == TYPE_USER) && (extname == "ssl"))
                {
-                       userrec* dest = (userrec*)target;
+                       User* dest = (User*)target;
                        // if they dont already have an ssl flag, accept the remote server's
                        if (!dest->GetExt(extname, dummy))
                        {
@@ -589,7 +695,7 @@ class ModuleSSLGnuTLS : public Module
                {
                        // Handshake complete.
                        // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       userrec* extendme = ServerInstance->FindDescriptor(session->fd);
+                       User* extendme = ServerInstance->FindDescriptor(session->fd);
                        if (extendme)
                        {
                                if (!extendme->GetExt("ssl", dummy))
@@ -606,10 +712,10 @@ class ModuleSSLGnuTLS : public Module
                }
        }
 
-       virtual void OnPostConnect(userrec* user)
+       virtual void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
+               // protocol module has propagated the NICK message.
                if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
@@ -619,16 +725,36 @@ class ModuleSSLGnuTLS : public Module
                        metadata->push_back("ON");              // The value to send
                        Event* event = new Event((char*)metadata,(Module*)this,"send_metadata");
                        event->Send(ServerInstance);            // Trigger the event. We don't care what module picks it up.
-                       DELETE(event);
-                       DELETE(metadata);
+                       delete event;
+                       delete metadata;
 
                        VerifyCertificate(&sessions[user->GetFd()],user);
+                       if (sessions[user->GetFd()].sess)
+                       {
+                               std::string cipher = gnutls_kx_get_name(gnutls_kx_get(sessions[user->GetFd()].sess));
+                               cipher.append("-").append(gnutls_cipher_get_name(gnutls_cipher_get(sessions[user->GetFd()].sess))).append("-");
+                               cipher.append(gnutls_mac_get_name(gnutls_mac_get(sessions[user->GetFd()].sess)));
+                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick, cipher.c_str());
+                       }
                }
        }
 
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
+               if (eh)
+                       ServerInstance->SE->WantWrite(eh);
+       }
+
+       virtual void OnBufferFlushed(User* user)
+       {
+               if (user->GetExt("ssl"))
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
 
        void CloseSession(issl_session* session)
@@ -652,6 +778,9 @@ class ModuleSSLGnuTLS : public Module
 
        void VerifyCertificate(issl_session* session, Extensible* user)
        {
+               if (!session->sess || !user)
+                       return;
+
                unsigned int status;
                const gnutls_datum_t* cert_list;
                int ret;
@@ -774,27 +903,11 @@ class ModuleSSLGnuTLS : public Module
                return;
        }
 
-};
-
-class ModuleSSLGnuTLSFactory : public ModuleFactory
-{
- public:
-       ModuleSSLGnuTLSFactory()
-       {
-       }
-
-       ~ModuleSSLGnuTLSFactory()
+       void OnEvent(Event* ev)
        {
+               GenericCapHandler(ev, "tls", "tls");
        }
 
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSSLGnuTLS(Me);
-       }
 };
 
-
-extern "C" void * init_module( void )
-{
-       return new ModuleSSLGnuTLSFactory;
-}
+MODULE_INIT(ModuleSSLGnuTLS)