]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
Whos been commiting a quarter of a fix?
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 3398af91f1076ff9f2c48f2381b5a68a0690e9eb..0c9307ae4e8e525b66adde5e3f187f695180eaab 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <vector>
+#include "inspircd.h"
 
 #include <openssl/ssl.h>
 #include <openssl/err.h>
 
-#include "inspircd_config.h"
 #include "configreader.h"
 #include "users.h"
 #include "channels.h"
 
 #include "socket.h"
 #include "hashcomp.h"
-#include "inspircd.h"
 
 #include "transport.h"
 
+#ifdef WINDOWS
+#pragma comment(lib, "libeay32MTd")
+#pragma comment(lib, "ssleay32MTd")
+#undef MAX_DESCRIPTORS
+#define MAX_DESCRIPTORS 10000
+#endif
+
 /* $ModDesc: Provides SSL support for clients */
-/* $CompileFlags: pkgconfincludes("openssl","/openssl/ssl.h","") */
-/* $LinkerFlags: pkgconflibs("openssl","/libssl.so","-lssl -lcrypto") */
+
+/* $LinkerFlags: if("USE_FREEBSD_BASE_SSL") -lssl -lcrypto */
+/* $CompileFlags: if(!"USE_FREEBSD_BASE_SSL") pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
+/* $LinkerFlags: if(!"USE_FREEBSD_BASE_SSL") rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto -ldl") */
+
 /* $ModDep: transport.h */
+/* $NoPedantic */
+/* $CopyInstall: conf/key.pem $(CONPATH) */
+/* $CopyInstall: conf/cert.pem $(CONPATH) */
+
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
 enum issl_io_status { ISSL_WRITE, ISSL_READ };
 
 static bool SelfSigned = false;
 
-bool isin(int port, const std::vector<int> &portlist)
+bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
 {
-       for(unsigned int i = 0; i < portlist.size(); i++)
-               if(portlist[i] == port)
-                       return true;
-                       
-       return false;
+       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
+               return true;
+
+       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
+               return true;
+
+       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
 }
 
 char* get_error()
@@ -53,6 +66,8 @@ char* get_error()
        return ERR_error_string(ERR_get_error(), NULL);
 }
 
+static int error_callback(const char *str, size_t len, void *u);
+
 /** Represents an SSL user's extra data
  */
 class issl_session : public classbase
@@ -64,12 +79,14 @@ public:
        issl_io_status wstat;
 
        unsigned int inbufoffset;
-       char* inbuf;                    // Buffer OpenSSL reads into.
+       char* inbuf;                    // Buffer OpenSSL reads into.
        std::string outbuf;     // Buffer for outgoing data that OpenSSL will not take.
        int fd;
-       
+       bool outbound;
+
        issl_session()
        {
+               outbound = false;
                rstat = ISSL_READ;
                wstat = ISSL_WRITE;
        }
@@ -88,148 +105,177 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
        return 1;
 }
-       
+
 class ModuleSSLOpenSSL : public Module
 {
-       
-       ConfigReader* Conf;
-       
-       CullList* culllist;
-       
-       std::vector<int> listenports;
-       
+       std::vector<std::string> listenports;
+
        int inbufsize;
-       issl_session sessions[MAX_DESCRIPTORS];
-       
+       issl_session* sessions;
+
        SSL_CTX* ctx;
-       
+       SSL_CTX* clictx;
+
        char* dummy;
-       
+       char cipher[MAXBUF];
+
        std::string keyfile;
        std::string certfile;
        std::string cafile;
        // std::string crlfile;
        std::string dhfile;
-       
+       std::string sslports;
+
+       int clientactive;
+
  public:
-       
+
+       InspIRCd* PublicInstance;
+
        ModuleSSLOpenSSL(InspIRCd* Me)
-               : Module::Module(Me)
+       : Module(Me), PublicInstance(Me)
        {
-               culllist = new CullList(ServerInstance);
+               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
+
+               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
-               ServerInstance->PublishInterface("InspSocketHook", this);
-               
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
-               
+
                /* Global SSL library initialization*/
                SSL_library_init();
                SSL_load_error_strings();
-               
-               /* Build our SSL context*/
+
+               /* Build our SSL contexts:
+                * NOTE: OpenSSL makes us have two contexts, one for servers and one for clients. ICK.
+                */
                ctx = SSL_CTX_new( SSLv23_server_method() );
+               clictx = SSL_CTX_new( SSLv23_client_method() );
 
                SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
+               SSL_CTX_set_verify(clictx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 
                // Needs the flag as it ignores a plain /rehash
                OnRehash(NULL,"ssl");
+               Implementation eventlist[] = { I_OnRawSocketConnect, I_OnRawSocketAccept, I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup, I_On005Numeric,
+                       I_OnBufferFlushed, I_OnRequest, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUnloadModule, I_OnRehash, I_OnWhois, I_OnPostConnect, I_OnHookUserIO };
+               ServerInstance->Modules->Attach(eventlist, this, 16);
        }
-       
-       virtual void OnRehash(userrec* user, const std::string &param)
+
+       virtual void OnHookUserIO(User* user, const std::string &targetip)
        {
-               if (param != "ssl")
-                       return;
-       
-               Conf = new ConfigReader(ServerInstance);
-                       
-               for (unsigned int i = 0; i < listenports.size(); i++)
+               if (!user->io && isin(targetip,user->GetPort(), listenports))
                {
-                       ServerInstance->Config->DelIOHook(listenports[i]);
+                       /* Hook the user with our module */
+                       user->io = this;
                }
-               
+       }
+
+       virtual void OnRehash(User* user, const std::string &param)
+       {
+               ConfigReader Conf(ServerInstance);
+
                listenports.clear();
-               
-               for (int i = 0; i < Conf->Enumerate("bind"); i++)
+               clientactive = 0;
+               sslports.clear();
+
+               for(int index = 0; index < Conf.Enumerate("bind"); index++)
                {
                        // For each <bind> tag
-                       if (((Conf->ReadValue("bind", "type", i) == "") || (Conf->ReadValue("bind", "type", i) == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "openssl"))
+                       std::string x = Conf.ReadValue("bind", "type", index);
+                       if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
                        {
                                // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf->ReadValue("bind", "port", i);
+                               std::string port = Conf.ReadValue("bind", "port", index);
+                               std::string addr = Conf.ReadValue("bind", "address", index);
+
                                irc::portparser portrange(port, false);
                                long portno = -1;
                                while ((portno = portrange.GetToken()))
                                {
-                                       if (ServerInstance->Config->AddIOHook(portno, this))
+                                       clientactive++;
+                                       try
                                        {
-                                               listenports.push_back(portno);
-                                               for (unsigned int i = 0; i < ServerInstance->stats->BoundPortCount; i++)
-                                                       if (ServerInstance->Config->ports[i] == portno)
-                                                               ServerInstance->Config->openSockfd[i]->SetDescription("ssl");
-                                               ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %d", portno);
+                                               listenports.push_back(addr + ":" + ConvToStr(portno));
+
+                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
+                                                       if ((ServerInstance->Config->ports[i]->GetPort() == portno) && (ServerInstance->Config->ports[i]->GetIP() == addr))
+                                                               ServerInstance->Config->ports[i]->SetDescription("ssl");
+                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %ld", portno);
+
+                                               sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
                                        }
-                                       else
+                                       catch (ModuleException &e)
                                        {
-                                               ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?", portno);
+                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
                                        }
                                }
                        }
                }
-               
-               std::string confdir(CONFIG_FILE);
+
+               if (!sslports.empty())
+                       sslports.erase(sslports.end() - 1);
+
+               if (param != "ssl")
+               {
+                       return;
+               }
+
+               std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
                confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
-               
-               cafile   = Conf->ReadValue("openssl", "cafile", 0);
-               certfile = Conf->ReadValue("openssl", "certfile", 0);
-               keyfile  = Conf->ReadValue("openssl", "keyfile", 0);
-               dhfile   = Conf->ReadValue("openssl", "dhfile", 0);
-               
+
+               cafile   = Conf.ReadValue("openssl", "cafile", 0);
+               certfile = Conf.ReadValue("openssl", "certfile", 0);
+               keyfile  = Conf.ReadValue("openssl", "keyfile", 0);
+               dhfile   = Conf.ReadValue("openssl", "dhfile", 0);
+
                // Set all the default values needed.
-               if (cafile == "")
+               if (cafile.empty())
                        cafile = "ca.pem";
-                       
-               if (certfile == "")
+
+               if (certfile.empty())
                        certfile = "cert.pem";
-                       
-               if (keyfile == "")
+
+               if (keyfile.empty())
                        keyfile = "key.pem";
-                       
-               if (dhfile == "")
+
+               if (dhfile.empty())
                        dhfile = "dhparams.pem";
-                       
-               // Prepend relative paths with the path to the config directory.        
-               if (cafile[0] != '/')
+
+               // Prepend relative paths with the path to the config directory.
+               if ((cafile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(cafile)))
                        cafile = confdir + cafile;
-               
-               //if(crlfile[0] != '/')
-               //      crlfile = confdir + crlfile;
-                       
-               if (certfile[0] != '/')
+
+               if ((certfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(certfile)))
                        certfile = confdir + certfile;
-                       
-               if (keyfile[0] != '/')
+
+               if ((keyfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(keyfile)))
                        keyfile = confdir + keyfile;
-                       
-               if (dhfile[0] != '/')
+
+               if ((dhfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(dhfile)))
                        dhfile = confdir + dhfile;
 
-               /* Load our keys and certificates*/
-               if (!SSL_CTX_use_certificate_chain_file(ctx, certfile.c_str()))
+               /* Load our keys and certificates
+                * NOTE: OpenSSL's error logging API sucks, don't blame us for this clusterfuck.
+                */
+               if ((!SSL_CTX_use_certificate_chain_file(ctx, certfile.c_str())) || (!SSL_CTX_use_certificate_chain_file(clictx, certfile.c_str())))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s", certfile.c_str());
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s. %s", certfile.c_str(), strerror(errno));
+                       ERR_print_errors_cb(error_callback, this);
                }
 
-               if (!SSL_CTX_use_PrivateKey_file(ctx, keyfile.c_str(), SSL_FILETYPE_PEM))
+               if (((!SSL_CTX_use_PrivateKey_file(ctx, keyfile.c_str(), SSL_FILETYPE_PEM))) || (!SSL_CTX_use_PrivateKey_file(clictx, keyfile.c_str(), SSL_FILETYPE_PEM)))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read key file %s", keyfile.c_str());
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read key file %s. %s", keyfile.c_str(), strerror(errno));
+                       ERR_print_errors_cb(error_callback, this);
                }
 
                /* Load the CAs we trust*/
-               if (!SSL_CTX_load_verify_locations(ctx, cafile.c_str(), 0))
+               if (((!SSL_CTX_load_verify_locations(ctx, cafile.c_str(), 0))) || (!SSL_CTX_load_verify_locations(clictx, cafile.c_str(), 0)))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read CA list from ", cafile.c_str());
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. %s", cafile.c_str(), strerror(errno));
+                       ERR_print_errors_cb(error_callback, this);
                }
 
                FILE* dhpfile = fopen(dhfile.c_str(), "r");
@@ -237,97 +283,91 @@ class ModuleSSLOpenSSL : public Module
 
                if (dhpfile == NULL)
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so Couldn't open DH file %s: %s", dhfile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so Couldn't open DH file %s: %s", dhfile.c_str(), strerror(errno));
                        throw ModuleException("Couldn't open DH file " + dhfile + ": " + strerror(errno));
                }
                else
                {
                        ret = PEM_read_DHparams(dhpfile, NULL, NULL, NULL);
-               
-                       if(SSL_CTX_set_tmp_dh(ctx, ret) < 0)
+                       if ((SSL_CTX_set_tmp_dh(ctx, ret) < 0) || (SSL_CTX_set_tmp_dh(clictx, ret) < 0))
                        {
-                               ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters");
+                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
+                               ERR_print_errors_cb(error_callback, this);
                        }
                }
-               
+
                fclose(dhpfile);
+       }
 
-               DELETE(Conf);
+       virtual void On005Numeric(std::string &output)
+       {
+               output.append(" SSL=" + sslports);
        }
 
        virtual ~ModuleSSLOpenSSL()
        {
                SSL_CTX_free(ctx);
-               delete culllist;
+               SSL_CTX_free(clictx);
+               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
+               delete[] sessions;
        }
-       
+
        virtual void OnCleanup(int target_type, void* item)
        {
                if (target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
-                       
-                       if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && isin(user->GetPort(), listenports))
+                       User* user = (User*)item;
+
+                       if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && user->io == this)
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Adding user %s to cull list", user->nick);
-                               culllist->AddItem(user, "SSL module unloading");
+                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
                        }
-                       if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
+                       if (user->GetExt("ssl_cert", dummy))
                        {
                                ssl_cert* tofree;
                                user->GetExt("ssl_cert", tofree);
                                delete tofree;
                                user->Shrink("ssl_cert");
                        }
+
+                       user->io = NULL;
                }
        }
-       
+
        virtual void OnUnloadModule(Module* mod, const std::string &name)
        {
                if (mod == this)
                {
-                       // We're being unloaded, kill all the users added to the cull list in OnCleanup
-                       int numusers = culllist->Apply();
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Killed %d users for unload of OpenSSL SSL module", numusers);
-                       
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
-                               ServerInstance->Config->DelIOHook(listenports[i]);
-                               for (unsigned int j = 0; j < ServerInstance->stats->BoundPortCount; j++)
-                                       if (ServerInstance->Config->ports[j] == listenports[i])
-                                               if (ServerInstance->Config->openSockfd[j])
-                                                       ServerInstance->Config->openSockfd[j]->SetDescription("plaintext");
+                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
+                                       if (listenports[i] == (ServerInstance->Config->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->Config->ports[j]->GetPort())))
+                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
                        }
                }
        }
-       
+
        virtual Version GetVersion()
        {
-               return Version(1, 1, 0, 0, VF_VENDOR, API_VERSION);
+               return Version(1, 2, 0, 0, VF_VENDOR, API_VERSION);
        }
 
-       void Implements(char* List)
-       {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
-       }
 
-       virtual char* OnRequest(Request* request)
+       virtual const char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
-               ServerInstance->Log(DEBUG, "hook OnRequest");
                if (strcmp("IS_NAME", request->GetId()) == 0)
                {
                        return "openssl";
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       char* ret = "OK";
+                       const char* ret = "OK";
                        try
                        {
-                               ret = ServerInstance->Config->AddIOHook((Module*)this, (InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                               ret = ServerInstance->Config->AddIOHook((Module*)this, (BufferedSocket*)ISR->Sock) ? "OK" : NULL;
                        }
                        catch (ModuleException &e)
                        {
@@ -338,20 +378,22 @@ class ModuleSSLOpenSSL : public Module
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       ServerInstance->Log(DEBUG, "Unhooking socket %08x", ISR->Sock);
-                       return ServerInstance->Config->DelIOHook((InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                       return ServerInstance->Config->DelIOHook((BufferedSocket*)ISR->Sock) ? "OK" : NULL;
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
+                       if (ISR->Sock->GetFd() < 0)
+                               return "OK";
+
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       return (session->status == ISSL_HANDSHAKING) ? NULL : (char*)"OK";
+                       return (session->status == ISSL_HANDSHAKING) ? NULL : "OK";
                }
                else if (strcmp("IS_ATTACH", request->GetId()) == 0)
                {
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       if (session)
+                       if (session->sess)
                        {
-                               VerifyCertificate(session, (InspSocket*)ISR->Sock);
+                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                return "OK";
                        }
                }
@@ -361,24 +403,25 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
-               ServerInstance->Log(DEBUG, "Hook accept %d", fd);
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                issl_session* session = &sessions[fd];
-       
+
                session->fd = fd;
                session->inbuf = new char[inbufsize];
-               session->inbufoffset = 0;               
+               session->inbufoffset = 0;
                session->sess = SSL_new(ctx);
                session->status = ISSL_NONE;
-       
+               session->outbound = false;
+
                if (session->sess == NULL)
-               {
-                       ServerInstance->Log(DEBUG, "m_ssl.so: Couldn't create SSL object: %s", get_error());
                        return;
-               }
-               
+
                if (SSL_set_fd(session->sess, fd) == 0)
                {
-                       ServerInstance->Log(DEBUG, "m_ssl.so: Couldn't set fd for SSL object: %s", get_error());
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
                        return;
                }
 
@@ -387,23 +430,25 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketConnect(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
                session->inbuf = new char[inbufsize];
                session->inbufoffset = 0;
-               session->sess = SSL_new(ctx);
+               session->sess = SSL_new(clictx);
                session->status = ISSL_NONE;
+               session->outbound = true;
 
                if (session->sess == NULL)
-               {
-                       ServerInstance->Log(DEBUG, "m_ssl.so: Couldn't create SSL object: %s", get_error());
                        return;
-               }
 
                if (SSL_set_fd(session->sess, fd) == 0)
                {
-                       ServerInstance->Log(DEBUG, "m_ssl.so: Couldn't set fd for SSL object: %s", get_error());
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
                        return;
                }
 
@@ -412,7 +457,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
-               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketClose: %d", fd);
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -428,42 +476,39 @@ class ModuleSSLOpenSSL : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return 0;
+
                issl_session* session = &sessions[fd];
-               
+
                if (!session->sess)
                {
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketRead: No session to read from");
                        readresult = 0;
                        CloseSession(session);
                        return 1;
                }
-               
+
                if (session->status == ISSL_HANDSHAKING)
                {
                        if (session->rstat == ISSL_READ || session->wstat == ISSL_READ)
                        {
                                // The handshake isn't finished and it wants to read, try to finish it.
-                               if (Handshake(session))
+                               if (!Handshake(session))
                                {
-                                       // Handshake successfully resumed.
-                                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketRead: successfully resumed handshake");
-                               }
-                               else
-                               {
-                                       // Couldn't resume handshake.   
-                                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketRead: failed to resume handshake");
+                                       // Couldn't resume handshake.
                                        return -1;
                                }
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketRead: handshake wants to write data but we are currently reading");
-                               return -1;                      
+                               errno = EAGAIN;
+                               return -1;
                        }
                }
 
                // If we resumed the handshake then session->status will be ISSL_OPEN
-                               
+
                if (session->status == ISSL_OPEN)
                {
                        if (session->wstat == ISSL_READ)
@@ -471,18 +516,18 @@ class ModuleSSLOpenSSL : public Module
                                if(DoWrite(session) == 0)
                                        return 0;
                        }
-                       
+
                        if (session->rstat == ISSL_READ)
                        {
                                int ret = DoRead(session);
-                       
+
                                if (ret > 0)
                                {
                                        if (count <= session->inbufoffset)
                                        {
-                                               memcpy(buffer, session->inbuf, count);
+                                               memmove(buffer, session->inbuf, count);
                                                // Move the stuff left in inbuf to the beginning of it
-                                               memcpy(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
+                                               memmove(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
                                                // Now we need to set session->inbufoffset to the amount of data still waiting to be handed to insp.
                                                session->inbufoffset -= count;
                                                // Insp uses readresult as the count of how much data there is in buffer, so:
@@ -491,109 +536,91 @@ class ModuleSSLOpenSSL : public Module
                                        else
                                        {
                                                // There's not as much in the inbuf as there is space in the buffer, so just copy the whole thing.
-                                               memcpy(buffer, session->inbuf, session->inbufoffset);
-                                               
+                                               memmove(buffer, session->inbuf, session->inbufoffset);
+
                                                readresult = session->inbufoffset;
                                                // Zero the offset, as there's nothing there..
                                                session->inbufoffset = 0;
                                        }
-                               
                                        return 1;
                                }
-                               else
-                               {
-                                       return ret;
-                               }
+                               return ret;
                        }
                }
-               
+
                return -1;
        }
-       
+
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
-       {               
+       {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
                {
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketWrite: No session to write to");
                        CloseSession(session);
-                       return 1;
+                       return -1;
                }
 
                session->outbuf.append(buffer, count);
-               
+               MakePollWrite(session);
+
                if (session->status == ISSL_HANDSHAKING)
                {
                        // The handshake isn't finished, try to finish it.
                        if (session->rstat == ISSL_WRITE || session->wstat == ISSL_WRITE)
                        {
-                               if (Handshake(session))
-                               {
-                                       // Handshake successfully resumed.
-                                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketWrite: successfully resumed handshake");
-                               }
-                               else
-                               {
-                                       // Couldn't resume handshake.   
-                                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketWrite: failed to resume handshake"); 
-                               }
-                       }
-                       else
-                       {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: OnRawSocketWrite: handshake wants to read data but we are currently writing");                    
+                               Handshake(session);
                        }
                }
-               
+
                if (session->status == ISSL_OPEN)
                {
                        if (session->rstat == ISSL_WRITE)
                        {
                                DoRead(session);
                        }
-                       
+
                        if (session->wstat == ISSL_WRITE)
                        {
                                return DoWrite(session);
                        }
                }
-               
+
                return 1;
        }
-       
+
        int DoWrite(issl_session* session)
        {
                if (!session->outbuf.size())
                        return -1;
 
-               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: To write: %d", session->outbuf.size());
                int ret = SSL_write(session->sess, session->outbuf.data(), session->outbuf.size());
-               
+
                if (ret == 0)
                {
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoWrite: Client closed the connection");
                        CloseSession(session);
                        return 0;
                }
                else if (ret < 0)
                {
                        int err = SSL_get_error(session->sess, ret);
-                       
+
                        if (err == SSL_ERROR_WANT_WRITE)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoWrite: Not all SSL data written, need to retry: %s", get_error());
                                session->wstat = ISSL_WRITE;
                                return -1;
                        }
                        else if (err == SSL_ERROR_WANT_READ)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoWrite: Not all SSL data written but the damn thing wants to read instead: %s", get_error());
                                session->wstat = ISSL_READ;
                                return -1;
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoWrite: Error writing SSL data: %s", get_error());
                                CloseSession(session);
                                return 0;
                        }
@@ -604,40 +631,37 @@ class ModuleSSLOpenSSL : public Module
                        return ret;
                }
        }
-       
+
        int DoRead(issl_session* session)
        {
                // Is this right? Not sure if the unencrypted data is garaunteed to be the same length.
                // Read into the inbuffer, offset from the beginning by the amount of data we have that insp hasn't taken yet.
-                       
+
                int ret = SSL_read(session->sess, session->inbuf + session->inbufoffset, inbufsize - session->inbufoffset);
 
                if (ret == 0)
                {
                        // Client closed connection.
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoRead: Client closed the connection");
                        CloseSession(session);
                        return 0;
                }
                else if (ret < 0)
                {
                        int err = SSL_get_error(session->sess, ret);
-                               
+
                        if (err == SSL_ERROR_WANT_READ)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoRead: Not all SSL data read, need to retry: %s", get_error());
                                session->rstat = ISSL_READ;
                                return -1;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoRead: Not all SSL data read but the damn thing wants to write instead: %s", get_error());
                                session->rstat = ISSL_WRITE;
+                               MakePollWrite(session);
                                return -1;
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: DoRead: Error reading SSL data: %s", get_error());
                                CloseSession(session);
                                return 0;
                        }
@@ -653,18 +677,21 @@ class ModuleSSLOpenSSL : public Module
                        return ret;
                }
        }
-       
+
        // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(userrec* source, userrec* dest)
+       virtual void OnWhois(User* source, User* dest)
        {
+               if (!clientactive)
+                       return;
+
                // Bugfix, only send this numeric for *our* SSL users
-               if (dest->GetExt("ssl", dummy) || (IS_LOCAL(dest) &&  isin(dest->GetPort(), listenports)))
+               if (dest->GetExt("ssl", dummy) || ((IS_LOCAL(dest) && dest->io == this)))
                {
-                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick, dest->nick);
+                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick.c_str(), dest->nick.c_str());
                }
        }
-       
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname)
+
+       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
        {
                // check if the linking module wants to know about OUR metadata
                if (extname == "ssl")
@@ -674,17 +701,17 @@ class ModuleSSLOpenSSL : public Module
                        {
                                // call this function in the linking module, let it format the data how it
                                // sees fit, and send it on its way. We dont need or want to know how.
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, "ON");
+                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, displayable ? "Enabled" : "ON");
                        }
                }
        }
-       
+
        virtual void OnDecodeMetaData(int target_type, void* target, const std::string &extname, const std::string &extdata)
        {
                // check if its our metadata key, and its associated with a user
                if ((target_type == TYPE_USER) && (extname == "ssl"))
                {
-                       userrec* dest = (userrec*)target;
+                       User* dest = (User*)target;
                        // if they dont already have an ssl flag, accept the remote server's
                        if (!dest->GetExt(extname, dummy))
                        {
@@ -692,82 +719,101 @@ class ModuleSSLOpenSSL : public Module
                        }
                }
        }
-       
+
        bool Handshake(issl_session* session)
-       {               
-               int ret = SSL_accept(session->sess);
-      
+       {
+               int ret;
+
+               if (session->outbound)
+                       ret = SSL_connect(session->sess);
+               else
+                       ret = SSL_accept(session->sess);
+
                if (ret < 0)
                {
                        int err = SSL_get_error(session->sess, ret);
-                               
+
                        if (err == SSL_ERROR_WANT_READ)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Handshake: Not completed, need to read again: %s", get_error());
                                session->rstat = ISSL_READ;
                                session->status = ISSL_HANDSHAKING;
+                               return true;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Handshake: Not completed, need to write more data: %s", get_error());
                                session->wstat = ISSL_WRITE;
                                session->status = ISSL_HANDSHAKING;
                                MakePollWrite(session);
+                               return true;
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Handshake: Failed, bailing: %s", get_error());
                                CloseSession(session);
                        }
 
                        return false;
                }
-               else
+               else if (ret > 0)
                {
                        // Handshake complete.
-                       ServerInstance->Log(DEBUG, "m_ssl_openssl.so: Handshake completed");
-                       
                        // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       userrec* u = ServerInstance->FindDescriptor(session->fd);
+                       User* u = ServerInstance->FindDescriptor(session->fd);
                        if (u)
                        {
                                if (!u->GetExt("ssl", dummy))
                                        u->Extend("ssl", "ON");
                        }
-                       
+
                        session->status = ISSL_OPEN;
-                       
+
                        MakePollWrite(session);
-                       
+
+                       return true;
+               }
+               else if (ret == 0)
+               {
+                       CloseSession(session);
                        return true;
                }
+
+               return true;
        }
-       
-       virtual void OnPostConnect(userrec* user)
+
+       virtual void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
+               // protocol module has propagated the NICK message.
                if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
-                       std::deque<std::string>* metadata = new std::deque<std::string>;
-                       metadata->push_back(user->nick);
-                       metadata->push_back("ssl");             // The metadata id
-                       metadata->push_back("ON");              // The value to send
-                       Event* event = new Event((char*)metadata,(Module*)this,"send_metadata");
-                       event->Send(ServerInstance);            // Trigger the event. We don't care what module picks it up.
-                       DELETE(event);
-                       DELETE(metadata);
+                       ServerInstance->PI->SendMetaData(user, TYPE_USER, "SSL", "on");
 
                        VerifyCertificate(&sessions[user->GetFd()], user);
+                       if (sessions[user->GetFd()].sess)
+                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->GetFd()].sess));
                }
        }
-       
+
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
+               if (eh)
+               {
+                       ServerInstance->SE->WantWrite(eh);
+               }
+       }
+
+       virtual void OnBufferFlushed(User* user)
+       {
+               if (user->GetExt("ssl"))
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
-       
+
        void CloseSession(issl_session* session)
        {
                if (session->sess)
@@ -775,12 +821,12 @@ class ModuleSSLOpenSSL : public Module
                        SSL_shutdown(session->sess);
                        SSL_free(session->sess);
                }
-               
+
                if (session->inbuf)
                {
                        delete[] session->inbuf;
                }
-               
+
                session->outbuf.clear();
                session->inbuf = NULL;
                session->sess = NULL;
@@ -789,6 +835,9 @@ class ModuleSSLOpenSSL : public Module
 
        void VerifyCertificate(issl_session* session, Extensible* user)
        {
+               if (!session->sess || !user)
+                       return;
+
                X509* cert;
                ssl_cert* certinfo = new ssl_cert;
                unsigned int n;
@@ -837,27 +886,30 @@ class ModuleSSLOpenSSL : public Module
 
                X509_free(cert);
        }
-};
 
-class ModuleSSLOpenSSLFactory : public ModuleFactory
-{
- public:
-       ModuleSSLOpenSSLFactory()
-       {
-       }
-       
-       ~ModuleSSLOpenSSLFactory()
+       void Prioritize()
        {
+               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
+               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIO_AFTER, &server);
        }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleSSLOpenSSL(Me);
-       }
-};
 
+};
 
-extern "C" void * init_module( void )
+static int error_callback(const char *str, size_t len, void *u)
 {
-       return new ModuleSSLOpenSSLFactory;
+       ModuleSSLOpenSSL* mssl = (ModuleSSLOpenSSL*)u;
+       mssl->PublicInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
+
+       //
+       // XXX: Remove this line, it causes valgrind warnings...
+       //
+       // MD_update(&m, buf, j);
+       //
+       //
+       // ... ONLY JOKING! :-)
+       //
+
+       return 0;
 }
+
+MODULE_INIT(ModuleSSLOpenSSL)