]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
Some more text fixes and improvements (#1618).
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 6e40f97f060a5e564c411b51c7eaa182ae09354d..3ebc8e4d91685b258e9961220790ad3c2a0f7ef4 100644 (file)
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/// $CompilerFlags: find_compiler_flags("openssl")
+/// $LinkerFlags: find_linker_flags("openssl" "-lssl -lcrypto")
+
+/// $PackageInfo: require_system("centos") openssl-devel pkgconfig
+/// $PackageInfo: require_system("darwin") openssl pkg-config
+/// $PackageInfo: require_system("debian") libssl-dev openssl pkg-config
+/// $PackageInfo: require_system("ubuntu") libssl-dev openssl pkg-config
+
 
 #include "inspircd.h"
 #include "iohook.h"
 
 #include <openssl/ssl.h>
 #include <openssl/err.h>
+#include <openssl/dh.h>
 
 #ifdef _WIN32
 # pragma comment(lib, "ssleay32.lib")
 # pragma comment(lib, "libeay32.lib")
 #endif
 
-/* $CompileFlags: pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
-/* $LinkerFlags: rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto") */
+// Compatibility layer to allow OpenSSL 1.0 to use the 1.1 API.
+#if ((defined LIBRESSL_VERSION_NUMBER) || (OPENSSL_VERSION_NUMBER < 0x10100000L))
+
+// BIO is opaque in OpenSSL 1.1 but the access API does not exist in 1.0.
+# define BIO_get_data(BIO) BIO->ptr
+# define BIO_set_data(BIO, VALUE) BIO->ptr = VALUE;
+# define BIO_set_init(BIO, VALUE) BIO->init = VALUE;
+
+// These functions have been renamed in OpenSSL 1.1.
+# define OpenSSL_version SSLeay_version
+# define X509_getm_notAfter X509_get_notAfter
+# define X509_getm_notBefore X509_get_notBefore
+# define OPENSSL_init_ssl(OPTIONS, SETTINGS) \
+       SSL_library_init(); \
+       SSL_load_error_strings();
+
+// These macros have been renamed in OpenSSL 1.1.
+# define OPENSSL_VERSION SSLEAY_VERSION
+
+#else
+# define INSPIRCD_OPENSSL_OPAQUE_BIO
+#endif
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
 
@@ -111,7 +140,7 @@ namespace OpenSSL
                {
                        // Sane default options for OpenSSL see https://www.openssl.org/docs/ssl/SSL_CTX_set_options.html
                        // and when choosing a cipher, use the server's preferences instead of the client preferences.
-                       long opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SESSION_RESUMPTION_ON_RENEGOTIATION | SSL_OP_CIPHER_SERVER_PREFERENCE | SSL_OP_SINGLE_DH_USE;
+                       long opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_SESSION_RESUMPTION_ON_RENEGOTIATION | SSL_OP_CIPHER_SERVER_PREFERENCE | SSL_OP_SINGLE_DH_USE;
                        // Only turn options on if they exist
 #ifdef SSL_OP_SINGLE_ECDH_USE
                        opts |= SSL_OP_SINGLE_ECDH_USE;
@@ -121,8 +150,13 @@ namespace OpenSSL
 #endif
 
                        ctx_options = SSL_CTX_set_options(ctx, opts);
-                       SSL_CTX_set_mode(ctx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
-                       SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
+
+                       long mode = SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER;
+#ifdef SSL_MODE_RELEASE_BUFFERS
+                       mode |= SSL_MODE_RELEASE_BUFFERS;
+#endif
+                       SSL_CTX_set_mode(ctx, mode);
+                       SSL_CTX_set_verify(ctx, SSL_VERIFY_NONE, NULL);
                        SSL_CTX_set_session_cache_mode(ctx, SSL_SESS_CACHE_OFF);
                        SSL_CTX_set_info_callback(ctx, StaticSSLInfoCallback);
                }
@@ -138,7 +172,7 @@ namespace OpenSSL
                        return (SSL_CTX_set_tmp_dh(ctx, dh.get()) >= 0);
                }
 
-#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
+#ifndef OPENSSL_NO_ECDH
                void SetECDH(const std::string& curvename)
                {
                        int nid = OBJ_sn2nid(curvename.c_str());
@@ -181,6 +215,45 @@ namespace OpenSSL
                        return SSL_CTX_load_verify_locations(ctx, filename.c_str(), 0);
                }
 
+               void SetCRL(const std::string& crlfile, const std::string& crlpath, const std::string& crlmode)
+               {
+                       if (crlfile.empty() && crlpath.empty())
+                               return;
+
+                       /* Set CRL mode */
+                       unsigned long crlflags = X509_V_FLAG_CRL_CHECK;
+                       if (stdalgo::string::equalsci(crlmode, "chain"))
+                       {
+                               crlflags |= X509_V_FLAG_CRL_CHECK_ALL;
+                       }
+                       else if (!stdalgo::string::equalsci(crlmode, "leaf"))
+                       {
+                               throw ModuleException("Unknown mode '" + crlmode + "'; expected either 'chain' (default) or 'leaf'");
+                       }
+
+                       /* Load CRL files */
+                       X509_STORE* store = SSL_CTX_get_cert_store(ctx);
+                       if (!store)
+                       {
+                               throw ModuleException("Unable to get X509_STORE from SSL context; this should never happen");
+                       }
+                       ERR_clear_error();
+                       if (!X509_STORE_load_locations(store,
+                               crlfile.empty() ? NULL : crlfile.c_str(),
+                               crlpath.empty() ? NULL : crlpath.c_str()))
+                       {
+                               int err = ERR_get_error();
+                               throw ModuleException("Unable to load CRL file '" + crlfile + "' or CRL path '" + crlpath + "': '" + (err ? ERR_error_string(err, NULL) : "unknown") + "'");
+                       }
+
+                       /* Set CRL mode */
+                       if (X509_STORE_set_flags(store, crlflags) != 1)
+                       {
+                               throw ModuleException("Unable to set X509 CRL flags");
+                       }
+               }
+
+
                long GetDefaultContextOptions() const
                {
                        return ctx_options;
@@ -196,6 +269,11 @@ namespace OpenSSL
                        return SSL_CTX_clear_options(ctx, clearoptions);
                }
 
+               void SetVerifyCert()
+               {
+                       SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
+               }
+
                SSL* CreateServerSession()
                {
                        SSL* sess = SSL_new(ctx);
@@ -211,7 +289,7 @@ namespace OpenSSL
                }
        };
 
-       class Profile : public refcountbase
+       class Profile
        {
                /** Name of this profile
                 */
@@ -256,15 +334,14 @@ namespace OpenSSL
                 */
                void SetContextOptions(const std::string& ctxname, ConfigTag* tag, Context& context)
                {
-                       long setoptions = tag->getInt(ctxname + "setoptions");
-                       long clearoptions = tag->getInt(ctxname + "clearoptions");
+                       long setoptions = tag->getInt(ctxname + "setoptions", 0);
+                       long clearoptions = tag->getInt(ctxname + "clearoptions", 0);
 #ifdef SSL_OP_NO_COMPRESSION
-                       if (!tag->getBool("compression", true))
+                       if (!tag->getBool("compression", false)) // Disable compression by default
                                setoptions |= SSL_OP_NO_COMPRESSION;
 #endif
-                       if (!tag->getBool("sslv3", true))
-                               setoptions |= SSL_OP_NO_SSLv3;
-                       if (!tag->getBool("tlsv1", true))
+                       // Disable TLSv1.0 by default.
+                       if (!tag->getBool("tlsv1", false))
                                setoptions |= SSL_OP_NO_TLSv1;
 
                        if (!setoptions && !clearoptions)
@@ -278,11 +355,11 @@ namespace OpenSSL
         public:
                Profile(const std::string& profilename, ConfigTag* tag)
                        : name(profilename)
-                       , dh(ServerInstance->Config->Paths.PrependConfig(tag->getString("dhfile", "dh.pem")))
+                       , dh(ServerInstance->Config->Paths.PrependConfig(tag->getString("dhfile", "dhparams.pem")))
                        , ctx(SSL_CTX_new(SSLv23_server_method()))
                        , clictx(SSL_CTX_new(SSLv23_client_method()))
                        , allowrenego(tag->getBool("renegotiation")) // Disallow by default
-                       , outrecsize(tag->getInt("outrecsize", 2048, 512, 16384))
+                       , outrecsize(tag->getUInt("outrecsize", 2048, 512, 16384))
                {
                        if ((!ctx.SetDH(dh)) || (!clictx.SetDH(dh)))
                                throw Exception("Couldn't set DH parameters");
@@ -302,7 +379,7 @@ namespace OpenSSL
                                }
                        }
 
-#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
+#ifndef OPENSSL_NO_ECDH
                        std::string curvename = tag->getString("ecdhcurve", "prime256v1");
                        if (!curvename.empty())
                                ctx.SetECDH(curvename);
@@ -335,6 +412,16 @@ namespace OpenSSL
                                ERR_print_errors_cb(error_callback, this);
                                ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Can't read CA list from %s. This is only a problem if you want to verify client certificates, otherwise it's safe to ignore this message. Error: %s", filename.c_str(), lasterr.c_str());
                        }
+
+                       // Load the CRLs.
+                       std::string crlfile  = tag->getString("crlfile");
+                       std::string crlpath  = tag->getString("crlpath");
+                       std::string crlmode  = tag->getString("crlmode", "chain");
+                       ctx.SetCRL(crlfile, crlpath, crlmode);
+
+                       clictx.SetVerifyCert();
+                       if (tag->getBool("requestclientcert", true))
+                               ctx.SetVerifyCert();
                }
 
                const std::string& GetName() const { return name; }
@@ -344,8 +431,68 @@ namespace OpenSSL
                bool AllowRenegotiation() const { return allowrenego; }
                unsigned int GetOutgoingRecordSize() const { return outrecsize; }
        };
+
+       namespace BIOMethod
+       {
+               static int create(BIO* bio)
+               {
+                       BIO_set_init(bio, 1);
+                       return 1;
+               }
+
+               static int destroy(BIO* bio)
+               {
+                       // XXX: Dummy function to avoid a memory leak in OpenSSL.
+                       // The memory leak happens in BIO_free() (bio_lib.c) when the destroy func of the BIO is NULL.
+                       // This is fixed in OpenSSL but some distros still ship the unpatched version hence we provide this workaround.
+                       return 1;
+               }
+
+               static long ctrl(BIO* bio, int cmd, long num, void* ptr)
+               {
+                       if (cmd == BIO_CTRL_FLUSH)
+                               return 1;
+                       return 0;
+               }
+
+               static int read(BIO* bio, char* buf, int len);
+               static int write(BIO* bio, const char* buf, int len);
+
+#ifdef INSPIRCD_OPENSSL_OPAQUE_BIO
+               static BIO_METHOD* alloc()
+               {
+                       BIO_METHOD* meth = BIO_meth_new(100 | BIO_TYPE_SOURCE_SINK, "inspircd");
+                       BIO_meth_set_write(meth, OpenSSL::BIOMethod::write);
+                       BIO_meth_set_read(meth, OpenSSL::BIOMethod::read);
+                       BIO_meth_set_ctrl(meth, OpenSSL::BIOMethod::ctrl);
+                       BIO_meth_set_create(meth, OpenSSL::BIOMethod::create);
+                       BIO_meth_set_destroy(meth, OpenSSL::BIOMethod::destroy);
+                       return meth;
+               }
+#endif
+       }
 }
 
+// BIO_METHOD is opaque in OpenSSL 1.1 so we can't do this.
+// See OpenSSL::BIOMethod::alloc for the new method.
+#ifndef INSPIRCD_OPENSSL_OPAQUE_BIO
+static BIO_METHOD biomethods =
+{
+       (100 | BIO_TYPE_SOURCE_SINK),
+       "inspircd",
+       OpenSSL::BIOMethod::write,
+       OpenSSL::BIOMethod::read,
+       NULL, // puts
+       NULL, // gets
+       OpenSSL::BIOMethod::ctrl,
+       OpenSSL::BIOMethod::create,
+       OpenSSL::BIOMethod::destroy, // destroy, does nothing, see function body for more info
+       NULL // callback_ctrl
+};
+#else
+static BIO_METHOD* biomethods;
+#endif
+
 static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 {
        /* XXX: This will allow self signed certificates.
@@ -366,7 +513,6 @@ class OpenSSLIOHook : public SSLIOHook
        SSL* sess;
        issl_status status;
        bool data_to_write;
-       reference<OpenSSL::Profile> profile;
 
        // Returns 1 if handshake succeeded, 0 if it is still in progress, -1 if it failed
        int Handshake(StreamSocket* user)
@@ -466,7 +612,7 @@ class OpenSSLIOHook : public SSLIOHook
                if (certinfo->issuer.find_first_of("\r\n") != std::string::npos)
                        certinfo->issuer.clear();
 
-               if (!X509_digest(cert, profile->GetDigest(), md, &n))
+               if (!X509_digest(cert, GetProfile().GetDigest(), md, &n))
                {
                        certinfo->error = "Out of memory generating fingerprint";
                }
@@ -475,7 +621,7 @@ class OpenSSLIOHook : public SSLIOHook
                        certinfo->fingerprint = BinToHex(md, n);
                }
 
-               if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
+               if ((ASN1_UTCTIME_cmp_time_t(X509_getm_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_getm_notBefore(cert), ServerInstance->Time()) == 0))
                {
                        certinfo->error = "Not activated, or expired certificate";
                }
@@ -487,13 +633,15 @@ class OpenSSLIOHook : public SSLIOHook
        {
                if ((where & SSL_CB_HANDSHAKE_START) && (status == ISSL_OPEN))
                {
-                       if (profile->AllowRenegotiation())
+                       if (GetProfile().AllowRenegotiation())
                                return;
 
                        // The other side is trying to renegotiate, kill the connection and change status
                        // to ISSL_NONE so CheckRenego() closes the session
                        status = ISSL_NONE;
-                       SocketEngine::Shutdown(SSL_get_fd(sess), 2);
+                       BIO* bio = SSL_get_rbio(sess);
+                       EventHandler* eh = static_cast<StreamSocket*>(BIO_get_data(bio));
+                       SocketEngine::Shutdown(eh, 2);
                }
        }
 
@@ -527,17 +675,20 @@ class OpenSSLIOHook : public SSLIOHook
        friend void StaticSSLInfoCallback(const SSL* ssl, int where, int rc);
 
  public:
-       OpenSSLIOHook(IOHookProvider* hookprov, StreamSocket* sock, SSL* session, const reference<OpenSSL::Profile>& sslprofile)
+       OpenSSLIOHook(IOHookProvider* hookprov, StreamSocket* sock, SSL* session)
                : SSLIOHook(hookprov)
                , sess(session)
                , status(ISSL_NONE)
                , data_to_write(false)
-               , profile(sslprofile)
        {
-               if (sess == NULL)
-                       return;
-               if (SSL_set_fd(sess, sock->GetFd()) == 0)
-                       throw ModuleException("Can't set fd with SSL_set_fd: " + ConvToStr(sock->GetFd()));
+               // Create BIO instance and store a pointer to the socket in it which will be used by the read and write functions
+#ifdef INSPIRCD_OPENSSL_OPAQUE_BIO
+               BIO* bio = BIO_new(biomethods);
+#else
+               BIO* bio = BIO_new(&biomethods);
+#endif
+               BIO_set_data(bio, sock);
+               SSL_set_bio(sess, bio, bio);
 
                SSL_set_ex_data(sess, exdataindex, this);
                sock->AddIOHook(this);
@@ -569,8 +720,14 @@ class OpenSSLIOHook : public SSLIOHook
                        if (ret > 0)
                        {
                                recvq.append(buffer, ret);
+                               int mask = 0;
+                               // Schedule a read if there is still data in the OpenSSL buffer
+                               if (SSL_pending(sess) > 0)
+                                       mask |= FD_ADD_TRIAL_READ;
                                if (data_to_write)
-                                       SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_SINGLE_WRITE);
+                                       mask |= FD_WANT_POLL_READ | FD_WANT_SINGLE_WRITE;
+                               if (mask != 0)
+                                       SocketEngine::ChangeEventMask(user, mask);
                                return 1;
                        }
                        else if (ret == 0)
@@ -603,7 +760,7 @@ class OpenSSLIOHook : public SSLIOHook
                }
        }
 
-       int OnStreamSocketWrite(StreamSocket* user) CXX11_OVERRIDE
+       int OnStreamSocketWrite(StreamSocket* user, StreamSocket::SendQueue& sendq) CXX11_OVERRIDE
        {
                // Finish handshake if needed
                int prepret = PrepareIO(user);
@@ -613,11 +770,10 @@ class OpenSSLIOHook : public SSLIOHook
                data_to_write = true;
 
                // Session is ready for transferring application data
-               StreamSocket::SendQueue& sendq = user->GetSendQ();
                while (!sendq.empty())
                {
                        ERR_clear_error();
-                       FlattenSendQueue(sendq, profile->GetOutgoingRecordSize());
+                       FlattenSendQueue(sendq, GetProfile().GetOutgoingRecordSize());
                        const StreamSocket::SendQueue::Element& buffer = sendq.front();
                        int ret = SSL_write(sess, buffer.data(), buffer.size());
 
@@ -667,28 +823,26 @@ class OpenSSLIOHook : public SSLIOHook
                return 1;
        }
 
-       void TellCiphersAndFingerprint(LocalUser* user)
+       void GetCiphersuite(std::string& out) const CXX11_OVERRIDE
        {
-               if (sess)
-               {
-                       std::string text = "*** You are connected using SSL cipher '";
-                       GetCiphersuite(text);
-                       text += '\'';
-                       const std::string& fingerprint = certificate->fingerprint;
-                       if (!fingerprint.empty())
-                               text += " and your SSL certificate fingerprint is " + fingerprint;
-
-                       user->WriteNotice(text);
-               }
+               if (!IsHandshakeDone())
+                       return;
+               out.append(SSL_get_version(sess)).push_back('-');
+               out.append(SSL_get_cipher(sess));
        }
 
-       void GetCiphersuite(std::string& out) const
+       bool GetServerName(std::string& out) const CXX11_OVERRIDE
        {
-               out.append(SSL_get_version(sess)).push_back('-');
-               out.append(SSL_get_cipher(sess));
+               const char* name = SSL_get_servername(sess, TLSEXT_NAMETYPE_host_name);
+               if (!name)
+                       return false;
+
+               out.append(name);
+               return true;
        }
 
        bool IsHandshakeDone() const { return (status == ISSL_OPEN); }
+       OpenSSL::Profile& GetProfile();
 };
 
 static void StaticSSLInfoCallback(const SSL* ssl, int where, int rc)
@@ -697,14 +851,60 @@ static void StaticSSLInfoCallback(const SSL* ssl, int where, int rc)
        hook->SSLInfoCallback(where, rc);
 }
 
-class OpenSSLIOHookProvider : public refcountbase, public IOHookProvider
+static int OpenSSL::BIOMethod::write(BIO* bio, const char* buffer, int size)
+{
+       BIO_clear_retry_flags(bio);
+
+       StreamSocket* sock = static_cast<StreamSocket*>(BIO_get_data(bio));
+       if (sock->GetEventMask() & FD_WRITE_WILL_BLOCK)
+       {
+               // Writes blocked earlier, don't retry syscall
+               BIO_set_retry_write(bio);
+               return -1;
+       }
+
+       int ret = SocketEngine::Send(sock, buffer, size, 0);
+       if ((ret < size) && ((ret > 0) || (SocketEngine::IgnoreError())))
+       {
+               // Blocked, set retry flag for OpenSSL
+               SocketEngine::ChangeEventMask(sock, FD_WRITE_WILL_BLOCK);
+               BIO_set_retry_write(bio);
+       }
+
+       return ret;
+}
+
+static int OpenSSL::BIOMethod::read(BIO* bio, char* buffer, int size)
 {
-       reference<OpenSSL::Profile> profile;
+       BIO_clear_retry_flags(bio);
+
+       StreamSocket* sock = static_cast<StreamSocket*>(BIO_get_data(bio));
+       if (sock->GetEventMask() & FD_READ_WILL_BLOCK)
+       {
+               // Reads blocked earlier, don't retry syscall
+               BIO_set_retry_read(bio);
+               return -1;
+       }
+
+       int ret = SocketEngine::Recv(sock, buffer, size, 0);
+       if ((ret < size) && ((ret > 0) || (SocketEngine::IgnoreError())))
+       {
+               // Blocked, set retry flag for OpenSSL
+               SocketEngine::ChangeEventMask(sock, FD_READ_WILL_BLOCK);
+               BIO_set_retry_read(bio);
+       }
+
+       return ret;
+}
+
+class OpenSSLIOHookProvider : public IOHookProvider
+{
+       OpenSSL::Profile profile;
 
  public:
-       OpenSSLIOHookProvider(Module* mod, reference<OpenSSL::Profile>& prof)
-               : IOHookProvider(mod, "ssl/" + prof->GetName(), IOHookProvider::IOH_SSL)
-               , profile(prof)
+       OpenSSLIOHookProvider(Module* mod, const std::string& profilename, ConfigTag* tag)
+               : IOHookProvider(mod, "ssl/" + profilename, IOHookProvider::IOH_SSL)
+               , profile(profilename, tag)
        {
                ServerInstance->Modules->AddService(*this);
        }
@@ -716,15 +916,23 @@ class OpenSSLIOHookProvider : public refcountbase, public IOHookProvider
 
        void OnAccept(StreamSocket* sock, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server) CXX11_OVERRIDE
        {
-               new OpenSSLIOHook(this, sock, profile->CreateServerSession(), profile);
+               new OpenSSLIOHook(this, sock, profile.CreateServerSession());
        }
 
        void OnConnect(StreamSocket* sock) CXX11_OVERRIDE
        {
-               new OpenSSLIOHook(this, sock, profile->CreateClientSession(), profile);
+               new OpenSSLIOHook(this, sock, profile.CreateClientSession());
        }
+
+       OpenSSL::Profile& GetProfile() { return profile; }
 };
 
+OpenSSL::Profile& OpenSSLIOHook::GetProfile()
+{
+       IOHookProvider* hookprov = prov;
+       return static_cast<OpenSSLIOHookProvider*>(hookprov)->GetProfile();
+}
+
 class ModuleSSLOpenSSL : public Module
 {
        typedef std::vector<reference<OpenSSLIOHookProvider> > ProfileList;
@@ -744,8 +952,7 @@ class ModuleSSLOpenSSL : public Module
 
                        try
                        {
-                               reference<OpenSSL::Profile> profile(new OpenSSL::Profile(defname, tag));
-                               newprofiles.push_back(new OpenSSLIOHookProvider(this, profile));
+                               newprofiles.push_back(new OpenSSLIOHookProvider(this, defname, tag));
                        }
                        catch (OpenSSL::Exception& ex)
                        {
@@ -756,7 +963,7 @@ class ModuleSSLOpenSSL : public Module
                for (ConfigIter i = tags.first; i != tags.second; ++i)
                {
                        ConfigTag* tag = i->second;
-                       if (tag->getString("provider") != "openssl")
+                       if (!stdalgo::string::equalsci(tag->getString("provider"), "openssl"))
                                continue;
 
                        std::string name = tag->getString("name");
@@ -766,17 +973,23 @@ class ModuleSSLOpenSSL : public Module
                                continue;
                        }
 
-                       reference<OpenSSL::Profile> profile;
+                       reference<OpenSSLIOHookProvider> prov;
                        try
                        {
-                               profile = new OpenSSL::Profile(name, tag);
+                               prov = new OpenSSLIOHookProvider(this, name, tag);
                        }
                        catch (CoreException& ex)
                        {
                                throw ModuleException("Error while initializing SSL profile \"" + name + "\" at " + tag->getTagLocation() + " - " + ex.GetReason());
                        }
 
-                       newprofiles.push_back(new OpenSSLIOHookProvider(this, profile));
+                       newprofiles.push_back(prov);
+               }
+
+               for (ProfileList::iterator i = profiles.begin(); i != profiles.end(); ++i)
+               {
+                       OpenSSLIOHookProvider& prov = **i;
+                       ServerInstance->Modules.DelService(prov);
                }
 
                profiles.swap(newprofiles);
@@ -786,13 +999,20 @@ class ModuleSSLOpenSSL : public Module
        ModuleSSLOpenSSL()
        {
                // Initialize OpenSSL
-               SSL_library_init();
-               SSL_load_error_strings();
+               OPENSSL_init_ssl(0, NULL);
+#ifdef INSPIRCD_OPENSSL_OPAQUE_BIO
+               biomethods = OpenSSL::BIOMethod::alloc();
+       }
+
+       ~ModuleSSLOpenSSL()
+       {
+               BIO_meth_free(biomethods);
+#endif
        }
 
        void init() CXX11_OVERRIDE
        {
-               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "OpenSSL lib version \"%s\" module was compiled for \"" OPENSSL_VERSION_TEXT "\"", SSLeay_version(SSLEAY_VERSION));
+               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "OpenSSL lib version \"%s\" module was compiled for \"" OPENSSL_VERSION_TEXT "\"", OpenSSL_version(OPENSSL_VERSION));
 
                // Register application specific data
                char exdatastr[] = "inspircd";
@@ -818,20 +1038,13 @@ class ModuleSSLOpenSSL : public Module
                }
        }
 
-       void OnUserConnect(LocalUser* user) CXX11_OVERRIDE
+       void OnCleanup(ExtensionItem::ExtensibleType type, Extensible* item) CXX11_OVERRIDE
        {
-               IOHook* hook = user->eh.GetIOHook();
-               if (hook && hook->prov->creator == this)
-                       static_cast<OpenSSLIOHook*>(hook)->TellCiphersAndFingerprint(user);
-       }
-
-       void OnCleanup(int target_type, void* item) CXX11_OVERRIDE
-       {
-               if (target_type == TYPE_USER)
+               if (type == ExtensionItem::EXT_USER)
                {
                        LocalUser* user = IS_LOCAL((User*)item);
 
-                       if (user && user->eh.GetIOHook() && user->eh.GetIOHook()->prov->creator == this)
+                       if ((user) && (user->eh.GetModHook(this)))
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
@@ -842,19 +1055,15 @@ class ModuleSSLOpenSSL : public Module
 
        ModResult OnCheckReady(LocalUser* user) CXX11_OVERRIDE
        {
-               if ((user->eh.GetIOHook()) && (user->eh.GetIOHook()->prov->creator == this))
-               {
-                       OpenSSLIOHook* iohook = static_cast<OpenSSLIOHook*>(user->eh.GetIOHook());
-                       if (!iohook->IsHandshakeDone())
-                               return MOD_RES_DENY;
-               }
-
+               const OpenSSLIOHook* const iohook = static_cast<OpenSSLIOHook*>(user->eh.GetModHook(this));
+               if ((iohook) && (!iohook->IsHandshakeDone()))
+                       return MOD_RES_DENY;
                return MOD_RES_PASSTHRU;
        }
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Provides SSL support for clients", VF_VENDOR);
+               return Version("Provides SSL support via OpenSSL", VF_VENDOR);
        }
 };