]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
All of insp now builds with -pedantic (theres some warnings to squash in modules...
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 943d88843f3daf13d6f20271c0d25a78b4618967..5355e18557135f4b6b9f0a2899e02776f5dd6819 100644 (file)
@@ -74,7 +74,7 @@ public:
        issl_io_status wstat;
 
        unsigned int inbufoffset;
-       char* inbuf;                    // Buffer OpenSSL reads into.
+       char* inbuf;                    // Buffer OpenSSL reads into.
        std::string outbuf;     // Buffer for outgoing data that OpenSSL will not take.
        int fd;
        bool outbound;
@@ -103,9 +103,6 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
 class ModuleSSLOpenSSL : public Module
 {
-
-       ConfigReader* Conf;
-
        std::vector<int> listenports;
 
        int inbufsize;
@@ -122,6 +119,7 @@ class ModuleSSLOpenSSL : public Module
        std::string cafile;
        // std::string crlfile;
        std::string dhfile;
+       std::string sslports;
 
        int clientactive;
 
@@ -130,9 +128,9 @@ class ModuleSSLOpenSSL : public Module
        InspIRCd* PublicInstance;
 
        ModuleSSLOpenSSL(InspIRCd* Me)
-               : Module(Me), PublicInstance(Me)
+       : Module(Me), PublicInstance(Me)
        {
-               ServerInstance->PublishInterface("InspSocketHook", this);
+               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
@@ -154,12 +152,12 @@ class ModuleSSLOpenSSL : public Module
                OnRehash(NULL,"ssl");
        }
 
-       virtual void OnRehash(userrec* user, const std::string &param)
+       virtual void OnRehash(User* user, const std::string &param)
        {
                if (param != "ssl")
                        return;
 
-               Conf = new ConfigReader(ServerInstance);
+               ConfigReader Conf(ServerInstance);
 
                for (unsigned int i = 0; i < listenports.size(); i++)
                {
@@ -168,15 +166,16 @@ class ModuleSSLOpenSSL : public Module
 
                listenports.clear();
                clientactive = 0;
+               sslports.clear();
 
-               for (int i = 0; i < Conf->Enumerate("bind"); i++)
+               for (int i = 0; i < Conf.Enumerate("bind"); i++)
                {
                        // For each <bind> tag
-                       std::string x = Conf->ReadValue("bind", "type", i);
-                       if (((x.empty()) || (x == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "openssl"))
+                       std::string x = Conf.ReadValue("bind", "type", i);
+                       if (((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", i) == "openssl"))
                        {
                                // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf->ReadValue("bind", "port", i);
+                               std::string port = Conf.ReadValue("bind", "port", i);
                                irc::portparser portrange(port, false);
                                long portno = -1;
                                while ((portno = portrange.GetToken()))
@@ -191,6 +190,7 @@ class ModuleSSLOpenSSL : public Module
                                                                if (ServerInstance->Config->ports[i]->GetPort() == portno)
                                                                        ServerInstance->Config->ports[i]->SetDescription("ssl");
                                                        ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %d", portno);
+                                                       sslports.append("*:").append(ConvToStr(portno)).append(";");
                                                }
                                                else
                                                {
@@ -205,14 +205,17 @@ class ModuleSSLOpenSSL : public Module
                        }
                }
 
+               if (!sslports.empty())
+                       sslports.erase(sslports.end() - 1);
+
                std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
                confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
 
-               cafile   = Conf->ReadValue("openssl", "cafile", 0);
-               certfile = Conf->ReadValue("openssl", "certfile", 0);
-               keyfile  = Conf->ReadValue("openssl", "keyfile", 0);
-               dhfile   = Conf->ReadValue("openssl", "dhfile", 0);
+               cafile   = Conf.ReadValue("openssl", "cafile", 0);
+               certfile = Conf.ReadValue("openssl", "certfile", 0);
+               keyfile  = Conf.ReadValue("openssl", "keyfile", 0);
+               dhfile   = Conf.ReadValue("openssl", "dhfile", 0);
 
                // Set all the default values needed.
                if (cafile.empty())
@@ -281,8 +284,11 @@ class ModuleSSLOpenSSL : public Module
                }
 
                fclose(dhpfile);
+       }
 
-               DELETE(Conf);
+       virtual void On005Numeric(std::string &output)
+       {
+               output.append(" SSL=" + sslports);
        }
 
        virtual ~ModuleSSLOpenSSL()
@@ -295,13 +301,13 @@ class ModuleSSLOpenSSL : public Module
        {
                if (target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
+                       User* user = (User*)item;
 
                        if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && isin(user->GetPort(), listenports))
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->GlobalCulls.AddItem(user, "SSL module unloading");
+                               User::QuitUser(ServerInstance, user, "SSL module unloading");
                        }
                        if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
                        {
@@ -334,8 +340,8 @@ class ModuleSSLOpenSSL : public Module
 
        void Implements(char* List)
        {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
+               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = List[I_On005Numeric] = 1;
+               List[I_OnBufferFlushed] = List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
        }
 
        virtual char* OnRequest(Request* request)
@@ -350,7 +356,7 @@ class ModuleSSLOpenSSL : public Module
                        char* ret = "OK";
                        try
                        {
-                               ret = ServerInstance->Config->AddIOHook((Module*)this, (InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                               ret = ServerInstance->Config->AddIOHook((Module*)this, (BufferedSocket*)ISR->Sock) ? (char*)"OK" : NULL;
                        }
                        catch (ModuleException &e)
                        {
@@ -361,7 +367,7 @@ class ModuleSSLOpenSSL : public Module
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ServerInstance->Config->DelIOHook((InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                       return ServerInstance->Config->DelIOHook((BufferedSocket*)ISR->Sock) ? (char*)"OK" : NULL;
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
@@ -376,7 +382,7 @@ class ModuleSSLOpenSSL : public Module
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
                        if (session->sess)
                        {
-                               VerifyCertificate(session, (InspSocket*)ISR->Sock);
+                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                return "OK";
                        }
                }
@@ -386,6 +392,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -409,6 +419,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketConnect(int fd)
        {
+                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -432,6 +446,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -447,6 +465,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -469,6 +491,7 @@ class ModuleSSLOpenSSL : public Module
                        }
                        else
                        {
+                               errno = EAGAIN;
                                return -1;
                        }
                }
@@ -508,13 +531,9 @@ class ModuleSSLOpenSSL : public Module
                                                // Zero the offset, as there's nothing there..
                                                session->inbufoffset = 0;
                                        }
-
                                        return 1;
                                }
-                               else
-                               {
-                                       return ret;
-                               }
+                               return ret;
                        }
                }
 
@@ -523,6 +542,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -532,21 +555,28 @@ class ModuleSSLOpenSSL : public Module
                }
 
                session->outbuf.append(buffer, count);
+               MakePollWrite(session);
 
                if (session->status == ISSL_HANDSHAKING)
                {
                        // The handshake isn't finished, try to finish it.
                        if (session->rstat == ISSL_WRITE || session->wstat == ISSL_WRITE)
+                       {
                                Handshake(session);
+                       }
                }
 
                if (session->status == ISSL_OPEN)
                {
                        if (session->rstat == ISSL_WRITE)
+                       {
                                DoRead(session);
+                       }
 
                        if (session->wstat == ISSL_WRITE)
+                       {
                                return DoWrite(session);
+                       }
                }
 
                return 1;
@@ -595,7 +625,7 @@ class ModuleSSLOpenSSL : public Module
        {
                // Is this right? Not sure if the unencrypted data is garaunteed to be the same length.
                // Read into the inbuffer, offset from the beginning by the amount of data we have that insp hasn't taken yet.
-
+               
                int ret = SSL_read(session->sess, session->inbuf + session->inbufoffset, inbufsize - session->inbufoffset);
 
                if (ret == 0)
@@ -616,6 +646,7 @@ class ModuleSSLOpenSSL : public Module
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
                                session->rstat = ISSL_WRITE;
+                               MakePollWrite(session);
                                return -1;
                        }
                        else
@@ -637,7 +668,7 @@ class ModuleSSLOpenSSL : public Module
        }
 
        // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(userrec* source, userrec* dest)
+       virtual void OnWhois(User* source, User* dest)
        {
                if (!clientactive)
                        return;
@@ -649,7 +680,7 @@ class ModuleSSLOpenSSL : public Module
                }
        }
 
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
+       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
        {
                // check if the linking module wants to know about OUR metadata
                if (extname == "ssl")
@@ -669,7 +700,7 @@ class ModuleSSLOpenSSL : public Module
                // check if its our metadata key, and its associated with a user
                if ((target_type == TYPE_USER) && (extname == "ssl"))
                {
-                       userrec* dest = (userrec*)target;
+                       User* dest = (User*)target;
                        // if they dont already have an ssl flag, accept the remote server's
                        if (!dest->GetExt(extname, dummy))
                        {
@@ -695,12 +726,14 @@ class ModuleSSLOpenSSL : public Module
                        {
                                session->rstat = ISSL_READ;
                                session->status = ISSL_HANDSHAKING;
+                               return true;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
                                session->wstat = ISSL_WRITE;
                                session->status = ISSL_HANDSHAKING;
                                MakePollWrite(session);
+                               return true;
                        }
                        else
                        {
@@ -713,7 +746,7 @@ class ModuleSSLOpenSSL : public Module
                {
                        // Handshake complete.
                        // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       userrec* u = ServerInstance->FindDescriptor(session->fd);
+                       User* u = ServerInstance->FindDescriptor(session->fd);
                        if (u)
                        {
                                if (!u->GetExt("ssl", dummy))
@@ -735,10 +768,10 @@ class ModuleSSLOpenSSL : public Module
                return true;
        }
 
-       virtual void OnPostConnect(userrec* user)
+       virtual void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
+               // protocol module has propagated the NICK message.
                if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
@@ -759,7 +792,22 @@ class ModuleSSLOpenSSL : public Module
 
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
+               if (eh)
+               {
+                       ServerInstance->SE->WantWrite(eh);
+               }
+       }
+
+       virtual void OnBufferFlushed(User* user)
+       {
+               if (user->GetExt("ssl"))
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
 
        void CloseSession(issl_session* session)
@@ -843,5 +891,4 @@ static int error_callback(const char *str, size_t len, void *u)
        return 0;
 }
 
-MODULE_INIT(ModuleSSLOpenSSL);
-
+MODULE_INIT(ModuleSSLOpenSSL)