]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
The rest of the server protocol interface and fix a warning in m_rline
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index ba32c40134e96452a95c55e748ca4eb35a6887dc..83fa94e96c8b785243b68bb40247fa5a736bd0e4 100644 (file)
@@ -46,13 +46,15 @@ enum issl_io_status { ISSL_WRITE, ISSL_READ };
 
 static bool SelfSigned = false;
 
-bool isin(int port, const std::vector<int> &portlist)
+bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
 {
-       for(unsigned int i = 0; i < portlist.size(); i++)
-               if(portlist[i] == port)
-                       return true;
+       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
+               return true;
+
+       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
+               return true;
 
-       return false;
+       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
 }
 
 char* get_error()
@@ -102,10 +104,10 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
 class ModuleSSLOpenSSL : public Module
 {
-       std::vector<int> listenports;
+       std::vector<std::string> listenports;
 
        int inbufsize;
-       issl_session sessions[MAX_DESCRIPTORS];
+       issl_session* sessions;
 
        SSL_CTX* ctx;
        SSL_CTX* clictx;
@@ -131,6 +133,8 @@ class ModuleSSLOpenSSL : public Module
        {
                ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
+               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
+
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
 
@@ -154,9 +158,9 @@ class ModuleSSLOpenSSL : public Module
                ServerInstance->Modules->Attach(eventlist, this, 16);
        }
 
-        virtual void OnHookUserIO(User* user)
+        virtual void OnHookUserIO(User* user, const std::string &targetip)
        {
-               if (!user->io && isin(user->GetPort(), listenports))
+               if (!user->io && isin(targetip,user->GetPort(), listenports))
                {
                        /* Hook the user with our module */
                        user->io = this;
@@ -167,51 +171,43 @@ class ModuleSSLOpenSSL : public Module
        {
                ConfigReader Conf(ServerInstance);
 
-               for (unsigned int i = 0; i < listenports.size(); i++)
-               {
-                       ServerInstance->Config->DelIOHook(listenports[i]);
-               }
-
-               listenports.clear();
-               clientactive = 0;
-               sslports.clear();
-
-               for (int index = 0; index < Conf.Enumerate("bind"); index++)
-               {
-                       // For each <bind> tag
-                       std::string x = Conf.ReadValue("bind", "type", index);
-                       if (((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
-                       {
-                               // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf.ReadValue("bind", "port", index);
-                               irc::portparser portrange(port, false);
-                               long portno = -1;
-                               while ((portno = portrange.GetToken()))
-                               {
-                                       clientactive++;
-                                       try
-                                       {
-                                               if (ServerInstance->Config->AddIOHook(portno, this))
-                                               {
-                                                       listenports.push_back(portno);
-                                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
-                                                               if (ServerInstance->Config->ports[i]->GetPort() == portno)
-                                                                       ServerInstance->Config->ports[i]->SetDescription("ssl");
-                                                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %d", portno);
-                                                       sslports.append("*:").append(ConvToStr(portno)).append(";");
-                                               }
-                                               else
-                                               {
-                                                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?",   portno);
-                                               }
-                                       }
-                                       catch (ModuleException &e)
-                                       {
-                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %d: %s. Maybe it's already hooked by the same port on a different IP, or you have another SSL or similar module loaded?", portno, e.GetReason());
-                                       }
-                               }
-                       }
-               }
+                listenports.clear();
+                clientactive = 0;
+                sslports.clear();
+
+                for(int index = 0; index < Conf.Enumerate("bind"); index++)
+                {
+                        // For each <bind> tag
+                        std::string x = Conf.ReadValue("bind", "type", index);
+                        if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
+                        {
+                                // Get the port we're meant to be listening on with SSL
+                                std::string port = Conf.ReadValue("bind", "port", index);
+                                std::string addr = Conf.ReadValue("bind", "address", index);
+
+                                irc::portparser portrange(port, false);
+                                long portno = -1;
+                                while ((portno = portrange.GetToken()))
+                                {
+                                        clientactive++;
+                                        try
+                                        {
+                                                listenports.push_back(addr + ":" + ConvToStr(portno));
+
+                                                for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
+                                                        if ((ServerInstance->Config->ports[i]->GetPort() == portno) && (ServerInstance->Config->ports[i]->GetIP() == addr))
+                                                                ServerInstance->Config->ports[i]->SetDescription("ssl");
+                                                ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %ld", portno);
+
+                                                sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
+                                        }
+                                        catch (ModuleException &e)
+                                        {
+                                                ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_gnutls.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
+                                        }
+                                }
+                        }
+                }
 
                if (!sslports.empty())
                        sslports.erase(sslports.end() - 1);
@@ -308,6 +304,8 @@ class ModuleSSLOpenSSL : public Module
        {
                SSL_CTX_free(ctx);
                SSL_CTX_free(clictx);
+               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
+               delete[] sessions;
        }
 
        virtual void OnCleanup(int target_type, void* item)
@@ -316,13 +314,13 @@ class ModuleSSLOpenSSL : public Module
                {
                        User* user = (User*)item;
 
-                       if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && isin(user->GetPort(), listenports))
+                       if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && user->io == this)
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
                                User::QuitUser(ServerInstance, user, "SSL module unloading");
                        }
-                       if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
+                       if (user->GetExt("ssl_cert", dummy))
                        {
                                ssl_cert* tofree;
                                user->GetExt("ssl_cert", tofree);
@@ -340,9 +338,8 @@ class ModuleSSLOpenSSL : public Module
                {
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
-                               ServerInstance->Config->DelIOHook(listenports[i]);
                                for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
-                                       if (ServerInstance->Config->ports[j]->GetPort() == listenports[i])
+                                       if (listenports[i] == (ServerInstance->Config->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->Config->ports[j]->GetPort())))
                                                ServerInstance->Config->ports[j]->SetDescription("plaintext");
                        }
                }
@@ -403,7 +400,7 @@ class ModuleSSLOpenSSL : public Module
        virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
        {
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return;
 
                issl_session* session = &sessions[fd];
@@ -430,7 +427,7 @@ class ModuleSSLOpenSSL : public Module
        virtual void OnRawSocketConnect(int fd)
        {
                 /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
                        return;
 
                issl_session* session = &sessions[fd];
@@ -457,7 +454,7 @@ class ModuleSSLOpenSSL : public Module
        virtual void OnRawSocketClose(int fd)
        {
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return;
 
                CloseSession(&sessions[fd]);
@@ -476,7 +473,7 @@ class ModuleSSLOpenSSL : public Module
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return 0;
 
                issl_session* session = &sessions[fd];
@@ -553,7 +550,7 @@ class ModuleSSLOpenSSL : public Module
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > MAX_DESCRIPTORS))
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return 0;
 
                issl_session* session = &sessions[fd];
@@ -684,7 +681,7 @@ class ModuleSSLOpenSSL : public Module
                        return;
 
                // Bugfix, only send this numeric for *our* SSL users
-               if (dest->GetExt("ssl", dummy) || (IS_LOCAL(dest) &&  isin(dest->GetPort(), listenports)))
+               if (dest->GetExt("ssl", dummy) || ((IS_LOCAL(dest) && dest->io == this)))
                {
                        ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick, dest->nick);
                }
@@ -786,7 +783,7 @@ class ModuleSSLOpenSSL : public Module
                {
                        // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
                        std::deque<std::string>* metadata = new std::deque<std::string>;
-                       metadata->push_back(user->nick);
+                       metadata->push_back(user->uuid);
                        metadata->push_back("ssl");             // The metadata id
                        metadata->push_back("ON");              // The value to send
                        Event* event = new Event((char*)metadata,(Module*)this,"send_metadata");
@@ -892,6 +889,13 @@ class ModuleSSLOpenSSL : public Module
 
                X509_free(cert);
        }
+
+       void Prioritize()
+       {
+               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
+               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIO_AFTER, &server);
+       }
+
 };
 
 static int error_callback(const char *str, size_t len, void *u)