]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
m_ssl_openssl Verify DH params being non-NULL before setting it on the context
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 53a0e241fee1eec0580f9436990dd69a1167143f..aee7a5e3428a86afc8e2817c21fea3566aed3365 100644 (file)
@@ -1,26 +1,45 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2008 Pippijn van Steenhoven <pip88nl@gmail.com>
+ *   Copyright (C) 2006-2008 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2008 Thomas Stagner <aquanight@inspircd.org>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+ /* HACK: This prevents OpenSSL on OS X 10.7 and later from spewing deprecation
+  * warnings for every single function call. As far as I (SaberUK) know, Apple
+  * have no plans to remove OpenSSL so this warning just causes needless spam.
+  */
+#ifdef __APPLE__
+# define __AVAILABILITYMACROS__
+# define DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER
+#endif
 #include "inspircd.h"
 #include <openssl/ssl.h>
 #include <openssl/err.h>
-#include "transport.h"
+#include "ssl.h"
 
-#ifdef WINDOWS
-#pragma comment(lib, "libeay32MTd")
-#pragma comment(lib, "ssleay32MTd")
-#undef MAX_DESCRIPTORS
-#define MAX_DESCRIPTORS 10000
+#ifdef _WIN32
+# pragma comment(lib, "ssleay32.lib")
+# pragma comment(lib, "libeay32.lib")
+# undef MAX_DESCRIPTORS
+# define MAX_DESCRIPTORS 10000
 #endif
 
 /* $ModDesc: Provides SSL support for clients */
 /* $CompileFlags: if(!"USE_FREEBSD_BASE_SSL") pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
 /* $LinkerFlags: if(!"USE_FREEBSD_BASE_SSL") rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto -ldl") */
 
-/* $ModDep: transport.h */
 /* $NoPedantic */
-/* $CopyInstall: conf/key.pem $(CONPATH) */
-/* $CopyInstall: conf/cert.pem $(CONPATH) */
 
 
+class ModuleSSLOpenSSL;
+
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
-enum issl_io_status { ISSL_WRITE, ISSL_READ };
 
 static bool SelfSigned = false;
 
-bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
-{
-       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
-               return true;
-
-       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
-               return true;
-
-       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
-}
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+static ModuleSSLOpenSSL* opensslmod = NULL;
+#endif
 
 char* get_error()
 {
@@ -60,25 +70,22 @@ static int error_callback(const char *str, size_t len, void *u);
 
 /** Represents an SSL user's extra data
  */
-class issl_session : public classbase
+class issl_session
 {
 public:
        SSL* sess;
        issl_status status;
-       issl_io_status rstat;
-       issl_io_status wstat;
+       reference<ssl_cert> cert;
 
-       unsigned int inbufoffset;
-       char* inbuf;                    // Buffer OpenSSL reads into.
-       std::string outbuf;     // Buffer for outgoing data that OpenSSL will not take.
-       int fd;
        bool outbound;
+       bool data_to_write;
 
        issl_session()
+               : sess(NULL)
+               , status(ISSL_NONE)
        {
                outbound = false;
-               rstat = ISSL_READ;
-               wstat = ISSL_WRITE;
+               data_to_write = false;
        }
 };
 
@@ -98,39 +105,115 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
 class ModuleSSLOpenSSL : public Module
 {
-       std::vector<std::string> listenports;
-
-       int inbufsize;
        issl_session* sessions;
 
        SSL_CTX* ctx;
        SSL_CTX* clictx;
 
-       char* dummy;
-       char cipher[MAXBUF];
+       long ctx_options;
+       long clictx_options;
 
-       std::string keyfile;
-       std::string certfile;
-       std::string cafile;
-       // std::string crlfile;
-       std::string dhfile;
        std::string sslports;
+       bool use_sha;
 
-       int clientactive;
+       ServiceProvider iohook;
 
- public:
+       static void SetContextOptions(SSL_CTX* ctx, long defoptions, const std::string& ctxname, ConfigTag* tag)
+       {
+               long setoptions = tag->getInt(ctxname + "setoptions");
+               // User-friendly config options for setting context options
+#ifdef SSL_OP_CIPHER_SERVER_PREFERENCE
+               if (tag->getBool("cipherserverpref"))
+                       setoptions |= SSL_OP_CIPHER_SERVER_PREFERENCE;
+#endif
+#ifdef SSL_OP_NO_COMPRESSION
+               if (!tag->getBool("compression", true))
+                       setoptions |= SSL_OP_NO_COMPRESSION;
+#endif
+               if (!tag->getBool("sslv3", true))
+                       setoptions |= SSL_OP_NO_SSLv3;
+               if (!tag->getBool("tlsv1", true))
+                       setoptions |= SSL_OP_NO_TLSv1;
+
+               long clearoptions = tag->getInt(ctxname + "clearoptions");
+               ServerInstance->Logs->Log("m_ssl_openssl", DEBUG, "Setting OpenSSL %s context options, default: %ld set: %ld clear: %ld", ctxname.c_str(), defoptions, setoptions, clearoptions);
 
-       InspIRCd* PublicInstance;
+               // Clear everything
+               SSL_CTX_clear_options(ctx, SSL_CTX_get_options(ctx));
 
-       ModuleSSLOpenSSL(InspIRCd* Me)
-       : Module(Me), PublicInstance(Me)
+               // Set the default options and what is in the conf
+               SSL_CTX_set_options(ctx, defoptions | setoptions);
+               long final = SSL_CTX_clear_options(ctx, clearoptions);
+               ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "OpenSSL %s context options: %ld", ctxname.c_str(), final);
+       }
+
+#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
+       void SetupECDH(ConfigTag* tag)
        {
-               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
+               std::string curvename = tag->getString("ecdhcurve", "prime256v1");
+               if (curvename.empty())
+                       return;
 
-               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
+               int nid = OBJ_sn2nid(curvename.c_str());
+               if (nid == 0)
+               {
+                       ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Unknown curve: \"%s\"", curvename.c_str());
+                       return;
+               }
 
-               // Not rehashable...because I cba to reduce all the sizes of existing buffers.
-               inbufsize = ServerInstance->Config->NetBufferSize;
+               EC_KEY* eckey = EC_KEY_new_by_curve_name(nid);
+               if (!eckey)
+               {
+                       ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Unable to create EC key object");
+                       return;
+               }
+
+               ERR_clear_error();
+               if (SSL_CTX_set_tmp_ecdh(ctx, eckey) < 0)
+               {
+                       ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Couldn't set ECDH parameters");
+                       ERR_print_errors_cb(error_callback, this);
+               }
+
+               EC_KEY_free(eckey);
+       }
+#endif
+
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+       static void SSLInfoCallback(const SSL* ssl, int where, int rc)
+       {
+               int fd = SSL_get_fd(const_cast<SSL*>(ssl));
+               issl_session& session = opensslmod->sessions[fd];
+
+               if ((where & SSL_CB_HANDSHAKE_START) && (session.status == ISSL_OPEN))
+               {
+                       // The other side is trying to renegotiate, kill the connection and change status
+                       // to ISSL_NONE so CheckRenego() closes the session
+                       session.status = ISSL_NONE;
+                       ServerInstance->SE->Shutdown(fd, 2);
+               }
+       }
+
+       bool CheckRenego(StreamSocket* sock, issl_session* session)
+       {
+               if (session->status != ISSL_NONE)
+                       return true;
+
+               ServerInstance->Logs->Log("m_ssl_openssl", DEBUG, "Session %p killed, attempted to renegotiate", (void*)session->sess);
+               CloseSession(session);
+               sock->SetError("Renegotiation is not allowed");
+               return false;
+       }
+#endif
+
+ public:
+
+       ModuleSSLOpenSSL() : iohook(this, "ssl/openssl", SERVICE_IOHOOK)
+       {
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+               opensslmod = this;
+#endif
+               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                /* Global SSL library initialization*/
                SSL_library_init();
@@ -148,134 +231,144 @@ class ModuleSSLOpenSSL : public Module
                SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
                SSL_CTX_set_verify(clictx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 
+               SSL_CTX_set_session_cache_mode(ctx, SSL_SESS_CACHE_OFF);
+               SSL_CTX_set_session_cache_mode(clictx, SSL_SESS_CACHE_OFF);
+
+               long opts = SSL_OP_NO_SSLv2 | SSL_OP_SINGLE_DH_USE;
+               // Only turn options on if they exist
+#ifdef SSL_OP_SINGLE_ECDH_USE
+               opts |= SSL_OP_SINGLE_ECDH_USE;
+#endif
+#ifdef SSL_OP_NO_TICKET
+               opts |= SSL_OP_NO_TICKET;
+#endif
+
+               ctx_options = SSL_CTX_set_options(ctx, opts);
+               clictx_options = SSL_CTX_set_options(clictx, opts);
+       }
+
+       void init()
+       {
                // Needs the flag as it ignores a plain /rehash
                OnModuleRehash(NULL,"ssl");
-               Implementation eventlist[] = { I_OnRawSocketConnect, I_OnRawSocketAccept,
-                       I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup, I_On005Numeric,
-                       I_OnBufferFlushed, I_OnRequest, I_OnSyncUserMetaData, I_OnDecodeMetaData,
-                       I_OnUnloadModule, I_OnRehash, I_OnModuleRehash, I_OnWhois, I_OnPostConnect,
-                       I_OnHookUserIO };
-               ServerInstance->Modules->Attach(eventlist, this, 17);
+               Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnHookIO, I_OnUserConnect };
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
+               ServerInstance->Modules->AddService(iohook);
        }
 
-       virtual void OnHookUserIO(User* user, const std::string &targetip)
+       void OnHookIO(StreamSocket* user, ListenSocket* lsb)
        {
-               if (!user->GetIOHook() && isin(targetip,user->GetPort(), listenports))
+               if (!user->GetIOHook() && lsb->bind_tag->getString("ssl") == "openssl")
                {
                        /* Hook the user with our module */
                        user->AddIOHook(this);
                }
        }
 
-       virtual void OnRehash(User* user)
+       void OnRehash(User* user)
        {
-               ConfigReader Conf(ServerInstance);
-
-               listenports.clear();
-               clientactive = 0;
                sslports.clear();
 
-               for(int index = 0; index < Conf.Enumerate("bind"); index++)
+               ConfigTag* Conf = ServerInstance->Config->ConfValue("openssl");
+
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+               // Set the callback if we are not allowing renegotiations, unset it if we do
+               if (Conf->getBool("renegotiation", true))
+               {
+                       SSL_CTX_set_info_callback(ctx, NULL);
+                       SSL_CTX_set_info_callback(clictx, NULL);
+               }
+               else
                {
-                       // For each <bind> tag
-                       std::string x = Conf.ReadValue("bind", "type", index);
-                       if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
+                       SSL_CTX_set_info_callback(ctx, SSLInfoCallback);
+                       SSL_CTX_set_info_callback(clictx, SSLInfoCallback);
+               }
+#endif
+
+               if (Conf->getBool("showports", true))
+               {
+                       sslports = Conf->getString("advertisedports");
+                       if (!sslports.empty())
+                               return;
+
+                       for (size_t i = 0; i < ServerInstance->ports.size(); i++)
                        {
-                               // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf.ReadValue("bind", "port", index);
-                               std::string addr = Conf.ReadValue("bind", "address", index);
+                               ListenSocket* port = ServerInstance->ports[i];
+                               if (port->bind_tag->getString("ssl") != "openssl")
+                                       continue;
 
-                               if (!addr.empty())
-                               {
-                                       // normalize address, important for IPv6
-                                       int portint = 0;
-                                       irc::sockets::sockaddrs bin;
-                                       if (irc::sockets::aptosa(addr.c_str(), portint, &bin))
-                                               irc::sockets::satoap(&bin, addr, portint);
-                               }
+                               const std::string& portid = port->bind_desc;
+                               ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %s", portid.c_str());
 
-                               irc::portparser portrange(port, false);
-                               long portno = -1;
-                               while ((portno = portrange.GetToken()))
+                               if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
                                {
-                                       clientactive++;
-                                       try
-                                       {
-                                               listenports.push_back(addr + ":" + ConvToStr(portno));
-
-                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
-                                                       if ((ServerInstance->Config->ports[i]->GetPort() == portno) && (ServerInstance->Config->ports[i]->GetIP() == addr))
-                                                               ServerInstance->Config->ports[i]->SetDescription("ssl");
-                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %ld", portno);
-
-                                               if (addr != "127.0.0.1")
-                                                       sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
-                                       }
-                                       catch (ModuleException &e)
-                                       {
-                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
-                                       }
+                                       /*
+                                        * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
+                                        * the IP:port in ISUPPORT.
+                                        *
+                                        * We used to advertise all ports seperated by a ';' char that matched the above criteria,
+                                        * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
+                                        * To solve this by default we now only display the first IP:port found and let the user
+                                        * configure the exact value for the 005 token, if necessary.
+                                        */
+                                       sslports = portid;
+                                       break;
                                }
                        }
                }
-
-               if (!sslports.empty())
-                       sslports.erase(sslports.end() - 1);
        }
 
-       virtual void OnModuleRehash(User* user, const std::string &param)
+       void OnModuleRehash(User* user, const std::string &param)
        {
                if (param != "ssl")
                        return;
 
+               std::string keyfile;
+               std::string certfile;
+               std::string cafile;
+               std::string dhfile;
                OnRehash(user);
 
-               ConfigReader Conf(ServerInstance);
-
-               std::string confdir(ServerInstance->ConfigFileName);
-               // +1 so we the path ends with a /
-               confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
-
-               cafile   = Conf.ReadValue("openssl", "cafile", 0);
-               certfile = Conf.ReadValue("openssl", "certfile", 0);
-               keyfile  = Conf.ReadValue("openssl", "keyfile", 0);
-               dhfile   = Conf.ReadValue("openssl", "dhfile", 0);
-
-               // Set all the default values needed.
-               if (cafile.empty())
-                       cafile = "ca.pem";
-
-               if (certfile.empty())
-                       certfile = "cert.pem";
+               ConfigTag* conf = ServerInstance->Config->ConfValue("openssl");
 
-               if (keyfile.empty())
-                       keyfile = "key.pem";
+               cafile   = conf->getString("cafile", CONFIG_PATH "/ca.pem");
+               certfile = conf->getString("certfile", CONFIG_PATH "/cert.pem");
+               keyfile  = conf->getString("keyfile", CONFIG_PATH "/key.pem");
+               dhfile   = conf->getString("dhfile", CONFIG_PATH "/dhparams.pem");
+               std::string hash = conf->getString("hash", "md5");
+               if (hash != "sha1" && hash != "md5")
+                       throw ModuleException("Unknown hash type " + hash);
+               use_sha = (hash == "sha1");
 
-               if (dhfile.empty())
-                       dhfile = "dhparams.pem";
-
-               // Prepend relative paths with the path to the config directory.
-               if ((cafile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(cafile)))
-                       cafile = confdir + cafile;
-
-               if ((certfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(certfile)))
-                       certfile = confdir + certfile;
+               if (conf->getBool("customcontextoptions"))
+               {
+                       SetContextOptions(ctx, ctx_options, "server", conf);
+                       SetContextOptions(clictx, clictx_options, "client", conf);
+               }
 
-               if ((keyfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(keyfile)))
-                       keyfile = confdir + keyfile;
+               std::string ciphers = conf->getString("ciphers", "");
 
-               if ((dhfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(dhfile)))
-                       dhfile = confdir + dhfile;
+               if (!ciphers.empty())
+               {
+                       ERR_clear_error();
+                       if ((!SSL_CTX_set_cipher_list(ctx, ciphers.c_str())) || (!SSL_CTX_set_cipher_list(clictx, ciphers.c_str())))
+                       {
+                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't set cipher list to %s.", ciphers.c_str());
+                               ERR_print_errors_cb(error_callback, this);
+                       }
+               }
 
                /* Load our keys and certificates
                 * NOTE: OpenSSL's error logging API sucks, don't blame us for this clusterfuck.
                 */
+               ERR_clear_error();
                if ((!SSL_CTX_use_certificate_chain_file(ctx, certfile.c_str())) || (!SSL_CTX_use_certificate_chain_file(clictx, certfile.c_str())))
                {
                        ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s. %s", certfile.c_str(), strerror(errno));
                        ERR_print_errors_cb(error_callback, this);
                }
 
+               ERR_clear_error();
                if (((!SSL_CTX_use_PrivateKey_file(ctx, keyfile.c_str(), SSL_FILETYPE_PEM))) || (!SSL_CTX_use_PrivateKey_file(clictx, keyfile.c_str(), SSL_FILETYPE_PEM)))
                {
                        ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read key file %s. %s", keyfile.c_str(), strerror(errno));
@@ -283,13 +376,18 @@ class ModuleSSLOpenSSL : public Module
                }
 
                /* Load the CAs we trust*/
+               ERR_clear_error();
                if (((!SSL_CTX_load_verify_locations(ctx, cafile.c_str(), 0))) || (!SSL_CTX_load_verify_locations(clictx, cafile.c_str(), 0)))
                {
-                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. %s", cafile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. This is only a problem if you want to verify client certificates, otherwise it's safe to ignore this message. Error: %s", cafile.c_str(), strerror(errno));
                        ERR_print_errors_cb(error_callback, this);
                }
 
+#ifdef _WIN32
+               BIO* dhpfile = BIO_new_file(dhfile.c_str(), "r");
+#else
                FILE* dhpfile = fopen(dhfile.c_str(), "r");
+#endif
                DH* ret;
 
                if (dhpfile == NULL)
@@ -299,132 +397,114 @@ class ModuleSSLOpenSSL : public Module
                }
                else
                {
+#ifdef _WIN32
+                       ret = PEM_read_bio_DHparams(dhpfile, NULL, NULL, NULL);
+                       BIO_free(dhpfile);
+#else
                        ret = PEM_read_DHparams(dhpfile, NULL, NULL, NULL);
-                       if ((SSL_CTX_set_tmp_dh(ctx, ret) < 0) || (SSL_CTX_set_tmp_dh(clictx, ret) < 0))
+#endif
+
+                       ERR_clear_error();
+                       if (ret)
                        {
-                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
-                               ERR_print_errors_cb(error_callback, this);
+                               if ((SSL_CTX_set_tmp_dh(ctx, ret) < 0) || (SSL_CTX_set_tmp_dh(clictx, ret) < 0))
+                               {
+                                       ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
+                                       ERR_print_errors_cb(error_callback, this);
+                               }
+                               DH_free(ret);
+                       }
+                       else
+                       {
+                               ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s.", dhfile.c_str());
                        }
                }
 
+#ifndef _WIN32
                fclose(dhpfile);
+#endif
+
+#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
+               SetupECDH(conf);
+#endif
        }
 
-       virtual void On005Numeric(std::string &output)
+       void On005Numeric(std::string &output)
        {
-               output.append(" SSL=" + sslports);
+               if (!sslports.empty())
+                       output.append(" SSL=" + sslports);
        }
 
-       virtual ~ModuleSSLOpenSSL()
+       ~ModuleSSLOpenSSL()
        {
                SSL_CTX_free(ctx);
                SSL_CTX_free(clictx);
-               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
                delete[] sessions;
        }
 
-       virtual void OnCleanup(int target_type, void* item)
+       void OnUserConnect(LocalUser* user)
        {
-               if (target_type == TYPE_USER)
+               if (user->eh.GetIOHook() == this)
                {
-                       User* user = (User*)item;
-
-                       if (user->GetIOHook() == this)
-                       {
-                               // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
-                               // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
-                               user->DelIOHook();
-                       }
-                       if (user->GetExt("ssl_cert", dummy))
+                       if (sessions[user->eh.GetFd()].sess)
                        {
-                               ssl_cert* tofree;
-                               user->GetExt("ssl_cert", tofree);
-                               delete tofree;
-                               user->Shrink("ssl_cert");
+                               if (!sessions[user->eh.GetFd()].cert->fingerprint.empty())
+                                       user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\""
+                                               " and your SSL fingerprint is %s", user->nick.c_str(), SSL_get_cipher(sessions[user->eh.GetFd()].sess), sessions[user->eh.GetFd()].cert->fingerprint.c_str());
+                               else
+                                       user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->eh.GetFd()].sess));
                        }
                }
        }
 
-       virtual void OnUnloadModule(Module* mod, const std::string &name)
+       void OnCleanup(int target_type, void* item)
        {
-               if (mod == this)
+               if (target_type == TYPE_USER)
                {
-                       for(unsigned int i = 0; i < listenports.size(); i++)
+                       LocalUser* user = IS_LOCAL((User*)item);
+
+                       if (user && user->eh.GetIOHook() == this)
                        {
-                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
-                                       if (listenports[i] == (ServerInstance->Config->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->Config->ports[j]->GetPort())))
-                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
+                               // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
+                               // Potentially there could be multiple SSL modules loaded at once on different ports.
+                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
                        }
                }
        }
 
-       virtual Version GetVersion()
+       Version GetVersion()
        {
-               return Version("$Id$", VF_VENDOR, API_VERSION);
+               return Version("Provides SSL support for clients", VF_VENDOR);
        }
 
-
-       virtual const char* OnRequest(Request* request)
+       void OnRequest(Request& request)
        {
-               ISHRequest* ISR = (ISHRequest*)request;
-               if (strcmp("IS_NAME", request->GetId()) == 0)
-               {
-                       return "openssl";
-               }
-               else if (strcmp("IS_HOOK", request->GetId()) == 0)
-               {
-                       const char* ret = "OK";
-                       try
-                       {
-                               ret = ISR->Sock->AddIOHook((Module*)this) ? "OK" : NULL;
-                       }
-                       catch (ModuleException &e)
-                       {
-                               return NULL;
-                       }
-
-                       return ret;
-               }
-               else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
-               {
-                       return ISR->Sock->DelIOHook() ? "OK" : NULL;
-               }
-               else if (strcmp("IS_HSDONE", request->GetId()) == 0)
+               if (strcmp("GET_SSL_CERT", request.id) == 0)
                {
-                       if (ISR->Sock->GetFd() < 0)
-                               return "OK";
+                       SocketCertificateRequest& req = static_cast<SocketCertificateRequest&>(request);
+                       int fd = req.sock->GetFd();
+                       issl_session* session = &sessions[fd];
 
-                       issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       return (session->status == ISSL_HANDSHAKING) ? NULL : "OK";
+                       req.cert = session->cert;
                }
-               else if (strcmp("IS_ATTACH", request->GetId()) == 0)
+               else if (!strcmp("GET_RAW_SSL_SESSION", request.id))
                {
-                       issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       if (session->sess)
-                       {
-                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
-                               return "OK";
-                       }
+                       SSLRawSessionRequest& req = static_cast<SSLRawSessionRequest&>(request);
+                       if ((req.fd >= 0) && (req.fd < ServerInstance->SE->GetMaxFds()))
+                               req.data = reinterpret_cast<void*>(sessions[req.fd].sess);
                }
-               return NULL;
        }
 
-
-       virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return;
+               int fd = user->GetFd();
 
                issl_session* session = &sessions[fd];
 
-               session->fd = fd;
-               session->inbuf = new char[inbufsize];
-               session->inbufoffset = 0;
                session->sess = SSL_new(ctx);
                session->status = ISSL_NONE;
                session->outbound = false;
+               session->data_to_write = false;
 
                if (session->sess == NULL)
                        return;
@@ -435,23 +515,22 @@ class ModuleSSLOpenSSL : public Module
                        return;
                }
 
-               Handshake(session);
+               Handshake(user, session);
        }
 
-       virtual void OnRawSocketConnect(int fd)
+       void OnStreamSocketConnect(StreamSocket* user)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
                        return;
 
                issl_session* session = &sessions[fd];
 
-               session->fd = fd;
-               session->inbuf = new char[inbufsize];
-               session->inbufoffset = 0;
                session->sess = SSL_new(clictx);
                session->status = ISSL_NONE;
                session->outbound = true;
+               session->data_to_write = false;
 
                if (session->sess == NULL)
                        return;
@@ -462,59 +541,43 @@ class ModuleSSLOpenSSL : public Module
                        return;
                }
 
-               Handshake(session);
+               Handshake(user, session);
        }
 
-       virtual void OnRawSocketClose(int fd)
+       void OnStreamSocketClose(StreamSocket* user)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return;
 
                CloseSession(&sessions[fd]);
-
-               EventHandler* user = ServerInstance->SE->GetRef(fd);
-
-               if ((user) && (user->GetExt("ssl_cert", dummy)))
-               {
-                       ssl_cert* tofree;
-                       user->GetExt("ssl_cert", tofree);
-                       delete tofree;
-                       user->Shrink("ssl_cert");
-               }
        }
 
-       virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
+       int OnStreamSocketRead(StreamSocket* user, std::string& recvq)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
+                       return -1;
 
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
                {
-                       readresult = 0;
                        CloseSession(session);
-                       return 1;
+                       return -1;
                }
 
                if (session->status == ISSL_HANDSHAKING)
                {
-                       if (session->rstat == ISSL_READ || session->wstat == ISSL_READ)
+                       // The handshake isn't finished and it wants to read, try to finish it.
+                       if (!Handshake(user, session))
                        {
-                               // The handshake isn't finished and it wants to read, try to finish it.
-                               if (!Handshake(session))
-                               {
-                                       // Couldn't resume handshake.
-                                       errno = session->status == ISSL_NONE ? EIO : EAGAIN;
+                               // Couldn't resume handshake.
+                               if (session->status == ISSL_NONE)
                                        return -1;
-                               }
-                       }
-                       else
-                       {
-                               errno = EAGAIN;
-                               return -1;
+                               return 0;
                        }
                }
 
@@ -522,53 +585,66 @@ class ModuleSSLOpenSSL : public Module
 
                if (session->status == ISSL_OPEN)
                {
-                       if (session->wstat == ISSL_READ)
+                       ERR_clear_error();
+                       char* buffer = ServerInstance->GetReadBuffer();
+                       size_t bufsiz = ServerInstance->Config->NetBufferSize;
+                       int ret = SSL_read(session->sess, buffer, bufsiz);
+
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+                       if (!CheckRenego(user, session))
+                               return -1;
+#endif
+
+                       if (ret > 0)
                        {
-                               if(DoWrite(session) == 0)
-                                       return 0;
+                               recvq.append(buffer, ret);
+
+                               int mask = 0;
+                               // Schedule a read if there is still data in the OpenSSL buffer
+                               if (SSL_pending(session->sess) > 0)
+                                       mask |= FD_ADD_TRIAL_READ;
+                               if (session->data_to_write)
+                                       mask |= FD_WANT_POLL_READ | FD_WANT_SINGLE_WRITE;
+                               if (mask != 0)
+                                       ServerInstance->SE->ChangeEventMask(user, mask);
+                               return 1;
                        }
-
-                       if (session->rstat == ISSL_READ)
+                       else if (ret == 0)
                        {
-                               int ret = DoRead(session);
+                               // Client closed connection.
+                               CloseSession(session);
+                               user->SetError("Connection closed");
+                               return -1;
+                       }
+                       else if (ret < 0)
+                       {
+                               int err = SSL_get_error(session->sess, ret);
 
-                               if (ret > 0)
+                               if (err == SSL_ERROR_WANT_READ)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ);
+                                       return 0;
+                               }
+                               else if (err == SSL_ERROR_WANT_WRITE)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
+                                       return 0;
+                               }
+                               else
                                {
-                                       if (count <= session->inbufoffset)
-                                       {
-                                               memcpy(buffer, session->inbuf, count);
-                                               // Move the stuff left in inbuf to the beginning of it
-                                               memmove(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
-                                               // Now we need to set session->inbufoffset to the amount of data still waiting to be handed to insp.
-                                               session->inbufoffset -= count;
-                                               // Insp uses readresult as the count of how much data there is in buffer, so:
-                                               readresult = count;
-                                       }
-                                       else
-                                       {
-                                               // There's not as much in the inbuf as there is space in the buffer, so just copy the whole thing.
-                                               memcpy(buffer, session->inbuf, session->inbufoffset);
-
-                                               readresult = session->inbufoffset;
-                                               // Zero the offset, as there's nothing there..
-                                               session->inbufoffset = 0;
-                                       }
-                                       return 1;
+                                       CloseSession(session);
+                                       return -1;
                                }
-                               return ret;
                        }
                }
 
-               return -1;
+               return 0;
        }
 
-       virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
+       int OnStreamSocketWrite(StreamSocket* user, std::string& buffer)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
+               int fd = user->GetFd();
 
-               errno = EAGAIN;
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -577,170 +653,75 @@ class ModuleSSLOpenSSL : public Module
                        return -1;
                }
 
-               session->outbuf.append(buffer, count);
-               MakePollWrite(session);
+               session->data_to_write = true;
 
                if (session->status == ISSL_HANDSHAKING)
                {
-                       // The handshake isn't finished, try to finish it.
-                       if (session->rstat == ISSL_WRITE || session->wstat == ISSL_WRITE)
+                       if (!Handshake(user, session))
                        {
-                               if (!Handshake(session))
-                               {
-                                       // Couldn't resume handshake.
-                                       errno = session->status == ISSL_NONE ? EIO : EAGAIN;
+                               // Couldn't resume handshake.
+                               if (session->status == ISSL_NONE)
                                        return -1;
-                               }
+                               return 0;
                        }
                }
 
                if (session->status == ISSL_OPEN)
                {
-                       if (session->rstat == ISSL_WRITE)
-                       {
-                               DoRead(session);
-                       }
-
-                       if (session->wstat == ISSL_WRITE)
-                       {
-                               return DoWrite(session);
-                       }
-               }
-
-               return 1;
-       }
-
-       int DoWrite(issl_session* session)
-       {
-               if (!session->outbuf.size())
-                       return -1;
-
-               int ret = SSL_write(session->sess, session->outbuf.data(), session->outbuf.size());
-
-               if (ret == 0)
-               {
-                       CloseSession(session);
-                       return 0;
-               }
-               else if (ret < 0)
-               {
-                       int err = SSL_get_error(session->sess, ret);
+                       ERR_clear_error();
+                       int ret = SSL_write(session->sess, buffer.data(), buffer.size());
 
-                       if (err == SSL_ERROR_WANT_WRITE)
-                       {
-                               session->wstat = ISSL_WRITE;
+#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
+                       if (!CheckRenego(user, session))
                                return -1;
-                       }
-                       else if (err == SSL_ERROR_WANT_READ)
-                       {
-                               session->wstat = ISSL_READ;
-                               return -1;
-                       }
-                       else
-                       {
-                               CloseSession(session);
-                               return 0;
-                       }
-               }
-               else
-               {
-                       session->outbuf = session->outbuf.substr(ret);
-                       return ret;
-               }
-       }
-
-       int DoRead(issl_session* session)
-       {
-               // Is this right? Not sure if the unencrypted data is garaunteed to be the same length.
-               // Read into the inbuffer, offset from the beginning by the amount of data we have that insp hasn't taken yet.
-
-               int ret = SSL_read(session->sess, session->inbuf + session->inbufoffset, inbufsize - session->inbufoffset);
-
-               if (ret == 0)
-               {
-                       // Client closed connection.
-                       CloseSession(session);
-                       return 0;
-               }
-               else if (ret < 0)
-               {
-                       int err = SSL_get_error(session->sess, ret);
+#endif
 
-                       if (err == SSL_ERROR_WANT_READ)
+                       if (ret == (int)buffer.length())
                        {
-                               session->rstat = ISSL_READ;
-                               return -1;
+                               session->data_to_write = false;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+                               return 1;
                        }
-                       else if (err == SSL_ERROR_WANT_WRITE)
+                       else if (ret > 0)
                        {
-                               session->rstat = ISSL_WRITE;
-                               MakePollWrite(session);
-                               return -1;
+                               buffer = buffer.substr(ret);
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
+                               return 0;
                        }
-                       else
+                       else if (ret == 0)
                        {
                                CloseSession(session);
-                               return 0;
+                               return -1;
                        }
-               }
-               else
-               {
-                       // Read successfully 'ret' bytes into inbuf + inbufoffset
-                       // There are 'ret' + 'inbufoffset' bytes of data in 'inbuf'
-                       // 'buffer' is 'count' long
-
-                       session->inbufoffset += ret;
-
-                       return ret;
-               }
-       }
-
-       // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(User* source, User* dest)
-       {
-               if (!clientactive)
-                       return;
-
-               // Bugfix, only send this numeric for *our* SSL users
-               if (dest->GetExt("ssl", dummy))
-               {
-                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick.c_str(), dest->nick.c_str());
-               }
-       }
-
-       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
-       {
-               // check if the linking module wants to know about OUR metadata
-               if (extname == "ssl")
-               {
-                       // check if this user has an swhois field to send
-                       if(user->GetExt(extname, dummy))
+                       else if (ret < 0)
                        {
-                               // call this function in the linking module, let it format the data how it
-                               // sees fit, and send it on its way. We dont need or want to know how.
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, displayable ? "Enabled" : "ON");
-                       }
-               }
-       }
+                               int err = SSL_get_error(session->sess, ret);
 
-       virtual void OnDecodeMetaData(int target_type, void* target, const std::string &extname, const std::string &extdata)
-       {
-               // check if its our metadata key, and its associated with a user
-               if ((target_type == TYPE_USER) && (extname == "ssl"))
-               {
-                       User* dest = (User*)target;
-                       // if they dont already have an ssl flag, accept the remote server's
-                       if (!dest->GetExt(extname, dummy))
-                       {
-                               dest->Extend(extname, "ON");
+                               if (err == SSL_ERROR_WANT_WRITE)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
+                                       return 0;
+                               }
+                               else if (err == SSL_ERROR_WANT_READ)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ);
+                                       return 0;
+                               }
+                               else
+                               {
+                                       CloseSession(session);
+                                       return -1;
+                               }
                        }
                }
+               return 0;
        }
 
-       bool Handshake(issl_session* session)
+       bool Handshake(StreamSocket* user, issl_session* session)
        {
                int ret;
 
+               ERR_clear_error();
                if (session->outbound)
                        ret = SSL_connect(session->sess);
                else
@@ -752,15 +733,14 @@ class ModuleSSLOpenSSL : public Module
 
                        if (err == SSL_ERROR_WANT_READ)
                        {
-                               session->rstat = ISSL_READ;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
                                session->status = ISSL_HANDSHAKING;
                                return true;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
-                               session->wstat = ISSL_WRITE;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
                                session->status = ISSL_HANDSHAKING;
-                               MakePollWrite(session);
                                return true;
                        }
                        else
@@ -773,62 +753,19 @@ class ModuleSSLOpenSSL : public Module
                else if (ret > 0)
                {
                        // Handshake complete.
-                       // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       EventHandler *u = ServerInstance->SE->GetRef(session->fd);
-                       if (u)
-                       {
-                               if (!u->GetExt("ssl", dummy))
-                                       u->Extend("ssl", "ON");
-                       }
+                       VerifyCertificate(session, user);
 
                        session->status = ISSL_OPEN;
 
-                       MakePollWrite(session);
+                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
 
                        return true;
                }
                else if (ret == 0)
                {
                        CloseSession(session);
-                       return true;
-               }
-
-               return true;
-       }
-
-       virtual void OnPostConnect(User* user)
-       {
-               // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propagated the NICK message.
-               if ((user->GetIOHook() == this) && (IS_LOCAL(user)))
-               {
-                       // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
-                       ServerInstance->PI->SendMetaData(user, TYPE_USER, "ssl", "on");
-
-                       VerifyCertificate(&sessions[user->GetFd()], user);
-                       if (sessions[user->GetFd()].sess)
-                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->GetFd()].sess));
-               }
-       }
-
-       void MakePollWrite(issl_session* session)
-       {
-               //OnRawSocketWrite(session->fd, NULL, 0);
-               EventHandler* eh = ServerInstance->SE->GetRef(session->fd);
-               if (eh)
-               {
-                       ServerInstance->SE->WantWrite(eh);
-               }
-       }
-
-       virtual void OnBufferFlushed(User* user)
-       {
-               if (user->GetIOHook() == this)
-               {
-                       issl_session* session = &sessions[user->GetFd()];
-                       if (session && session->outbuf.size())
-                               OnRawSocketWrite(user->GetFd(), NULL, 0);
                }
+               return false;
        }
 
        void CloseSession(issl_session* session)
@@ -839,84 +776,77 @@ class ModuleSSLOpenSSL : public Module
                        SSL_free(session->sess);
                }
 
-               if (session->inbuf)
-               {
-                       delete[] session->inbuf;
-               }
-
-               session->outbuf.clear();
-               session->inbuf = NULL;
                session->sess = NULL;
                session->status = ISSL_NONE;
-               errno = EIO;
+               session->cert = NULL;
        }
 
-       void VerifyCertificate(issl_session* session, Extensible* user)
+       void VerifyCertificate(issl_session* session, StreamSocket* user)
        {
                if (!session->sess || !user)
                        return;
 
                X509* cert;
                ssl_cert* certinfo = new ssl_cert;
+               session->cert = certinfo;
                unsigned int n;
                unsigned char md[EVP_MAX_MD_SIZE];
-               const EVP_MD *digest = EVP_md5();
-
-               user->Extend("ssl_cert",certinfo);
+               const EVP_MD *digest = use_sha ? EVP_sha1() : EVP_md5();
 
                cert = SSL_get_peer_certificate((SSL*)session->sess);
 
                if (!cert)
                {
-                       certinfo->data.insert(std::make_pair("error","Could not get peer certificate: "+std::string(get_error())));
+                       certinfo->error = "Could not get peer certificate: "+std::string(get_error());
                        return;
                }
 
-               certinfo->data.insert(std::make_pair("invalid", SSL_get_verify_result(session->sess) != X509_V_OK ? ConvToStr(1) : ConvToStr(0)));
+               certinfo->invalid = (SSL_get_verify_result(session->sess) != X509_V_OK);
 
-               if (SelfSigned)
+               if (!SelfSigned)
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(0)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(1)));
+                       certinfo->unknownsigner = false;
+                       certinfo->trusted = true;
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(1)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(0)));
+                       certinfo->unknownsigner = true;
+                       certinfo->trusted = false;
                }
 
-               certinfo->data.insert(std::make_pair("dn",std::string(X509_NAME_oneline(X509_get_subject_name(cert),0,0))));
-               certinfo->data.insert(std::make_pair("issuer",std::string(X509_NAME_oneline(X509_get_issuer_name(cert),0,0))));
+               char buf[512];
+               X509_NAME_oneline(X509_get_subject_name(cert), buf, sizeof(buf));
+               certinfo->dn = buf;
+               // Make sure there are no chars in the string that we consider invalid
+               if (certinfo->dn.find_first_of("\r\n") != std::string::npos)
+                       certinfo->dn.clear();
+
+               X509_NAME_oneline(X509_get_issuer_name(cert), buf, sizeof(buf));
+               certinfo->issuer = buf;
+               if (certinfo->issuer.find_first_of("\r\n") != std::string::npos)
+                       certinfo->issuer.clear();
 
                if (!X509_digest(cert, digest, md, &n))
                {
-                       certinfo->data.insert(std::make_pair("error","Out of memory generating fingerprint"));
+                       certinfo->error = "Out of memory generating fingerprint";
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("fingerprint",irc::hex(md, n)));
+                       certinfo->fingerprint = irc::hex(md, n);
                }
 
                if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
                {
-                       certinfo->data.insert(std::make_pair("error","Not activated, or expired certificate"));
+                       certinfo->error = "Not activated, or expired certificate";
                }
 
                X509_free(cert);
        }
-
-       void Prioritize()
-       {
-               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
-               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIORITY_AFTER, &server);
-       }
-
 };
 
 static int error_callback(const char *str, size_t len, void *u)
 {
-       ModuleSSLOpenSSL* mssl = (ModuleSSLOpenSSL*)u;
-       mssl->PublicInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
+       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
 
        //
        // XXX: Remove this line, it causes valgrind warnings...