]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
Fix the message sent when SSL profiles are rehashed.
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 0ecd8444dac239df67028ad86ca183a0786d6cb0..b34eda6bfd6e935eb5953da86dbba2b4cbb3d789 100644 (file)
@@ -1,14 +1,14 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2020 Matt Schatz <genius3000@g3k.solutions>
  *   Copyright (C) 2019 linuxdaemon <linuxdaemon.irc@gmail.com>
- *   Copyright (C) 2019 Matt Schatz <genius3000@g3k.solutions>
  *   Copyright (C) 2017 Wade Cline <wadecline@hotmail.com>
  *   Copyright (C) 2014, 2016 Adam <Adam@anope.org>
  *   Copyright (C) 2014 Julien Vehent <julien@linuxwall.info>
- *   Copyright (C) 2013-2014, 2016-2019 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013-2014, 2016-2020 Sadie Powell <sadie@witchery.services>
  *   Copyright (C) 2012-2017 Attila Molnar <attilamolnar@hush.com>
- *   Copyright (C) 2012, 2019 Robby <robby@chatbelgie.be>
+ *   Copyright (C) 2012 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2012 ChrisTX <xpipe@hotmail.de>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
  *   Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
@@ -28,7 +28,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/// $CompilerFlags: find_compiler_flags("openssl")
+/// $CompilerFlags: find_compiler_flags("openssl" "")
 /// $LinkerFlags: find_linker_flags("openssl" "-lssl -lcrypto")
 
 /// $PackageInfo: require_system("arch") openssl pkgconf
 # pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif
 
+// LibreSSL lies about the version of OpenSSL it is compatible with and is a general pain
+// to support. Support for it was removed in the master branch at the same time that
+// support for OpenSSL pre-1.1 was.
+#if defined __GNUC__ && defined LIBRESSL_VERSION_NUMBER
+# warning LibreSSL support will be discontinued in the future. Consider using the ssl_gnutls or ssl_mbedtls modules instead.
+#endif
+
 // Fix warnings about the use of `long long` on C++03.
 #if defined __clang__
 # pragma clang diagnostic ignored "-Wc++11-long-long"
@@ -251,7 +258,7 @@ namespace OpenSSL
                        X509_STORE* store = SSL_CTX_get_cert_store(ctx);
                        if (!store)
                        {
-                               throw ModuleException("Unable to get X509_STORE from SSL context; this should never happen");
+                               throw ModuleException("Unable to get X509_STORE from TLS (SSL) context; this should never happen");
                        }
                        ERR_clear_error();
                        if (!X509_STORE_load_locations(store,
@@ -979,7 +986,7 @@ class ModuleSSLOpenSSL : public Module
                        // Create a default profile named "openssl"
                        const std::string defname = "openssl";
                        ConfigTag* tag = ServerInstance->Config->ConfValue(defname);
-                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "No <sslprofile> tags found, using settings from the <openssl> tag");
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "No <sslprofile> tags found, using settings from the deprecated <openssl> tag");
 
                        try
                        {
@@ -987,34 +994,40 @@ class ModuleSSLOpenSSL : public Module
                        }
                        catch (OpenSSL::Exception& ex)
                        {
-                               throw ModuleException("Error while initializing the default SSL profile - " + ex.GetReason());
+                               throw ModuleException("Error while initializing the default TLS (SSL) profile - " + ex.GetReason());
                        }
                }
-
-               for (ConfigIter i = tags.first; i != tags.second; ++i)
+               else
                {
-                       ConfigTag* tag = i->second;
-                       if (!stdalgo::string::equalsci(tag->getString("provider"), "openssl"))
-                               continue;
-
-                       std::string name = tag->getString("name");
-                       if (name.empty())
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "You have defined an <sslprofile> tag; you should use this in place of \"openssl\" when configuring TLS (SSL) connections in <bind:ssl> or <link:ssl>");
+                       for (ConfigIter i = tags.first; i != tags.second; ++i)
                        {
-                               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Ignoring <sslprofile> tag without name at " + tag->getTagLocation());
-                               continue;
-                       }
+                               ConfigTag* tag = i->second;
+                               if (!stdalgo::string::equalsci(tag->getString("provider"), "openssl"))
+                               {
+                                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Ignoring non-OpenSSL <sslprofile> tag at " + tag->getTagLocation());
+                                       continue;
+                               }
 
-                       reference<OpenSSLIOHookProvider> prov;
-                       try
-                       {
-                               prov = new OpenSSLIOHookProvider(this, name, tag);
-                       }
-                       catch (CoreException& ex)
-                       {
-                               throw ModuleException("Error while initializing SSL profile \"" + name + "\" at " + tag->getTagLocation() + " - " + ex.GetReason());
-                       }
+                               std::string name = tag->getString("name");
+                               if (name.empty())
+                               {
+                                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Ignoring <sslprofile> tag without name at " + tag->getTagLocation());
+                                       continue;
+                               }
+
+                               reference<OpenSSLIOHookProvider> prov;
+                               try
+                               {
+                                       prov = new OpenSSLIOHookProvider(this, name, tag);
+                               }
+                               catch (CoreException& ex)
+                               {
+                                       throw ModuleException("Error while initializing TLS (SSL) profile \"" + name + "\" at " + tag->getTagLocation() + " - " + ex.GetReason());
+                               }
 
-                       newprofiles.push_back(prov);
+                               newprofiles.push_back(prov);
+                       }
                }
 
                for (ProfileList::iterator i = profiles.begin(); i != profiles.end(); ++i)
@@ -1056,13 +1069,13 @@ class ModuleSSLOpenSSL : public Module
 
        void OnModuleRehash(User* user, const std::string &param) CXX11_OVERRIDE
        {
-               if (!irc::equals(param, "ssl"))
+               if (!irc::equals(param, "tls") && !irc::equals(param, "ssl"))
                        return;
 
                try
                {
                        ReadProfiles();
-                       ServerInstance->SNO->WriteToSnoMask('a', "SSL module %s rehashed.", MODNAME);
+                       ServerInstance->SNO->WriteToSnoMask('a', "OpenSSL TLS (SSL) profiles have been reloaded.");
                }
                catch (ModuleException& ex)
                {
@@ -1078,9 +1091,9 @@ class ModuleSSLOpenSSL : public Module
 
                        if ((user) && (user->eh.GetModHook(this)))
                        {
-                               // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
-                               // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
+                               // User is using TLS (SSL), they're a local user, and they're using one of *our* TLS (SSL) ports.
+                               // Potentially there could be multiple TLS (SSL) modules loaded at once on different ports.
+                               ServerInstance->Users->QuitUser(user, "OpenSSL module unloading");
                        }
                }
        }
@@ -1095,7 +1108,7 @@ class ModuleSSLOpenSSL : public Module
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Allows TLS encrypted connections using the OpenSSL library.", VF_VENDOR);
+               return Version("Allows TLS (SSL) encrypted connections using the OpenSSL library.", VF_VENDOR);
        }
 };