]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
Remove InspIRCd* parameters and fields
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index b9e23ba0b017fff8758cf123368cd4da718acaa1..f566b326b3a41d30cb852d180238435b73e58ac4 100644 (file)
 
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
-enum issl_io_status { ISSL_WRITE, ISSL_READ };
 
 static bool SelfSigned = false;
 
-bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
-{
-       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
-               return true;
-
-       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
-               return true;
-
-       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
-}
-
 char* get_error()
 {
        return ERR_error_string(ERR_get_error(), NULL);
@@ -65,20 +53,15 @@ class issl_session : public classbase
 public:
        SSL* sess;
        issl_status status;
-       issl_io_status rstat;
-       issl_io_status wstat;
 
-       unsigned int inbufoffset;
-       char* inbuf;                    // Buffer OpenSSL reads into.
-       std::string outbuf;     // Buffer for outgoing data that OpenSSL will not take.
        int fd;
        bool outbound;
+       bool data_to_write;
 
        issl_session()
        {
                outbound = false;
-               rstat = ISSL_READ;
-               wstat = ISSL_WRITE;
+               data_to_write = false;
        }
 };
 
@@ -98,7 +81,7 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
 class ModuleSSLOpenSSL : public Module
 {
-       std::vector<std::string> listenports;
+       std::set<ListenSocketBase*> listenports;
 
        int inbufsize;
        issl_session* sessions;
@@ -106,7 +89,6 @@ class ModuleSSLOpenSSL : public Module
        SSL_CTX* ctx;
        SSL_CTX* clictx;
 
-       char* dummy;
        char cipher[MAXBUF];
 
        std::string keyfile;
@@ -116,14 +98,9 @@ class ModuleSSLOpenSSL : public Module
        std::string dhfile;
        std::string sslports;
 
-       int clientactive;
-
  public:
 
-       InspIRCd* PublicInstance;
-
-       ModuleSSLOpenSSL(InspIRCd* Me)
-       : Module(Me), PublicInstance(Me)
+       ModuleSSLOpenSSL()
        {
                ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
 
@@ -149,79 +126,56 @@ class ModuleSSLOpenSSL : public Module
                SSL_CTX_set_verify(clictx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 
                // Needs the flag as it ignores a plain /rehash
-               OnRehash(NULL,"ssl");
-               Implementation eventlist[] = { I_OnRawSocketConnect, I_OnRawSocketAccept, I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup, I_On005Numeric,
-                       I_OnBufferFlushed, I_OnRequest, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUnloadModule, I_OnRehash, I_OnWhois, I_OnPostConnect, I_OnHookUserIO };
-               ServerInstance->Modules->Attach(eventlist, this, 16);
+               OnModuleRehash(NULL,"ssl");
+               Implementation eventlist[] = {
+                       I_On005Numeric, I_OnRequest, I_OnRehash, I_OnModuleRehash, I_OnPostConnect,
+                       I_OnHookIO };
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
-       virtual void OnHookUserIO(User* user, const std::string &targetip)
+       void OnHookIO(StreamSocket* user, ListenSocketBase* lsb)
        {
-               if (!user->GetIOHook() && isin(targetip,user->GetPort(), listenports))
+               if (!user->GetIOHook() && listenports.find(lsb) != listenports.end())
                {
                        /* Hook the user with our module */
                        user->AddIOHook(this);
                }
        }
 
-       virtual void OnRehash(User* user, const std::string &param)
+       void OnRehash(User* user)
        {
-               ConfigReader Conf(ServerInstance);
+               ConfigReader Conf;
 
                listenports.clear();
-               clientactive = 0;
                sslports.clear();
 
-               for(int index = 0; index < Conf.Enumerate("bind"); index++)
+               for (size_t i = 0; i < ServerInstance->ports.size(); i++)
                {
-                       // For each <bind> tag
-                       std::string x = Conf.ReadValue("bind", "type", index);
-                       if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
-                       {
-                               // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf.ReadValue("bind", "port", index);
-                               std::string addr = Conf.ReadValue("bind", "address", index);
+                       ListenSocketBase* port = ServerInstance->ports[i];
+                       std::string desc = port->GetDescription();
+                       if (desc != "openssl")
+                               continue;
 
-                               if (!addr.empty())
-                               {
-                                       // normalize address, important for IPv6
-                                       int portint = 0;
-                                       irc::sockets::sockaddrs bin;
-                                       if (irc::sockets::aptosa(addr.c_str(), portint, &bin))
-                                               irc::sockets::satoap(addr, portint, &bin);
-                               }
+                       listenports.insert(port);
+                       std::string portid = port->GetBindDesc();
 
-                               irc::portparser portrange(port, false);
-                               long portno = -1;
-                               while ((portno = portrange.GetToken()))
-                               {
-                                       clientactive++;
-                                       try
-                                       {
-                                               listenports.push_back(addr + ":" + ConvToStr(portno));
-
-                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
-                                                       if ((ServerInstance->Config->ports[i]->GetPort() == portno) && (ServerInstance->Config->ports[i]->GetIP() == addr))
-                                                               ServerInstance->Config->ports[i]->SetDescription("ssl");
-                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %ld", portno);
-
-                                               sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
-                                       }
-                                       catch (ModuleException &e)
-                                       {
-                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
-                                       }
-                               }
-                       }
+                       ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %s", portid.c_str());
+                       if (port->GetIP() != "127.0.0.1")
+                               sslports.append(portid).append(";");
                }
 
                if (!sslports.empty())
                        sslports.erase(sslports.end() - 1);
+       }
 
+       void OnModuleRehash(User* user, const std::string &param)
+       {
                if (param != "ssl")
-               {
                        return;
-               }
+
+               OnRehash(user);
+
+               ConfigReader Conf;
 
                std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
@@ -301,12 +255,13 @@ class ModuleSSLOpenSSL : public Module
                fclose(dhpfile);
        }
 
-       virtual void On005Numeric(std::string &output)
+       void On005Numeric(std::string &output)
        {
-               output.append(" SSL=" + sslports);
+               if (!sslports.empty())
+                       output.append(" SSL=" + sslports);
        }
 
-       virtual ~ModuleSSLOpenSSL()
+       ~ModuleSSLOpenSSL()
        {
                SSL_CTX_free(ctx);
                SSL_CTX_free(clictx);
@@ -314,7 +269,7 @@ class ModuleSSLOpenSSL : public Module
                delete[] sessions;
        }
 
-       virtual void OnCleanup(int target_type, void* item)
+       void OnCleanup(int target_type, void* item)
        {
                if (target_type == TYPE_USER)
                {
@@ -327,36 +282,16 @@ class ModuleSSLOpenSSL : public Module
                                ServerInstance->Users->QuitUser(user, "SSL module unloading");
                                user->DelIOHook();
                        }
-                       if (user->GetExt("ssl_cert", dummy))
-                       {
-                               ssl_cert* tofree;
-                               user->GetExt("ssl_cert", tofree);
-                               delete tofree;
-                               user->Shrink("ssl_cert");
-                       }
                }
        }
 
-       virtual void OnUnloadModule(Module* mod, const std::string &name)
+       Version GetVersion()
        {
-               if (mod == this)
-               {
-                       for(unsigned int i = 0; i < listenports.size(); i++)
-                       {
-                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
-                                       if (listenports[i] == (ServerInstance->Config->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->Config->ports[j]->GetPort())))
-                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
-                       }
-               }
-       }
-
-       virtual Version GetVersion()
-       {
-               return Version("$Id$", VF_VENDOR, API_VERSION);
+               return Version("Provides SSL support for clients", VF_VENDOR, API_VERSION);
        }
 
 
-       virtual const char* OnRequest(Request* request)
+       const char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
                if (strcmp("IS_NAME", request->GetId()) == 0)
@@ -365,21 +300,13 @@ class ModuleSSLOpenSSL : public Module
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       const char* ret = "OK";
-                       try
-                       {
-                               ret = ISR->Sock->AddIOHook((Module*)this) ? "OK" : NULL;
-                       }
-                       catch (ModuleException &e)
-                       {
-                               return NULL;
-                       }
-
-                       return ret;
+                       ISR->Sock->AddIOHook(this);
+                       return "OK";
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ISR->Sock->DelIOHook() ? "OK" : NULL;
+                       ISR->Sock->DelIOHook();
+                       return "OK";
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
@@ -394,25 +321,26 @@ class ModuleSSLOpenSSL : public Module
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
                        if (session->sess)
                        {
-                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                return "OK";
                        }
                }
+               else if (strcmp("GET_CERT", request->GetId()) == 0)
+               {
+                       Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
+                       if (sslinfo)
+                               return sslinfo->OnRequest(request);
+               }
                return NULL;
        }
 
 
-       virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
+       void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return;
+               int fd = user->GetFd();
 
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
-               session->inbuf = new char[inbufsize];
-               session->inbufoffset = 0;
                session->sess = SSL_new(ctx);
                session->status = ISSL_NONE;
                session->outbound = false;
@@ -426,11 +354,12 @@ class ModuleSSLOpenSSL : public Module
                        return;
                }
 
-               Handshake(session);
+               Handshake(user, session);
        }
 
-       virtual void OnRawSocketConnect(int fd)
+       void OnStreamSocketConnect(StreamSocket* user)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
                        return;
@@ -438,8 +367,6 @@ class ModuleSSLOpenSSL : public Module
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
-               session->inbuf = new char[inbufsize];
-               session->inbufoffset = 0;
                session->sess = SSL_new(clictx);
                session->status = ISSL_NONE;
                session->outbound = true;
@@ -453,58 +380,43 @@ class ModuleSSLOpenSSL : public Module
                        return;
                }
 
-               Handshake(session);
+               Handshake(user, session);
        }
 
-       virtual void OnRawSocketClose(int fd)
+       void OnStreamSocketClose(StreamSocket* user)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
                        return;
 
                CloseSession(&sessions[fd]);
-
-               EventHandler* user = ServerInstance->SE->GetRef(fd);
-
-               if ((user) && (user->GetExt("ssl_cert", dummy)))
-               {
-                       ssl_cert* tofree;
-                       user->GetExt("ssl_cert", tofree);
-                       delete tofree;
-                       user->Shrink("ssl_cert");
-               }
        }
 
-       virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
+       int OnStreamSocketRead(StreamSocket* user, std::string& recvq)
        {
+               int fd = user->GetFd();
                /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
                if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
+                       return -1;
 
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
                {
-                       readresult = 0;
                        CloseSession(session);
-                       return 1;
+                       return -1;
                }
 
                if (session->status == ISSL_HANDSHAKING)
                {
-                       if (session->rstat == ISSL_READ || session->wstat == ISSL_READ)
+                       // The handshake isn't finished and it wants to read, try to finish it.
+                       if (!Handshake(user, session))
                        {
-                               // The handshake isn't finished and it wants to read, try to finish it.
-                               if (!Handshake(session))
-                               {
-                                       // Couldn't resume handshake.
+                               // Couldn't resume handshake.
+                               if (session->status == ISSL_NONE)
                                        return -1;
-                               }
-                       }
-                       else
-                       {
-                               errno = EAGAIN;
-                               return -1;
+                               return 0;
                        }
                }
 
@@ -512,51 +424,49 @@ class ModuleSSLOpenSSL : public Module
 
                if (session->status == ISSL_OPEN)
                {
-                       if (session->wstat == ISSL_READ)
+                       char* buffer = ServerInstance->GetReadBuffer();
+                       size_t bufsiz = ServerInstance->Config->NetBufferSize;
+                       int ret = SSL_read(session->sess, buffer, bufsiz);
+                       
+                       if (ret > 0)
                        {
-                               if(DoWrite(session) == 0)
-                                       return 0;
+                               recvq.append(buffer, ret);
+                               return 1;
                        }
-
-                       if (session->rstat == ISSL_READ)
+                       else if (ret == 0)
                        {
-                               int ret = DoRead(session);
+                               // Client closed connection.
+                               CloseSession(session);
+                               return -1;
+                       }
+                       else if (ret < 0)
+                       {
+                               int err = SSL_get_error(session->sess, ret);
 
-                               if (ret > 0)
+                               if (err == SSL_ERROR_WANT_READ)
                                {
-                                       if (count <= session->inbufoffset)
-                                       {
-                                               memcpy(buffer, session->inbuf, count);
-                                               // Move the stuff left in inbuf to the beginning of it
-                                               memmove(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
-                                               // Now we need to set session->inbufoffset to the amount of data still waiting to be handed to insp.
-                                               session->inbufoffset -= count;
-                                               // Insp uses readresult as the count of how much data there is in buffer, so:
-                                               readresult = count;
-                                       }
-                                       else
-                                       {
-                                               // There's not as much in the inbuf as there is space in the buffer, so just copy the whole thing.
-                                               memcpy(buffer, session->inbuf, session->inbufoffset);
-
-                                               readresult = session->inbufoffset;
-                                               // Zero the offset, as there's nothing there..
-                                               session->inbufoffset = 0;
-                                       }
-                                       return 1;
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ);
+                                       return 0;
+                               }
+                               else if (err == SSL_ERROR_WANT_WRITE)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
+                                       return 0;
+                               }
+                               else
+                               {
+                                       CloseSession(session);
+                                       return -1;
                                }
-                               return ret;
                        }
                }
 
-               return -1;
+               return 0;
        }
 
-       virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
+       int OnStreamSocketWrite(StreamSocket* user, std::string& buffer)
        {
-               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
-               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
-                       return 0;
+               int fd = user->GetFd();
 
                issl_session* session = &sessions[fd];
 
@@ -566,162 +476,64 @@ class ModuleSSLOpenSSL : public Module
                        return -1;
                }
 
-               session->outbuf.append(buffer, count);
-               MakePollWrite(session);
+               session->data_to_write = true;
 
                if (session->status == ISSL_HANDSHAKING)
                {
-                       // The handshake isn't finished, try to finish it.
-                       if (session->rstat == ISSL_WRITE || session->wstat == ISSL_WRITE)
+                       if (!Handshake(user, session))
                        {
-                               Handshake(session);
+                               // Couldn't resume handshake.
+                               if (session->status == ISSL_NONE)
+                                       return -1;
+                               return 0;
                        }
                }
 
                if (session->status == ISSL_OPEN)
                {
-                       if (session->rstat == ISSL_WRITE)
-                       {
-                               DoRead(session);
-                       }
-
-                       if (session->wstat == ISSL_WRITE)
-                       {
-                               return DoWrite(session);
-                       }
-               }
-
-               return 1;
-       }
-
-       int DoWrite(issl_session* session)
-       {
-               if (!session->outbuf.size())
-                       return -1;
-
-               int ret = SSL_write(session->sess, session->outbuf.data(), session->outbuf.size());
-
-               if (ret == 0)
-               {
-                       CloseSession(session);
-                       return 0;
-               }
-               else if (ret < 0)
-               {
-                       int err = SSL_get_error(session->sess, ret);
-
-                       if (err == SSL_ERROR_WANT_WRITE)
-                       {
-                               session->wstat = ISSL_WRITE;
-                               return -1;
-                       }
-                       else if (err == SSL_ERROR_WANT_READ)
+                       int ret = SSL_write(session->sess, buffer.data(), buffer.size());
+                       if (ret == (int)buffer.length())
                        {
-                               session->wstat = ISSL_READ;
-                               return -1;
+                               session->data_to_write = false;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+                               return 1;
                        }
-                       else
+                       else if (ret > 0)
                        {
-                               CloseSession(session);
+                               buffer = buffer.substr(ret);
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
                                return 0;
                        }
-               }
-               else
-               {
-                       session->outbuf = session->outbuf.substr(ret);
-                       return ret;
-               }
-       }
-
-       int DoRead(issl_session* session)
-       {
-               // Is this right? Not sure if the unencrypted data is garaunteed to be the same length.
-               // Read into the inbuffer, offset from the beginning by the amount of data we have that insp hasn't taken yet.
-
-               int ret = SSL_read(session->sess, session->inbuf + session->inbufoffset, inbufsize - session->inbufoffset);
-
-               if (ret == 0)
-               {
-                       // Client closed connection.
-                       CloseSession(session);
-                       return 0;
-               }
-               else if (ret < 0)
-               {
-                       int err = SSL_get_error(session->sess, ret);
-
-                       if (err == SSL_ERROR_WANT_READ)
+                       else if (ret == 0)
                        {
-                               session->rstat = ISSL_READ;
-                               return -1;
-                       }
-                       else if (err == SSL_ERROR_WANT_WRITE)
-                       {
-                               session->rstat = ISSL_WRITE;
-                               MakePollWrite(session);
+                               CloseSession(session);
                                return -1;
                        }
-                       else
+                       else if (ret < 0)
                        {
-                               CloseSession(session);
-                               return 0;
-                       }
-               }
-               else
-               {
-                       // Read successfully 'ret' bytes into inbuf + inbufoffset
-                       // There are 'ret' + 'inbufoffset' bytes of data in 'inbuf'
-                       // 'buffer' is 'count' long
-
-                       session->inbufoffset += ret;
-
-                       return ret;
-               }
-       }
+                               int err = SSL_get_error(session->sess, ret);
 
-       // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(User* source, User* dest)
-       {
-               if (!clientactive)
-                       return;
-
-               // Bugfix, only send this numeric for *our* SSL users
-               if (dest->GetExt("ssl", dummy))
-               {
-                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick.c_str(), dest->nick.c_str());
-               }
-       }
-
-       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
-       {
-               // check if the linking module wants to know about OUR metadata
-               if (extname == "ssl")
-               {
-                       // check if this user has an swhois field to send
-                       if(user->GetExt(extname, dummy))
-                       {
-                               // call this function in the linking module, let it format the data how it
-                               // sees fit, and send it on its way. We dont need or want to know how.
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, displayable ? "Enabled" : "ON");
-                       }
-               }
-       }
-
-       virtual void OnDecodeMetaData(int target_type, void* target, const std::string &extname, const std::string &extdata)
-       {
-               // check if its our metadata key, and its associated with a user
-               if ((target_type == TYPE_USER) && (extname == "ssl"))
-               {
-                       User* dest = (User*)target;
-                       // if they dont already have an ssl flag, accept the remote server's
-                       if (!dest->GetExt(extname, dummy))
-                       {
-                               dest->Extend(extname, "ON");
+                               if (err == SSL_ERROR_WANT_WRITE)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
+                                       return 0;
+                               }
+                               else if (err == SSL_ERROR_WANT_READ)
+                               {
+                                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+                                       return 0;
+                               }
+                               else
+                               {
+                                       CloseSession(session);
+                                       return -1;
+                               }
                        }
                }
+               return 0;
        }
 
-       bool Handshake(issl_session* session)
+       bool Handshake(EventHandler* user, issl_session* session)
        {
                int ret;
 
@@ -736,15 +548,14 @@ class ModuleSSLOpenSSL : public Module
 
                        if (err == SSL_ERROR_WANT_READ)
                        {
-                               session->rstat = ISSL_READ;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
                                session->status = ISSL_HANDSHAKING;
                                return true;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
-                               session->wstat = ISSL_WRITE;
+                               ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
                                session->status = ISSL_HANDSHAKING;
-                               MakePollWrite(session);
                                return true;
                        }
                        else
@@ -757,17 +568,11 @@ class ModuleSSLOpenSSL : public Module
                else if (ret > 0)
                {
                        // Handshake complete.
-                       // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       User* u = ServerInstance->FindDescriptor(session->fd);
-                       if (u)
-                       {
-                               if (!u->GetExt("ssl", dummy))
-                                       u->Extend("ssl", "ON");
-                       }
+                       VerifyCertificate(session, user);
 
                        session->status = ISSL_OPEN;
 
-                       MakePollWrite(session);
+                       ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
 
                        return true;
                }
@@ -780,41 +585,6 @@ class ModuleSSLOpenSSL : public Module
                return true;
        }
 
-       virtual void OnPostConnect(User* user)
-       {
-               // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propagated the NICK message.
-               if ((user->GetIOHook() == this) && (IS_LOCAL(user)))
-               {
-                       // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
-                       ServerInstance->PI->SendMetaData(user, TYPE_USER, "ssl", "on");
-
-                       VerifyCertificate(&sessions[user->GetFd()], user);
-                       if (sessions[user->GetFd()].sess)
-                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->GetFd()].sess));
-               }
-       }
-
-       void MakePollWrite(issl_session* session)
-       {
-               //OnRawSocketWrite(session->fd, NULL, 0);
-               EventHandler* eh = ServerInstance->FindDescriptor(session->fd);
-               if (eh)
-               {
-                       ServerInstance->SE->WantWrite(eh);
-               }
-       }
-
-       virtual void OnBufferFlushed(User* user)
-       {
-               if (user->GetIOHook() == this)
-               {
-                       issl_session* session = &sessions[user->GetFd()];
-                       if (session && session->outbuf.size())
-                               OnRawSocketWrite(user->GetFd(), NULL, 0);
-               }
-       }
-
        void CloseSession(issl_session* session)
        {
                if (session->sess)
@@ -823,15 +593,9 @@ class ModuleSSLOpenSSL : public Module
                        SSL_free(session->sess);
                }
 
-               if (session->inbuf)
-               {
-                       delete[] session->inbuf;
-               }
-
-               session->outbuf.clear();
-               session->inbuf = NULL;
                session->sess = NULL;
                session->status = ISSL_NONE;
+               errno = EIO;
        }
 
        void VerifyCertificate(issl_session* session, Extensible* user)
@@ -839,53 +603,57 @@ class ModuleSSLOpenSSL : public Module
                if (!session->sess || !user)
                        return;
 
+               Module* sslinfo = ServerInstance->Modules->Find("m_sslinfo.so");
+               if (!sslinfo)
+                       return;
+
                X509* cert;
                ssl_cert* certinfo = new ssl_cert;
                unsigned int n;
                unsigned char md[EVP_MAX_MD_SIZE];
                const EVP_MD *digest = EVP_md5();
 
-               user->Extend("ssl_cert",certinfo);
-
                cert = SSL_get_peer_certificate((SSL*)session->sess);
 
                if (!cert)
                {
-                       certinfo->data.insert(std::make_pair("error","Could not get peer certificate: "+std::string(get_error())));
+                       certinfo->error = "Could not get peer certificate: "+std::string(get_error());
+                       BufferedSocketFingerprintSubmission(user, this, sslinfo, certinfo).Send();
                        return;
                }
 
-               certinfo->data.insert(std::make_pair("invalid", SSL_get_verify_result(session->sess) != X509_V_OK ? ConvToStr(1) : ConvToStr(0)));
+               certinfo->invalid = (SSL_get_verify_result(session->sess) != X509_V_OK);
 
                if (SelfSigned)
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(0)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(1)));
+                       certinfo->unknownsigner = false;
+                       certinfo->trusted = true;
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(1)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(0)));
+                       certinfo->unknownsigner = true;
+                       certinfo->trusted = false;
                }
 
-               certinfo->data.insert(std::make_pair("dn",std::string(X509_NAME_oneline(X509_get_subject_name(cert),0,0))));
-               certinfo->data.insert(std::make_pair("issuer",std::string(X509_NAME_oneline(X509_get_issuer_name(cert),0,0))));
+               certinfo->dn = X509_NAME_oneline(X509_get_subject_name(cert),0,0);
+               certinfo->issuer = X509_NAME_oneline(X509_get_issuer_name(cert),0,0);
 
                if (!X509_digest(cert, digest, md, &n))
                {
-                       certinfo->data.insert(std::make_pair("error","Out of memory generating fingerprint"));
+                       certinfo->error = "Out of memory generating fingerprint";
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("fingerprint",irc::hex(md, n)));
+                       certinfo->fingerprint = irc::hex(md, n);
                }
 
                if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
                {
-                       certinfo->data.insert(std::make_pair("error","Not activated, or expired certificate"));
+                       certinfo->error = "Not activated, or expired certificate";
                }
 
                X509_free(cert);
+               BufferedSocketFingerprintSubmission(user, this, sslinfo, certinfo).Send();
        }
 
        void Prioritize()
@@ -898,8 +666,7 @@ class ModuleSSLOpenSSL : public Module
 
 static int error_callback(const char *str, size_t len, void *u)
 {
-       ModuleSSLOpenSSL* mssl = (ModuleSSLOpenSSL*)u;
-       mssl->PublicInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
+       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
 
        //
        // XXX: Remove this line, it causes valgrind warnings...