]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/extra/m_ssl_openssl.cpp
Change OnHookUserIO to OnHookIO, making it usable for more than User* and less picky...
[user/henk/code/inspircd.git] / src / modules / extra / m_ssl_openssl.cpp
index 1d323e3b8be5d2282f6e52f623de8b60aa187e07..fc0de61f4a8d55e7bcd9869b1c49b6c4b9be90b3 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  */
 
 #include "inspircd.h"
-
 #include <openssl/ssl.h>
 #include <openssl/err.h>
-
-#ifdef WINDOWS
-#include <openssl/applink.c>
-#endif
-
-#include "configreader.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
-
-#include "socket.h"
-#include "hashcomp.h"
-
 #include "transport.h"
 
 #ifdef WINDOWS
 #endif
 
 /* $ModDesc: Provides SSL support for clients */
-/* $CompileFlags: pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
-/* $LinkerFlags: rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto -ldl") */
+
+/* $LinkerFlags: if("USE_FREEBSD_BASE_SSL") -lssl -lcrypto */
+/* $CompileFlags: if(!"USE_FREEBSD_BASE_SSL") pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
+/* $LinkerFlags: if(!"USE_FREEBSD_BASE_SSL") rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto -ldl") */
+
 /* $ModDep: transport.h */
+/* $NoPedantic */
+/* $CopyInstall: conf/key.pem $(CONPATH) */
+/* $CopyInstall: conf/cert.pem $(CONPATH) */
+
 
 enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
 enum issl_io_status { ISSL_WRITE, ISSL_READ };
 
 static bool SelfSigned = false;
 
-bool isin(int port, const std::vector<int> &portlist)
+bool isin(const std::string &host, int port, const std::vector<std::string> &portlist)
 {
-       for(unsigned int i = 0; i < portlist.size(); i++)
-               if(portlist[i] == port)
-                       return true;
+       if (std::find(portlist.begin(), portlist.end(), "*:" + ConvToStr(port)) != portlist.end())
+               return true;
+
+       if (std::find(portlist.begin(), portlist.end(), ":" + ConvToStr(port)) != portlist.end())
+               return true;
 
-       return false;
+       return std::find(portlist.begin(), portlist.end(), host + ":" + ConvToStr(port)) != portlist.end();
 }
 
 char* get_error()
@@ -74,7 +69,7 @@ public:
        issl_io_status wstat;
 
        unsigned int inbufoffset;
-       char* inbuf;                    // Buffer OpenSSL reads into.
+       char* inbuf;                    // Buffer OpenSSL reads into.
        std::string outbuf;     // Buffer for outgoing data that OpenSSL will not take.
        int fd;
        bool outbound;
@@ -103,13 +98,10 @@ static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 
 class ModuleSSLOpenSSL : public Module
 {
-
-       ConfigReader* Conf;
-
-       std::vector<int> listenports;
+       std::vector<std::string> listenports;
 
        int inbufsize;
-       issl_session sessions[MAX_DESCRIPTORS];
+       issl_session* sessions;
 
        SSL_CTX* ctx;
        SSL_CTX* clictx;
@@ -131,9 +123,11 @@ class ModuleSSLOpenSSL : public Module
        InspIRCd* PublicInstance;
 
        ModuleSSLOpenSSL(InspIRCd* Me)
-               : Module(Me), PublicInstance(Me)
+       : Module(Me), PublicInstance(Me)
        {
-               ServerInstance->PublishInterface("InspSocketHook", this);
+               ServerInstance->Modules->PublishInterface("BufferedSocketHook", this);
+
+               sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 
                // Not rehashable...because I cba to reduce all the sizes of existing buffers.
                inbufsize = ServerInstance->Config->NetBufferSize;
@@ -148,37 +142,57 @@ class ModuleSSLOpenSSL : public Module
                ctx = SSL_CTX_new( SSLv23_server_method() );
                clictx = SSL_CTX_new( SSLv23_client_method() );
 
+               SSL_CTX_set_mode(ctx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
+               SSL_CTX_set_mode(clictx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
+
                SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
                SSL_CTX_set_verify(clictx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 
                // Needs the flag as it ignores a plain /rehash
-               OnRehash(NULL,"ssl");
+               OnModuleRehash(NULL,"ssl");
+               Implementation eventlist[] = { I_OnRawSocketConnect, I_OnRawSocketAccept,
+                       I_OnRawSocketClose, I_OnRawSocketRead, I_OnRawSocketWrite, I_OnCleanup, I_On005Numeric,
+                       I_OnBufferFlushed, I_OnRequest, I_OnUnloadModule, I_OnRehash, I_OnModuleRehash,
+                       I_OnPostConnect, I_OnHookIO };
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
-       virtual void OnRehash(userrec* user, const std::string &param)
+       virtual void OnHookIO(EventHandler* user, ListenSocketBase* lsb)
        {
-               if (param != "ssl")
-                       return;
-
-               Conf = new ConfigReader(ServerInstance);
-
-               for (unsigned int i = 0; i < listenports.size(); i++)
+               if (!user->GetIOHook() && isin(lsb->GetIP(),lsb->GetPort(),listenports))
                {
-                       ServerInstance->Config->DelIOHook(listenports[i]);
+                       /* Hook the user with our module */
+                       user->AddIOHook(this);
                }
+       }
+
+       virtual void OnRehash(User* user)
+       {
+               ConfigReader Conf(ServerInstance);
 
                listenports.clear();
                clientactive = 0;
                sslports.clear();
 
-               for (int i = 0; i < Conf->Enumerate("bind"); i++)
+               for(int index = 0; index < Conf.Enumerate("bind"); index++)
                {
                        // For each <bind> tag
-                       std::string x = Conf->ReadValue("bind", "type", i);
-                       if (((x.empty()) || (x == "clients")) && (Conf->ReadValue("bind", "ssl", i) == "openssl"))
+                       std::string x = Conf.ReadValue("bind", "type", index);
+                       if(((x.empty()) || (x == "clients")) && (Conf.ReadValue("bind", "ssl", index) == "openssl"))
                        {
                                // Get the port we're meant to be listening on with SSL
-                               std::string port = Conf->ReadValue("bind", "port", i);
+                               std::string port = Conf.ReadValue("bind", "port", index);
+                               std::string addr = Conf.ReadValue("bind", "address", index);
+
+                               if (!addr.empty())
+                               {
+                                       // normalize address, important for IPv6
+                                       int portint = 0;
+                                       irc::sockets::sockaddrs bin;
+                                       if (irc::sockets::aptosa(addr.c_str(), portint, &bin))
+                                               irc::sockets::satoap(&bin, addr, portint);
+                               }
+
                                irc::portparser portrange(port, false);
                                long portno = -1;
                                while ((portno = portrange.GetToken()))
@@ -186,23 +200,19 @@ class ModuleSSLOpenSSL : public Module
                                        clientactive++;
                                        try
                                        {
-                                               if (ServerInstance->Config->AddIOHook(portno, this))
-                                               {
-                                                       listenports.push_back(portno);
-                                                               for (size_t i = 0; i < ServerInstance->Config->ports.size(); i++)
-                                                               if (ServerInstance->Config->ports[i]->GetPort() == portno)
-                                                                       ServerInstance->Config->ports[i]->SetDescription("ssl");
-                                                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %d", portno);
-                                                       sslports.append("*:").append(ConvToStr(portno)).append(";");
-                                               }
-                                               else
-                                               {
-                                                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %d, maybe you have another ssl or similar module loaded?", portno);
-                                               }
+                                               listenports.push_back(addr + ":" + ConvToStr(portno));
+
+                                               for (size_t i = 0; i < ServerInstance->ports.size(); i++)
+                                                       if ((ServerInstance->ports[i]->GetPort() == portno) && (ServerInstance->ports[i]->GetIP() == addr))
+                                                               ServerInstance->ports[i]->SetDescription("ssl");
+                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %ld", portno);
+
+                                               if (addr != "127.0.0.1")
+                                                       sslports.append((addr.empty() ? "*" : addr)).append(":").append(ConvToStr(portno)).append(";");
                                        }
                                        catch (ModuleException &e)
                                        {
-                                               ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %d: %s. Maybe it's already hooked by the same port on a different IP, or you have another SSL or similar module loaded?", portno, e.GetReason());
+                                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: FAILED to enable SSL on port %ld: %s. Maybe it's already hooked by the same port on a different IP, or you have an other SSL or similar module loaded?", portno, e.GetReason());
                                        }
                                }
                        }
@@ -210,15 +220,25 @@ class ModuleSSLOpenSSL : public Module
 
                if (!sslports.empty())
                        sslports.erase(sslports.end() - 1);
+       }
+
+       virtual void OnModuleRehash(User* user, const std::string &param)
+       {
+               if (param != "ssl")
+                       return;
+
+               OnRehash(user);
+
+               ConfigReader Conf(ServerInstance);
 
                std::string confdir(ServerInstance->ConfigFileName);
                // +1 so we the path ends with a /
                confdir = confdir.substr(0, confdir.find_last_of('/') + 1);
 
-               cafile   = Conf->ReadValue("openssl", "cafile", 0);
-               certfile = Conf->ReadValue("openssl", "certfile", 0);
-               keyfile  = Conf->ReadValue("openssl", "keyfile", 0);
-               dhfile   = Conf->ReadValue("openssl", "dhfile", 0);
+               cafile   = Conf.ReadValue("openssl", "cafile", 0);
+               certfile = Conf.ReadValue("openssl", "certfile", 0);
+               keyfile  = Conf.ReadValue("openssl", "keyfile", 0);
+               dhfile   = Conf.ReadValue("openssl", "dhfile", 0);
 
                // Set all the default values needed.
                if (cafile.empty())
@@ -234,16 +254,16 @@ class ModuleSSLOpenSSL : public Module
                        dhfile = "dhparams.pem";
 
                // Prepend relative paths with the path to the config directory.
-               if (cafile[0] != '/')
+               if ((cafile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(cafile)))
                        cafile = confdir + cafile;
 
-               if (certfile[0] != '/')
+               if ((certfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(certfile)))
                        certfile = confdir + certfile;
 
-               if (keyfile[0] != '/')
+               if ((keyfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(keyfile)))
                        keyfile = confdir + keyfile;
 
-               if (dhfile[0] != '/')
+               if ((dhfile[0] != '/') && (!ServerInstance->Config->StartsWithWindowsDriveLetter(dhfile)))
                        dhfile = confdir + dhfile;
 
                /* Load our keys and certificates
@@ -251,20 +271,20 @@ class ModuleSSLOpenSSL : public Module
                 */
                if ((!SSL_CTX_use_certificate_chain_file(ctx, certfile.c_str())) || (!SSL_CTX_use_certificate_chain_file(clictx, certfile.c_str())))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s. %s", certfile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s. %s", certfile.c_str(), strerror(errno));
                        ERR_print_errors_cb(error_callback, this);
                }
 
                if (((!SSL_CTX_use_PrivateKey_file(ctx, keyfile.c_str(), SSL_FILETYPE_PEM))) || (!SSL_CTX_use_PrivateKey_file(clictx, keyfile.c_str(), SSL_FILETYPE_PEM)))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read key file %s. %s", keyfile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read key file %s. %s", keyfile.c_str(), strerror(errno));
                        ERR_print_errors_cb(error_callback, this);
                }
 
                /* Load the CAs we trust*/
                if (((!SSL_CTX_load_verify_locations(ctx, cafile.c_str(), 0))) || (!SSL_CTX_load_verify_locations(clictx, cafile.c_str(), 0)))
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. %s", cafile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. %s", cafile.c_str(), strerror(errno));
                        ERR_print_errors_cb(error_callback, this);
                }
 
@@ -273,7 +293,7 @@ class ModuleSSLOpenSSL : public Module
 
                if (dhpfile == NULL)
                {
-                       ServerInstance->Log(DEFAULT, "m_ssl_openssl.so Couldn't open DH file %s: %s", dhfile.c_str(), strerror(errno));
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so Couldn't open DH file %s: %s", dhfile.c_str(), strerror(errno));
                        throw ModuleException("Couldn't open DH file " + dhfile + ": " + strerror(errno));
                }
                else
@@ -281,14 +301,12 @@ class ModuleSSLOpenSSL : public Module
                        ret = PEM_read_DHparams(dhpfile, NULL, NULL, NULL);
                        if ((SSL_CTX_set_tmp_dh(ctx, ret) < 0) || (SSL_CTX_set_tmp_dh(clictx, ret) < 0))
                        {
-                               ServerInstance->Log(DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
+                               ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
                                ERR_print_errors_cb(error_callback, this);
                        }
                }
 
                fclose(dhpfile);
-
-               DELETE(Conf);
        }
 
        virtual void On005Numeric(std::string &output)
@@ -300,21 +318,24 @@ class ModuleSSLOpenSSL : public Module
        {
                SSL_CTX_free(ctx);
                SSL_CTX_free(clictx);
+               ServerInstance->Modules->UnpublishInterface("BufferedSocketHook", this);
+               delete[] sessions;
        }
 
        virtual void OnCleanup(int target_type, void* item)
        {
                if (target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
+                       User* user = (User*)item;
 
-                       if (user->GetExt("ssl", dummy) && IS_LOCAL(user) && isin(user->GetPort(), listenports))
+                       if (user->GetIOHook() == this)
                        {
                                // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
                                // Potentially there could be multiple SSL modules loaded at once on different ports.
-                               ServerInstance->GlobalCulls.AddItem(user, "SSL module unloading");
+                               ServerInstance->Users->QuitUser(user, "SSL module unloading");
+                               user->DelIOHook();
                        }
-                       if (user->GetExt("ssl_cert", dummy) && isin(user->GetPort(), listenports))
+                       if (user->GetExt("ssl_cert", dummy))
                        {
                                ssl_cert* tofree;
                                user->GetExt("ssl_cert", tofree);
@@ -330,26 +351,20 @@ class ModuleSSLOpenSSL : public Module
                {
                        for(unsigned int i = 0; i < listenports.size(); i++)
                        {
-                               ServerInstance->Config->DelIOHook(listenports[i]);
-                               for (size_t j = 0; j < ServerInstance->Config->ports.size(); j++)
-                                       if (ServerInstance->Config->ports[j]->GetPort() == listenports[i])
-                                               ServerInstance->Config->ports[j]->SetDescription("plaintext");
+                               for (size_t j = 0; j < ServerInstance->ports.size(); j++)
+                                       if (listenports[i] == (ServerInstance->ports[j]->GetIP()+":"+ConvToStr(ServerInstance->ports[j]->GetPort())))
+                                               ServerInstance->ports[j]->SetDescription("plaintext");
                        }
                }
        }
 
        virtual Version GetVersion()
        {
-               return Version(1, 1, 0, 0, VF_VENDOR, API_VERSION);
+               return Version("$Id$", VF_VENDOR, API_VERSION);
        }
 
-       void Implements(char* List)
-       {
-               List[I_OnRawSocketConnect] = List[I_OnRawSocketAccept] = List[I_OnRawSocketClose] = List[I_OnRawSocketRead] = List[I_OnRawSocketWrite] = List[I_OnCleanup] = List[I_On005Numeric] = 1;
-               List[I_OnRequest] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUnloadModule] = List[I_OnRehash] = List[I_OnWhois] = List[I_OnPostConnect] = 1;
-       }
 
-       virtual char* OnRequest(Request* request)
+       virtual const char* OnRequest(Request* request)
        {
                ISHRequest* ISR = (ISHRequest*)request;
                if (strcmp("IS_NAME", request->GetId()) == 0)
@@ -358,10 +373,10 @@ class ModuleSSLOpenSSL : public Module
                }
                else if (strcmp("IS_HOOK", request->GetId()) == 0)
                {
-                       char* ret = "OK";
+                       const char* ret = "OK";
                        try
                        {
-                               ret = ServerInstance->Config->AddIOHook((Module*)this, (InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                               ret = ISR->Sock->AddIOHook((Module*)this) ? "OK" : NULL;
                        }
                        catch (ModuleException &e)
                        {
@@ -372,31 +387,49 @@ class ModuleSSLOpenSSL : public Module
                }
                else if (strcmp("IS_UNHOOK", request->GetId()) == 0)
                {
-                       return ServerInstance->Config->DelIOHook((InspSocket*)ISR->Sock) ? (char*)"OK" : NULL;
+                       return ISR->Sock->DelIOHook() ? "OK" : NULL;
                }
                else if (strcmp("IS_HSDONE", request->GetId()) == 0)
                {
                        if (ISR->Sock->GetFd() < 0)
-                               return (char*)"OK";
+                               return "OK";
 
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
-                       return (session->status == ISSL_HANDSHAKING) ? NULL : (char*)"OK";
+                       return (session->status == ISSL_HANDSHAKING) ? NULL : "OK";
                }
                else if (strcmp("IS_ATTACH", request->GetId()) == 0)
                {
                        issl_session* session = &sessions[ISR->Sock->GetFd()];
                        if (session->sess)
                        {
-                               VerifyCertificate(session, (InspSocket*)ISR->Sock);
+                               VerifyCertificate(session, (BufferedSocket*)ISR->Sock);
                                return "OK";
                        }
                }
+               else if (strcmp("GET_FP", request->GetId()) == 0)
+               {
+                       if (ISR->Sock->GetFd() > -1)
+                       {
+                               issl_session* session = &sessions[ISR->Sock->GetFd()];
+                               if (session->sess)
+                               {
+                                       Extensible* ext = ISR->Sock;
+                                       ssl_cert* certinfo;
+                                       if (ext->GetExt("ssl_cert",certinfo))
+                                               return certinfo->GetFingerprint().c_str();
+                               }
+                       }
+               }
                return NULL;
        }
 
 
-       virtual void OnRawSocketAccept(int fd, const std::string &ip, int localport)
+       virtual void OnRawSocketAccept(int fd, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -411,7 +444,7 @@ class ModuleSSLOpenSSL : public Module
 
                if (SSL_set_fd(session->sess, fd) == 0)
                {
-                       ServerInstance->Log(DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
                        return;
                }
 
@@ -420,6 +453,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketConnect(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
+                       return;
+
                issl_session* session = &sessions[fd];
 
                session->fd = fd;
@@ -434,7 +471,7 @@ class ModuleSSLOpenSSL : public Module
 
                if (SSL_set_fd(session->sess, fd) == 0)
                {
-                       ServerInstance->Log(DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
+                       ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
                        return;
                }
 
@@ -443,6 +480,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual void OnRawSocketClose(int fd)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return;
+
                CloseSession(&sessions[fd]);
 
                EventHandler* user = ServerInstance->SE->GetRef(fd);
@@ -458,6 +499,10 @@ class ModuleSSLOpenSSL : public Module
 
        virtual int OnRawSocketRead(int fd, char* buffer, unsigned int count, int &readresult)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return 0;
+
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -475,11 +520,13 @@ class ModuleSSLOpenSSL : public Module
                                if (!Handshake(session))
                                {
                                        // Couldn't resume handshake.
+                                       errno = session->status == ISSL_NONE ? EIO : EAGAIN;
                                        return -1;
                                }
                        }
                        else
                        {
+                               errno = EAGAIN;
                                return -1;
                        }
                }
@@ -504,7 +551,7 @@ class ModuleSSLOpenSSL : public Module
                                        {
                                                memcpy(buffer, session->inbuf, count);
                                                // Move the stuff left in inbuf to the beginning of it
-                                               memcpy(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
+                                               memmove(session->inbuf, session->inbuf + count, (session->inbufoffset - count));
                                                // Now we need to set session->inbufoffset to the amount of data still waiting to be handed to insp.
                                                session->inbufoffset -= count;
                                                // Insp uses readresult as the count of how much data there is in buffer, so:
@@ -519,13 +566,9 @@ class ModuleSSLOpenSSL : public Module
                                                // Zero the offset, as there's nothing there..
                                                session->inbufoffset = 0;
                                        }
-
                                        return 1;
                                }
-                               else
-                               {
-                                       return ret;
-                               }
+                               return ret;
                        }
                }
 
@@ -534,6 +577,11 @@ class ModuleSSLOpenSSL : public Module
 
        virtual int OnRawSocketWrite(int fd, const char* buffer, int count)
        {
+               /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
+               if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
+                       return 0;
+
+               errno = EAGAIN;
                issl_session* session = &sessions[fd];
 
                if (!session->sess)
@@ -543,21 +591,33 @@ class ModuleSSLOpenSSL : public Module
                }
 
                session->outbuf.append(buffer, count);
+               MakePollWrite(session);
 
                if (session->status == ISSL_HANDSHAKING)
                {
                        // The handshake isn't finished, try to finish it.
                        if (session->rstat == ISSL_WRITE || session->wstat == ISSL_WRITE)
-                               Handshake(session);
+                       {
+                               if (!Handshake(session))
+                               {
+                                       // Couldn't resume handshake.
+                                       errno = session->status == ISSL_NONE ? EIO : EAGAIN;
+                                       return -1;
+                               }
+                       }
                }
 
                if (session->status == ISSL_OPEN)
                {
                        if (session->rstat == ISSL_WRITE)
+                       {
                                DoRead(session);
+                       }
 
                        if (session->wstat == ISSL_WRITE)
+                       {
                                return DoWrite(session);
+                       }
                }
 
                return 1;
@@ -627,6 +687,7 @@ class ModuleSSLOpenSSL : public Module
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
                                session->rstat = ISSL_WRITE;
+                               MakePollWrite(session);
                                return -1;
                        }
                        else
@@ -647,48 +708,6 @@ class ModuleSSLOpenSSL : public Module
                }
        }
 
-       // :kenny.chatspike.net 320 Om Epy|AFK :is a Secure Connection
-       virtual void OnWhois(userrec* source, userrec* dest)
-       {
-               if (!clientactive)
-                       return;
-
-               // Bugfix, only send this numeric for *our* SSL users
-               if (dest->GetExt("ssl", dummy) || (IS_LOCAL(dest) &&  isin(dest->GetPort(), listenports)))
-               {
-                       ServerInstance->SendWhoisLine(source, dest, 320, "%s %s :is using a secure connection", source->nick, dest->nick);
-               }
-       }
-
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
-       {
-               // check if the linking module wants to know about OUR metadata
-               if (extname == "ssl")
-               {
-                       // check if this user has an swhois field to send
-                       if(user->GetExt(extname, dummy))
-                       {
-                               // call this function in the linking module, let it format the data how it
-                               // sees fit, and send it on its way. We dont need or want to know how.
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, displayable ? "Enabled" : "ON");
-                       }
-               }
-       }
-
-       virtual void OnDecodeMetaData(int target_type, void* target, const std::string &extname, const std::string &extdata)
-       {
-               // check if its our metadata key, and its associated with a user
-               if ((target_type == TYPE_USER) && (extname == "ssl"))
-               {
-                       userrec* dest = (userrec*)target;
-                       // if they dont already have an ssl flag, accept the remote server's
-                       if (!dest->GetExt(extname, dummy))
-                       {
-                               dest->Extend(extname, "ON");
-                       }
-               }
-       }
-
        bool Handshake(issl_session* session)
        {
                int ret;
@@ -706,12 +725,14 @@ class ModuleSSLOpenSSL : public Module
                        {
                                session->rstat = ISSL_READ;
                                session->status = ISSL_HANDSHAKING;
+                               return true;
                        }
                        else if (err == SSL_ERROR_WANT_WRITE)
                        {
                                session->wstat = ISSL_WRITE;
                                session->status = ISSL_HANDSHAKING;
                                MakePollWrite(session);
+                               return true;
                        }
                        else
                        {
@@ -724,11 +745,10 @@ class ModuleSSLOpenSSL : public Module
                {
                        // Handshake complete.
                        // This will do for setting the ssl flag...it could be done earlier if it's needed. But this seems neater.
-                       userrec* u = ServerInstance->FindDescriptor(session->fd);
+                       EventHandler *u = ServerInstance->SE->GetRef(session->fd);
                        if (u)
                        {
-                               if (!u->GetExt("ssl", dummy))
-                                       u->Extend("ssl", "ON");
+                               u->Extend("ssl");
                        }
 
                        session->status = ISSL_OPEN;
@@ -746,31 +766,40 @@ class ModuleSSLOpenSSL : public Module
                return true;
        }
 
-       virtual void OnPostConnect(userrec* user)
+       virtual void OnPostConnect(User* user)
        {
                // This occurs AFTER OnUserConnect so we can be sure the
-               // protocol module has propogated the NICK message.
-               if ((user->GetExt("ssl", dummy)) && (IS_LOCAL(user)))
-               {
-                       // Tell whatever protocol module we're using that we need to inform other servers of this metadata NOW.
-                       std::deque<std::string>* metadata = new std::deque<std::string>;
-                       metadata->push_back(user->nick);
-                       metadata->push_back("ssl");             // The metadata id
-                       metadata->push_back("ON");              // The value to send
-                       Event* event = new Event((char*)metadata,(Module*)this,"send_metadata");
-                       event->Send(ServerInstance);            // Trigger the event. We don't care what module picks it up.
-                       DELETE(event);
-                       DELETE(metadata);
-
-                       VerifyCertificate(&sessions[user->GetFd()], user);
+               // protocol module has propagated the NICK message.
+               if ((user->GetIOHook() == this) && (IS_LOCAL(user)))
+               {
+                       ssl_cert* certdata = VerifyCertificate(&sessions[user->GetFd()], user);
                        if (sessions[user->GetFd()].sess)
-                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick, SSL_get_cipher(sessions[user->GetFd()].sess));
+                               user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->GetFd()].sess));
+
+                       ServerInstance->PI->SendMetaData(user, "ssl", "ON");
+                       if (certdata)
+                               ServerInstance->PI->SendMetaData(user, "ssl_cert", certdata->GetMetaLine().c_str());
                }
        }
 
        void MakePollWrite(issl_session* session)
        {
-               OnRawSocketWrite(session->fd, NULL, 0);
+               //OnRawSocketWrite(session->fd, NULL, 0);
+               EventHandler* eh = ServerInstance->SE->GetRef(session->fd);
+               if (eh)
+               {
+                       ServerInstance->SE->WantWrite(eh);
+               }
+       }
+
+       virtual void OnBufferFlushed(User* user)
+       {
+               if (user->GetIOHook() == this)
+               {
+                       issl_session* session = &sessions[user->GetFd()];
+                       if (session && session->outbuf.size())
+                               OnRawSocketWrite(user->GetFd(), NULL, 0);
+               }
        }
 
        void CloseSession(issl_session* session)
@@ -790,12 +819,13 @@ class ModuleSSLOpenSSL : public Module
                session->inbuf = NULL;
                session->sess = NULL;
                session->status = ISSL_NONE;
+               errno = EIO;
        }
 
-       void VerifyCertificate(issl_session* session, Extensible* user)
+       ssl_cert* VerifyCertificate(issl_session* session, Extensible* user)
        {
                if (!session->sess || !user)
-                       return;
+                       return NULL;
 
                X509* cert;
                ssl_cert* certinfo = new ssl_cert;
@@ -809,50 +839,67 @@ class ModuleSSLOpenSSL : public Module
 
                if (!cert)
                {
-                       certinfo->data.insert(std::make_pair("error","Could not get peer certificate: "+std::string(get_error())));
-                       return;
+                       certinfo->error = "Could not get peer certificate: "+std::string(get_error());
+                       return certinfo;
                }
 
-               certinfo->data.insert(std::make_pair("invalid", SSL_get_verify_result(session->sess) != X509_V_OK ? ConvToStr(1) : ConvToStr(0)));
+               certinfo->invalid = (SSL_get_verify_result(session->sess) != X509_V_OK);
 
                if (SelfSigned)
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(0)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(1)));
+                       certinfo->unknownsigner = false;
+                       certinfo->trusted = true;
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("unknownsigner",ConvToStr(1)));
-                       certinfo->data.insert(std::make_pair("trusted",ConvToStr(0)));
+                       certinfo->unknownsigner = true;
+                       certinfo->trusted = false;
                }
 
-               certinfo->data.insert(std::make_pair("dn",std::string(X509_NAME_oneline(X509_get_subject_name(cert),0,0))));
-               certinfo->data.insert(std::make_pair("issuer",std::string(X509_NAME_oneline(X509_get_issuer_name(cert),0,0))));
+               certinfo->dn = X509_NAME_oneline(X509_get_subject_name(cert),0,0);
+               certinfo->issuer = X509_NAME_oneline(X509_get_issuer_name(cert),0,0);
 
                if (!X509_digest(cert, digest, md, &n))
                {
-                       certinfo->data.insert(std::make_pair("error","Out of memory generating fingerprint"));
+                       certinfo->error = "Out of memory generating fingerprint";
                }
                else
                {
-                       certinfo->data.insert(std::make_pair("fingerprint",irc::hex(md, n)));
+                       certinfo->fingerprint = irc::hex(md, n);
                }
 
-               if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), time(NULL)) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), time(NULL)) == 0))
+               if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
                {
-                       certinfo->data.insert(std::make_pair("error","Not activated, or expired certificate"));
+                       certinfo->error = "Not activated, or expired certificate";
                }
 
                X509_free(cert);
+               return certinfo;
        }
+
+       void Prioritize()
+       {
+               Module* server = ServerInstance->Modules->Find("m_spanningtree.so");
+               ServerInstance->Modules->SetPriority(this, I_OnPostConnect, PRIORITY_AFTER, &server);
+       }
+
 };
 
 static int error_callback(const char *str, size_t len, void *u)
 {
        ModuleSSLOpenSSL* mssl = (ModuleSSLOpenSSL*)u;
-       mssl->PublicInstance->Log(DEFAULT, "SSL error: " + std::string(str, len - 1));
+       mssl->PublicInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
+
+       //
+       // XXX: Remove this line, it causes valgrind warnings...
+       //
+       // MD_update(&m, buf, j);
+       //
+       //
+       // ... ONLY JOKING! :-)
+       //
+
        return 0;
 }
 
-MODULE_INIT(ModuleSSLOpenSSL);
-
+MODULE_INIT(ModuleSSLOpenSSL)