Fix some logically dead code which was found by Coverity.

[user/henk/code/inspircd.git] / src / modules / m_abbreviation.cpp

diff --git a/src/modules/m_abbreviation.cpp b/src/modules/m_abbreviation.cpp
index 35a6082d9df7f3955687254de83c4faf2e681d96..a744f55f66a235d1dd657f01cd9a02e1bade069d 100644 (file)
--- a/src/modules/m_abbreviation.cpp
+++ b/src/modules/m_abbreviation.cpp
@@ -1,67 +1,99 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *   Copyright (C) 2008 Craig Edwards <craigedwards@brainbox.cc>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 #include "inspircd.h"
-#include "wildcard.h"
 
-/* $ModDesc: Provides the ability to abbreviate commands. */
+/* $ModDesc: Provides the ability to abbreviate commands a-la BBC BASIC keywords. */
 
 class ModuleAbbreviation : public Module
 {
-
  public:
-       
-       ModuleAbbreviation(InspIRCd* Me)
-               : Module(Me)
+       void init()
+       {
+               ServerInstance->Modules->Attach(I_OnPreCommand, this);
+       }
+
+       void Prioritize()
        {
-               Me->Modules->Attach(I_OnPreCommand, this);
-               /* Must do this first */
-               Me->Modules->SetPriority(this, I_OnPreCommand, PRIO_FIRST);
+               ServerInstance->Modules->SetPriority(this, I_OnPreCommand, PRIORITY_FIRST);
        }
 
        virtual Version GetVersion()
        {
-               return Version(1,2,0,0,VF_VENDOR,API_VERSION);
+               return Version("Provides the ability to abbreviate commands a-la BBC BASIC keywords.",VF_VENDOR);
        }
 
-       virtual int OnPreCommand(std::string &command, std::vector<std::string> &parameters, User *user, bool validated, const std::string &original_line)
+       virtual ModResult OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line)
        {
                /* Command is already validated, has a length of 0, or last character is not a . */
                if (validated || command.empty() || *command.rbegin() != '.')
-                       return 0;
+                       return MOD_RES_PASSTHRU;
 
                /* Whack the . off the end */
                command.erase(command.end() - 1);
 
-               ServerInstance->Logs->Log("m_abbreviation", DEBUG, "Abbreviated command: %s", command.c_str());
-
+               /* Look for any command that starts with the same characters, if it does, replace the command string with it */
                size_t clen = command.length();
+               std::string foundcommand, matchlist;
+               bool foundmatch = false;
                for (Commandtable::iterator n = ServerInstance->Parser->cmdlist.begin(); n != ServerInstance->Parser->cmdlist.end(); ++n)
                {
                        if (n->first.length() < clen)
                                continue;
 
-                       ServerInstance->Logs->Log("m_abbreviation", DEBUG, "command=%s abbr=%s", command.c_str(), n->first.substr(0, clen).c_str());
                        if (command == n->first.substr(0, clen))
                        {
-                               /* Found the command */
-                               command = n->first;
-                               return false;
+                               if (matchlist.length() > 450)
+                               {
+                                       user->WriteNumeric(420, "%s :Ambiguous abbreviation and too many possible matches.", user->nick.c_str());
+                                       return MOD_RES_DENY;
+                               }
+
+                               if (!foundmatch)
+                               {
+                                       /* Found the command */
+                                       foundcommand = n->first;
+                                       foundmatch = true;
+                               }
+                               else
+                                       matchlist.append(" ").append(n->first);
                        }
                }
 
-               command += '.';
-               return false;
+               /* Ambiguous command, list the matches */
+               if (!matchlist.empty())
+               {
+                       user->WriteNumeric(420, "%s :Ambiguous abbreviation, posssible matches: %s%s", user->nick.c_str(), foundcommand.c_str(), matchlist.c_str());
+                       return MOD_RES_DENY;
+               }
+
+               if (foundcommand.empty())
+               {
+                       /* No match, we have to put the . back again so that the invalid command numeric looks correct. */
+                       command += '.';
+               }
+               else
+               {
+                       command = foundcommand;
+               }
+
+               return MOD_RES_PASSTHRU;
        }
 };