Fix m_chanlog crashing.

[user/henk/code/inspircd.git] / src / modules / m_alias.cpp

diff --git a/src/modules/m_alias.cpp b/src/modules/m_alias.cpp
index 1e117fb3da9493ac3fc3530c83738a90b5a9a523..5a6850f617b2444bc9f76064e4189dc6aa28b58d 100644 (file)
--- a/src/modules/m_alias.cpp
+++ b/src/modules/m_alias.cpp
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -12,9 +12,6 @@
  */
 
 #include "inspircd.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
 #include "wildcard.h"
 
 /* $ModDesc: Provides aliases of commands. */
@@ -77,12 +74,11 @@ class ModuleAlias : public Module
                : Module(Me)
        {
                ReadAliases();
-               pars.resize(127);
-       }
+               pars.resize(MAXPARAMETERS);
+
+               Me->Modules->Attach(I_OnPreCommand, this);
+               Me->Modules->Attach(I_OnRehash, this);
 
-       void Implements(char* List)
-       {
-               List[I_OnPreCommand] = List[I_OnRehash] = 1;
        }
 
        virtual ~ModuleAlias()
@@ -104,12 +100,12 @@ class ModuleAlias : public Module
                std::string word;
 
                for (int j = 0; j < index; j++)
-                       word = ss.GetToken();
+                       ss.GetToken(word);
 
                if (everything_after)
                {
-                       std::string more = "*";
-                       while ((more = ss.GetToken()) != "")
+                       std::string more;
+                       while (ss.GetToken(more))
                        {
                                word.append(" ");
                                word.append(more);
@@ -130,9 +126,9 @@ class ModuleAlias : public Module
                }
        }
 
-       virtual int OnPreCommand(const std::string &command, const char** parameters, int pcnt, userrec *user, bool validated, const std::string &original_line)
+       virtual int OnPreCommand(const std::string &command, const char** parameters, int pcnt, User *user, bool validated, const std::string &original_line)
        {
-               userrec *u = NULL;
+               User *u = NULL;
 
                /* If theyre not registered yet, we dont want
                 * to know.
@@ -183,7 +179,7 @@ class ModuleAlias : public Module
                                {
                                        if (!ServerInstance->ULine(u->server))
                                        {
-                                               ServerInstance->WriteOpers("*** NOTICE -- Service "+Aliases[i].requires+" required by alias "+std::string(Aliases[i].text.c_str())+" is not on a u-lined server, possibly underhanded antics detected!"); 
+                                               ServerInstance->SNO->WriteToSnoMask('A', "NOTICE -- Service "+Aliases[i].requires+" required by alias "+std::string(Aliases[i].text.c_str())+" is not on a u-lined server, possibly underhanded antics detected!"); 
                                                user->WriteServ("401 "+std::string(user->nick)+" "+Aliases[i].requires+" :is an imposter! Please inform an IRC operator as soon as possible.");
                                                return 1;
                                        }
@@ -201,8 +197,8 @@ class ModuleAlias : public Module
                                else
                                {
                                        irc::sepstream commands(Aliases[i].replace_with, '\n');
-                                       std::string command = "*";
-                                       while ((command = commands.GetToken()) != "")
+                                       std::string command;
+                                       while (commands.GetToken(command))
                                        {
                                                DoCommand(command, user, safe);
                                        }
@@ -213,7 +209,7 @@ class ModuleAlias : public Module
                return 0;
        }
 
-       void DoCommand(std::string newline, userrec* user, const std::string &original_line)
+       void DoCommand(std::string newline, User* user, const std::string &original_line)
        {
                for (int v = 1; v < 10; v++)
                {
@@ -251,10 +247,10 @@ class ModuleAlias : public Module
                SearchAndReplace(newline, "\r", "$");
 
                irc::tokenstream ss(newline);
-               const char* parv[127];
+               const char* parv[MAXPARAMETERS];
                int x = 0;
 
-               while (ss.GetToken(pars[x]))
+               while (ss.GetToken(pars[x]) && x < MAXPARAMETERS)
                {
                        parv[x] = pars[x].c_str();
                        x++;
@@ -263,11 +259,10 @@ class ModuleAlias : public Module
                ServerInstance->Parser->CallHandler(parv[0], &parv[1], x-1, user);
        }
  
-       virtual void OnRehash(userrec* user, const std::string &parameter)
+       virtual void OnRehash(User* user, const std::string &parameter)
        {
                ReadAliases();
        }
 };
 
-MODULE_INIT(ModuleAlias);
-
+MODULE_INIT(ModuleAlias)