]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_callerid.cpp
MetaData rework
[user/henk/code/inspircd.git] / src / modules / m_callerid.cpp
index 9eb7ff37d517c3459929a5f4d47fda65eb0f83ef..29ba7fd6022f2c113a1e7365519f35df5012115f 100644 (file)
@@ -1,12 +1,19 @@
-#include "inspircd.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
+/*       +------------------------------------+
+ *       | Inspire Internet Relay Chat Daemon |
+ *       +------------------------------------+
+ *
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
+ *
+ * This program is free but copyrighted software; see
+ *            the file COPYING for details.
+ *
+ * ---------------------------------------------------
+ */
 
+#include "inspircd.h"
 #include <set>
-
 #include <sstream>
-
 #include <algorithm>
 
 /* $ModDesc: Implementation of callerid (umode +g & /accept, ala hybrid etc) */
@@ -15,8 +22,15 @@ class callerid_data : public classbase
 {
  public:
        time_t lastnotify;
+
+       /** Users I accept messages from
+        */
        std::set<User*> accepting;
 
+       /** Users who list me as accepted
+        */
+       std::list<callerid_data *> wholistsme;
+
        callerid_data() : lastnotify(0) { }
        callerid_data(const std::string& str, InspIRCd* ServerInstance)
        {
@@ -32,11 +46,8 @@ class callerid_data : public classbase
                        {
                                continue;
                        }
-                       User* u = ServerInstance->FindUUID(tok);
-                       if (!u)
-                       {
-                               u = ServerInstance->FindNick(tok);
-                       }
+
+                       User *u = ServerInstance->FindNick(tok);
                        if (!u)
                        {
                                continue;
@@ -45,20 +56,25 @@ class callerid_data : public classbase
                }
        }
 
-       std::string ToString(bool displayable) const
+       std::string ToString(Module* proto) const
        {
                std::ostringstream oss;
                oss << lastnotify;
                for (std::set<User*>::const_iterator i = accepting.begin(); i != accepting.end(); ++i)
                {
                        // Encode UIDs.
-                       oss << "," << (displayable ? (*i)->nick : (*i)->uuid);
+                       oss << "," << proto->ProtoTranslate(*i);
                }
                oss << std::ends;
                return oss.str();
        }
 };
 
+/** Retrieves the callerid information for a given user record
+ * @param who The user to retrieve callerid information for
+ * @param extend true to add callerid information if it doesn't already exist, false to return NULL if it doesn't exist
+ * @return NULL if extend is false and it doesn't exist, a callerid_data instance otherwise.
+ */
 callerid_data* GetData(User* who, bool extend = true)
 {
        callerid_data* dat;
@@ -85,28 +101,29 @@ void RemoveData(User* who)
        if (!dat)
                return;
 
-       who->Shrink("callerid_data");
-       delete dat;
-}
-
-void RemoveFromAllAccepts(InspIRCd* ServerInstance, User* who)
-{
-       for (user_hash::iterator i = ServerInstance->Users->clientlist->begin(); i != ServerInstance->Users->clientlist->end(); ++i)
+       // We need to walk the list of users on our accept list, and remove ourselves from their wholistsme.
+       for (std::set<User *>::iterator it = dat->accepting.begin(); it != dat->accepting.end(); it++)
        {
-               callerid_data* dat = GetData(i->second, false);
-
-               if (!dat)
-                       continue;
-
-               std::set<User*>::iterator iter = dat->accepting.find(who);
+               callerid_data *targ = GetData(*it, false);
 
-               if (iter == dat->accepting.end())
-                       continue;
+               if (!targ)
+                       continue; // shouldn't happen, but oh well.
 
-               dat->accepting.erase(iter);
+               for (std::list<callerid_data *>::iterator it2 = targ->wholistsme.begin(); it2 != targ->wholistsme.end(); it2++)
+               {
+                       if (*it2 == dat)
+                       {
+                               targ->wholistsme.erase(it2);
+                               break;
+                       }
+               }
        }
+
+       who->Shrink("callerid_data");
+       delete dat;
 }
 
+
 class User_g : public SimpleUserModeHandler
 {
 public:
@@ -217,6 +234,7 @@ public:
 
        bool AddAccept(User* user, User* whotoadd, bool quiet)
        {
+               // Add this user to my accept list first, so look me up..
                callerid_data* dat = GetData(user, true);
                if (dat->accepting.size() >= maxaccepts)
                {
@@ -232,11 +250,18 @@ public:
 
                        return false;
                }
+
+               // Now, look them up, and add me to their list
+               callerid_data *targ = GetData(whotoadd, true);
+               targ->wholistsme.push_back(dat);
+
+               user->WriteServ("NOTICE %s :%s is now on your accept list", user->nick.c_str(), whotoadd->nick.c_str());
                return true;
        }
 
        bool RemoveAccept(User* user, User* whotoremove, bool quiet)
        {
+               // Remove them from my list, so look up my list..
                callerid_data* dat = GetData(user, false);
                if (!dat)
                {
@@ -253,7 +278,28 @@ public:
 
                        return false;
                }
+
                dat->accepting.erase(i);
+
+               // Look up their list to remove me.
+               callerid_data *dat2 = GetData(whotoremove, false);
+               if (!dat2)
+               {
+                       // How the fuck is this possible.
+                       return false;
+               }
+
+               for (std::list<callerid_data *>::iterator it = dat2->wholistsme.begin(); it != dat2->wholistsme.end(); it++)
+               {
+                       // Found me!
+                       if (*it == dat)
+                       {
+                               dat2->wholistsme.erase(it);
+                               break;
+                       }
+               }
+
+               user->WriteServ("NOTICE %s :%s is no longer on your accept list", user->nick.c_str(), whotoremove->nick.c_str());
                return true;
        }
 };
@@ -261,8 +307,8 @@ public:
 class ModuleCallerID : public Module
 {
 private:
-       CommandAccept *mycommand;
-       User_g* myumode;
+       CommandAccept mycommand;
+       User_g myumode;
 
        // Configuration variables:
        unsigned int maxaccepts; // Maximum ACCEPT entries.
@@ -270,38 +316,48 @@ private:
        bool tracknick; // Allow ACCEPT entries to update with nick changes.
        unsigned int notify_cooldown; // Seconds between notifications.
 
-public:
-       ModuleCallerID(InspIRCd* Me) : Module(Me)
+       /** Removes a user from all accept lists
+        * @param who The user to remove from accepts
+        */
+       void RemoveFromAllAccepts(User* who)
        {
-               OnRehash(NULL, "");
-               mycommand = new CommandAccept(ServerInstance, maxaccepts);
-               myumode = new User_g(ServerInstance);
+               // First, find the list of people who have me on accept
+               callerid_data *userdata = GetData(who, false);
+               if (!userdata)
+                       return;
 
-               if (!ServerInstance->Modes->AddMode(myumode))
+               // Iterate over the list of people who accept me, and remove all entries
+               for (std::list<callerid_data *>::iterator it = userdata->wholistsme.begin(); it != userdata->wholistsme.end(); it++)
                {
-                       delete mycommand;
-                       delete myumode;
-                       throw ModuleException("Could not add usermode +g");
-               }
-               try
-               {
-                       ServerInstance->AddCommand(mycommand);
-               }
-               catch (const ModuleException& e)
-               {
-                       delete mycommand;
-                       delete myumode;
-                       throw ModuleException("Could not add command!");
+                       callerid_data *dat = *(it);
+
+                       // Find me on their callerid list
+                       std::set<User *>::iterator it2 = dat->accepting.find(who);
+
+                       if (it2 != dat->accepting.end())
+                               dat->accepting.erase(it2);
                }
 
+               userdata->wholistsme.clear();
+       }
+
+public:
+       ModuleCallerID(InspIRCd* Me) : Module(Me), mycommand(Me, maxaccepts), myumode(Me)
+       {
+               OnRehash(NULL);
+
+               if (!ServerInstance->Modes->AddMode(&myumode))
+                       throw ModuleException("Could not add usermode +g");
+
+               ServerInstance->AddCommand(&mycommand);
+
                Implementation eventlist[] = { I_OnRehash, I_OnUserPreNick, I_OnUserQuit, I_On005Numeric, I_OnUserPreNotice, I_OnUserPreMessage, I_OnCleanup };
                ServerInstance->Modules->Attach(eventlist, this, 7);
        }
 
        virtual ~ModuleCallerID()
        {
-               ServerInstance->Modes->DelMode(myumode);
-               delete myumode;
+               ServerInstance->Modes->DelMode(&myumode);
        }
 
        virtual Version GetVersion()
@@ -323,17 +379,24 @@ public:
                        return 0;
 
                callerid_data* dat = GetData(dest, true);
-               std::set<User*>::iterator i = dat->accepting.find(dest);
+               std::set<User*>::iterator i = dat->accepting.find(user);
 
                if (i == dat->accepting.end())
                {
-                       time_t now = time(NULL);
+                       time_t now = ServerInstance->Time();
                        /* +g and *not* accepted */
                        user->WriteNumeric(716, "%s %s :is in +g mode (server-side ignore).", user->nick.c_str(), dest->nick.c_str());
                        if (now > (dat->lastnotify + (time_t)notify_cooldown))
                        {
                                user->WriteNumeric(717, "%s %s :has been informed that you messaged them.", user->nick.c_str(), dest->nick.c_str());
-                               dest->WriteNumeric(718, "%s %s %s@%s :is messaging you, and you have umode +g", dest->nick.c_str(), user->nick.c_str(), user->ident.c_str(), user->dhost.c_str());
+                               if (IS_LOCAL(dest))
+                               {
+                                       dest->WriteNumeric(718, "%s %s %s@%s :is messaging you, and you have umode +g. Use /ACCEPT +%s to allow.", dest->nick.c_str(), user->nick.c_str(), user->ident.c_str(), user->dhost.c_str(), user->nick.c_str());
+                               }
+                               else
+                               {
+                                       ServerInstance->PI->PushToClient(dest, std::string("::") + ServerInstance->Config->ServerName + " 718 " + dest->nick + " " + user->nick + " " + user->ident + "@" + user->dhost + " :is messaging you,  and you have umode +g. Use /ACCEPT +" + user->nick + " to allow.");
+                               }
                                dat->lastnotify = now;
                        }
                        return 1;
@@ -367,24 +430,21 @@ public:
                RemoveData(u);
        }
 
-       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string& extname, bool displayable)
+       virtual void OnSyncUser(User* user, Module* proto, void* opaque)
        {
-               if (extname == "callerid_data")
+               callerid_data* dat = GetData(user, false);
+               if (dat)
                {
-                       callerid_data* dat = GetData(user, false);
-                       if (dat)
-                       {
-                               std::string str = dat->ToString(displayable);
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, str);
-                       }
+                       std::string str = dat->ToString(proto);
+                       proto->ProtoSendMetaData(opaque, user, "callerid_data", str);
                }
        }
 
-       virtual void OnDecodeMetaData(int target_type, void* target, const std::string& extname, const std::string& extdata)
+       virtual void OnDecodeMetaData(Extensible* target, const std::string& extname, const std::string& extdata)
        {
-               if (target_type == TYPE_USER && extname == "callerid_data")
+               User* u = dynamic_cast<User*>(target);
+               if (u && extname == "callerid_data")
                {
-                       User* u = (User*)target;
                        callerid_data* dat = new callerid_data(extdata, ServerInstance);
                        u->Extend("callerid_data", dat);
                }
@@ -393,17 +453,17 @@ public:
        virtual int OnUserPreNick(User* user, const std::string& newnick)
        {
                if (!tracknick)
-                       RemoveFromAllAccepts(ServerInstance, user);
+                       RemoveFromAllAccepts(user);
                return 0;
        }
 
        virtual void OnUserQuit(User* user, const std::string& message, const std::string& oper_message)
        {
+               RemoveFromAllAccepts(user);
                RemoveData(user);
-               RemoveFromAllAccepts(ServerInstance, user);
        }
 
-       virtual void OnRehash(User* user, const std::string& parameter)
+       virtual void OnRehash(User* user)
        {
                ConfigReader Conf(ServerInstance);
                maxaccepts = Conf.ReadInteger("callerid", "maxaccepts", "16", 0, true);