Remove the size argument from IsChannel and IsNick.

[user/henk/code/inspircd.git] / src / modules / m_cap.cpp

diff --git a/src/modules/m_cap.cpp b/src/modules/m_cap.cpp
index 36674b9c5a41c41f5f88629e65d3a2cadcaca470..1d165f9355e427db5cfff61310c1b4d872eab87e 100644 (file)
--- a/src/modules/m_cap.cpp
+++ b/src/modules/m_cap.cpp
@@ -19,7 +19,7 @@
 
 
 #include "inspircd.h"
-#include "m_cap.h"
+#include "modules/cap.h"
 
 /* $ModDesc: Provides the CAP negotiation mechanism seen in ratbox-derived ircds */
 
@@ -55,19 +55,14 @@ class CommandCAP : public Command
 
                if (subcommand == "REQ")
                {
-                       CapEvent Data(creator, "cap_req");
-
-                       Data.type = subcommand;
-                       Data.user = user;
-                       Data.creator = this->creator;
-
                        if (parameters.size() < 2)
                                return CMD_FAILURE;
 
+                       CapEvent Data(creator, user, CapEvent::CAPEVENT_REQ);
+
                        // tokenize the input into a nice list of requested caps
-                       std::string param = parameters[1];
                        std::string cap_;
-                       irc::spacesepstream cap_stream(param);
+                       irc::spacesepstream cap_stream(parameters[1]);
 
                        while (cap_stream.GetToken(cap_))
                        {
@@ -95,11 +90,7 @@ class CommandCAP : public Command
                }
                else if ((subcommand == "LS") || (subcommand == "LIST"))
                {
-                       CapEvent Data(creator, subcommand == "LS" ? "cap_ls" : "cap_list");
-
-                       Data.type = subcommand;
-                       Data.user = user;
-                       Data.creator = this->creator;
+                       CapEvent Data(creator, user, subcommand == "LS" ? CapEvent::CAPEVENT_LS : CapEvent::CAPEVENT_LIST);
 
                        reghold.set(user, 1);
                        Data.Send();
@@ -107,31 +98,28 @@ class CommandCAP : public Command
                        std::string Result;
                        if (Data.wanted.size() > 0)
                                Result = irc::stringjoiner(" ", Data.wanted, 0, Data.wanted.size() - 1).GetJoined();
-                       else
-                               Result = "";
 
                        user->WriteServ("CAP %s %s :%s", user->nick.c_str(), subcommand.c_str(), Result.c_str());
                }
                else if (subcommand == "CLEAR")
                {
-                       CapEvent Data(creator, "cap_clear");
-
-                       Data.type = subcommand;
-                       Data.user = user;
-                       Data.creator = this->creator;
+                       CapEvent Data(creator, user, CapEvent::CAPEVENT_CLEAR);
 
                        reghold.set(user, 1);
                        Data.Send();
 
-                       std::string Result = irc::stringjoiner(" ", Data.ack, 0, Data.ack.size() - 1).GetJoined();
+                       std::string Result;
+                       if (!Data.ack.empty())
+                               Result = irc::stringjoiner(" ", Data.ack, 0, Data.ack.size() - 1).GetJoined();
                        user->WriteServ("CAP %s ACK :%s", user->nick.c_str(), Result.c_str());
                }
                else
                {
                        user->WriteNumeric(ERR_INVALIDCAPSUBCOMMAND, "%s %s :Invalid CAP subcommand", user->nick.c_str(), subcommand.c_str());
+                       return CMD_FAILURE;
                }
 
-               return CMD_FAILURE;
+               return CMD_SUCCESS;
        }
 };
 
@@ -142,14 +130,18 @@ class ModuleCAP : public Module
        ModuleCAP()
                : cmd(this)
        {
-               ServerInstance->AddCommand(&cmd);
-               ServerInstance->Extensions.Register(&cmd.reghold);
+       }
+
+       void init() CXX11_OVERRIDE
+       {
+               ServerInstance->Modules->AddService(cmd);
+               ServerInstance->Modules->AddService(cmd.reghold);
 
                Implementation eventlist[] = { I_OnCheckReady };
-               ServerInstance->Modules->Attach(eventlist, this, 1);
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
-       ModResult OnCheckReady(LocalUser* user)
+       ModResult OnCheckReady(LocalUser* user) CXX11_OVERRIDE
        {
                /* Users in CAP state get held until CAP END */
                if (cmd.reghold.get(user))
@@ -158,15 +150,10 @@ class ModuleCAP : public Module
                return MOD_RES_PASSTHRU;
        }
 
-       ~ModuleCAP()
-       {
-       }
-
-       Version GetVersion()
+       Version GetVersion() CXX11_OVERRIDE
        {
                return Version("Client CAP extension support", VF_VENDOR);
        }
 };
 
 MODULE_INIT(ModuleCAP)
-