Reasonably sized fix - when adding modes in modules, be sure to check the return...

[user/henk/code/inspircd.git] / src / modules / m_censor.cpp

diff --git a/src/modules/m_censor.cpp b/src/modules/m_censor.cpp
index 9d2a26191d5b72e522df767e1a8f726bb49bf739..4df2db95e4ec38e2c6d8e43720f28e8198126bcc 100644 (file)
--- a/src/modules/m_censor.cpp
+++ b/src/modules/m_censor.cpp
@@ -99,8 +99,8 @@ class ModuleCensor : public Module
                OnRehash("");
                cu = new CensorUser(ServerInstance);
                cc = new CensorChannel(ServerInstance);
-               ServerInstance->AddMode(cu, 'G');
-               ServerInstance->AddMode(cc, 'G');
+               if (!ServerInstance->AddMode(cu, 'G') || !ServerInstance->AddMode(cc, 'G'))
+                       throw ModuleException("Could not add new modes!");
        }
 
        void Implements(char* List)
@@ -118,11 +118,11 @@ class ModuleCensor : public Module
 
        virtual void ReplaceLine(irc::string &text, irc::string pattern, irc::string replace)
        {
-               if ((pattern != "") && (text != ""))
+               if ((!pattern.empty()) && (!text.empty()))
                {
-                       while (text.find(pattern) != irc::string::npos)
+                       std::string::size_type pos;
+                       while ((pos = text.find(pattern)) != irc::string::npos)
                        {
-                               int pos = text.find(pattern);
                                text.erase(pos,pattern.length());
                                text.insert(pos,replace);
                        }
@@ -133,29 +133,24 @@ class ModuleCensor : public Module
        virtual int OnUserPreMessage(userrec* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list)
        {
                bool active = false;
+
+               if (target_type == TYPE_USER)
+                       active = ((userrec*)dest)->IsModeSet('G');
+               else if (target_type == TYPE_CHANNEL)
+                       active = ((chanrec*)dest)->IsModeSet('G');
+
+               if (!active)
+                       return 0;
+
                irc::string text2 = text.c_str();
                for (censor_t::iterator index = censors.begin(); index != censors.end(); index++)
                { 
                        if (text2.find(index->first) != irc::string::npos)
                        {
-                               if (target_type == TYPE_USER)
-                               {
-                                       userrec* t = (userrec*)dest;
-                                       active = t->IsModeSet('G');
-                               }
-                               else if (target_type == TYPE_CHANNEL)
-                               {
-                                       chanrec* t = (chanrec*)dest;
-                                       active = t->IsModeSet('G');
-                               }
-                               
-                               if (active)
-                               {
-                                       this->ReplaceLine(text2,index->first,index->second);
-                                       text = text2.c_str();
-                               }
+                               this->ReplaceLine(text2,index->first,index->second);
                        }
                }
+               text = text2.c_str();
                return 0;
        }