]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_cgiirc.cpp
Clean up challenge generation to not include character 0x7F, and fix some other thing...
[user/henk/code/inspircd.git] / src / modules / m_cgiirc.cpp
index 06da29bc0c454130f691cfed033966a0d3b20020..1467d0f6854daee9ce60b61dc592ae3573399711 100644 (file)
@@ -3,7 +3,7 @@
  *       +------------------------------------+
  *
  *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
@@ -56,7 +56,7 @@ class CommandWebirc : public Command
        CGIHostlist Hosts;
        bool notify;
        public:
-               CommandWebirc(InspIRCd* Instance, CGIHostlist &cHosts, bool bnotify) : Command(Instance, "WEBIRC", 0, 4, true), Hosts(cHosts), notify(bnotify)
+               CommandWebirc(InspIRCd* Instance, bool bnotify) : Command(Instance, "WEBIRC", 0, 4, true), notify(bnotify)
                {
                        this->source = "m_cgiirc.so";
                        this->syntax = "password client hostname ip";
@@ -75,15 +75,22 @@ class CommandWebirc : public Command
                                                user->Extend("cgiirc_realhost", new std::string(user->host));
                                                user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
                                                if (notify)
-                                                       ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", user->nick.c_str(), user->host.c_str(), parameters[2].c_str(), user->host.c_str());
+                                                       ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", user->nick.c_str(), user->host.c_str(), parameters[2].c_str(), user->host.c_str());
                                                user->Extend("cgiirc_webirc_hostname", new std::string(parameters[2]));
                                                user->Extend("cgiirc_webirc_ip", new std::string(parameters[3]));
                                                return CMD_LOCALONLY;
                                        }
                                }
                        }
+
+                       ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s tried to use WEBIRC, but didn't match any configured webirc blocks.", user->GetFullRealHost().c_str());
                        return CMD_FAILURE;
                }
+
+               void SetHosts(CGIHostlist &phosts)
+               {
+                       this->Hosts = phosts;
+               }
 };
 
 
@@ -99,21 +106,18 @@ class CGIResolver : public Resolver
        CGIResolver(Module* me, InspIRCd* Instance, bool NotifyOpers, const std::string &source, bool forward, User* u, int userfd, const std::string &type, bool &cached)
                : Resolver(Instance, source, forward ? DNS_QUERY_A : DNS_QUERY_PTR4, cached, me), typ(type), theirfd(userfd), them(u), notify(NotifyOpers) { }
 
-       virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached, int resultnum = 0)
+       virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached)
        {
-               if (resultnum)
-                       return;
-
                /* Check the user still exists */
                if ((them) && (them == ServerInstance->SE->GetRef(theirfd)))
                {
                        if (notify)
-                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", them->nick.c_str(), them->host.c_str(), result.c_str(), typ.c_str());
+                               ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", them->nick.c_str(), them->host.c_str(), result.c_str(), typ.c_str());
 
                        them->host.assign(result,0, 64);
                        them->dhost.assign(result, 0, 64);
                        if (querytype)
-                               them->SetSockAddr(them->GetProtocolFamily(), result.c_str(), them->GetPort());
+                               them->SetClientIP(result.c_str());
                        them->ident.assign("~cgiirc", 0, 8);
                        them->InvalidateCache();
                        them->CheckLines(true);
@@ -125,7 +129,7 @@ class CGIResolver : public Resolver
                if ((them) && (them == ServerInstance->SE->GetRef(theirfd)))
                {
                        if (notify)
-                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but their host can't be resolved from their %s!", them->nick.c_str(), them->host.c_str(), typ.c_str());
+                               ServerInstance->SNO->WriteToSnoMask('a', "Connecting user %s detected as using CGI:IRC (%s), but their host can't be resolved from their %s!", them->nick.c_str(), them->host.c_str(), typ.c_str());
                }
        }
 
@@ -142,9 +146,8 @@ class ModuleCgiIRC : public Module
 public:
        ModuleCgiIRC(InspIRCd* Me) : Module(Me)
        {
-
-               OnRehash(NULL,"");
-               mycommand = new CommandWebirc(Me, Hosts, NotifyOpers);
+               mycommand = new CommandWebirc(Me, NotifyOpers);
+               OnRehash(NULL);
                ServerInstance->AddCommand(mycommand);
 
                Implementation eventlist[] = { I_OnRehash, I_OnUserRegister, I_OnCleanup, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUserDisconnect, I_OnUserConnect };
@@ -154,10 +157,10 @@ public:
 
        virtual void Prioritize()
        {
-               ServerInstance->Modules->SetPriority(this, I_OnUserConnect, PRIO_FIRST);
+               ServerInstance->Modules->SetPriority(this, I_OnUserConnect, PRIORITY_FIRST);
        }
 
-       virtual void OnRehash(User* user, const std::string &parameter)
+       virtual void OnRehash(User* user)
        {
                ConfigReader Conf(ServerInstance);
                Hosts.clear();
@@ -204,6 +207,8 @@ public:
                                continue;
                        }
                }
+
+               mycommand->SetHosts(Hosts);
        }
 
        virtual void OnCleanup(int target_type, void* item)
@@ -313,7 +318,7 @@ public:
                if(user->GetExt("cgiirc_webirc_ip", webirc_ip))
                {
                        ServerInstance->Users->RemoveCloneCounts(user);
-                       user->SetSockAddr(user->GetProtocolFamily(), webirc_ip->c_str(), user->GetPort());
+                       user->SetClientIP(webirc_ip->c_str());
                        delete webirc_ip;
                        user->InvalidateCache();
                        user->Shrink("cgiirc_webirc_ip");
@@ -336,15 +341,7 @@ public:
 
                        bool valid = false;
                        ServerInstance->Users->RemoveCloneCounts(user);
-#ifdef IPV6
-                       if (user->GetProtocolFamily() == AF_INET6)
-                               valid = (inet_pton(AF_INET6, user->password.c_str(), &((sockaddr_in6*)user->ip)->sin6_addr) > 0);
-                       else
-                               valid = (inet_aton(user->password.c_str(), &((sockaddr_in*)user->ip)->sin_addr));
-#else
-                       if (inet_aton(user->password.c_str(), &((sockaddr_in*)user->ip)->sin_addr))
-                               valid = true;
-#endif
+                       valid = user->SetClientIP(user->password.c_str());
                        ServerInstance->Users->AddLocalClone(user);
                        ServerInstance->Users->AddGlobalClone(user);
                        user->CheckClass();
@@ -353,7 +350,7 @@ public:
                        {
                                /* We were given a IP in the password, we don't do DNS so they get this is as their host as well. */
                                if(NotifyOpers)
-                                       ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from PASS", user->nick.c_str(), user->host.c_str(), user->password.c_str());
+                                       ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from PASS", user->nick.c_str(), user->host.c_str(), user->password.c_str());
                        }
                        else
                        {
@@ -368,7 +365,7 @@ public:
                                catch (...)
                                {
                                        if (NotifyOpers)
-                                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
+                                               ServerInstance->SNO->WriteToSnoMask('a', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
                                }
                        }
 
@@ -381,10 +378,9 @@ public:
 
        bool CheckIdent(User* user)
        {
-               int ip[4];
                const char* ident;
-               char newip[16];
                int len = user->ident.length();
+               in_addr newip;
 
                if(len == 8)
                        ident = user->ident.c_str();
@@ -393,38 +389,36 @@ public:
                else
                        return false;
 
-               for(int i = 0; i < 4; i++)
-                       if(!HexToInt(ip[i], ident + i*2))
-                               return false;
-
-               snprintf(newip, 16, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]);
+               errno = 0;
+               unsigned long ipaddr = strtoul(ident, NULL, 16);
+               if (errno)
+                       return false;
+               newip.s_addr = htonl(ipaddr);
+               char* newipstr = inet_ntoa(newip);
 
                user->Extend("cgiirc_realhost", new std::string(user->host));
                user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
                ServerInstance->Users->RemoveCloneCounts(user);
-               user->SetSockAddr(user->GetProtocolFamily(), newip, user->GetPort());
+               user->SetClientIP(newipstr);
                ServerInstance->Users->AddLocalClone(user);
                ServerInstance->Users->AddGlobalClone(user);
                user->CheckClass();
+               user->host = newipstr;
+               user->dhost = newipstr;
+               user->ident.assign("~cgiirc", 0, 8);
                try
                {
-                       user->host.assign(newip, 0, 16);
-                       user->dhost.assign(newip, 0, 16);
-                       user->ident.assign("~cgiirc", 0, 8);
 
                        bool cached;
-                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, newip, false, user, user->GetFd(), "IDENT", cached);
+                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, newipstr, false, user, user->GetFd(), "IDENT", cached);
                        ServerInstance->AddResolver(r, cached);
                }
                catch (...)
                {
-                       user->host.assign(newip, 0, 16);
-                       user->dhost.assign(newip, 0, 16);
-                       user->ident.assign("~cgiirc", 0, 8);
                        user->InvalidateCache();
 
                        if(NotifyOpers)
-                                ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
+                                ServerInstance->SNO->WriteToSnoMask('a', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
                }
 
                return true;
@@ -486,20 +480,6 @@ public:
                return true;
        }
 
-       bool HexToInt(int &out, const char* in)
-       {
-               char ip[3];
-               ip[0] = in[0];
-               ip[1] = in[1];
-               ip[2] = 0;
-               out = strtol(ip, NULL, 16);
-
-               if(out > 255 || out < 0)
-                       return false;
-
-               return true;
-       }
-
        virtual ~ModuleCgiIRC()
        {
        }